license_finder 1.0.0.0-java → 1.1.1-java

data/spec/fixtures/Podfile

@@ -0,0 +1,3 @@
+platform :ios, '7.0'
+pod 'JSONKit',       '~> 1.4'
+pod 'ABTest', '~> 0.0.5'

data/spec/lib/license_finder/cli_spec.rb

@@ -5,7 +5,7 @@ module LicenseFinder
     describe Dependencies do
       describe "add" do
         it "adds a dependency" do
-          DependencyManager.should_receive(:create_manually_managed).with("MIT", "js_dep", "1.2.3")
+          DependencyManager.should_receive(:manually_add).with("MIT", "js_dep", "1.2.3")
 
           silence_stdout do
             subject.add("MIT", "js_dep", "1.2.3")
@@ -13,7 +13,7 @@ module LicenseFinder
         end
 
         it "does not require a version" do
-          DependencyManager.should_receive(:create_manually_managed).with("MIT", "js_dep", nil)
+          DependencyManager.should_receive(:manually_add).with("MIT", "js_dep", nil)
 
           silence_stdout do
             subject.add("MIT", "js_dep")
@@ -21,18 +21,18 @@ module LicenseFinder
         end
 
         it "has an --approve option to approve the added dependency" do
-          DependencyManager.should_receive(:create_manually_managed).with("MIT", "js_dep", "1.2.3")
-          DependencyManager.should_receive(:approve!).with("js_dep")
+          DependencyManager.should_receive(:manually_add).with("MIT", "js_dep", "1.2.3")
+          DependencyManager.should_receive(:approve!).with("js_dep", "Julian", "We really need this")
 
           silence_stdout do
-            LicenseFinder::CLI::Main.start(["dependencies", "add", "--approve", "MIT", "js_dep", "1.2.3"])
+            Main.start(["dependencies", "add", "--approve", "--approver", "Julian", "--message", "We really need this", "MIT", "js_dep", "1.2.3"])
           end
         end
       end
 
       describe "remove" do
         it "removes a dependency" do
-          DependencyManager.should_receive(:destroy_manually_managed).with("js_dep")
+          DependencyManager.should_receive(:manually_remove).with("js_dep")
           silence_stdout do
             subject.remove("js_dep")
           end
@@ -57,7 +57,7 @@ module LicenseFinder
         it "adds the specified license to the whitelist" do
           config.whitelist.should_receive(:push).with("test")
           config.should_receive(:save)
-          Reporter.should_receive(:write_reports)
+          expect(DependencyManager).to receive(:sync_with_package_managers)
 
           silence_stdout do
             subject.add("test")
@@ -68,7 +68,7 @@ module LicenseFinder
           config.whitelist.should_receive(:push).with("test")
           config.whitelist.should_receive(:push).with("rest")
           config.should_receive(:save)
-          Reporter.should_receive(:write_reports)
+          expect(DependencyManager).to receive(:sync_with_package_managers)
 
           silence_stdout do
             subject.add("test", "rest")
@@ -80,7 +80,7 @@ module LicenseFinder
         it "removes the specified license from the whitelist" do
           config.should_receive(:save)
           config.whitelist.should_receive(:delete).with("test")
-          Reporter.should_receive(:write_reports)
+          expect(DependencyManager).to receive(:sync_with_package_managers)
 
           silence_stdout do
 
@@ -92,7 +92,7 @@ module LicenseFinder
           config.should_receive(:save)
           config.whitelist.should_receive(:delete).with("test")
           config.whitelist.should_receive(:delete).with("rest")
-          Reporter.should_receive(:write_reports)
+          expect(DependencyManager).to receive(:sync_with_package_managers)
 
           silence_stdout do
             subject.remove("test", "rest")
@@ -108,7 +108,7 @@ module LicenseFinder
         it "sets the project name" do
           config.should_receive(:save)
           config.project_name.should_not eq("new_project_name")
-          Reporter.should_receive(:write_reports)
+          expect(DependencyManager).to receive(:sync_with_package_managers)
 
           silence_stdout do
             subject.set("new_project_name")
@@ -124,11 +124,9 @@ module LicenseFinder
 
       describe "list" do
         it "shows the ignored groups in the standard output" do
-          config.should_receive(:ignore_groups).and_return([])
+          config.should_receive(:ignore_groups).and_return(['development'])
 
-          silence_stdout do
-            subject.list
-          end
+          expect(capture_stdout { subject.list }).to match /development/
         end
       end
 
@@ -136,7 +134,7 @@ module LicenseFinder
         it "adds the specified group to the ignored groups list" do
           config.ignore_groups.should_receive(:push).with("test")
           config.should_receive(:save)
-          Reporter.should_receive(:write_reports)
+          expect(DependencyManager).to receive(:sync_with_package_managers)
 
           silence_stdout do
             subject.add("test")
@@ -148,7 +146,51 @@ module LicenseFinder
         it "removes the specified group from the ignored groups list" do
           config.ignore_groups.should_receive(:delete).with("test")
           config.should_receive(:save)
-          Reporter.should_receive(:write_reports)
+          expect(DependencyManager).to receive(:sync_with_package_managers)
+
+          silence_stdout do
+            subject.remove("test")
+          end
+        end
+      end
+    end
+
+    describe IgnoredDependencies do
+      let(:config) { LicenseFinder.config }
+
+      describe "list" do
+        context "when there is at least one ignored dependency" do
+          it "shows the ignored dependencies" do
+            expect(config).to receive(:ignore_dependencies).and_return(['bundler'])
+            expect(capture_stdout { subject.list }).to match /bundler/
+          end
+        end
+
+        context "when there are no ignored dependencies" do
+          it "prints '(none)'" do
+            expect(config).to receive(:ignore_dependencies).and_return([])
+            expect(capture_stdout { subject.list }).to match /\(none\)/
+          end
+        end
+      end
+
+      describe "add" do
+        it "adds the specified group to the ignored groups list" do
+          config.ignore_dependencies.should_receive(:push).with("test")
+          config.should_receive(:save)
+          expect(DependencyManager).to receive(:sync_with_package_managers)
+
+          silence_stdout do
+            subject.add("test")
+          end
+        end
+      end
+
+      describe "remove" do
+        it "removes the specified group from the ignored groups list" do
+          config.ignore_dependencies.should_receive(:delete).with("test")
+          config.should_receive(:save)
+          expect(DependencyManager).to receive(:sync_with_package_managers)
 
           silence_stdout do
             subject.remove("test")
@@ -191,7 +233,7 @@ module LicenseFinder
 
       describe "#approve" do
         it "approves the requested gem" do
-          DependencyManager.should_receive(:approve!).with("foo")
+          DependencyManager.should_receive(:approve!).with("foo", nil, nil)
 
           silence_stdout do
             subject.approve 'foo'
@@ -199,8 +241,8 @@ module LicenseFinder
         end
 
         it "approves multiple gem" do
-          DependencyManager.should_receive(:approve!).with("foo")
-          DependencyManager.should_receive(:approve!).with("bar")
+          DependencyManager.should_receive(:approve!).with("foo", nil, nil)
+          DependencyManager.should_receive(:approve!).with("bar", nil, nil)
 
           silence_stdout do
             subject.approve 'foo', 'bar'
@@ -211,9 +253,15 @@ module LicenseFinder
           DependencyManager.should_not_receive(:approve!)
 
           silence_stdout do
-            subject.should_receive(:say).with(/Warning/, :red)
-            subject.should_not_receive(:say).with(/dependency has been approved/, anything)
-            subject.approve
+            expect { subject.approve }.to raise_error(ArgumentError)
+          end
+        end
+
+        it "sets approver and approval message" do
+          DependencyManager.should_receive(:approve!).with("foo", "Julian", "We really need this")
+
+          silence_stdout do
+            Main.start(["approve", "--approver", "Julian", "--message", "We really need this", "foo"])
           end
         end
       end

data/spec/lib/license_finder/configuration_spec.rb

@@ -11,40 +11,61 @@ module LicenseFinder
       end
     end
 
+    describe "#last_modified" do
+      let(:time) { double :time }
+      before do
+        allow(Configuration::Persistence).to receive(:last_modified) { time }
+      end
+
+      it 'returns the last modified date of the config file' do
+        expect(LicenseFinder::Configuration.new({}).last_modified).to eq time
+      end
+    end
+
     describe '.new' do
       it "should default missing attributes" do
         subject = described_class.new({})
         subject.whitelist.should == []
         subject.ignore_groups.should == []
+        subject.ignore_dependencies.should == []
         subject.artifacts.dir.should == Pathname('./doc/')
+        subject.gradle_command.should == 'gradle'
       end
 
       it "should default missing attributes even if they are saved as nils in the YAML file" do
         attributes = {
           "whitelist" => nil,
           "ignore_groups" => nil,
+          "ignore_dependencies" => nil,
           "dependencies_file_dir" => nil,
-          "project_name" => nil
+          "project_name" => nil,
+          "gradle_command" => nil
         }
         subject = described_class.new(attributes)
         subject.whitelist.should == []
         subject.ignore_groups.should == []
+        subject.ignore_dependencies.should == []
         subject.artifacts.dir.should == Pathname('./doc/')
         subject.project_name.should_not be_nil
+        subject.gradle_command.should == 'gradle'
       end
 
       it "should set the all of the attributes on the instance" do
         attributes = {
           "whitelist" => %w{a whitelist},
           "ignore_groups" => %w{test development},
+          "ignore_dependencies" => %w{bundler},
           "dependencies_file_dir" => "some/path",
-          "project_name" => "my_app"
+          "project_name" => "my_app",
+          "gradle_command" => "./gradlew"
         }
         subject = described_class.new(attributes)
         subject.whitelist.should == %w{a whitelist}
         subject.ignore_groups.should == %w{test development}
+        subject.ignore_dependencies.should == %w{bundler}
         subject.artifacts.dir.should == Pathname("some/path")
         subject.project_name.should == "my_app"
+        subject.gradle_command.should == "./gradlew"
       end
     end
 
@@ -72,31 +93,15 @@ module LicenseFinder
       end
     end
 
-    describe "whitelisted?" do
-      context "short name whitelisted" do
-        subject { described_class.new('whitelist' => ["Apache2"]) }
-
-        it "should accept any of the licenses names" do
-          subject.should be_whitelisted "Apache2"
-          subject.should be_whitelisted "Apache 2.0"
-          subject.should be_whitelisted "Apache-2.0"
-        end
-
-        it "should be case-insensitive" do
-          subject.should be_whitelisted "apache2"
-          subject.should be_whitelisted "apache 2.0"
-          subject.should be_whitelisted "apache-2.0"
-        end
-      end
-    end
-
     describe "#save" do
       def attributes # can't be a let... the caching causes polution
         {
           'whitelist' => ['my_gem'],
           'ignore_groups' => ['other_group', 'test'],
+          'ignore_dependencies' => ['bundler'],
           'project_name' => "New Project Name",
-          'dependencies_file_dir' => "./deps"
+          'dependencies_file_dir' => "./deps",
+          'gradle_command' => './gradle'
         }
       end
 
@@ -109,6 +114,7 @@ module LicenseFinder
         config = described_class.new(attributes)
         config.whitelist << 'my_gem'
         config.ignore_groups << 'test'
+        config.ignore_dependencies << 'bundler'
 
         Configuration::Persistence.should_receive(:set).with(attributes)
         config.save
@@ -116,6 +122,28 @@ module LicenseFinder
     end
   end
 
+  describe Configuration::Artifacts do
+    describe "#last_refreshed" do
+      let(:database_modified_time) { 1 }
+      let(:text_modified_time) { 2 }
+      let(:detailed_text_modified_time) { 3 }
+      let(:html_modified_time) { 4 }
+      let(:markdown_modified_time) { 5 }
+
+      before do
+        allow(File).to receive(:mtime).with(Pathname('./doc/dependencies.db')) { database_modified_time }
+        allow(File).to receive(:mtime).with(Pathname('./doc/dependencies.csv')) { text_modified_time }
+        allow(File).to receive(:mtime).with(Pathname('./doc/dependencies_detailed.csv')) { detailed_text_modified_time }
+        allow(File).to receive(:mtime).with(Pathname('./doc/dependencies.html')) { html_modified_time }
+        allow(File).to receive(:mtime).with(Pathname('./doc/dependencies.md')) { markdown_modified_time }
+      end
+
+      it 'returns the earliest modified date of the config file' do
+        expect(described_class.new(Pathname('./doc')).last_refreshed).to eq database_modified_time
+      end
+    end
+  end
+
   describe Configuration::Persistence do
     describe ".get" do
       it "should use saved configuration" do
@@ -168,5 +196,17 @@ module LicenseFinder
         described_class.init
       end
     end
+
+    describe ".last_modified" do
+      let(:time) { double :time }
+      let(:config_path) { Pathname.new('.').join('config').join('license_finder.yml') }
+      before do
+        allow(File).to receive(:mtime).with(config_path) { time }
+      end
+
+      it "returns the last time the yml file was modified" do
+        expect(described_class.last_modified).to eq time
+      end
+    end
   end
 end

data/spec/lib/license_finder/dependency_manager_spec.rb

@@ -13,10 +13,10 @@ module LicenseFinder
       let(:gem1) { double(:package) }
       let(:gem2) { double(:package) }
 
-      it "destroys every dependency except for the ones Bundler reports as 'current' or are marked as 'manual'" do
+      it "destroys every dependency except for the ones Bundler reports as 'current' or are marked as 'added_manually'" do
         cur1 = Dependency.create(name: "current dependency 1")
         cur2 = Dependency.create(name: "current dependency 2")
-        man1 = Dependency.create(name: "manual dependency", manual: true)
+        man1 = Dependency.create(name: "manual dependency", added_manually: true)
         Dependency.create(name: "old dependency 1")
         Dependency.create(name: "old dependency 2")
 
@@ -29,20 +29,20 @@ module LicenseFinder
       end
     end
 
-    describe ".create_manually_managed" do
+    describe ".manually_add" do
       it "should add a Dependency" do
         expect do
-          described_class.create_manually_managed("MIT", "js_dep", "0.0.0")
+          described_class.manually_add("MIT", "js_dep", "0.0.0")
         end.to change(Dependency, :count).by(1)
       end
 
       it "should mark the dependency as manual" do
-        described_class.create_manually_managed("MIT", "js_dep", "0.0.0")
-          .should be_manual
+        described_class.manually_add("MIT", "js_dep", "0.0.0")
+          .should be_added_manually
       end
 
       it "should set the appropriate values" do
-        dep = described_class.create_manually_managed("GPL", "js_dep", "0.0.0")
+        dep = described_class.manually_add("GPL", "js_dep", "0.0.0")
         dep.name.should == "js_dep"
         dep.version.should == "0.0.0"
         dep.license.name.should == "GPL"
@@ -51,23 +51,16 @@ module LicenseFinder
 
       it "should complain if the dependency already exists" do
         Dependency.create(name: "current dependency 1")
-        expect { described_class.create_manually_managed("GPL", "current dependency 1", "0.0.0") }
-          .to raise_error(LicenseFinder::Error)
-      end
-
-      it "re-uses an existing, unassociated, license alias" do
-        existing_license = LicenseAlias.named("existing license")
-
-        dep = described_class.create_manually_managed("existing license", "js_dep", "0.0.0")
-        dep.license.should == existing_license
+        expect { described_class.manually_add("GPL", "current dependency 1", "0.0.0") }
+          .to raise_error(Error)
       end
     end
 
-    describe ".destroy_manually_managed" do
+    describe ".manually_remove" do
       it "should remove a manually managed Dependency" do
-        described_class.create_manually_managed("GPL", "a manually managed dep", nil)
+        described_class.manually_add("GPL", "a manually managed dep", nil)
         expect do
-          described_class.destroy_manually_managed("a manually managed dep")
+          described_class.manually_remove("a manually managed dep")
         end.to change(Dependency, :count).by(-1)
       end
 
@@ -75,8 +68,8 @@ module LicenseFinder
         Dependency.create(name: "a bundler dep")
         expect do
           expect do
-            described_class.destroy_manually_managed("a bundler dep")
-          end.to raise_error(LicenseFinder::Error)
+            described_class.manually_remove("a bundler dep")
+          end.to raise_error(Error)
         end.to_not change(Dependency, :count)
       end
     end
@@ -84,14 +77,24 @@ module LicenseFinder
     describe ".approve!" do
       it "approves the dependency" do
         dep = Dependency.named("current dependency")
+        dep.license = License.find_by_name('not approved')
+        dep.save
         dep.reload.should_not be_approved
         described_class.approve!("current dependency")
         dep.reload.should be_approved
       end
 
+      it "optionally adds approver and approval notes" do
+        dep = Dependency.named("current dependency")
+        described_class.approve!("current dependency", "Julian", "We really need this")
+        approval = dep.reload.manual_approval
+        approval.approver.should eq "Julian"
+        approval.notes.should eq "We really need this"
+      end
+
       it "should raise an error if it can't find the dependency" do
         expect { described_class.approve!("non-existent dependency") }
-          .to raise_error(LicenseFinder::Error)
+          .to raise_error(Error)
       end
     end
 
@@ -100,13 +103,13 @@ module LicenseFinder
 
       it "adds a license for the dependency" do
         DependencyManager.stub(:find_by_name).with("dependency").and_return(dependency)
-        dependency.should_receive(:set_license_manually!).with("MIT")
+        dependency.should_receive(:set_license_manually!).with(License.find_by_name "MIT")
         described_class.license!("dependency", "MIT")
       end
 
       it "should raise an error if it can't find the dependency" do
         expect { described_class.license!("non-existent dependency", "a license") }
-          .to raise_error(LicenseFinder::Error)
+          .to raise_error(Error)
       end
     end
 
@@ -145,27 +148,43 @@ module LicenseFinder
         context "when the database has not changed" do
           before do
             Digest::SHA2.stub_chain(:file, :hexdigest) { 5 }
+            allow(config).to receive(:last_modified) { config_last_update }
+            allow(config.artifacts).to receive(:last_refreshed) { artifacts_last_update }
           end
 
-          context "when the reports exist" do
+          context "and the reports do not exist" do
             before do
-              config.artifacts.stub(:html_file).and_return(file_exists)
+              config.artifacts.stub(:html_file).and_return(file_does_not_exist)
             end
 
-            it "does not write reports" do
-              Reporter.should_not_receive(:write_reports)
+            it "writes reports" do
+              Reporter.should_receive(:write_reports)
               DependencyManager.modifying {}
             end
           end
 
-          context "when the reports do not exist" do
+          context "and the reports exist" do
             before do
-              config.artifacts.stub(:html_file).and_return(file_does_not_exist)
+              config.artifacts.stub(:html_file).and_return(file_exists)
             end
 
-            it "writes reports" do
-              Reporter.should_receive(:write_reports)
-              DependencyManager.modifying {}
+            context "and configs are newer than the reports" do
+              let(:config_last_update) { 4 }
+              let(:artifacts_last_update) { 1 }
+              it "writes reports" do
+                expect(Reporter).to receive(:write_reports)
+                DependencyManager.modifying {}
+              end
+            end
+
+            context "and configs are older than the reports" do
+              let(:config_last_update) { 4 }
+              let(:artifacts_last_update) { 6 }
+
+              it "does not write reports" do
+                expect(Reporter).not_to receive(:write_reports)
+                DependencyManager.modifying {}
+              end
             end
           end
         end