libv8 5.3.332.38.5 → 5.6.326.50.0beta1

data/vendor/depot_tools/pylintrc

@@ -33,64 +33,91 @@ load-plugins=
 # can either give multiple identifier separated by comma (,) or put this option
 # multiple time (only on the command line, not in the configuration file where
 # it should appear only once).
-# CHANGED:
-# C0103: Invalid name ""
-# C0111: Missing docstring
-# C0302: Too many lines in module (N)
-# I0010: Unable to consider inline option ''
-# I0011: Locally disabling WNNNN
 #
-# R0801: Similar lines in N files
-# R0901: Too many ancestors (8/7)
-# R0902: Too many instance attributes (N/7)
-# R0903: Too few public methods (N/2)
-# R0904: Too many public methods (N/20)
-# R0911: Too many return statements (N/6)
-# R0912: Too many branches (N/12)
-# R0913: Too many arguments (N/5)
-# R0914: Too many local variables (N/15)
-# R0915: Too many statements (N/50)
-# R0921: Abstract class not referenced
-# R0922: Abstract class is only referenced 1 times
-# W0122: Use of the exec statement
-# W0141: Used builtin function ''
-# W0142: Used * or ** magic
-# W0402: Uses of a deprecated module 'string'
-# W0404: 41: Reimport 'XX' (imported line NN)
-# W0511: TODO
-# W0603: Using the global statement
-# W0703: Catch "Exception"
-# W1201: Specify string format arguments as logging function parameters
+# These should get enabled, but the codebase has too many violations currently:
+#     bad-continuation
+#     anomalous-backslash-in-string
+#     bad-context-manager
+#     bad-indentation
+#     bad-str-strip-call
+#     bad-whitespace
+#     cell-var-from-loop
+#     deprecated-lambda
+#     eval-used
+#     function-redefined
+#     import-error
+#     locally-enabled
+#     missing-final-newline
+#     no-init
+#     no-name-in-module
+#     no-self-use
+#     not-callable
+#     old-style-class
+#     protected-access
+#     superfluous-parens
+#     super-on-old-class
+#     too-many-function-args
+#     trailing-whitespace
+#     unnecessary-semicolon
+#     unpacking-non-sequence
+#     unused-import
+#     useless-else-on-loop
 #
-# These should get enabled, but the codebase has too many violations currently.
-# bad-continuation
-# anomalous-backslash-in-string
-# bad-context-manager
-# bad-indentation
-# bad-str-strip-call
-# bad-whitespace
-# cell-var-from-loop
-# deprecated-lambda
-# eval-used
-# function-redefined
-# import-error
-# locally-enabled
-# missing-final-newline
-# no-init
-# no-name-in-module
-# no-self-use
-# not-callable
-# old-style-class
-# protected-access
-# superfluous-parens
-# super-on-old-class
-# too-many-function-args
-# trailing-whitespace
-# unnecessary-semicolon
-# unpacking-non-sequence
-# unused-import
-# useless-else-on-loop
-disable=C0103,C0111,C0302,I0010,I0011,R0801,R0901,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0921,R0922,W0122,W0141,W0142,W0402,W0404,W0511,W0603,W0703,W1201,bad-continuation,anomalous-backslash-in-string,bad-context-manager,bad-indentation,bad-str-strip-call,bad-whitespace,cell-var-from-loop,deprecated-lambda,eval-used,function-redefined,import-error,locally-enabled,missing-final-newline,no-init,no-name-in-module,no-self-use,not-callable,old-style-class,protected-access,superfluous-parens,super-on-old-class,too-many-function-args,trailing-whitespace,unnecessary-semicolon,unpacking-non-sequence,unused-import,useless-else-on-loop
+# CHANGED:
+disable=
+    invalid-name,
+    missing-docstring,
+    too-many-lines,
+    bad-inline-option,
+    locally-disabled,
+    duplicate-code,
+    too-many-ancestors,
+    too-many-instance-attributes,
+    too-few-public-methods,
+    too-many-public-methods,
+    too-many-return-statements,
+    too-many-branches,
+    too-many-arguments,
+    too-many-locals,
+    too-many-statements,
+    abstract-class-not-used,
+    abstract-class-little-used,
+    exec-used,
+    bad-builtin,
+    star-args,
+    deprecated-module,
+    reimported,
+    fixme,
+    global-statement,
+    broad-except,
+    logging-not-lazy,
+    bad-continuation,
+    anomalous-backslash-in-string,
+    bad-context-manager,
+    bad-indentation,
+    bad-str-strip-call,
+    bad-whitespace,
+    cell-var-from-loop,
+    deprecated-lambda,
+    eval-used,
+    function-redefined,
+    import-error,
+    locally-enabled,
+    missing-final-newline,
+    no-init,
+    no-name-in-module,
+    no-self-use,
+    not-callable,
+    old-style-class,
+    protected-access,
+    superfluous-parens,
+    super-on-old-class,
+    too-many-function-args,
+    trailing-whitespace,
+    unnecessary-semicolon,
+    unpacking-non-sequence,
+    unused-import,
+    useless-else-on-loop
 
 
 [REPORTS]

data/vendor/depot_tools/recipe_modules/OWNERS

@@ -0,0 +1 @@
+recipe-roller@chromium.org

data/vendor/depot_tools/recipe_modules/bot_update/__init__.py

@@ -15,18 +15,27 @@ from recipe_engine.recipe_api import Property
 from recipe_engine.types import freeze
 
 PROPERTIES = {
-  'mastername': Property(default=None),
-  'buildername': Property(default=None),
-  'slavename': Property(default=None),
+  # Gerrit patches will have all properties about them prefixed with patch_.
+  'patch_issue': Property(default=None),  # TODO(tandrii): add kind=int.
+  'patch_set': Property(default=None),  # TODO(tandrii): add kind=int.
+  'patch_project': Property(default=None),  # Also used by Rietveld.
+  'patch_gerrit_url': Property(default=None),
+  'patch_repository_url': Property(default=None),
+  'patch_ref': Property(default=None),
+
+  # TODO(tAndrii): remove legacy Gerrit fields.
+  # Legacy Gerrit fields.
+  'event.patchSet.ref': Property(default=None, param_name='gerrit_ref'),
+
+  # Rietveld-only fields.
+  'rietveld': Property(default=None),  # Stores Url of Rietveld server.
   'issue': Property(default=None),
   'patchset': Property(default=None),
-  'patch_url': Property(default=None),
-  'patch_project': Property(default=None),
   'repository': Property(default=None),
-  'event.patchSet.ref': Property(default=None, param_name="gerrit_ref"),
-  'rietveld': Property(default=None),
-  'revision': Property(default=None),
-  'parent_got_revision': Property(default=None),
+
+  # Common fields for both systems.
   'deps_revision_overrides': Property(default=freeze({})),
   'fail_patch': Property(default=None, kind=str),
+  'parent_got_revision': Property(default=None),
+  'revision': Property(default=None),
 }

data/vendor/depot_tools/recipe_modules/bot_update/api.py

@@ -3,25 +3,22 @@
 # found in the LICENSE file.
 
 
-"""Recipe module to ensure a checkout is consistant on a bot."""
+"""Recipe module to ensure a checkout is consistent on a bot."""
 
 from recipe_engine import recipe_api
 
 
 class BotUpdateApi(recipe_api.RecipeApi):
 
-  def __init__(self, mastername, buildername, slavename, issue, patchset,
-               patch_url, repository, gerrit_ref, rietveld, revision,
-               parent_got_revision, deps_revision_overrides, fail_patch,
-               *args, **kwargs):
-    self._mastername = mastername
-    self._buildername = buildername
-    self._slavename = slavename
-    self._issue = issue
-    self._patchset = patchset
-    self._patch_url = patch_url
-    self._repository = repository
-    self._gerrit_ref = gerrit_ref
+  def __init__(self, issue, patch_issue, patchset, patch_set, patch_project,
+               repository, patch_repository_url, gerrit_ref, patch_ref,
+               patch_gerrit_url, rietveld, revision, parent_got_revision,
+               deps_revision_overrides, fail_patch, *args, **kwargs):
+    self._issue = issue or patch_issue
+    self._patchset = patchset or patch_set
+    self._repository = repository or patch_repository_url
+    self._gerrit_ref = gerrit_ref or patch_ref
+    self._gerrit = patch_gerrit_url
     self._rietveld = rietveld
     self._revision = revision
     self._parent_got_revision = parent_got_revision
@@ -40,6 +37,11 @@ class BotUpdateApi(recipe_api.RecipeApi):
     kwargs['env'].setdefault('PATH', '%(PATH)s')
     kwargs['env']['PATH'] = self.m.path.pathsep.join([
         kwargs['env']['PATH'], str(self._module.PACKAGE_REPO_ROOT)])
+    # These are to prevent git from hanging.  If the git connection is slower
+    # than 1KB/s for more than 5 minutes then git will kill the connection
+    # and die with an error "error: RPC failed; curl 28 Operation too slow"
+    kwargs['env']['GIT_HTTP_LOW_SPEED_LIMIT'] = 1000
+    kwargs['env']['GIT_HTTP_LOW_SPEED_TIME'] = 300
     return self.m.python(name, bot_update_path, cmd, **kwargs)
 
   @property
@@ -47,11 +49,9 @@ class BotUpdateApi(recipe_api.RecipeApi):
       return self._last_returned_properties
 
   # DO NOT USE.
-  # The below method will be removed after there are no more callers of
-  # tryserver.maybe_apply_issue (skbug.com/5588).
+  # TODO(tandrii): refactor this into tryserver.maybe_apply_patch
   def apply_gerrit_ref(self, root, gerrit_no_reset=False,
-                       gerrit_no_rebase_patch_ref=False,
-                       gerrit_rebase_patch_ref=True, **kwargs):
+                       gerrit_no_rebase_patch_ref=False, **kwargs):
     apply_gerrit_path = self.resource('apply_gerrit.py')
     kwargs.setdefault('infra_step', True)
     kwargs.setdefault('env', {}).setdefault('PATH', '%(PATH)s')
@@ -64,20 +64,20 @@ class BotUpdateApi(recipe_api.RecipeApi):
     ]
     if gerrit_no_reset:
       cmd.append('--gerrit_no_reset')
-    if gerrit_no_rebase_patch_ref or not gerrit_rebase_patch_ref:
+    if gerrit_no_rebase_patch_ref:
       cmd.append('--gerrit_no_rebase_patch_ref')
     return self.m.python('apply_gerrit', apply_gerrit_path, cmd, **kwargs)
 
   def ensure_checkout(self, gclient_config=None, suffix=None,
                       patch=True, update_presentation=True,
-                      force=False, patch_root=None, no_shallow=False,
+                      patch_root=None, no_shallow=False,
                       with_branch_heads=False, refs=None,
-                      patch_oauth2=False, use_site_config_creds=True,
+                      patch_oauth2=False, oauth2_json=False,
+                      use_site_config_creds=True,
                       output_manifest=True, clobber=False,
                       root_solution_revision=None, rietveld=None, issue=None,
                       patchset=None, gerrit_no_reset=False,
-                      gerrit_no_rebase_patch_ref=False,
-                      gerrit_rebase_patch_ref=True, **kwargs):
+                      gerrit_no_rebase_patch_ref=False, **kwargs):
     """
     Args:
       use_site_config_creds: If the oauth2 credentials are in the buildbot
@@ -98,10 +98,8 @@ class BotUpdateApi(recipe_api.RecipeApi):
     assert cfg is not None, (
         'missing gclient_config or forgot api.gclient.set_config(...) before?')
 
-    # Used by bot_update to determine if we want to run or not.
-    master = self._mastername
-    builder = self._buildername
-    slave = self._slavename
+    # Only one of these should exist.
+    assert not (oauth2_json and patch_oauth2)
 
     # Construct our bot_update command.  This basically be inclusive of
     # everything required for bot_update to know:
@@ -113,13 +111,12 @@ class BotUpdateApi(recipe_api.RecipeApi):
     if patch:
       issue = issue or self._issue
       patchset = patchset or self._patchset
-      patch_url = self._patch_url
       gerrit_repo = self._repository
       gerrit_ref = self._gerrit_ref
     else:
       # The trybot recipe sometimes wants to de-apply the patch. In which case
-      # we pretend the issue/patchset/patch_url never existed.
-      issue = patchset = patch_url = email_file = key_file = None
+      # we pretend the issue/patchset never existed.
+      issue = patchset = email_file = key_file = None
       gerrit_repo = gerrit_ref = None
 
     # Issue and patchset must come together.
@@ -127,31 +124,43 @@ class BotUpdateApi(recipe_api.RecipeApi):
       assert patchset
     if patchset:
       assert issue
-    if patch_url:
-      # If patch_url is present, bot_update will actually ignore issue/ps.
-      issue = patchset = None
 
     # The gerrit_ref and gerrit_repo must be together or not at all.  If one is
     # missing, clear both of them.
     if not gerrit_ref or not gerrit_repo:
       gerrit_repo = gerrit_ref = None
     assert (gerrit_ref != None) == (gerrit_repo != None)
+    if gerrit_ref:
+      # Gerrit patches have historically not specified issue and patchset.
+      # resourece/bot_update has as a result implicit assumption that set issue
+      # implies Rietveld patch.
+      # TODO(tandrii): fix this madness.
+      issue = patchset = None
 
     # Point to the oauth2 auth files if specified.
     # These paths are where the bots put their credential files.
-    if patch_oauth2:
+    oauth2_json_file = email_file = key_file = None
+    if oauth2_json:
+      if self.m.platform.is_win:
+        oauth2_json_file = 'C:\\creds\\refresh_tokens\\internal-try'
+      else:
+        oauth2_json_file = '/creds/refresh_tokens/internal-try'
+    elif patch_oauth2:
       # TODO(martiniss): remove this hack :(. crbug.com/624212
       if use_site_config_creds:
-        email_file = self.m.path['build'].join(
-            'site_config', '.rietveld_client_email')
-        key_file = self.m.path['build'].join(
-            'site_config', '.rietveld_secret_key')
+        try:
+          build_path = self.m.path['build']
+        except KeyError:
+          raise self.m.step.StepFailure(
+              'build path is not defined. This is normal for LUCI builds. '
+              'In LUCI, use_site_config_creds parameter of '
+              'bot_update.ensure_checkout is not supported')
+        email_file = build_path.join('site_config', '.rietveld_client_email')
+        key_file = build_path.join('site_config', '.rietveld_secret_key')
       else: #pragma: no cover
         #TODO(martiniss): make this use path.join, so it works on windows
         email_file = '/creds/rietveld/client_email'
         key_file = '/creds/rietveld/secret_key'
-    else:
-      email_file = key_file = None
 
     # Allow patch_project's revision if necessary.
     # This is important for projects which are checked out as DEPS of the
@@ -162,28 +171,23 @@ class BotUpdateApi(recipe_api.RecipeApi):
     rev_map = cfg.got_revision_mapping.as_jsonish()
 
     flags = [
-        # 1. Do we want to run? (master/builder/slave).
-        ['--master', master],
-        ['--builder', builder],
-        ['--slave', slave],
-
-        # 2. What do we want to check out (spec/root/rev/rev_map).
+        # What do we want to check out (spec/root/rev/rev_map).
         ['--spec', self.m.gclient.config_to_pythonish(cfg)],
-        ['--root', root],
+        ['--patch_root', root],
         ['--revision_mapping_file', self.m.json.input(rev_map)],
         ['--git-cache-dir', cfg.cache_dir],
 
-        # 3. How to find the patch, if any (issue/patchset/patch_url).
+        # How to find the patch, if any (issue/patchset).
         ['--issue', issue],
         ['--patchset', patchset],
-        ['--patch_url', patch_url],
         ['--rietveld_server', rietveld or self._rietveld],
         ['--gerrit_repo', gerrit_repo],
         ['--gerrit_ref', gerrit_ref],
         ['--apply_issue_email_file', email_file],
         ['--apply_issue_key_file', key_file],
+        ['--apply_issue_oauth2_file', oauth2_json_file],
 
-        # 4. Hookups to JSON output back into recipes.
+        # Hookups to JSON output back into recipes.
         ['--output_json', self.m.json.output()],]
 
 
@@ -223,8 +227,6 @@ class BotUpdateApi(recipe_api.RecipeApi):
 
     if clobber:
       cmd.append('--clobber')
-    if force:
-      cmd.append('--force')
     if no_shallow:
       cmd.append('--no_shallow')
     if output_manifest:
@@ -233,14 +235,13 @@ class BotUpdateApi(recipe_api.RecipeApi):
       cmd.append('--with_branch_heads')
     if gerrit_no_reset:
       cmd.append('--gerrit_no_reset')
-    if gerrit_no_rebase_patch_ref or not gerrit_rebase_patch_ref:
+    if gerrit_no_rebase_patch_ref:
       cmd.append('--gerrit_no_rebase_patch_ref')
 
     # Inject Json output for testing.
     first_sln = cfg.solutions[0].name
     step_test_data = lambda: self.test_api.output_json(
-        master, builder, slave, root, first_sln, rev_map, force,
-        self._fail_patch,
+        root, first_sln, rev_map, self._fail_patch,
         output_manifest=output_manifest, fixed_revisions=fixed_revisions)
 
     # Add suffixes to the step name, if specified.
@@ -310,7 +311,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
         # first solution.
         if step_result.json.output['did_run']:
           co_root = step_result.json.output['root']
-          cwd = kwargs.get('cwd', self.m.path['slave_build'])
+          cwd = self.m.step.get_from_context('cwd', self.m.path['start_dir'])
           if 'checkout' not in self.m.path:
             self.m.path['checkout'] = cwd.join(*co_root.split(self.m.path.sep))
 

data/vendor/depot_tools/recipe_modules/bot_update/example.expected/basic.json

@@ -4,15 +4,9 @@
       "python",
       "-u",
       "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
-      "--master",
-      "chromium.linux",
-      "--builder",
-      "Linux Builder",
-      "--slave",
-      "totallyaslave-m1",
       "--spec",
       "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",
-      "--root",
+      "--patch_root",
       "src",
       "--revision_mapping_file",
       "{\"src\": \"got_cr_revision\"}",
@@ -24,6 +18,8 @@
       "src@abc"
     ],
     "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
       "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update (without patch)",