lhs 15.3.1 → 15.3.2

data/spec/record/immutable_chains_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) do
+  before do
     class Record < LHS::Record
       endpoint 'http://local.ch/v2/records'
     end

data/spec/record/includes_all_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   context 'includes all' do
-    before(:each) do
+    before do
       class Customer < LHS::Record
         endpoint 'http://datastore/customers/{id}'
       end
@@ -170,7 +170,7 @@ describe LHS::Record do
     end
 
     context 'includes for an empty array' do
-      before(:each) do
+      before do
         class Contract < LHS::Record
           endpoint 'http://datastore/contracts/{id}'
         end
@@ -194,7 +194,7 @@ describe LHS::Record do
       end
 
       context 'weird array without hrefs' do
-        before(:each) do
+        before do
           stub_request(:get, "http://datastore/options/1?limit=100")
             .to_return(body: { type: 'REACH_EXT' }.to_json)
         end
@@ -213,7 +213,7 @@ describe LHS::Record do
     end
 
     context 'include a known/identifiable record' do
-      before(:each) do
+      before do
         class Contract < LHS::Record
           endpoint 'http://datastore/contracts/{id}'
         end
@@ -262,7 +262,7 @@ describe LHS::Record do
     end
 
     context 'includes all for parallel loaded ids' do
-      before(:each) do
+      before do
         class Place < LHS::Record
           endpoint 'http://datastore/places/{id}'
         end
@@ -341,7 +341,7 @@ describe LHS::Record do
   end
 
   context 'Linked resources' do
-    before(:each) do
+    before do
       stub_request(:get, 'http://datastore/places/1/contracts?offset=0&limit=10')
         .to_return(
           body: {

data/spec/record/includes_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   let(:datastore) { 'http://local.ch/v2' }
-  before(:each) { LHC.config.placeholder('datastore', datastore) }
+  before { LHC.config.placeholder('datastore', datastore) }
 
   let(:stub_campaign_request) do
     stub_request(:get, "#{datastore}/content-ads/51dfc5690cf271c375c5a12d")
@@ -24,7 +24,7 @@ describe LHS::Record do
   end
 
   context 'singlelevel includes' do
-    before(:each) do
+    before do
       class LocalEntry < LHS::Record
         endpoint '{+datastore}/local-entries'
         endpoint '{+datastore}/local-entries/{id}'
@@ -72,7 +72,7 @@ describe LHS::Record do
   end
 
   context 'multilevel includes' do
-    before(:each) do
+    before do
       class Feedback < LHS::Record
         endpoint '{+datastore}/feedbacks'
         endpoint '{+datastore}/feedbacks/{id}'
@@ -151,7 +151,7 @@ describe LHS::Record do
 
       let(:interceptor) { spy('interceptor') }
 
-      before(:each) do
+      before do
         class Entry < LHS::Record
           endpoint '{+datastore}/local-entries/{id}'
         end
@@ -167,7 +167,7 @@ describe LHS::Record do
     end
 
     context 'includes not present in response' do
-      before :each do
+      before do
         class Parent < LHS::Record
           endpoint '{+datastore}/local-parents'
           endpoint '{+datastore}/local-parents/{id}'
@@ -239,12 +239,12 @@ describe LHS::Record do
 
       feedback = Feedback.includes(campaign: :entry).find(123)
       expect(feedback.campaign._raw.keys.count).to eq 1
-      expect(feedback.campaign.href).to be
+      expect(feedback.campaign.href).to be_present
     end
   end
 
   context 'modules' do
-    before(:each) do
+    before do
       module Services
         class LocalEntry < LHS::Record
           endpoint '{+datastore}/local-entries'
@@ -264,7 +264,7 @@ describe LHS::Record do
   end
 
   context 'arrays' do
-    before(:each) do
+    before do
       class Place < LHS::Record
         endpoint '{+datastore}/place'
         endpoint '{+datastore}/place/{id}'
@@ -307,7 +307,7 @@ describe LHS::Record do
 
       it 'loads places in parallel and merges included data properly' do
         place = Place.includes(:relations).find(2, 1)
-        expect(place[0].relations.empty?)
+        expect(place[0].relations.empty?).to be true
         expect(place[1].relations[0].name).to eq 'Category'
         expect(place[1].relations[1].name).to eq 'ZeFrank'
       end
@@ -359,7 +359,7 @@ describe LHS::Record do
   end
 
   context 'unexpanded response when requesting the included collection' do
-    before(:each) do
+    before do
       class Customer < LHS::Record
         endpoint '{+datastore}/customer/{id}'
       end
@@ -428,7 +428,7 @@ describe LHS::Record do
   end
 
   context 'includes with options' do
-    before(:each) do
+    before do
       class Customer < LHS::Record
         endpoint '{+datastore}/customers/{id}'
         endpoint '{+datastore}/customers'
@@ -474,7 +474,7 @@ describe LHS::Record do
   end
 
   context 'more complex examples' do
-    before(:each) do
+    before do
       class Place < LHS::Record
         endpoint 'http://datastore/places/{id}'
       end
@@ -536,7 +536,7 @@ describe LHS::Record do
   end
 
   context 'include and merge arrays when calling find in parallel' do
-    before(:each) do
+    before do
       class Place < LHS::Record
         endpoint 'http://datastore/places/{id}'
       end

data/spec/record/includes_warning_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   context 'includes warning' do
-    before(:each) do
+    before do
       class Customer < LHS::Record
         endpoint 'http://datastore/customers/{id}'
       end

data/spec/record/item_key_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) do
+  before do
     class Location < LHS::Record
       configuration item_key: [:response, :location]
       endpoint 'http://uberall/location'

data/spec/record/items_created_key_configuration_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) do
+  before do
     class Business < LHS::Record
       configuration item_created_key: [:response, :business], limit_key: [:response, :max], pagination_key: [:response, :offset], total_key: [:response, :count], pagination_strategy: :offset
       endpoint 'http://uberall/businesses'

data/spec/record/mapping_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
   context 'mapping' do
     let(:datastore) { 'http://local.ch/v2' }
 
-    before(:each) do
+    before do
       LHC.config.placeholder('datastore', datastore)
       class LocalEntry < LHS::Record
         endpoint '{+datastore}/local-entries'

data/spec/record/model_name_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   context 'model_name' do
-    before(:each) do
+    before do
       class LocalEntry < LHS::Record
         endpoint '{+datastore}/local-entries'
       end

data/spec/record/new_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
   context 'new' do
     let(:datastore) { 'http://local.ch/v2' }
 
-    before(:each) do
+    before do
       LHC.config.placeholder('datastore', datastore)
       class Rating < LHS::Record
         endpoint '{+datastore}/content-ads/{campaign_id}/feedbacks'
@@ -27,7 +27,7 @@ describe LHS::Record do
     end
 
     context 'initialise records with raw data' do
-      before(:each) do
+      before do
         class User < LHS::Record
           endpoint '{+datastore}/users'
         end
@@ -46,7 +46,7 @@ describe LHS::Record do
     end
 
     context 'custom setters' do
-      before(:each) do
+      before do
         class Rating
           def ratings=(ratings)
             _raw[:ratings] = ratings.map { |k, v| { name: k, value: v } }
@@ -66,7 +66,7 @@ describe LHS::Record do
       end
 
       context 'that do not affect raw data' do
-        before(:each) do
+        before do
           class Rating
             attr_accessor :listing
           end
@@ -86,7 +86,7 @@ describe LHS::Record do
       end
 
       context 'and custom getters' do
-        before(:each) do
+        before do
           class Rating
             def ratings
               Hash[_raw[:ratings].map { |r| [r[:name], r[:value]] }]

data/spec/record/options_spec.rb

@@ -5,7 +5,7 @@ describe LHS::Record do
     'http://datastore/v2'
   end
 
-  before(:each) do
+  before do
     LHC.config.placeholder('datastore', datastore)
     class Record < LHS::Record
       endpoint '{+datastore}/records', validates: { persist: false }
@@ -73,7 +73,7 @@ describe LHS::Record do
       end
 
       context 'save' do
-        before(:each) do
+        before do
           stub_request(:post, 'http://datastore/v2/records/123').to_return(body: {}.to_json)
           expect(LHC).to receive(:request)
             .with(options.merge(method: :post, url: "http://datastore/v2/records/123", body: { href: 'http://datastore/v2/records/123' }, headers: { "Content-Type" => "application/json" }))
@@ -98,7 +98,7 @@ describe LHS::Record do
       end
 
       context 'destroy' do
-        before(:each) do
+        before do
           stub_request(:delete, 'http://datastore/v2/records/123').to_return(body: {}.to_json)
           expect(LHC).to receive(:request)
             .with(options.merge(method: :delete, url: "http://datastore/v2/records/123"))
@@ -115,7 +115,7 @@ describe LHS::Record do
       end
 
       context 'update' do
-        before(:each) do
+        before do
           stub_request(:post, "http://datastore/v2/records/123").to_return(body: {}.to_json)
           body = LHS::Data.new({ href: 'http://datastore/v2/records/123', name: 'steve' }, nil, Record)
           expect(LHC).to receive(:request)
@@ -141,7 +141,7 @@ describe LHS::Record do
       end
 
       context 'valid' do
-        before(:each) do
+        before do
           stub_request(:post, 'http://datastore/v2/records?persist=false').to_return(body: {}.to_json)
           body = LHS::Data.new({ href: 'http://datastore/v2/records/123' }, nil, Record)
           expect(LHC).to receive(:request)

data/spec/record/paginatable_collection_spec.rb

@@ -1,12 +1,11 @@
-
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) { LHC.config.placeholder('datastore', datastore) }
+  before { LHC.config.placeholder('datastore', datastore) }
   let(:datastore) { 'http://local.ch/v2' }
 
   context 'default pagination behaviour' do
-    before(:each) do
+    before do
       class Record < LHS::Record
         endpoint '{+datastore}/feedbacks'
       end
@@ -49,7 +48,7 @@ describe LHS::Record do
   end
 
   context 'pagination using offset(0,100,200,...)' do
-    before(:each) do
+    before do
       class Record < LHS::Record
         configuration pagination_strategy: 'offset', pagination_key: 'offset'
         endpoint '{+datastore}/feedbacks'
@@ -129,7 +128,7 @@ describe LHS::Record do
   end
 
   context 'pagination using page(1,2,3,...)' do
-    before(:each) do
+    before do
       class Record < LHS::Record
         configuration pagination_strategy: 'page', pagination_key: 'page'
         endpoint '{+datastore}/feedbacks'
@@ -207,7 +206,7 @@ describe LHS::Record do
   end
 
   context 'pagination using start(1,101,201,...)' do
-    before(:each) do
+    before do
       class Record < LHS::Record
         configuration pagination_strategy: 'start', pagination_key: 'start'
         endpoint '{+datastore}/feedbacks'

data/spec/record/pagination_chain_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 describe LHS::Record do
   context 'pagination chain' do
     context 'default pagination (offset)' do
-      before(:each) do
+      before do
         class Record < LHS::Record
           endpoint 'http://local.ch/records'
           endpoint 'http://local.ch/records/{id}'
@@ -55,7 +55,7 @@ describe LHS::Record do
     end
 
     context 'start pagination' do
-      before(:each) do
+      before do
         class Record < LHS::Record
           configuration pagination_strategy: 'start', pagination_key: 'start'
           endpoint 'http://local.ch/records'
@@ -76,7 +76,7 @@ describe LHS::Record do
     end
 
     context 'page pagination' do
-      before(:each) do
+      before do
         class Record < LHS::Record
           configuration pagination_strategy: 'page', pagination_key: 'page'
           endpoint 'http://local.ch/records'

data/spec/record/pagination_links_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   context 'pagination links' do
-    before(:each) do
+    before do
       class Customer < LHS::Record
         endpoint 'http://datastore/customer'
       end

data/spec/record/pagination_spec.rb

@@ -20,7 +20,7 @@ describe LHS::Record do
       }.to_json
     end
 
-    before(:each) do
+    before do
       LHC.config.placeholder('datastore', datastore)
       class Feedback < LHS::Record
         endpoint '{+datastore}/feedbacks'

data/spec/record/persisted_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
   context '#persisted?' do
     let(:datastore) { 'http://local.ch/v2' }
 
-    before(:each) do
+    before do
       LHC.config.placeholder('datastore', datastore)
       class Feedback < LHS::Record
         endpoint '{+datastore}/content-ads/{campaign_id}/feedbacks'
@@ -32,6 +32,7 @@ describe LHS::Record do
     context 'for saved record' do
       let(:campaign_id) { 'aaa' }
       let(:parameters) { { recommended: true } }
+
       subject { Feedback.new(parameters.merge(campaign_id: campaign_id)) }
 
       before do

data/spec/record/references_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   context 'references' do
-    before(:each) do
+    before do
       class Customer < LHS::Record
         endpoint 'http://datastore/customers/{id}'
       end

data/spec/record/reload_by_id_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) do
+  before do
     class Record < LHS::Record
       endpoint 'http://datastore/records'
       endpoint 'http://datastore/records/{id}'

data/spec/record/reload_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) do
+  before do
     class Record < LHS::Record
       endpoint 'http://datastore/records'
       endpoint 'http://datastore/records/{id}'
@@ -24,7 +24,7 @@ describe LHS::Record do
 
   context 'nested items' do
 
-    before(:each) do
+    before do
       class Location < LHS::Record
         endpoint 'http://uberall/locations'
         endpoint 'http://uberall/locations/{id}'