lhs 15.3.1 → 15.3.2

data/spec/proxy/record_identification_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Proxy do
-  before(:each) do
+  before do
     class Search < LHS::Record
       endpoint 'http://search/results', items_key: :docs
     end

data/spec/record/all_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   context 'all' do
-    before(:each) do
+    before do
       class Record < LHS::Record
         endpoint 'http://datastore/feedbacks'
       end
@@ -60,7 +60,7 @@ describe LHS::Record do
   end
 
   context 'all without current page indicator' do
-    before(:each) do
+    before do
       class Category < LHS::Record
         configuration(
           items_key: %i(response results),
@@ -84,7 +84,7 @@ describe LHS::Record do
         )
     end
 
-    it 'is able to fetch all remote objects without any current page indicator by simply increasing the offset until response is empty' do
+    it 'is able to fetch all remote objects without any current page indicator by simply increasing the offset until response is empty with a limit' do
       stub_batch('http://store/categories?language=en&max=10&offset=0')
       stub_batch('http://store/categories?language=en&max=10&offset=10')
       stub_batch('http://store/categories?language=en&max=10&offset=20')

data/spec/record/build_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
   context 'build' do
     let(:datastore) { 'http://local.ch/v2' }
 
-    before(:each) do
+    before do
       LHC.config.placeholder('datastore', datastore)
       class Feedback < LHS::Record
         endpoint '{+datastore}/content-ads/{campaign_id}/feedbacks'

data/spec/record/cast_nested_data_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
   context 'cast nested data' do
     let(:datastore) { 'http://local.ch/v2' }
 
-    before(:each) do
+    before do
       LHC.config.placeholder('datastore', datastore)
       class Customer < LHS::Record
         endpoint '{+datastore}/customers'

data/spec/record/chain_error_handling_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 describe LHS::Record do
   let(:handler) { spy('handler') }
 
-  before(:each) do
+  before do
     class Record < LHS::Record
       endpoint 'http://local.ch/v2/records'
     end

data/spec/record/create_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
   context 'create' do
     let(:datastore) { 'http://local.ch/v2' }
 
-    before(:each) do
+    before do
       LHC.config.placeholder('datastore', datastore)
       class Feedback < LHS::Record
         endpoint '{+datastore}/content-ads/{campaign_id}/feedbacks'
@@ -79,7 +79,7 @@ describe LHS::Record do
     end
 
     context 'custom setters' do
-      before(:each) do
+      before do
         class Feedback
           def ratings=(ratings)
             _raw[:ratings] = ratings.map { |k, v| { name: k.to_s, value: v } }
@@ -117,7 +117,7 @@ describe LHS::Record do
       end
 
       context 'and custom getters' do
-        before(:each) do
+        before do
           class Feedback
             def ratings
               Hash[_raw[:ratings].map { |r| [r[:name].to_sym, r[:value]] }]
@@ -133,7 +133,7 @@ describe LHS::Record do
     end
 
     context 'location header' do
-      before(:each) do
+      before do
         class ContactPerson < LHS::Record
           endpoint 'http://datastore/contact_persons'
         end

data/spec/record/creation_failed_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
   context 'creation failed' do
     let(:datastore) { 'http://local.ch/v2' }
 
-    before(:each) do
+    before do
       LHC.config.placeholder(:datastore, datastore)
       class Record < LHS::Record
         endpoint '{+datastore}/{campaign_id}/feedbacks'
@@ -35,7 +35,7 @@ describe LHS::Record do
         .to_return(status: 400, body: creation_error.to_json)
       record = Record.create(name: 'Steve')
       expect(record).to be_kind_of Record
-      expect(record.errors).to be
+      expect(record.errors).to be_present
       expect(record.name).to eq 'Steve'
       expect(record.errors.include?(:ratings)).to eq true
       expect(record.errors.include?(:recommended)).to eq true

data/spec/record/definitions_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
   context 'definitions' do
     let(:datastore) { 'http://local.ch/v2' }
 
-    before(:each) do
+    before do
       LHC.config.placeholder('datastore', datastore)
       class LocalEntry < LHS::Record
         endpoint '{+datastore}/local-entries'

data/spec/record/destroy_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   context 'destroy' do
-    before(:each) do
+    before do
       class Record < LHS::Record
         endpoint 'http://datastore/history'
         endpoint 'http://datastore/history/{id}'

data/spec/record/dig_configuration_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) do
+  before do
     class Business < LHS::Record
       configuration(
         items_key: [:response, :businesses],

data/spec/record/endpoint_inheritance_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   context 'inherit endpoints' do
-    before(:each) do
+    before do
       class Base < LHS::Record
         endpoint 'records/{id}'
       end
@@ -20,7 +20,7 @@ describe LHS::Record do
   end
 
   context 'define endpoints in subclass' do
-    before(:each) do
+    before do
       class Base < LHS::Record
         endpoint 'records/{id}'
       end
@@ -40,7 +40,7 @@ describe LHS::Record do
   end
 
   context 'clashing endpoints between super and subclass' do
-    before(:each) do
+    before do
       class Base < LHS::Record
         endpoint 'records'
       end

data/spec/record/endpoint_options_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   context 'set options for an endpoint' do
-    before(:each) do
+    before do
       class Record < LHS::Record
         endpoint 'backend/v2/feedbacks/{id}', cache_expires_in: 1.day, retry: 2, cache: true
       end
@@ -20,7 +20,7 @@ describe LHS::Record do
 
     context 'deep merge endpoint options' do
 
-      before(:each) do
+      before do
         class Location < LHS::Record
           endpoint 'http://uberall/locations', headers: { privateKey: '123' }
         end

data/spec/record/endpoints_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
   context 'endpoints' do
     let(:datastore) { 'http://local.ch/v2' }
 
-    before(:each) do
+    before do
       LHC.config.placeholder(:datastore, datastore)
       class Record < LHS::Record
         endpoint '{+datastore}/entries/{entry_id}/content-ads/{campaign_id}/feedbacks'
@@ -14,9 +14,9 @@ describe LHS::Record do
     end
 
     it 'stores all the endpoints by url' do
-      expect(LHS::Record::Endpoints.all['{+datastore}/entries/{entry_id}/content-ads/{campaign_id}/feedbacks']).to be
-      expect(LHS::Record::Endpoints.all['{+datastore}/{campaign_id}/feedbacks']).to be
-      expect(LHS::Record::Endpoints.all['{+datastore}/feedbacks']).to be
+      expect(LHS::Record::Endpoints.all['{+datastore}/entries/{entry_id}/content-ads/{campaign_id}/feedbacks']).to be_present
+      expect(LHS::Record::Endpoints.all['{+datastore}/{campaign_id}/feedbacks']).to be_present
+      expect(LHS::Record::Endpoints.all['{+datastore}/feedbacks']).to be_present
     end
 
     it 'stores the endpoints of the service' do
@@ -42,7 +42,7 @@ describe LHS::Record do
     end
 
     context 'compute url from endpoint' do
-      before(:each) do
+      before do
         class Feedback < LHS::Record
           endpoint '{+datastore}/feedbacks'
           endpoint '{+datastore}/feedbacks/{id}'
@@ -56,7 +56,7 @@ describe LHS::Record do
     end
 
     context 'unsorted endpoints' do
-      before(:each) do
+      before do
         class AnotherRecord < LHS::Record
           endpoint '{+datastore}/feedbacks'
           endpoint '{+datastore}/{campaign_id}/feedbacks'
@@ -71,7 +71,7 @@ describe LHS::Record do
     end
 
     context 'includes data without considering base endpoint of parent record if url is present' do
-      before(:each) do
+      before do
         class Contract < LHS::Record
           endpoint '{+datastore}/contracts/:id'
           endpoint '{+datastore}/entry/{entry_id}/contracts'

data/spec/record/equality_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Record do
   context 'equality' do
-    before(:each) do
+    before do
       class Record < LHS::Record
         endpoint 'http://local.ch/records'
       end

data/spec/record/expanded_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) do
+  before do
     class Record < LHS::Record
       endpoint 'http://local.ch/v2/records'
     end

data/spec/record/fetch_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) do
+  before do
     class Record < LHS::Record
       endpoint 'http://datastore/records/'
     end

data/spec/record/find_by_chains_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) do
+  before do
     class Record < LHS::Record
       endpoint 'http://datastore/records/'
     end

data/spec/record/find_by_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 describe LHS::Record do
   let(:datastore) { 'http://local.ch/v2' }
 
-  before(:each) do
+  before do
     LHC.config.placeholder(:datastore, datastore)
     class Record < LHS::Record
       endpoint '{+datastore}/content-ads/{campaign_id}/feedbacks'
@@ -44,7 +44,7 @@ describe LHS::Record do
     end
 
     context 'when record has custom configurations for limit_key' do
-      before :each do
+      before do
         class Record < LHS::Record
           endpoint '{+datastore}/feedbacks/{id}'
           configuration(

data/spec/record/find_each_spec.rb

@@ -17,7 +17,7 @@ describe LHS::Collection do
 
   let(:datastore) { 'http://local.ch/v2' }
 
-  before(:each) do
+  before do
     LHC.config.placeholder('datastore', datastore)
     class Record < LHS::Record
       endpoint '{+datastore}/{campaign_id}/feedbacks'

data/spec/record/find_in_batches_spec.rb

@@ -17,7 +17,7 @@ describe LHS::Collection do
 
   let(:datastore) { 'http://local.ch/v2' }
 
-  before(:each) do
+  before do
     LHC.config.placeholder('datastore', datastore)
     class Record < LHS::Record
       endpoint '{+datastore}/{campaign_id}/feedbacks'
@@ -65,7 +65,7 @@ describe LHS::Collection do
   end
 
   context 'configured pagination' do
-    before(:each) do
+    before do
       class Record < LHS::Record
         endpoint '{+datastore}/{campaign_id}/feedbacks'
         endpoint '{+datastore}/feedbacks'

data/spec/record/find_in_parallel_spec.rb

@@ -1,14 +1,14 @@
 require 'rails_helper'
 
 describe LHS::Record do
-  before(:each) do
+  before do
     class Record < LHS::Record
       endpoint 'http://datastore/records/{id}'
     end
   end
 
   context 'find in parallel' do
-    before(:each) do
+    before do
       stub_request(:get, "http://datastore/records/1").to_return(status: 200, body: { id: 1 }.to_json)
       stub_request(:get, "http://datastore/records/3").to_return(status: 200, body: { id: 3 }.to_json)
     end

data/spec/record/find_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 describe LHS::Record do
   let(:datastore) { 'http://local.ch/v2' }
 
-  before(:each) do
+  before do
     LHC.config.placeholder(:datastore, datastore)
     class Record < LHS::Record
       endpoint '{+datastore}/content-ads/{campaign_id}/feedbacks'
@@ -15,7 +15,7 @@ describe LHS::Record do
 
   context 'find' do
     context 'finds a single unique record' do
-      before(:each) do
+      before do
         stub_request(:get, "#{datastore}/feedbacks/z12f-3asm3ngals")
           .to_return(status: 200, body: load_json(:feedback))
       end
@@ -34,7 +34,7 @@ describe LHS::Record do
     end
 
     context 'endpoint without identifier' do
-      before :each do
+      before do
         class LatestAGB < LHS::Record
           endpoint 'agbs/latest'
         end

data/spec/record/first_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 describe LHS::Record do
   let(:datastore) { 'http://local.ch/v2' }
 
-  before(:each) do
+  before do
     LHC.config.placeholder(:datastore, datastore)
     class Record < LHS::Record
       endpoint '{+datastore}/content-ads/{campaign_id}/feedbacks'
@@ -17,7 +17,7 @@ describe LHS::Record do
         .to_return(status: 200, body: load_json(:feedback))
       record = Record.first
       expect(record).to be_kind_of Record
-      expect(record.source_id).to be
+      expect(record.source_id).to be_present
     end
 
     it 'returns nil if no record was found' do

data/spec/record/handle_includes_errors_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 describe LHS::Record do
   let(:handler) { spy('handler') }
 
-  before(:each) do
+  before do
     class Record < LHS::Record
       endpoint 'http://local.ch/v2/records/{id}'
     end

data/spec/record/has_many_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
 
   let(:listing) { location.listings.first }
 
-  before(:each) do
+  before do
     stub_request(:get, 'http://uberall/locations/1')
       .to_return(body: {
         listings: [{
@@ -15,7 +15,7 @@ describe LHS::Record do
 
   context 'has_many' do
 
-    before(:each) do
+    before do
       class Location < LHS::Record
         endpoint 'http://uberall/locations'
         endpoint 'http://uberall/locations/{id}'
@@ -45,7 +45,7 @@ describe LHS::Record do
 
   context 'custom class_name' do
 
-    before(:each) do
+    before do
       module Uberall
         class Location < LHS::Record
           endpoint 'http://uberall/locations'

data/spec/record/ignore_errors_spec.rb

@@ -4,7 +4,7 @@ describe LHS::Record do
   let(:handler) { spy('handler') }
   let(:record_json) { { color: 'blue' }.to_json }
 
-  before(:each) do
+  before do
     class Record < LHS::Record
       endpoint 'http://local.ch/v2/records'
       endpoint 'http://local.ch/v2/records/{id}'
@@ -23,7 +23,7 @@ describe LHS::Record do
   end
 
   context 'multiple ignored errors' do
-    it 'ignores error if one of them is specified' do
+    it 'ignores error if first of them is specified' do
       stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(status: 401)
       record = Record
         .ignore(LHC::Unauthorized)
@@ -33,7 +33,7 @@ describe LHS::Record do
       expect(record).to eq nil
     end
 
-    it 'ignores error if one of them is specified' do
+    it 'ignores error if last of them is specified' do
       stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(status: 404)
       record = Record
         .ignore(LHC::Unauthorized)
@@ -53,15 +53,6 @@ describe LHS::Record do
     expect(record).to eq nil
   end
 
-  it 'can ignore multiple error with one ignore call' do
-    stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(status: 401)
-    record = Record
-      .ignore(LHC::Unauthorized, LHC::NotFound)
-      .where(color: 'blue')
-      .fetch
-    expect(record).to eq nil
-  end
-
   it 'can ignore multiple error with one ignore call, on chain start' do
     stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(status: 401)
     record = Record
@@ -100,7 +91,7 @@ describe LHS::Record do
       expect(record).to eq nil
     end
 
-    it 'returns nil also when ignoring errors on find' do
+    it 'returns nil also when ignoring errors on fetch' do
       stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(status: 500, body: body)
       record = Record
         .ignore(LHC::Error)
@@ -109,7 +100,7 @@ describe LHS::Record do
       expect(record).to eq nil
     end
 
-    it 'returns nil also when ignoring errors on find' do
+    it 'returns nil also when ignoring errors on find_by' do
       stub_request(:get, "http://local.ch/v2/records?color=blue&limit=1").to_return(status: 500, body: body)
       record = Record
         .ignore(LHC::Error)