lex-service_now 0.2.0 → 0.3.1

data/README.md

@@ -1,19 +1,15 @@
 # lex-service_now
 
-A LegionIO extension connecting Legion to ServiceNow via REST APIs. Covers 46 domains spanning ITSM, ITOM, ITAM, HR, Security, DevOps, and platform administration.
+A LegionIO extension connecting Legion to ServiceNow via REST APIs. Covers **66 domains** and **345 methods** spanning ITSM, ITOM, ITAM, HR, Security, GRC, CSM, DevOps, and platform administration.
 
 ## Installation
 
-Add to your Gemfile:
-
 ```ruby
 gem 'lex-service_now'
 ```
 
 ## Configuration
 
-Set credentials via Legion settings (`~/.legionio/settings/service_now.json`):
-
 ```json
 {
   "service_now": {
@@ -24,154 +20,204 @@ Set credentials via Legion settings (`~/.legionio/settings/service_now.json`):
 }
 ```
 
-OAuth2 and Bearer token auth are also supported — the most secure credentials provided are used automatically (OAuth2 > Bearer > Basic Auth).
+OAuth2 and Bearer token are also supported — the most secure credentials provided win (OAuth2 > Bearer > Basic Auth).
 
 ## Usage
 
-### Standalone Client
-
 ```ruby
-require 'legion/extensions/service_now'
-
 client = Legion::Extensions::ServiceNow::Client.new(
   url: 'https://your-instance.service-now.com',
   username: 'admin',
   password: 'secret'
 )
 
-# Incidents
+# ITSM
 client.list_incidents(sysparm_query: 'state=1^priority=1', sysparm_limit: 10)
-client.create_incident(short_description: 'Production server down', urgency: '1', impact: '1')
-client.resolve_incident(sys_id: 'abc123', close_code: 'Solved (Permanently)', close_notes: 'Fixed')
+client.create_incident(short_description: 'Production down', urgency: '1', impact: '1')
+client.resolve_incident(sys_id: 'abc', close_code: 'Solved (Permanently)', close_notes: 'Fixed')
 
-# Change Management
-client.create_normal(short_description: 'Deploy app v2.0', assignment_group: 'CAB Approval')
-client.get_change(id: 'CHG0012345')
+# Change
+client.create_normal(short_description: 'Deploy v2.0')
 client.get_approvals(id: 'CHG0012345')
 
 # CMDB
 client.list_cis(class_name: 'cmdb_ci_server', sysparm_query: 'operational_status=1')
 client.get_relationships(class_name: 'cmdb_ci_server', sys_id: 'srv001')
 
-# Service Catalog
-client.list_items(catalog_id: 'cat1')
-client.order_now(sys_id: 'item_id', quantity: 1, variables: { justification: 'Project work' })
+# Generic table escape hatch
+client.table_list(table_name: 'u_custom_table', sysparm_query: 'active=true')
+client.table_create(table_name: 'u_custom_table', name: 'New Record', u_field: 'value')
 
-# Users & Groups
-client.get_user_by_email(email: 'jdoe@company.com')
-client.list_group_members(group_sys_id: 'network_team_id')
+# Pagination helper — automatically fetches all pages
+all_incidents = client.paginate(:list_incidents, sysparm_query: 'state=1')
 
-# Generic Table API (escape hatch for any table)
-client.table_list(table_name: 'u_custom_table', sysparm_query: 'active=true')
+# Retry helper — retries on rate limits and server errors
+client.with_retry(max_retries: 3) { client.create_incident(short_description: 'Issue') }
+
+# Error handling
+begin
+  client.get_incident(sys_id: 'nonexistent')
+rescue Legion::Extensions::ServiceNow::Errors::NotFoundError => e
+  puts "Not found: #{e.message} (status: #{e.status})"
+end
 ```
 
-## Supported Domains
+## Supported Domains (66 total)
 
 ### ITSM
-| Domain | Methods | Table |
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| Change | 14 | `sn_chg_rest` API |
-| Incident | 6 | `incident` |
-| Problem | 6 | `problem` |
-| Request/RITM | 6 | `sc_request`, `sc_req_item` |
-| Approval | 5 | `sysapproval_approver` |
-| Task | 5 | `task` |
-| SLA | 5 | `contract_sla`, `task_sla` |
+| Change | 14 | normal/emergency/standard + change_tasks/conflicts/approvals |
+| Incident | 6 | CRUD + resolve |
+| Problem | 6 | CRUD + close |
+| Request/RITM | 6 | sc_request + sc_req_item |
+| Approval | 5 | approve/reject + list_for_record |
+| Task | 5 | CRUD + add_work_note |
+| SLA | 5 | definitions + task SLAs |
+| CatalogTask | 4 | sc_task list/get/update/close |
 
 ### CMDB & Discovery
-| Domain | Methods | Table |
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| CMDB Instance | 7 | `/api/now/cmdb/instance` |
-| CMDB Meta | 2 | `/api/now/doc/meta` |
-| Discovery | 5 | `discovery_schedule`, `discovery_log` |
-| MID Server | 5 | `ecc_agent` |
+| CMDB Instance | 7 | CI CRUD + relationships |
+| CMDB Meta | 2 | hierarchy + class metadata |
+| CiRelationship | 5 | cmdb_rel_type + cmdb_rel_ci |
+| CmdbHealth | 4 | duplicates, stale CIs, health dashboard |
+| Discovery | 5 | schedules/logs/devices |
+| MID Server | 5 | ecc_agent CRUD + capabilities |
 
 ### Service Catalog
-| Domain | Methods | Table |
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| Service Catalog | 11 | `/api/sn_sc/servicecatalog` |
-| Catalog Variable | 5 | `item_option_new` |
+| Service Catalog | 11 | catalogs/items/cart/order |
+| Catalog Variable | 5 | item_option_new CRUD |
 
-### Knowledge & Content
-| Domain | Methods | Table |
+### Knowledge
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| Knowledge | 5 | `/api/sn_km_api/knowledge` |
-| Survey | 5 | `survey`, `asmt_assessment_instance` |
+| Knowledge | 5 | article CRUD |
+| Knowledge Base | 6 | kb_knowledge_base CRUD + categories |
+| Knowledge Feedback | 4 | feedback + views |
 
 ### User & Organization
-| Domain | Methods | Table |
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| User | 7 | `sys_user` |
-| UserGroup | 9 | `sys_user_group`, `sys_user_grmember` |
-| Account | 4 | `account` |
-| Location | 5 | `cmn_location` |
-| Department | 5 | `cmn_department` |
-| Company | 5 | `core_company` |
-| Cost Center | 5 | `cmn_cost_center` |
+| User | 7 | CRUD + lookup_by_username/email |
+| UserGroup | 9 | CRUD + member management |
+| Account | 4 | account CRUD |
+| Location | 5 | cmn_location CRUD |
+| Department | 5 | cmn_department CRUD |
+| Company | 5 | core_company CRUD |
+| Cost Center | 5 | cmn_cost_center CRUD |
+| Vendor | 5 | vendor-filtered company records |
 
 ### Asset & Contract Management
-| Domain | Methods | Table |
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| Asset | 6 | `alm_asset`, `alm_hardware` |
-| Contract | 5 | `ast_contract` |
+| Asset | 6 | alm_asset CRUD + hardware |
+| Contract | 5 | ast_contract CRUD |
+| License | 4 | agreements + allocations + installed software |
 
-### Security
-| Domain | Methods | Table |
+### Security & Compliance
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| Security Incident | 5 | `sn_si_incident` |
+| Security Incident | 5 | sn_si_incident CRUD |
+| Access Control | 5 | sys_security_acl CRUD |
+| GRC | 7 | risks + controls + audits + policies |
 
-### HR
-| Domain | Methods | Table |
+### HR & Customer Service
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| HR Case | 5 | `sn_hr_core_case` |
+| HR Case | 5 | sn_hr_core_case CRUD |
+| CSM | 6 | customer cases + contacts |
 
 ### Project & Release
-| Domain | Methods | Table |
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| Project | 6 | `pm_project`, `pm_project_task` |
-| Release | 5 | `rm_release` |
+| Project | 6 | pm_project CRUD + tasks |
+| Release | 5 | rm_release CRUD |
 
 ### Platform Administration
-| Domain | Methods | Table |
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| System Property | 6 | `sys_properties` |
-| Update Set | 6 | `sys_update_set`, `sys_update_xml` |
-| Script Include | 5 | `sys_script_include` |
-| Business Rule | 5 | `sys_script` |
-| Scheduled Job | 5 | `sysauto_script` |
-| Workflow | 6 | `wf_workflow`, `wf_context` |
-| Flow/Subflow | 6 | `/api/sn_fd` |
-| Audit | 3 | `sys_audit` |
+| System Property | 6 | sys_properties CRUD |
+| Update Set | 6 | CRUD + list changes |
+| Script Include | 5 | sys_script_include CRUD |
+| Business Rule | 5 | sys_script CRUD |
+| Script Action | 5 | sysevent_script_action CRUD |
+| Scheduled Job | 5 | sysauto_script CRUD |
+| UI Policy | 5 | sys_ui_policy CRUD |
+| UI Action | 5 | sys_ui_action CRUD |
+| Workflow | 6 | wf_workflow + contexts |
+| Flow/Subflow | 6 | sn_fd flows + execution |
+| Audit | 3 | sys_audit + field changes |
+| Deprecation Log | 4 | upgrade history + deprecations |
 
 ### ITOM & Monitoring
-| Domain | Methods | Table |
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| Event | 3 | `sysevent` |
-| Performance Analytics | 5 | `/api/now/pa` |
+| Event | 3 | sysevent CRUD |
+| Performance Analytics | 5 | widgets/scorecards/indicators |
+| Metric | 4 | definitions + instances |
 
 ### Communications
-| Domain | Methods | Table |
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| Notification | 5 | `sysevent_email_action` |
-| Email Log | 3 | `sys_email` |
+| Notification | 5 | sysevent_email_action CRUD |
+| Email Log | 3 | sys_email list/get/list_for_record |
 
 ### Field Service
-| Domain | Methods | Table |
+| Domain | Methods | Notes |
+|--------|---------|-------|
+| Work Order | 6 | wm_order CRUD + tasks + close |
+| On-Call | 5 | schedules + members + who_is_on_call |
+
+### Platform Modules
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| Work Order | 6 | `wm_order`, `wm_task` |
-| On-Call | 5 | `cmn_rota`, `cmn_rota_member` |
+| Service Portal | 6 | portals/pages/widgets |
+| Integration Hub | 5 | spokes/connections/credentials |
 
-### Utilities
-| Domain | Methods | Table |
+### Utilities & Reference
+| Domain | Methods | Notes |
 |--------|---------|-------|
-| Table (generic) | 5 | Any table via `/api/now/table/{table}` |
-| Import Set | 2 | `/api/now/import` |
-| Aggregate | 1 | `/api/now/stats/{table}` |
-| Attachment | 5 | `/api/now/attachment` |
+| Table (generic) | 5 | Any table via /api/now/table/{table} |
+| Import Set | 2 | /api/now/import |
+| Aggregate | 1 | count/sum/avg/min/max on any table |
+| Attachment | 5 | upload/download files |
+| Survey | 5 | assessments + instances + responses |
+| Tag | 7 | label + label_entry CRUD |
+| Currency | 3 | fx_currency + fx_rate |
+| Calendar | 6 | cmn_schedule CRUD + entries |
+
+## Helpers
+
+### Pagination
+```ruby
+all_results = client.paginate(:list_incidents, sysparm_query: 'state=1')
+```
+Automatically iterates through all pages.
+
+### Retry
+```ruby
+client.with_retry(max_retries: 3) { client.create_incident(...) }
+```
+Retries on `RateLimitError` (exponential backoff) and `ServerError`. Raises immediately on auth errors.
+
+### Error Handling
+```ruby
+rescue Legion::Extensions::ServiceNow::Errors::AuthenticationError => e  # 401
+rescue Legion::Extensions::ServiceNow::Errors::AuthorizationError => e   # 403
+rescue Legion::Extensions::ServiceNow::Errors::NotFoundError => e        # 404
+rescue Legion::Extensions::ServiceNow::Errors::UnprocessableError => e   # 422
+rescue Legion::Extensions::ServiceNow::Errors::RateLimitError => e       # 429
+rescue Legion::Extensions::ServiceNow::Errors::ServerError => e          # 5xx
+rescue Legion::Extensions::ServiceNow::Errors::ServiceNowError => e      # all others
+```
 
-## LLM Skills
+## LLM Skills (10 total)
 
-When `legion-llm` is available, 10 workflow skills are registered automatically:
+Registered automatically when `legion-llm` is available:
 
 | Skill | Trigger Words |
 |-------|--------------|
@@ -183,17 +229,17 @@ When `legion-llm` is available, 10 workflow skills are registered automatically:
 | `servicenow:problem_management` | PRB, problem, root cause, RCA |
 | `servicenow:request_fulfillment` | RITM, request item, fulfillment |
 | `servicenow:approval_workflow` | approval, approve, reject |
-| `servicenow:asset_management` | asset, hardware, inventory, ALM |
+| `servicenow:asset_management` | asset, hardware, inventory |
 | `servicenow:security_incident_response` | SIR, security incident, breach |
 
 ## Development
 
 ```bash
 bundle install
-bundle exec rspec        # 217 examples, 0 failures
+bundle exec rspec        # 372 examples, 0 failures
 bundle exec rubocop      # 0 offenses
 ```
 
 ## License
 
-MIT — see [LICENSE](LICENSE).
+MIT

data/lex-service_now.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.email         = ['matthewdiverson@gmail.com']
 
   spec.summary       = 'LEX::ServiceNow'
-  spec.description   = 'Connects Legion to ServiceNow via Change Management, CMDB, Knowledge, Service Catalog, and Account REST APIs'
+  spec.description   = 'Connects Legion to ServiceNow via 60+ REST API domains spanning ITSM, ITOM, ITAM, HR, Security, DevOps, and platform administration'
   spec.homepage      = 'https://github.com/LegionIO/lex-service_now'
   spec.license       = 'MIT'
   spec.required_ruby_version = '>= 3.4'

data/lib/legion/extensions/service_now/access_control/runners/access_control.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+module Legion
+  module Extensions
+    module ServiceNow
+      module AccessControl
+        module Runners
+          module AccessControl
+            include Legion::Extensions::ServiceNow::Helpers::Client
+
+            def list_acls(sysparm_limit: 100, sysparm_offset: 0,
+                          sysparm_query: nil, **)
+              params = { sysparm_limit: sysparm_limit, sysparm_offset: sysparm_offset }
+              params[:sysparm_query] = sysparm_query if sysparm_query
+              resp = get('/api/now/table/sys_security_acl', params, **)
+              { acls: resp.body['result'] }
+            end
+
+            def get_acl(sys_id:, **)
+              resp = get("/api/now/table/sys_security_acl/#{sys_id}", {}, **)
+              { acl: resp.body['result'] }
+            end
+
+            def create_acl(name:, type:, operation:, active: true,
+                           script: nil, condition: nil, **)
+              body = { name: name, type: type, operation: operation, active: active }
+              body[:script]    = script if script
+              body[:condition] = condition if condition
+              resp = post('/api/now/table/sys_security_acl', body, **)
+              { acl: resp.body['result'] }
+            end
+
+            def update_acl(sys_id:, active: nil, script: nil, condition: nil, **)
+              body = {}
+              body[:active]    = active unless active.nil?
+              body[:script]    = script if script
+              body[:condition] = condition if condition
+              resp = patch("/api/now/table/sys_security_acl/#{sys_id}", body, **)
+              { acl: resp.body['result'] }
+            end
+
+            def delete_acl(sys_id:, **)
+              resp = delete("/api/now/table/sys_security_acl/#{sys_id}", **)
+              { deleted: resp.status == 204, sys_id: sys_id }
+            end
+
+            include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
+                                                        Legion::Extensions::Helpers.const_defined?(:Lex, false)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/legion/extensions/service_now/account/runners/account.rb

@@ -11,12 +11,12 @@ module Legion
             def list_accounts(sysparm_limit: 100, sysparm_offset: 0, sysparm_query: nil, **)
               params = { sysparm_limit: sysparm_limit, sysparm_offset: sysparm_offset }
               params[:sysparm_query] = sysparm_query if sysparm_query
-              resp = connection(**).get('/api/now/account', params)
+              resp = get('/api/now/account', params, **)
               { accounts: resp.body['result'] }
             end
 
             def get_account(sys_id:, **)
-              resp = connection(**).get("/api/now/account/#{sys_id}")
+              resp = get("/api/now/account/#{sys_id}", {}, **)
               { account: resp.body['result'] }
             end
 
@@ -24,7 +24,7 @@ module Legion
               body = { name: name }
               body[:phone] = phone if phone
               body[:email] = email if email
-              resp = connection(**).post('/api/now/account', body)
+              resp = post('/api/now/account', body, **)
               { account: resp.body['result'] }
             end
 
@@ -33,7 +33,7 @@ module Legion
               body[:name]  = name if name
               body[:phone] = phone if phone
               body[:email] = email if email
-              resp = connection(**).patch("/api/now/account/#{sys_id}", body)
+              resp = patch("/api/now/account/#{sys_id}", body, **)
               { account: resp.body['result'] }
             end
 

data/lib/legion/extensions/service_now/aggregate/runners/aggregate.rb

@@ -21,7 +21,7 @@ module Legion
               params[:sysparm_query]       = sysparm_query if sysparm_query
               params[:sysparm_group_by]    = sysparm_group_by if sysparm_group_by
               params[:sysparm_having]      = sysparm_having if sysparm_having
-              resp = connection(**).get("/api/now/stats/#{table_name}", params)
+              resp = get("/api/now/stats/#{table_name}", params, **)
               { stats: resp.body['result'] }
             end
 

data/lib/legion/extensions/service_now/approval/runners/approval.rb

@@ -11,32 +11,32 @@ module Legion
             def list_approvals(sysparm_limit: 100, sysparm_offset: 0, sysparm_query: nil, **)
               params = { sysparm_limit: sysparm_limit, sysparm_offset: sysparm_offset }
               params[:sysparm_query] = sysparm_query if sysparm_query
-              resp = connection(**).get('/api/now/table/sysapproval_approver', params)
+              resp = get('/api/now/table/sysapproval_approver', params, **)
               { approvals: resp.body['result'] }
             end
 
             def get_approval(sys_id:, **)
-              resp = connection(**).get("/api/now/table/sysapproval_approver/#{sys_id}")
+              resp = get("/api/now/table/sysapproval_approver/#{sys_id}", {}, **)
               { approval: resp.body['result'] }
             end
 
             def approve(sys_id:, comments: nil, **)
               body = { state: 'approved' }
               body[:comments] = comments if comments
-              resp = connection(**).patch("/api/now/table/sysapproval_approver/#{sys_id}", body)
+              resp = patch("/api/now/table/sysapproval_approver/#{sys_id}", body, **)
               { approval: resp.body['result'] }
             end
 
             def reject(sys_id:, comments: nil, **)
               body = { state: 'rejected' }
               body[:comments] = comments if comments
-              resp = connection(**).patch("/api/now/table/sysapproval_approver/#{sys_id}", body)
+              resp = patch("/api/now/table/sysapproval_approver/#{sys_id}", body, **)
               { approval: resp.body['result'] }
             end
 
             def list_approvals_for_record(document_id:, **)
               params = { sysparm_query: "document_id=#{document_id}", sysparm_limit: 100 }
-              resp = connection(**).get('/api/now/table/sysapproval_approver', params)
+              resp = get('/api/now/table/sysapproval_approver', params, **)
               { approvals: resp.body['result'] }
             end
 

data/lib/legion/extensions/service_now/asset/runners/asset.rb

@@ -13,12 +13,12 @@ module Legion
               params = { sysparm_limit: sysparm_limit, sysparm_offset: sysparm_offset }
               params[:sysparm_query]  = sysparm_query if sysparm_query
               params[:sysparm_fields] = sysparm_fields if sysparm_fields
-              resp = connection(**).get('/api/now/table/alm_asset', params)
+              resp = get('/api/now/table/alm_asset', params, **)
               { assets: resp.body['result'] }
             end
 
             def get_asset(sys_id:, **)
-              resp = connection(**).get("/api/now/table/alm_asset/#{sys_id}")
+              resp = get("/api/now/table/alm_asset/#{sys_id}", {}, **)
               { asset: resp.body['result'] }
             end
 
@@ -28,7 +28,7 @@ module Legion
               body[:serial_number] = serial_number if serial_number
               body[:assigned_to]   = assigned_to if assigned_to
               body[:state]         = state if state
-              resp = connection(**).post('/api/now/table/alm_asset', body)
+              resp = post('/api/now/table/alm_asset', body, **)
               { asset: resp.body['result'] }
             end
 
@@ -39,19 +39,19 @@ module Legion
               body[:assigned_to]   = assigned_to if assigned_to
               body[:location]      = location if location
               body[:serial_number] = serial_number if serial_number
-              resp = connection(**).patch("/api/now/table/alm_asset/#{sys_id}", body)
+              resp = patch("/api/now/table/alm_asset/#{sys_id}", body, **)
               { asset: resp.body['result'] }
             end
 
             def delete_asset(sys_id:, **)
-              resp = connection(**).delete("/api/now/table/alm_asset/#{sys_id}")
+              resp = delete("/api/now/table/alm_asset/#{sys_id}", **)
               { deleted: resp.status == 204, sys_id: sys_id }
             end
 
             def list_hardware(sysparm_limit: 100, sysparm_offset: 0, sysparm_query: nil, **)
               params = { sysparm_limit: sysparm_limit, sysparm_offset: sysparm_offset }
               params[:sysparm_query] = sysparm_query if sysparm_query
-              resp = connection(**).get('/api/now/table/alm_hardware', params)
+              resp = get('/api/now/table/alm_hardware', params, **)
               { hardware: resp.body['result'] }
             end
 

data/lib/legion/extensions/service_now/attachment/runners/attachment.rb

@@ -14,17 +14,17 @@ module Legion
                                  sysparm_offset: 0, **)
               params = { sysparm_limit: sysparm_limit, sysparm_offset: sysparm_offset }
               params[:sysparm_query] = "table_name=#{table_name}^table_sys_id=#{table_sys_id}" if table_name && table_sys_id
-              resp = connection(**).get('/api/now/attachment', params)
+              resp = get('/api/now/attachment', params, **)
               { attachments: resp.body['result'] }
             end
 
             def get_attachment(sys_id:, **)
-              resp = connection(**).get("/api/now/attachment/#{sys_id}")
+              resp = get("/api/now/attachment/#{sys_id}", {}, **)
               { attachment: resp.body['result'] }
             end
 
             def get_attachment_file(sys_id:, **)
-              resp = connection(**).get("/api/now/attachment/#{sys_id}/file")
+              resp = get("/api/now/attachment/#{sys_id}/file", {}, **)
               { content: resp.body, status: resp.status }
             end
 
@@ -41,7 +41,7 @@ module Legion
             end
 
             def delete_attachment(sys_id:, **)
-              resp = connection(**).delete("/api/now/attachment/#{sys_id}")
+              resp = delete("/api/now/attachment/#{sys_id}", **)
               { deleted: resp.status == 204, sys_id: sys_id }
             end
 

data/lib/legion/extensions/service_now/audit/runners/audit.rb

@@ -17,12 +17,12 @@ module Legion
               elsif sysparm_query
                 params[:sysparm_query] = sysparm_query
               end
-              resp = connection(**).get('/api/now/table/sys_audit', params)
+              resp = get('/api/now/table/sys_audit', params, **)
               { audit_records: resp.body['result'] }
             end
 
             def get_audit_record(sys_id:, **)
-              resp = connection(**).get("/api/now/table/sys_audit/#{sys_id}")
+              resp = get("/api/now/table/sys_audit/#{sys_id}", {}, **)
               { audit_record: resp.body['result'] }
             end
 
@@ -31,7 +31,7 @@ module Legion
               query = "tablename=#{tablename}^documentkey=#{documentkey}"
               query += "^fieldname=#{fieldname}" if fieldname
               params = { sysparm_query: query, sysparm_limit: sysparm_limit }
-              resp = connection(**).get('/api/now/table/sys_audit', params)
+              resp = get('/api/now/table/sys_audit', params, **)
               { field_changes: resp.body['result'] }
             end
 

data/lib/legion/extensions/service_now/business_rule/runners/business_rule.rb

@@ -12,12 +12,12 @@ module Legion
                                     sysparm_query: nil, **)
               params = { sysparm_limit: sysparm_limit, sysparm_offset: sysparm_offset }
               params[:sysparm_query] = sysparm_query if sysparm_query
-              resp = connection(**).get('/api/now/table/sys_script', params)
+              resp = get('/api/now/table/sys_script', params, **)
               { business_rules: resp.body['result'] }
             end
 
             def get_business_rule(sys_id:, **)
-              resp = connection(**).get("/api/now/table/sys_script/#{sys_id}")
+              resp = get("/api/now/table/sys_script/#{sys_id}", {}, **)
               { business_rule: resp.body['result'] }
             end
 
@@ -34,7 +34,7 @@ module Legion
                 action_delete: action_delete,
                 active:        active
               }
-              resp = connection(**).post('/api/now/table/sys_script', body)
+              resp = post('/api/now/table/sys_script', body, **)
               { business_rule: resp.body['result'] }
             end
 
@@ -44,12 +44,12 @@ module Legion
               body[:script] = script if script
               body[:active] = active unless active.nil?
               body[:name]   = name if name
-              resp = connection(**).patch("/api/now/table/sys_script/#{sys_id}", body)
+              resp = patch("/api/now/table/sys_script/#{sys_id}", body, **)
               { business_rule: resp.body['result'] }
             end
 
             def delete_business_rule(sys_id:, **)
-              resp = connection(**).delete("/api/now/table/sys_script/#{sys_id}")
+              resp = delete("/api/now/table/sys_script/#{sys_id}", **)
               { deleted: resp.status == 204, sys_id: sys_id }
             end