lex-service_now 0.2.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dbf260038f432fcd485cb48c125da454b3f796b3165cefe76675b5fea1c1a336
-  data.tar.gz: 1a82c55c3644116943755c214c527173b928a499437cb3b75aa897b25afbf1bf
+  metadata.gz: f18e533db37ce9fdaf5c08842bd1c7f147a5e395a977efe7d7ce4d5c865fbe58
+  data.tar.gz: c72de9f35aa66e0499592cbfe21cf6a65d951e6943e6b689d3f97c2cee5762ff
 SHA512:
-  metadata.gz: 552a514871309be55f0c41b899724cc833649741bbea34be70695e3b8e3f784f40952dd2afb6244163438b8214808b610cd267f871963cd9d74bd67c7ab0158f
-  data.tar.gz: 8e37565b25abc8382372e77bb2e02acb14ef894b340ee823346671ea9e5beff9256f9af1e32ddb25780bfb3bb2790684164b6805d05125fec8fc55467b52bf65
+  metadata.gz: 25217fe95b96c91c97dc82fad4d2fdfedd04880ed910f35a7a2a24841f3210400a2a3bf95876b09a833bea69b887e64f7994b41ad0773b98cb8d8865d60c0a2d
+  data.tar.gz: 9d9ebe39b1c39b8e2272f28ec4a8a0580758e056e88fa60b5dfbd533ddfbd2e910af73e20a3f79ff6d7a41cc385eae3a81a1fb7c8a2d1f4b7319a2afde31c860

data/CHANGELOG.md

@@ -1,58 +1,60 @@
 # Changelog
 
+## [0.3.1] - 2026-05-25
+
+### Fixed
+- Skills: move `steps` DSL declaration after method definitions in all 10 skills to fix
+  `InvalidSkill` error on load (`validate_steps!` requires methods to be defined first)
+
+## [0.3.0] - 2026-04-22
+
+### Added
+- Tag runner (7 methods) — label + label_entry CRUD, tag/untag records
+- Metric runner (4 methods) — metric_definition + metric_instance
+- Currency runner (3 methods) — fx_currency + fx_rate
+- Calendar runner (6 methods) — cmn_schedule CRUD + entries
+- KnowledgeFeedback runner (4 methods) — kb_feedback + kb_view
+- License runner (4 methods) — license_agreement + allocations + installed software
+- DeprecationLog runner (4 methods) — upgrade history + deprecation log
+- CmdbHealth runner (4 methods) — duplicate CIs, stale CIs, health dashboard
+- ServicePortal runner (6 methods) — portals, pages, widgets
+- GRC runner (7 methods) — risks, controls, audits, policies
+- CSM runner (6 methods) — customer service cases and contacts
+- IntegrationHub runner (5 methods) — spokes, action types, connections, credentials
+- Vendor runner (5 methods) — vendor-filtered company records
+- CiRelationship runner (5 methods) — cmdb_rel_type + cmdb_rel_ci
+- ScriptAction runner (5 methods) — sysevent_script_action CRUD
+- UiPolicy runner (5 methods) — sys_ui_policy CRUD
+- UiAction runner (5 methods) — sys_ui_action CRUD
+- AccessControl runner (5 methods) — sys_security_acl CRUD
+- CatalogTask runner (4 methods) — sc_task list/get/update/close
+- KnowledgeBase runner (6 methods) — kb_knowledge_base CRUD + categories
+- Helpers::Pagination — auto-fetches all pages for any list method
+- Helpers::Retry — retries on RateLimitError/ServerError with exponential backoff
+- Helpers::Client#handle_response — raises typed errors on non-2xx responses
+- Errors module — AuthenticationError, AuthorizationError, NotFoundError,
+  UnprocessableError, RateLimitError, ServerError
+
+### Fixed
+- Table runner: table_create/table_update no longer leak auth kwargs into request body
+- Change runner: task methods renamed to list_change_tasks/create_change_task/
+  update_change_task/delete_change_task to avoid collision with Task runner
+
 ## [0.2.0] - 2026-04-22
 
 ### Added
-- Incident runner (6 methods)
-- Problem runner (6 methods)
-- Attachment runner (5 methods) with multipart upload support
-- Table runner (5 methods) — generic CRUD escape hatch for any table
-- Aggregate runner (1 method) — stats/count/sum/avg queries
-- User runner (7 methods) including lookup by username and email
-- UserGroup runner (9 methods) including member management
-- Request/RITM runner (6 methods)
-- Approval runner (5 methods) — approve, reject, list_for_record
-- Task runner (5 methods) including add_work_note
-- SLA runner (5 methods) — definitions and task SLA tracking
-- ImportSet runner (2 methods)
-- Event runner (3 methods)
-- PerformanceAnalytics runner (5 methods) — widgets, scorecards, indicators
-- Flow/Subflow runner (6 methods)
-- Notification runner (5 methods)
-- EmailLog runner (3 methods)
-- Audit runner (3 methods) — field change history
-- SystemProperty runner (6 methods)
-- Asset runner (6 methods) including hardware
-- Location runner (5 methods)
-- Department runner (5 methods)
-- Company runner (5 methods)
-- Project runner (6 methods) including project tasks
-- Release runner (5 methods)
-- HrCase runner (5 methods)
-- SecurityIncident runner (5 methods)
-- UpdateSet runner (6 methods) including change listing
-- ScriptInclude runner (5 methods)
-- BusinessRule runner (5 methods)
-- ScheduledJob runner (5 methods)
-- OnCall runner (5 methods) — schedules, members, who_is_on_call
-- Survey runner (5 methods) — instances and responses
-- Contract runner (5 methods)
-- CostCenter runner (5 methods)
-- WorkOrder runner (6 methods) including tasks
-- Discovery runner (5 methods)
-- MidServer runner (5 methods)
-- CatalogVariable runner (5 methods)
-- Workflow runner (6 methods) — contexts and cancellation
-- 10 LLM skills: Incident, ChangeRequest, CmdbQuery, Knowledge, ServiceCatalog, ProblemManagement, RequestFulfillment, ApprovalWorkflow, AssetManagement, SecurityIncidentResponse
+- Incident, Problem, Attachment, Table, Aggregate, User, UserGroup runners
+- Request/RITM, Approval, Task, SLA, ImportSet, Event runners
+- PerformanceAnalytics, Flow/Subflow runners
+- Notification, EmailLog, Audit, SystemProperty runners
+- Asset, Location, Department, Company, CostCenter runners
+- Project, Release, SecurityIncident, HrCase runners
+- UpdateSet, ScriptInclude, BusinessRule, ScheduledJob runners
+- OnCall, Survey, Contract, WorkOrder, Discovery, MidServer runners
+- CatalogVariable, Workflow runners
+- 10 LLM skills
 
 ## [0.1.0] - 2026-04-22
 
 ### Added
-- Initial release
-- Change Management API (14 methods)
-- CMDB Instance API (7 methods)
-- CMDB Meta API (2 methods)
-- Knowledge API (5 methods)
-- Service Catalog API (11 methods)
-- Account API (4 methods)
-- LLM skill triggers for Incident, ChangeRequest, CmdbQuery, Knowledge, ServiceCatalog
+- Initial release with Change, CMDB Instance/Meta, Knowledge, Service Catalog, Account

data/CLAUDE.md

@@ -6,9 +6,9 @@
 
 ## Purpose
 
-Comprehensive Legion Extension connecting LegionIO to ServiceNow via REST APIs. Covers 46 domains spanning ITSM, ITOM, ITAM, HR, Security, DevOps, and platform administration.
+Comprehensive Legion Extension connecting LegionIO to ServiceNow via REST APIs. Covers **66 domains** and **346 methods** spanning ITSM, ITOM, ITAM, HR, Security, GRC, CSM, DevOps, and platform administration.
 
-**Version**: 0.2.0
+**Version**: 0.3.0
 **GitHub**: https://github.com/LegionIO/lex-service_now
 **License**: MIT
 
@@ -16,106 +16,134 @@ Comprehensive Legion Extension connecting LegionIO to ServiceNow via REST APIs.
 
 ```
 Legion::Extensions::ServiceNow
++-- Errors                              # AuthenticationError, AuthorizationError,
+|                                       # NotFoundError, UnprocessableError,
+|                                       # RateLimitError, ServerError
 +-- Helpers/
-|   +-- Client             # connection() with OAuth2→Bearer→Basic auth priority fallback
+|   +-- Client          # connection() with OAuth2→Bearer→Basic fallback
+|   |                   # handle_response() raises typed errors on non-2xx
+|   +-- Pagination      # paginate(method, **opts) auto-fetches all pages
+|   +-- Retry           # with_retry(max_retries:) retries on rate limit/server errors
 +-- ITSM/
-|   +-- Change::Runners::Change          (14 methods) — normal/emergency/standard + tasks/conflicts/approvals
-|   +-- Incident::Runners::Incident      (6 methods)  — CRUD + resolve
-|   +-- Problem::Runners::Problem        (6 methods)  — CRUD + close
-|   +-- Request::Runners::Request        (6 methods)  — sc_request + sc_req_item
-|   +-- Approval::Runners::Approval      (5 methods)  — approve/reject + list_for_record
-|   +-- Task::Runners::Task              (5 methods)  — CRUD + add_work_note
-|   +-- Sla::Runners::Sla               (5 methods)  — definitions + task SLAs
+|   +-- Change          (14) — normal/emergency/standard + change_tasks/conflicts/approvals
+|   +-- Incident         (6) — CRUD + resolve
+|   +-- Problem          (6) — CRUD + close
+|   +-- Request          (6) — sc_request + sc_req_item
+|   +-- Approval         (5) — approve/reject + list_for_record
+|   +-- Task             (5) — CRUD + add_work_note
+|   +-- Sla              (5) — definitions + task SLAs
+|   +-- CatalogTask       (4) — sc_task list/get/update/close
 +-- CMDB/
-|   +-- Cmdb::Instance::Runners::Instance  (7 methods)  — CI CRUD + relationships
-|   +-- Cmdb::Meta::Runners::Meta          (2 methods)  — hierarchy + class metadata
-+-- Knowledge/
-|   +-- Knowledge::Runners::Knowledge      (5 methods)  — article CRUD
+|   +-- Cmdb::Instance   (7) — CI CRUD + relationships
+|   +-- Cmdb::Meta        (2) — hierarchy + class metadata
+|   +-- CiRelationship    (5) — cmdb_rel_type + cmdb_rel_ci
+|   +-- CmdbHealth        (4) — duplicates, stale CIs, health dashboard
 +-- ServiceCatalog/
-|   +-- ServiceCatalog::Runners::ServiceCatalog  (11 methods) — catalogs/items/cart/order
-|   +-- CatalogVariable::Runners::CatalogVariable (5 methods) — item variables CRUD
-+-- User Management/
-|   +-- User::Runners::User              (7 methods)  — CRUD + lookup_by_username/email
-|   +-- UserGroup::Runners::UserGroup    (9 methods)  — CRUD + member management
-|   +-- Account::Runners::Account        (4 methods)  — core account CRUD
-+-- Assets/
-|   +-- Asset::Runners::Asset            (6 methods)  — alm_asset CRUD + hardware
-|   +-- Contract::Runners::Contract      (5 methods)  — ast_contract CRUD
+|   +-- ServiceCatalog   (11) — catalogs/items/cart/order
+|   +-- CatalogVariable   (5) — item_option_new CRUD
++-- Knowledge/
+|   +-- Knowledge         (5) — article CRUD
+|   +-- KnowledgeBase     (6) — kb_knowledge_base CRUD + categories
+|   +-- KnowledgeFeedback (4) — feedback + views
++-- UserManagement/
+|   +-- User              (7) — CRUD + lookup_by_username/email
+|   +-- UserGroup         (9) — CRUD + member management
+|   +-- Account           (4) — account CRUD
 +-- Organization/
-|   +-- Location::Runners::Location      (5 methods)  — cmn_location CRUD
-|   +-- Department::Runners::Department  (5 methods)  — cmn_department CRUD
-|   +-- Company::Runners::Company        (5 methods)  — core_company CRUD
-|   +-- CostCenter::Runners::CostCenter  (5 methods)  — cmn_cost_center CRUD
-+-- Project & Release/
-|   +-- Project::Runners::Project        (6 methods)  — pm_project CRUD + tasks
-|   +-- Release::Runners::Release        (5 methods)  — rm_release CRUD
+|   +-- Location          (5) — cmn_location CRUD
+|   +-- Department        (5) — cmn_department CRUD
+|   +-- Company           (5) — core_company CRUD
+|   +-- CostCenter        (5) — cmn_cost_center CRUD
+|   +-- Vendor            (5) — vendor-filtered company records
++-- Assets/
+|   +-- Asset             (6) — alm_asset CRUD + hardware
+|   +-- Contract          (5) — ast_contract CRUD
+|   +-- License           (4) — agreements + allocations + installed software
 +-- Security/
-|   +-- SecurityIncident::Runners::SecurityIncident  (5 methods) — sn_si_incident CRUD
+|   +-- SecurityIncident  (5) — sn_si_incident CRUD
+|   +-- AccessControl     (5) — sys_security_acl CRUD
+|   +-- Grc               (7) — risks + controls + audits + policies
 +-- HR/
-|   +-- HrCase::Runners::HrCase          (5 methods)  — sn_hr_core_case CRUD
-+-- Platform Admin/
-|   +-- SystemProperty::Runners::SystemProperty  (6 methods) — sys_properties CRUD
-|   +-- UpdateSet::Runners::UpdateSet    (6 methods)  — CRUD + list changes
-|   +-- ScriptInclude::Runners::ScriptInclude  (5 methods)  — sys_script_include CRUD
-|   +-- BusinessRule::Runners::BusinessRule    (5 methods)  — sys_script CRUD
-|   +-- ScheduledJob::Runners::ScheduledJob    (5 methods)  — sysauto_script CRUD
-|   +-- Workflow::Runners::Workflow       (6 methods)  — wf_workflow + contexts
-|   +-- Flow::Runners::Flow              (6 methods)  — sn_fd flow execute + subflows
-|   +-- Audit::Runners::Audit            (3 methods)  — sys_audit + field changes
+|   +-- HrCase            (5) — sn_hr_core_case CRUD
++-- CustomerService/
+|   +-- Csm               (6) — customer cases + contacts
++-- ProjectRelease/
+|   +-- Project           (6) — pm_project CRUD + tasks
+|   +-- Release           (5) — rm_release CRUD
++-- PlatformAdmin/
+|   +-- SystemProperty    (6) — sys_properties CRUD
+|   +-- UpdateSet         (6) — CRUD + list changes
+|   +-- ScriptInclude     (5) — sys_script_include CRUD
+|   +-- BusinessRule      (5) — sys_script CRUD
+|   +-- ScriptAction      (5) — sysevent_script_action CRUD
+|   +-- ScheduledJob      (5) — sysauto_script CRUD
+|   +-- UiPolicy          (5) — sys_ui_policy CRUD
+|   +-- UiAction          (5) — sys_ui_action CRUD
+|   +-- Workflow          (6) — wf_workflow + contexts
+|   +-- Flow              (6) — sn_fd flows + subflows
+|   +-- Audit             (3) — sys_audit + field changes
+|   +-- DeprecationLog    (4) — upgrade history + deprecation log
 +-- ITOM/
-|   +-- Discovery::Runners::Discovery    (5 methods)  — schedules/logs/devices
-|   +-- MidServer::Runners::MidServer    (5 methods)  — ecc_agent CRUD + capabilities
-|   +-- Event::Runners::Event            (3 methods)  — sysevent CRUD
+|   +-- Discovery         (5) — schedules/logs/devices
+|   +-- MidServer         (5) — ecc_agent CRUD + capabilities
+|   +-- Event             (3) — sysevent CRUD
 +-- Analytics/
-|   +-- PerformanceAnalytics::Runners::PerformanceAnalytics  (5 methods) — widgets/scorecards/indicators
-|   +-- Aggregate::Runners::Aggregate    (1 method)   — stats queries on any table
+|   +-- PerformanceAnalytics (5) — widgets/scorecards/indicators
+|   +-- Metric             (4) — definitions + instances
 +-- Comms/
-|   +-- Notification::Runners::Notification  (5 methods) — sysevent_email_action CRUD
-|   +-- EmailLog::Runners::EmailLog      (3 methods)  — sys_email list/get/list_for_record
-+-- Field Service/
-|   +-- WorkOrder::Runners::WorkOrder    (6 methods)  — wm_order CRUD + tasks + close
-|   +-- OnCall::Runners::OnCall          (5 methods)  — cmn_rota + members + who_is_on_call
+|   +-- Notification       (5) — sysevent_email_action CRUD
+|   +-- EmailLog           (3) — sys_email list/get/list_for_record
++-- FieldService/
+|   +-- WorkOrder          (6) — wm_order CRUD + tasks + close
+|   +-- OnCall             (5) — schedules + members + who_is_on_call
++-- PlatformModules/
+|   +-- ServicePortal      (6) — portals/pages/widgets
+|   +-- IntegrationHub     (5) — spokes/connections/credentials
 +-- Utilities/
-|   +-- Table::Runners::Table            (5 methods)  — generic CRUD on any table
-|   +-- ImportSet::Runners::ImportSet    (2 methods)  — /api/now/import
-|   +-- Survey::Runners::Survey          (5 methods)  — assessments + instances + responses
+|   +-- Table              (5) — generic CRUD on any table
+|   +-- ImportSet          (2) — /api/now/import
+|   +-- Aggregate          (1) — stats queries on any table
+|   +-- Attachment         (5) — upload/download files
+|   +-- Survey             (5) — assessments + instances + responses
+|   +-- Tag                (7) — label + label_entry CRUD
+|   +-- Currency           (3) — fx_currency + fx_rate
+|   +-- Calendar           (6) — cmn_schedule CRUD + entries
 +-- Skills/ (loaded only if legion-llm available)
 |   +-- Incident, ChangeRequest, CmdbQuery, Knowledge, ServiceCatalog
 |   +-- ProblemManagement, RequestFulfillment, ApprovalWorkflow
 |   +-- AssetManagement, SecurityIncidentResponse
-+-- Client                 # Standalone client class including all 46 runners
++-- Client                 # includes all 66 runners + helpers
 ```
 
+## Known Method Name Notes
+
+- Change runner task methods are named `list_change_tasks`, `create_change_task`, `update_change_task`, `delete_change_task` to avoid collision with the generic Task runner's `list_tasks`/`update_task`.
+
 ## Authentication
 
-`Helpers::Client#connection` selects auth priority order (most secure first):
-1. **OAuth2** — `client_id` + `client_secret` → client credentials grant → `/oauth_token.do`, token memoized in `@fetch_oauth2_token`
+Priority order (most secure wins):
+1. **OAuth2** — `client_id` + `client_secret` → `/oauth_token.do` → memoized in `@fetch_oauth2_token`
 2. **Bearer** — `token` → `Authorization: Bearer <token>`
-3. **Basic Auth** — `username` + `password` → HTTP Basic
+3. **Basic Auth** — `username` + `password`
 
-Instance URL defaults to `Legion::Settings[:service_now][:url]`, overridable per `Client.new` or per call.
+URL defaults to `Legion::Settings[:service_now][:url]`, overridable per call or `Client.new`.
 
-## Standalone Client
+## Helpers
 
+### Pagination
 ```ruby
-client = Legion::Extensions::ServiceNow::Client.new(
-  url: 'https://your-instance.service-now.com',
-  username: 'svc_account',
-  password: 'secret'
-)
-
-# Or with OAuth2
-client = Legion::Extensions::ServiceNow::Client.new(
-  url: 'https://your-instance.service-now.com',
-  client_id: 'abc',
-  client_secret: 'xyz'
-)
-
-client.list_incidents(sysparm_query: 'state=1', sysparm_limit: 50)
-client.create_change(short_description: 'Deploy v2.0')
-client.get_ci(class_name: 'cmdb_ci_server', sys_id: 'abc123')
+all = client.paginate(:list_incidents, sysparm_query: 'state=1')
 ```
 
+### Retry
+```ruby
+client.with_retry(max_retries: 3) { client.create_incident(...) }
+```
+Retries on `RateLimitError` (exponential backoff) and `ServerError`. Does not retry auth errors.
+
+### Error Handling
+`handle_response` is called automatically; raises typed `Errors::*` on non-2xx. Errors carry `.status` and `.detail`.
+
 ## Settings
 
 ```json
@@ -138,20 +166,20 @@ client.get_ci(class_name: 'cmdb_ci_server', sys_id: 'abc123')
 | `faraday >= 2.0` | HTTP client |
 | `faraday-multipart >= 1.0` | Multipart upload for attachments |
 | `legion-settings >= 1.3.14` | Settings/config |
-| `legion-logging >= 1.3.2` | Structured logging |
+| `legion-logging >= 1.3.2` | Logging |
 | `legion-cache >= 1.3.11` | Caching |
 | `legion-crypt >= 1.4.9` | Credential encryption |
 | `legion-data >= 1.4.17` | ORM |
 | `legion-json >= 1.2.1` | JSON helpers |
 | `legion-transport >= 1.3.9` | AMQP transport |
 
-`legion-llm` is an optional soft dependency — skills load only if defined.
+`legion-llm` is optional — skills load only if defined.
 
 ## Development
 
 ```bash
 bundle install
-bundle exec rspec          # 217+ examples, 0 failures
+bundle exec rspec          # 372 examples, 0 failures
 bundle exec rubocop        # 0 offenses
 ```