ledger_sync 1.4.4 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fd6a2c51848e4e1e51a7c0870956a23b7e6d81c6eff754554340fd48d350a6a9
-  data.tar.gz: d632009d62b0f7cfa59edceee5d9e2df57caa27a437197dc324e978dfc71d44c
+  metadata.gz: 19414532e2c552b3e17efa9e8dc0315740809c7bbe74124af62f55dbd4bad2d0
+  data.tar.gz: a8cf13be61f9ce6a738f4bf0d54774da3b676714a6e982394036fd924503a3e0
 SHA512:
-  metadata.gz: 8b09d33912d3bd337a3d84cf05093193dc1a80b1bdc3137f903131d386bb5a38355da76856b72cb55cfa2cdd190ef98c88ba87aeb62b5851beae05bc7aeb1fb9
-  data.tar.gz: bdc088c4b18661ee9ead64d5877c1e4104a1d9a6f1d39aec8e7d24cfd45f35ca00c3953783f2bfec22f62a7d56cc6cebf8a9e50f09596c272274b61e149cecf1
+  metadata.gz: 97a8377503769687b0f4b765ece61bb4fe9b4689adf493e8d41fe3d77fd58f90f53a0c51f6412d3f69221e697ae6c6633a4bb6edd54013cae86022a0c7b683b0
+  data.tar.gz: 7a6dfcde809c765cee2faad8f063c321f1baa064ff47cb98e5187042631fa13624b91e7954b729e4ded47ccaabef742b95579dcd5e66e9ef200df7a02fbc817e

data/.rubocop.yml

@@ -1,7 +1,10 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.6
+  Exclude:
+    - "documentation/site/_plugins/**/*"
+  TargetRubyVersion: 2.5.8
+  NewCops: enable
 
 Layout/LineLength:
   Enabled: True
@@ -15,3 +18,63 @@ Style/HashTransformKeys:
 
 Style/HashTransformValues:
   Enabled: True
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: True
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: True
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: True
+
+Lint/DuplicateElsifCondition:
+  Enabled: True
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: True
+
+Lint/RaiseException:
+  Enabled: True
+
+Lint/StructNewOverride:
+  Enabled: True
+
+Style/AccessorGrouping:
+  Enabled: True
+
+Style/ArrayCoercion:
+  Enabled: True
+
+Style/BisectedAttrAccessor:
+  Enabled: True
+
+Style/CaseLikeIf:
+  Enabled: True
+
+Style/ExponentialNotation:
+  Enabled: True
+
+Style/HashAsLastArrayItem:
+  Enabled: True
+
+Style/HashLikeCase:
+  Enabled: True
+
+Style/RedundantAssignment:
+  Enabled: True
+
+Style/RedundantFetchBlock:
+  Enabled: True
+
+Style/RedundantFileExtensionInRequire:
+  Enabled: True
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: True
+
+Style/RedundantRegexpEscape:
+  Enabled: True
+
+Style/SlicingWithRange:
+  Enabled: False

data/.travis.yml

@@ -1,4 +1,3 @@
----
 language: ruby
 cache: bundler
 rvm:
@@ -9,11 +8,19 @@ rvm:
   - ruby-head
 before_install:
   - gem update --system
-  - gem install bundler:1.17.3
-  - gem install overcommit
+  - gem install bundler
+  - rm Gemfile.lock
+  - bundle install
 script:
   - bundle exec rspec --order rand
-  - overcommit --sign && overcommit --run
+  - bundle exec overcommit --sign && bundle exec overcommit --run
 jobs:
   allow_failures:
-    - rvm: ruby-head
+    - rvm: ruby-head
+deploy:
+  - api_key:
+      secure: b7Ubc7/+EX4zHJ5zz15xiHntizhuZCU8SKR/jcbrR86wZx1DW8kIABBoVIHMh5CaMvrjF63B1qEoG4HcuovKZWezFLPgj4IQqlwlUle0/Vm0smO1kPMEOuMIv5P3TTgXZ99h1OdnfRQtDgbjxgKGszawMxNcw9Q8mqvVCc8Pmr+Uiw9DOOkHNMfLH+xOl00Ir9ST+K4/GKq19h8Z3glZE0oQAPajt5kgDZdDGD3en+t2g3kafJ9Hv6twKSb5rd5I9BN+VJ0m66OofGxnZFUxM/cb8T+s+6DdPXGWJq4IZ/q9SO108qfl1aTd7EiFa+hVtlLii7QaSMHARrbWT3wMYH3QhgTBPly8Dky92c74ziLkqaDdaxmGfYnzLDVCRVlGmGzUkOLx1ey9XK2kwSods+ud8rJ2pHWaT7NQROzTD4O0YhLHvEAoN6PwtIWm1v78OViBng36PKW0WtAE1rG9CEK1FjhA7ZZoctAsKqSaXWZR39+0xgSv+1axLXru/TG8QLqKNEOgNbE5lqR7sF2cVQgmmUstlMqiEgKMF0cFWWVi1wqR6VNxrgwgWeWtwzHLkchY6T3vhK9sl+cUM6SebfCOCAJHPBxSvHRHtJcrDY8qMqjlfFBSagjaClFt1Uzy//ab4XRzEs8VQcVkz9Yw7S51iOYBdj6135lfE0ZxE1c=
+    edge: true
+    on:
+      all_branches: true
+    provider: rubygems

data/Gemfile.lock

@@ -1,31 +1,31 @@
 PATH
   remote: .
   specs:
-    ledger_sync (1.4.4)
+    ledger_sync (1.5.0)
       activemodel
       colorize
-      coveralls
-      dotenv
-      dry-schema
-      dry-validation
+      coveralls (~> 0.8.23)
+      dotenv (~> 2.7.6)
+      dry-schema (~> 1.5.4)
+      dry-validation (~> 1.5.6)
       faraday
       faraday-detailed_logger
       faraday_middleware
       fingerprintable (>= 1.2.1)
-      netsuite
+      netsuite (~> 0.8.6)
       nokogiri
       oauth2
       pd_ruby
       resonad
       simply_serializable (>= 1.5.1)
-      stripe
+      stripe (~> 5.26.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (6.0.3.1)
-      activesupport (= 6.0.3.1)
-    activesupport (6.0.3.1)
+    activemodel (6.0.3.4)
+      activesupport (= 6.0.3.4)
+    activesupport (6.0.3.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
@@ -36,27 +36,26 @@ GEM
     akami (1.3.1)
       gyoku (>= 0.4.0)
       nokogiri
-    ast (2.4.0)
+    ast (2.4.1)
     awesome_print (1.8.0)
     builder (3.2.4)
     bump (0.9.0)
     byebug (11.1.3)
-    childprocess (3.0.0)
+    childprocess (4.0.0)
     colorator (1.1.0)
     colorize (0.8.1)
-    concurrent-ruby (1.1.6)
+    concurrent-ruby (1.1.7)
     coveralls (0.8.23)
       json (>= 1.8, < 3)
       simplecov (~> 0.16.1)
       term-ansicolor (~> 1.3)
       thor (>= 0.19.4, < 2.0)
       tins (~> 1.6)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
-    diff-lcs (1.3)
+    crack (0.4.4)
+    diff-lcs (1.4.4)
     docile (1.3.2)
-    dotenv (2.7.5)
-    dry-configurable (0.11.5)
+    dotenv (2.7.6)
+    dry-configurable (0.11.6)
       concurrent-ruby (~> 1.0)
       dry-core (~> 0.4, >= 0.4.7)
       dry-equalizer (~> 0.2)
@@ -67,12 +66,12 @@ GEM
       concurrent-ruby (~> 1.0)
     dry-equalizer (0.3.0)
     dry-inflector (0.2.0)
-    dry-initializer (3.0.3)
-    dry-logic (1.0.6)
+    dry-initializer (3.0.4)
+    dry-logic (1.0.8)
       concurrent-ruby (~> 1.0)
       dry-core (~> 0.2)
       dry-equalizer (~> 0.2)
-    dry-schema (1.5.1)
+    dry-schema (1.5.6)
       concurrent-ruby (~> 1.0)
       dry-configurable (~> 0.8, >= 0.8.3)
       dry-core (~> 0.4)
@@ -87,26 +86,27 @@ GEM
       dry-equalizer (~> 0.3)
       dry-inflector (~> 0.1, >= 0.1.2)
       dry-logic (~> 1.0, >= 1.0.2)
-    dry-validation (1.5.1)
+    dry-validation (1.5.6)
       concurrent-ruby (~> 1.0)
       dry-container (~> 0.7, >= 0.7.1)
       dry-core (~> 0.4)
       dry-equalizer (~> 0.2)
       dry-initializer (~> 3.0)
-      dry-schema (~> 1.5)
-    em-websocket (0.5.1)
+      dry-schema (~> 1.5, >= 1.5.2)
+    em-websocket (0.5.2)
       eventmachine (>= 0.12.9)
       http_parser.rb (~> 0.6.0)
     eventmachine (1.2.7)
-    factory_bot (6.0.1)
+    factory_bot (6.1.0)
       activesupport (>= 5.0.0)
-    faraday (1.0.1)
+    faraday (1.1.0)
       multipart-post (>= 1.2, < 3)
+      ruby2_keywords
     faraday-detailed_logger (2.3.0)
       faraday (>= 0.8, < 2)
     faraday_middleware (1.0.0)
       faraday (~> 1.0)
-    ffi (1.13.0)
+    ffi (1.13.1)
     fingerprintable (1.2.1)
       colorize
     forwardable-extended (2.6.0)
@@ -114,7 +114,7 @@ GEM
       builder (>= 2.1.2)
     hashdiff (1.0.1)
     http_parser.rb (0.6.0)
-    httpi (2.4.4)
+    httpi (2.4.5)
       rack
       socksify
     i18n (0.9.5)
@@ -142,8 +142,8 @@ GEM
       sass (~> 3.4)
     jekyll-watch (2.2.1)
       listen (~> 3.0)
-    json (2.3.0)
-    jwt (2.2.1)
+    json (2.3.1)
+    jwt (2.2.2)
     kramdown (1.17.0)
     liquid (4.0.3)
     listen (3.2.1)
@@ -151,13 +151,13 @@ GEM
       rb-inotify (~> 0.9, >= 0.9.10)
     mercenary (0.3.6)
     mini_portile2 (2.4.0)
-    minitest (5.14.1)
-    multi_json (1.14.1)
+    minitest (5.14.2)
+    multi_json (1.15.0)
     multi_xml (0.6.0)
     multipart-post (2.1.1)
-    netsuite (0.8.5)
-      savon (>= 2.3.0)
-    nokogiri (1.10.9)
+    netsuite (0.8.6)
+      savon (>= 2.3.0, <= 2.11.1)
+    nokogiri (1.10.10)
       mini_portile2 (~> 2.4.0)
     nori (2.6.0)
     oauth2 (1.4.4)
@@ -166,64 +166,65 @@ GEM
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 3)
-    overcommit (0.53.0)
-      childprocess (>= 0.6.3, < 4)
+    overcommit (0.57.0)
+      childprocess (>= 0.6.3, < 5)
       iniparse (~> 1.4)
-    parallel (1.19.1)
-    parser (2.7.1.3)
-      ast (~> 2.4.0)
+    parallel (1.19.2)
+    parser (2.7.2.0)
+      ast (~> 2.4.1)
     pathutil (0.16.2)
       forwardable-extended (~> 2.6)
     pd_ruby (0.2.3)
       colorize
-    public_suffix (4.0.5)
+    public_suffix (4.0.6)
     rack (2.2.3)
     rainbow (3.0.0)
     rake (13.0.1)
     rb-fsevent (0.10.4)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
-    regexp_parser (1.7.1)
-    resonad (1.2.0)
+    regexp_parser (1.8.2)
+    resonad (1.3.0)
     rexml (3.2.4)
-    rouge (3.19.0)
+    rouge (3.24.0)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
       rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.2)
+    rspec-core (3.9.3)
       rspec-support (~> 3.9.3)
-    rspec-expectations (3.9.2)
+    rspec-expectations (3.9.3)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
-    rspec-support (3.9.3)
-    rubocop (0.85.1)
+    rspec-support (3.9.4)
+    rubocop (1.0.0)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
+      regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 0.0.3)
+      rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.0.3)
-      parser (>= 2.7.0.1)
+    rubocop-ast (1.1.0)
+      parser (>= 2.7.1.5)
     ruby-progressbar (1.10.1)
+    ruby2_keywords (0.0.2)
     safe_yaml (1.0.5)
     sass (3.7.4)
       sass-listen (~> 4.0.0)
     sass-listen (4.0.0)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
-    savon (2.12.0)
+    savon (2.11.1)
       akami (~> 1.2)
       builder (>= 2.1.2)
       gyoku (~> 1.2)
       httpi (~> 2.3)
-      nokogiri (>= 1.8.1)
+      nokogiri (>= 1.4.0)
       nori (~> 2.4)
       wasabi (~> 3.4)
     simplecov (0.16.1)
@@ -234,42 +235,43 @@ GEM
     simply_serializable (1.5.1)
       fingerprintable (>= 1.2.1)
     socksify (1.7.1)
-    stripe (5.22.0)
+    stripe (5.26.0)
     sync (0.5.0)
     term-ansicolor (1.7.1)
       tins (~> 1.0)
     thor (1.0.1)
     thread_safe (0.3.6)
-    tins (1.25.0)
+    tins (1.26.0)
       sync
     tzinfo (1.2.7)
       thread_safe (~> 0.1)
     unicode-display_width (1.7.0)
     vcr (6.0.0)
-    wasabi (3.5.0)
+    wasabi (3.6.1)
+      addressable
       httpi (~> 2.0)
       nokogiri (>= 1.4.2)
-    webmock (3.8.3)
+    webmock (3.9.3)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    zeitwerk (2.3.0)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   awesome_print
-  bump
-  bundler (~> 1.16)
+  bump (~> 0.9.0)
+  bundler (~> 2.1)
   byebug
-  factory_bot
+  factory_bot (~> 6.1.0)
   jekyll (~> 3.8.4)
   jekyll-menus (~> 0.6.0)
   jekyll-paginate (~> 1.1)
   jekyll-paginate-v2 (~> 1.9)
   ledger_sync!
-  overcommit
+  overcommit (~> 0.57.0)
   rake (~> 13.0)
   rspec (~> 3.2)
   rubocop
@@ -277,4 +279,4 @@ DEPENDENCIES
   webmock
 
 BUNDLED WITH
-   1.17.3
+   2.1.4

data/bin/quickbooks_online_oauth_server.rb

@@ -42,7 +42,7 @@ client = LedgerSync::Ledgers::QuickBooksOnline::Client.new_from_env(test: true)
 puts 'Go to the following URL:'
 puts client.authorization_url(redirect_uri: base_url)
 
-while (session = server.accept)
+while (session = server.accept) # rubocop:disable Lint/UnreachableLoop
   request = session.gets
 
   puts request

data/documentation/generators/reference/ledger/generator.rb

@@ -10,6 +10,8 @@ module Docs
 
         def initialize(args = {})
           @ledger = args.fetch(:ledger)
+
+          super
         end
 
         def client_class

data/documentation/site/guides/contribute/deployment.md

@@ -1,17 +1,72 @@
 ---
-title: Deployment
+title: New Release
 layout: guides
 ---
 
 <div class="note"><strong>Note:</strong>
-Only contributors can deploy new versions of the gem to RubyGems.org.
+Only owners can release new versions of the gem to RubyGems.org.
 </div>
 
-To deploy a new version of the gem to RubyGems, you can use the `release.sh` script in the root.  The script takes advantage of [the bump gem](https://github.com/gregorym/bump).  So you may call the script using any of the following:
+## 1. Pull latest development
+
+```bash
+git checkout development
+git pull origin development
+```
+
+## 3. Start release
+
+This assumes you are using [the git-flow gem](https://github.com/nvie/gitflow):
+
+```bash
+git flow release start vX.X.X # Replace X.X.X. with new version
+```
+
+## 2. Update version
+
+You can use [the bump gem](https://github.com/gregorym/bump) to easily update the gem version:
 
 ```bash
 # Version Format: MAJOR.MINOR.PATCH
-./release.sh patch # to bump X in 1.1.X
-./release.sh minor # to bump X in 1.X.1
-./release.sh major # to bump X in X.1.1
-```
+# Choose one of the following
+bundle exec bump patch # to bump X in 1.1.X
+bundle exec bump minor # to bump X in 1.X.1
+bundle exec bump major # to bump X in X.1.1
+
+git commit -am "Publish version X.X.X"
+```
+
+## 3. Publish version
+
+```bash
+git flow release publish vX.X.X # Replace X.X.X. with new version
+```
+
+## 4. Create PR
+
+Create a PR in the github repo with `master` as the base.
+
+## 5. Wait for review and tests to pass.
+
+All releases should be approved and NOT merged using github.
+
+## 6. Merge release
+
+Merge the release using git-flow:
+
+```bash
+git flow release finish vX.X.X # Replace X.X.X. with new version
+git push origin --tags
+```
+
+## 7. Deploy new version to rubygems
+
+```bash
+git checkout master
+bundle exec build
+bundle exec release
+```
+
+## That's it!
+
+The version will now be available [on rubygems](https://rubygems.org/gems/ledger_sync).