ledger_sync 1.4.4 → 1.5.0

data/lib/ledger_sync/ledgers/quickbooks_online/resources/ledger_class.rb

@@ -4,12 +4,16 @@ module LedgerSync
   module Ledgers
     module QuickBooksOnline
       class LedgerClass < QuickBooksOnline::Resource
-        attribute :name, type: Type::String
-        attribute :fully_qualified_name, type: Type::String
-        attribute :active, type: Type::Boolean
-        attribute :sub_class, type: Type::Boolean
+        attribute :Name, type: Type::String
+        attribute :FullyQualifiedName, type: Type::String
+        attribute :Active, type: Type::Boolean
+        attribute :SubClass, type: Type::Boolean
 
-        references_one :parent, to: LedgerClass
+        references_one :Parent, to: LedgerClass
+
+        def name
+          self.Name
+        end
       end
     end
   end

data/lib/ledger_sync/ledgers/quickbooks_online/resources/payment.rb

@@ -3,24 +3,24 @@
 require_relative 'account'
 require_relative 'currency'
 require_relative 'customer'
-require_relative 'payment_line_item'
+require_relative 'payment_line'
 
 module LedgerSync
   module Ledgers
     module QuickBooksOnline
       class Payment < QuickBooksOnline::Resource
-        attribute :amount, type: Type::Integer
-        attribute :memo, type: Type::String
-        attribute :transaction_date, type: Type::Date
-        attribute :exchange_rate, type: Type::Float
-        attribute :reference_number, type: Type::String
+        attribute :TotalAmt, type: Type::Integer
+        attribute :PrivateNote, type: Type::String
+        attribute :TxnDate, type: Type::Date
+        attribute :ExchangeRate, type: Type::Float
+        attribute :PaymentRefNum, type: Type::String
 
-        references_one :customer, to: Customer
-        references_one :deposit_account, to: Account
-        references_one :account, to: Account
-        references_one :currency, to: Currency
+        references_one :Customer, to: Customer
+        references_one :DepositToAccount, to: Account
+        references_one :ARAccount, to: Account
+        references_one :Currency, to: Currency
 
-        references_many :line_items, to: PaymentLineItem
+        references_many :Line, to: PaymentLine
 
         def name
           "Payment: #{amount} #{currency}"

data/lib/ledger_sync/ledgers/quickbooks_online/resources/{payment_line_item.rb → payment_line.rb}

@@ -5,13 +5,13 @@ require_relative 'invoice'
 module LedgerSync
   module Ledgers
     module QuickBooksOnline
-      class PaymentLineItem < QuickBooksOnline::Resource
-        attribute :amount, type: Type::Integer
+      class PaymentLine < QuickBooksOnline::Resource
+        attribute :Amount, type: Type::Integer
 
-        references_many :ledger_transactions, to: [Invoice]
+        references_many :LinkedTxn, to: [Invoice]
 
         def name
-          amount
+          self.Amount
         end
       end
     end

data/lib/ledger_sync/ledgers/quickbooks_online/resources/preferences.rb

@@ -4,16 +4,16 @@ module LedgerSync
   module Ledgers
     module QuickBooksOnline
       class Preferences < QuickBooksOnline::Resource
-        attribute :accounting_info, type: Type::Hash
-        attribute :product_and_services, type: Type::Hash
-        attribute :sales_forms, type: Type::Hash
-        attribute :email_messages, type: Type::Hash
-        attribute :vendor_and_purchases, type: Type::Hash
-        attribute :time_tracking, type: Type::Hash
-        attribute :tax, type: Type::Hash
-        attribute :currency, type: Type::Hash
-        attribute :report, type: Type::Hash
-        attribute :other, type: Type::Hash
+        attribute :AccountingInfoPrefs, type: Type::Hash
+        attribute :ProductAndServicesPrefs, type: Type::Hash
+        attribute :SalesFormsPrefs, type: Type::Hash
+        attribute :EmailMessagesPrefs, type: Type::Hash
+        attribute :VendorAndPurchasesPrefs, type: Type::Hash
+        attribute :TimeTrackingPrefs, type: Type::Hash
+        attribute :TaxPrefs, type: Type::Hash
+        attribute :CurrencyPrefs, type: Type::Hash
+        attribute :ReportPrefs, type: Type::Hash
+        attribute :OtherPrefs, type: Type::Hash
 
         def name
           'Preference'

data/lib/ledger_sync/ledgers/quickbooks_online/resources/sales_item_line_detail.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require_relative 'item'
+require_relative 'ledger_class'
+
+module LedgerSync
+  module Ledgers
+    module QuickBooksOnline
+      class SalesItemLineDetail < QuickBooksOnline::Resource
+        references_one :Item, to: Item
+        references_one :Class, to: LedgerClass
+
+        def name
+          "#{self.Item.try(:name)} #{self.Class.try(:name)}"
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/ledgers/quickbooks_online/resources/transfer.rb

@@ -7,16 +7,16 @@ module LedgerSync
   module Ledgers
     module QuickBooksOnline
       class Transfer < QuickBooksOnline::Resource
-        attribute :amount, type: Type::Integer
-        attribute :memo, type: Type::String
-        attribute :transaction_date, type: Type::Date
+        attribute :Amount, type: Type::Integer
+        attribute :PrivateNote, type: Type::String
+        attribute :TxnDate, type: Type::Date
 
-        references_one :from_account, to: Account
-        references_one :to_account, to: Account
-        references_one :currency, to: Currency
+        references_one :FromAccount, to: Account
+        references_one :ToAccount, to: Account
+        references_one :Currency, to: Currency
 
         def name
-          "Transaction: #{amount} #{currency}"
+          "Transfer: #{self.Amount} #{self.Currency}"
         end
       end
     end

data/lib/ledger_sync/ledgers/quickbooks_online/resources/vendor.rb

@@ -1,21 +1,23 @@
 # frozen_string_literal: true
 
-require_relative 'subsidiary'
+require_relative 'primary_phone'
+require_relative 'primary_email_addr'
 
 module LedgerSync
   module Ledgers
     module QuickBooksOnline
       class Vendor < QuickBooksOnline::Resource
-        attribute :company_name, type: Type::String
-        attribute :email, type: Type::String
-        attribute :display_name, type: Type::String
-        attribute :first_name, type: Type::String
-        attribute :last_name, type: Type::String
-        attribute :phone_number, type: Type::String
-        references_one :subsidiary, to: Subsidiary
+        attribute :DisplayName, type: Type::String
+        attribute :GivenName, type: Type::String
+        attribute :MiddleName, type: Type::String
+        attribute :FamilyName, type: Type::String
+        attribute :CompanyName, type: Type::String
+
+        references_one :PrimaryPhone, to: PrimaryPhone
+        references_one :PrimaryEmailAddr, to: PrimaryEmailAddr
 
         def name
-          display_name.to_s
+          self.DisplayName
         end
       end
     end

data/lib/ledger_sync/ledgers/quickbooks_online/sales_item_line_detail/deserializer.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require_relative '../reference/deserializer'
+
+module LedgerSync
+  module Ledgers
+    module QuickBooksOnline
+      class SalesItemLineDetail
+        class Deserializer < QuickBooksOnline::Deserializer
+          references_one :Item,
+                         hash_attribute: 'ItemRef',
+                         deserializer: Reference::Deserializer
+
+          references_one :Class,
+                         hash_attribute: 'ClassRef',
+                         deserializer: Reference::Deserializer
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/ledgers/quickbooks_online/sales_item_line_detail/serializer.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require_relative '../reference/serializer'
+
+module LedgerSync
+  module Ledgers
+    module QuickBooksOnline
+      class SalesItemLineDetail
+        class Serializer < QuickBooksOnline::Serializer
+          references_one 'ItemRef',
+                         resource_attribute: :Item,
+                         serializer: Reference::Serializer
+
+          references_one 'ClassRef',
+                         resource_attribute: :Class,
+                         serializer: Reference::Serializer
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/ledgers/quickbooks_online/serialziation/type/mapping_type.rb

@@ -9,6 +9,8 @@ module LedgerSync
 
           def initialize(args = {})
             @mapping = args.fetch(:mapping)
+
+            super()
           end
 
           def cast_value(args = {})

data/lib/ledger_sync/ledgers/quickbooks_online/transfer/deserializer.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../currency/deserializer'
+require_relative '../reference/deserializer'
 
 module LedgerSync
   module Ledgers
@@ -9,24 +9,21 @@ module LedgerSync
         class Deserializer < QuickBooksOnline::Deserializer
           id
 
-          amount :amount,
-                 hash_attribute: 'Amount'
+          amount :Amount
+          attribute :PrivateNote
+          date :TxnDate
 
-          attribute :memo,
-                    hash_attribute: 'PrivateNote'
+          references_one :FromAccount,
+                         hash_attribute: 'FromAccountRef',
+                         deserializer: Reference::Deserializer
 
-          attribute 'from_account.ledger_id',
-                    hash_attribute: 'FromAccountRef.value'
+          references_one :ToAccount,
+                         hash_attribute: 'ToAccountRef',
+                         deserializer: Reference::Deserializer
 
-          attribute 'to_account.ledger_id',
-                    hash_attribute: 'ToAccountRef.value'
-
-          date :transaction_date,
-               hash_attribute: 'TxnDate'
-
-          references_one :currency,
-                         hash_attribute: :CurrencyRef,
-                         deserializer: Currency::Deserializer
+          references_one :Currency,
+                         hash_attribute: 'CurrencyRef',
+                         deserializer: Reference::Deserializer
         end
       end
     end

data/lib/ledger_sync/ledgers/quickbooks_online/transfer/operations/create.rb

@@ -10,12 +10,12 @@ module LedgerSync
               params do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).value(:nil)
-                required(:from_account).hash(Types::Reference)
-                required(:to_account).hash(Types::Reference)
-                required(:amount).filled(:integer)
-                required(:currency).filled(:hash, Types::Reference)
-                required(:memo).filled(:string)
-                required(:transaction_date).filled(:date?)
+                required(:FromAccount).hash(Types::Reference)
+                required(:ToAccount).hash(Types::Reference)
+                required(:Amount).filled(:integer)
+                required(:Currency).filled(:hash, Types::Reference)
+                required(:PrivateNote).filled(:string)
+                required(:TxnDate).filled(:date?)
               end
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/transfer/operations/find.rb

@@ -10,12 +10,12 @@ module LedgerSync
               schema do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
-                required(:from_account).hash(Types::Reference)
-                required(:to_account).hash(Types::Reference)
-                required(:amount).maybe(:integer)
-                required(:currency).maybe(:hash, Types::Reference)
-                required(:memo).maybe(:string)
-                required(:transaction_date).maybe(:date?)
+                optional(:FromAccount).hash(Types::Reference)
+                optional(:ToAccount).hash(Types::Reference)
+                optional(:Amount).maybe(:integer)
+                optional(:Currency).maybe(:hash, Types::Reference)
+                optional(:PrivateNote).maybe(:string)
+                optional(:TxnDate).maybe(:date?)
               end
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/transfer/operations/update.rb

@@ -10,12 +10,12 @@ module LedgerSync
               schema do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
-                required(:from_account).hash(Types::Reference)
-                required(:to_account).hash(Types::Reference)
-                required(:amount).filled(:integer)
-                required(:currency).filled(:hash, Types::Reference)
-                required(:memo).filled(:string)
-                required(:transaction_date).filled(:date?)
+                required(:FromAccount).hash(Types::Reference)
+                required(:ToAccount).hash(Types::Reference)
+                required(:Amount).filled(:integer)
+                required(:Currency).filled(:hash, Types::Reference)
+                required(:PrivateNote).filled(:string)
+                required(:TxnDate).filled(:date?)
               end
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/transfer/serializer.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../currency/serializer'
+require_relative '../reference/serializer'
 
 module LedgerSync
   module Ledgers
@@ -9,24 +9,21 @@ module LedgerSync
         class Serializer < QuickBooksOnline::Serializer
           id
 
-          amount 'Amount',
-                 resource_attribute: :amount
+          amount :Amount
+          attribute :PrivateNote
+          date :TxnDate
 
-          attribute 'PrivateNote',
-                    resource_attribute: :memo
+          references_one 'FromAccountRef',
+                         resource_attribute: :FromAccount,
+                         serializer: Reference::Serializer
 
-          attribute 'FromAccountRef.value',
-                    resource_attribute: 'from_account.ledger_id'
+          references_one 'ToAccountRef',
+                         resource_attribute: :ToAccount,
+                         serializer: Reference::Serializer
 
-          attribute 'ToAccountRef.value',
-                    resource_attribute: 'to_account.ledger_id'
-
-          date 'TxnDate',
-               resource_attribute: :transaction_date
-
-          references_one :CurrencyRef,
-                         resource_attribute: :currency,
-                         serializer: Currency::Serializer
+          references_one 'CurrencyRef',
+                         resource_attribute: :Currency,
+                         serializer: Reference::Serializer
         end
       end
     end

data/lib/ledger_sync/ledgers/quickbooks_online/util/error_matcher.rb

@@ -14,7 +14,7 @@ module LedgerSync
           end
 
           def body
-            error.response.body
+            @body ||= error.response.body
           rescue NoMethodError
             nil
           end
@@ -26,30 +26,43 @@ module LedgerSync
           def error_message
             return error.message unless body
 
-            parsed_body = JSON.parse(body)
-
-            parsed_body.dig('fault', 'error')&.first&.fetch('message') ||
-              parsed_body.dig('Fault', 'Error')&.first&.fetch('Message') ||
-              parsed_body.dig('error')
+            fault&.fetch('message', nil) ||
+              fault&.fetch('Message', nil) ||
+              parsed_body['error']
           end
 
           def detail
-            (body && JSON.parse(body).dig('fault', 'error')&.first&.fetch('detail')) ||
-              (body && JSON.parse(body).dig('Fault', 'Error')&.first&.fetch('Detail'))
+            return if body.blank?
+
+            fault&.fetch('detail') ||
+              fault&.fetch('Detail')
           end
 
           def code
-            ((body && JSON.parse(body).dig('fault', 'error')&.first&.fetch('code')) ||
-            (body && JSON.parse(body).dig('Fault', 'Error')&.first&.fetch('code'))).to_i
+            return if body.blank?
+
+            fault&.fetch('code') ||
+              fault&.fetch('code').to_i
           end
 
           def match?
             raise NotImplementedError
           end
 
+          def parsed_body
+            @parsed_body ||= JSON.parse(body)
+          end
+
           def output_message
             raise NotImplementedError
           end
+
+          private
+
+          def fault
+            parsed_body.dig('fault', 'error')&.first ||
+              parsed_body.dig('Fault', 'Error')&.first
+          end
         end
       end
     end