ledger_sync 1.4.4 → 1.5.0

data/lib/ledger_sync/ledgers/quickbooks_online/department/operations/create.rb

@@ -10,11 +10,11 @@ module LedgerSync
               params do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).value(:nil)
-                required(:name).filled(:string)
-                required(:active).filled(:bool?)
-                required(:sub_department).filled(:bool?)
-                optional(:fully_qualified_name).maybe(:string)
-                optional(:parent).maybe(:hash, Types::Reference)
+                required(:Name).filled(:string)
+                required(:Active).filled(:bool?)
+                required(:SubDepartment).filled(:bool?)
+                optional(:FullyQualifiedName).maybe(:string)
+                optional(:Parent).maybe(:hash, Types::Reference)
               end
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/department/operations/find.rb

@@ -10,11 +10,11 @@ module LedgerSync
               params do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
-                optional(:name).maybe(:string)
-                optional(:active).maybe(:bool?)
-                optional(:sub_department).maybe(:bool?)
-                optional(:fully_qualified_name).maybe(:string)
-                optional(:parent).maybe(:hash, Types::Reference)
+                optional(:Name).maybe(:string)
+                optional(:Active).maybe(:bool?)
+                optional(:SubDepartment).maybe(:bool?)
+                optional(:FullyQualifiedName).maybe(:string)
+                optional(:Parent).maybe(:hash, Types::Reference)
               end
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/department/operations/update.rb

@@ -10,11 +10,11 @@ module LedgerSync
               params do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
-                required(:name).filled(:string)
-                required(:active).filled(:bool?)
-                required(:sub_department).filled(:bool?)
-                optional(:fully_qualified_name).maybe(:string)
-                optional(:parent).maybe(:hash, Types::Reference)
+                required(:Name).filled(:string)
+                required(:Active).filled(:bool?)
+                required(:SubDepartment).filled(:bool?)
+                optional(:FullyQualifiedName).maybe(:string)
+                optional(:Parent).maybe(:hash, Types::Reference)
               end
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/department/serializer.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../reference/serializer'
+
 module LedgerSync
   module Ledgers
     module QuickBooksOnline
@@ -7,24 +9,14 @@ module LedgerSync
         class Serializer < QuickBooksOnline::Serializer
           id
 
-          attribute 'Name',
-                    resource_attribute: :name
-          attribute 'Active',
-                    resource_attribute: :active
-          attribute 'SubDepartment',
-                    resource_attribute: :sub_department
-          attribute 'FullyQualifiedName',
-                    resource_attribute: :fully_qualified_name
-
-          attribute(:ParentRef) do |args = {}|
-            resource = args.fetch(:resource)
+          attribute :Name
+          attribute :Active
+          attribute :SubDepartment
+          attribute :FullyQualifiedName
 
-            if resource.parent.present?
-              {
-                'value' => resource.parent.ledger_id
-              }
-            end
-          end
+          references_one 'ParentRef',
+                         resource_attribute: :Parent,
+                         serializer: Reference::Serializer
 
           # Sending "ParentRef": {"value": null} results in QBO API crash
           # This patches serialized hash to exclude it unless we don't set value

data/lib/ledger_sync/ledgers/quickbooks_online/deposit/deserializer.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require_relative '../deposit_line_item/deserializer'
-require_relative '../currency/deserializer'
+require_relative '../deposit_line/deserializer'
+require_relative '../reference/deserializer'
 
 module LedgerSync
   module Ledgers
@@ -10,28 +10,25 @@ module LedgerSync
         class Deserializer < QuickBooksOnline::Deserializer
           id
 
-          references_one :currency,
-                         hash_attribute: :CurrencyRef,
-                         deserializer: Currency::Deserializer
+          date :TxnDate
+          attribute :PrivateNote
+          attribute :ExchangeRate
 
-          date :transaction_date,
-               hash_attribute: 'TxnDate'
+          references_one :Currency,
+                         hash_attribute: 'CurrencyRef',
+                         deserializer: Reference::Deserializer
 
-          attribute :memo,
-                    hash_attribute: 'PrivateNote'
+          references_one :DepositToAccount,
+                         hash_attribute: 'DepositToAccountRef',
+                         deserializer: Reference::Deserializer
 
-          attribute :exchange_rate,
-                    hash_attribute: 'ExchangeRate'
+          references_one :Department,
+                         hash_attribute: 'DepartmentRef',
+                         deserializer: Reference::Deserializer
 
-          attribute 'account.ledger_id',
-                    hash_attribute: 'DepositToAccountRef.value'
-
-          attribute 'department.ledger_id',
-                    hash_attribute: 'DepartmentRef.value'
-
-          references_many :line_items,
+          references_many :Line,
                           hash_attribute: 'Line',
-                          deserializer: DepositLineItem::Deserializer
+                          deserializer: DepositLine::Deserializer
         end
       end
     end

data/lib/ledger_sync/ledgers/quickbooks_online/deposit/operations/create.rb

@@ -10,13 +10,13 @@ module LedgerSync
               params do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).value(:nil)
-                required(:account).hash(Types::Reference)
-                required(:currency).filled(:hash, Types::Reference)
-                required(:department).hash(Types::Reference)
-                required(:memo).filled(:string)
-                required(:transaction_date).filled(:date?)
-                required(:exchange_rate).maybe(:float)
-                required(:line_items).array(Types::Reference)
+                required(:DepositToAccount).hash(Types::Reference)
+                required(:Currency).filled(:hash, Types::Reference)
+                required(:Department).hash(Types::Reference)
+                required(:PrivateNote).filled(:string)
+                required(:TxnDate).filled(:date?)
+                required(:ExchangeRate).maybe(:float)
+                required(:Line).array(Types::Reference)
               end
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/deposit/operations/find.rb

@@ -10,13 +10,13 @@ module LedgerSync
               schema do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
-                required(:account).hash(Types::Reference)
-                required(:currency).maybe(:hash, Types::Reference)
-                required(:department).hash(Types::Reference)
-                required(:memo).maybe(:string)
-                required(:transaction_date).filled(:date?)
-                required(:exchange_rate).maybe(:float)
-                required(:line_items).array(Types::Reference)
+                optional(:DepositToAccount).hash(Types::Reference)
+                optional(:Currency).maybe(:hash, Types::Reference)
+                optional(:Department).hash(Types::Reference)
+                optional(:PrivateNote).maybe(:string)
+                optional(:TxnDate).filled(:date?)
+                optional(:ExchangeRate).maybe(:float)
+                optional(:Line).array(Types::Reference)
               end
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/deposit/operations/update.rb

@@ -10,13 +10,13 @@ module LedgerSync
               schema do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
-                required(:account).hash(Types::Reference)
-                required(:currency).filled(:hash, Types::Reference)
-                required(:department).hash(Types::Reference)
-                required(:memo).filled(:string)
-                required(:transaction_date).filled(:date?)
-                required(:exchange_rate).maybe(:float)
-                required(:line_items).array(Types::Reference)
+                required(:DepositToAccount).hash(Types::Reference)
+                required(:Currency).filled(:hash, Types::Reference)
+                required(:Department).hash(Types::Reference)
+                required(:PrivateNote).filled(:string)
+                required(:TxnDate).filled(:date?)
+                required(:ExchangeRate).maybe(:float)
+                required(:Line).array(Types::Reference)
               end
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/deposit/serializer.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require_relative '../deposit_line_item/serializer'
-require_relative '../currency/serializer'
+require_relative '../deposit_line/serializer'
+require_relative '../reference/serializer'
 
 module LedgerSync
   module Ledgers
@@ -10,28 +10,25 @@ module LedgerSync
         class Serializer < QuickBooksOnline::Serializer
           id
 
-          references_one :CurrencyRef,
-                         resource_attribute: :currency,
-                         serializer: Currency::Serializer
+          date :TxnDate
+          attribute :PrivateNote
+          attribute :ExchangeRate
 
-          date 'TxnDate',
-               resource_attribute: :transaction_date
+          references_one 'CurrencyRef',
+                         resource_attribute: :Currency,
+                         serializer: Reference::Serializer
 
-          attribute 'PrivateNote',
-                    resource_attribute: :memo
+          references_one 'DepositToAccountRef',
+                         resource_attribute: :DepositToAccount,
+                         serializer: Reference::Serializer
 
-          attribute 'ExchangeRate',
-                    resource_attribute: :exchange_rate
-
-          attribute 'DepositToAccountRef.value',
-                    resource_attribute: 'account.ledger_id'
-
-          attribute 'DepartmentRef.value',
-                    resource_attribute: 'department.ledger_id'
+          references_one 'DepartmentRef',
+                         resource_attribute: :Department,
+                         serializer: Reference::Serializer
 
           references_many 'Line',
-                          resource_attribute: :line_items,
-                          serializer: DepositLineItem::Serializer
+                          resource_attribute: :Line,
+                          serializer: DepositLine::Serializer
         end
       end
     end

data/lib/ledger_sync/ledgers/quickbooks_online/deposit_line/deserializer.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require_relative '../deposit_line_detail/deserializer'
+
+module LedgerSync
+  module Ledgers
+    module QuickBooksOnline
+      class DepositLine
+        class Deserializer < QuickBooksOnline::Deserializer
+          id
+
+          amount :Amount
+          attribute :Description
+
+          references_one :DepositLineDetail,
+                         hash_attribute: 'DepositLineDetail',
+                         deserializer: DepositLineDetail::Deserializer
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/ledgers/quickbooks_online/deposit_line/serializer.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require_relative '../deposit_line_detail/serializer'
+
+module LedgerSync
+  module Ledgers
+    module QuickBooksOnline
+      class DepositLine
+        class Serializer < QuickBooksOnline::Serializer
+          id
+
+          amount :Amount
+          attribute :Description
+
+          attribute :DetailType do
+            'DepositLineDetail'
+          end
+
+          references_one 'DepositLineDetail',
+                         resource_attribute: :DepositLineDetail,
+                         serializer: DepositLineDetail::Serializer
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/ledgers/quickbooks_online/deposit_line_detail/deserializer.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require_relative '../reference/deserializer'
+
+module LedgerSync
+  module Ledgers
+    module QuickBooksOnline
+      class DepositLineDetail
+        class Deserializer < QuickBooksOnline::Deserializer
+          references_one :Account,
+                         hash_attribute: 'AccountRef',
+                         deserializer: Reference::Deserializer
+
+          references_one :Class,
+                         hash_attribute: 'ClassRef',
+                         deserializer: Reference::Deserializer
+
+          attribute(:Entity) do |args = {}|
+            hash = args.fetch(:hash)
+            value = hash.fetch('Entity', nil)
+
+            unless value.nil?
+              Client.ledger_resource_for(
+                type: value['type']
+              ).new(
+                ledger_id: value['value']
+              )
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/ledgers/quickbooks_online/deposit_line_detail/serializer.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require_relative '../reference/serializer'
+
+module LedgerSync
+  module Ledgers
+    module QuickBooksOnline
+      class DepositLineDetail
+        class Serializer < QuickBooksOnline::Serializer
+          references_one 'AccountRef',
+                         resource_attribute: :Account,
+                         serializer: Reference::Serializer
+
+          references_one 'ClassRef',
+                         resource_attribute: :Class,
+                         serializer: Reference::Serializer
+
+          attribute 'Entity' do |args = {}|
+            resource = args.fetch(:resource)
+
+            if resource.Entity.present?
+              {
+                'name' => resource.Entity.name,
+                'value' => resource.Entity.ledger_id,
+                'type' => Client.ledger_resource_type_for(
+                  resource_class: resource.Entity.class
+                ).classify
+              }
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/ledgers/quickbooks_online/deserializer.rb

@@ -15,10 +15,10 @@ module LedgerSync
 
           # Ref: https://github.com/LedgerSync/ledger_sync/issues/86
           if deserialized_resource.is_a?(LedgerSync::Ledgers::QuickBooksOnline::Account) &&
-             deserialized_resource.account_type &&
-             deserialized_resource.classification.blank?
-            deserialized_resource.classification = deserialized_resource.class::TYPES_TO_CLASSIFICATION_MAPPING.fetch(
-              deserialized_resource.account_type,
+             deserialized_resource.AccountType &&
+             deserialized_resource.Classification.blank?
+            deserialized_resource.Classification = deserialized_resource.class::TYPES_TO_CLASSIFICATION_MAPPING.fetch(
+              deserialized_resource.AccountType,
               nil
             )
           end

data/lib/ledger_sync/ledgers/quickbooks_online/expense/deserializer.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require_relative '../expense_line_item/deserializer'
-require_relative '../currency/deserializer'
+require_relative '../expense_line/deserializer'
+require_relative '../reference/deserializer'
 
 module LedgerSync
   module Ledgers
@@ -10,24 +10,16 @@ module LedgerSync
         class Deserializer < QuickBooksOnline::Deserializer
           id
 
-          references_one :currency,
-                         hash_attribute: :CurrencyRef,
-                         deserializer: Currency::Deserializer
+          attribute :DocNumber
+          date :TxnDate
+          attribute :PrivateNote
 
-          mapping :payment_type,
-                  hash_attribute: 'PaymentType',
-                  hash: Expense::PAYMENT_TYPES.invert
-
-          date :transaction_date,
-               hash_attribute: 'TxnDate'
+          attribute :ExchangeRate
 
-          attribute :memo,
-                    hash_attribute: 'PrivateNote'
-
-          attribute :exchange_rate,
-                    hash_attribute: 'ExchangeRate'
+          mapping :PaymentType,
+                  hash: Expense::PAYMENT_TYPES.invert
 
-          attribute(:entity) do |args = {}|
+          attribute(:Entity) do |args = {}|
             hash = args.fetch(:hash)
             value = hash['EntityRef']
 
@@ -40,18 +32,21 @@ module LedgerSync
             end
           end
 
-          attribute :reference_number,
-                    hash_attribute: 'DocNumber'
+          references_one :Currency,
+                         hash_attribute: 'CurrencyRef',
+                         deserializer: Reference::Deserializer
 
-          attribute 'account.ledger_id',
-                    hash_attribute: 'AccountRef.value'
+          references_one :Account,
+                         hash_attribute: 'AccountRef',
+                         deserializer: Reference::Deserializer
 
-          attribute 'department.ledger_id',
-                    hash_attribute: 'DepartmentRef.value'
+          references_one :Department,
+                         hash_attribute: 'DepartmentRef',
+                         deserializer: Reference::Deserializer
 
-          references_many :line_items,
+          references_many :Line,
                           hash_attribute: 'Line',
-                          deserializer: ExpenseLineItem::Deserializer
+                          deserializer: ExpenseLine::Deserializer
         end
       end
     end