ledger_sync 1.1.1 → 1.1.2

data/lib/ledger_sync/adaptors/test/transfer/operations/find.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Find < Operation::Find
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
@@ -15,19 +16,6 @@ module LedgerSync
                 required(:transaction_date).maybe(:date?)
               end
             end
-
-            private
-
-            def operate
-              return failure(nil) if resource.ledger_id.nil?
-
-              response = adaptor.find(
-                resource: 'transfer',
-                id: resource.ledger_id
-              )
-
-              success(response: response)
-            end
           end
         end
       end

data/lib/ledger_sync/adaptors/test/transfer/operations/update.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Update < Operation::Update
             class Contract < LedgerSync::Adaptors::Contract
               params do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
@@ -15,31 +16,6 @@ module LedgerSync
                 required(:transaction_date).filled(:date?)
               end
             end
-
-            private
-
-            def operate
-              ledger_resource_data = adaptor.find(
-                resource: 'transfer',
-                id: resource.ledger_id
-              )
-              response = adaptor.post(
-                resource: 'transfer',
-                payload: merge_into(from: local_resource_data, to: ledger_resource_data)
-              )
-
-              success(response: response)
-            end
-
-            def local_resource_data
-              {
-                'amount' => resource.amount,
-                'currency' => resource.currency,
-                'from_account_id' => resource.from_account.ledger_id,
-                'to_account_id' => resource.to_account.ledger_id,
-                'date' => resource.transaction_date
-              }
-            end
           end
         end
       end

data/lib/ledger_sync/adaptors/test/vendor/operations/create.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Create < Operation::Create
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).value(:nil)
                 required(:display_name).maybe(:string)
                 required(:first_name).maybe(:string)
@@ -37,7 +38,10 @@ module LedgerSync
 
               resource.ledger_id = response.dig('id')
 
-              success(response: response)
+              success(
+                resource: Test::LedgerSerializer.new(resource: resource).deserialize(hash: response),
+                response: response
+              )
             end
           end
         end

data/lib/ledger_sync/adaptors/test/vendor/operations/find.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LedgerSync
   module Adaptors
     module Test
@@ -6,6 +8,7 @@ module LedgerSync
           class Find < Operation::Find
             class Contract < LedgerSync::Adaptors::Contract
               params do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 optional(:display_name).maybe(:string)
                 optional(:first_name).maybe(:string)
@@ -24,7 +27,10 @@ module LedgerSync
                 id: resource.ledger_id
               )
 
-              success(response: response)
+              success(
+                resource: Test::LedgerSerializer.new(resource: resource).deserialize(hash: response),
+                response: response
+              )
             end
           end
         end

data/lib/ledger_sync/adaptors/test/vendor/operations/invalid.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Invalid < Operation::Create
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                required(:external_id).filled(:string)
                 required(:ledger_id).filled(:string)
                 required(:display_name).filled(:string)
                 required(:first_name).filled(:string)

data/lib/ledger_sync/adaptors/test/vendor/operations/update.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Update < Operation::Update
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:display_name).maybe(:string)
                 required(:first_name).maybe(:string)
@@ -13,29 +14,6 @@ module LedgerSync
                 optional(:email).maybe(:string)
               end
             end
-
-            private
-
-            def operate
-              ledger_resource_data = adaptor.find(
-                resource: 'vendor',
-                id: resource.ledger_id
-              )
-
-              response = adaptor.post(
-                resource: 'vendor',
-                payload: merge_into(from: local_resource_data, to: ledger_resource_data)
-              )
-
-              success(response: response)
-            end
-
-            def local_resource_data
-              {
-                'name' => resource.name,
-                'email' => resource.email
-              }
-            end
           end
         end
       end

data/lib/ledger_sync/adaptors/test/vendor/operations/valid.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Valid < Operation::Create
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                optional(:external_id).maybe(:string)
                 optional(:ledger_id).maybe(:string)
                 optional(:display_name).maybe(:string)
                 optional(:first_name).maybe(:string)

data/lib/ledger_sync/error/adaptor_errors.rb

@@ -4,15 +4,20 @@ module LedgerSync
   class Error
     class AdaptorError < Error
       attr_reader :adaptor
+      attr_reader :response
 
-      def initialize(adaptor:, message:)
+      def initialize(adaptor:, message:, response:nil)
         @adaptor = adaptor
+        @response = response
         super(message: message)
       end
 
       class MissingAdaptorError < self
         def initialize(message:)
-          super(message: message, adaptor: nil)
+          super(
+            message: message,
+            adaptor: nil,
+          )
         end
       end
 
@@ -22,20 +27,27 @@ module LedgerSync
         def initialize(message:, adaptor:, attribute:, validation:)
           @attribute = attribute
           @validation = validation
-          super(message: message, adaptor: adaptor)
+          super(
+            message: message,
+            adaptor: adaptor,
+          )
         end
       end
 
       class ThrottleError < self
         attr_reader :rate_limiting_wait_in_seconds
 
-        def initialize(adaptor:, message: nil)
+        def initialize(adaptor:, message: nil, response:nil)
           message ||= 'Your request has been throttled.'
           @rate_limiting_wait_in_seconds = LedgerSync.adaptors.config_from_klass(
             klass: adaptor.class
           ).rate_limiting_wait_in_seconds
 
-          super(adaptor: adaptor, message: message)
+          super(
+            adaptor: adaptor,
+            message: message,
+            response: response
+          )
         end
       end
 

data/lib/ledger_sync/error/operation_errors.rb

@@ -4,9 +4,11 @@ module LedgerSync
   class Error
     class OperationError < Error
       attr_reader :operation
+      attr_reader :response
 
-      def initialize(message:, operation:)
+      def initialize(message:, operation:, response:nil)
         @operation = operation
+        @response = response
         super(message: message)
       end
 
@@ -15,10 +17,14 @@ module LedgerSync
       class LedgerValidationError < self; end
 
       class PerformedOperationError < self
-        def initialize(message: nil, operation:)
+        def initialize(message: nil, operation:, response:nil)
           message ||= 'Operation has already been performed. Please check the result.'
 
-          super(message: message, operation: operation)
+          super(
+            message: message,
+            operation: operation,
+            response: response
+          )
         end
       end
 
@@ -26,13 +32,14 @@ module LedgerSync
         attr_reader :attribute,
                     :validation
 
-        def initialize(message:, attribute:, operation:, validation:)
+        def initialize(message:, attribute:, operation:, validation:, response:nil)
           @attribute = attribute
           @validation = validation
 
           super(
             message: message,
-            operation: operation
+            operation: operation,
+            response: response
           )
         end
       end

data/lib/ledger_sync/error/resource_errors.rb

@@ -16,7 +16,11 @@ module LedgerSync
 
         resource_class = resource.class
 
-        message = "Attribute #{attribute.name} for #{resource_class.name} should be a class supported by #{attribute.type.class.name}.  Given: #{value.class}"
+        message = attribute.type.error_message(
+          attribute: attribute,
+          resource: resource,
+          value: value
+        )
 
         super(message: message, resource: nil)
       end

data/lib/ledger_sync/resource.rb

@@ -14,6 +14,7 @@ module LedgerSync
     include ResourceAttribute::Reference::Many::Mixin
 
     PRIMITIVES = [
+      ActiveModel::Type,
       Date,
       DateTime,
       FalseClass,
@@ -27,24 +28,50 @@ module LedgerSync
 
     serialize except: %i[resource_attributes references]
 
-    dirty_attribute :external_id, :ledger_id, :sync_token
+    def assign_attribute(name, value)
+      public_send("#{name}=", value)
+    end
+
+    def assign_attributes(**keywords)
+      keywords.each { |k, v| assign_attribute(k, v) }
+    end
 
-    def initialize(external_id: nil, ledger_id: nil, sync_token: nil, **data)
-      @external_id = external_id.try(:to_sym)
-      @ledger_id = ledger_id
-      @sync_token = sync_token
+    def changed?
+      super || resource_attributes.references_many.select(&:changed?).any?
+    end
 
-      super(data)
+    def changes
+      super.merge(Hash[resource_attributes.references_many.map { |ref| [ref.name, ref.changes['value']] if ref.changed? }.compact])
+    end
+
+    def dup
+      Marshal.load(Marshal.dump(self))
     end
 
     def klass_from_resource_type(obj)
       LedgerSync.const_get(LedgerSync::Util::StringHelpers.camelcase(obj))
     end
 
+    def to_h
+      resource_attributes.to_h.merge(dirty_attributes_to_h)
+    end
+
+    def self.inherited(subclass)
+      subclass.attribute :external_id, type: Type::ID
+      subclass.attribute :ledger_id, type: Type::ID
+    end
+
     def self.resource_type
       @resource_type ||= LedgerSync::Util::StringHelpers.underscore(name.split('::').last).to_sym
     end
 
+    def self.serialize_attribute?(sattr)
+      sattr = sattr.to_sym
+      return true if resource_attributes.key?(sattr)
+
+      false
+    end
+
     def ==(other)
       other.fingerprint == fingerprint
     end

data/lib/ledger_sync/resource_attribute.rb

@@ -43,6 +43,10 @@ module LedgerSync
       is_a?(Reference)
     end
 
+    def references_many?
+      is_a?(Reference::Many)
+    end
+
     def valid_with?(value:)
       type.valid_without_casting?(value: value)
     end

data/lib/ledger_sync/resource_attribute/dirty_mixin.rb

@@ -32,6 +32,21 @@ module LedgerSync
         end
       end
 
+      # Change the dirty change set of {"name" => ["Bill", "Bob"]}
+      # to current values of attributes that have changed: {"name" => "Bob"}
+      def changes_to_h
+        Hash[changes.map { |k, v| [k, v.last] }]
+      end
+
+      def dirty_attributes_to_h
+        Hash[self.class.dirty_attributes.keys.map do |k|
+          [
+            k,
+            public_send(k)
+          ]
+        end]
+      end
+
       # Normally you would just call `changes_applied`, but because we
       # define an `@attributes` instance variable, the `ActiveModel::Dirty`
       # mixin assumes it is a list of attributes in their format (spoiler: it
@@ -43,6 +58,7 @@ module LedgerSync
         @mutations_before_last_save = mutations_from_database
         # forget_attribute_assignments # skipped as our attributes do not implement this method
         @mutations_from_database = ActiveModel::ForcedMutationTracker.new(self) # Manually set to expected value
+        resource_attributes.references_many.map(&:save)
       end
     end
   end

data/lib/ledger_sync/resource_attribute/mixin.rb

@@ -21,19 +21,21 @@ module LedgerSync
               resource_attributes[name].value
             end
 
-            define_method "#{name}=" do |val|
-              public_send("#{name}_will_change!") unless val == resource_attributes[name] # For Dirty
-
-              attribute = resource_attributes[name]
-
-              unless attribute.valid_with?(value: val)
+            define_method "_#{name}_valid_with_value?" do |val|
+              unless resource_attributes[name].valid_with?(value: val)
                 raise ResourceError::AttributeTypeError.new(
-                  attribute: attribute,
+                  attribute: resource_attributes[name],
                   resource: self,
                   value: val
                 )
               end
+            end
 
+            define_method "#{name}=" do |val|
+              attribute = resource_attributes[name]
+              public_send("_#{name}_valid_with_value?", val)
+              val = attribute.type.cast(val) if attribute.type.cast?
+              public_send("#{name}_will_change!") unless val == resource_attributes[name] # For Dirty
               attribute.value = val
             end
 
@@ -47,10 +49,15 @@ module LedgerSync
           _define_attribute_methods(name)
 
           resource_attributes.add(resource_attribute)
+          references_many_resource_attributes << resource_attribute if resource_attribute.type.is_a?(Reference::Many)
 
           resource_attribute
         end
 
+        def references_many_resource_attributes
+          @references_many_resource_attributes ||= []
+        end
+
         def resource_attributes
           @resource_attributes ||= ResourceAttributeSet.new(resource: self)
         end
@@ -82,6 +89,11 @@ module LedgerSync
         @resource_attributes ||= Marshal.load(Marshal.dump(self.class.resource_attributes))
       end
 
+      def save
+        resoure_attributes.map(&:save)
+        super
+      end
+
       def serialize_attributes
         Hash[resource_attributes.map { |k, v| [k, v.value] }]
       end

data/lib/ledger_sync/resource_attribute/reference/many.rb

@@ -7,6 +7,48 @@ module LedgerSync
   class ResourceAttribute
     class Reference
       class Many < Reference
+        class ManyArray
+          include ActiveModel::Dirty
+
+          ARRAY_METHODS_TO_OVERRIDE_WITH_DIRTY = %w[<< | []= + -].freeze
+
+          delegate  :count,
+                    :each,
+                    :include?,
+                    :map,
+                    to: :value
+
+          attr_accessor :value
+
+          define_attribute_methods :value
+
+          def initialize
+            @value = []
+          end
+
+          ARRAY_METHODS_TO_OVERRIDE_WITH_DIRTY.each do |array_method|
+            define_method(array_method) do |val|
+              value_will_change!
+              @value = @value.send(array_method, val)
+            end
+          end
+
+          def ==(other)
+            return false unless other.is_a?(ManyArray)
+            return false unless other.sorted_fingerprints == sorted_fingerprints
+
+            true
+          end
+
+          def save
+            changes_applied
+          end
+
+          def sorted_fingerprints
+            value.map(&:fingerprint).sort
+          end
+        end
+
         module Mixin
           def self.included(base)
             base.extend(ClassMethods)
@@ -25,9 +67,21 @@ module LedgerSync
           super(
             name: name,
             type: Type::ReferenceMany.new(resource_class: to),
-            value: []
+            value: ManyArray.new
           )
         end
+
+        def changed?
+          value.changed?
+        end
+
+        def changes
+          value.changes
+        end
+
+        def save
+          value.save
+        end
       end
     end
   end