ledger_sync 1.1.1 → 1.1.2

data/lib/ledger_sync/adaptors/quickbooks_online/transfer/ledger_serializer.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module LedgerSync
+  module Adaptors
+    module QuickBooksOnline
+      module Transfer
+        class LedgerSerializer < QuickBooksOnline::LedgerSerializer
+          id
+
+          attribute ledger_attribute: 'Amount',
+                    resource_attribute: :amount,
+                    type: LedgerSerializerType::AmountType
+
+          attribute ledger_attribute: 'PrivateNote',
+                    resource_attribute: :memo
+
+          attribute ledger_attribute: 'FromAccountRef.value',
+                    resource_attribute: 'from_account.ledger_id'
+
+          attribute ledger_attribute: 'ToAccountRef.value',
+                    resource_attribute: 'to_account.ledger_id'
+
+          attribute ledger_attribute: 'TxnDate',
+                    resource_attribute: :transaction_date,
+                    type: LedgerSerializerType::DateType
+
+          attribute ledger_attribute: 'CurrencyRef.value',
+                    resource_attribute: 'currency'
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/adaptors/quickbooks_online/transfer/operations/create.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Create < Operation::Create
             class Contract < LedgerSync::Adaptors::Contract
               params do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).value(:nil)
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
@@ -15,35 +16,6 @@ module LedgerSync
                 required(:transaction_date).filled(:date?)
               end
             end
-
-            private
-
-            def operate
-              response = adaptor.post(
-                resource: 'transfer',
-                payload: local_resource_data
-              )
-
-              resource.ledger_id = response.dig('Id')
-              success(response: response)
-            end
-
-            def local_resource_data
-              {
-                'CurrencyRef' => {
-                  'value' => resource.currency,
-                },
-                'Amount' => resource.amount,
-                'TxnDate' => resource.transaction_date.to_s, # Format: YYYY-MM-DD
-                'PrivateNote' => resource.memo,
-                'FromAccountRef' => {
-                  'value' => resource.from_account.ledger_id
-                },
-                'ToAccountRef' => {
-                  'value' => resource.to_account.ledger_id
-                }
-              }
-            end
           end
         end
       end

data/lib/ledger_sync/adaptors/quickbooks_online/transfer/operations/find.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Find < Operation::Find
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
@@ -15,19 +16,6 @@ module LedgerSync
                 required(:transaction_date).maybe(:date?)
               end
             end
-
-            private
-
-            def operate
-              return failure(nil) if resource.ledger_id.nil?
-
-              response = adaptor.find(
-                resource: 'transfer',
-                id: resource.ledger_id
-              )
-
-              success(response: response)
-            end
           end
         end
       end

data/lib/ledger_sync/adaptors/quickbooks_online/transfer/operations/update.rb

@@ -1,11 +1,14 @@
+# frozen_string_literal: true
+
 module LedgerSync
   module Adaptors
     module QuickBooksOnline
       module Transfer
         module Operations
-          class Update < Operation::Update
+          class Update < Operation::FullUpdate
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
@@ -15,40 +18,6 @@ module LedgerSync
                 required(:transaction_date).filled(:date?)
               end
             end
-
-            private
-
-            def operate
-              ledger_resource_data = adaptor.find(
-                resource: 'transfer',
-                id: resource.ledger_id
-              )
-              response = adaptor.post(
-                resource: 'transfer',
-                payload: merge_into(from: local_resource_data, to: ledger_resource_data)
-              )
-
-              resource.ledger_id = response.dig('Id')
-              success(response: response)
-            end
-
-            def local_resource_data
-              {
-                'CurrencyRef' => {
-                  'value' => resource.currency,
-                },
-                'Amount' => resource.amount,
-                'TxnDate' => resource.transaction_date.to_s, # Format: YYYY-MM-DD
-                'PrivateNote' => resource.memo,
-                'FromAccountRef' => {
-                  'value' => resource.from_account.ledger_id
-                },
-                'ToAccountRef' => {
-                  'value' => resource.to_account.ledger_id
-                }
-              }
-
-            end
           end
         end
       end

data/lib/ledger_sync/adaptors/quickbooks_online/util/adaptor_error_parser.rb

@@ -90,7 +90,8 @@ module LedgerSync
 
               return matcher.error_klass.new(
                 adaptor: adaptor,
-                message: matcher.output_message
+                message: matcher.output_message,
+                response: error
               )
             end
             nil

data/lib/ledger_sync/adaptors/quickbooks_online/util/operation_error_parser.rb

@@ -87,7 +87,8 @@ module LedgerSync
 
               return matcher.error_klass.new(
                 operation: operation,
-                message: matcher.output_message
+                message: matcher.output_message,
+                response: error
               )
             end
           end

data/lib/ledger_sync/adaptors/quickbooks_online/vendor/ledger_serializer.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module LedgerSync
+  module Adaptors
+    module QuickBooksOnline
+      module Vendor
+        class LedgerSerializer < QuickBooksOnline::LedgerSerializer
+          id
+
+          attribute ledger_attribute: 'DisplayName',
+                    resource_attribute: :display_name
+
+          attribute ledger_attribute: 'GivenName',
+                    resource_attribute: :first_name
+
+          attribute ledger_attribute: 'FamilyName',
+                    resource_attribute: :last_name
+
+          attribute ledger_attribute: 'PrimaryEmailAddr.Address',
+                    resource_attribute: :email
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/adaptors/quickbooks_online/vendor/operations/create.rb

@@ -8,6 +8,7 @@ module LedgerSync
           class Create < Operation::Create
             class Contract < LedgerSync::Adaptors::Contract
               params do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).value(:nil)
                 optional(:display_name).maybe(:string)
                 optional(:first_name).maybe(:string)
@@ -15,29 +16,6 @@ module LedgerSync
                 optional(:email).maybe(:string)
               end
             end
-
-            private
-
-            def operate
-              response = adaptor.post(
-                resource: 'vendor',
-                payload: local_resource_data
-              )
-
-              resource.ledger_id = response.dig('Id')
-              success(response: response)
-            end
-
-            def local_resource_data
-              {
-                'DisplayName' => resource.display_name,
-                'GivenName' => resource.first_name,
-                'FamilyName' => resource.last_name,
-                'PrimaryEmailAddr' => {
-                  'Address' => resource.email
-                }
-              }
-            end
           end
         end
       end

data/lib/ledger_sync/adaptors/quickbooks_online/vendor/operations/find.rb

@@ -8,6 +8,7 @@ module LedgerSync
           class Find < Operation::Find
             class Contract < LedgerSync::Adaptors::Contract
               params do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:display_name).maybe(:string)
                 required(:first_name).maybe(:string)
@@ -15,19 +16,6 @@ module LedgerSync
                 optional(:email).maybe(:string)
               end
             end
-
-            private
-
-            def operate
-              return failure(nil) if resource.ledger_id.nil?
-
-              response = adaptor.find(
-                resource: 'vendor',
-                id: resource.ledger_id
-              )
-
-              success(response: response)
-            end
           end
         end
       end

data/lib/ledger_sync/adaptors/quickbooks_online/vendor/operations/update.rb

@@ -5,9 +5,10 @@ module LedgerSync
     module QuickBooksOnline
       module Vendor
         module Operations
-          class Update < Operation::Update
+          class Update < Operation::FullUpdate
             class Contract < LedgerSync::Adaptors::Contract
               params do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 optional(:display_name).maybe(:string)
                 optional(:first_name).maybe(:string)
@@ -15,34 +16,6 @@ module LedgerSync
                 optional(:email).maybe(:string)
               end
             end
-
-            private
-
-            def operate
-              ledger_resource_data = adaptor.find(
-                resource: 'vendor',
-                id: resource.ledger_id
-              )
-
-              response = adaptor.post(
-                resource: 'vendor',
-                payload: merge_into(from: local_resource_data, to: ledger_resource_data)
-              )
-
-              resource.ledger_id = response.dig('Id')
-              success(response: response)
-            end
-
-            def local_resource_data
-              {
-                'DisplayName' => resource.display_name,
-                'GivenName' => resource.first_name,
-                'FamilyName' => resource.last_name,
-                'PrimaryEmailAddr' => {
-                  'Address' => resource.email
-                }
-              }
-            end
           end
         end
       end

data/lib/ledger_sync/adaptors/test/account/operations/create.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Create < Operation::Create
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).value(:nil)
                 required(:name).filled(:string)
                 required(:classification).filled(:string)
@@ -43,7 +44,10 @@ module LedgerSync
 
               resource.ledger_id = response.dig('id')
 
-              success(response: response)
+              success(
+                resource: Test::LedgerSerializer.new(resource: resource).deserialize(hash: response),
+                response: response
+              )
             end
           end
         end

data/lib/ledger_sync/adaptors/test/account/operations/find.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Find < Operation::Find
             class Contract < LedgerSync::Adaptors::Contract
               params do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:name).maybe(:string)
                 required(:classification).maybe(:string)
@@ -28,7 +29,10 @@ module LedgerSync
                 id: resource.ledger_id
               )
 
-              success(response: response)
+              success(
+                resource: Test::LedgerSerializer.new(resource: resource).deserialize(hash: response),
+                response: response
+              )
             end
           end
         end

data/lib/ledger_sync/adaptors/test/account/operations/invalid.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Invalid < Operation::Create
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:name).maybe(:string)
                 required(:classification).maybe(:string)

data/lib/ledger_sync/adaptors/test/account/operations/update.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Update < Operation::Update
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:name).filled(:string)
                 required(:classification).filled(:string)
@@ -26,12 +27,17 @@ module LedgerSync
                 id: resource.ledger_id
               )
 
+              find_serializer = Test::LedgerSerializer.new(resource: resource).deserialize(hash: ledger_resource_data)
+
               response = adaptor.post(
                 resource: 'account',
-                payload: merge_into(from: local_resource_data, to: ledger_resource_data)
+                payload: find_serializer.to_h
               )
 
-              success(response: response)
+              success(
+                resource: Test::LedgerSerializer.new(resource: resource).deserialize(hash: response),
+                response: response
+              )
             end
 
             def local_resource_data

data/lib/ledger_sync/adaptors/test/account/operations/valid.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Valid < Operation::Create
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                optional(:external_id).maybe(:string)
                 optional(:ledger_id).maybe(:string)
                 required(:name).filled(:string)
                 required(:classification).filled(:string)

data/lib/ledger_sync/adaptors/test/customer/operations/create.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Create < Operation::Create
             class Contract < LedgerSync::Adaptors::Contract
               schema do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).value(:nil)
                 required(:email).maybe(:string)
                 required(:name).filled(:string)
@@ -37,7 +38,10 @@ module LedgerSync
 
               resource.ledger_id = response.dig('id')
 
-              success(response: response)
+              success(
+                response: response,
+                resource: resource
+              )
             end
           end
         end

data/lib/ledger_sync/adaptors/test/customer/operations/find.rb

@@ -6,6 +6,7 @@ module LedgerSync
           class Find < Operation::Find
             class Contract < LedgerSync::Adaptors::Contract
               params do
+                required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 optional(:email).maybe(:string)
                 optional(:name).maybe(:string)
@@ -23,7 +24,10 @@ module LedgerSync
                 id: resource.ledger_id
               )
 
-              success(response: response)
+              success(
+                resource: Test::LedgerSerializer.new(resource: resource).deserialize(hash: response),
+                response: response
+              )
             end
           end
         end