lazylead 0.9.1 → 0.10.1

data/lib/messages/svn_diff_attachment.erb

@@ -91,18 +91,16 @@
 <p>Commit(s) since <code><%= since_rev %></code> revision in <a href="<%= svn_url %>"><%= svn_url %></a>:</p>
 <div id="table-of-contents" class="table-of-contents">
   <ul>
-    <% stdout.split("------------------------------------------------------------------------").reject(&:blank?).reverse.each do |commit| %>
-      <% details = commit.split("\n").reject(&:blank?).first.split("|").map(&:strip).reject(&:blank?) %>
-      <li><a href="#<%= details[0] %>"><%= details[0] %></a> by <%= details[1] %> at <%= details[2] %></li>
+    <% commits.each do |commit| %>
+      <li><a href="#<%= commit.rev %>"><%= commit.rev %></a> by <%= commit.author %> at <%= commit.time %></li>
     <% end %>
   </ul>
 </div>
-<% stdout.split("------------------------------------------------------------------------").reject(&:blank?).reverse.each do |commit| %>
+<% commits.each do |commit| %>
   <div class="commit">
-    <% commit.split("\n").reject(&:blank?).each_with_index do |line, index| %>
+    <% commit.lines.each_with_index do |line, index| %>
       <% if index.zero? %>
-        <% details = line.split("|").map(&:strip).reject(&:blank?) %>
-        <p style="background: gainsboro;" id="<%= details[0] %>"><a href="<%= commit_url %><%= details[0][1..-1] %>"><%= details[0] %></a> by <a href="<%= user %><%= details[1] %>"><%= details[1] %></a> at <span style="color: #275a90;"><%= details[2] %></span>
+        <p style="background: gainsboro;" id="<%= commit.rev %>"><a href="<%= commit_url %><%= commit.rev %>"><%= commit.rev %></a> by <a href="<%= user %><%= commit.author %>"><%= commit.author %></a> at <span style="color: #275a90;"><%= commit.time %></span>
           <a href="#table-of-contents">&#8593;</a>
         </p>
       <% else %>

data/lib/messages/svn_grep.erb

@@ -64,14 +64,8 @@
       padding: 36px
     }
 
-    .commit {
-      min-width: 100%;
-      border-radius: 3.5px;
-      overflow: hidden;
-      display: inline-block;
-      line-height: 15px;
-      font-family: Menlo, Monaco, Consolas, "Courier New", monospace;
-      border: 1px solid #BCC6CC;
+    td {
+      padding: 2px;
     }
 
     .commit * {
@@ -86,29 +80,37 @@
 <p>Hi,</p>
 <p>The following file(s) contain text <code><%= text %></code> in
   <a href="<%= svn_url %>"><%= svn_url %></a>:</p>
-<% entries.each do |commit| %>
-  <div class="commit">
-    <p style="background: gainsboro;">
-      <a href="<%= commit_url %><%= commit.rev %>"><%= commit.msg %></a>
-      by <a href="<%= user %><%= commit.author %>"><%= commit.author %></a>
-      at <span style="color: #275a90;"><%= commit.time %></span>
-    </p>
-    <% commit.diff(text.split(",")).each do |line| %>
-      <% if line.start_with?("+++") || line.start_with?("---") %>
-        <p style="background: gainsboro;"><%= line.gsub(/[<>]/, '<' => '&lt;', '>' => '&gt;') %></p>
-      <% elsif text.split(",").any? { |t| line.include? t } %>
-        <p style="background: #F9F103;"><%= line.gsub(/[<>]/, '<' => '&lt;', '>' => '&gt;') %></p>
-      <% elsif line.start_with?("+") %>
-        <p style="<%= "background: darkseagreen;" %>"><%= line.gsub(/[<>]/, '<' => '&lt;', '>' => '&gt;') %></p>
-      <% elsif line.start_with?("-") %>
-        <p style="<%= "background: lightsalmon;" %>"><%= line.gsub(/[<>]/, '<' => '&lt;', '>' => '&gt;') %></p>
-      <% else %>
-        <p style="background: gainsboro;"><%= line.gsub(/[<>]/, '<' => '&lt;', '>' => '&gt;') %></p>
-      <% end %>
-    <% end %>
-  </div>
-<% end %>
-<p>Posted by<a href="https://github.com/dgroup/lazylead">lazylead
-  v<%= version %></a>.</p>
+<table summary="table with svn commits">
+  <tr>
+    <th id="rev">rev</th>
+    <th id="when">when</th>
+    <th id="author">author</th>
+    <th id="commit_msg" style="text-align: left">commit</th>
+  </tr>
+  <% entries.each do |commit| %>
+    <tr>
+      <td><a href="<%= commit_url %><%= commit.rev %>"><%= commit.rev %></a></td>
+      <td><%= commit.time %></td>
+      <td><a href="<%= user %><%= commit.author %>"><%= commit.author %></a></td>
+      <td>
+        <b><p><%= commit.msg %></p></b>
+        <% commit.diff(text.split(",")).each do |line| %>
+          <% if line.start_with?("+++") || line.start_with?("---") %>
+            <p style="background: gainsboro;"><%= line.gsub(/[<>]/, '<' => '&lt;', '>' => '&gt;') %></p>
+          <% elsif text.split(",").any? { |t| line.include? t } %>
+            <p style="background: #F9F103;"><%= line.gsub(/[<>]/, '<' => '&lt;', '>' => '&gt;') %></p>
+          <% elsif line.start_with?("+") %>
+            <p style="<%= "background: darkseagreen;" %>"><%= line.gsub(/[<>]/, '<' => '&lt;', '>' => '&gt;') %></p>
+          <% elsif line.start_with?("-") %>
+            <p style="<%= "background: lightsalmon;" %>"><%= line.gsub(/[<>]/, '<' => '&lt;', '>' => '&gt;') %></p>
+          <% else %>
+            <p style="background: gainsboro;"><%= line.gsub(/[<>]/, '<' => '&lt;', '>' => '&gt;') %></p>
+          <% end %>
+        <% end %>
+      </td>
+    </tr>
+  <% end %>
+</table>
+<p>Posted by<a href="https://github.com/dgroup/lazylead">lazylead v<%= version %></a>.</p>
 </body>
 </html>

data/readme.md

@@ -48,13 +48,15 @@ Join our telegram group [lazylead.org](https://t.me/lazyleads) for discussions.
 | Create a meeting(s) automatically in case some tickets appeared (group by assignee/reporters/component/ticket type/etc) | ⌛ | ⌛ | ⌛ | ❌ | 
 | Propogate fields from parent tickets to sub-tasks | ✅ | ⌛ | ⌛ | ❌ | 
 | Notify about tickets without comments with expected text | ✅ | ⌛ | ⌛ | ❌ | 
-| Notify about team loading (no tasks on teammates) | ✅ | ⌛ | ⌛ | ❌ | 
+| [Notify about team loading (no tasks on teammates)](lib/lazylead/task/loading.rb) | ✅ | ⌛ | ⌛ | ❌ | 
 | Notify about tickets matches predefined multiple conditions | ✅ | ⌛ | ⌛ | ❌ | 
 | Link automatically the ticket and Confluence page if link found in ticket's comments/description | ✅ | ⌛ | ⌛ | ❌ | 
 | Notify about tickets assigned to your team members not by effective managers| ✅ | ⌛ | ⌛ | ❌ | 
 | Notify about modifications of important files in VCS | ❌ | ⌛ | ❌ | ✅ | 
 | Notify about diff changes for past X period in VCS | ❌ | ⌛ | ❌ | ✅ | 
 | Notify about changes with some text for past X period in VCS | ❌ | ⌛ | ❌ | ✅ | 
+| [Notify when someone outside of your team changed the due date on tickets for your team](lib/lazylead/task/micromanager.rb)| ✅ | ⌛ | ❌ | ❌ | 
+| [Notify when someone outside of your team assigned a ticket directly to the developer](lib/lazylead/task/assignment.rb)| ✅ | ⌛ | ❌ | ❌ | 
 
 | Integration                                           | Type          | Status |
 | :---------------------------------------------------- | :-----------: | :----: |
@@ -65,7 +67,7 @@ Join our telegram group [lazylead.org](https://t.me/lazyleads) for discussions.
 | calendar.google.com                                   | Calendar      | ⌛ |
 | slack.com                                             | Notifications | ⌛ |
 
-✅ - implemented, ⌛ - planned, 🌵 - implemented, but not tested, ❌ - not supported by ticketing system.
+✅ - implemented, ⌛ - planned, 🌵 - implemented, but not tested, ❌ - not supported/planned.
 
 New ideas, bugs, suggestions or questions are welcome [via GitHub issues](https://github.com/dgroup/lazylead/issues/new)!
 
@@ -173,11 +175,12 @@ For simplicity, we are using [docker-compose](https://docs.docker.com/compose/):
     ```
 
 ### How to contribute?
-[![EO badge](http://www.elegantobjects.org/badge.svg)](http://www.elegantobjects.org/#principles) 
 
-Pull requests are welcome! Don't forget to add your name to contribution section and run this, beforehand:
+<a href="https://www.buymeacoffee.com/lazylead" target="_blank"><img src="https://www.buymeacoffee.com/assets/img/custom_images/orange_img.png" alt="Buy Me A Coffee" style="height: 41px !important;width: 174px !important;box-shadow: 0px 3px 2px 0px rgba(190, 190, 190, 0.5) !important;-webkit-box-shadow: 0px 3px 2px 0px rgba(190, 190, 190, 0.5) !important;" ></a>
+
+[Pull requests](http://www.elegantobjects.org/#principles) are welcome! Don't forget to add your name to contribution section and run this, beforehand:
 ```ruby
-bundle exec rake
+rake -A
 ```
 Everyone interacting in this project’s codebases, issue trackers, chat rooms is expected to follow the [code of conduct](.github/CODE_OF_CONDUCT.md).
 

data/test/lazylead/system/jira_test.rb

@@ -194,5 +194,13 @@ module Lazylead
         "context_path" => ""
       ).issues("key=DATAJDBC-480")
     end
+
+    test "sprint is found" do
+      assert_equal "Sprint 68",
+                   NoAuthJira.new("https://jira.spring.io")
+                             .issues("key=XD-3744", fields: ["customfield_10480"])
+                             .first
+                             .sprint("customfield_10480")
+    end
   end
 end

data/test/lazylead/task/accuracy/accuracy_test.rb

@@ -56,7 +56,7 @@ module Lazylead
         )
       )
       assert_email "[LL] Raised tickets",
-                   %w[DATAJDBC-493 0.5 100% MyeongHyeonLee Deadlock\ occurs]
+                   "DATAJDBC-493", "0.5", "100%", "MyeongHyeonLee", "Deadlock occurs"
     end
 
     test "construct accuracy from orm" do

data/test/lazylead/task/accuracy/logs_link_test.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2021 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require_relative "../../../test"
+require_relative "../../../../lib/lazylead/task/accuracy/logs_link"
+
+module Lazylead
+  class LogsLinkTest < Lazylead::Test
+    test "log file is present" do
+      assert LogsLink.new("https://mygraylog.com/log#5").passed(
+        OpenStruct.new(
+          attachments: [OpenStruct.new(attrs: { "size" => 10_241, "filename" => "catalina.log" })]
+        )
+      )
+    end
+
+    test "log file is absent but description has log reference" do
+      assert LogsLink.new("https://mygraylog.com").passed(
+        OpenStruct.new(description: "Here is the log for current ticket https://mygraylog.com/log#5")
+      )
+    end
+
+    test "log file is absent and link is absent" do
+      refute LogsLink.new("https://mygraylog.com").passed(
+        OpenStruct.new(attachments: [])
+      )
+    end
+  end
+end

data/test/lazylead/task/accuracy/onlyll_test.rb

@@ -69,7 +69,7 @@ module Lazylead
         )
       )
       assert_email "[LL] Only",
-                   %w[XD-3725 Blocker EmbeddedHeadersMessageConverter]
+                   "XD-3725", "Blocker", "EmbeddedHeadersMessageConverter"
     end
 
     test "detect score" do

data/test/lazylead/task/accuracy/screenshots_test.rb

@@ -65,12 +65,10 @@ module Lazylead
     end
 
     test "issue has two .png files with reference in description but with extension mismatch" do
-      refute Screenshots.new.passed(
+      refute Screenshots.new(minimum: 2).passed(
         OpenStruct.new(
           description: "Hi,\n here are snapshots !img1.jpg|thumbnail!\n!img2.jpg|thumbnail!\n",
-          fields: {
-            "description" => "Hi,\n here are snapshots !img1.jpg|thumbnail!\n!img2.jpg|thumbnail!\n"
-          },
+          fields: { "description" => "-" },
           attachments: [
             OpenStruct.new("filename" => "img1.JPG"),
             OpenStruct.new("filename" => "img2.jpg")

data/test/lazylead/task/accuracy/testcase_test.rb

@@ -273,6 +273,40 @@ module Lazylead
                         *{color:#DE10AA}[AR]{color}* = YYYY"
     end
 
+    test "TC named use case" do
+      assert testcase? "{color:#0747a6}+*Use case*+{color}
+                         # Step 1
+                         # Step ..
+                         # Step N
+                        *{color:#00673A}[ER]{color}* = XXXX
+                        *{color:#DE10AA}[AR]{color}* = YYYY"
+    end
+
+    test "TC with full ar er words" do
+      assert testcase? "{color:#0747a6}+*Use case*+{color}
+                         # Step 1
+                         # Step ..
+                         # Step N
+                        *{color:#00673A}Expected result:{color}* = XXXX
+                        *{color:#DE10AA}Actual Result:{color}* = YYYY"
+    end
+
+    test "TC with prerequisites" do
+      assert testcase? "{color:#0747a6}+*Pre-requisites and Steps:*+{color}
+                         # Step 1
+                         # Step ..
+                         # Step N
+                        *{color:#00673A}Expected result:{color}* = XXXX
+                        *{color:#DE10AA}Actual Result:{color}* = YYYY"
+    end
+
+    test "TC with h3" do
+      assert testcase? "h3. Steps: Start updating
+                        h3. ER: updating failed
+                        h3. AR: updating should be passed
+                        h3. Screenshots:   !r37.png|thumbnail!"
+    end
+
     # ensure that issue description has a test case, AR and ER
     def testcase?(desc)
       Testcase.new.passed(OpenStruct.new(description: desc))

data/test/lazylead/task/alert/alertif_test.rb

@@ -48,7 +48,8 @@ module Lazylead
           "template" => "lib/messages/alertif.erb"
         )
       )
-      assert_email "[LL] alert if", %w[XD-3064 Critical	Done Glenn Risberg HdfsMongoDB]
+      assert_email "[LL] alert if",
+                   "XD-3064", "Critical", "Done", "Glenn Renfro", "Thomas Risberg", "HdfsMongoDB"
     end
   end
 end

data/test/lazylead/task/assignment_test.rb

@@ -47,7 +47,8 @@ module Lazylead
         )
       )
       assert_email "Assignment: How dare you?",
-                   %w[DATAJDBC-480 01-Apr-2020 Minor Mark\ Paluch tom,mike,bob EntityInstantiators]
+                   "DATAJDBC-480", "01-Apr", "Minor", "Mark Paluch", "tom,mike,bob",
+                   "EntityInstantiators"
     end
   end
 end

data/test/lazylead/task/created_recently_test.rb

@@ -47,7 +47,8 @@ module Lazylead
           "template" => "lib/messages/created_recently.erb"
         )
       )
-      assert_email "[CR] 20min ago!", %w[XD-3766 SGF-726]
+      assert_email "[CR] 20min ago!",
+                   "XD-3766", "SGF-726"
     end
   end
 end

data/test/lazylead/task/duedate_test.rb

@@ -82,7 +82,7 @@ module Lazylead
         )
       )
       assert_email "[DD] HMCHT!",
-                   %w[STS-3599 2013-11-08 Major Miles\ Parker Use JavaFX WebView]
+                   "STS-3599", "2013-11-08", "Major", "Miles Parker", "Use JavaFX WebView"
     end
 
     test "send notification about bunch of tickets" do
@@ -100,7 +100,7 @@ module Lazylead
         )
       )
       assert_email "ALRT: Frozen",
-                   %w[Hi Boss STS-3599 2013-11-08 Major Miles\ Parker Use JavaFX WebView]
+                   "Hi Boss", "STS-3599", "2013-11-08", "Major", "Miles Parker", "Use JavaFX WebView"
     end
 
     test "cc got notification" do

data/test/lazylead/task/fix_version_test.rb

@@ -48,7 +48,8 @@ module Lazylead
         )
       )
       assert_email "FixVersion: How dare you?",
-                   %w[DATAJDBC-480 01-Apr-2020 Minor Mark\ Paluch tom,mike,bob EntityInstantiators]
+                   "DATAJDBC-480", "01-Apr-2020", "Minor", "Mark Paluch", "tom,mike,bob",
+                   "EntityInstantiators"
     end
   end
 end

data/test/lazylead/task/loading_test.rb

@@ -41,15 +41,19 @@ module Lazylead
           "to" => "lead@company.com",
           "from" => "ll@company.com",
           "jql" => "key in (STS-3599, XD-3739, XD-3744)",
-          "team" => "mclaren:Tom McLaren,milesparker:Mi Pa",
+          "team" => "mclaren:Tom McLaren,milesparker:Mi Pa,grussell:Gary Ru",
           "user_link" => "https://user.com?id=",
           "search_link" => "https://jira.spring.io/issues/?jql=",
           "fields" => "assignee,duedate,customfield_10480",
+          "sprint" => "customfield_10480",
           "subject" => "[LL] Team loading",
           "template" => "lib/messages/loading.erb"
         )
       )
-      assert_email "[LL] Team loading", %w[mclaren Tom McLaren 0]
+      assert_email "[LL] Team loading",
+                   "grussell", "Gary Ru", "Sprint 68", "1",
+                   "Miles Parker", "No sprint: 1", "2013-11-08",
+                   "Tom McLaren", "0"
     end
   end
 end

data/test/lazylead/task/micromanager_test.rb

@@ -43,12 +43,19 @@ module Lazylead
           "jql" => "key in ('STS-3599','SPR-6541') and duedate is not empty",
           "fields" => "assignee,duedate,priority,created,summary,reporter",
           "allowed" => "tom,mike,bob",
+          "period" => "86400",
+          "now" => "2009-12-10T00:04:00.000+0000",
           "subject" => "DD: How dare you?",
           "template" => "lib/messages/illegal_duedate_change.erb"
         )
       )
       assert_email "DD: How dare you?",
-                   %w[SPR-6541	Major	(kdonald)	2009-12-10 Spring's\ Maven\ Central tom,mike,bob]
+                   "SPR-6541", "Major", "(kdonald)", "2009-12-10", "Spring's Maven Central", "tom,mike,bob"
+    end
+
+    test "since for past 1 min" do
+      greater_or_eq Task::Micromanager.new.since("period" => 60).to_i,
+                    (Time.now - 60).to_i
     end
   end
 end

data/test/lazylead/task/missing_comment_test.rb

@@ -50,7 +50,7 @@ module Lazylead
         )
       )
       assert_email "Expected ftp link is missing",
-                   %w[DATAJDBC-523 Major Mark\ Paluch https://github.com/spring-projects/spring-data-jdbc/commit/aadbb667ed1d61139d5ac51a06eb3dd1b39316db#diff-510a5041bb8a0575e97fedf105606b83R130]
+                   "DATAJDBC-523", "Major", "Mark Paluch", "https://github.com/spring-projects/spring-data-jdbc/commit/aadbb667ed1d61139d5ac51a06eb3dd1b39316db#diff-510a5041bb8a0575e97fedf105606b83R130"
     end
   end
 end

data/test/lazylead/task/svn/diff_test.rb

@@ -57,7 +57,7 @@ module Lazylead
           "template-attachment" => "lib/messages/svn_diff_attachment.erb"
         )
       )
-      assert_email_line "[SVN] Changed since rev1", %w[r2 by dgroup at 2020-08-16]
+      assert_email_line "[SVN] Changed since rev1", %w[r2 by dgroup at 16-08-2020]
       # assert_attachment "[SVN] Changed since rev1", /^.*svn-log-.*.html.zip$/
     end
 

data/test/lazylead/task/svn/grep_test.rb

@@ -28,6 +28,7 @@ require_relative "../../../../lib/lazylead/smtp"
 require_relative "../../../../lib/lazylead/opts"
 require_relative "../../../../lib/lazylead/postman"
 require_relative "../../../../lib/lazylead/task/svn/grep"
+require_relative "../../../../lib/lazylead/task/svn/svn"
 
 module Lazylead
   class GrepTest < Lazylead::Test
@@ -96,7 +97,7 @@ module Lazylead
 
 
       MSG
-      assert_equal 15, Entry.new(diff).diff(%w[ping]).size,
+      assert_equal 15, Lazylead::Svn::Commit.new(diff).diff(%w[ping]).size,
                    "There is one commit with 'ping' word where diff has 14 lines"
     end
   end

data/test/test.rb

@@ -79,9 +79,9 @@ module Lazylead
     end
 
     # Assert that text contains expected words
-    def assert_words(words, text)
+    def assert_words(*words, text)
       words = [words] unless words.respond_to? :each
-      words.each do |w|
+      words.first.each do |w|
         assert_includes text, w
       end
     end
@@ -103,7 +103,8 @@ module Lazylead
 
     # Assert that email sent using 'mail' gem in test mode
     #  has expected subject and words
-    def assert_email(subject, words)
+    def assert_email(subject, *words)
+      refute_empty words, "No words provided to match"
       email = Mail::TestMailer.deliveries
                               .find { |m| m.subject.eql? subject }
       refute_nil email, "No email found with subject: #{subject}"