lazylead 0.9.1 → 0.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2cbd092ef55bfdcf7887c4e0fcf5e5838a70b91eac82011893dc9423b22a0b74
-  data.tar.gz: 5d71b27626fbf5e9d60ea38cce1e06ab6637aa874daa057ff9b9f8451b095dbf
+  metadata.gz: ddf0f9e22eff50a83a0161cc969c6397c326d88a21dcc0a191634645a22bff67
+  data.tar.gz: ed262c75c351a8bdfc317123b04de69c854af92fe79234b01e85c3664e16a576
 SHA512:
-  metadata.gz: 748f97ab75655642143bd13d562aab38693df3f6496429d794e75f4c6bb9f0315537ad656027f639a9481ed0399345b3cef0f9ebcd83af680c69f5cf3be6380d
-  data.tar.gz: ea40e803198075657c05df31b251599aac4dbb55bf628a01e1d68bcffeedd09c713ca9d0858d153301ab88f518e5ab50a1486fbc58be3801e5a57264611d915c
+  metadata.gz: dc478328e0831adf45af81deaf82427e6f279607d3547fafe5c9593707eb3d39642426fc5f0239a0147fd0d007931e2712337a73da49dd33e6e423c16b947f9c
+  data.tar.gz: 930bb2edee338509549c3afe7d9d0dcea5f5391e7f5f6b6bf9cdfc9f2263cb723efedc0596df4e33babdf9d4c02af1401442dfa1ab7f5ffac6b13dccfb2b160b

data/.rubocop.yml

@@ -42,7 +42,7 @@ Metrics/MethodLength:
     - "test/**/*"
 
 Metrics/ParameterLists:
-  Max: 3
+  Max: 4
 
 Layout/HashAlignment:
   EnforcedColonStyle:

data/Rakefile

@@ -114,8 +114,7 @@ task :sqlint do
   if total.positive?
     abort "#{total.colorize(:red)} SQL violations found."
   else
-    puts "#{src.size} files inspected, #{'no offenses'.colorize(:green)} " \
-          "detected"
+    puts "#{src.size} files inspected, #{'no offenses'.colorize(:green)} detected"
   end
 end
 

data/lazylead.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |s|
   s.rubygems_version = "2.2"
   s.required_ruby_version = ">=2.6.5"
   s.name = "lazylead"
-  s.version = "0.9.1"
+  s.version = "0.10.1"
   s.license = "MIT"
   s.summary = "Eliminate the annoying work within bug-trackers."
   s.description = "Ticketing systems (Github, Jira, etc.) are strongly
@@ -45,7 +45,7 @@ tasks instead of solving technical problems."
   s.authors = ["Yurii Dubinka"]
   s.email = "yurii.dubinka@gmail.com"
   s.homepage = "http://github.com/dgroup/lazylead"
-  s.post_install_message = "Thanks for installing Lazylead v0.9.1!
+  s.post_install_message = "Thanks for installing Lazylead v0.10.1!
   Read our blog posts: https://lazylead.org
   Stay in touch with the community in Telegram: https://t.me/lazylead
   Follow us on Twitter: https://twitter.com/lazylead
@@ -58,7 +58,7 @@ tasks instead of solving technical problems."
   s.add_runtime_dependency "activerecord", "6.1.3"
   s.add_runtime_dependency "backtrace", "0.3"
   s.add_runtime_dependency "colorize", "0.8.1"
-  s.add_runtime_dependency "faraday", "1.4.1"
+  s.add_runtime_dependency "faraday", "1.5.1"
   s.add_runtime_dependency "get_process_mem", "0.2.7"
   s.add_runtime_dependency "inifile", "3.0.0"
   s.add_runtime_dependency "jira-ruby", "2.1.5"
@@ -69,9 +69,9 @@ tasks instead of solving technical problems."
   s.add_runtime_dependency "openssl", "2.1.2"
   s.add_runtime_dependency "railties", "6.1.3"
   s.add_runtime_dependency "require_all", "3.0.0"
-  s.add_runtime_dependency "rubyzip", "2.3.0"
+  s.add_runtime_dependency "rubyzip", "2.3.2"
   s.add_runtime_dependency "rufus-scheduler", "3.7.0"
-  s.add_runtime_dependency "slop", "4.8.2"
+  s.add_runtime_dependency "slop", "4.9.1"
   s.add_runtime_dependency "sqlite3", "1.4.2"
   s.add_runtime_dependency "tempfile", "0.1.1"
   s.add_runtime_dependency "tilt", "2.0.10"
@@ -80,21 +80,21 @@ tasks instead of solving technical problems."
   s.add_runtime_dependency "vcs4sql", "0.1.1"
   s.add_runtime_dependency "viewpoint", "1.1.1"
   s.add_development_dependency "codecov", "0.5.2"
-  s.add_development_dependency "guard", "2.16.2"
+  s.add_development_dependency "guard", "2.17.0"
   s.add_development_dependency "guard-minitest", "2.4.6"
   s.add_development_dependency "minitest", "5.14.4"
   s.add_development_dependency "minitest-fail-fast", "0.1.0"
   s.add_development_dependency "minitest-hooks", "1.5.0"
   s.add_development_dependency "minitest-reporters", "1.4.3"
   s.add_development_dependency "net-ping", "2.0.8"
-  s.add_development_dependency "rake", "13.0.3"
+  s.add_development_dependency "rake", "13.0.6"
   s.add_development_dependency "random-port", "0.5.1"
-  s.add_development_dependency "rdoc", "6.3.0"
-  s.add_development_dependency "rubocop", "1.13.0"
-  s.add_development_dependency "rubocop-minitest", "0.12.1"
-  s.add_development_dependency "rubocop-performance", "1.11.0"
-  s.add_development_dependency "rubocop-rake", "0.5.1"
-  s.add_development_dependency "rubocop-rspec", "2.3.0"
+  s.add_development_dependency "rdoc", "6.3.2"
+  s.add_development_dependency "rubocop", "1.18.3"
+  s.add_development_dependency "rubocop-minitest", "0.14.0"
+  s.add_development_dependency "rubocop-performance", "1.11.4"
+  s.add_development_dependency "rubocop-rake", "0.6.0"
+  s.add_development_dependency "rubocop-rspec", "2.4.0"
   s.add_development_dependency "sqlint", "0.2.0"
   s.add_development_dependency "tempfile", "0.1.1"
   s.add_development_dependency "xcop", "0.6.2"

data/lib/lazylead/confluence.rb

@@ -76,8 +76,7 @@ module Lazylead
       return "" if resp.blank?
       pages = JSON.parse(resp)
       return "" if pages["results"].empty?
-      "#{@conf.url}/pages/viewpage.action?"\
-          "pageId=#{pages['results'].first['id']}"
+      "#{@conf.url}/pages/viewpage.action?pageId=#{pages['results'].first['id']}"
     end
   end
 

data/lib/lazylead/os.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2021 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+module Lazylead
+  #
+  # Represents a native, operation system.
+  #
+  # Author:: Yurii Dubinka (yurii.dubinka@gmail.com)
+  # Copyright:: Copyright (c) 2019-2020 Yurii Dubinka
+  # License:: MIT
+  class OS
+    #
+    # Run OS-oriented command
+    # @param cmd
+    #        The command could be a single string or array of strings.
+    #        Examples                 Final command to OS
+    #        run("ls")                "ls"                  => stdout
+    #        run("ls", "-lah")        "ls -lah"             => stdout
+    #        run()                    N/A                   => ""
+    #        run("ls", nil, "-lah")   N/A                   => ""
+    #        run("ls", "", "-lah")    "ls -lah"             => stdout
+    #
+    # @return stdout
+    #         Please note, that this is not a raw stdout.
+    #         The output will be modified by String#scrub! in order to avoid invalid byte sequence
+    #         in UTF-8 (https://stackoverflow.com/a/24037885/6916890).
+    def run(*cmd)
+      return "" if cmd.empty? || cmd.any?(&:nil?)
+      todo = cmd
+      todo = [cmd.first] if cmd.size == 1
+      `#{todo.join(" ")}`.scrub!
+    end
+  end
+end

data/lib/lazylead/task/accuracy/accuracy.rb

@@ -86,7 +86,7 @@ module Lazylead
         "Hi [~#{reporter}],",
         "",
         "The triage accuracy is '{color:#{color}}#{@score}{color}'" \
-          " (~{color:#{color}}#{@accuracy}%{color}), here are the reasons why:",
+        " (~{color:#{color}}#{@accuracy}%{color}), here are the reasons why:",
         "|| Ticket requirement || Status || Field ||"
       ]
       @opts[:rules].each do |r|
@@ -94,8 +94,7 @@ module Lazylead
       end
       comment << docs_link
       comment << ""
-      comment << "Posted by [lazylead v#{Lazylead::VERSION}|" \
-                    "https://bit.ly/2NjdndS]."
+      comment << "Posted by [lazylead v#{Lazylead::VERSION}|https://bit.ly/2NjdndS]."
       comment.join("\r\n")
     end
 

data/lib/lazylead/task/accuracy/attachment.rb

@@ -28,6 +28,7 @@ module Lazylead
   # Check that ticket has an attachment.
   class Attachment < Lazylead::Requirement
     def passed(issue)
+      return false if issue.nil? || issue.attachments.nil?
       issue.attachments.any? { |a| matches?(a) }
     end
 

data/lib/lazylead/task/accuracy/environment.rb

@@ -22,18 +22,13 @@
 # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
-require_relative "requirement"
+require_relative "required"
 
 module Lazylead
   # A requirement that Jira field "Environment" provided by the reporter.
-  class Environment < Requirement
+  class Environment < Lazylead::Required
     def initialize(score = 0.5)
-      super "Environment details (URL, patches)", score, "Environment"
-    end
-
-    # @return true if an issue has non-empty "Environment" field
-    def passed(issue)
-      non_blank? issue, "environment"
+      super "Environment details (URL, patches)", score, "Environment", "environment"
     end
   end
 end

data/lib/lazylead/task/accuracy/logs_link.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2021 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require_relative "logs"
+require_relative "attachment"
+
+module Lazylead
+  # Check that ticket has link/reference to log record(s) in another system like ELK, GrayLog, etc.
+  #  or attachment with plain log file
+  class LogsLink < Lazylead::Logs
+    def initialize(link)
+      super
+      @link = link
+    end
+
+    def passed(issue)
+      super(issue) || link?(issue)
+    end
+
+    # Ensure that ticket has a link to external logs system like ELK, GrayLog, etc.
+    def link?(issue)
+      return false if issue.description.nil?
+      issue.description
+           .split("\n")
+           .reject(&:blank?)
+           .flat_map(&:split)
+           .reject(&:blank?)
+           .any? { |word| word.start_with? @link }
+    end
+  end
+end

data/lib/lazylead/task/accuracy/records.rb

@@ -28,7 +28,7 @@ module Lazylead
   # Check that ticket has video record(s) with reproducing results.
   class Records < Lazylead::Attachment
     def initialize(ext = [])
-      super("Recorded internal reproducing results", 5, "Attachments")
+      super("Internal reproducing results (video)", 5, "Attachments")
       @ext = ext
       return unless @ext.empty?
       @ext = %w[.webm .mkv .flv .flv .vob .ogv .ogg .drc .gif .gifv .mng .avi

data/lib/lazylead/task/accuracy/required.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2021 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require_relative "requirement"
+
+module Lazylead
+  #
+  # Check that ticket has mandatory non-blank field(s).
+  #
+  class Required < Lazylead::Requirement
+    def initialize(desc, score, msg, *fields)
+      super desc, score, msg
+      @fields = fields
+    end
+
+    def passed(issue)
+      return false if @fields.nil? || @fields.empty?
+      return true if @fields.all? { |f| non_blank?(issue, f) }
+      false
+    end
+  end
+end

data/lib/lazylead/task/accuracy/screenshots.rb

@@ -35,15 +35,14 @@ module Lazylead
   class Screenshots < Lazylead::Requirement
     # @param minimum The number of expected screenshots
     def initialize(minimum: 1, score: 2, ext: %w[.jpg .jpeg .exif .tiff .tff .bmp .png .svg])
-      super "Screenshots", score, "Description,Attachments"
+      super "Internal reproducing results (screenshots)", score, "Description,Attachments"
       @minimum = minimum
       @ext = ext
     end
 
     def passed(issue)
       return false if issue.attachments.nil? || blank?(issue, "description")
-      ref = references(issue)
-      ref.size < @minimum ? false : ref.all? { |r| pictures(issue).any? { |file| r.include? file } }
+      references(issue).count { |r| pictures(issue).any? { |file| r.include? file } } >= @minimum
     end
 
     # Detect all references in ticket description to attachments (including web links).

data/lib/lazylead/task/accuracy/servers.rb

@@ -32,18 +32,18 @@ module Lazylead
     # @param envs regexp expressions to match servers in description.
     #
     def initialize(score: 2, envs: [], desc: "Internal reproducing results")
-      super desc, score, "Description/Environment"
+      super desc, score, "Description"
       @envs = envs
     end
 
     def passed(issue)
       return true if @envs.empty?
-      "#{issue['environment']}\n#{issue.description}".split("\n")
-                                                     .reject(&:blank?)
-                                                     .map(&:strip)
-                                                     .flat_map { |l| l.split.map(&:strip) }
-                                                     .select { |u| url?(u) }
-                                                     .any? { |u| match?(u) }
+      issue.description.split("\n")
+           .reject(&:blank?)
+           .map(&:strip)
+           .flat_map { |l| l.split.map(&:strip) }
+           .select { |u| url?(u) }
+           .any? { |u| match?(u) }
     end
 
     # Ensure that particular text contains web url

data/lib/lazylead/task/accuracy/testcase.rb

@@ -37,11 +37,11 @@ module Lazylead
     def passed(issue)
       return false if issue.description.nil?
       @tc = @ar = @er = -1
-      issue.description.split("\n").reject(&:blank?).each_with_index do |l, i|
-        line = escape l.downcase.gsub(/(\s+|\*|\+)/, "")
-        detect_tc line, i
-        detect_ar line, i
-        detect_er line, i
+      issue.description.split("\n").reject(&:blank?).map(&:downcase).each_with_index do |l, i|
+        line = escape l.gsub(/(\s+|\*|\+)/, "")
+        detect_tc i, l, line
+        detect_ar i, l, line
+        detect_er i, l, line
         break if with_tc_ar_er?
       end
       with_tc_ar_er?
@@ -63,30 +63,37 @@ module Lazylead
     end
 
     # Detect index of line with test case
-    def detect_tc(line, index)
+    # @param index The line number in description
+    # @param src The whole line in lower case from description
+    # @param strip The escaped line in lower case from description without special symbol(s)
+    def detect_tc(index, src, strip)
       return unless @tc.negative?
-      @tc = index if eql? line,
-                          %w[testcase: tc: teststeps: teststeps steps: tcsteps: tc testcases steps]
+      keywords = %w[testcase: tc: teststeps: teststeps steps: tcsteps: tc testcases steps usecase
+                    pre-requisitesandsteps:]
+      @tc = index if keywords.any? { |k| strip.eql? k }
+      @tc = index if keywords.any? { |k| src.include? k }
     end
 
     # Detect index of line with actual result
-    def detect_ar(line, index)
+    # @param index The line number in description
+    # @param src The whole line in lower case from description
+    # @param strip The escaped line in lower case from description without special symbol(s)
+    def detect_ar(index, src, strip)
       return unless @ar.negative? && index > @tc
-      @ar = index if starts? line, %w[ar: actualresult: ar= [ar]]
+      keywords = %w[ar: actualresult: ar= [ar] actualresult]
+      @ar = index if keywords.any? { |k| strip.start_with? k }
+      @ar = index if keywords.any? { |k| src.include? k }
     end
 
     # Detect index of line with expected result
-    def detect_er(line, index)
+    # @param index The line number in description
+    # @param src The whole line in lower case from description
+    # @param strip The escaped line in lower case from description without special symbol(s)
+    def detect_er(index, src, strip)
       return unless @er.negative? && index > @tc
-      @er = index if starts? line, %w[er: expectedresult: er= [er]]
-    end
-
-    def starts?(line, text)
-      text.any? { |t| line.start_with? t }
-    end
-
-    def eql?(line, text)
-      text.any? { |t| t.eql? line }
+      keywords = %w[er: expectedresult: er= [er] expectedresult]
+      @er = index if keywords.any? { |k| strip.start_with? k }
+      @er = index if keywords.any? { |k| src.include? k }
     end
   end
 end

data/lib/lazylead/task/fix_version.rb

@@ -39,15 +39,12 @@ module Lazylead
       def run(sys, postman, opts)
         allowed = opts.slice("allowed", ",")
         silent = opts.key? "silent"
-        issues = sys.issues(
-          opts["jql"], opts.jira_defaults.merge(expand: "changelog")
-        )
+        issues = sys.issues(opts["jql"], opts.jira_defaults.merge(expand: "changelog"))
+                    .map { |i| Version.new(i, allowed, silent) }
+                    .select(&:changed?)
+                    .each(&:add_label)
         return if issues.empty?
-        postman.send opts.merge(
-          versions: issues.map { |i| Version.new(i, allowed, silent) }
-                          .select(&:changed?)
-                          .each(&:add_label)
-        )
+        postman.send opts.merge(versions: issues)
       end
     end