lazylead 0.6.0 → 0.7.2

data/lib/lazylead/task/accuracy/onlyll.rb

@@ -0,0 +1,147 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2020 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require_relative "../../log"
+require_relative "../../opts"
+
+module Lazylead
+  module Task
+    #
+    # Ensure that ticket accuracy evaluation labels are set only by LL, not by
+    #  some person.
+    #
+    # The task supports the following features:
+    #  - fetch issues from remote ticketing system by query
+    #  - check the history of labels modification
+    #  - remove evaluation labels if they set not by LL
+    class OnlyLL
+      def initialize(log = Log.new)
+        @log = log
+      end
+
+      def run(sys, postman, opts)
+        found = sys.issues(opts["jql"],
+                           opts.jira_defaults.merge(expand: "changelog"))
+                   .map { |i| Labels.new(i, opts) }
+                   .select(&:exists?)
+                   .reject(&:valid?)
+                   .each(&:remove)
+        postman.send opts.merge(tickets: found) unless found.empty?
+      end
+    end
+  end
+
+  # The ticket with grid labels
+  class Labels
+    attr_reader :issue
+
+    def initialize(issue, opts)
+      @issue = issue
+      @opts = opts
+    end
+
+    # Ensure that issue has evaluation labels for accuracy rules
+    def exists?
+      return false if @issue.labels.nil? || @issue.labels.empty?
+      return false unless @issue.labels.is_a? Array
+      grid.any? { |g| @issue.labels.any? { |l| g.eql? l } }
+    end
+
+    # Compare the score evaluated by LL and current ticket score.
+    # @return true if current score equal to LL evaluation
+    def valid?
+      score.eql?(@issue.labels.sort.find { |l| grid.any? { |g| l.eql? g } })
+    end
+
+    # Find expected ticket score evaluated by LL.
+    # If LL evaluated the same ticket several times (no matter why),
+    #  then the last score would be returned.
+    def score
+      to_l(
+        @issue.history
+              .select { |h| h["author"]["key"].eql? @opts["author"] }
+              .reverse
+              .find { |h| to_l(h) }
+      ).fetch("toString", "").split.find { |l| grid.any? { |g| l.eql? g } }
+    end
+
+    # Find history record with labels changes.
+    def to_l(history)
+      return {} if history.nil? || history.empty?
+      history["items"].find { |f| f["field"].eql? "labels" }
+    end
+
+    # Detect the percentage grid for tickets, by default its 0%, 10%, 20%, etc.
+    def grid
+      @grid ||= begin
+        if @opts.key? "grid"
+          @opts.slice("grid", ",")
+        else
+          %w[0% 10% 20% 30% 40% 50% 60% 70% 80% 90% 100%]
+        end
+      end
+    end
+
+    # Remove score labels from the ticket.
+    def remove
+      @issue.labels!(@issue.labels - grid)
+    end
+
+    # Detect the violators with their changes.
+    #   .violators  => ["Tom Hhhh set 40%", "Bob Mmmm set 50%"]
+    def violators
+      @issue.history
+            .reject { |h| h["author"]["key"].eql? @opts["author"] }
+            .select { |h| grid?(h) }
+            .group_by { |h| h["author"]["key"] }
+            .map do |a|
+        "#{a.last.first['author']['displayName']} set #{hacked(a.last)}"
+      end
+    end
+
+    # Ensure that history record has label change related to LL grid labels.
+    # @return true if LL grid labels added
+    def grid?(record)
+      diff(record).any? { |d| d.find { |l| grid.any? { |g| l.eql? g } } }
+    end
+
+    # Detect label diff in single history record from ticket's history.
+    def diff(record)
+      record["items"].select { |f| f["field"].eql? "labels" }
+                     .reject { |f| f["toString"].nil? || f["toString"].blank? }
+                     .map do |f|
+        from = []
+        from = f["fromString"].split unless f["fromString"].nil?
+        f["toString"].split - from
+      end
+    end
+
+    # Hacked score by violator in ticket's history.
+    def hacked(record)
+      diff(record.first)
+        .first
+        .find { |l| grid.any? { |g| l.eql? g } }
+    end
+  end
+end

data/lib/lazylead/task/accuracy/records.rb

@@ -38,7 +38,7 @@ module Lazylead
     end
 
     # Ensure that ticket has an attachment with video-file extension
-    def matching(attach)
+    def matches?(attach)
       @ext.any? { |e| e.eql? File.extname(attach.attrs["filename"]).downcase }
     end
   end

data/lib/lazylead/task/accuracy/servers.rb

@@ -38,13 +38,22 @@ module Lazylead
 
     def passed(issue)
       return true if @envs.empty?
-      lines = issue["environment"].to_s + "\n" + issue.description
-      lines.split("\n")
-           .reject(&:blank?)
-           .map(&:strip)
-           .flat_map { |l| l.split(" ").map(&:strip) }
-           .select { |w| w.include?("http://") || w.include?("https://") }
-           .any? { |u| @envs.any? { |e| u.match? e } }
+      "#{issue['environment']}\n#{issue.description}".split("\n")
+                                                     .reject(&:blank?)
+                                                     .map(&:strip)
+                                                     .flat_map { |l| l.split.map(&:strip) }
+                                                     .select { |u| url?(u) }
+                                                     .any? { |u| match?(u) }
+    end
+
+    # Ensure that particular text contains web url
+    def url?(text)
+      text.include?("http://") || text.include?("https://")
+    end
+
+    # Ensure that particular url matches expected servers urls
+    def match?(url)
+      @envs.any? { |e| url.match? e }
     end
   end
 end

data/lib/lazylead/task/accuracy/stacktrace.rb

@@ -60,7 +60,7 @@ module Lazylead
       words = desc.gsub(/{(c|C)(o|O)(d|D)(e|E)/, " {code")
                   .gsub("}", "} ")
                   .gsub("Caused by:", "Caused_by:")
-                  .split(" ")
+                  .split
                   .map(&:strip)
                   .reject(&:blank?)
       pairs(words, "{code").map { |s| words[s.first..s.last].join("\n") }

data/lib/lazylead/task/accuracy/testcase.rb

@@ -38,10 +38,10 @@ module Lazylead
       return false if issue.description.nil?
       @tc = @ar = @er = -1
       issue.description.split("\n").reject(&:blank?).each_with_index do |l, i|
-        line = escape(l.downcase.gsub(/\s+/, ""))
-        detect_tc(line, i)
-        detect_ar(line, i)
-        detect_er(line, i)
+        line = escape l.downcase.gsub(/(\s+|\*|\+)/, "")
+        detect_tc line, i
+        detect_ar line, i
+        detect_er line, i
         break if with_tc_ar_er?
       end
       with_tc_ar_er?
@@ -65,19 +65,20 @@ module Lazylead
     # Detect index of line with test case
     def detect_tc(line, index)
       return unless @tc.negative?
-      @tc = index if eql?(line, %w[testcase: tc: teststeps: teststeps steps:])
+      @tc = index if eql? line,
+                          %w[testcase: tc: teststeps: teststeps steps: tcsteps: tc testcases steps]
     end
 
     # Detect index of line with actual result
     def detect_ar(line, index)
       return unless @ar.negative? && index > @tc
-      @ar = index if starts?(line, %w[ar: actualresult: ar= *ar*= *ar*:])
+      @ar = index if starts? line, %w[ar: actualresult: ar= [ar]]
     end
 
     # Detect index of line with expected result
     def detect_er(line, index)
       return unless @er.negative? && index > @tc
-      @er = index if starts?(line, %w[er: expectedresult: er= *er*= *er*:])
+      @er = index if starts? line, %w[er: expectedresult: er= [er]]
     end
 
     def starts?(line, text)

data/lib/lazylead/task/fix_version.rb

@@ -86,8 +86,10 @@ module Lazylead
         @issue.add_label("LL.IllegalChangeOfFixVersion") unless @silent
       end
 
-      def current
-        @issue.fields["fixVersions"].first["name"]
+      def to
+        versions = @issue.fields["fixVersions"]
+        return "" if versions.nil? || versions.empty?
+        versions.map { |x| x["name"] }.join(",")
       end
     end
   end

data/lib/lazylead/task/propagate_down.rb

@@ -106,7 +106,7 @@ module Lazylead
           v = a.last
           d[k] = expected[k] if v.nil? || v.blank?
           next if v.nil?
-          d[k] = v + "," + expected[k] unless v.to_s.include? expected[k]
+          d[k] = "#{v},#{expected[k]}" unless v.to_s.include? expected[k]
         end
       end
 

data/lib/lazylead/task/svn/diff.rb

@@ -22,8 +22,9 @@
 # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
-require "tmpdir"
+require "tempfile"
 require "nokogiri"
+require "backtrace"
 require "active_support/core_ext/hash/conversions"
 require_relative "../../salt"
 require_relative "../../opts"
@@ -48,26 +49,26 @@ module Lazylead
             "-r#{opts['since_rev']}:HEAD #{opts['svn_url']}"
           ]
           stdout = `#{cmd.join(" ")}`
-          send_email stdout, postman, opts unless stdout.blank?
+          send_email postman, opts.merge(stdout: stdout) unless stdout.blank?
         end
 
         # Send email with svn log as an attachment.
         # The attachment won't be stored locally and we'll be removed once
         #  mail sent.
-        def send_email(stdout, postman, opts)
+        def send_email(postman, opts)
           Dir.mktmpdir do |dir|
             name = "svn-log-#{Date.today.strftime('%d-%b-%Y')}.html"
             f = File.open(File.join(dir, name), "w")
-            f.write(
-              Email.new(
-                opts["template-attachment"],
-                opts.merge(stdout: stdout, version: Lazylead::VERSION)
-              ).render
-            )
-            postman.send opts.merge(stdout: stdout, attachments: [f.path])
+            begin
+              f.write opts.msg_body("template-attachment")
+              f.close
+              postman.send opts.merge(attachments: [f.path])
+            ensure
+              File.delete(f)
+            end
           rescue StandardError => e
-            @log.error "ll-010: Can't send an email for #{opts} based on "\
-                     "'#{stdout}'", e
+            @log.error "ll-010: Can't send an email for #{opts} due to " \
+                       "#{Backtrace.new(e)}'"
           end
         end
       end

data/lib/lazylead/task/svn/grep.rb

@@ -47,21 +47,28 @@ module Lazylead
 
         # Return all svn commits for particular date range in repo
         def svn_log(opts)
-          now = if opts.key? "now"
-                  DateTime.parse(opts["now"])
-                else
-                  DateTime.now
-                end
-          start = (now.to_time - opts["period"].to_i).to_datetime
           cmd = [
             "svn log --diff --no-auth-cache",
             "--username #{opts.decrypt('svn_user', 'svn_salt')}",
             "--password #{opts.decrypt('svn_password', 'svn_salt')}",
-            "-r {#{start}}:{#{now}} #{opts['svn_url']}"
+            "-r {#{from(opts)}}:{#{now(opts)}} #{opts['svn_url']}"
           ]
           stdout = `#{cmd.join(" ")}`
-          stdout.split("-" * 72).reject(&:blank?).reverse
-                .map { |e| Entry.new(e) }
+          stdout.split("-" * 72).reject(&:blank?).reverse.map { |e| Entry.new(e) }
+        end
+
+        # The start date & time for search range
+        def from(opts)
+          (now(opts).to_time - opts["period"].to_i).to_datetime
+        end
+
+        # The current date & time for search range
+        def now(opts)
+          if opts.key? "now"
+            DateTime.parse(opts["now"])
+          else
+            DateTime.now
+          end
         end
       end
     end
@@ -78,7 +85,7 @@ module Lazylead
     end
 
     def rev
-      header.first
+      header.first[1..]
     end
 
     def author
@@ -96,8 +103,8 @@ module Lazylead
     # The modified lines contains expected text
     def includes?(text)
       text = [text] unless text.respond_to? :each
-      lines[4..-1].select { |l| l.start_with? "+" }
-                  .any? { |l| text.any? { |t| l.include? t } }
+      lines[4..].select { |l| l.start_with? "+" }
+                .any? { |l| text.any? { |t| l.include? t } }
     end
 
     def lines
@@ -107,5 +114,26 @@ module Lazylead
     def header
       @header ||= lines.first.split(" | ").reject(&:blank?)
     end
+
+    # Detect SVN diff lines with particular text
+    def diff(text)
+      @diff ||= begin
+        files = affected(text).uniq
+        @commit.split("Index: ")
+               .select { |i| files.any? { |f| i.start_with? f } }
+               .map { |i| i.split "\n" }
+               .flatten
+      end
+    end
+
+    # Detect affected files with particular text
+    def affected(text)
+      occurrences = lines.each_index.select do |i|
+        lines[i].start_with?("+") && text.any? { |t| lines[i].include? t }
+      end
+      occurrences.map do |occ|
+        lines[2..occ].reverse.find { |l| l.start_with? "Index: " }[7..]
+      end
+    end
   end
 end

data/lib/lazylead/task/svn/touch.rb

@@ -50,11 +50,9 @@ module Lazylead
         def touch(files, opts)
           xpath = files.map { |f| "contains(text(),\"#{f}\")" }.join(" or ")
           svn_log(opts).xpath("//logentry[paths/path[#{xpath}]]")
-                       .map(&method(:to_entry))
+                       .map { |xml| to_entry(xml) }
                        .each do |e|
-            if e.paths.path.respond_to? :delete_if
-              e.paths.path.delete_if { |p| files.none? { |f| p.include? f } }
-            end
+            e.paths.path.delete_if { |p| files.none? { |f| p.include? f } } if e.paths.path.respond_to? :delete_if
           end
         end
 

data/lib/lazylead/version.rb

@@ -23,5 +23,5 @@
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
 module Lazylead
-  VERSION = "0.6.0"
+  VERSION = "0.7.2"
 end

data/lib/messages/illegal_fixversion_change.erb

@@ -92,7 +92,8 @@
   <tr>
     <th id="key">Key</th>
     <th id="priority">Priority</th>
-    <th id="version">Fix Version</th>
+    <th id="from">From</th>
+    <th id="to">To</th>
     <th id="when">When</th>
     <th id="who">Who</th>
     <th id="reporter">Reporter</th>
@@ -102,7 +103,12 @@
     <tr>
       <td><a href='<%= v.issue.url %>'><%= v.issue.key %></a></td>
       <td><%= v.issue.priority %></td>
-      <td><%= v.current %></td>
+      <td><%= v.last["items"]
+               .select { |h| h["field"] == "Fix Version" }
+               .map { |h| h["fromString"] }
+               .reject(&:blank?)
+               .join(",") %></td>
+      <td><%= v.to %></td>
       <td><%= DateTime.parse(v.last["created"])
                       .strftime('%d-%b-%Y %I:%M:%S %p') %></td>
       <td><span style='color: red'><%= v.last["author"]["displayName"] %></span>

data/lib/messages/only_ll.erb

@@ -0,0 +1,107 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+  <style> /* CSS styles taken from https://github.com/yegor256/tacit */
+  th {
+    font-weight: 600
+  }
+
+  table tr {
+    border-bottom-width: 2.16px
+  }
+
+  table tr th {
+    border-bottom-width: 2.16px
+  }
+
+  table tr td, table tr th {
+    overflow: hidden;
+    padding: 5.4px 3.6px;
+    line-height: 14px;
+  }
+
+  #summary {
+    text-align: left;
+  }
+
+  .auto {
+    min-width: auto;
+    white-space: nowrap;
+  }
+
+  a {
+    color: #275a90;
+    text-decoration: none
+  }
+
+  a:hover {
+    text-decoration: underline
+  }
+
+  * {
+    border: 0;
+    border-collapse: separate;
+    border-spacing: 0;
+    box-sizing: border-box;
+    margin: 0;
+    max-width: 100%;
+    padding: 0;
+    vertical-align: baseline;
+    font-family: system-ui, "Helvetica Neue", Helvetica, Arial, sans-serif;
+    font-size: 13px;
+    font-stretch: normal;
+    font-style: normal;
+    font-weight: 400;
+    line-height: 29.7px
+  }
+
+  html, body {
+    width: 100%
+  }
+
+  html {
+    height: 100%
+  }
+
+  body {
+    background: #fff;
+    color: #1a1919;
+    padding: 36px
+  }
+  </style>
+  <title>Only LL</title>
+</head>
+<body>
+<p>Hi,</p>
+<p>The LL accuracy labels are cleaned from the following tickets:</p>
+<table summary="table with tickets triage score">
+  <tr>
+    <th id="key">Key</th>
+    <th id="priority">Priority</th>
+    <th id="reporter">Reporter</th>
+    <th id="violators">Violators</th>
+    <th id="summary">Summary</th>
+    <th id="labels">Labels</th>
+  </tr>
+  <% tickets.each do |t| %>
+    <tr>
+      <td>
+        <div class="auto">
+          <a href="<%= t.issue.url %>"><%= t.issue.key %></a>
+        </div>
+      </td>
+      <td><%= t.issue.priority %></td>
+      <td>
+        <div class="auto"><%= t.issue.reporter.name %></div>
+      </td>
+      <td><%= t.violators.join(', ') %></td>
+      <td><%= t.issue.summary %></td>
+      <td><%= t.issue.labels.join(', ') %></td>
+    </tr>
+  <% end %>
+</table>
+<p>Posted by
+  <a href="https://github.com/dgroup/lazylead">lazylead v<%= version %></a>.
+</p>
+</body>
+</html>