lazylead 0.6.0 → 0.7.2

data/lib/lazylead/email.rb

@@ -25,26 +25,6 @@
 require "tilt"
 
 module Lazylead
-  # Email notifications utilities.
-  module Emailing
-    # Construct html document from template and binds.
-    def make_body(opts)
-      Email.new(
-        opts["template"],
-        opts.merge(version: Lazylead::VERSION)
-      ).render
-    end
-
-    # Split text with email addresses by ',' and trim all elements if needed.
-    def split(type, opts)
-      if opts[type].include? ","
-        opts[type].split(",").map(&:strip).reject(&:empty?)
-      else
-        [opts[type]]
-      end
-    end
-  end
-
   # An email regarding tickets based on file with markup.
   #
   # The 'tilt' gem was used as a template engine.

data/lib/lazylead/exchange.rb

@@ -39,8 +39,6 @@ module Lazylead
   # Copyright:: Copyright (c) 2019-2020 Yurii Dubinka
   # License:: MIT
   class Exchange
-    include Emailing
-
     def initialize(
       log = Log.new, salt = Salt.new("exchange_salt"), opts = ENV.to_h
     )
@@ -52,38 +50,28 @@ module Lazylead
     # Send an email.
     # :opts   :: the mail configuration like from, cc, subject, template.
     def send(opts)
-      to = opts["to"] || opts[:to]
-      to = [to] unless to.is_a? Array
-      if to.reject { |e| e.nil? || e.blank? }.empty?
-        @log.warn "Email can't be sent to '#{to}, more: '#{opts}'"
-        return
+      if opts.msg_to.empty?
+        @log.warn "ll-012: Email can't be sent to '#{opts.msg_to}," \
+                  " more: '#{opts}'"
+      else
+        msg = make_msg opts
+        cli.send_message msg
+        msg[:file_attachments].each(&:close) unless opts.msg_attachments.empty?
+        @log.debug "#{__FILE__} sent '#{opts['subject']}' to '#{opts.msg_to}'."
       end
-      msg = make_msg(to, opts)
-      msg.update(cc_recipients: opts["cc"]) if opts.key? "cc"
-      add_attachments(msg, opts)
-      cli.send_message msg
-      close_attachments msg
-      @log.debug "#{__FILE__} sent '#{opts['subject']}' to '#{to}'."
     end
 
-    def make_msg(to, opts)
-      {
+    def make_msg(opts)
+      msg = {
         subject: opts["subject"],
-        body: make_body(opts),
+        body: opts.msg_body,
         body_type: "HTML",
-        to_recipients: to
+        to_recipients: opts.msg_to
       }
-    end
-
-    def add_attachments(msg, opts)
-      return unless opts.key? "attachments"
-      files = split("attachments", opts).map { |f| File.open(f, "r") }
-      msg[:file_attachments] = files
-    end
-
-    def close_attachments(msg)
-      return if msg[:file_attachments].nil? || msg[:file_attachments].empty?
-      msg[:file_attachments].each(&:close)
+      files = opts.msg_attachments.map { |f| File.open(f, "r") }
+      msg[:file_attachments] = files unless files.empty?
+      msg[:cc_recipients] = opts["cc"] if opts.key? "cc"
+      msg
     end
 
     private

data/lib/lazylead/model.rb

@@ -68,9 +68,7 @@ module Lazylead
       opts.each_with_object({}) do |e, o|
         k = e[0]
         v = e[1]
-        if v.respond_to? :start_with?
-          v = ENV[v.slice(2, v.length - 3)] if v.start_with? "${"
-        end
+        v = ENV[v.slice(2, v.length - 3)] if v.respond_to?(:start_with?) && v.start_with?("${")
         o[k] = v
       end
     end
@@ -80,6 +78,13 @@ module Lazylead
       JSON.parse(properties).to_h
     end
 
+    def to_h?
+      return true unless to_hash.nil?
+      false
+    rescue StandardError => _e
+      false
+    end
+
     def to_s
       attributes.map { |k, v| "#{k}='#{v}'" }.join(", ")
     end
@@ -99,6 +104,7 @@ module Lazylead
         sys = system.connect
         opts = props
         opts = detect_cc(sys) if opts.key? "cc"
+        opts["system"] = second_sys if opts.numeric? "system"
         action.constantize.new.run(sys, postman, opts)
       end
 
@@ -130,12 +136,12 @@ module Lazylead
 
       def props
         @props ||= begin
-                     if team.nil?
-                       Opts.new(env(to_hash))
-                     else
-                       Opts.new(env(team.to_hash.merge(to_hash)))
-                     end
-                   end
+          if team.nil?
+            Opts.new(env(to_hash))
+          else
+            Opts.new(env(team.to_hash.merge(to_hash)))
+          end
+        end
       end
 
       def postman
@@ -146,17 +152,21 @@ module Lazylead
         end
       end
 
+      def second_sys
+        sys = System.find(props["system"])
+        raise "ll-014: No ticketing system found for #{self}" if sys.nil?
+        sys.connect
+      end
+
       private
 
       # Parse scheduling #type and #unit
       def trigger
         @trigger ||= begin
-                       trg = schedule.split(":")
-                       unless trg.size == 2
-                         raise "ll-007: illegal schedule format '#{schedule}'"
-                       end
-                       trg.map(&:strip).map(&:chomp)
-                     end
+          trg = schedule.split(":")
+          raise "ll-007: illegal schedule format '#{schedule}'" unless trg.size == 2
+          trg.map(&:strip).map(&:chomp)
+        end
       end
     end
 
@@ -172,6 +182,10 @@ module Lazylead
         @log = log
       end
 
+      # @todo #/DEV Remove the suppression during next refactoring (or enhancements)
+      #  for the method below
+      #
+      # rubocop:disable Metrics/AbcSize
       def exec
         Logging.mdc["tid"] = "task #{id}"
         @log.debug "'#{name}' is started."
@@ -182,12 +196,13 @@ module Lazylead
       rescue StandardError => e
         msg = <<~MSG
           ll-006: Task ##{id} #{e} (#{e.class}) at #{self}
-          #{Backtrace.new(e) if ARGV.include? '--trace'}"
+          #{Backtrace.new(e) if ARGV.include? '--trace'}
         MSG
         @log.error msg
       ensure
         Logging.mdc["tid"] = ""
       end
+      # rubocop:enable Metrics/AbcSize
     end
 
     # Ticketing systems to monitor.

data/lib/lazylead/opts.rb

@@ -34,7 +34,8 @@ module Lazylead
   # License:: MIT
   class Opts
     extend Forwardable
-    def_delegators :@origin, :[], :[]=, :to_s, :key?, :fetch, :merge, :except
+    def_delegators :@origin, :[], :[]=, :to_s, :key?, :fetch, :except, :each,
+                   :each_pair, :sort_by
 
     def initialize(origin = {})
       @origin = origin
@@ -43,7 +44,13 @@ module Lazylead
     # Split text value by delimiter, trim all spaces and reject blank items
     def slice(key, delim)
       return [] unless to_h.key? key
-      to_h[key].split(delim).map(&:chomp).map(&:strip).reject(&:blank?)
+      trim to_h[key].split(delim)
+    end
+
+    # Trim all spaces and reject blank items in array
+    def trim(arr)
+      return [] if arr.nil?
+      arr.map(&:chomp).map(&:strip).reject(&:blank?)
     end
 
     def blank?(key)
@@ -77,5 +84,60 @@ module Lazylead
       return Salt.new(sid).decrypt(text) if ENV.key? sid
       text
     end
+
+    def merge(args)
+      return self unless args.is_a? Hash
+      Opts.new @origin.merge(args)
+    end
+
+    # Construct html document from template and binds.
+    def msg_body(template = "template")
+      Email.new(
+        to_h[template],
+        to_h.merge(version: Lazylead::VERSION)
+      ).render
+    end
+
+    def msg_to(delim = ",")
+      sliced delim, :to, "to"
+    end
+
+    def msg_cc(delim = ",")
+      sliced delim, :cc, "cc"
+    end
+
+    def msg_from(delim = ",")
+      sliced delim, :from, "from"
+    end
+
+    def msg_attachments(delim = ",")
+      sliced(delim, :attachments, "attachments").select { |f| File.file? f }
+    end
+
+    #
+    # Find the option by key and split by delimiter
+    #   Opts.new("key" => "a,b").sliced(",", "key")     => [a, b]
+    #   Opts.new(key: "a,b").sliced(",", :key)          => [a, b]
+    #   Opts.new(key: "a,b").sliced(",", "key", :key)   => [a, b]
+    #   Opts.new(key: "").sliced ",", :key)             => []
+    #
+    def sliced(delim, *keys)
+      return [] if keys.empty?
+      key = keys.detect { |k| key? k }
+      val = to_h[key]
+      return [] if val.nil? || val.blank?
+      return val if val.is_a? Array
+      return [val] unless val.include? delim
+      slice key, delim
+    end
+
+    # Ensure that particular key from options is a positive numer
+    #   Opts.new("key" => "1").numeric? "key"   => true
+    #   Opts.new("key" => "0").numeric? "key"   => false
+    #   Opts.new("key" => ".").numeric? "key"   => false
+    #   Opts.new("key" => "nil").numeric? "key" => false
+    def numeric?(key)
+      to_h[key].to_i.positive?
+    end
   end
 end

data/lib/lazylead/postman.rb

@@ -44,8 +44,6 @@ module Lazylead
   # Copyright:: Copyright (c) 2019-2020 Yurii Dubinka
   # License:: MIT
   class Postman
-    include Emailing
-
     def initialize(log = Log.new)
       @log = log
     end
@@ -53,32 +51,29 @@ module Lazylead
     # Send an email.
     # :opts   :: the mail configuration like to, from, cc, subject, template.
     def send(opts)
-      mail = make_email(opts)
-      mail.deliver
-      @log.debug "#{__FILE__} sent '#{mail.subject}' to '#{mail.to}'."
+      if opts.msg_to.empty?
+        @log.warn "ll-013: Email can't be sent to '#{opts.msg_to}," \
+                  " more: '#{opts}'"
+      else
+        mail = make_email(opts)
+        mail.deliver
+        @log.debug "#{__FILE__} sent '#{mail.subject}' to '#{mail.to}'."
+      end
     end
 
     # Construct an email based on input arguments
     def make_email(opts)
       mail = Mail.new
-      mail.to opts[:to] || opts["to"]
-      mail.from opts["from"]
-      mail.cc opts["cc"] if opts.key? "cc"
+      mail.to opts.msg_to
+      mail.from opts.msg_from
+      mail.cc opts.msg_cc if opts.key? "cc"
       mail.subject opts["subject"]
-      html = make_body(opts)
       mail.html_part do
         content_type "text/html; charset=UTF-8"
-        body html
+        body opts.msg_body
       end
-      add_attachments mail, opts
+      opts.msg_attachments.each { |f| mail.add_file f }
       mail
     end
-
-    def add_attachments(mail, opts)
-      return unless opts.key?("attachments") || opts.key?(:attachments)
-      attach = opts["attachments"] || opts[:attachments]
-      return if attach.nil?
-      attach.select { |a| File.file? a }.each { |a| mail.add_file a }
-    end
   end
 end

data/lib/lazylead/salt.rb

@@ -39,6 +39,7 @@ module Lazylead
   #
   class Salt
     attr_reader :id
+
     #
     # Each salt should be defined as a environment variable with id, like
     #  salt1=E1F53135E559C253

data/lib/lazylead/system/jira.rb

@@ -177,7 +177,7 @@ module Lazylead
     end
 
     def url
-      @issue.attrs["self"].split("/rest/api/").first + "/browse/" + key
+      "#{@issue.attrs['self'].split('/rest/api/').first}/browse/#{key}"
     end
 
     def duedate
@@ -257,13 +257,20 @@ module Lazylead
       lbl = [] if lbl.nil?
       lbl << label
       lbl += more if more.size.positive?
-      save!("fields" => { "labels" => lbl.uniq })
+      labels! lbl
     end
 
+    # Get the labels for a particular issue
     def labels
       fields["labels"]
     end
 
+    # Update the labels for a particular issue
+    def labels!(lbl)
+      return if lbl.nil? || lbl.empty?
+      save!("fields" => { "labels" => lbl.uniq })
+    end
+
     def save!(opts)
       @issue.save(opts)
     end

data/lib/lazylead/task/accuracy/accuracy.rb

@@ -70,10 +70,8 @@ module Lazylead
     # Estimate the ticket score and accuracy.
     # Accuracy is a percentage between current score and maximum possible value.
     def evaluate(digits = 2)
-      @total = @rules.map(&:score).sum
-      @score = @rules.select { |r| r.passed(@issue) }
-                     .map(&:score)
-                     .sum
+      @total = @rules.sum(&:score)
+      @score = @rules.select { |r| r.passed(@issue) }.sum(&:score)
       @accuracy = (score / @total * 100).round(digits)
     end
 
@@ -81,7 +79,7 @@ module Lazylead
     def post
       return if @opts.key? "silent"
       @issue.post comment
-      @issue.add_label "LL.accuracy", "#{grade(@accuracy)}%"
+      @issue.add_label "LL.accuracy", "#{grade(@accuracy)}%", "#{@accuracy}%"
     end
 
     # The jira comment in markdown format
@@ -114,9 +112,7 @@ module Lazylead
     end
 
     def color
-      if colors.nil? || !defined?(@score) || !@score.is_a?(Numeric)
-        return "#061306"
-      end
+      return "#061306" if colors.nil? || !defined?(@score) || !@score.is_a?(Numeric)
       colors.reverse_each do |color|
         return color.last if @accuracy >= color.first
       end
@@ -125,12 +121,12 @@ module Lazylead
 
     def colors
       @colors ||= begin
-                    JSON.parse(@opts["colors"])
-                        .to_h
-                        .to_a
-                        .each { |e| e[0] = e[0].to_i }
-                        .sort_by { |e| e[0] }
-                  end
+        JSON.parse(@opts["colors"])
+            .to_h
+            .to_a
+            .each { |e| e[0] = e[0].to_i }
+            .sort_by { |e| e[0] }
+      end
     end
 
     # Calculate grade for accuracy

data/lib/lazylead/task/accuracy/attachment.rb

@@ -27,17 +27,13 @@ require_relative "requirement"
 module Lazylead
   # Check that ticket has an attachment.
   class Attachment < Lazylead::Requirement
-    def initialize(desc, score, field)
-      super(desc, score, field)
-    end
-
     def passed(issue)
-      issue.attachments.any?(&method(:matching))
+      issue.attachments.any? { |a| matches?(a) }
     end
 
     # Check a single attachment from ticket.
     # Potential extension point for custom verification logic.
-    def matching(attachment)
+    def matches?(attachment)
       !attachment.nil?
     end
   end

data/lib/lazylead/task/accuracy/logs.rb

@@ -27,16 +27,21 @@ require_relative "attachment"
 module Lazylead
   # Check that ticket has log file(s) in attachment.
   class Logs < Lazylead::Attachment
-    def initialize
+    def initialize(files = %w[log.zip logs.zip log.gz logs.gz log.tar.gz
+                              logs.tar.gz log.7z logs.7z log.tar logs.tar])
       super("Log files", 2, "Attachments")
+      @files = files
     end
 
     # Ensure that ticket has a '*.log' file more '5KB'
-    def matching(attachment)
+    def matches?(attachment)
       name = attachment.attrs["filename"].downcase
       return false unless attachment.attrs["size"].to_i > 5120
-      return true if File.extname(name).start_with?(".log", ".txt")
-      %w[.log.zip .log.gz .log.tar.gz].any? { |l| name.end_with? l }
+      return true if File.extname(name).start_with? ".log", ".txt", ".out"
+      return true if @files.any? { |l| name.end_with? l }
+      %w[.zip .7z .gz tar.gz].any? do |l|
+        name.end_with?(l) && name.split(/(?:[^a-zA-Z0-9](?<![^\x00-\x7F]))+/).include?("logs")
+      end
     end
   end
 end