kumi 0.0.21 → 0.0.23

data/lib/kumi/core/analyzer/passes/scope_resolution_pass.rb

@@ -1,349 +0,0 @@
-# frozen_string_literal: true
-
-module Kumi
-  module Core
-    module Analyzer
-      module Passes
-        # Plans per-declaration execution scope and join/lift needs.
-        # Determines the dimensional scope (array nesting level) for each declaration
-        # based on vectorization metadata and input paths.
-        #
-        # DEPENDENCIES: :declarations, :input_metadata, :broadcasts
-        # PRODUCES: :scope_plans, :decl_shapes
-        class ScopeResolutionPass < PassBase
-          include Kumi::Core::Analyzer::Plans
-
-          def run(_errors)
-            declarations = get_state(:declarations, required: true)
-            input_metadata = get_state(:input_metadata, required: true)
-            broadcasts = get_state(:broadcasts) || {}
-            dependencies = get_state(:dependencies) || {}
-
-            puts "Available dependencies: #{dependencies.keys.inspect}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-
-            scope_plans = {}
-            decl_shapes = {}
-
-            initial_scopes = {}
-            declarations.each do |name, decl|
-              debug_output(name, decl) if ENV["DEBUG_SCOPE_RESOLUTION"]
-              target_scope = infer_target_scope(name, decl, broadcasts, input_metadata)
-              result_kind = determine_result_kind(name, target_scope, broadcasts)
-              initial_scopes[name] = target_scope
-              debug_result(target_scope, result_kind) if ENV["DEBUG_SCOPE_RESOLUTION"]
-            end
-
-            final_scopes = propagate_scope_constraints(initial_scopes, declarations, input_metadata)
-            final_scopes.each do |name, target_scope|
-              result_kind = determine_result_kind(name, target_scope, broadcasts)
-              plan = build_scope_plan(target_scope)
-              scope_plans[name] = plan
-              decl_shapes[name] = { scope: target_scope, result: result_kind }.freeze
-            end
-
-            # Return new state with scope information
-            state.with(:scope_plans, scope_plans.freeze)
-                 .with(:decl_shapes, decl_shapes.freeze)
-          end
-
-          private
-
-          def propagate_scope_constraints(initial_scopes, declarations, input_metadata)
-            scopes = initial_scopes.dup
-            puts "\n=== Propagating scope constraints ===" if ENV["DEBUG_SCOPE_RESOLUTION"]
-
-            declarations.each do |name, decl|
-              case decl.expression
-              when Kumi::Syntax::ArrayExpression
-                propagate_from_array_expression(name, decl.expression, scopes, declarations, input_metadata)
-              when Kumi::Syntax::CascadeExpression
-                propagate_from_cascade_expression(name, decl.expression, scopes, declarations, input_metadata)
-              end
-            end
-
-            puts "Final propagated scopes: #{scopes.inspect}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-            scopes
-          end
-
-          def propagate_from_array_expression(name, array_expr, scopes, declarations, input_metadata)
-            puts "Analyzing array expression in #{name}: #{array_expr.elements.map(&:class)}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-
-            anchor_scope = nil
-            declaration_refs = []
-
-            array_expr.elements.each do |element|
-              case element
-              when Kumi::Syntax::InputElementReference
-                path_scope = dims_from_path(element.path, input_metadata)
-                puts "Found input anchor: #{element.path} -> scope #{path_scope}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-                anchor_scope = path_scope if path_scope.length > (anchor_scope&.length || 0)
-              when Kumi::Syntax::DeclarationReference
-                declaration_refs << element.name
-              end
-            end
-
-            return unless anchor_scope && !anchor_scope.empty?
-
-            declaration_refs.each do |ref_name|
-              current_scope = scopes[ref_name] || []
-              next unless anchor_scope.length > current_scope.length
-
-              puts "Propagating scope #{anchor_scope} to #{ref_name} (was #{current_scope})" if ENV["DEBUG_SCOPE_RESOLUTION"]
-              scopes[ref_name] = anchor_scope
-              propagate_to_dependencies(ref_name, anchor_scope, scopes, declarations, input_metadata)
-            end
-          end
-
-          def propagate_from_cascade_expression(name, cascade_expr, scopes, declarations, input_metadata)
-            puts "Analyzing cascade expression in #{name}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-
-            # Cascade should propagate its own scope to condition dependencies
-            cascade_scope = scopes[name] || []
-            return if cascade_scope.empty?
-
-            puts "Propagating cascade scope #{cascade_scope} to condition dependencies" if ENV["DEBUG_SCOPE_RESOLUTION"]
-
-            cascade_expr.cases.each do |case_expr|
-              find_declaration_references(case_expr.condition).each do |ref_name|
-                current_scope = scopes[ref_name] || []
-                next unless cascade_scope.length > current_scope.length
-
-                if ENV["DEBUG_SCOPE_RESOLUTION"]
-                  puts "Propagating scope #{cascade_scope} to cascade condition #{ref_name} (was #{current_scope})"
-                end
-                scopes[ref_name] = cascade_scope
-                propagate_to_dependencies(ref_name, cascade_scope, scopes, declarations, input_metadata)
-              end
-            end
-          end
-
-          def propagate_to_dependencies(decl_name, required_scope, scopes, declarations, input_metadata)
-            return unless declarations[decl_name]
-
-            decl = declarations[decl_name]
-            puts "Propagating #{required_scope} into dependencies of #{decl_name}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-
-            case decl.expression
-            when Kumi::Syntax::CascadeExpression
-              decl.expression.cases.each do |case_expr|
-                find_declaration_references(case_expr.condition).each do |ref_name|
-                  current_scope = scopes[ref_name] || []
-                  next unless required_scope.length > current_scope.length
-
-                  puts "Propagating scope #{required_scope} to trait dependency #{ref_name}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-                  scopes[ref_name] = required_scope
-                  update_reduction_scope_if_needed(ref_name, required_scope, declarations, input_metadata)
-                end
-              end
-            end
-          end
-
-          def find_declaration_references(expr)
-            refs = []
-            case expr
-            when Kumi::Syntax::DeclarationReference
-              refs << expr.name
-            when Kumi::Syntax::CallExpression
-              expr.args.each { |arg| refs.concat(find_declaration_references(arg)) }
-            when Kumi::Syntax::ArrayExpression
-              expr.elements.each { |elem| refs.concat(find_declaration_references(elem)) }
-            end
-            refs
-          end
-
-          def update_reduction_scope_if_needed(decl_name, required_scope, declarations, _input_metadata)
-            decl = declarations[decl_name]
-            return unless decl
-
-            puts "Checking if #{decl_name} needs reduction scope update for #{required_scope}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-          end
-
-          def debug_output(name, decl)
-            puts "\n=== Resolving scope for #{name} ==="
-            puts "Declaration: #{decl.inspect}"
-          end
-
-          def debug_result(target_scope, result_kind)
-            puts "Target scope: #{target_scope.inspect}"
-            puts "Result kind: #{result_kind.inspect}"
-          end
-
-          def build_scope_plan(target_scope)
-            Scope.new(
-              scope: target_scope,
-              lifts: [], # Will be computed during IR lowering per call-site
-              join_hint: nil, # Will be set to :zip when multiple vectorized args exist
-              arg_shapes: {} # Optional: filled during lowering
-            )
-          end
-
-          def determine_result_kind(name, target_scope, broadcasts)
-            return :scalar if broadcasts.dig(:reduction_operations, name)
-            return :scalar if target_scope.empty?
-
-            { array: :dense }
-          end
-
-          # Derive scope from vectorization metadata or from deepest input path
-          def infer_target_scope(name, decl, broadcasts, input_metadata)
-            # First check vectorized operations
-            vec = broadcasts.dig(:vectorized_operations, name)
-            if vec
-              puts "Vectorization info: #{vec.inspect}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-
-              case vec[:source]
-              when :nested_array_access, :array_field_access
-                path = vec[:path] || []
-                return dims_from_path(path, input_metadata)
-              when :cascade_with_vectorized_conditions_or_results,
-                   :cascade_condition_with_vectorized_trait
-                # Fallback: derive from first input path seen in expression
-                path = find_first_input_path(decl.expression) || []
-                return dims_from_path(path, input_metadata)
-              else
-                return []
-              end
-            end
-
-            # Check if this is a reduction operation that should preserve some scope
-            red = broadcasts.dig(:reduction_operations, name)
-            if red
-              puts "Reduction info: #{red.inspect}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-
-              # Infer the natural scope for this reduction
-              # For expressions like fn(:any?, input.players.score_matrices.session.points > 1000)
-              # we want to reduce over session dimension but preserve the players dimension
-              scope = infer_reduction_target_scope(decl.expression, input_metadata)
-              puts "Inferred reduction target scope: #{scope.inspect}" if ENV["DEBUG_SCOPE_RESOLUTION"]
-              return scope
-            end
-
-            []
-          end
-
-          def infer_reduction_target_scope(expr, input_metadata)
-            # For reduction expressions, we need to analyze the argument to the reducer
-            # and determine which dimensions should be preserved vs reduced
-            case expr
-            when Kumi::Syntax::CallExpression
-              if reducer_function?(expr.fn_name)
-                # Find the argument being reduced
-                arg = expr.args.first
-                if arg
-                  # Get the full scope from the argument
-                  full_scope = infer_scope_from_argument(arg, input_metadata)
-
-                  # For array reductions, we typically want to preserve
-                  # the outermost dimension (e.g., keep :players, reduce :score_matrices/:session)
-                  if full_scope.length > 1
-                    return full_scope[0..0] # Keep only the first dimension
-                  end
-                end
-              else
-                # Recursively check if any argument contains a reducer
-                # This handles cases like (fn(:sum, ...) >= 3500)
-                expr.args.each do |arg|
-                  nested_scope = infer_reduction_target_scope(arg, input_metadata)
-                  return nested_scope unless nested_scope.empty?
-                end
-              end
-            end
-            []
-          end
-
-          def reducer_function?(fn_name)
-            entry = Kumi::Registry.entry(fn_name)
-            entry&.reducer == true
-          end
-
-          def infer_scope_from_argument(arg, input_metadata)
-            case arg
-            when Kumi::Syntax::InputElementReference
-              dims_from_path(arg.path, input_metadata)
-            when Kumi::Syntax::InputReference
-              dims_from_path([arg.name], input_metadata)
-            when Kumi::Syntax::CallExpression
-              # For expressions like (input.players.score_matrices.session.points > 1000),
-              # we need to find the deepest input path
-              deepest_path = find_deepest_input_path(arg)
-              deepest_path ? dims_from_path(deepest_path, input_metadata) : []
-            else
-              []
-            end
-          end
-
-          def find_deepest_input_path(expr)
-            paths = collect_input_paths(expr)
-            paths.max_by(&:length)
-          end
-
-          def collect_input_paths(expr)
-            paths = []
-            case expr
-            when Kumi::Syntax::InputElementReference
-              paths << expr.path
-            when Kumi::Syntax::InputReference
-              paths << [expr.name]
-            when Kumi::Syntax::CallExpression
-              expr.args.each { |arg| paths.concat(collect_input_paths(arg)) }
-            when Kumi::Syntax::ArrayExpression
-              expr.elements.each { |elem| paths.concat(collect_input_paths(elem)) }
-            end
-            paths
-          end
-
-          def find_first_input_path(expr)
-            return nil unless expr
-
-            # Handle InputElementReference directly
-            return expr.path if expr.is_a?(Kumi::Syntax::InputElementReference)
-
-            # Handle InputReference (convert to path array)
-            return [expr.name] if expr.is_a?(Kumi::Syntax::InputReference)
-
-            # Recursively search in CallExpression arguments
-            if expr.is_a?(Kumi::Syntax::CallExpression) && expr.args
-              expr.args.each do |arg|
-                path = find_first_input_path(arg)
-                return path if path
-              end
-            end
-
-            # Search in CascadeExpression cases
-            if expr.is_a?(Kumi::Syntax::CascadeExpression) && expr.cases
-              expr.cases.each do |case_item|
-                path = find_first_input_path(case_item.condition)
-                return path if path
-
-                path = find_first_input_path(case_item.result)
-                return path if path
-              end
-            end
-
-            # Search in expression field if present
-            return find_first_input_path(expr.expression) if expr.respond_to?(:expression)
-
-            nil
-          end
-
-          # Map an input path like [:regions, :offices, :salary] to container dims [:regions, :offices]
-          def dims_from_path(path, input_metadata)
-            dims = []
-            meta = input_metadata
-
-            path.each do |seg|
-              field = meta[seg] || meta[seg.to_sym] || meta[seg.to_s]
-              break unless field
-
-              dims << seg.to_sym if field[:type] == :array
-
-              meta = field[:children] || {}
-            end
-
-            dims
-          end
-        end
-      end
-    end
-  end
-end

data/lib/kumi/core/analyzer/passes/type_checker.rb

@@ -1,179 +0,0 @@
-# frozen_string_literal: true
-
-module Kumi
-  module Core
-    module Analyzer
-      module Passes
-        # RESPONSIBILITY: Validate function call arity and argument types against FunctionRegistry
-        # DEPENDENCIES: :inferred_types from TypeInferencerPass
-        # PRODUCES: :functions_required - Set of function names used in the schema
-        # INTERFACE: new(schema, state).run(errors)
-        class TypeChecker < VisitorPass
-          def run(errors)
-            functions_required = Set.new
-            @registry = state[:registry]
-
-            visit_nodes_of_type(Kumi::Syntax::CallExpression, errors: errors) do |node, _decl, errs|
-              validate_function_call(node, errs)
-              functions_required.add(node.fn_name)
-            end
-
-            state.with(:functions_required, functions_required)
-          end
-
-          private
-
-          def validate_function_call(node, errors)
-            signature = get_function_signature(node, errors)
-            return unless signature
-
-            validate_arity(node, signature, errors)
-            validate_argument_types(node, signature, errors)
-          end
-
-          def get_function_signature(node, errors)
-            func = begin
-              @registry.function(node.fn_name)
-            rescue StandardError
-              nil
-            end
-            if func
-              return {
-                arity: func.params.size,
-                param_types: func.params.map { |p| p["type"] ? Kumi::Core::Types.parse(p["type"]) : nil }
-              }
-            end
-
-            Kumi::Registry.signature(node.fn_name)
-          rescue Kumi::Errors::UnknownFunction
-            # Use old format for backward compatibility, but node.loc provides better location
-            report_error(errors, "unsupported operator `#{node.fn_name}`", location: node.loc, type: :type)
-            nil
-          end
-
-          def validate_arity(node, signature, errors)
-            expected_arity = signature[:arity]
-            actual_arity = node.args.size
-
-            return if expected_arity.negative? || expected_arity == actual_arity
-
-            report_error(errors, "operator `#{node.fn_name}` expects #{expected_arity} args, got #{actual_arity}", location: node.loc,
-                                                                                                                   type: :type)
-          end
-
-          def validate_argument_types(node, signature, errors)
-            types = signature[:param_types]
-            return if types.nil? || (signature[:arity].negative? && node.args.empty?)
-
-            # Skip type checking for vectorized operations
-            broadcast_meta = get_state(:broadcasts, required: false)
-            return if broadcast_meta && is_part_of_vectorized_operation?(node, broadcast_meta)
-
-            node.args.each_with_index do |arg, i|
-              validate_argument_type(arg, i, types[i], node.fn_name, errors)
-            end
-          end
-
-          def is_part_of_vectorized_operation?(node, broadcast_meta)
-            # Check if this node is part of a vectorized or reduction operation
-            # This is a simplified check - in a real implementation we'd need to track context
-            node.args.any? do |arg|
-              case arg
-              when Kumi::Syntax::DeclarationReference
-                broadcast_meta[:vectorized_operations]&.key?(arg.name) ||
-                  broadcast_meta[:reduction_operations]&.key?(arg.name)
-              when Kumi::Syntax::InputElementReference
-                broadcast_meta[:array_fields]&.key?(arg.path.first)
-              else
-                false
-              end
-            end
-          end
-
-          def validate_argument_type(arg, index, expected_type, fn_name, errors)
-            return if expected_type.nil? || expected_type == Kumi::Core::Types::ANY
-
-            # Get the inferred type for this argument
-            actual_type = get_expression_type(arg)
-            return if Kumi::Core::Types.compatible?(actual_type, expected_type)
-
-            # Generate descriptive error message
-            source_desc = describe_expression_type(arg, actual_type)
-            report_error(errors, "argument #{index + 1} of `fn(:#{fn_name})` expects #{expected_type}, " \
-                                 "got #{source_desc}", location: arg.loc, type: :type)
-          end
-
-          def get_expression_type(expr)
-            case expr
-            when Kumi::Syntax::Literal
-              # Inferred type from literal value
-              Kumi::Core::Types.infer_from_value(expr.value)
-
-            when Kumi::Syntax::InputReference
-              # Declared type from input block (user-specified)
-              get_declared_field_type(expr.name)
-
-            when Kumi::Syntax::DeclarationReference
-              # Inferred type from type inference results
-              get_inferred_declaration_type(expr.name)
-
-            else
-              # For complex expressions, we should have type inference results
-              # This is a simplified approach - in reality we'd need to track types for all expressions
-              Kumi::Core::Types::ANY
-            end
-          end
-
-          def get_declared_field_type(field_name)
-            # Get explicitly declared type from input metadata
-            input_meta = get_state(:input_metadata, required: false) || {}
-            field_meta = input_meta[field_name]
-            field_meta&.dig(:type) || Kumi::Core::Types::ANY
-          end
-
-          def get_inferred_declaration_type(decl_name)
-            # Get inferred type from type inference results
-            decl_types = get_state(:inferred_types, required: true)
-            decl_types[decl_name] || Kumi::Core::Types::ANY
-          end
-
-          def describe_expression_type(expr, type)
-            case expr
-            when Kumi::Syntax::Literal
-              "`#{expr.value}` of type #{type} (literal value)"
-
-            when Kumi::Syntax::InputReference
-              input_meta = get_state(:input_metadata, required: false) || {}
-              field_meta = input_meta[expr.name]
-
-              if field_meta&.dig(:type)
-                # Explicitly declared type
-                domain_desc = field_meta[:domain] ? " (domain: #{field_meta[:domain]})" : ""
-                "input field `#{expr.name}` of declared type #{type}#{domain_desc}"
-              else
-                # Undeclared field
-                "undeclared input field `#{expr.name}` (inferred as #{type})"
-              end
-
-            when Kumi::Syntax::DeclarationReference
-              # This type was inferred from the declaration's expression
-              "reference to declaration `#{expr.name}` of inferred type #{type}"
-
-            when Kumi::Syntax::CallExpression
-              "result of function `#{expr.fn_name}` returning #{type}"
-
-            when Kumi::Syntax::ArrayExpression
-              "list expression of type #{type}"
-
-            when Kumi::Syntax::CascadeExpression
-              "cascade expression of type #{type}"
-
-            else
-              "expression of type #{type}"
-            end
-          end
-        end
-      end
-    end
-  end
-end