kt-paperclip 6.2.0

data/spec/paperclip/io_adapters/stringio_adapter_spec.rb

@@ -0,0 +1,64 @@
+require "spec_helper"
+
+describe Paperclip::StringioAdapter do
+  context "a new instance" do
+    before do
+      @contents = "abc123"
+      @stringio = StringIO.new(@contents)
+      @subject = Paperclip.io_adapters.for(@stringio, hash_digest: Digest::MD5)
+    end
+
+    it "returns a file name" do
+      assert_equal "data", @subject.original_filename
+    end
+
+    it "returns a content type" do
+      assert_equal "text/plain", @subject.content_type
+    end
+
+    it "returns the size of the data" do
+      assert_equal 6, @subject.size
+    end
+
+    it "returns the length of the data" do
+      assert_equal 6, @subject.length
+    end
+
+    it "generates an MD5 hash of the contents" do
+      assert_equal Digest::MD5.hexdigest(@contents), @subject.fingerprint
+    end
+
+    it "generates correct fingerprint after read" do
+      fingerprint = Digest::MD5.hexdigest(@subject.read)
+      assert_equal fingerprint, @subject.fingerprint
+    end
+
+    it "generates same fingerprint" do
+      assert_equal @subject.fingerprint, @subject.fingerprint
+    end
+
+    it "returns the data contained in the StringIO" do
+      assert_equal "abc123", @subject.read
+    end
+
+    it "accepts a content_type" do
+      @subject.content_type = "image/png"
+      assert_equal "image/png", @subject.content_type
+    end
+
+    it "accepts an original_filename" do
+      @subject.original_filename = "image.png"
+      assert_equal "image.png", @subject.original_filename
+    end
+
+    it "does not generate filenames that include restricted characters" do
+      @subject.original_filename = "image:restricted.png"
+      assert_equal "image_restricted.png", @subject.original_filename
+    end
+
+    it "does not generate paths that include restricted characters" do
+      @subject.original_filename = "image:restricted.png"
+      expect(@subject.path).to_not match(/:/)
+    end
+  end
+end

data/spec/paperclip/io_adapters/uploaded_file_adapter_spec.rb

@@ -0,0 +1,146 @@
+require "spec_helper"
+
+describe Paperclip::UploadedFileAdapter do
+  context "a new instance" do
+    context "with UploadedFile responding to #tempfile" do
+      before do
+        Paperclip::UploadedFileAdapter.content_type_detector = nil
+
+        class UploadedFile < OpenStruct; end
+        tempfile = File.new(fixture_file("5k.png"))
+        tempfile.binmode
+
+        @file = UploadedFile.new(
+          original_filename: "5k.png",
+          content_type: "image/x-png-by-browser\r",
+          head: "",
+          tempfile: tempfile,
+          path: tempfile.path
+        )
+        @subject = Paperclip.io_adapters.for(@file, hash_digest: Digest::MD5)
+      end
+
+      it "gets the right filename" do
+        assert_equal "5k.png", @subject.original_filename
+      end
+
+      it "forces binmode on tempfile" do
+        assert @subject.instance_variable_get("@tempfile").binmode?
+      end
+
+      it "gets the content type" do
+        assert_equal "image/png", @subject.content_type
+      end
+
+      it "gets the file's size" do
+        assert_equal 4456, @subject.size
+      end
+
+      it "returns false for a call to nil?" do
+        assert !@subject.nil?
+      end
+
+      it "generates a MD5 hash of the contents" do
+        expected = Digest::MD5.file(@file.tempfile.path).to_s
+        assert_equal expected, @subject.fingerprint
+      end
+
+      it "reads the contents of the file" do
+        expected = @file.tempfile.read
+        assert !expected.empty?
+        assert_equal expected, @subject.read
+      end
+    end
+
+    context "with UploadedFile that has restricted characters" do
+      before do
+        Paperclip::UploadedFileAdapter.content_type_detector = nil
+
+        class UploadedFile < OpenStruct; end
+        @file = UploadedFile.new(
+          original_filename: "image:restricted.gif",
+          content_type: "image/x-png-by-browser",
+          head: "",
+          path: fixture_file("5k.png")
+        )
+        @subject = Paperclip.io_adapters.for(@file, hash_digest: Digest::MD5)
+      end
+
+      it "does not generate paths that include restricted characters" do
+        expect(@subject.path).to_not match(/:/)
+      end
+
+      it "does not generate filenames that include restricted characters" do
+        assert_equal "image_restricted.gif", @subject.original_filename
+      end
+    end
+
+    context "with UploadFile responding to #path" do
+      before do
+        Paperclip::UploadedFileAdapter.content_type_detector = nil
+
+        class UploadedFile < OpenStruct; end
+        @file = UploadedFile.new(
+          original_filename: "5k.png",
+          content_type: "image/x-png-by-browser",
+          head: "",
+          path: fixture_file("5k.png")
+        )
+        @subject = Paperclip.io_adapters.for(@file, hash_digest: Digest::MD5)
+      end
+
+      it "gets the right filename" do
+        assert_equal "5k.png", @subject.original_filename
+      end
+
+      it "forces binmode on tempfile" do
+        assert @subject.instance_variable_get("@tempfile").binmode?
+      end
+
+      it "gets the content type" do
+        assert_equal "image/png", @subject.content_type
+      end
+
+      it "gets the file's size" do
+        assert_equal 4456, @subject.size
+      end
+
+      it "returns false for a call to nil?" do
+        assert !@subject.nil?
+      end
+
+      it "generates a MD5 hash of the contents" do
+        expected = Digest::MD5.file(@file.path).to_s
+        assert_equal expected, @subject.fingerprint
+      end
+
+      it "reads the contents of the file" do
+        expected_file = File.new(@file.path)
+        expected_file.binmode
+        expected = expected_file.read
+        assert !expected.empty?
+        assert_equal expected, @subject.read
+      end
+
+      context "don't trust client-given MIME type" do
+        before do
+          Paperclip::UploadedFileAdapter.content_type_detector =
+            Paperclip::FileCommandContentTypeDetector
+
+          class UploadedFile < OpenStruct; end
+          @file = UploadedFile.new(
+            original_filename: "5k.png",
+            content_type: "image/x-png-by-browser",
+            head: "",
+            path: fixture_file("5k.png")
+          )
+          @subject = Paperclip.io_adapters.for(@file)
+        end
+
+        it "gets the content type" do
+          assert_equal "image/png", @subject.content_type
+        end
+      end
+    end
+  end
+end

data/spec/paperclip/io_adapters/uri_adapter_spec.rb

@@ -0,0 +1,221 @@
+require "spec_helper"
+
+describe Paperclip::UriAdapter do
+  let(:content_type) { "image/png" }
+  let(:meta) { {} }
+
+  before do
+    @open_return = StringIO.new("xxx")
+    allow(@open_return).to receive(:content_type).and_return(content_type)
+    allow(@open_return).to receive(:meta).and_return(meta)
+    Paperclip::UriAdapter.register
+  end
+
+  after do
+    Paperclip.io_adapters.unregister(described_class)
+  end
+
+  context "a new instance" do
+    let(:meta) { { "content-type" => "image/png" } }
+
+    before do
+      allow_any_instance_of(Paperclip::UriAdapter).
+        to receive(:download_content).and_return(@open_return)
+
+      @uri = URI.parse("http://thoughtbot.com/images/thoughtbot-logo.png")
+      @subject = Paperclip.io_adapters.for(@uri, hash_digest: Digest::MD5)
+    end
+
+    it "returns a file name" do
+      assert_equal "thoughtbot-logo.png", @subject.original_filename
+    end
+
+    it "closes open handle after reading" do
+      assert_equal true, @open_return.closed?
+    end
+
+    it "returns a content type" do
+      assert_equal "image/png", @subject.content_type
+    end
+
+    it "returns the size of the data" do
+      assert_equal @open_return.size, @subject.size
+    end
+
+    it "generates an MD5 hash of the contents" do
+      assert_equal Digest::MD5.hexdigest("xxx"), @subject.fingerprint
+    end
+
+    it "generates correct fingerprint after read" do
+      fingerprint = Digest::MD5.hexdigest(@subject.read)
+      assert_equal fingerprint, @subject.fingerprint
+    end
+
+    it "generates same fingerprint" do
+      assert_equal @subject.fingerprint, @subject.fingerprint
+    end
+
+    it "returns the data contained in the StringIO" do
+      assert_equal "xxx", @subject.read
+    end
+
+    it "accepts a content_type" do
+      @subject.content_type = "image/png"
+      assert_equal "image/png", @subject.content_type
+    end
+
+    it "accepts an original_filename" do
+      @subject.original_filename = "image.png"
+      assert_equal "image.png", @subject.original_filename
+    end
+  end
+
+  context "a directory index url" do
+    let(:content_type) { "text/html" }
+    let(:meta) { { "content-type" => "text/html" } }
+
+    before do
+      allow_any_instance_of(Paperclip::UriAdapter).
+        to receive(:download_content).and_return(@open_return)
+
+      @uri = URI.parse("http://thoughtbot.com")
+      @subject = Paperclip.io_adapters.for(@uri)
+    end
+
+    it "returns a file name" do
+      assert_equal "index.html", @subject.original_filename
+    end
+
+    it "returns a content type" do
+      assert_equal "text/html", @subject.content_type
+    end
+  end
+
+  context "a url with query params" do
+    before do
+      allow_any_instance_of(Paperclip::UriAdapter).
+        to receive(:download_content).and_return(@open_return)
+
+      @uri = URI.parse("https://github.com/thoughtbot/paperclip?file=test")
+      @subject = Paperclip.io_adapters.for(@uri)
+    end
+
+    it "returns a file name" do
+      assert_equal "paperclip", @subject.original_filename
+    end
+  end
+
+  context "a url with content disposition headers" do
+    let(:file_name) { "test_document.pdf" }
+    let(:filename_from_path) { "paperclip" }
+
+    before do
+      allow_any_instance_of(Paperclip::UriAdapter).
+        to receive(:download_content).and_return(@open_return)
+
+      @uri = URI.parse(
+        "https://github.com/thoughtbot/#{filename_from_path}?file=test"
+      )
+    end
+
+    it "returns file name from path" do
+      meta["content-disposition"] = "inline;"
+
+      @subject = Paperclip.io_adapters.for(@uri)
+
+      assert_equal filename_from_path, @subject.original_filename
+    end
+
+    it "returns a file name enclosed in double quotes" do
+      file_name = "john's test document.pdf"
+      meta["content-disposition"] = "attachment; filename=\"#{file_name}\";"
+
+      @subject = Paperclip.io_adapters.for(@uri)
+
+      assert_equal file_name, @subject.original_filename
+    end
+
+    it "returns a file name not enclosed in double quotes" do
+      meta["content-disposition"] = "ATTACHMENT; FILENAME=#{file_name};"
+
+      @subject = Paperclip.io_adapters.for(@uri)
+
+      assert_equal file_name, @subject.original_filename
+    end
+
+    it "does not crash when an empty filename is given" do
+      meta["content-disposition"] = "ATTACHMENT; FILENAME=\"\";"
+
+      @subject = Paperclip.io_adapters.for(@uri)
+
+      assert_equal "", @subject.original_filename
+    end
+
+    it "returns a file name ignoring RFC 5987 encoding" do
+      meta["content-disposition"] =
+        "attachment; filename=#{file_name}; filename* = utf-8''%e2%82%ac%20rates"
+
+      @subject = Paperclip.io_adapters.for(@uri)
+
+      assert_equal file_name, @subject.original_filename
+    end
+
+    context "when file name has consecutive periods" do
+      let(:file_name) { "test_document..pdf" }
+
+      it "returns a file name" do
+        @uri = URI.parse(
+          "https://github.com/thoughtbot/#{file_name}?file=test"
+        )
+        @subject = Paperclip.io_adapters.for(@uri)
+        assert_equal file_name, @subject.original_filename
+      end
+    end
+  end
+
+  context "a url with restricted characters in the filename" do
+    before do
+      allow_any_instance_of(Paperclip::UriAdapter).
+        to receive(:download_content).and_return(@open_return)
+
+      @uri = URI.parse("https://github.com/thoughtbot/paper:clip.jpg")
+      @subject = Paperclip.io_adapters.for(@uri)
+    end
+
+    it "does not generate filenames that include restricted characters" do
+      assert_equal "paper_clip.jpg", @subject.original_filename
+    end
+
+    it "does not generate paths that include restricted characters" do
+      expect(@subject.path).to_not match(/:/)
+    end
+  end
+
+  describe "#download_content" do
+    before do
+      allow_any_instance_of(Paperclip::UriAdapter).to receive(:open).and_return(@open_return)
+      @uri = URI.parse("https://github.com/thoughtbot/paper:clip.jpg")
+      @subject = Paperclip.io_adapters.for(@uri)
+    end
+
+    after do
+      @subject.send(:download_content)
+    end
+
+    context "with default read_timeout" do
+      it "calls open without options" do
+        expect(@subject).to receive(:open).with(@uri, {}).at_least(1).times
+      end
+    end
+
+    context "with custom read_timeout" do
+      before do
+        Paperclip.options[:read_timeout] = 120
+      end
+
+      it "calls open with read_timeout option" do
+        expect(@subject).to receive(:open).with(@uri, read_timeout: 120).at_least(1).times
+      end
+    end
+  end
+end

data/spec/paperclip/matchers/have_attached_file_matcher_spec.rb

@@ -0,0 +1,19 @@
+require "spec_helper"
+require "paperclip/matchers"
+
+describe Paperclip::Shoulda::Matchers::HaveAttachedFileMatcher do
+  extend Paperclip::Shoulda::Matchers
+
+  it "rejects the dummy class if it has no attachment" do
+    reset_table "dummies"
+    reset_class "Dummy"
+    matcher = self.class.have_attached_file(:avatar)
+    expect(matcher).to_not accept(Dummy)
+  end
+
+  it "accepts the dummy class if it has an attachment" do
+    rebuild_model
+    matcher = self.class.have_attached_file(:avatar)
+    expect(matcher).to accept(Dummy)
+  end
+end