kt-paperclip 6.2.0

data/spec/paperclip/interpolations_spec.rb

@@ -0,0 +1,270 @@
+require "spec_helper"
+
+describe Paperclip::Interpolations do
+  it "returns all methods but the infrastructure when sent #all" do
+    methods = Paperclip::Interpolations.all
+    assert !methods.include?(:[])
+    assert !methods.include?(:[]=)
+    assert !methods.include?(:all)
+    methods.each do |m|
+      assert Paperclip::Interpolations.respond_to?(m)
+    end
+  end
+
+  it "returns the Rails.root" do
+    assert_equal Rails.root, Paperclip::Interpolations.rails_root(:attachment, :style)
+  end
+
+  it "returns the Rails.env" do
+    assert_equal Rails.env, Paperclip::Interpolations.rails_env(:attachment, :style)
+  end
+
+  it "returns the class of the Interpolations module when called with no params" do
+    assert_equal Module, Paperclip::Interpolations.class
+  end
+
+  it "returns the class of the instance" do
+    class Thing; end
+    attachment = spy
+    expect(attachment).to receive(:instance).and_return(attachment)
+    expect(attachment).to receive(:class).and_return(Thing)
+    assert_equal "things", Paperclip::Interpolations.class(attachment, :style)
+  end
+
+  it "returns the basename of the file" do
+    attachment = spy
+    expect(attachment).to receive(:original_filename).and_return("one.jpg")
+    assert_equal "one", Paperclip::Interpolations.basename(attachment, :style)
+  end
+
+  it "returns the extension of the file" do
+    attachment = spy
+    expect(attachment).to receive(:original_filename).and_return("one.jpg")
+    expect(attachment).to receive(:styles).and_return({})
+    assert_equal "jpg", Paperclip::Interpolations.extension(attachment, :style)
+  end
+
+  it "returns the extension of the file as the format if defined in the style" do
+    attachment = spy
+    expect(attachment).to_not receive(:original_filename)
+    expect(attachment).to receive(:styles).at_least(2).times.and_return(style: { format: "png" })
+
+    [:style, "style"].each do |style|
+      assert_equal "png", Paperclip::Interpolations.extension(attachment, style)
+    end
+  end
+
+  it "returns the extension of the file based on the content type" do
+    attachment = spy
+    expect(attachment).to receive(:content_type).and_return("image/png")
+    expect(attachment).to receive(:styles).and_return({})
+    interpolations = Paperclip::Interpolations
+    expect(interpolations).to receive(:extension).and_return("random")
+    assert_equal "png", interpolations.content_type_extension(attachment, :style)
+  end
+
+  it "returns the original extension of the file if it matches a content type extension" do
+    attachment = spy
+    expect(attachment).to receive(:content_type).and_return("image/jpeg")
+    expect(attachment).to receive(:styles).and_return({})
+    interpolations = Paperclip::Interpolations
+    expect(interpolations).to receive(:extension).and_return("jpe")
+    assert_equal "jpe", interpolations.content_type_extension(attachment, :style)
+  end
+
+  it "returns the extension of the file with a dot" do
+    attachment = spy
+    expect(attachment).to receive(:original_filename).and_return("one.jpg")
+    expect(attachment).to receive(:styles).and_return({})
+    assert_equal ".jpg", Paperclip::Interpolations.dotextension(attachment, :style)
+  end
+
+  it "returns the extension of the file without a dot if the extension is empty" do
+    attachment = spy
+    expect(attachment).to receive(:original_filename).and_return("one")
+    expect(attachment).to receive(:styles).and_return({})
+    assert_equal "", Paperclip::Interpolations.dotextension(attachment, :style)
+  end
+
+  it "returns the latter half of the content type of the extension if no match found" do
+    attachment = spy
+    allow(attachment).to receive(:content_type).at_least(1).times.and_return("not/found")
+    allow(attachment).to receive(:styles).and_return({})
+    interpolations = Paperclip::Interpolations
+    expect(interpolations).to receive(:extension).and_return("random")
+    assert_equal "found", interpolations.content_type_extension(attachment, :style)
+  end
+
+  it "returns the format if defined in the style, ignoring the content type" do
+    attachment = spy
+    expect(attachment).to receive(:content_type).and_return("image/jpeg")
+    expect(attachment).to receive(:styles).and_return(style: { format: "png" })
+    interpolations = Paperclip::Interpolations
+    expect(interpolations).to receive(:extension).and_return("random")
+    assert_equal "png", interpolations.content_type_extension(attachment, :style)
+  end
+
+  it "is able to handle numeric style names" do
+    attachment = spy(
+      styles: {:"4" => {format: :expected_extension}}
+    )
+    assert_equal :expected_extension, Paperclip::Interpolations.extension(attachment, 4)
+  end
+
+  it "returns the #to_param of the attachment" do
+    attachment = spy
+    expect(attachment).to receive(:to_param).and_return("23-awesome")
+    expect(attachment).to receive(:instance).and_return(attachment)
+    assert_equal "23-awesome", Paperclip::Interpolations.param(attachment, :style)
+  end
+
+  it "returns the id of the attachment" do
+    attachment = spy
+    expect(attachment).to receive(:id).and_return(23)
+    expect(attachment).to receive(:instance).and_return(attachment)
+    assert_equal 23, Paperclip::Interpolations.id(attachment, :style)
+  end
+
+  it "returns nil for attachments to new records" do
+    attachment = spy
+    expect(attachment).to receive(:id).and_return(nil)
+    expect(attachment).to receive(:instance).and_return(attachment)
+    assert_nil Paperclip::Interpolations.id(attachment, :style)
+  end
+
+  it "returns the partitioned id of the attachment when the id is an integer" do
+    attachment = spy
+    expect(attachment).to receive(:id).and_return(23)
+    expect(attachment).to receive(:instance).and_return(attachment)
+    assert_equal "000/000/023", Paperclip::Interpolations.id_partition(attachment, :style)
+  end
+
+  it "returns the partitioned id when the id is above 999_999_999" do
+    attachment = spy
+    expect(attachment).to receive(:id).and_return(Paperclip::Interpolations::ID_PARTITION_LIMIT)
+    expect(attachment).to receive(:instance).and_return(attachment)
+    assert_equal "001/000/000/000",
+                 Paperclip::Interpolations.id_partition(attachment, :style)
+  end
+
+  it "returns the partitioned id of the attachment when the id is a string" do
+    attachment = spy
+    expect(attachment).to receive(:id).and_return("32fnj23oio2f")
+    expect(attachment).to receive(:instance).and_return(attachment)
+    assert_equal "32f/nj2/3oi", Paperclip::Interpolations.id_partition(attachment, :style)
+  end
+
+  it "returns nil for the partitioned id of an attachment to a new record (when the id is nil)" do
+    attachment = spy
+    expect(attachment).to receive(:id).and_return(nil)
+    expect(attachment).to receive(:instance).and_return(attachment)
+    assert_nil Paperclip::Interpolations.id_partition(attachment, :style)
+  end
+
+  it "returns the name of the attachment" do
+    attachment = spy
+    expect(attachment).to receive(:name).and_return("file")
+    assert_equal "files", Paperclip::Interpolations.attachment(attachment, :style)
+  end
+
+  it "returns the style" do
+    assert_equal :style, Paperclip::Interpolations.style(:attachment, :style)
+  end
+
+  it "returns the default style" do
+    attachment = spy
+    expect(attachment).to receive(:default_style).and_return(:default_style)
+    assert_equal :default_style, Paperclip::Interpolations.style(attachment, nil)
+  end
+
+  it "reinterpolates :url" do
+    attachment = spy
+    expect(attachment).to receive(:url).with(:style, timestamp: false, escape: false).and_return("1234")
+    assert_equal "1234", Paperclip::Interpolations.url(attachment, :style)
+  end
+
+  it "raises if infinite loop detcted reinterpolating :url" do
+    attachment = Object.new
+    class << attachment
+      def url(*_args)
+        Paperclip::Interpolations.url(self, :style)
+      end
+    end
+    assert_raises(Paperclip::Errors::InfiniteInterpolationError) { Paperclip::Interpolations.url(attachment, :style) }
+  end
+
+  it "returns the filename as basename.extension" do
+    attachment = spy
+    expect(attachment).to receive(:styles).and_return({})
+    expect(attachment).to receive(:original_filename).and_return("one.jpg").twice
+    assert_equal "one.jpg", Paperclip::Interpolations.filename(attachment, :style)
+  end
+
+  it "returns the filename as basename.extension when format supplied" do
+    attachment = spy
+    expect(attachment).to receive(:styles).and_return(style: { format: :png })
+    expect(attachment).to receive(:original_filename).and_return("one.jpg").once
+    assert_equal "one.png", Paperclip::Interpolations.filename(attachment, :style)
+  end
+
+  it "returns the filename as basename when extension is blank" do
+    attachment = spy
+    allow(attachment).to receive(:styles).and_return({})
+    allow(attachment).to receive(:original_filename).and_return("one")
+    assert_equal "one", Paperclip::Interpolations.filename(attachment, :style)
+  end
+
+  it "returns the basename when the extension contains regexp special characters" do
+    attachment = spy
+    allow(attachment).to receive(:styles).and_return({})
+    allow(attachment).to receive(:original_filename).and_return("one.ab)")
+    assert_equal "one", Paperclip::Interpolations.basename(attachment, :style)
+  end
+
+  it "returns the timestamp" do
+    now = Time.now
+    zone = "UTC"
+    attachment = spy
+    expect(attachment).to receive(:instance_read).with(:updated_at).and_return(now)
+    expect(attachment).to receive(:time_zone).and_return(zone)
+    assert_equal now.in_time_zone(zone).to_s, Paperclip::Interpolations.timestamp(attachment, :style)
+  end
+
+  it "returns updated_at" do
+    attachment = spy
+    seconds_since_epoch = 1234567890
+    expect(attachment).to receive(:updated_at).and_return(seconds_since_epoch)
+    assert_equal seconds_since_epoch, Paperclip::Interpolations.updated_at(attachment, :style)
+  end
+
+  it "returns attachment's hash when passing both arguments" do
+    attachment = spy
+    fake_hash = "a_wicked_secure_hash"
+    expect(attachment).to receive(:hash_key).and_return(fake_hash)
+    assert_equal fake_hash, Paperclip::Interpolations.hash(attachment, :style)
+  end
+
+  it "returns Object#hash when passing no argument" do
+    attachment = spy
+    fake_hash = "a_wicked_secure_hash"
+    expect(attachment).to_not receive(:hash_key)
+    assert_not_equal fake_hash, Paperclip::Interpolations.hash
+  end
+
+  it "calls all expected interpolations with the given arguments" do
+    expect(Paperclip::Interpolations).to receive(:id).with(:attachment, :style).and_return(1234)
+    expect(Paperclip::Interpolations).to receive(:attachment).with(:attachment, :style).and_return("attachments")
+    expect(Paperclip::Interpolations).to_not receive(:notreal)
+    value = Paperclip::Interpolations.interpolate(":notreal/:id/:attachment", :attachment, :style)
+    assert_equal ":notreal/1234/attachments", value
+  end
+
+  it "handles question marks" do
+    Paperclip.interpolates :foo? do
+      "bar"
+    end
+    expect(Paperclip::Interpolations).to_not receive(:fool)
+    value = Paperclip::Interpolations.interpolate(":fo/:foo?")
+    assert_equal ":fo/bar", value
+  end
+end

data/spec/paperclip/io_adapters/abstract_adapter_spec.rb

@@ -0,0 +1,160 @@
+require "spec_helper"
+
+describe Paperclip::AbstractAdapter do
+  class TestAdapter < Paperclip::AbstractAdapter
+    attr_accessor :tempfile
+
+    def content_type
+      Paperclip::ContentTypeDetector.new(path).detect
+    end
+  end
+
+  subject { TestAdapter.new(nil) }
+
+  context "content type from file contents" do
+    before do
+      allow(subject).to receive(:path).and_return("image.png")
+      allow(Paperclip).to receive(:run).and_return("image/png\n")
+      allow_any_instance_of(Paperclip::ContentTypeDetector).to receive(:type_from_mime_magic).and_return("image/png")
+    end
+
+    it "returns the content type without newline" do
+      assert_equal "image/png", subject.content_type
+    end
+  end
+
+  context "nil?" do
+    it "returns false" do
+      assert !subject.nil?
+    end
+  end
+
+  context "delegation" do
+    before do
+      subject.tempfile = double("Tempfile")
+    end
+
+    [:binmode, :binmode?, :close, :close!, :closed?, :eof?, :path, :readbyte, :rewind, :unlink].each do |method|
+      it "delegates #{method} to @tempfile" do
+        allow(subject.tempfile).to receive(method)
+        subject.public_send(method)
+        expect(subject.tempfile).to have_received(method)
+      end
+    end
+  end
+
+  it "gets rid of slashes and colons in filenames" do
+    subject.original_filename = "awesome/file:name.png"
+
+    assert_equal "awesome_file_name.png", subject.original_filename
+  end
+
+  it "is an assignment" do
+    assert subject.assignment?
+  end
+
+  it "is not nil" do
+    assert !subject.nil?
+  end
+
+  it "generates a destination filename with no original filename" do
+    expect(subject.send(:destination).path).to_not be_nil
+  end
+
+  it "uses the original filename to generate the tempfile" do
+    subject.original_filename = "file.png"
+    expect(subject.send(:destination).path).to end_with(".png")
+  end
+
+  context "generates a fingerprint" do
+    subject { TestAdapter.new(nil, options) }
+
+    before do
+      allow(subject).to receive(:path).and_return(fixture_file("50x50.png"))
+    end
+
+    context "MD5" do
+      let(:options) { { hash_digest: Digest::MD5 } }
+
+      it "returns a fingerprint" do
+        expect(subject.fingerprint).to be_a String
+        expect(subject.fingerprint).to eq "a790b00c9b5d58a8fd17a1ec5a187129"
+      end
+    end
+
+    context "SHA256" do
+      let(:options) { { hash_digest: Digest::SHA256 } }
+
+      it "returns a fingerprint" do
+        expect(subject.fingerprint).to be_a String
+        expect(subject.fingerprint).
+          to eq "243d7ce1099719df25f600f1c369c629fb979f88d5a01dbe7d0d48c8e6715bb1"
+      end
+    end
+  end
+
+  context "#copy_to_tempfile" do
+    around do |example|
+      FileUtils.module_eval do
+        class << self
+          alias paperclip_ln ln
+
+          def ln(*)
+            raise Errno::EXDEV
+          end
+        end
+      end
+
+      example.run
+
+      FileUtils.module_eval do
+        class << self
+          alias ln paperclip_ln
+          undef paperclip_ln
+        end
+      end
+    end
+
+    it "should return a readable file even when linking fails" do
+      src = open(fixture_file("5k.png"), "rb")
+      expect(subject.send(:copy_to_tempfile, src).read).to eq src.read
+    end
+  end
+
+  context "#original_filename=" do
+    it "should not fail with a nil original filename" do
+      expect { subject.original_filename = nil }.not_to raise_error
+    end
+  end
+
+  context "#link_or_copy_file" do
+    class TestLinkOrCopyAdapter < Paperclip::AbstractAdapter
+      public :copy_to_tempfile, :destination
+    end
+
+    subject { TestLinkOrCopyAdapter.new(nil) }
+    let(:body) { "body" }
+
+    let(:file) do
+      t = Tempfile.new("destination")
+      t.print(body)
+      t.rewind
+      t
+    end
+
+    after do
+      file.close
+      file.unlink
+    end
+
+    it "should be able to read the file" do
+      expect(subject.copy_to_tempfile(file).read).to eq(body)
+    end
+
+    it "should be able to reopen the file after symlink has failed" do
+      expect(FileUtils).to receive(:ln).and_raise(Errno::EXDEV)
+
+      expect(subject.copy_to_tempfile(file).read).to eq(body)
+    end
+  end
+end

data/spec/paperclip/io_adapters/attachment_adapter_spec.rb

@@ -0,0 +1,140 @@
+require "spec_helper"
+
+describe Paperclip::AttachmentAdapter do
+  before do
+    rebuild_model path: "tmp/:class/:attachment/:style/:filename", styles: { thumb: "50x50" }
+    @attachment = Dummy.new.avatar
+  end
+
+  context "for an attachment" do
+    before do
+      @file = File.new(fixture_file("5k.png"))
+      @file.binmode
+
+      @attachment.assign(@file)
+      @attachment.save
+      @subject = Paperclip.io_adapters.for(@attachment,
+                                           hash_digest: Digest::MD5)
+    end
+
+    after do
+      @file.close
+      @subject.close
+    end
+
+    it "gets the right filename" do
+      assert_equal "5k.png", @subject.original_filename
+    end
+
+    it "forces binmode on tempfile" do
+      assert @subject.instance_variable_get("@tempfile").binmode?
+    end
+
+    it "gets the content type" do
+      assert_equal "image/png", @subject.content_type
+    end
+
+    it "gets the file's size" do
+      assert_equal 4456, @subject.size
+    end
+
+    it "returns false for a call to nil?" do
+      assert !@subject.nil?
+    end
+
+    it "generates a MD5 hash of the contents" do
+      expected = Digest::MD5.file(@file.path).to_s
+      assert_equal expected, @subject.fingerprint
+    end
+
+    it "reads the contents of the file" do
+      expected = @file.read
+      actual = @subject.read
+      assert !expected.empty?
+      assert_equal expected.length, actual.length
+      assert_equal expected, actual
+    end
+  end
+
+  context "for a file with restricted characters in the name" do
+    before do
+      file_contents = IO.read(fixture_file("animated.gif"))
+      @file = StringIO.new(file_contents)
+      allow(@file).to receive(:original_filename).and_return("image:restricted.gif")
+      @file.binmode
+
+      @attachment.assign(@file)
+      @attachment.save
+      @subject = Paperclip.io_adapters.for(@attachment,
+                                           hash_digest: Digest::MD5)
+    end
+
+    after do
+      @subject.close
+    end
+
+    it "does not generate paths that include restricted characters" do
+      expect(@subject.path).to_not match(/:/)
+    end
+
+    it "does not generate filenames that include restricted characters" do
+      assert_equal "image_restricted.gif", @subject.original_filename
+    end
+  end
+
+  context "for a style" do
+    before do
+      @file = File.new(fixture_file("5k.png"))
+      @file.binmode
+
+      @attachment.assign(@file)
+
+      @thumb = Tempfile.new("thumbnail").tap(&:binmode)
+      FileUtils.cp @attachment.queued_for_write[:thumb].path, @thumb.path
+
+      @attachment.save
+      @subject = Paperclip.io_adapters.for(@attachment.styles[:thumb],
+                                           hash_digest: Digest::MD5)
+    end
+
+    after do
+      @file.close
+      @thumb.close
+      @subject.close
+    end
+
+    it "gets the original filename" do
+      assert_equal "5k.png", @subject.original_filename
+    end
+
+    it "forces binmode on tempfile" do
+      assert @subject.instance_variable_get("@tempfile").binmode?
+    end
+
+    it "gets the content type" do
+      assert_equal "image/png", @subject.content_type
+    end
+
+    it "gets the thumbnail's file size" do
+      assert_equal @thumb.size, @subject.size
+    end
+
+    it "returns false for a call to nil?" do
+      assert !@subject.nil?
+    end
+
+    it "generates a MD5 hash of the contents" do
+      expected = Digest::MD5.file(@thumb.path).to_s
+      assert_equal expected, @subject.fingerprint
+    end
+
+    it "reads the contents of the thumbnail" do
+      @thumb.rewind
+      expected = @thumb.read
+      actual = @subject.read
+      assert !expected.empty?
+      assert_equal expected.length, actual.length
+      assert_equal expected, actual
+    end
+  end
+end