kt-paperclip 5.4.0 → 6.2.0

data/spec/paperclip/validators/media_type_spoof_detection_validator_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Paperclip::Validators::MediaTypeSpoofDetectionValidator do
   before do
@@ -8,17 +8,17 @@ describe Paperclip::Validators::MediaTypeSpoofDetectionValidator do
 
   def build_validator(options = {})
     @validator = Paperclip::Validators::MediaTypeSpoofDetectionValidator.new(options.merge(
-      attributes: :avatar
-    ))
+                                                                               attributes: :avatar
+                                                                             ))
   end
 
   it "is on the attachment without being explicitly added" do
-    assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :media_type_spoof_detection }
+    assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :media_type_spoof_detection }
   end
 
   it "is not on the attachment when explicitly rejected" do
     rebuild_model validate_media_type: false
-    assert Dummy.validators_on(:avatar).none?{ |validator| validator.kind == :media_type_spoof_detection }
+    assert Dummy.validators_on(:avatar).none? { |validator| validator.kind == :media_type_spoof_detection }
   end
 
   it "returns default error message for spoofed media type" do
@@ -26,8 +26,8 @@ describe Paperclip::Validators::MediaTypeSpoofDetectionValidator do
     file = File.new(fixture_file("5k.png"), "rb")
     @dummy.avatar.assign(file)
 
-    detector = mock("detector", :spoofed? => true)
-    Paperclip::MediaTypeSpoofDetector.stubs(:using).returns(detector)
+    detector = double("detector", spoofed?: true)
+    allow(Paperclip::MediaTypeSpoofDetector).to receive(:using).and_return(detector)
     @validator.validate(@dummy)
 
     assert_equal I18n.t("errors.messages.spoofed_media_type"), @dummy.errors[:avatar].first
@@ -37,16 +37,12 @@ describe Paperclip::Validators::MediaTypeSpoofDetectionValidator do
     build_validator
     file = File.new(fixture_file("5k.png"), "rb")
     @dummy.avatar.assign(file)
-    Paperclip::MediaTypeSpoofDetector.stubs(:using).returns(stub(:spoofed? => false))
-
+    expect(Paperclip::MediaTypeSpoofDetector).to receive(:using).once.and_return(double("detector", spoofed?: false))
     @dummy.valid?
-
-    assert_received(Paperclip::MediaTypeSpoofDetector, :using){|e| e.once }
   end
 
   it "does not run when attachment is not dirty" do
-    Paperclip::MediaTypeSpoofDetector.stubs(:using).never
+    expect(Paperclip::MediaTypeSpoofDetector).to_not receive(:using)
     @dummy.valid?
-    assert_received(Paperclip::MediaTypeSpoofDetector, :using){|e| e.never }
   end
 end

data/spec/paperclip/validators_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Paperclip::Validators do
   context "using the helper" do
@@ -8,65 +8,65 @@ describe Paperclip::Validators do
     end
 
     it "adds the attachment_presence validator to the class" do
-      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_presence }
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_presence }
     end
 
     it "adds the attachment_content_type validator to the class" do
-      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_content_type }
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_content_type }
     end
 
     it "adds the attachment_size validator to the class" do
-      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_size }
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_size }
     end
 
-    it 'prevents you from attaching a file that violates that validation' do
-      Dummy.class_eval{ validate(:name) { raise "DO NOT RUN THIS" } }
+    it "prevents you from attaching a file that violates that validation" do
+      Dummy.class_eval { validate(:name) { raise "DO NOT RUN THIS" } }
       dummy = Dummy.new(avatar: File.new(fixture_file("12k.png")))
       expect(dummy.errors.keys).to match_array [:avatar_content_type, :avatar, :avatar_file_size]
-      assert_raises(RuntimeError){ dummy.valid? }
+      assert_raises(RuntimeError) { dummy.valid? }
     end
   end
 
-  context 'using the helper with array of validations' do
+  context "using the helper with array of validations" do
     before do
       rebuild_class
       Dummy.validates_attachment :avatar, file_type_ignorance: true, file_name: [
-          { matches: /\A.*\.jpe?g\z/i, message: :invalid_extension },
-          { matches: /\A.{,8}\..+\z/i, message: [:too_long, count: 8] },
+        { matches: /\A.*\.jpe?g\z/i, message: :invalid_extension },
+        { matches: /\A.{,8}\..+\z/i, message: [:too_long, count: 8] },
       ]
     end
 
-    it 'adds the attachment_file_name validator to the class' do
-      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_file_name }
+    it "adds the attachment_file_name validator to the class" do
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_file_name }
     end
 
-    it 'adds the attachment_file_name validator with two validations' do
-      assert_equal 2, Dummy.validators_on(:avatar).select{ |validator| validator.kind == :attachment_file_name }.size
+    it "adds the attachment_file_name validator with two validations" do
+      assert_equal 2, Dummy.validators_on(:avatar).select { |validator| validator.kind == :attachment_file_name }.size
     end
 
-    it 'prevents you from attaching a file that violates all of these validations' do
-      Dummy.class_eval{ validate(:name) { raise 'DO NOT RUN THIS' } }
-      dummy = Dummy.new(avatar: File.new(fixture_file('spaced file.png')))
+    it "prevents you from attaching a file that violates all of these validations" do
+      Dummy.class_eval { validate(:name) { raise "DO NOT RUN THIS" } }
+      dummy = Dummy.new(avatar: File.new(fixture_file("spaced file.png")))
       expect(dummy.errors.keys).to match_array [:avatar, :avatar_file_name]
-      assert_raises(RuntimeError){ dummy.valid? }
+      assert_raises(RuntimeError) { dummy.valid? }
     end
 
-    it 'prevents you from attaching a file that violates only first of these validations' do
-      Dummy.class_eval{ validate(:name) { raise 'DO NOT RUN THIS' } }
-      dummy = Dummy.new(avatar: File.new(fixture_file('5k.png')))
+    it "prevents you from attaching a file that violates only first of these validations" do
+      Dummy.class_eval { validate(:name) { raise "DO NOT RUN THIS" } }
+      dummy = Dummy.new(avatar: File.new(fixture_file("5k.png")))
       expect(dummy.errors.keys).to match_array [:avatar, :avatar_file_name]
-      assert_raises(RuntimeError){ dummy.valid? }
+      assert_raises(RuntimeError) { dummy.valid? }
     end
 
-    it 'prevents you from attaching a file that violates only second of these validations' do
-      Dummy.class_eval{ validate(:name) { raise 'DO NOT RUN THIS' } }
-      dummy = Dummy.new(avatar: File.new(fixture_file('spaced file.jpg')))
+    it "prevents you from attaching a file that violates only second of these validations" do
+      Dummy.class_eval { validate(:name) { raise "DO NOT RUN THIS" } }
+      dummy = Dummy.new(avatar: File.new(fixture_file("spaced file.jpg")))
       expect(dummy.errors.keys).to match_array [:avatar, :avatar_file_name]
-      assert_raises(RuntimeError){ dummy.valid? }
+      assert_raises(RuntimeError) { dummy.valid? }
     end
 
-    it 'allows you to attach a file that does not violate these validations' do
-      dummy = Dummy.new(avatar: File.new(fixture_file('rotated.jpg')))
+    it "allows you to attach a file that does not violate these validations" do
+      dummy = Dummy.new(avatar: File.new(fixture_file("rotated.jpg")))
       expect(dummy.errors.full_messages).to be_empty
       assert dummy.valid?
     end
@@ -76,9 +76,9 @@ describe Paperclip::Validators do
     before do
       rebuild_class
       Dummy.validates_attachment :avatar, presence: true,
-        content_type: { content_type: "image/jpeg" },
-        size: { in: 0..10240 },
-        if: :title_present?
+                                          content_type: { content_type: "image/jpeg" },
+                                          size: { in: 0..10240 },
+                                          if: :title_present?
     end
 
     it "validates the attachment if title is present" do
@@ -102,20 +102,20 @@ describe Paperclip::Validators do
     end
   end
 
-  context 'with no other validations on the Dummy#avatar attachment' do
+  context "with no other validations on the Dummy#avatar attachment" do
     before do
       reset_class("Dummy")
       Dummy.has_attached_file :avatar
       Paperclip.reset_duplicate_clash_check!
     end
 
-    it 'raises an error when no content_type validation exists' do
+    it "raises an error when no content_type validation exists" do
       assert_raises(Paperclip::Errors::MissingRequiredValidatorError) do
         Dummy.new(avatar: File.new(fixture_file("12k.png")))
       end
     end
 
-    it 'does not raise an error when a content_type validation exists' do
+    it "does not raise an error when a content_type validation exists" do
       Dummy.validates_attachment :avatar, content_type: { content_type: "image/jpeg" }
 
       assert_nothing_raised do
@@ -123,18 +123,18 @@ describe Paperclip::Validators do
       end
     end
 
-    it 'does not raise an error when a content_type validation exists using validates_with' do
-      Dummy.validates_with Paperclip::Validators::AttachmentContentTypeValidator, attributes: :attachment, content_type: 'images/jpeg'
+    it "does not raise an error when a content_type validation exists using validates_with" do
+      Dummy.validates_with Paperclip::Validators::AttachmentContentTypeValidator, attributes: :attachment, content_type: "images/jpeg"
 
       assert_nothing_raised do
         Dummy.new(avatar: File.new(fixture_file("12k.png")))
       end
     end
 
-    it 'does not raise an error when an inherited validator is used' do
+    it "does not raise an error when an inherited validator is used" do
       class MyValidator < Paperclip::Validators::AttachmentContentTypeValidator
         def initialize(options)
-          options[:content_type] = "images/jpeg" unless options.has_key?(:content_type)
+          options[:content_type] = "images/jpeg" unless options.key?(:content_type)
           super
         end
       end
@@ -145,7 +145,7 @@ describe Paperclip::Validators do
       end
     end
 
-    it 'does not raise an error when a file_name validation exists' do
+    it "does not raise an error when a file_name validation exists" do
       Dummy.validates_attachment :avatar, file_name: { matches: /png$/ }
 
       assert_nothing_raised do
@@ -153,7 +153,7 @@ describe Paperclip::Validators do
       end
     end
 
-    it 'does not raise an error when a the validation has been explicitly rejected' do
+    it "does not raise an error when a the validation has been explicitly rejected" do
       Dummy.validates_attachment :avatar, file_type_ignorance: true
 
       assert_nothing_raised do

data/spec/spec_helper.rb

@@ -1,36 +1,35 @@
-require 'rubygems'
-require 'rspec'
-require 'active_record'
-require 'active_record/version'
-require 'active_support'
-require 'active_support/core_ext'
-require 'mocha/api'
-require 'bourne'
-require 'ostruct'
-require 'pathname'
-require 'activerecord-import'
-
-ROOT = Pathname(File.expand_path(File.join(File.dirname(__FILE__), '..')))
+require "rubygems"
+require "rspec"
+require "active_record"
+require "active_record/version"
+require "active_support"
+require "active_support/core_ext"
+require "ostruct"
+require "pathname"
+require "activerecord-import"
+require "yaml"
+
+ROOT = Pathname(File.expand_path(File.join(File.dirname(__FILE__), "..")))
 
 puts "Testing against version #{ActiveRecord::VERSION::STRING}"
 
-$LOAD_PATH << File.join(ROOT, 'lib')
-$LOAD_PATH << File.join(ROOT, 'lib', 'paperclip')
-require File.join(ROOT, 'lib', 'paperclip.rb')
+$LOAD_PATH << File.join(ROOT, "lib")
+$LOAD_PATH << File.join(ROOT, "lib", "paperclip")
+require File.join(ROOT, "lib", "paperclip.rb")
 
 FIXTURES_DIR = File.join(File.dirname(__FILE__), "fixtures")
-config = YAML::load(IO.read(File.dirname(__FILE__) + '/database.yml'))
+config = YAML::safe_load(IO.read(File.dirname(__FILE__) + "/database.yml"))
 ActiveRecord::Base.logger = Logger.new(File.dirname(__FILE__) + "/debug.log")
-ActiveRecord::Base.establish_connection(config['test'])
+ActiveRecord::Base.establish_connection(config["test"])
 if ActiveRecord::VERSION::STRING >= "4.2" &&
-    ActiveRecord::VERSION::STRING < "5.0"
+   ActiveRecord::VERSION::STRING < "5.0"
   ActiveRecord::Base.raise_in_transactional_callbacks = true
 end
 Paperclip.options[:logger] = ActiveRecord::Base.logger
 
-Dir[File.join(ROOT, 'spec', 'support', '**', '*.rb')].each{|f| require f }
+Dir[File.join(ROOT, "spec", "support", "**", "*.rb")].each { |f| require f }
 
-Rails = FakeRails.new('test', Pathname.new(ROOT).join('tmp'))
+Rails = FakeRails.new("test", Pathname.new(ROOT).join("tmp"))
 ActiveSupport::Deprecation.silenced = true
 
 RSpec.configure do |config|
@@ -39,8 +38,7 @@ RSpec.configure do |config|
   config.include TestData
   config.include Reporting
   config.extend VersionHelper
-  config.extend ConditionalFilterHelper
-  config.mock_framework = :mocha
+
   config.before(:all) do
     rebuild_model
   end

data/spec/support/assertions.rb

@@ -51,8 +51,8 @@ module Assertions
     url = "http:#{url}" unless url =~ /http/
     Net::HTTP.get_response(URI.parse(url)) do |response|
       assert_equal "200",
-        response.code,
-        "Expected HTTP response code 200, got #{response.code}"
+                   response.code,
+                   "Expected HTTP response code 200, got #{response.code}"
     end
   end
 
@@ -60,7 +60,7 @@ module Assertions
     url = "http:#{url}" unless url =~ /http/
     Net::HTTP.get_response(URI.parse(url)) do |response|
       assert_equal "404", response.code,
-        "Expected HTTP response code 404, got #{response.code}"
+                   "Expected HTTP response code 404, got #{response.code}"
     end
   end
 
@@ -68,14 +68,16 @@ module Assertions
     url = "http:#{url}" unless url =~ /http/
     Net::HTTP.get_response(URI.parse(url)) do |response|
       assert_equal "403", response.code,
-        "Expected HTTP response code 403, got #{response.code}"
+                   "Expected HTTP response code 403, got #{response.code}"
     end
   end
 
   def assert_frame_dimensions(range, frames)
     frames.each_with_index do |frame, frame_index|
-      frame.split('x').each_with_index do |dimension, dimension_index |
-        assert range.include?(dimension.to_i), "Frame #{frame_index}[#{dimension_index}] should have been within #{range.inspect}, but was #{dimension}"
+      frame.split("x").each_with_index do |dimension, dimension_index|
+        assert range.include?(dimension.to_i),
+               "Frame #{frame_index}[#{dimension_index}] should have been within #{range.inspect},
+                but was #{dimension}"
       end
     end
   end

data/spec/support/fake_model.rb

@@ -12,8 +12,7 @@ class FakeModel
     @errors ||= []
   end
 
-  def run_paperclip_callbacks name, *args
-  end
+  def run_paperclip_callbacks(name, *args); end
 
   def valid?
     errors.empty?

data/spec/support/fake_rails.rb

@@ -6,7 +6,7 @@ class FakeRails
 
   attr_accessor :env, :root
 
-  def const_defined?(const)
+  def const_defined?(_const)
     false
   end
 end

data/spec/support/matchers/exist.rb

@@ -1,4 +1,4 @@
-RSpec::Matchers.define :exist do |expected|
+RSpec::Matchers.define :exist do |_expected|
   match do |actual|
     File.exist?(actual)
   end

data/spec/support/matchers/have_column.rb

@@ -4,7 +4,7 @@ RSpec::Matchers.define :have_column do |column_name|
   end
 
   match do |columns|
-    column = columns.detect{|column| column.name == column_name }
+    column = columns.detect { |column| column.name == column_name }
     column && column.default.to_s == @default.to_s
   end
 

data/spec/support/mock_url_generator_builder.rb

@@ -1,6 +1,5 @@
 class MockUrlGeneratorBuilder
-  def initializer
-  end
+  def initializer; end
 
   def new(attachment)
     @attachment = attachment
@@ -16,7 +15,7 @@ class MockUrlGeneratorBuilder
 
   def has_generated_url_with_options?(options)
     # options.is_a_subhash_of(@generated_url_with_options)
-    options.inject(true) do |acc,(k,v)|
+    options.inject(true) do |acc, (k, v)|
       acc && @generated_url_with_options[k] == v
     end
   end

data/spec/support/model_reconstruction.rb

@@ -1,7 +1,11 @@
 module ModelReconstruction
-  def reset_class class_name
-    ActiveRecord::Base.send(:include, Paperclip::Glue)
-    Object.send(:remove_const, class_name) rescue nil
+  def reset_class(class_name)
+    ActiveRecord::Base.include Paperclip::Glue
+    begin
+      Object.send(:remove_const, class_name)
+    rescue StandardError
+      nil
+    end
     klass = Object.const_set(class_name, Class.new(ActiveRecord::Base))
 
     klass.class_eval do
@@ -22,29 +26,29 @@ module ModelReconstruction
     klass
   end
 
-  def reset_table table_name, &block
-    block ||= lambda { |table| true }
-    ActiveRecord::Base.connection.create_table :dummies, **{force: true}, &block
+  def reset_table(_table_name, &block)
+    block ||= lambda { |_table| true }
+    ActiveRecord::Base.connection.create_table :dummies, { force: true }, &block
   end
 
-  def modify_table table_name, &block
+  def modify_table(&block)
     ActiveRecord::Base.connection.change_table :dummies, &block
   end
 
-  def rebuild_model options = {}
-    ActiveRecord::Base.connection.create_table :dummies, **{force: true} do |table|
+  def rebuild_model(options = {})
+    ActiveRecord::Base.connection.create_table :dummies, force: true do |table|
       table.column :title, :string
       table.column :other, :string
       table.column :avatar_file_name, :string
       table.column :avatar_content_type, :string
-      table.column :avatar_file_size, :integer
+      table.column :avatar_file_size, :bigint
       table.column :avatar_updated_at, :datetime
       table.column :avatar_fingerprint, :string
     end
     rebuild_class options
   end
 
-  def rebuild_class options = {}
+  def rebuild_class(options = {})
     reset_class("Dummy").tap do |klass|
       klass.has_attached_file :avatar, options
       klass.do_not_validate_attachment_file_type :avatar
@@ -52,7 +56,7 @@ module ModelReconstruction
     end
   end
 
-  def rebuild_meta_class_of obj, options = {}
+  def rebuild_meta_class_of(obj, options = {})
     meta_class_of(obj).tap do |metaklass|
       metaklass.has_attached_file :avatar, options
       metaklass.do_not_validate_attachment_file_type :avatar

data/spec/support/reporting.rb

@@ -1,7 +1,7 @@
 module Reporting
   def silence_stream(stream)
     old_stream = stream.dup
-    stream.reopen(RbConfig::CONFIG['host_os'] =~ /mswin|mingw/ ? 'NUL:' : '/dev/null')
+    stream.reopen(RbConfig::CONFIG["host_os"] =~ /mswin|mingw/ ? "NUL:" : "/dev/null")
     stream.sync = true
     yield
   ensure

data/spec/support/test_data.rb

@@ -1,5 +1,5 @@
 module TestData
-  def attachment(options={})
+  def attachment(options = {})
     Paperclip::Attachment.new(:avatar, FakeModel.new, options)
   end
 
@@ -8,6 +8,6 @@ module TestData
   end
 
   def fixture_file(filename)
-    File.join(File.dirname(__FILE__), 'fixtures', filename)
+    File.join(File.dirname(__FILE__), "fixtures", filename)
   end
 end