kt-paperclip 5.4.0 → 6.2.0

data/spec/paperclip/url_generator_spec.rb

@@ -1,5 +1,4 @@
-# encoding: utf-8
-require 'spec_helper'
+require "spec_helper"
 
 describe Paperclip::UrlGenerator do
   it "uses the given interpolator" do
@@ -25,20 +24,20 @@ describe Paperclip::UrlGenerator do
     url_generator.for(:style_name, {})
 
     assert mock_interpolator.has_interpolated_pattern?(default_url),
-      "expected the interpolator to be passed #{default_url.inspect} but it wasn't"
+           "expected the interpolator to be passed #{default_url.inspect} but it wasn't"
   end
 
   it "executes the default URL lambda when no file is assigned" do
     mock_interpolator = MockInterpolator.new
-    default_url = lambda {|attachment| "the #{attachment.class.name} default url" }
-    options = { interpolator: mock_interpolator, default_url: default_url}
+    default_url = lambda { |attachment| "the #{attachment.class.name} default url" }
+    options = { interpolator: mock_interpolator, default_url: default_url }
     mock_attachment = MockAttachment.new(options)
 
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
     url_generator.for(:style_name, {})
 
     assert mock_interpolator.has_interpolated_pattern?("the MockAttachment default url"),
-      %{expected the interpolator to be passed "the MockAttachment default url", but it wasn't}
+           %{expected the interpolator to be passed "the MockAttachment default url", but it wasn't}
   end
 
   it "executes the method named by the symbol as the default URL when no file is assigned" do
@@ -56,7 +55,7 @@ describe Paperclip::UrlGenerator do
     url_generator.for(:style_name, {})
 
     assert mock_interpolator.has_interpolated_pattern?(mock_model.to_s),
-      %{expected the interpolator to be passed #{mock_model.to_s}, but it wasn't}
+           %{expected the interpolator to be passed #{mock_model}, but it wasn't}
   end
 
   it "URL-escapes spaces if asked to" do
@@ -66,7 +65,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {escape: true})
+    result = url_generator.for(:style_name, escape: true)
 
     assert_equal "the%20expected%20result", result
   end
@@ -82,7 +81,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {escape: true})
+    result = url_generator.for(:style_name, escape: true)
 
     assert_equal "the escaped result", result
   end
@@ -94,7 +93,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {escape: false})
+    result = url_generator.for(:style_name, escape: false)
 
     assert_equal "the expected result", result
   end
@@ -118,7 +117,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {timestamp: true})
+    result = url_generator.for(:style_name, timestamp: true)
 
     assert_equal expected, result
   end
@@ -134,7 +133,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {timestamp: true})
+    result = url_generator.for(:style_name, timestamp: true)
 
     assert_equal expected, result
   end
@@ -147,7 +146,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {timestamp: true})
+    result = url_generator.for(:style_name, timestamp: true)
 
     assert_equal "#{expected}?#{updated_at}", result
   end
@@ -160,7 +159,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {timestamp: true})
+    result = url_generator.for(:style_name, timestamp: true)
 
     assert_equal "#{expected}&#{updated_at}", result
   end
@@ -173,7 +172,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {timestamp: false})
+    result = url_generator.for(:style_name, timestamp: false)
 
     assert_equal expected, result
   end
@@ -192,21 +191,11 @@ describe Paperclip::UrlGenerator do
     url_generator.for(:style_name, {})
 
     assert mock_interpolator.has_interpolated_pattern?(expected),
-      "expected the interpolator to be passed #{expected.inspect} but it wasn't"
-  end
-
-  it "doesn't emit deprecation warnings" do
-    expected = "the expected result"
-    mock_interpolator = MockInterpolator.new(result: expected)
-    options = { interpolator: mock_interpolator }
-    mock_attachment = MockAttachment.new(options)
-    url_generator = Paperclip::UrlGenerator.new(mock_attachment)
-
-    expect { url_generator.for(:style_name, escape: true) }.to_not(output(/URI\.(un)?escape is obsolete/).to_stderr)
+           "expected the interpolator to be passed #{expected.inspect} but it wasn't"
   end
 
   describe "should be able to escape (, ), [, and ]." do
-    def generate(expected, updated_at=nil)
+    def generate(expected, updated_at = nil)
       mock_interpolator = MockInterpolator.new(result: expected)
       options = { interpolator: mock_interpolator, updated_at: updated_at }
       mock_attachment = MockAttachment.new(options)
@@ -214,7 +203,7 @@ describe Paperclip::UrlGenerator do
       def url_generator.respond_to(params)
         false if params == :escape
       end
-      url_generator.for(:style_name, {escape: true, timestamp: !!updated_at})
+      url_generator.for(:style_name, escape: true, timestamp: !!updated_at)
     end
 
     it "not timestamp" do
@@ -226,7 +215,7 @@ describe Paperclip::UrlGenerator do
       expected = "the(expected)result[]"
       updated_at = 1231231234
       assert_equal "the%28expected%29result%5B%5D?#{updated_at}",
-        generate(expected, updated_at)
+                   generate(expected, updated_at)
     end
   end
 end

data/spec/paperclip/validators/attachment_content_type_validator_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Paperclip::Validators::AttachmentContentTypeValidator do
   before do
@@ -8,14 +8,14 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
 
   def build_validator(options)
     @validator = Paperclip::Validators::AttachmentContentTypeValidator.new(options.merge(
-      attributes: :avatar
-    ))
+                                                                             attributes: :avatar
+                                                                           ))
   end
 
   context "with a nil content type" do
     before do
       build_validator content_type: "image/jpg"
-      @dummy.stubs(avatar_content_type: nil)
+      allow(@dummy).to receive_messages(avatar_content_type: nil)
       @validator.validate(@dummy)
     end
 
@@ -28,7 +28,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     context "as true" do
       before do
         build_validator content_type: "image/png", allow_nil: true
-        @dummy.stubs(avatar_content_type: nil)
+        allow(@dummy).to receive_messages(avatar_content_type: nil)
         @validator.validate(@dummy)
       end
 
@@ -40,7 +40,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     context "as false" do
       before do
         build_validator content_type: "image/png", allow_nil: false
-        @dummy.stubs(avatar_content_type: nil)
+        allow(@dummy).to receive_messages(avatar_content_type: nil)
         @validator.validate(@dummy)
       end
 
@@ -53,13 +53,13 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
   context "with a failing validation" do
     before do
       build_validator content_type: "image/png", allow_nil: false
-      @dummy.stubs(avatar_content_type: nil)
+      allow(@dummy).to receive_messages(avatar_content_type: nil)
       @validator.validate(@dummy)
     end
 
     it "adds error to the base object" do
       assert @dummy.errors[:avatar].present?,
-        "Error not added to base attribute"
+             "Error not added to base attribute"
     end
 
     it "adds error to base object as a string" do
@@ -70,13 +70,13 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
   context "with a successful validation" do
     before do
       build_validator content_type: "image/png", allow_nil: false
-      @dummy.stubs(avatar_content_type: "image/png")
+      allow(@dummy).to receive_messages(avatar_content_type: "image/png")
       @validator.validate(@dummy)
     end
 
     it "does not add error to the base object" do
       assert @dummy.errors[:avatar].blank?,
-        "Error was added to base attribute"
+             "Error was added to base attribute"
     end
   end
 
@@ -84,7 +84,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     context "as true" do
       before do
         build_validator content_type: "image/png", allow_blank: true
-        @dummy.stubs(avatar_content_type: "")
+        allow(@dummy).to receive_messages(avatar_content_type: "")
         @validator.validate(@dummy)
       end
 
@@ -96,7 +96,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     context "as false" do
       before do
         build_validator content_type: "image/png", allow_blank: false
-        @dummy.stubs(avatar_content_type: "")
+        allow(@dummy).to receive_messages(avatar_content_type: "")
         @validator.validate(@dummy)
       end
 
@@ -111,7 +111,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a string" do
         before do
           build_validator content_type: "image/jpg"
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -123,7 +123,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as an regexp" do
         before do
           build_validator content_type: /^image\/.*/
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -135,7 +135,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a list" do
         before do
           build_validator content_type: ["image/png", "image/jpg", "image/jpeg"]
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -149,7 +149,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a string" do
         before do
           build_validator content_type: "image/png"
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -162,7 +162,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a regexp" do
         before do
           build_validator content_type: /^text\/.*/
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -176,7 +176,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
         context "without interpolation" do
           before do
             build_validator content_type: "image/png", message: "should be a PNG image"
-            @dummy.stubs(avatar_content_type: "image/jpg")
+            allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
             @validator.validate(@dummy)
           end
 
@@ -188,7 +188,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
         context "with interpolation" do
           before do
             build_validator content_type: "image/png", message: "should have content type %{types}"
-            @dummy.stubs(avatar_content_type: "image/jpg")
+            allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
             @validator.validate(@dummy)
           end
 
@@ -205,7 +205,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a string" do
         before do
           build_validator not: "image/gif"
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -217,7 +217,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as an regexp" do
         before do
           build_validator not: /^text\/.*/
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -229,7 +229,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a list" do
         before do
           build_validator not: ["image/png", "image/jpg", "image/jpeg"]
-          @dummy.stubs(avatar_content_type: "image/gif")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/gif")
           @validator.validate(@dummy)
         end
 
@@ -243,7 +243,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a string" do
         before do
           build_validator not: "image/png"
-          @dummy.stubs(avatar_content_type: "image/png")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/png")
           @validator.validate(@dummy)
         end
 
@@ -256,7 +256,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a regexp" do
         before do
           build_validator not: /^text\/.*/
-          @dummy.stubs(avatar_content_type: "text/plain")
+          allow(@dummy).to receive_messages(avatar_content_type: "text/plain")
           @validator.validate(@dummy)
         end
 
@@ -270,7 +270,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
         context "without interpolation" do
           before do
             build_validator not: "image/png", message: "should not be a PNG image"
-            @dummy.stubs(avatar_content_type: "image/png")
+            allow(@dummy).to receive_messages(avatar_content_type: "image/png")
             @validator.validate(@dummy)
           end
 
@@ -282,7 +282,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
         context "with interpolation" do
           before do
             build_validator not: "image/png", message: "should not have content type %{types}"
-            @dummy.stubs(avatar_content_type: "image/png")
+            allow(@dummy).to receive_messages(avatar_content_type: "image/png")
             @validator.validate(@dummy)
           end
 
@@ -300,7 +300,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     end
 
     it "adds the validator to the class" do
-      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_content_type }
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_content_type }
     end
   end
 

data/spec/paperclip/validators/attachment_file_name_validator_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Paperclip::Validators::AttachmentFileNameValidator do
   before do
@@ -8,20 +8,20 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
 
   def build_validator(options)
     @validator = Paperclip::Validators::AttachmentFileNameValidator.new(options.merge(
-      attributes: :avatar
-    ))
+                                                                          attributes: :avatar
+                                                                        ))
   end
 
   context "with a failing validation" do
     before do
       build_validator matches: /.*\.png$/, allow_nil: false
-      @dummy.stubs(avatar_file_name: "data.txt")
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
       @validator.validate(@dummy)
     end
 
     it "adds error to the base object" do
       assert @dummy.errors[:avatar].present?,
-        "Error not added to base attribute"
+             "Error not added to base attribute"
     end
 
     it "adds error to base object as a string" do
@@ -31,7 +31,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
 
   it "does not add error to the base object with a successful validation" do
     build_validator matches: /.*\.png$/, allow_nil: false
-    @dummy.stubs(avatar_file_name: "image.png")
+    allow(@dummy).to receive_messages(avatar_file_name: "image.png")
     @validator.validate(@dummy)
 
     assert @dummy.errors[:avatar].blank?, "Error was added to base attribute"
@@ -42,7 +42,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
       context "as a single regexp" do
         before do
           build_validator matches: /.*\.jpg$/
-          @dummy.stubs(avatar_file_name: "image.jpg")
+          allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
           @validator.validate(@dummy)
         end
 
@@ -54,7 +54,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
       context "as a list" do
         before do
           build_validator matches: [/.*\.png$/, /.*\.jpe?g$/]
-          @dummy.stubs(avatar_file_name: "image.jpg")
+          allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
           @validator.validate(@dummy)
         end
 
@@ -67,7 +67,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
     context "with a disallowed type" do
       it "sets a correct default error message" do
         build_validator matches: /^text\/.*/
-        @dummy.stubs(avatar_file_name: "image.jpg")
+        allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
         @validator.validate(@dummy)
 
         assert @dummy.errors[:avatar_file_name].present?
@@ -76,7 +76,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
 
       it "sets a correct custom error message" do
         build_validator matches: /.*\.png$/, message: "should be a PNG image"
-        @dummy.stubs(avatar_file_name: "image.jpg")
+        allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
         @validator.validate(@dummy)
 
         expect(@dummy.errors[:avatar_file_name]).to include "should be a PNG image"
@@ -89,7 +89,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
       context "as a single regexp" do
         before do
           build_validator not: /^text\/.*/
-          @dummy.stubs(avatar_file_name: "image.jpg")
+          allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
           @validator.validate(@dummy)
         end
 
@@ -101,7 +101,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
       context "as a list" do
         before do
           build_validator not: [/.*\.png$/, /.*\.jpe?g$/]
-          @dummy.stubs(avatar_file_name: "image.gif")
+          allow(@dummy).to receive_messages(avatar_file_name: "image.gif")
           @validator.validate(@dummy)
         end
 
@@ -114,7 +114,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
     context "with a disallowed type" do
       it "sets a correct default error message" do
         build_validator not: /data.*/
-        @dummy.stubs(avatar_file_name: "data.txt")
+        allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
         @validator.validate(@dummy)
 
         assert @dummy.errors[:avatar_file_name].present?
@@ -123,7 +123,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
 
       it "sets a correct custom error message" do
         build_validator not: /.*\.png$/, message: "should not be a PNG image"
-        @dummy.stubs(avatar_file_name: "image.png")
+        allow(@dummy).to receive_messages(avatar_file_name: "image.png")
         @validator.validate(@dummy)
 
         expect(@dummy.errors[:avatar_file_name]).to include "should not be a PNG image"
@@ -137,7 +137,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
     end
 
     it "adds the validator to the class" do
-      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_file_name }
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_file_name }
     end
   end
 
@@ -157,4 +157,3 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
     end
   end
 end
-

data/spec/paperclip/validators/attachment_presence_validator_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Paperclip::Validators::AttachmentPresenceValidator do
   before do
@@ -6,10 +6,10 @@ describe Paperclip::Validators::AttachmentPresenceValidator do
     @dummy = Dummy.new
   end
 
-  def build_validator(options={})
+  def build_validator(options = {})
     @validator = Paperclip::Validators::AttachmentPresenceValidator.new(options.merge(
-      attributes: :avatar
-    ))
+                                                                          attributes: :avatar
+                                                                        ))
   end
 
   context "nil attachment" do
@@ -79,7 +79,7 @@ describe Paperclip::Validators::AttachmentPresenceValidator do
     end
 
     it "adds the validator to the class" do
-      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_presence }
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_presence }
     end
   end
 end

data/spec/paperclip/validators/attachment_size_validator_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Paperclip::Validators::AttachmentSizeValidator do
   before do
@@ -8,22 +8,22 @@ describe Paperclip::Validators::AttachmentSizeValidator do
 
   def build_validator(options)
     @validator = Paperclip::Validators::AttachmentSizeValidator.new(options.merge(
-      attributes: :avatar
-    ))
+                                                                      attributes: :avatar
+                                                                    ))
   end
 
   def self.should_allow_attachment_file_size(size)
     context "when the attachment size is #{size}" do
       it "adds error to dummy object" do
-        @dummy.stubs(:avatar_file_size).returns(size)
+        allow(@dummy).to receive(:avatar_content_type).and_return(size)
         @validator.validate(@dummy)
         assert @dummy.errors[:avatar_file_size].blank?,
-          "Expect an error message on :avatar_file_size, got none."
+               "Expect an error message on :avatar_file_size, got none."
       end
 
       it "does not add error to the base dummy object" do
         assert @dummy.errors[:avatar].blank?,
-          "Error added to base attribute"
+               "Error added to base attribute"
       end
     end
   end
@@ -31,18 +31,18 @@ describe Paperclip::Validators::AttachmentSizeValidator do
   def self.should_not_allow_attachment_file_size(size, options = {})
     context "when the attachment size is #{size}" do
       before do
-        @dummy.stubs(:avatar_file_size).returns(size)
+        allow(@dummy).to receive(:avatar_file_size).and_return(size)
         @validator.validate(@dummy)
       end
 
       it "adds error to dummy object" do
         assert @dummy.errors[:avatar_file_size].present?,
-          "Unexpected error message on :avatar_file_size"
+               "Unexpected error message on :avatar_file_size"
       end
 
       it "adds error to the base dummy object" do
         assert @dummy.errors[:avatar].present?,
-          "Error not added to base attribute"
+               "Error not added to base attribute"
       end
 
       it "adds error to base object as a string" do
@@ -70,7 +70,7 @@ describe Paperclip::Validators::AttachmentSizeValidator do
 
     context "as a proc" do
       before do
-        build_validator in: lambda { |avatar| (5.kilobytes..10.kilobytes) }
+        build_validator in: lambda { |_avatar| (5.kilobytes..10.kilobytes) }
       end
 
       should_allow_attachment_file_size(7.kilobytes)
@@ -91,7 +91,7 @@ describe Paperclip::Validators::AttachmentSizeValidator do
 
     context "as a proc" do
       before do
-        build_validator greater_than: lambda { |avatar| 10.kilobytes }
+        build_validator greater_than: lambda { |_avatar| 10.kilobytes }
       end
 
       should_allow_attachment_file_size 11.kilobytes
@@ -111,7 +111,7 @@ describe Paperclip::Validators::AttachmentSizeValidator do
 
     context "as a proc" do
       before do
-        build_validator less_than: lambda { |avatar| 10.kilobytes }
+        build_validator less_than: lambda { |_avatar| 10.kilobytes }
       end
 
       should_allow_attachment_file_size 9.kilobytes
@@ -123,7 +123,7 @@ describe Paperclip::Validators::AttachmentSizeValidator do
     context "as numbers" do
       before do
         build_validator greater_than: 5.kilobytes,
-          less_than: 10.kilobytes
+                        less_than: 10.kilobytes
       end
 
       should_allow_attachment_file_size 7.kilobytes
@@ -133,8 +133,8 @@ describe Paperclip::Validators::AttachmentSizeValidator do
 
     context "as a proc" do
       before do
-        build_validator greater_than: lambda { |avatar| 5.kilobytes },
-          less_than: lambda { |avatar| 10.kilobytes }
+        build_validator greater_than: lambda { |_avatar| 5.kilobytes },
+                        less_than: lambda { |_avatar| 10.kilobytes }
       end
 
       should_allow_attachment_file_size 7.kilobytes
@@ -147,7 +147,7 @@ describe Paperclip::Validators::AttachmentSizeValidator do
     context "given a range" do
       before do
         build_validator in: (5.kilobytes..10.kilobytes),
-          message: "is invalid. (Between %{min} and %{max} please.)"
+                        message: "is invalid. (Between %{min} and %{max} please.)"
       end
 
       should_not_allow_attachment_file_size(
@@ -159,8 +159,8 @@ describe Paperclip::Validators::AttachmentSizeValidator do
     context "given :less_than and :greater_than" do
       before do
         build_validator less_than: 10.kilobytes,
-          greater_than: 5.kilobytes,
-          message: "is invalid. (Between %{min} and %{max} please.)"
+                        greater_than: 5.kilobytes,
+                        message: "is invalid. (Between %{min} and %{max} please.)"
       end
 
       should_not_allow_attachment_file_size(
@@ -174,7 +174,7 @@ describe Paperclip::Validators::AttachmentSizeValidator do
     context "given :less_than and :greater_than" do
       before do
         build_validator greater_than: 5.kilobytes,
-          less_than: 10.kilobytes
+                        less_than: 10.kilobytes
       end
 
       should_not_allow_attachment_file_size(
@@ -211,7 +211,7 @@ describe Paperclip::Validators::AttachmentSizeValidator do
     end
 
     it "adds the validator to the class" do
-      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_size }
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_size }
     end
   end
 
@@ -222,7 +222,7 @@ describe Paperclip::Validators::AttachmentSizeValidator do
       end
     end
 
-    (Paperclip::Validators::AttachmentSizeValidator::AVAILABLE_CHECKS).each do |argument|
+    Paperclip::Validators::AttachmentSizeValidator::AVAILABLE_CHECKS.each do |argument|
       it "does not raise arguemnt error if #{argument} was given" do
         build_validator argument => 5.kilobytes
       end