kreuzberg 4.0.0.rc2 → 4.0.0

data/spec/unit/config/language_detection_config_spec.rb

@@ -0,0 +1,258 @@
+# frozen_string_literal: true
+
+RSpec.describe Kreuzberg::Config::LanguageDetection do
+  describe '#initialize' do
+    it 'creates config with default values' do
+      config = described_class.new
+
+      expect(config.enabled).to be false
+      expect(config.min_confidence).to eq 0.5
+      expect(config.detect_multiple).to be false
+    end
+
+    it 'creates config with custom values' do
+      config = described_class.new(
+        enabled: true,
+        min_confidence: 0.9,
+        detect_multiple: true
+      )
+
+      expect(config.enabled).to be true
+      expect(config.min_confidence).to eq 0.9
+      expect(config.detect_multiple).to be true
+    end
+
+    it 'converts enabled to boolean' do
+      config = described_class.new(enabled: 1)
+
+      expect(config.enabled).to be true
+      expect(config.enabled).to be_a TrueClass
+    end
+
+    it 'converts min_confidence to float' do
+      config = described_class.new(min_confidence: '0.75')
+
+      expect(config.min_confidence).to eq 0.75
+      expect(config.min_confidence).to be_a Float
+    end
+
+    it 'converts detect_multiple to boolean' do
+      config = described_class.new(detect_multiple: 'yes')
+
+      expect(config.detect_multiple).to be true
+    end
+  end
+
+  describe '#to_h' do
+    it 'serializes to hash with all values' do
+      config = described_class.new(
+        enabled: true,
+        min_confidence: 0.8,
+        detect_multiple: true
+      )
+      hash = config.to_h
+
+      expect(hash).to be_a Hash
+      expect(hash[:enabled]).to be true
+      expect(hash[:min_confidence]).to eq 0.8
+      expect(hash[:detect_multiple]).to be true
+    end
+
+    it 'always includes all keys in hash' do
+      config = described_class.new
+      hash = config.to_h
+
+      expect(hash.keys).to contain_exactly(
+        :enabled,
+        :min_confidence,
+        :detect_multiple
+      )
+    end
+  end
+
+  describe 'validation' do
+    it 'accepts confidence value of 0.5' do
+      expect do
+        described_class.new(min_confidence: 0.5)
+      end.not_to raise_error
+    end
+
+    it 'accepts confidence value of 0.0' do
+      expect do
+        described_class.new(min_confidence: 0.0)
+      end.not_to raise_error
+    end
+
+    it 'accepts confidence value of 1.0' do
+      expect do
+        described_class.new(min_confidence: 1.0)
+      end.not_to raise_error
+    end
+
+    it 'accepts boolean enabled' do
+      expect do
+        described_class.new(enabled: true)
+      end.not_to raise_error
+    end
+  end
+
+  describe 'keyword arguments' do
+    it 'accepts all keyword arguments' do
+      config = described_class.new(
+        enabled: true,
+        min_confidence: 0.85,
+        detect_multiple: true
+      )
+
+      expect(config.enabled).to be true
+      expect(config.min_confidence).to eq 0.85
+      expect(config.detect_multiple).to be true
+    end
+  end
+
+  describe 'equality' do
+    it 'compares configs by value' do
+      config1 = described_class.new(
+        enabled: true,
+        min_confidence: 0.8
+      )
+      config2 = described_class.new(
+        enabled: true,
+        min_confidence: 0.8
+      )
+
+      expect(config1.enabled).to eq config2.enabled
+      expect(config1.min_confidence).to eq config2.min_confidence
+    end
+
+    it 'detects differences in enabled' do
+      config1 = described_class.new(enabled: true)
+      config2 = described_class.new(enabled: false)
+
+      expect(config1.enabled).not_to eq config2.enabled
+    end
+
+    it 'detects differences in min_confidence' do
+      config1 = described_class.new(min_confidence: 0.5)
+      config2 = described_class.new(min_confidence: 0.9)
+
+      expect(config1.min_confidence).not_to eq config2.min_confidence
+    end
+
+    it 'detects differences in detect_multiple' do
+      config1 = described_class.new(detect_multiple: true)
+      config2 = described_class.new(detect_multiple: false)
+
+      expect(config1.detect_multiple).not_to eq config2.detect_multiple
+    end
+  end
+
+  describe 'nested config integration' do
+    it 'can be nested in Extraction config' do
+      lang_detect = described_class.new(enabled: true, min_confidence: 0.9)
+      extraction = Kreuzberg::Config::Extraction.new(language_detection: lang_detect)
+
+      expect(extraction.language_detection).to be_a described_class
+      expect(extraction.language_detection.enabled).to be true
+      expect(extraction.language_detection.min_confidence).to eq 0.9
+    end
+
+    it 'accepts hash in Extraction config' do
+      extraction = Kreuzberg::Config::Extraction.new(
+        language_detection: { enabled: true, min_confidence: 0.75 }
+      )
+
+      expect(extraction.language_detection).to be_a described_class
+      expect(extraction.language_detection.enabled).to be true
+      expect(extraction.language_detection.min_confidence).to eq 0.75
+    end
+  end
+
+  describe 'symbol vs string key handling' do
+    it 'accepts symbol and string enabled values' do
+      config = described_class.new(enabled: true)
+
+      expect(config.enabled).to be true
+    end
+
+    it 'converts min_confidence string to float' do
+      config = described_class.new(min_confidence: '0.95')
+
+      expect(config.min_confidence).to eq 0.95
+      expect(config.min_confidence).to be_a Float
+    end
+  end
+
+  describe 'boolean conversion' do
+    it 'converts truthy enabled to true' do
+      config = described_class.new(enabled: 1)
+
+      expect(config.enabled).to be true
+    end
+
+    it 'converts false enabled to false' do
+      config = described_class.new(enabled: false)
+
+      expect(config.enabled).to be false
+    end
+
+    it 'converts truthy detect_multiple to true' do
+      config = described_class.new(detect_multiple: 'yes')
+
+      expect(config.detect_multiple).to be true
+    end
+
+    it 'converts false detect_multiple to false' do
+      config = described_class.new(detect_multiple: false)
+
+      expect(config.detect_multiple).to be false
+    end
+  end
+
+  describe 'confidence range' do
+    it 'accepts minimum confidence value' do
+      config = described_class.new(min_confidence: 0.0)
+
+      expect(config.min_confidence).to eq 0.0
+    end
+
+    it 'accepts maximum confidence value' do
+      config = described_class.new(min_confidence: 1.0)
+
+      expect(config.min_confidence).to eq 1.0
+    end
+
+    it 'accepts mid-range confidence value' do
+      config = described_class.new(min_confidence: 0.6)
+
+      expect(config.min_confidence).to eq 0.6
+    end
+
+    it 'preserves high precision confidence values' do
+      config = described_class.new(min_confidence: 0.123456)
+
+      expect(config.min_confidence).to be_within(0.00001).of(0.123456)
+    end
+  end
+
+  describe 'multiple language detection' do
+    it 'allows enabling multiple language detection' do
+      config = described_class.new(detect_multiple: true)
+
+      expect(config.detect_multiple).to be true
+    end
+
+    it 'defaults to single language detection' do
+      config = described_class.new
+
+      expect(config.detect_multiple).to be false
+    end
+
+    it 'can be disabled when enabled is true' do
+      config = described_class.new(enabled: true, detect_multiple: false)
+
+      expect(config.enabled).to be true
+      expect(config.detect_multiple).to be false
+    end
+  end
+end

data/spec/unit/config/ocr_config_spec.rb

@@ -0,0 +1,171 @@
+# frozen_string_literal: true
+
+RSpec.describe Kreuzberg::Config::OCR do
+  describe '#initialize' do
+    it 'creates config with default values' do
+      config = described_class.new
+
+      expect(config.backend).to eq 'tesseract'
+      expect(config.language).to eq 'eng'
+      expect(config.tesseract_config).to be_nil
+    end
+
+    it 'creates config with custom string values' do
+      config = described_class.new(
+        backend: 'easyocr',
+        language: 'fra'
+      )
+
+      expect(config.backend).to eq 'easyocr'
+      expect(config.language).to eq 'fra'
+    end
+
+    it 'converts symbol keys to strings' do
+      config = described_class.new(backend: :tesseract, language: :deu)
+
+      expect(config.backend).to eq 'tesseract'
+      expect(config.language).to eq 'deu'
+    end
+
+    it 'accepts tesseract_config as instance' do
+      tesseract = Kreuzberg::Config::Tesseract.new(options: 'value')
+      config = described_class.new(tesseract_config: tesseract)
+
+      expect(config.tesseract_config).to be_a Kreuzberg::Config::Tesseract
+    end
+
+    it 'converts tesseract_config hash to instance' do
+      config = described_class.new(tesseract_config: { option: 'value' })
+
+      expect(config.tesseract_config).to be_a Kreuzberg::Config::Tesseract
+    end
+  end
+
+  describe '#to_h' do
+    it 'serializes to hash with default values' do
+      config = described_class.new
+      hash = config.to_h
+
+      expect(hash).to be_a Hash
+      expect(hash[:backend]).to eq 'tesseract'
+      expect(hash[:language]).to eq 'eng'
+      expect(hash[:tesseract_config]).to be_nil
+    end
+
+    it 'includes tesseract_config in hash when present' do
+      config = described_class.new(
+        backend: 'tesseract',
+        tesseract_config: { dpi: 300 }
+      )
+      hash = config.to_h
+
+      expect(hash[:tesseract_config]).to be_a Hash
+    end
+
+    it 'compacts nil values from hash' do
+      config = described_class.new(backend: 'tesseract')
+      hash = config.to_h
+
+      expect(hash.key?(:tesseract_config)).to be false
+    end
+  end
+
+  describe 'validation' do
+    it 'accepts valid backends' do
+      expect do
+        described_class.new(backend: 'tesseract')
+      end.not_to raise_error
+    end
+
+    it 'accepts symbol language' do
+      expect do
+        described_class.new(language: :fra)
+      end.not_to raise_error
+    end
+
+    it 'raises error for invalid tesseract_config type' do
+      expect do
+        described_class.new(tesseract_config: 'invalid')
+      end.to raise_error ArgumentError, /Expected.*Tesseract.*Hash.*nil/
+    end
+  end
+
+  describe 'keyword arguments' do
+    it 'accepts keyword arguments only' do
+      config = described_class.new(backend: 'tesseract', language: 'eng')
+
+      expect(config.backend).to eq 'tesseract'
+      expect(config.language).to eq 'eng'
+    end
+
+    it 'ignores unknown keywords gracefully' do
+      # This test documents current behavior
+      # The initialize method doesn't explicitly reject unknown keys
+      config = described_class.new(backend: 'tesseract')
+      expect(config).to be_a described_class
+    end
+  end
+
+  describe 'equality' do
+    it 'compares configs by value' do
+      config1 = described_class.new(backend: 'tesseract', language: 'eng')
+      config2 = described_class.new(backend: 'tesseract', language: 'eng')
+
+      expect(config1.backend).to eq config2.backend
+      expect(config1.language).to eq config2.language
+    end
+
+    it 'detects differences in backend' do
+      config1 = described_class.new(backend: 'tesseract')
+      config2 = described_class.new(backend: 'easyocr')
+
+      expect(config1.backend).not_to eq config2.backend
+    end
+
+    it 'detects differences in language' do
+      config1 = described_class.new(language: 'eng')
+      config2 = described_class.new(language: 'fra')
+
+      expect(config1.language).not_to eq config2.language
+    end
+  end
+
+  describe 'nested config integration' do
+    it 'integrates with Extraction config' do
+      ocr_config = described_class.new(backend: 'tesseract', language: 'deu')
+      extraction = Kreuzberg::Config::Extraction.new(ocr: ocr_config)
+
+      expect(extraction.ocr).to be_a described_class
+      expect(extraction.ocr.backend).to eq 'tesseract'
+      expect(extraction.ocr.language).to eq 'deu'
+    end
+
+    it 'accepts hash in Extraction config and converts to instance' do
+      extraction = Kreuzberg::Config::Extraction.new(
+        ocr: { backend: 'easyocr', language: 'fra' }
+      )
+
+      expect(extraction.ocr).to be_a described_class
+      expect(extraction.ocr.backend).to eq 'easyocr'
+    end
+  end
+
+  describe 'symbol vs string key handling' do
+    it 'converts symbol keys to correct attributes' do
+      config = described_class.new(backend: :tesseract, language: :fra)
+
+      expect(config.backend).to eq 'tesseract'
+      expect(config.language).to eq 'fra'
+    end
+
+    it 'handles mixed symbol and string values' do
+      config = described_class.new(
+        backend: 'tesseract',
+        language: :eng
+      )
+
+      expect(config.backend).to eq 'tesseract'
+      expect(config.language).to eq 'eng'
+    end
+  end
+end

data/spec/unit/config/page_config_spec.rb

@@ -0,0 +1,221 @@
+# frozen_string_literal: true
+
+RSpec.describe Kreuzberg::Config::PageConfig do
+  describe '#initialize' do
+    it 'creates config with default values' do
+      config = described_class.new
+
+      expect(config.extract_pages).to be false
+      expect(config.insert_page_markers).to be false
+      expect(config.marker_format).to eq "\n\n<!-- PAGE {page_num} -->\n\n"
+    end
+
+    it 'creates config with custom values' do
+      config = described_class.new(
+        extract_pages: true,
+        insert_page_markers: true,
+        marker_format: '--- PAGE {page_num} ---'
+      )
+
+      expect(config.extract_pages).to be true
+      expect(config.insert_page_markers).to be true
+      expect(config.marker_format).to eq '--- PAGE {page_num} ---'
+    end
+
+    it 'converts boolean values' do
+      config = described_class.new(
+        extract_pages: true,
+        insert_page_markers: false
+      )
+
+      expect(config.extract_pages).to be true
+      expect(config.insert_page_markers).to be false
+    end
+
+    it 'converts marker_format to string' do
+      config = described_class.new(marker_format: :default)
+
+      expect(config.marker_format).to be_a String
+    end
+  end
+
+  describe '#to_h' do
+    it 'serializes to hash with all values' do
+      config = described_class.new(extract_pages: true)
+      hash = config.to_h
+
+      expect(hash).to be_a Hash
+      expect(hash[:extract_pages]).to be true
+      expect(hash[:insert_page_markers]).to be false
+      expect(hash[:marker_format]).to eq "\n\n<!-- PAGE {page_num} -->\n\n"
+    end
+
+    it 'always includes all keys in hash' do
+      config = described_class.new
+      hash = config.to_h
+
+      expect(hash.keys).to contain_exactly(
+        :extract_pages,
+        :insert_page_markers,
+        :marker_format
+      )
+    end
+  end
+
+  describe 'validation' do
+    it 'accepts boolean extract_pages' do
+      expect do
+        described_class.new(extract_pages: true)
+      end.not_to raise_error
+    end
+
+    it 'accepts boolean insert_page_markers' do
+      expect do
+        described_class.new(insert_page_markers: true)
+      end.not_to raise_error
+    end
+
+    it 'accepts custom marker formats' do
+      expect do
+        described_class.new(marker_format: '===== PAGE {page_num} =====')
+      end.not_to raise_error
+    end
+  end
+
+  describe 'keyword arguments' do
+    it 'accepts all keyword arguments' do
+      config = described_class.new(
+        extract_pages: true,
+        insert_page_markers: true,
+        marker_format: 'Page: {page_num}'
+      )
+
+      expect(config.extract_pages).to be true
+      expect(config.insert_page_markers).to be true
+      expect(config.marker_format).to eq 'Page: {page_num}'
+    end
+  end
+
+  describe 'equality' do
+    it 'compares configs by value' do
+      config1 = described_class.new(
+        extract_pages: true,
+        insert_page_markers: true,
+        marker_format: '--- PAGE {page_num} ---'
+      )
+      config2 = described_class.new(
+        extract_pages: true,
+        insert_page_markers: true,
+        marker_format: '--- PAGE {page_num} ---'
+      )
+
+      expect(config1.extract_pages).to eq config2.extract_pages
+      expect(config1.insert_page_markers).to eq config2.insert_page_markers
+      expect(config1.marker_format).to eq config2.marker_format
+    end
+
+    it 'detects differences in extract_pages' do
+      config1 = described_class.new(extract_pages: true)
+      config2 = described_class.new(extract_pages: false)
+
+      expect(config1.extract_pages).not_to eq config2.extract_pages
+    end
+
+    it 'detects differences in marker_format' do
+      config1 = described_class.new(marker_format: 'Format A')
+      config2 = described_class.new(marker_format: 'Format B')
+
+      expect(config1.marker_format).not_to eq config2.marker_format
+    end
+  end
+
+  describe 'nested config integration' do
+    it 'can be nested in Extraction config' do
+      pages = described_class.new(extract_pages: true)
+      extraction = Kreuzberg::Config::Extraction.new(pages: pages)
+
+      expect(extraction.pages).to be_a described_class
+      expect(extraction.pages.extract_pages).to be true
+    end
+
+    it 'accepts hash in Extraction config' do
+      extraction = Kreuzberg::Config::Extraction.new(
+        pages: { extract_pages: true, insert_page_markers: true }
+      )
+
+      expect(extraction.pages).to be_a described_class
+      expect(extraction.pages.extract_pages).to be true
+      expect(extraction.pages.insert_page_markers).to be true
+    end
+  end
+
+  describe 'marker format' do
+    it 'preserves custom marker format' do
+      format = '=== PAGE {page_num} ==='
+      config = described_class.new(marker_format: format)
+
+      expect(config.marker_format).to eq format
+    end
+
+    it 'preserves default marker format' do
+      config = described_class.new
+
+      expect(config.marker_format).to include '{page_num}'
+    end
+
+    it 'allows empty marker format' do
+      config = described_class.new(marker_format: '')
+
+      expect(config.marker_format).to eq ''
+    end
+
+    it 'handles multiline marker formats' do
+      format = "\n--- PAGE {page_num} ---\n"
+      config = described_class.new(marker_format: format)
+
+      expect(config.marker_format).to eq format
+    end
+  end
+
+  describe 'symbol vs string key handling' do
+    it 'converts symbol values to strings' do
+      config = described_class.new(marker_format: :default_format)
+
+      expect(config.marker_format).to be_a String
+    end
+
+    it 'preserves string marker format' do
+      format = 'Custom Format'
+      config = described_class.new(marker_format: format)
+
+      expect(config.marker_format).to eq format
+      expect(config.marker_format).to be_a String
+    end
+  end
+
+  describe 'boolean conversion' do
+    it 'converts truthy extract_pages to true' do
+      config = described_class.new(extract_pages: 1)
+
+      expect(config.extract_pages).to be true
+    end
+
+    it 'converts false extract_pages to false' do
+      config = described_class.new(extract_pages: false)
+
+      expect(config.extract_pages).to be false
+    end
+
+    it 'converts truthy insert_page_markers to true' do
+      config = described_class.new(insert_page_markers: 'yes')
+
+      expect(config.insert_page_markers).to be true
+    end
+
+    it 'converts false insert_page_markers to false' do
+      config = described_class.new(insert_page_markers: false)
+
+      expect(config.insert_page_markers).to be false
+    end
+  end
+end