kpm 0.7.2 → 0.10.0

data/spec/kpm/unit/os_information_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'kpm/system_helpers/system_proxy'
+require 'kpm/system_helpers/os_information'
+
+describe KPM::SystemProxy::OsInformation do
+  subject { described_class.new }
+  let(:os_data) { subject.send(:build_hash, data) }
+
+  context 'when running on Linux' do
+    let(:data) { "Description:Ubuntu 16.04.1 LTS \n\n" }
+
+    it {
+      expect(subject.labels).to eq([{ label: :os_detail },
+                                    { label: :value }])
+    }
+
+    it {
+      expect(os_data).to eq({ 'Description' => { :os_detail => 'Description', :value => 'Ubuntu 16.04.1 LTS' } })
+    }
+  end
+
+  context 'when running on MacOS' do
+    let(:data) { "ProductName:\tMac OS X\nProductVersion:\t10.14.6\nBuildVersion:\t18G87\n" }
+
+    it {
+      expect(subject.labels).to eq([{ label: :os_detail },
+                                    { label: :value }])
+    }
+
+    it {
+      expect(os_data).to eq({ 'ProductName' => { :os_detail => 'ProductName', :value => 'Mac OS X' },
+                              'ProductVersion' => { :os_detail => 'ProductVersion', :value => '10.14.6' },
+                              'BuildVersion' => { :os_detail => 'BuildVersion', :value => '18G87' } })
+    }
+  end
+end

data/spec/kpm/unit/plugins_directory_spec.rb

@@ -1,36 +1,52 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::PluginsDirectory do
-
   it 'should parse the plugins directory' do
     directory = KPM::PluginsDirectory.all(false)
-    directory.size.should > 0
+    expect(directory.size).to be > 0
   end
 
-
   it 'should lookup plugins' do
-    group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.14')
-    group_id.should == 'org.kill-bill.billing.plugin.java'
-    artifact_id.should == 'analytics-plugin'
-    packaging.should == 'jar'
-    classifier.should be_nil
-    version.should == '1.0.3'
-    type.should == :java
+    group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.20.11')
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq '6.0.1'
+    expect(type).to eq :java
+
+    group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.20.11-SNAPSHOT')
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq '6.0.1'
+    expect(type).to eq :java
+
+    group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.20')
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq '6.0.1'
+    expect(type).to eq :java
 
     group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, 'LATEST')
-    group_id.should == 'org.kill-bill.billing.plugin.java'
-    artifact_id.should == 'analytics-plugin'
-    packaging.should == 'jar'
-    classifier.should be_nil
-    version.should == 'LATEST'
-    type.should == :java
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq 'LATEST'
+    expect(type).to eq :java
 
     group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.42')
-    group_id.should == 'org.kill-bill.billing.plugin.java'
-    artifact_id.should == 'analytics-plugin'
-    packaging.should == 'jar'
-    classifier.should be_nil
-    version.should == 'LATEST'
-    type.should == :java
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq 'LATEST'
+    expect(type).to eq :java
   end
 end

data/spec/kpm/unit/plugins_manager_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::PluginsManager do
-
   before(:each) do
     logger = Logger.new(STDOUT)
     logger.level = Logger::INFO
@@ -14,7 +15,7 @@ describe KPM::PluginsManager do
     FileUtils.mkdir_p(@plugin_dir.join('1.0.0'))
     FileUtils.mkdir_p(@plugin_dir.join('2.0.0'))
 
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_false
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_falsey
   end
 
   after(:each) do
@@ -24,133 +25,128 @@ describe KPM::PluginsManager do
   it 'creates a plugin identifier entry with no coordinate' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('foo', 'foo_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['foo']['plugin_name'].should == 'foo_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
   end
 
   it 'creates a plugin identifier entry with coordinates' do
     # Verifies file gets created if does not exist
-    coordinate_map = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version'}
+    coordinate_map = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map)
-    identifiers.size.should == 1
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['bar']['group_id'].should == 'group'
-    identifiers['bar']['artifact_id'].should == 'artifact'
-    identifiers['bar']['packaging'].should == 'packaging'
-    identifiers['bar']['classifier'].should == nil
-    identifiers['bar']['version'].should == 'version'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['group_id']).to eq 'group'
+    expect(identifiers['bar']['artifact_id']).to eq 'artifact'
+    expect(identifiers['bar']['packaging']).to eq 'packaging'
+    expect(identifiers['bar']['classifier']).to be_nil
+    expect(identifiers['bar']['version']).to eq 'version'
   end
 
-
   it 'creates plugin identifier with multiple entries' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('foo', 'foo_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['foo']['plugin_name'].should == 'foo_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
 
     # Verify file was created from previous entry (prev value was read)
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', nil)
-    identifiers.size.should == 2
-    identifiers['foo']['plugin_name'].should == 'foo_name'
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-
+    expect(identifiers.size).to eq 2
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
 
     # Verify file was created from previous entry (prev value was read)
     identifiers = @manager.add_plugin_identifier_key('zoe', 'zoe_name', 'type', nil)
-    identifiers.size.should == 3
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['foo']['plugin_name'].should == 'foo_name'
-    identifiers['zoe']['plugin_name'].should == 'zoe_name'
+    expect(identifiers.size).to eq 3
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
+    expect(identifiers['zoe']['plugin_name']).to eq 'zoe_name'
   end
 
   it 'creates plugin identifiers with duplicate entries' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('kewl', 'kewl_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['kewl']['plugin_name'].should == 'kewl_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['kewl']['plugin_name']).to eq 'kewl_name'
 
     # Add with a different plugin_name
     identifiers = @manager.add_plugin_identifier_key('kewl', 'kewl_name2', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['kewl']['plugin_name'].should == 'kewl_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['kewl']['plugin_name']).to eq 'kewl_name'
   end
 
-
   it 'creates plugin identifiers and remove entry' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('lol', 'lol_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['lol']['plugin_name'].should == 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
 
     # Remove wrong entry, nothing happens
     identifiers = @manager.remove_plugin_identifier_key('lol2')
-    identifiers.size.should == 1
-    identifiers['lol']['plugin_name'].should == 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
 
     # Remove correct entry
     identifiers = @manager.remove_plugin_identifier_key('lol')
-    identifiers.size.should == 0
+    expect(identifiers.size).to eq 0
 
     # Add same entry again
     identifiers = @manager.add_plugin_identifier_key('lol', 'lol_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['lol']['plugin_name'].should == 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
   end
 
   it 'creates plugin identifiers and validate entry' do
     # Verifies file gets created if does not exist
-    coordinate_map = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version'}
+    coordinate_map = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
 
-    identifiers = @manager.add_plugin_identifier_key('yoyo', 'yoyo_name', 'type',  coordinate_map)
-    identifiers.size.should == 1
-    identifiers['yoyo']['plugin_name'].should == 'yoyo_name'
+    identifiers = @manager.add_plugin_identifier_key('yoyo', 'yoyo_name', 'type', coordinate_map)
+    expect(identifiers.size).to eq 1
+    expect(identifiers['yoyo']['plugin_name']).to eq 'yoyo_name'
 
-    @manager.validate_plugin_identifier_key('yoyo', coordinate_map).should == true
+    expect(@manager.validate_plugin_identifier_key('yoyo', coordinate_map)).to eq true
 
     # Negative validation
-    invalid_coordinate_map = {:group_id => 'group1', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version'}
+    invalid_coordinate_map = { group_id: 'group1', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
 
-    @manager.validate_plugin_identifier_key('yoyo', invalid_coordinate_map).should == false
+    expect(@manager.validate_plugin_identifier_key('yoyo', invalid_coordinate_map)).to eq false
   end
 
-
   it 'creates a plugin identifier entry with a new version' do
     # Verifies file gets created if does not exist
 
-    coordinate_map1 = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version1'}
+    coordinate_map1 = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version1' }
 
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map1)
-    identifiers.size.should == 1
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['bar']['version'].should == 'version1'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['version']).to eq 'version1'
 
-    coordinate_map2 = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version2'}
+    coordinate_map2 = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version2' }
 
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map2)
-    identifiers.size.should == 1
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['bar']['version'].should == 'version2'
-
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['version']).to eq 'version2'
   end
 
   it 'sets a path as active' do
     @manager.set_active(@plugin_dir.join('1.0.0'))
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('1.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('1.0.0').to_s
 
     @manager.set_active(@plugin_dir.join('2.0.0'))
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('2.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('2.0.0').to_s
   end
 
   it 'sets a plugin version as active' do
     @manager.set_active('killbill-stripe', '2.0.0')
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('2.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('2.0.0').to_s
 
     @manager.set_active('killbill-stripe', '1.0.0')
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('1.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('1.0.0').to_s
   end
 
   it 'uninstalls a plugin via a path' do
@@ -194,19 +190,19 @@ describe KPM::PluginsManager do
   end
 
   it 'guesses the plugin name' do
-    @manager.guess_plugin_name('tripe').should be_nil
+    expect(@manager.guess_plugin_name('tripe')).to be_nil
     # Short name
-    @manager.guess_plugin_name('stripe').should == 'killbill-stripe'
+    expect(@manager.guess_plugin_name('stripe')).to eq 'killbill-stripe'
     # Artifact id
-    @manager.guess_plugin_name('stripe-plugin').should == 'killbill-stripe'
+    expect(@manager.guess_plugin_name('stripe-plugin')).to eq 'killbill-stripe'
     # Plugin name (top directory in the .tar.gz)
-    @manager.guess_plugin_name('killbill-stripe').should == 'killbill-stripe'
+    expect(@manager.guess_plugin_name('killbill-stripe')).to eq 'killbill-stripe'
   end
 
   private
 
   def check_state(version, has_restart, has_disabled)
-    File.exists?(@plugin_dir.join(version).join('tmp').join('restart.txt')).should == has_restart
-    File.exists?(@plugin_dir.join(version).join('tmp').join('disabled.txt')).should == has_disabled
+    expect(File.exist?(@plugin_dir.join(version).join('tmp').join('restart.txt'))).to eq has_restart
+    expect(File.exist?(@plugin_dir.join(version).join('tmp').join('disabled.txt'))).to eq has_disabled
   end
 end

data/spec/kpm/unit/sha1_checker_spec.rb

@@ -1,103 +1,150 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::Sha1Checker do
+  let(:tmp_dir) { Dir.mktmpdir('sha1_checker_spec') }
+  let(:sha1_file) { File.join(tmp_dir, 'sha1.yml') }
+  let(:sha1_checker) { KPM::Sha1Checker.from_file(sha1_file) }
+  let(:sha1_content) do
+    {
+      'sha1' => { 'org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0' => 'fce068c3fd5f95646ce0d09852f43ff67f06f0b9',
+                  'org.kill-bill.billing.plugin.ruby:killbill-plugin-nomatch:tar.gz:1.0.0' => 'ace068c3fd5f95646ce0d09852f43ff67f06f0b8',
+                  'org.kill-bill.billing.plugin.ruby:killbill-plugin-other:tar.gz:1.0.0' => 'bbb068c3fd5f95646ce0d09852f43ff67f06fccc' },
+      'nexus' => { 'org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0' => { :sha1 => 'fce068c3fd5f95646ce0d09852f43ff67f06f0b9',
+                                                                                               :version => '1.0.0',
+                                                                                               :repository_path => '/org/kill-bill/billing/plugin/ruby/killbill-plugin-match/1.0.0/killbill-plugin-match-1.0.0.tar.gz',
+                                                                                               :is_tgz => true },
+                   'org.kill-bill.billing.plugin.ruby:killbill-plugin-nomatch:tar.gz:1.0.0' => { :sha1 => 'ace068c3fd5f95646ce0d09852f43ff67f06f0b8',
+                                                                                                 :version => '1.0.0',
+                                                                                                 :repository_path => '/org/kill-bill/billing/plugin/ruby/killbill-plugin-nomatch/1.0.0/killbill-plugin-nomatch-1.0.0.tar.gz',
+                                                                                                 :is_tgz => true },
+                   'org.kill-bill.billing.plugin.ruby:killbill-plugin-other:tar.gz:1.0.0' => { :sha1 => 'bbb068c3fd5f95646ce0d09852f43ff67f06fccc',
+                                                                                               :version => '1.0.0',
+                                                                                               :repository_path => '/org/kill-bill/billing/plugin/ruby/killbill-plugin-other/1.0.0/killbill-plugin-other-1.0.0.tar.gz',
+                                                                                               :is_tgz => true } },
+      'killbill' => { '0.20.10' => { 'killbill' => '0.20.10', 'killbill-oss-parent' => '0.142.7', 'killbill-api' => '0.52.0', 'killbill-plugin-api' => '0.25.0', 'killbill-commons' => '0.22.3', 'killbill-platform' => '0.38.3' },
+                      '0.20.12' => { 'killbill' => '0.20.12', 'killbill-oss-parent' => '0.142.7', 'killbill-api' => '0.52.0', 'killbill-plugin-api' => '0.25.0', 'killbill-commons' => '0.22.3', 'killbill-platform' => '0.38.3' },
+                      '0.18.5' => { 'killbill' => '0.18.5', 'killbill-oss-parent' => '0.140.18', 'killbill-api' => '0.50.1', 'killbill-plugin-api' => '0.23.1', 'killbill-commons' => '0.20.5', 'killbill-platform' => '0.36.5' } }
+    }
+  end
 
-  before(:all) do
-    @logger = Logger.new(STDOUT)
-    @logger.level = Logger::INFO
-
-    tmp_destination_dir = Dir.tmpdir()
-    init_config = File.join(File.dirname(__FILE__), 'sha1_test.yml')
-    FileUtils.copy(init_config, tmp_destination_dir)
-    @tmp_config = File.join(tmp_destination_dir, 'sha1_test.yml')
-    @sha1_checker = KPM::Sha1Checker.from_file(@tmp_config)
+  before do
+    File.open(sha1_file.to_s, 'w') { |l| l.puts(sha1_content.to_yaml) }
   end
 
   it 'should create intermediate directories' do
     Dir.mktmpdir do |dir|
-      config = File.join(dir, 'foo', 'bar', 'baz', 'sha1_test.yml')
+      config = File.join(dir, 'foo', 'bar', 'baz', 'sha1.yml')
+      expect(File.exist?(config)).to be_falsey
       KPM::Sha1Checker.from_file(config)
+      expect(File.exist?(config)).to be_truthy
     end
   end
 
-  it 'should find matching sha1' do
-    existing = @sha1_checker.sha1('killbill-plugin-match-1.0.0.tar.gz')
-    existing.should_not be_nil
-    existing.should == 'fce068c3fd5f95646ce0d09852f43ff67f06f0b9'
+  it 'translates LATEST when caching nexus info' do
+    sha1_checker.cache_artifact_info('org.kill-bill.billing.plugin.java:analytics-plugin:jar:LATEST', { :sha1 => '050594dd73a54d229ca3efcf69785345b8cd1681',
+                                                                                                        :version => '7.0.4',
+                                                                                                        :repository_path => '/org/kill-bill/billing/plugin/java/analytics-plugin/7.0.4/analytics-plugin-7.0.4.jar',
+                                                                                                        :is_tgz => false })
+    expect(sha1_checker.artifact_info('org.kill-bill.billing.plugin.java:analytics-plugin:jar:LATEST')).to be_nil
+    expect(sha1_checker.artifact_info('org.kill-bill.billing.plugin.java:analytics-plugin:jar:7.0.4')[:sha1]).to eq('050594dd73a54d229ca3efcf69785345b8cd1681')
   end
 
-  it 'should NOT find sha1' do
-    existing = @sha1_checker.sha1('killbill-plugin-nomatch-1.0.0.tar.gz')
-    existing.should_not be_nil
-    existing.should_not == 'fce068c3fd5f95646ce0d09852f43ff67f06f0b9'
+  it 'never caches nexus info without version info' do
+    sha1_checker.cache_artifact_info('org.kill-bill.billing.plugin.java:analytics-plugin:jar:LATEST', { :sha1 => '050594dd73a54d229ca3efcf69785345b8cd1681',
+                                                                                                        :repository_path => '/org/kill-bill/billing/plugin/java/analytics-plugin/7.0.4/analytics-plugin-7.0.4.jar',
+                                                                                                        :is_tgz => false })
+    expect(sha1_checker.artifact_info('org.kill-bill.billing.plugin.java:analytics-plugin:jar:LATEST')).to be_nil
+    expect(sha1_checker.artifact_info('org.kill-bill.billing.plugin.java:analytics-plugin:jar:7.0.4')).to be_nil
   end
 
-  it 'should NOT find matching sha1' do
-    existing = @sha1_checker.sha1('killbill-plugin-foo-1.0.0.tar.gz')
-    existing.should be_nil
+  it 'finds matching sha1' do
+    existing_sha1 = sha1_checker.sha1('org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0')
+    expect(existing_sha1).to eq('fce068c3fd5f95646ce0d09852f43ff67f06f0b9')
+
+    existing_nexus = sha1_checker.artifact_info('org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0')
+    expect(existing_nexus[:sha1]).to eq(existing_sha1)
+  end
+
+  it 'does not find matching sha1' do
+    existing_sha1 = sha1_checker.sha1('killbill-plugin-foo:tar.gz:1.0.0')
+    expect(existing_sha1).to be_nil
+
+    existing_nexus = sha1_checker.artifact_info('killbill-plugin-foo:tar.gz:1.0.0')
+    expect(existing_nexus).to be_nil
   end
 
-  it 'should add an entry and find them all' do
-    @sha1_checker.add_or_modify_entry!('killbill-plugin-new-1.1.0.0.tar.gz', 'abc068c3fd5f95646ce0d09852f43ff67f06f111')
+  it 'adds an entry and find them all' do
+    sha1_checker.add_or_modify_entry!('killbill-plugin-new:tar.gz:1.1.0.0', 'abc068c3fd5f95646ce0d09852f43ff67f06f111')
 
-    existing = @sha1_checker.sha1('killbill-plugin-match-1.0.0.tar.gz')
-    existing.should_not be_nil
-    existing.should == 'fce068c3fd5f95646ce0d09852f43ff67f06f0b9'
+    existing = sha1_checker.sha1('org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0')
+    expect(existing).to eq('fce068c3fd5f95646ce0d09852f43ff67f06f0b9')
 
-    existing = @sha1_checker.sha1('killbill-plugin-new-1.1.0.0.tar.gz')
-    existing.should_not be_nil
-    existing.should == 'abc068c3fd5f95646ce0d09852f43ff67f06f111'
+    # Nexus cache untouched
+    existing_nexus = sha1_checker.artifact_info('org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0')
+    expect(existing_nexus[:sha1]).to eq(existing)
 
+    existing = sha1_checker.sha1('killbill-plugin-new:tar.gz:1.1.0.0')
+    expect(existing).to eq('abc068c3fd5f95646ce0d09852f43ff67f06f111')
 
-    existing = @sha1_checker.sha1('killbill-plugin-other-1.0.0.tar.gz')
-    existing.should_not be_nil
-    existing.should == 'bbb068c3fd5f95646ce0d09852f43ff67f06fccc'
+    # Nexus cache not updated
+    expect(sha1_checker.artifact_info('killbill-plugin-new:tar.gz:1.1.0.0')).to be_nil
+
+    existing = sha1_checker.sha1('org.kill-bill.billing.plugin.ruby:killbill-plugin-other:tar.gz:1.0.0')
+    expect(existing).to eq('bbb068c3fd5f95646ce0d09852f43ff67f06fccc')
+
+    # Nexus cache untouched
+    existing_nexus = sha1_checker.artifact_info('org.kill-bill.billing.plugin.ruby:killbill-plugin-other:tar.gz:1.0.0')
+    expect(existing_nexus[:sha1]).to eq(existing)
   end
 
-  it 'should add allow to modify an entry and find them all' do
-    existing = @sha1_checker.sha1('killbill-plugin-match-1.0.0.tar.gz')
-    existing.should_not be_nil
-    existing.should == 'fce068c3fd5f95646ce0d09852f43ff67f06f0b9'
+  it 'modifies an entry and find them all' do
+    existing = sha1_checker.sha1('org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0')
+    expect(existing).to eq('fce068c3fd5f95646ce0d09852f43ff67f06f0b9')
+
+    existing_nexus = sha1_checker.artifact_info('org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0')
+    expect(existing_nexus[:sha1]).to eq(existing)
+
+    sha1_checker.add_or_modify_entry!('org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0', 'dde068c3fd5f95646ce0d09852f43ff67f06f0aa')
 
-    @sha1_checker.add_or_modify_entry!('killbill-plugin-match-1.0.0.tar.gz', 'dde068c3fd5f95646ce0d09852f43ff67f06f0aa')
+    existing = sha1_checker.sha1('org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0')
+    expect(existing).to eq('dde068c3fd5f95646ce0d09852f43ff67f06f0aa')
 
-    existing = @sha1_checker.sha1('killbill-plugin-match-1.0.0.tar.gz')
-    existing.should_not be_nil
-    existing.should == 'dde068c3fd5f95646ce0d09852f43ff67f06f0aa'
+    # Nexus cache untouched (modified in another code path)
+    existing_nexus = sha1_checker.artifact_info('org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0')
+    expect(existing_nexus[:sha1]).to eq('fce068c3fd5f95646ce0d09852f43ff67f06f0b9')
 
-    existing = @sha1_checker.sha1('killbill-plugin-other-1.0.0.tar.gz')
-    existing.should_not be_nil
-    existing.should == 'bbb068c3fd5f95646ce0d09852f43ff67f06fccc'
+    existing = sha1_checker.sha1('org.kill-bill.billing.plugin.ruby:killbill-plugin-other:tar.gz:1.0.0')
+    expect(existing).to eq('bbb068c3fd5f95646ce0d09852f43ff67f06fccc')
+
+    existing_nexus = sha1_checker.artifact_info('org.kill-bill.billing.plugin.ruby:killbill-plugin-other:tar.gz:1.0.0')
+    expect(existing_nexus[:sha1]).to eq(existing)
   end
 
   context 'when removing an entry' do
-    let(:identifier) { 'killbill-plugin-match-1.0.0.tar.gz' }
+    let(:identifier) { 'org.kill-bill.billing.plugin.ruby:killbill-plugin-match:tar.gz:1.0.0' }
     before do
-      @sha1_checker.remove_entry!(identifier)
+      sha1_checker.remove_entry!(identifier)
     end
 
     it 'does not find the entry' do
-      @sha1_checker.sha1(identifier).should be_nil
+      expect(sha1_checker.sha1(identifier)).to be_nil
+      expect(sha1_checker.artifact_info(identifier)).to be_nil
     end
 
-    let(:reloaded_checker) { KPM::Sha1Checker.from_file(@tmp_config) }
     it 'does not find entry in file system' do
-      reloaded_checker.sha1(identifier).should be_nil
+      expect(KPM::Sha1Checker.from_file(sha1_file).sha1(identifier)).to be_nil
     end
   end
 
-  it 'should work with empty config' do
-    tmp_destination_dir = Dir.tmpdir()
-    empty_config = File.join(tmp_destination_dir, 'sha1_test.yml')
-    if File.exists?(empty_config)
-      # Just to be sure
-      File.delete(empty_config)
+  it 'works with empty config' do
+    Dir.mktmpdir do |dir|
+      empty_config = File.join(dir, 'sha1.yml')
+      sha1_checker = KPM::Sha1Checker.from_file(empty_config)
+      sha1_checker.add_or_modify_entry!('killbill-plugin-new:tar.gz:1.1.0.0', 'abc068c3fd5f95646ce0d09852f43ff67f06f111')
+      existing = sha1_checker.sha1('killbill-plugin-new:tar.gz:1.1.0.0')
+      expect(existing).to eq('abc068c3fd5f95646ce0d09852f43ff67f06f111')
     end
-    @sha1_checker = KPM::Sha1Checker.from_file(empty_config)
-
-    @sha1_checker.add_or_modify_entry!('killbill-plugin-new-1.1.0.0.tar.gz', 'abc068c3fd5f95646ce0d09852f43ff67f06f111')
-    existing = @sha1_checker.sha1('killbill-plugin-new-1.1.0.0.tar.gz')
-    existing.should_not be_nil
-    existing.should == 'abc068c3fd5f95646ce0d09852f43ff67f06f111'
   end
 end