kpm 0.7.2 → 0.10.0

data/spec/kpm/remote/cloudsmith_api_calls_spec.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'rexml/document'
+
+describe KPM::NexusFacade, skip_me_if_nil: ENV['CLOUDSMITH_TOKEN'].nil? do
+  let(:logger) do
+    logger = ::Logger.new(STDOUT)
+    logger.level = Logger::INFO
+    logger
+  end
+  let(:coordinates_map) do
+    { version: '0.22.21-20210319.010242-1',
+      group_id: 'org.kill-bill.billing',
+      artifact_id: 'killbill',
+      packaging: 'pom',
+      classifier: nil }
+  end
+  let(:coordinates) { KPM::Coordinates.build_coordinates(coordinates_map) }
+  let(:nexus_remote) { described_class::CloudsmithApiCalls.new({ :url => "https://dl.cloudsmith.io/#{ENV['CLOUDSMITH_TOKEN']}/#{ENV['CLOUDSMITH_ORG']}/#{ENV['CLOUDSMITH_REPO']}/maven" }, true, logger) }
+
+  it {
+    # Not implemented
+    expect { nexus_remote.search_for_artifacts(coordinates) }.to raise_exception(NoMethodError, 'Cloudsmith has no search support')
+  }
+
+  it {
+    response = nil
+    expect { response = nexus_remote.get_artifact_info(coordinates) }.not_to raise_exception
+    expect(REXML::Document.new(response).elements['//version'].text).to eq(coordinates_map[:version])
+  }
+
+  it {
+    response = nil
+    destination = Dir.mktmpdir('artifact')
+    expect { response = nexus_remote.pull_artifact(coordinates, destination) }.not_to raise_exception
+    destination = File.join(File.expand_path(destination), response[:file_name])
+    expect(File.read(destination)).to match(/org.kill-bill.billing/)
+  }
+end

data/spec/kpm/remote/github_api_calls_spec.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'rexml/document'
+
+describe KPM::NexusFacade, skip_me_if_nil: ENV['TOKEN'].nil? do
+  let(:logger) do
+    logger = ::Logger.new(STDOUT)
+    logger.level = Logger::INFO
+    logger
+  end
+  let(:coordinates_map) do
+    { version: '1.1.9',
+      group_id: 'org.kill-bill.billing.thirdparty',
+      artifact_id: 'qualpay-java-client',
+      packaging: 'pom',
+      classifier: nil }
+  end
+  let(:coordinates) { KPM::Coordinates.build_coordinates(coordinates_map) }
+  let(:nexus_remote) { described_class::GithubApiCalls.new({ :url => 'https://maven.pkg.github.com/killbill/qualpay-java-client', :token => ENV['TOKEN'] }, true, logger) }
+
+  it {
+    # Not implemented
+    expect { nexus_remote.search_for_artifacts(coordinates) }.to raise_exception(NoMethodError, 'GitHub Packages has no search support')
+  }
+
+  it {
+    response = nil
+    expect { response = nexus_remote.get_artifact_info(coordinates) }.not_to raise_exception
+    expect(REXML::Document.new(response).elements['//version'].text).to eq(coordinates_map[:version])
+  }
+
+  it {
+    response = nil
+    destination = Dir.mktmpdir('artifact')
+    expect { response = nexus_remote.pull_artifact(coordinates, destination) }.not_to raise_exception
+    destination = File.join(File.expand_path(destination), response[:file_name])
+    expect(File.read(destination)).to match(/qualpay-java-client/)
+  }
+end

data/spec/kpm/remote/installer_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'json'
 
 describe KPM::Installer do
-
   before(:all) do
     @logger       = Logger.new(STDOUT)
     @logger.level = Logger::INFO
@@ -12,18 +13,18 @@ describe KPM::Installer do
     Dir.mktmpdir do |dir|
       kb_webapp_path   = dir + '/KB_ROOT.war'
       installer        = KPM::Installer.new({
-                                                'killbill' => {
-                                                    'webapp_path' => kb_webapp_path
-                                                }
+                                              'killbill' => {
+                                                'webapp_path' => kb_webapp_path
+                                              }
                                             },
                                             @logger)
 
       # No exception
       response = nil
-      expect{ response = installer.install }.to_not raise_exception
+      expect { response = installer.install }.to_not raise_exception
       response = JSON[response]
-      response['help'].should be_nil
-      response['killbill']['status'].should eq 'INSTALLED'
+      expect(response['help']).to be_nil
+      expect(response['killbill']['status']).to eq 'INSTALLED'
     end
   end
 
@@ -31,18 +32,18 @@ describe KPM::Installer do
     Dir.mktmpdir do |dir|
       kaui_webapp_path = dir + '/KAUI_ROOT.war'
       installer        = KPM::Installer.new({
-                                                'kaui' => {
-                                                    'webapp_path' => kaui_webapp_path
-                                                }
+                                              'kaui' => {
+                                                'webapp_path' => kaui_webapp_path
+                                              }
                                             },
                                             @logger)
 
       # No exception
       response = nil
-      expect{ response = installer.install }.to_not raise_exception
+      expect { response = installer.install }.to_not raise_exception
       response = JSON[response]
-      response['help'].should be_nil
-      response['kaui']['status'].should eq 'INSTALLED'
+      expect(response['help']).to be_nil
+      expect(response['kaui']['status']).to eq 'INSTALLED'
     end
   end
 
@@ -52,29 +53,28 @@ describe KPM::Installer do
       kaui_webapp_path = dir + '/KAUI_ROOT.war'
       plugins_dir      = dir + '/bundles'
       installer        = KPM::Installer.new({
-                                                'killbill' => {
-                                                    'webapp_path' => kb_webapp_path,
-                                                    'plugins_dir' => plugins_dir,
-                                                    'plugins' => {
-                                                        'java' => [{
-                                                                       'name' => 'analytics',
-                                                                       'version' => '0.7.1'
-                                                                   }],
-                                                        'ruby' => [{
-                                                                       'name' => 'payment-test-plugin',
-                                                                       'artifact_id' => 'payment-test-plugin',
-                                                                       'group_id' => 'org.kill-bill.billing.plugin.ruby',
-                                                                       'version' => '1.8.7'
-                                                                   },
-                                                                   {
-                                                                       'name' => 'stripe',
-                                                                       'version' => '3.0.3'
-                                                                   }]
-                                                    }
-                                                },
-                                                'kaui' => {
-                                                    'webapp_path' => kaui_webapp_path
+                                              'killbill' => {
+                                                'webapp_path' => kb_webapp_path,
+                                                'plugins_dir' => plugins_dir,
+                                                'plugins' => {
+                                                  'java' => [{
+                                                    'name' => 'analytics',
+                                                    'version' => '0.7.1'
+                                                  }, {
+                                                    'name' => 'stripe',
+                                                    'version' => '7.0.0'
+                                                  }],
+                                                  'ruby' => [{
+                                                    'name' => 'payment-test-plugin',
+                                                    'artifact_id' => 'payment-test-plugin',
+                                                    'group_id' => 'org.kill-bill.billing.plugin.ruby',
+                                                    'version' => '1.8.7'
+                                                  }]
                                                 }
+                                              },
+                                              'kaui' => {
+                                                'webapp_path' => kaui_webapp_path
+                                              }
                                             },
                                             @logger)
 
@@ -87,11 +87,10 @@ describe KPM::Installer do
 
       # Finally verify that for both (well behaved) ruby and java plugin, skipping the install will still correctly return the `:bundle_dir`
       info = installer.install_plugin('payment-test-plugin', nil, 'org.kill-bill.billing.plugin.ruby', 'payment-test-plugin', nil, nil, '1.8.7', plugins_dir)
-      info[:bundle_dir].should == plugins_dir + '/plugins/ruby/killbill-payment-test/1.8.7'
-
+      expect(info[:bundle_dir]).to eq plugins_dir + '/plugins/ruby/killbill-payment-test/1.8.7'
 
-      info = installer.install_plugin('analytics', nil, nil, nil,  nil, nil, '0.7.1', plugins_dir)
-      info[:bundle_dir].should == plugins_dir + '/plugins/java/analytics-plugin/0.7.1'
+      info = installer.install_plugin('analytics', nil, nil, nil, nil, nil, '0.7.1', plugins_dir)
+      expect(info[:bundle_dir]).to eq plugins_dir + '/plugins/java/analytics-plugin/0.7.1'
     end
   end
 
@@ -99,56 +98,58 @@ describe KPM::Installer do
 
   def check_installation(plugins_dir, kb_webapp_path, kaui_webapp_path)
     [
-        plugins_dir,
-        plugins_dir + '/platform',
-        plugins_dir + '/plugins',
-        plugins_dir + '/plugins/java',
-        plugins_dir + '/plugins/java/analytics-plugin',
-        plugins_dir + '/plugins/java/analytics-plugin/0.7.1',
-        plugins_dir + '/plugins/ruby',
-        plugins_dir + '/plugins/ruby/killbill-payment-test',
-        plugins_dir + '/plugins/ruby/killbill-payment-test/1.8.7',
-        plugins_dir + '/plugins/ruby/killbill-stripe'
+      plugins_dir,
+      plugins_dir + '/platform',
+      plugins_dir + '/plugins',
+      plugins_dir + '/plugins/java',
+      plugins_dir + '/plugins/java/analytics-plugin',
+      plugins_dir + '/plugins/java/analytics-plugin/0.7.1',
+      plugins_dir + '/plugins/java/stripe-plugin',
+      plugins_dir + '/plugins/java/stripe-plugin/7.0.0',
+      plugins_dir + '/plugins/ruby',
+      plugins_dir + '/plugins/ruby/killbill-payment-test',
+      plugins_dir + '/plugins/ruby/killbill-payment-test/1.8.7'
     ].each do |dir|
-      File.directory?(dir).should be_true
+      expect(File.directory?(dir)).to be_truthy
     end
 
     [
-        kb_webapp_path,
-        kaui_webapp_path,
-        plugins_dir + '/platform/jruby.jar',
-        plugins_dir + '/plugins/plugin_identifiers.json',
-        plugins_dir + '/plugins/java/analytics-plugin/0.7.1/analytics-plugin-0.7.1.jar',
-        plugins_dir + '/plugins/ruby/killbill-payment-test/1.8.7/killbill.properties'
+      kb_webapp_path,
+      kaui_webapp_path,
+      plugins_dir + '/platform/jruby.jar',
+      plugins_dir + '/plugins/plugin_identifiers.json',
+      plugins_dir + '/plugins/java/analytics-plugin/0.7.1/analytics-plugin-0.7.1.jar',
+      plugins_dir + '/plugins/java/stripe-plugin/7.0.0/stripe-plugin-7.0.0.jar',
+      plugins_dir + '/plugins/ruby/killbill-payment-test/1.8.7/killbill.properties'
     ].each do |file|
-      File.file?(file).should be_true
+      expect(File.file?(file)).to be_truthy
     end
 
     plugin_identifiers = File.open(plugins_dir + '/plugins/plugin_identifiers.json', 'r') do |f|
       JSON.parse(f.read)
     end
 
-    plugin_identifiers.size.should == 3
-
-    plugin_identifiers['analytics']['plugin_name'].should == 'analytics-plugin'
-    plugin_identifiers['analytics']['group_id'].should == 'org.kill-bill.billing.plugin.java'
-    plugin_identifiers['analytics']['artifact_id'].should == 'analytics-plugin'
-    plugin_identifiers['analytics']['packaging'].should == 'jar'
-    plugin_identifiers['analytics']['version'].should == '0.7.1'
-    plugin_identifiers['analytics']['language'].should == 'java'
-
-    plugin_identifiers['payment-test-plugin']['plugin_name'].should == 'killbill-payment-test'
-    plugin_identifiers['payment-test-plugin']['group_id'].should == 'org.kill-bill.billing.plugin.ruby'
-    plugin_identifiers['payment-test-plugin']['artifact_id'].should == 'payment-test-plugin'
-    plugin_identifiers['payment-test-plugin']['packaging'].should == 'tar.gz'
-    plugin_identifiers['payment-test-plugin']['version'].should == '1.8.7'
-    plugin_identifiers['payment-test-plugin']['language'].should == 'ruby'
-
-    plugin_identifiers['stripe']['plugin_name'].should == 'killbill-stripe'
-    plugin_identifiers['stripe']['group_id'].should == 'org.kill-bill.billing.plugin.ruby'
-    plugin_identifiers['stripe']['artifact_id'].should == 'stripe-plugin'
-    plugin_identifiers['stripe']['packaging'].should == 'tar.gz'
-    plugin_identifiers['stripe']['version'].should == '3.0.3'
-    plugin_identifiers['stripe']['language'].should == 'ruby'
+    expect(plugin_identifiers.size).to eq 3
+
+    expect(plugin_identifiers['analytics']['plugin_name']).to eq 'analytics-plugin'
+    expect(plugin_identifiers['analytics']['group_id']).to eq 'org.kill-bill.billing.plugin.java'
+    expect(plugin_identifiers['analytics']['artifact_id']).to eq 'analytics-plugin'
+    expect(plugin_identifiers['analytics']['packaging']).to eq 'jar'
+    expect(plugin_identifiers['analytics']['version']).to eq '0.7.1'
+    expect(plugin_identifiers['analytics']['language']).to eq 'java'
+
+    expect(plugin_identifiers['stripe']['plugin_name']).to eq 'stripe-plugin'
+    expect(plugin_identifiers['stripe']['group_id']).to eq 'org.kill-bill.billing.plugin.java'
+    expect(plugin_identifiers['stripe']['artifact_id']).to eq 'stripe-plugin'
+    expect(plugin_identifiers['stripe']['packaging']).to eq 'jar'
+    expect(plugin_identifiers['stripe']['version']).to eq '7.0.0'
+    expect(plugin_identifiers['stripe']['language']).to eq 'java'
+
+    expect(plugin_identifiers['payment-test-plugin']['plugin_name']).to eq 'killbill-payment-test'
+    expect(plugin_identifiers['payment-test-plugin']['group_id']).to eq 'org.kill-bill.billing.plugin.ruby'
+    expect(plugin_identifiers['payment-test-plugin']['artifact_id']).to eq 'payment-test-plugin'
+    expect(plugin_identifiers['payment-test-plugin']['packaging']).to eq 'tar.gz'
+    expect(plugin_identifiers['payment-test-plugin']['version']).to eq '1.8.7'
+    expect(plugin_identifiers['payment-test-plugin']['language']).to eq 'ruby'
   end
 end

data/spec/kpm/remote/kaui_artifact_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::KillbillPluginArtifact do
-
   before(:all) do
     @logger       = Logger.new(STDOUT)
     @logger.level = Logger::INFO
@@ -16,15 +17,15 @@ describe KPM::KillbillPluginArtifact do
                                     KPM::BaseArtifact::KAUI_CLASSIFIER,
                                     'LATEST',
                                     dir)
-      info[:file_name].should == "kaui-standalone-#{info[:version]}.war"
-      info[:size].should == File.size(info[:file_path])
+      expect(info[:file_name]).to eq "kaui-standalone-#{info[:version]}.war"
+      expect(info[:size]).to eq File.size(info[:file_path])
     end
   end
 
   it 'should be able to list versions' do
     versions = KPM::KauiArtifact.versions.to_a
-    versions.size.should >= 2
-    versions[0].should == '0.0.1'
-    versions[1].should == '0.0.2'
+    expect(versions.size).to be >= 2
+    expect(versions[0]).to eq '0.0.1'
+    expect(versions[1]).to eq '0.0.2'
   end
 end

data/spec/kpm/remote/killbill_plugin_artifact_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::KillbillPluginArtifact do
-
   before(:all) do
     @logger       = Logger.new(STDOUT)
     @logger.level = Logger::INFO
@@ -19,15 +20,15 @@ describe KPM::KillbillPluginArtifact do
 
     Dir.mktmpdir do |dir|
       info = KPM::KillbillPluginArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, plugin_name, dir)
-      info[:file_name].should be_nil
+      expect(info[:file_name]).to be_nil
 
       files_in_dir = Dir[info[:file_path] + '/*']
-      files_in_dir.size.should == 1
-      files_in_dir[0].should == info[:file_path] + '/killbill-payment-test'
+      expect(files_in_dir.size).to eq 1
+      expect(files_in_dir[0]).to eq info[:file_path] + '/killbill-payment-test'
 
-      File.read(info[:file_path] + '/killbill-payment-test/1.8.7/killbill.properties').should == "mainClass=PaymentTest::PaymentPlugin\nrequire=payment_test\npluginType=PAYMENT\n"
+      expect(File.read(info[:file_path] + '/killbill-payment-test/1.8.7/killbill.properties')).to eq "mainClass=PaymentTest::PaymentPlugin\nrequire=payment_test\npluginType=PAYMENT\n"
 
-      info[:bundle_dir].should == info[:file_path] + '/killbill-payment-test/1.8.7'
+      expect(info[:bundle_dir]).to eq info[:file_path] + '/killbill-payment-test/1.8.7'
     end
   end
 
@@ -43,8 +44,8 @@ describe KPM::KillbillPluginArtifact do
                                               'killbill-analytics',
                                               dir,
                                               sha1_file)
-      info[:file_name].should == "analytics-plugin-#{info[:version]}.jar"
-      info[:size].should == File.size(info[:file_path])
+      expect(info[:file_name]).to eq "analytics-plugin-#{info[:version]}.jar"
+      expect(info[:size]).to eq File.size(info[:file_path])
 
       check_yaml_for_resolved_latest_version(sha1_file, 'org.kill-bill.billing.plugin.java:analytics-plugin:jar', '3.0.0')
     end
@@ -62,31 +63,28 @@ describe KPM::KillbillPluginArtifact do
                                               sha1_file)
 
       # No file name - since we untar'ed it
-      info[:file_name].should be_nil
+      expect(info[:file_name]).to be_nil
 
       check_yaml_for_resolved_latest_version(sha1_file, 'org.kill-bill.billing.plugin.ruby:logging-plugin:tar.gz', '3.0.0')
     end
-
-
-
   end
 
   it 'should be able to list versions' do
     versions = KPM::KillbillPluginArtifact.versions
 
-    versions[:java].should_not be_nil
-    versions[:java]['analytics-plugin'].should_not be_nil
+    expect(versions[:java]).not_to be_nil
+    expect(versions[:java]['analytics-plugin']).not_to be_nil
     logging_plugin_versions = versions[:java]['analytics-plugin'].to_a
-    logging_plugin_versions.size.should >= 3
-    logging_plugin_versions[0].should == '0.6.0'
-    logging_plugin_versions[1].should == '0.7.0'
-    logging_plugin_versions[2].should == '0.7.1'
+    expect(logging_plugin_versions.size).to be >= 3
+    expect(logging_plugin_versions[0]).to eq '0.6.0'
+    expect(logging_plugin_versions[1]).to eq '0.7.0'
+    expect(logging_plugin_versions[2]).to eq '0.7.1'
 
-    versions[:ruby].should_not be_nil
-    versions[:ruby]['logging-plugin'].should_not be_nil
+    expect(versions[:ruby]).not_to be_nil
+    expect(versions[:ruby]['logging-plugin']).not_to be_nil
     logging_plugin_versions = versions[:ruby]['logging-plugin'].to_a
-    logging_plugin_versions.size.should >= 1
-    logging_plugin_versions[0].should == '1.7.0'
+    expect(logging_plugin_versions.size).to be >= 1
+    expect(logging_plugin_versions[0]).to eq '1.7.0'
   end
 
   private
@@ -95,17 +93,14 @@ describe KPM::KillbillPluginArtifact do
   # (we can't check against actual version because as we keep releasing those increment,
   # so the best we can do it check this is *not* LATEST and greater than current version at the time the test was written )
   def check_yaml_for_resolved_latest_version(sha1_file, key_prefix, minimum_version)
-
     sha1_checker = KPM::Sha1Checker.from_file(sha1_file)
 
-    keys = sha1_checker.all_sha1.keys.select { |k| k.start_with? key_prefix}
-    keys.size.should == 1
+    keys = sha1_checker.all_sha1.keys.select { |k| k.start_with? key_prefix }
+    expect(keys.size).to eq 1
 
     parts = keys[0].split(':')
-    parts.size.should == 4
-    parts[3].should_not == 'LATEST'
-    parts[3].should  >= minimum_version
+    expect(parts.size).to eq 4
+    expect(parts[3]).not_to eq 'LATEST'
+    expect(parts[3]).to be >= minimum_version
   end
-
-
 end

data/spec/kpm/remote/killbill_server_artifact_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::KillbillServerArtifact do
-
   before(:all) do
     @logger       = Logger.new(STDOUT)
     @logger.level = Logger::INFO
@@ -17,41 +18,41 @@ describe KPM::KillbillServerArtifact do
                                               KPM::BaseArtifact::KILLBILL_CLASSIFIER,
                                               'LATEST',
                                               dir)
-      info[:file_name].should == "killbill-profiles-killbill-#{info[:version]}.war"
-      info[:size].should == File.size(info[:file_path])
+      expect(info[:file_name]).to eq "killbill-profiles-killbill-#{info[:version]}.war"
+      expect(info[:size]).to eq File.size(info[:file_path])
     end
   end
 
   it 'should be able to list versions' do
     versions = KPM::KillbillServerArtifact.versions(KPM::BaseArtifact::KILLBILL_ARTIFACT_ID).to_a
-    versions.size.should >= 2
-    versions[0].should == '0.11.10'
-    versions[1].should == '0.11.11'
+    expect(versions.size).to be >= 2
+    expect(versions[0]).to eq '0.11.10'
+    expect(versions[1]).to eq '0.11.11'
   end
 
   it 'should get dependencies information' do
-    nexus_down = {:url => 'https://does.not.exist'}
+    nexus_down = { url: 'https://does.not.exist' }
 
     Dir.mktmpdir do |dir|
       sha1_file = "#{dir}/sha1.yml"
       info = KPM::KillbillServerArtifact.info('0.15.9', sha1_file)
-      info['killbill'].should == '0.15.9'
-      info['killbill-oss-parent'].should == '0.62'
-      info['killbill-api'].should == '0.27'
-      info['killbill-plugin-api'].should == '0.16'
-      info['killbill-commons'].should == '0.10'
-      info['killbill-platform'].should == '0.13'
-      KPM::Sha1Checker.from_file(sha1_file).killbill_info('0.15.9').should == info
+      expect(info['killbill']).to eq '0.15.9'
+      expect(info['killbill-oss-parent']).to eq '0.62'
+      expect(info['killbill-api']).to eq '0.27'
+      expect(info['killbill-plugin-api']).to eq '0.16'
+      expect(info['killbill-commons']).to eq '0.10'
+      expect(info['killbill-platform']).to eq '0.13'
+      expect(KPM::Sha1Checker.from_file(sha1_file).killbill_info('0.15.9')).to eq info
 
       # Verify the download is skipped gracefully when Nexus isn't reachable
       KPM::KillbillServerArtifact.info('0.15.9', sha1_file, false, nil, nexus_down)
 
       # Verify the download fails when Nexus isn't reachable and force_download is set
-      expect { KPM::KillbillServerArtifact.info('0.15.9', sha1_file, true, nil, nexus_down) }.to raise_error(SocketError)
+      expect { KPM::KillbillServerArtifact.info('0.15.9', sha1_file, true, nil, nexus_down) }.to raise_exception(SocketError, /(Failed to open TCP connection to does.not.exist:443|getaddrinfo)/)
 
       # Verify the download fails when Nexus isn't reachable and the Nexus cache is empty
       KPM::Sha1Checker.from_file(sha1_file).cache_killbill_info('0.15.9', nil)
-      expect { KPM::KillbillServerArtifact.info('0.15.9', sha1_file, false, nil, nexus_down) }.to raise_error(SocketError)
+      expect { KPM::KillbillServerArtifact.info('0.15.9', sha1_file, false, nil, nexus_down) }.to raise_exception(SocketError, /(Failed to open TCP connection to does.not.exist:443|getaddrinfo)/)
     end
   end
 end