kpm 0.7.1 → 0.9.0

data/spec/kpm/unit/installer_spec.rb

@@ -1,17 +1,18 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::Installer do
-
   context 'when no config file is specified' do
-    let(:all_kb_versions) { %w(0.15.0 0.15.1 0.15.10 0.15.11-SNAPSHOT 0.15.2 0.15.3 0.16.0 0.16.1 0.16.10 0.16.11 0.16.12-SNAPSHOT 0.16.2 0.16.3 0.17.0 0.17.1 0.17.2 0.17.2-SNAPSHOT 0.17.3-SNAPSHOT) }
+    let(:all_kb_versions) { %w[0.15.0 0.15.1 0.15.10 0.15.11-SNAPSHOT 0.15.2 0.15.3 0.16.0 0.16.1 0.16.10 0.16.11 0.16.12-SNAPSHOT 0.16.2 0.16.3 0.17.0 0.17.1 0.17.2 0.17.2-SNAPSHOT 0.17.3-SNAPSHOT] }
 
     it 'finds the right stable versions' do
       config = KPM::Installer.build_default_config(all_kb_versions)
-      config['killbill'].should_not be_nil
-      config['killbill']['version'].should == '0.16.11'
+      expect(config['killbill']).not_to be_nil
+      expect(config['killbill']['version']).to eq '0.16.11'
 
-      config['kaui'].should_not be_nil
-      config['kaui']['version'].should == 'LATEST'
+      expect(config['kaui']).not_to be_nil
+      expect(config['kaui']['version']).to eq 'LATEST'
     end
   end
 end

data/spec/kpm/unit/memory_information_spec.rb

@@ -0,0 +1,102 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'kpm/system_helpers/system_proxy'
+require 'kpm/system_helpers/memory_information'
+
+describe KPM::SystemProxy::MemoryInformation do
+  subject { described_class.new }
+
+  context 'when running on Linux' do
+    let(:data) { "MemTotal:       10774024 kB\nMemFree:         3788232 kB\nMemAvailable:    9483696 kB\nBuffers:          269216 kB\nCached:          5448624 kB\nSwapCached:            0 kB\nActive:          3562072 kB\nInactive:        2913296 kB\nActive(anon):     827072 kB\nInactive(anon):   124844 kB\nActive(file):    2735000 kB\nInactive(file):  2788452 kB\nUnevictable:           0 kB\nMlocked:               0 kB\nSwapTotal:       3620520 kB\nSwapFree:        3620520 kB\nDirty:                16 kB\nWriteback:             0 kB\nAnonPages:        757472 kB\nMapped:            71548 kB\nShmem:            194392 kB\nSlab:             468096 kB\nSReclaimable:     425428 kB\nSUnreclaim:        42668 kB\nKernelStack:        4816 kB\nPageTables:         3420 kB\nNFS_Unstable:          0 kB\nBounce:                0 kB\nWritebackTmp:          0 kB\nCommitLimit:     9007532 kB\nCommitted_AS:    1711072 kB\nVmallocTotal:   34359738367 kB\nVmallocUsed:           0 kB\nVmallocChunk:          0 kB\nAnonHugePages:    622592 kB\nHugePages_Total:       0\nHugePages_Free:        0\nHugePages_Rsvd:        0\nHugePages_Surp:        0\nHugepagesize:       2048 kB\nDirectMap4k:      166848 kB\nDirectMap2M:    10883072 kB\n" }
+    let(:memory_info) { subject.send(:build_hash, data) }
+
+    it {
+      expect(subject.labels).to eq([{ label: :memory_detail },
+                                    { label: :value }])
+    }
+
+    it {
+      expect(memory_info).to eq({ 'MemTotal' => { memory_detail: 'MemTotal', value: '10774024 kB' },
+                                  'MemFree' => { memory_detail: 'MemFree', value: '3788232 kB' },
+                                  'MemAvailable' => { memory_detail: 'MemAvailable', value: '9483696 kB' },
+                                  'Buffers' => { memory_detail: 'Buffers', value: '269216 kB' },
+                                  'Cached' => { memory_detail: 'Cached', value: '5448624 kB' },
+                                  'SwapCached' => { memory_detail: 'SwapCached', value: '0 kB' },
+                                  'Active' => { memory_detail: 'Active', value: '3562072 kB' },
+                                  'Inactive' => { memory_detail: 'Inactive', value: '2913296 kB' },
+                                  'Active(anon)' => { memory_detail: 'Active(anon)', value: '827072 kB' },
+                                  'Inactive(anon)' => { memory_detail: 'Inactive(anon)', value: '124844 kB' },
+                                  'Active(file)' => { memory_detail: 'Active(file)', value: '2735000 kB' },
+                                  'Inactive(file)' => { memory_detail: 'Inactive(file)', value: '2788452 kB' },
+                                  'Unevictable' => { memory_detail: 'Unevictable', value: '0 kB' },
+                                  'Mlocked' => { memory_detail: 'Mlocked', value: '0 kB' },
+                                  'SwapTotal' => { memory_detail: 'SwapTotal', value: '3620520 kB' },
+                                  'SwapFree' => { memory_detail: 'SwapFree', value: '3620520 kB' },
+                                  'Dirty' => { memory_detail: 'Dirty', value: '16 kB' },
+                                  'Writeback' => { memory_detail: 'Writeback', value: '0 kB' },
+                                  'AnonPages' => { memory_detail: 'AnonPages', value: '757472 kB' },
+                                  'Mapped' => { memory_detail: 'Mapped', value: '71548 kB' },
+                                  'Shmem' => { memory_detail: 'Shmem', value: '194392 kB' },
+                                  'Slab' => { memory_detail: 'Slab', value: '468096 kB' },
+                                  'SReclaimable' => { memory_detail: 'SReclaimable', value: '425428 kB' },
+                                  'SUnreclaim' => { memory_detail: 'SUnreclaim', value: '42668 kB' },
+                                  'KernelStack' => { memory_detail: 'KernelStack', value: '4816 kB' },
+                                  'PageTables' => { memory_detail: 'PageTables', value: '3420 kB' },
+                                  'NFS_Unstable' => { memory_detail: 'NFS_Unstable', value: '0 kB' },
+                                  'Bounce' => { memory_detail: 'Bounce', value: '0 kB' },
+                                  'WritebackTmp' => { memory_detail: 'WritebackTmp', value: '0 kB' },
+                                  'CommitLimit' => { memory_detail: 'CommitLimit', value: '9007532 kB' },
+                                  'Committed_AS' => { memory_detail: 'Committed_AS', value: '1711072 kB' },
+                                  'VmallocTotal' => { memory_detail: 'VmallocTotal', value: '34359738367 kB' },
+                                  'VmallocUsed' => { memory_detail: 'VmallocUsed', value: '0 kB' },
+                                  'VmallocChunk' => { memory_detail: 'VmallocChunk', value: '0 kB' },
+                                  'AnonHugePages' => { memory_detail: 'AnonHugePages', value: '622592 kB' },
+                                  'HugePages_Total' => { memory_detail: 'HugePages_Total', value: '0' },
+                                  'HugePages_Free' => { memory_detail: 'HugePages_Free', value: '0' },
+                                  'HugePages_Rsvd' => { memory_detail: 'HugePages_Rsvd', value: '0' },
+                                  'HugePages_Surp' => { memory_detail: 'HugePages_Surp', value: '0' },
+                                  'Hugepagesize' => { memory_detail: 'Hugepagesize', value: '2048 kB' },
+                                  'DirectMap4k' => { memory_detail: 'DirectMap4k', value: '166848 kB' },
+                                  'DirectMap2M' => { memory_detail: 'DirectMap2M', value: '10883072 kB' } })
+    }
+  end
+
+  context 'when running on MacOS' do
+    let(:mem_data) { "Mach Virtual Memory Statistics: (page size of 4096 bytes)\nPages free:                               20436\nPages active:                            279093\nPages inactive:                          276175\nPages speculative:                         2492\nPages throttled:                              0\nPages wired down:                       3328540\nPages purgeable:                          47378\n\"Translation faults\":                1774872371\nPages copy-on-write:                   34313850\nPages zero filled:                   1023660277\nPages reactivated:                    194623586\nPages purged:                          70443047\nFile-backed pages:                       119033\nAnonymous pages:                         438727\nPages stored in compressor:             2771982\nPages occupied by compressor:            287324\nDecompressions:                       252938013\nCompressions:                         328708973\nPageins:                               66884005\nPageouts:                               1122278\nSwapins:                              110783726\nSwapouts:                             113589173\n" }
+    let(:mem_total_data) { "      Memory: 16 GB\n" }
+    let(:memory_info) { subject.send(:build_hash_mac, mem_data, mem_total_data) }
+
+    it {
+      expect(subject.labels).to eq([{ label: :memory_detail },
+                                    { label: :value }])
+    }
+
+    it {
+      expect(memory_info).to eq({ 'Memory' => { memory_detail: 'Memory', value: '16 GB' },
+                                  'Mach Virtual Memory Statistics' => { memory_detail: 'Mach Virtual Memory Statistics', value: '0MB' },
+                                  'Pages free' => { memory_detail: 'Memory free', value: '79MB' },
+                                  'Pages active' => { memory_detail: 'Memory active', value: '1090MB' },
+                                  'Pages inactive' => { memory_detail: 'Memory inactive', value: '1078MB' },
+                                  'Pages speculative' => { memory_detail: 'Memory speculative', value: '9MB' },
+                                  'Pages throttled' => { memory_detail: 'Memory throttled', value: '0MB' },
+                                  'Pages wired down' => { memory_detail: 'Memory wired down', value: '13002MB' },
+                                  'Pages purgeable' => { memory_detail: 'Memory purgeable', value: '185MB' },
+                                  'Translation faults' => { memory_detail: 'Translation faults', value: '6933095MB' },
+                                  'Pages copy-on-write' => { memory_detail: 'Memory copy-on-write', value: '134038MB' },
+                                  'Pages zero filled' => { memory_detail: 'Memory zero filled', value: '3998672MB' },
+                                  'Pages reactivated' => { memory_detail: 'Memory reactivated', value: '760248MB' },
+                                  'Pages purged' => { memory_detail: 'Memory purged', value: '275168MB' },
+                                  'File-backed pages' => { memory_detail: 'File-backed pages', value: '464MB' },
+                                  'Anonymous pages' => { memory_detail: 'Anonymous pages', value: '1713MB' },
+                                  'Pages stored in compressor' => { memory_detail: 'Memory stored in compressor', value: '10828MB' },
+                                  'Pages occupied by compressor' => { memory_detail: 'Memory occupied by compressor', value: '1122MB' },
+                                  'Decompressions' => { memory_detail: 'Decompressions', value: '988039MB' },
+                                  'Compressions' => { memory_detail: 'Compressions', value: '1284019MB' },
+                                  'Pageins' => { memory_detail: 'Pageins', value: '261265MB' },
+                                  'Pageouts' => { memory_detail: 'Pageouts', value: '4383MB' },
+                                  'Swapins' => { memory_detail: 'Swapins', value: '432748MB' },
+                                  'Swapouts' => { memory_detail: 'Swapouts', value: '443707MB' } })
+    }
+  end
+end

data/spec/kpm/unit/os_information_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'kpm/system_helpers/system_proxy'
+require 'kpm/system_helpers/os_information'
+
+describe KPM::SystemProxy::OsInformation do
+  subject { described_class.new }
+  let(:os_data) { subject.send(:build_hash, data) }
+
+  context 'when running on Linux' do
+    let(:data) { "Description:Ubuntu 16.04.1 LTS \n\n" }
+
+    it {
+      expect(subject.labels).to eq([{ label: :os_detail },
+                                    { label: :value }])
+    }
+
+    it {
+      expect(os_data).to eq({ 'Description' => { :os_detail => 'Description', :value => 'Ubuntu 16.04.1 LTS' } })
+    }
+  end
+
+  context 'when running on MacOS' do
+    let(:data) { "ProductName:\tMac OS X\nProductVersion:\t10.14.6\nBuildVersion:\t18G87\n" }
+
+    it {
+      expect(subject.labels).to eq([{ label: :os_detail },
+                                    { label: :value }])
+    }
+
+    it {
+      expect(os_data).to eq({ 'ProductName' => { :os_detail => 'ProductName', :value => 'Mac OS X' },
+                              'ProductVersion' => { :os_detail => 'ProductVersion', :value => '10.14.6' },
+                              'BuildVersion' => { :os_detail => 'BuildVersion', :value => '18G87' } })
+    }
+  end
+end

data/spec/kpm/unit/plugins_directory_spec.rb

@@ -1,36 +1,52 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::PluginsDirectory do
-
   it 'should parse the plugins directory' do
     directory = KPM::PluginsDirectory.all(false)
-    directory.size.should > 0
+    expect(directory.size).to be > 0
   end
 
-
   it 'should lookup plugins' do
-    group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.14')
-    group_id.should == 'org.kill-bill.billing.plugin.java'
-    artifact_id.should == 'analytics-plugin'
-    packaging.should == 'jar'
-    classifier.should be_nil
-    version.should == '1.0.3'
-    type.should == :java
+    group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.20.11')
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq '6.0.1'
+    expect(type).to eq :java
+
+    group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.20.11-SNAPSHOT')
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq '6.0.1'
+    expect(type).to eq :java
+
+    group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.20')
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq '6.0.1'
+    expect(type).to eq :java
 
     group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, 'LATEST')
-    group_id.should == 'org.kill-bill.billing.plugin.java'
-    artifact_id.should == 'analytics-plugin'
-    packaging.should == 'jar'
-    classifier.should be_nil
-    version.should == 'LATEST'
-    type.should == :java
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq 'LATEST'
+    expect(type).to eq :java
 
     group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.42')
-    group_id.should == 'org.kill-bill.billing.plugin.java'
-    artifact_id.should == 'analytics-plugin'
-    packaging.should == 'jar'
-    classifier.should be_nil
-    version.should == 'LATEST'
-    type.should == :java
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq 'LATEST'
+    expect(type).to eq :java
   end
 end

data/spec/kpm/unit/plugins_manager_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::PluginsManager do
-
   before(:each) do
     logger = Logger.new(STDOUT)
     logger.level = Logger::INFO
@@ -14,7 +15,7 @@ describe KPM::PluginsManager do
     FileUtils.mkdir_p(@plugin_dir.join('1.0.0'))
     FileUtils.mkdir_p(@plugin_dir.join('2.0.0'))
 
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_false
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_falsey
   end
 
   after(:each) do
@@ -24,133 +25,128 @@ describe KPM::PluginsManager do
   it 'creates a plugin identifier entry with no coordinate' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('foo', 'foo_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['foo']['plugin_name'].should == 'foo_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
   end
 
   it 'creates a plugin identifier entry with coordinates' do
     # Verifies file gets created if does not exist
-    coordinate_map = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version'}
+    coordinate_map = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map)
-    identifiers.size.should == 1
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['bar']['group_id'].should == 'group'
-    identifiers['bar']['artifact_id'].should == 'artifact'
-    identifiers['bar']['packaging'].should == 'packaging'
-    identifiers['bar']['classifier'].should == nil
-    identifiers['bar']['version'].should == 'version'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['group_id']).to eq 'group'
+    expect(identifiers['bar']['artifact_id']).to eq 'artifact'
+    expect(identifiers['bar']['packaging']).to eq 'packaging'
+    expect(identifiers['bar']['classifier']).to be_nil
+    expect(identifiers['bar']['version']).to eq 'version'
   end
 
-
   it 'creates plugin identifier with multiple entries' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('foo', 'foo_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['foo']['plugin_name'].should == 'foo_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
 
     # Verify file was created from previous entry (prev value was read)
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', nil)
-    identifiers.size.should == 2
-    identifiers['foo']['plugin_name'].should == 'foo_name'
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-
+    expect(identifiers.size).to eq 2
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
 
     # Verify file was created from previous entry (prev value was read)
     identifiers = @manager.add_plugin_identifier_key('zoe', 'zoe_name', 'type', nil)
-    identifiers.size.should == 3
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['foo']['plugin_name'].should == 'foo_name'
-    identifiers['zoe']['plugin_name'].should == 'zoe_name'
+    expect(identifiers.size).to eq 3
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
+    expect(identifiers['zoe']['plugin_name']).to eq 'zoe_name'
   end
 
   it 'creates plugin identifiers with duplicate entries' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('kewl', 'kewl_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['kewl']['plugin_name'].should == 'kewl_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['kewl']['plugin_name']).to eq 'kewl_name'
 
     # Add with a different plugin_name
     identifiers = @manager.add_plugin_identifier_key('kewl', 'kewl_name2', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['kewl']['plugin_name'].should == 'kewl_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['kewl']['plugin_name']).to eq 'kewl_name'
   end
 
-
   it 'creates plugin identifiers and remove entry' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('lol', 'lol_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['lol']['plugin_name'].should == 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
 
     # Remove wrong entry, nothing happens
     identifiers = @manager.remove_plugin_identifier_key('lol2')
-    identifiers.size.should == 1
-    identifiers['lol']['plugin_name'].should == 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
 
     # Remove correct entry
     identifiers = @manager.remove_plugin_identifier_key('lol')
-    identifiers.size.should == 0
+    expect(identifiers.size).to eq 0
 
     # Add same entry again
     identifiers = @manager.add_plugin_identifier_key('lol', 'lol_name', 'type', nil)
-    identifiers.size.should == 1
-    identifiers['lol']['plugin_name'].should == 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
   end
 
   it 'creates plugin identifiers and validate entry' do
     # Verifies file gets created if does not exist
-    coordinate_map = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version'}
+    coordinate_map = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
 
-    identifiers = @manager.add_plugin_identifier_key('yoyo', 'yoyo_name', 'type',  coordinate_map)
-    identifiers.size.should == 1
-    identifiers['yoyo']['plugin_name'].should == 'yoyo_name'
+    identifiers = @manager.add_plugin_identifier_key('yoyo', 'yoyo_name', 'type', coordinate_map)
+    expect(identifiers.size).to eq 1
+    expect(identifiers['yoyo']['plugin_name']).to eq 'yoyo_name'
 
-    @manager.validate_plugin_identifier_key('yoyo', coordinate_map).should == true
+    expect(@manager.validate_plugin_identifier_key('yoyo', coordinate_map)).to eq true
 
     # Negative validation
-    invalid_coordinate_map = {:group_id => 'group1', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version'}
+    invalid_coordinate_map = { group_id: 'group1', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
 
-    @manager.validate_plugin_identifier_key('yoyo', invalid_coordinate_map).should == false
+    expect(@manager.validate_plugin_identifier_key('yoyo', invalid_coordinate_map)).to eq false
   end
 
-
   it 'creates a plugin identifier entry with a new version' do
     # Verifies file gets created if does not exist
 
-    coordinate_map1 = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version1'}
+    coordinate_map1 = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version1' }
 
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map1)
-    identifiers.size.should == 1
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['bar']['version'].should == 'version1'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['version']).to eq 'version1'
 
-    coordinate_map2 = {:group_id => 'group', :artifact_id => 'artifact', :packaging => 'packaging', :version => 'version2'}
+    coordinate_map2 = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version2' }
 
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map2)
-    identifiers.size.should == 1
-    identifiers['bar']['plugin_name'].should == 'bar_name'
-    identifiers['bar']['version'].should == 'version2'
-
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['version']).to eq 'version2'
   end
 
   it 'sets a path as active' do
     @manager.set_active(@plugin_dir.join('1.0.0'))
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('1.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('1.0.0').to_s
 
     @manager.set_active(@plugin_dir.join('2.0.0'))
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('2.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('2.0.0').to_s
   end
 
   it 'sets a plugin version as active' do
     @manager.set_active('killbill-stripe', '2.0.0')
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('2.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('2.0.0').to_s
 
     @manager.set_active('killbill-stripe', '1.0.0')
-    File.exists?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should == @plugin_dir.join('1.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('1.0.0').to_s
   end
 
   it 'uninstalls a plugin via a path' do
@@ -194,19 +190,19 @@ describe KPM::PluginsManager do
   end
 
   it 'guesses the plugin name' do
-    @manager.guess_plugin_name('tripe').should be_nil
+    expect(@manager.guess_plugin_name('tripe')).to be_nil
     # Short name
-    @manager.guess_plugin_name('stripe').should == 'killbill-stripe'
+    expect(@manager.guess_plugin_name('stripe')).to eq 'killbill-stripe'
     # Artifact id
-    @manager.guess_plugin_name('stripe-plugin').should == 'killbill-stripe'
+    expect(@manager.guess_plugin_name('stripe-plugin')).to eq 'killbill-stripe'
     # Plugin name (top directory in the .tar.gz)
-    @manager.guess_plugin_name('killbill-stripe').should == 'killbill-stripe'
+    expect(@manager.guess_plugin_name('killbill-stripe')).to eq 'killbill-stripe'
   end
 
   private
 
   def check_state(version, has_restart, has_disabled)
-    File.exists?(@plugin_dir.join(version).join('tmp').join('restart.txt')).should == has_restart
-    File.exists?(@plugin_dir.join(version).join('tmp').join('disabled.txt')).should == has_disabled
+    expect(File.exist?(@plugin_dir.join(version).join('tmp').join('restart.txt'))).to eq has_restart
+    expect(File.exist?(@plugin_dir.join(version).join('tmp').join('disabled.txt'))).to eq has_disabled
   end
 end