kpm 0.7.1 → 0.9.0

data/spec/kpm/unit/actions_spec.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe KPM::NexusFacade::Actions do
+  subject { described_class.new({}, nil, logger) }
+  let(:logger) { Logger.new(STDOUT) }
+  let(:nexus_mock) { double(KPM::NexusFacade::NexusApiCallsV2) }
+
+  before do
+    allow(KPM::NexusFacade::NexusApiCallsV2).to receive(:new).and_return(nexus_mock)
+  end
+
+  context 'when Nexus throws a non-retryable exception' do
+    it 'never retries' do
+      calls = 0
+      expect do
+        subject.send(:retry_exceptions, 'foo') do
+          calls += 1
+          raise StandardError, '404'
+        end
+      end.to raise_error(StandardError)
+      expect(calls).to eq(1)
+    end
+  end
+
+  context 'when Nexus throws a retryable exception' do
+    it 'retries until giving up' do
+      calls = 0
+      expect do
+        subject.send(:retry_exceptions, 'foo') do
+          calls += 1
+          raise KPM::NexusFacade::UnexpectedStatusCodeException, 503
+        end
+      end.to raise_error(StandardError)
+      expect(calls).to eq(3)
+    end
+  end
+
+  context 'when networking is flaky' do
+    it 'retries until call succeeds' do
+      calls = 0
+      expect(subject.send(:retry_exceptions, 'foo') do
+        calls += 1
+        raise OpenSSL::SSL::SSLErrorWaitReadable if calls < 2
+
+        true
+      end).to be_truthy
+      expect(calls).to eq(2)
+    end
+  end
+end

data/spec/kpm/unit/base_artifact_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::BaseArtifact do
-
   before(:all) do
     @logger = Logger.new(STDOUT)
     @logger.level = Logger::INFO
@@ -13,16 +14,16 @@ describe KPM::BaseArtifact do
     Dir.mktmpdir do |dir|
       info = KPM::BaseArtifact.pull_from_fs(@logger, file_path, dir)
 
-      info[:skipped].should be_false
-      info[:is_tgz].should be_false
-      info[:repository_path].should == file_path
-      info[:dir_name].should == dir
-      info[:bundle_dir].should == dir
-      info[:file_name].should == 'sha1_test.yml'
+      expect(info[:skipped]).to be_falsey
+      expect(info[:is_tgz]).to be_falsey
+      expect(info[:repository_path]).to eq file_path
+      expect(info[:dir_name]).to eq dir
+      expect(info[:bundle_dir]).to eq dir
+      expect(info[:file_name]).to eq 'sha1_test.yml'
 
       files_in_dir = Dir[dir + '/*']
-      files_in_dir.size.should == 1
-      files_in_dir[0].should == info[:file_path]
+      expect(files_in_dir.size).to eq 1
+      expect(files_in_dir[0]).to eq info[:file_path]
     end
   end
 
@@ -75,18 +76,18 @@ describe KPM::BaseArtifact do
 
   def check_fs_info(specified_destination_path, repository_path, is_tgz, version, expected_dir_name, expected_file_name, expected_file_path)
     info = {
-        :repository_path => repository_path,
-        :is_tgz => is_tgz,
-        :version => version
+      repository_path: repository_path,
+      is_tgz: is_tgz,
+      version: version
     }
 
     KPM::BaseArtifact.send('populate_fs_info', info, specified_destination_path)
 
-    info[:repository_path].should == repository_path
-    info[:is_tgz].should == is_tgz
-    info[:version].should == version
-    info[:dir_name].should == expected_dir_name
-    info[:file_name].should == expected_file_name
-    info[:file_path].should == expected_file_path
+    expect(info[:repository_path]).to eq repository_path
+    expect(info[:is_tgz]).to eq is_tgz
+    expect(info[:version]).to eq version
+    expect(info[:dir_name]).to eq expected_dir_name
+    expect(info[:file_name]).to eq expected_file_name
+    expect(info[:file_path]).to eq expected_file_path
   end
 end

data/spec/kpm/unit/cpu_information_spec.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'kpm/system_helpers/system_proxy'
+require 'kpm/system_helpers/cpu_information'
+
+describe KPM::SystemProxy::CpuInformation do
+  subject { described_class.new }
+  let(:cpu_info) { subject.send(:build_hash, data) }
+
+  context 'when running on Linux' do
+    let(:data) { "processor: 0\nvendor_id: GenuineIntel\ncpu family: 6\nmodel: 78\nmodel name: Intel(R) Core(TM) i5-6287U CPU @ 3.10GHz\nstepping: 3\ncpu MHz: 3096.000\ncache size: 4096 KB\nphysical id: 0\nsiblings: 2\ncore id: 0\ncpu cores: 2\napicid: 0\ninitial apicid: 0\nfpu: yes\nfpu_exception: yes\ncpuid level: 22\nwp: yes\nflags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc pni pclmulqdq ssse3 cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx rdrand hypervisor lahf_lm abm 3dnowprefetch fsgsbase avx2 invpcid rdseed clflushopt\nbugs:\nbogomips: 6192.00\nclflush size: 64\ncache_alignment: 64\naddress sizes: 39 bits physical, 48 bits virtual\npower management:\n\nprocessor: 1\nvendor_id: GenuineIntel\ncpu family: 6\nmodel: 78\nmodel name: Intel(R) Core(TM) i5-6287U CPU @ 3.10GHz\nstepping: 3\ncpu MHz: 3096.000\ncache size: 4096 KB\nphysical id: 0\nsiblings: 2\ncore id: 1\ncpu cores: 2\napicid: 1\ninitial apicid: 1\nfpu: yes\nfpu_exception: yes\ncpuid level: 22\nwp: yes\nflags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc pni pclmulqdq ssse3 cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx rdrand hypervisor lahf_lm abm 3dnowprefetch fsgsbase avx2 invpcid rdseed clflushopt\nbugs:\nbogomips: 6192.00\nclflush size: 64\ncache_alignment: 64\naddress sizes: 39 bits physical, 48 bits virtual\npower management:\n\n" }
+
+    it {
+      expect(subject.labels).to eq([{ label: :cpu_detail },
+                                    { label: :value }])
+    }
+
+    it {
+      expect(cpu_info).to eq({ 'processor' => { cpu_detail: 'processor', value: '1' },
+                               'vendor_id' => { cpu_detail: 'vendor_id', value: 'GenuineIntel' },
+                               'cpu family' => { cpu_detail: 'cpu family', value: '6' },
+                               'model' => { cpu_detail: 'model', value: '78' },
+                               'model name' =>
+                                 { cpu_detail: 'model name',
+                                   value: 'Intel(R) Core(TM) i5-6287U CPU @ 3.10GHz' },
+                               'stepping' => { cpu_detail: 'stepping', value: '3' },
+                               'cpu MHz' => { cpu_detail: 'cpu MHz', value: '3096.000' },
+                               'cache size' => { cpu_detail: 'cache size', value: '4096 KB' },
+                               'physical id' => { cpu_detail: 'physical id', value: '0' },
+                               'siblings' => { cpu_detail: 'siblings', value: '2' },
+                               'core id' => { cpu_detail: 'core id', value: '1' },
+                               'cpu cores' => { cpu_detail: 'cpu cores', value: '2' },
+                               'apicid' => { cpu_detail: 'apicid', value: '1' },
+                               'initial apicid' => { cpu_detail: 'initial apicid', value: '1' },
+                               'fpu' => { cpu_detail: 'fpu', value: 'yes' },
+                               'fpu_exception' => { cpu_detail: 'fpu_exception', value: 'yes' },
+                               'cpuid level' => { cpu_detail: 'cpuid level', value: '22' },
+                               'wp' => { cpu_detail: 'wp', value: 'yes' },
+                               'bugs' => { cpu_detail: 'bugs', value: '' },
+                               'bogomips' => { cpu_detail: 'bogomips', value: '6192.00' },
+                               'clflush size' => { cpu_detail: 'clflush size', value: '64' },
+                               'cache_alignment' => { cpu_detail: 'cache_alignment', value: '64' },
+                               'address sizes' =>
+                                 { cpu_detail: 'address sizes', value: '39 bits physical, 48 bits virtual' },
+                               'power management' => { cpu_detail: 'power management', value: '' } })
+    }
+  end
+
+  context 'when running on MacOS' do
+    let(:data) { "      Processor Name: Intel Core i5\n      Processor Speed: 3.1 GHz\n      Number of Processors: 1\n      Total Number of Cores: 2\n      L2 Cache (per Core): 256 KB\n      L3 Cache: 4 MB\n" }
+
+    it {
+      expect(subject.labels).to eq([{ label: :cpu_detail },
+                                    { label: :value }])
+    }
+
+    it {
+      expect(cpu_info).to eq({ 'Processor Name' => { cpu_detail: 'Processor Name', value: 'Intel Core i5' },
+                               'Processor Speed' => { cpu_detail: 'Processor Speed', value: '3.1 GHz' },
+                               'Number of Processors' => { cpu_detail: 'Number of Processors', value: '1' },
+                               'Total Number of Cores' => { cpu_detail: 'Total Number of Cores', value: '2' },
+                               'L2 Cache (per Core)' => { cpu_detail: 'L2 Cache (per Core)', value: '256 KB' },
+                               'L3 Cache' => { cpu_detail: 'L3 Cache', value: '4 MB' } })
+    }
+  end
+end

data/spec/kpm/unit/disk_space_information_spec.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'kpm/system_helpers/system_proxy'
+require 'kpm/system_helpers/disk_space_information'
+
+describe KPM::SystemProxy::DiskSpaceInformation do
+  subject { described_class.new }
+  let(:data_keys) { [] }
+  let!(:disk_space_info) { subject.send(:build_hash, data, cols_count, true, data_keys) }
+
+  context 'when running on Linux' do
+    let(:cols_count) { 5 }
+    let(:data) { "Filesystem     1K-blocks     Used Available Use% Mounted on\nnone            58419028 24656532  30723884  45% /\ntmpfs              65536        0     65536   0% /dev\ntmpfs            5387012        0   5387012   0% /sys/fs/cgroup\n/dev/sda1       58419028 24656532  30723884  45% /etc/hosts\nshm                65536        0     65536   0% /dev/shm\ntmpfs            5387012        0   5387012   0% /sys/firmware\n" }
+
+    it {
+      expect(data_keys).to eq(['Filesystem', '1K-blocks', 'Used', 'Available', 'Use%', 'Mounted on'])
+    }
+
+    it {
+      expect(disk_space_info).to eq({ 'DiskInfo_2' => { :Filesystem => 'none', :"1K-blocks" => '58419028', :Used => '24656532', :Available => '30723884', :"Use%" => '45%', :Mounted_on => '/' },
+                                      'DiskInfo_3' => { :Filesystem => 'tmpfs', :"1K-blocks" => '65536', :Used => '0', :Available => '65536', :"Use%" => '0%', :Mounted_on => '/dev' },
+                                      'DiskInfo_4' => { :Filesystem => 'tmpfs', :"1K-blocks" => '5387012', :Used => '0', :Available => '5387012', :"Use%" => '0%', :Mounted_on => '/sys/fs/cgroup' },
+                                      'DiskInfo_5' => { :Filesystem => '/dev/sda1', :"1K-blocks" => '58419028', :Used => '24656532', :Available => '30723884', :"Use%" => '45%', :Mounted_on => '/etc/hosts' },
+                                      'DiskInfo_6' => { :Filesystem => 'shm', :"1K-blocks" => '65536', :Used => '0', :Available => '65536', :"Use%" => '0%', :Mounted_on => '/dev/shm' },
+                                      'DiskInfo_7' => { :Filesystem => 'tmpfs', :"1K-blocks" => '5387012', :Used => '0', :Available => '5387012', :"Use%" => '0%', :Mounted_on => '/sys/firmware' } })
+    }
+  end
+
+  context 'when running on MacOS' do
+    let(:cols_count) { 8 }
+    let(:data) { "Filesystem    512-blocks      Used Available Capacity iused               ifree %iused  Mounted on\n/dev/disk1s1   976490576 778131600 173031648    82% 2431747 9223372036852344060    0%   /\ndevfs                690       690         0   100%    1194                   0  100%   /dev\n/dev/disk1s4   976490576  23925200 173031648    13%       5 9223372036854775802    0%   /private/var/vm\nmap -hosts             0         0         0   100%       0                   0  100%   /net\nmap auto_home          0         0         0   100%       0                   0  100%   /home\n/dev/disk1s3   976490576    996584 173031648     1%      34 9223372036854775773    0%   /Volumes/Recovery\n" }
+
+    it {
+      expect(data_keys).to eq(['Filesystem', '512-blocks', 'Used', 'Available', 'Capacity', 'iused', 'ifree', '%iused', 'Mounted on'])
+    }
+
+    it {
+      expect(disk_space_info).to eq({ 'DiskInfo_2' => { :Filesystem => '/dev/disk1s1', :"512-blocks" => '976490576', :Used => '778131600', :Available => '173031648', :Capacity => '82%', :iused => '2431747', :ifree => '9223372036852344060', :"%iused" => '0%', :Mounted_on => '/' },
+                                      'DiskInfo_3' => { :Filesystem => 'devfs', :"512-blocks" => '690', :Used => '690', :Available => '0', :Capacity => '100%', :iused => '1194', :ifree => '0', :"%iused" => '100%', :Mounted_on => '/dev' },
+                                      'DiskInfo_4' => { :Filesystem => '/dev/disk1s4', :"512-blocks" => '976490576', :Used => '23925200', :Available => '173031648', :Capacity => '13%', :iused => '5', :ifree => '9223372036854775802', :"%iused" => '0%', :Mounted_on => '/private/var/vm' },
+                                      'DiskInfo_5' => { :Filesystem => 'map', :"512-blocks" => '-hosts', :Used => '0', :Available => '0', :Capacity => '0', :iused => '100%', :ifree => '0', :"%iused" => '0', :Mounted_on => '100% /net ' },
+                                      'DiskInfo_6' => { :Filesystem => 'map', :"512-blocks" => 'auto_home', :Used => '0', :Available => '0', :Capacity => '0', :iused => '100%', :ifree => '0', :"%iused" => '0', :Mounted_on => '100% /home ' },
+                                      'DiskInfo_7' => { :Filesystem => '/dev/disk1s3', :"512-blocks" => '976490576', :Used => '996584', :Available => '173031648', :Capacity => '1%', :iused => '34', :ifree => '9223372036854775773', :"%iused" => '0%', :Mounted_on => '/Volumes/Recovery' } })
+    }
+  end
+end

data/spec/kpm/unit/entropy_information_spec.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'kpm/system_helpers/system_proxy'
+require 'kpm/system_helpers/entropy_available'
+
+describe KPM::SystemProxy::EntropyAvailable do
+  subject { described_class.new }
+  let(:entropy_info) { subject.send(:build_hash, data) }
+
+  context 'when running on Linux' do
+    let(:data) { '182' }
+
+    it {
+      expect(subject.labels).to eq([{ label: :entropy },
+                                    { label: :value }])
+    }
+
+    it {
+      expect(entropy_info).to eq({ 'entropy_available' => { entropy: 'available', value: '182' } })
+    }
+  end
+
+  context 'when running on MacOS' do
+    let(:data) { '-' }
+
+    it {
+      expect(subject.labels).to eq([{ label: :entropy },
+                                    { label: :value }])
+    }
+
+    it {
+      expect(entropy_info).to eq({ 'entropy_available' => { entropy: 'available', value: '-' } })
+    }
+  end
+end

data/spec/kpm/unit/formatter_spec.rb

@@ -0,0 +1,163 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Formatter' do
+  describe KPM::Formatter::DefaultFormatter do
+    subject { described_class.new(label, input) }
+
+    context 'when arguments are nil' do
+      let(:label) { nil }
+      let(:input) { nil }
+
+      it { expect(subject.size).to eq(0) }
+      it { expect(subject.to_s).to eq('') }
+      it { expect(subject.label).to eq('') }
+    end
+
+    context 'when arguments are non-nil' do
+      let(:label) { 'my_label' }
+      let(:input) { 'my_value' }
+
+      it { expect(subject.size).to eq(8) }
+      it { expect(subject.to_s).to eq('my_value') }
+      it { expect(subject.label).to eq('MY LABEL') }
+    end
+  end
+
+  describe KPM::Formatter::VersionFormatter do
+    subject { described_class.new(label, versions) }
+
+    context 'when arguments are nil/empty' do
+      let(:label) { nil }
+      let(:versions) { [] }
+
+      it { expect(subject.size).to eq(0) }
+      it { expect(subject.to_s).to eq('') }
+      it { expect(subject.label).to eq(' sha1=[], def=(*), del=(x)') }
+    end
+
+    context 'when arguments are non-nil' do
+      let(:label) { 'my_label' }
+      let(:versions) do
+        [{ version: '1.0', is_default: false, is_disabled: false, sha1: nil },
+         { version: '2.0', is_default: true, is_disabled: true, sha1: '123456789' }]
+      end
+
+      it { expect(subject.size).to eq(29) }
+      it { expect(subject.to_s).to eq('1.0[???], 2.0[123456..](*)(x)') }
+      it { expect(subject.label).to eq('MY LABEL sha1=[], def=(*), del=(x)') }
+    end
+  end
+
+  describe KPM::Formatter do
+    subject { described_class.new }
+
+    context 'when running inspect' do
+      let(:data) do
+        { 'killbill-kpm' => { plugin_name: 'killbill-kpm', plugin_path: '/var/tmp/bundles/plugins/ruby/killbill-kpm', type: 'ruby', versions: [{ version: '1.3.0', is_default: true, is_disabled: false, sha1: 'b350016c539abc48e51c97605ac1f08b441843d3' }], plugin_key: 'kpm', group_id: 'org.kill-bill.billing.plugin.ruby', artifact_id: 'kpm-plugin', packaging: 'tar.gz', classifier: nil },
+          'hello-world-plugin' => { plugin_name: 'hello-world-plugin', plugin_path: '/var/tmp/bundles/plugins/java/hello-world-plugin', type: 'java', versions: [{ version: '1.0.1-SNAPSHOT', is_default: true, is_disabled: false, sha1: nil }], plugin_key: 'dev:hello', group_id: nil, artifact_id: nil, packaging: nil, classifier: nil },
+          'analytics-plugin' => { plugin_name: 'analytics-plugin', plugin_path: '/var/tmp/bundles/plugins/java/analytics-plugin', type: 'java', versions: [{ version: '7.0.3-SNAPSHOT', is_default: true, is_disabled: false, sha1: nil }], plugin_key: 'analytics', group_id: nil, artifact_id: nil, packaging: nil, classifier: nil } }
+      end
+      let(:labels) do
+        [{ label: :plugin_name },
+         { label: :plugin_key },
+         { label: :type },
+         { label: :group_id },
+         { label: :artifact_id },
+         { label: :packaging },
+         { label: :versions, formatter: KPM::Formatter::VersionFormatter.name }]
+      end
+      let!(:labels_format_argument) { subject.send(:compute_labels, data, labels) }
+
+      it {
+        expect(labels_format_argument).to eq(['PLUGIN NAME',
+                                              'PLUGIN KEY',
+                                              'TYPE',
+                                              'GROUP ID',
+                                              'ARTIFACT ID',
+                                              'PACKAGING',
+                                              'VERSIONS sha1=[], def=(*), del=(x)'])
+      }
+
+      it {
+        expect(labels).to eq([{ label: :plugin_name, size: 18 },
+                              { label: :plugin_key, size: 10 },
+                              { label: :type, size: 4 },
+                              { label: :group_id, size: 33 },
+                              { label: :artifact_id, size: 11 },
+                              { label: :packaging, size: 9 },
+                              { label: :versions, formatter: KPM::Formatter::VersionFormatter.name, size: 34 }])
+      }
+
+      it {
+        # labels have the size computed here already
+        expect(subject.send(:compute_border, labels)).to eq('_____________________________________________________________________________________________________________________________________________')
+      }
+
+      it {
+        # labels have the size computed here already
+        expect(subject.send(:compute_format, labels)).to eq('| %18s | %10s | %4s | %33s | %11s | %9s | %34s |')
+      }
+
+      it {
+        expect(subject.send(:format_only, data, labels)).to eq("\n_____________________________________________________________________________________________________________________________________________
+|        PLUGIN NAME | PLUGIN KEY | TYPE |                          GROUP ID | ARTIFACT ID | PACKAGING | VERSIONS sha1=[], def=(*), del=(x) |
+_____________________________________________________________________________________________________________________________________________
+|       killbill-kpm |        kpm | ruby | org.kill-bill.billing.plugin.ruby |  kpm-plugin |    tar.gz |                 1.3.0[b35001..](*) |
+| hello-world-plugin |  dev:hello | java |                               ??? |         ??? |       ??? |             1.0.1-SNAPSHOT[???](*) |
+|   analytics-plugin |  analytics | java |                               ??? |         ??? |       ??? |             7.0.3-SNAPSHOT[???](*) |
+_____________________________________________________________________________________________________________________________________________\n\n")
+      }
+    end
+
+    context 'when formatting CPU information' do
+      let(:data) do
+        { 'Processor Name' => { cpu_detail: 'Processor Name', value: 'Intel Core i5' },
+          'Processor Speed' => { cpu_detail: 'Processor Speed', value: '3.1 GHz' },
+          'Number of Processors' => { cpu_detail: 'Number of Processors', value: '1' },
+          'Total Number of Cores' => { cpu_detail: 'Total Number of Cores', value: '2' },
+          'L2 Cache (per Core)' => { cpu_detail: 'L2 Cache (per Core)', value: '256 KB' },
+          'L3 Cache' => { cpu_detail: 'L3 Cache', value: '4 MB' } }
+      end
+      let(:labels) do
+        [{ label: :cpu_detail },
+         { label: :value }]
+      end
+      let!(:labels_format_argument) { subject.send(:compute_labels, data, labels) }
+
+      it {
+        expect(labels_format_argument).to eq(['CPU DETAIL',
+                                              'VALUE'])
+      }
+
+      it {
+        expect(labels).to eq([{ label: :cpu_detail, size: 21 },
+                              { label: :value, size: 13 }])
+      }
+
+      it {
+        # labels have the size computed here already
+        expect(subject.send(:compute_border, labels)).to eq('_________________________________________')
+      }
+
+      it {
+        # labels have the size computed here already
+        expect(subject.send(:compute_format, labels)).to eq('| %21s | %13s |')
+      }
+
+      it {
+        expect(subject.send(:format_only, data, labels)).to eq("\n_________________________________________
+|            CPU DETAIL |         VALUE |
+_________________________________________
+|        Processor Name | Intel Core i5 |
+|       Processor Speed |       3.1 GHz |
+|  Number of Processors |             1 |
+| Total Number of Cores |             2 |
+|   L2 Cache (per Core) |        256 KB |
+|              L3 Cache |          4 MB |
+_________________________________________\n\n")
+      }
+    end
+  end
+end

data/spec/kpm/unit/inspector_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe KPM::Inspector do
-
   before(:each) do
     @logger = Logger.new(STDOUT)
     @logger.level = Logger::INFO
@@ -20,72 +21,64 @@ describe KPM::Inspector do
 
     @manager = KPM::PluginsManager.new(@plugins_dir, @logger)
 
-    @sha1_file = @bundles_dir.join("sha1.yml")
+    @sha1_file = @bundles_dir.join('sha1.yml')
     @sha1_checker = KPM::Sha1Checker.from_file(@sha1_file)
-
   end
 
-
   it 'should parse a correctly setup env' do
-
-    add_plugin('foo', 'plugin_foo', ['1.2.3', '2.0.0', '2.0.1'], 'ruby', 'com.foo', 'foo', 'tar.gz', nil, ['12345', '23456', '34567'], '2.0.1', ['1.2.3'])
+    add_plugin('foo', 'plugin_foo', ['1.2.3', '2.0.0', '2.0.1'], 'ruby', 'com.foo', 'foo', 'tar.gz', nil, %w[12345 23456 34567], '2.0.1', ['1.2.3'])
     add_plugin('bar', 'plugin_bar', ['1.0.0'], 'java', 'com.bar', 'bar', 'jar', nil, ['98765'], nil, [])
 
     inspector = KPM::Inspector.new
     all_plugins = inspector.inspect(@bundles_dir)
-    all_plugins.size == 2
-
-    all_plugins['plugin_bar']['plugin_key'] == 'bar'
-    all_plugins['plugin_bar']['plugin_path'] == @java_plugins_dir.join('plugin_bar').to_s
-    all_plugins['plugin_bar'][:versions].size == 1
-    all_plugins['plugin_bar'][:versions][0][:version] == '1.0.0'
-    all_plugins['plugin_bar'][:versions][0][:is_default] == true
-    all_plugins['plugin_bar'][:versions][0][:is_disabled] == false
-    all_plugins['plugin_bar'][:versions][0][:sha1] == '98765'
-
-    all_plugins['plugin_foo']['plugin_key'] == 'foo'
-    all_plugins['plugin_foo']['plugin_path'] == @ruby_plugins_dir.join('plugin_foo').to_s
-    all_plugins['plugin_foo'][:versions].size == 3
-
-    all_plugins['plugin_foo'][:versions][0][:version] == '1.2.3'
-    all_plugins['plugin_foo'][:versions][0][:is_default] == false
-    all_plugins['plugin_foo'][:versions][0][:is_disabled] == true
-    all_plugins['plugin_foo'][:versions][0][:sha1] == '12345'
-
-    all_plugins['plugin_foo'][:versions][1][:version] == '2.0.0'
-    all_plugins['plugin_foo'][:versions][1][:is_default] == false
-    all_plugins['plugin_foo'][:versions][1][:is_disabled] == false
-    all_plugins['plugin_foo'][:versions][1][:sha1] == '23456'
-
-    all_plugins['plugin_foo'][:versions][2][:version] == '2.0.1'
-    all_plugins['plugin_foo'][:versions][2][:is_default] == true
-    all_plugins['plugin_foo'][:versions][2][:is_disabled] == false
-    all_plugins['plugin_foo'][:versions][2][:sha1] == '34567'
-
+    expect(all_plugins.size).to eq 2
+
+    expect(all_plugins['plugin_bar'][:plugin_key]).to eq 'bar'
+    expect(all_plugins['plugin_bar'][:plugin_path]).to eq @java_plugins_dir.join('plugin_bar').to_s
+    expect(all_plugins['plugin_bar'][:versions].size).to eq 1
+    expect(all_plugins['plugin_bar'][:versions][0][:version]).to eq '1.0.0'
+    expect(all_plugins['plugin_bar'][:versions][0][:is_default]).to eq false
+    expect(all_plugins['plugin_bar'][:versions][0][:is_disabled]).to eq false
+    expect(all_plugins['plugin_bar'][:versions][0][:sha1]).to eq '98765'
+
+    expect(all_plugins['plugin_foo'][:plugin_key]).to eq 'foo'
+    expect(all_plugins['plugin_foo'][:plugin_path]).to eq @ruby_plugins_dir.join('plugin_foo').to_s
+    expect(all_plugins['plugin_foo'][:versions].size).to eq 3
+
+    expect(all_plugins['plugin_foo'][:versions][0][:version]).to eq '1.2.3'
+    expect(all_plugins['plugin_foo'][:versions][0][:is_default]).to eq false
+    expect(all_plugins['plugin_foo'][:versions][0][:is_disabled]).to eq true
+    expect(all_plugins['plugin_foo'][:versions][0][:sha1]).to eq '12345'
+
+    expect(all_plugins['plugin_foo'][:versions][1][:version]).to eq '2.0.0'
+    expect(all_plugins['plugin_foo'][:versions][1][:is_default]).to eq false
+    expect(all_plugins['plugin_foo'][:versions][1][:is_disabled]).to eq false
+    expect(all_plugins['plugin_foo'][:versions][1][:sha1]).to eq '23456'
+
+    expect(all_plugins['plugin_foo'][:versions][2][:version]).to eq '2.0.1'
+    expect(all_plugins['plugin_foo'][:versions][2][:is_default]).to eq true
+    expect(all_plugins['plugin_foo'][:versions][2][:is_disabled]).to eq false
+    expect(all_plugins['plugin_foo'][:versions][2][:sha1]).to eq '34567'
   end
 
-
   private
 
   def add_plugin(plugin_key, plugin_name, versions, language, group_id, artifact_id, packaging, classifier, sha1, active_version, disabled_versions)
-
     plugin_dir = language == 'ruby' ? @ruby_plugins_dir.join(plugin_name) : @java_plugins_dir.join(plugin_name)
 
     versions.each_with_index do |v, idx|
-
-      coordinate_map = {:group_id => group_id, :artifact_id => artifact_id, :version => v, :packaging => packaging, :classifier => classifier}
+      coordinate_map = { group_id: group_id, artifact_id: artifact_id, version: v, packaging: packaging, classifier: classifier }
       coordinates = KPM::Coordinates.build_coordinates(coordinate_map)
 
       @manager.add_plugin_identifier_key(plugin_key, plugin_name, language, coordinate_map)
       @sha1_checker.add_or_modify_entry!(coordinates, sha1[idx])
 
-
       plugin_dir_version = plugin_dir.join(v)
 
       FileUtils.mkdir_p(plugin_dir_version)
 
       # Create some entry to look real
-      some_file = 'ruby' ? 'ROOT' : '#{plugin_name}.jar'
+      some_file = language == 'ruby' ? 'ROOT' : "#{plugin_name}.jar"
       FileUtils.touch(plugin_dir_version.join(some_file))
     end
 
@@ -95,5 +88,4 @@ describe KPM::Inspector do
       @manager.uninstall(plugin_dir, v)
     end
   end
-
 end