knife-ionoscloud 5.1.2 → 6.0.0

data/spec/chef/knife/ionoscloud_template_list_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+require 'ionoscloud_template_list'
+
+Chef::Knife::IonoscloudTemplateList.load_deps
+
+describe Chef::Knife::IonoscloudTemplateList do
+  before :each do
+    subject { Chef::Knife::IonoscloudTemplateList.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call TemplatesApi.templates_get' do
+      templates = templates_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      template_list = [
+        subject.ui.color('ID', :bold),
+        subject.ui.color('Name', :bold),
+        subject.ui.color('Cores', :bold),
+        subject.ui.color('RAM', :bold),
+        subject.ui.color('Storage Size', :bold),
+        templates.items[0].id,
+        templates.items[0].properties.name,
+        Integer(templates.items[0].properties.cores),
+        Integer(templates.items[0].properties.ram),
+        Integer(templates.items[0].properties.storage_size),
+        templates.items[1].id,
+        templates.items[1].properties.name,
+        Integer(templates.items[1].properties.cores),
+        Integer(templates.items[1].properties.ram),
+        Integer(templates.items[1].properties.storage_size),
+      ]
+
+      expect(subject.ui).to receive(:list).with(template_list, :uneven_columns_across, 5)
+
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: '/templates',
+            operation: :'TemplatesApi.templates_get',
+            return_type: 'Templates',
+            result: templates,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_user_ssourl_spec.rb

@@ -7,7 +7,7 @@ describe Chef::Knife::IonoscloudUserSsourl do
   subject { Chef::Knife::IonoscloudUserSsourl.new }
 
   describe '#run' do
-    it 'should call UserManagementApi.um_users_ssourl_get and output the received url when the user ID is valid' do
+    it 'should call UserS3KeysApi.um_users_ssourl_get and output the received url when the user ID is valid' do
       user = user_mock
       sso_url = sso_url_mock
       subject_config = {
@@ -27,7 +27,7 @@ describe Chef::Knife::IonoscloudUserSsourl do
           {
             method: 'GET',
             path: "/um/users/#{user.id}/s3ssourl",
-            operation: :'UserManagementApi.um_users_s3ssourl_get',
+            operation: :'UserS3KeysApi.um_users_s3ssourl_get',
             return_type: 'S3ObjectStorageSSO',
             result: sso_url,
           },
@@ -59,7 +59,7 @@ describe Chef::Knife::IonoscloudUserSsourl do
           {
             method: 'GET',
             path: "/um/users/#{user_id}/s3ssourl",
-            operation: :'UserManagementApi.um_users_s3ssourl_get',
+            operation: :'UserS3KeysApi.um_users_s3ssourl_get',
             return_type: 'S3ObjectStorageSSO',
             exception: Ionoscloud::ApiError.new(code: 404),
           },

data/spec/chef/knife/ionoscloud_volume_attach_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudVolumeAttach do
   end
 
   describe '#run' do
-    it 'should call ServerApi.datacenters_servers_volumes_post when the ID is valid' do
+    it 'should call ServersApi.datacenters_servers_volumes_post when the ID is valid' do
       volume = volume_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -35,7 +35,7 @@ describe Chef::Knife::IonoscloudVolumeAttach do
           {
             method: 'POST',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/volumes",
-            operation: :'ServerApi.datacenters_servers_volumes_post',
+            operation: :'ServersApi.datacenters_servers_volumes_post',
             body: { id: volume.id },
             return_type: 'Volume',
             result: volume,
@@ -46,7 +46,7 @@ describe Chef::Knife::IonoscloudVolumeAttach do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
-    it 'should not call ServerApi.datacenters_servers_volumes_post when the ID is not valid' do
+    it 'should not call ServersApi.datacenters_servers_volumes_post when the ID is not valid' do
       volume_id = 'invalid_id'
       subject_config = {
         ionoscloud_username: 'email',
@@ -67,7 +67,7 @@ describe Chef::Knife::IonoscloudVolumeAttach do
           {
             method: 'POST',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/volumes",
-            operation: :'ServerApi.datacenters_servers_volumes_post',
+            operation: :'ServersApi.datacenters_servers_volumes_post',
             body: { id: volume_id },
             return_type: 'Volume',
             exception: Ionoscloud::ApiError.new(code: 404),

data/spec/chef/knife/ionoscloud_volume_create_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudVolumeCreate do
   end
 
   describe '#run' do
-    it 'should call VolumeApi.datacenters_volumes_post with the expected arguments and output based on what it receives' do
+    it 'should call VolumesApi.datacenters_volumes_post with the expected arguments and output based on what it receives' do
       volume = volume_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -23,29 +23,29 @@ describe Chef::Knife::IonoscloudVolumeCreate do
         type: volume.properties.type,
         bus: volume.properties.bus,
         availability_zone: volume.properties.availability_zone,
-        image_alias: 'debian:latest',
         image_password: 'K3tTj8G14a3EgKyNeeiY',
+        image: volume.properties.image,
+        backupunit_id: volume.properties.backupunit_id,
+        user_data: volume.properties.user_data,
       }
 
       subject_config.each { |key, value| subject.config[key] = value }
 
       expected_body = volume.properties.to_hash
-      expected_body.delete(:image)
       expected_body.delete(:licenceType)
 
-      expected_body[:imageAlias] = subject_config[:image_alias]
       expected_body[:imagePassword] = subject_config[:image_password]
 
       expect(subject).to receive(:puts).with("ID: #{volume.id}")
-      expect(subject).to receive(:puts).with("Name: #{subject_config[:name]}")
-      expect(subject).to receive(:puts).with("Size: #{subject_config[:size]}")
-      expect(subject).to receive(:puts).with("Bus: #{subject_config[:bus]}")
+      expect(subject).to receive(:puts).with("Name: #{volume.properties.name}")
+      expect(subject).to receive(:puts).with("Size: #{volume.properties.size}")
+      expect(subject).to receive(:puts).with("Bus: #{volume.properties.bus}")
       expect(subject).to receive(:puts).with("Image: #{volume.properties.image}")
-      expect(subject).to receive(:puts).with("Type: #{subject_config[:type]}")
+      expect(subject).to receive(:puts).with("Type: #{volume.properties.type}")
       expect(subject).to receive(:puts).with("Licence Type: #{volume.properties.licence_type}")
       expect(subject).to receive(:puts).with("Backupunit ID: #{volume.properties.backupunit_id}")
       expect(subject).to receive(:puts).with("User Data: #{volume.properties.user_data}")
-      expect(subject).to receive(:puts).with("Zone: #{subject_config[:availability_zone]}")
+      expect(subject).to receive(:puts).with("Zone: #{volume.properties.availability_zone}")
       expect(subject).to receive(:puts).with("CPU Hot Plug: #{volume.properties.cpu_hot_plug}")
       expect(subject).to receive(:puts).with("RAM Hot Plug: #{volume.properties.ram_hot_plug}")
       expect(subject).to receive(:puts).with("NIC Hot Plug: #{volume.properties.nic_hot_plug}")
@@ -53,6 +53,7 @@ describe Chef::Knife::IonoscloudVolumeCreate do
       expect(subject).to receive(:puts).with("Disc Virtio Hot Plug: #{volume.properties.disc_virtio_hot_plug}")
       expect(subject).to receive(:puts).with("Disc Virtio Hot Unplug: #{volume.properties.disc_virtio_hot_unplug}")
       expect(subject).to receive(:puts).with("Device number: #{volume.properties.device_number}")
+      expect(subject).to receive(:puts).with("PCI Slot: #{volume.properties.pci_slot}")
 
       mock_wait_for(subject)
       mock_call_api(
@@ -61,7 +62,7 @@ describe Chef::Knife::IonoscloudVolumeCreate do
           {
             method: 'POST',
             path: "/datacenters/#{subject_config[:datacenter_id]}/volumes",
-            operation: :'VolumeApi.datacenters_volumes_post',
+            operation: :'VolumesApi.datacenters_volumes_post',
             return_type: 'Volume',
             body: { properties: expected_body },
             result: volume,
@@ -69,7 +70,7 @@ describe Chef::Knife::IonoscloudVolumeCreate do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/volumes/#{volume.id}",
-            operation: :'VolumeApi.datacenters_volumes_find_by_id',
+            operation: :'VolumesApi.datacenters_volumes_find_by_id',
             return_type: 'Volume',
             result: volume,
           },

data/spec/chef/knife/ionoscloud_volume_delete_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudVolumeDelete do
   end
 
   describe '#run' do
-    it 'should call VolumeApi.datacenters_volumes_delete when the ID is valid' do
+    it 'should call VolumesApi.datacenters_volumes_delete when the ID is valid' do
       volume = volume_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -41,6 +41,7 @@ describe Chef::Knife::IonoscloudVolumeDelete do
       expect(subject).to receive(:puts).with("Disc Virtio Hot Plug: #{volume.properties.disc_virtio_hot_plug}")
       expect(subject).to receive(:puts).with("Disc Virtio Hot Unplug: #{volume.properties.disc_virtio_hot_unplug}")
       expect(subject).to receive(:puts).with("Device number: #{volume.properties.device_number}")
+      expect(subject).to receive(:puts).with("PCI Slot: #{volume.properties.pci_slot}")
       expect(subject.ui).to receive(:warn).with("Deleted Volume #{volume.id}. Request ID: ")
 
       expect(subject).not_to receive(:wait_for)
@@ -51,14 +52,14 @@ describe Chef::Knife::IonoscloudVolumeDelete do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/volumes/#{volume.id}",
-            operation: :'VolumeApi.datacenters_volumes_find_by_id',
+            operation: :'VolumesApi.datacenters_volumes_find_by_id',
             return_type: 'Volume',
             result: volume,
           },
           {
             method: 'DELETE',
             path: "/datacenters/#{subject_config[:datacenter_id]}/volumes/#{volume.id}",
-            operation: :'VolumeApi.datacenters_volumes_delete',
+            operation: :'VolumesApi.datacenters_volumes_delete',
           },
         ],
       )
@@ -66,7 +67,7 @@ describe Chef::Knife::IonoscloudVolumeDelete do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
-    it 'should not call VolumeApi.datacenters_volumes_delete when the ID is not valid' do
+    it 'should not call VolumesApi.datacenters_volumes_delete when the ID is not valid' do
       volume_id = 'invalid_id'
       subject_config = {
         ionoscloud_username: 'email',
@@ -86,7 +87,7 @@ describe Chef::Knife::IonoscloudVolumeDelete do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/volumes/#{volume_id}",
-            operation: :'VolumeApi.datacenters_volumes_find_by_id',
+            operation: :'VolumesApi.datacenters_volumes_find_by_id',
             return_type: 'Volume',
             exception: Ionoscloud::ApiError.new(code: 404),
           },

data/spec/chef/knife/ionoscloud_volume_detach_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudVolumeDetach do
   end
 
   describe '#run' do
-    it 'should call ServerApi.datacenters_servers_volumes_delete when the ID is valid' do
+    it 'should call ServersApi.datacenters_servers_volumes_delete when the ID is valid' do
       volume = volume_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -32,16 +32,7 @@ describe Chef::Knife::IonoscloudVolumeDetach do
       expect(subject).to receive(:puts).with("Image: #{volume.properties.image}")
       expect(subject).to receive(:puts).with("Type: #{volume.properties.type}")
       expect(subject).to receive(:puts).with("Licence Type: #{volume.properties.licence_type}")
-      expect(subject).to receive(:puts).with("Backupunit ID: #{volume.properties.backupunit_id}")
-      expect(subject).to receive(:puts).with("User Data: #{volume.properties.user_data}")
       expect(subject).to receive(:puts).with("Zone: #{volume.properties.availability_zone}")
-      expect(subject).to receive(:puts).with("CPU Hot Plug: #{volume.properties.cpu_hot_plug}")
-      expect(subject).to receive(:puts).with("RAM Hot Plug: #{volume.properties.ram_hot_plug}")
-      expect(subject).to receive(:puts).with("NIC Hot Plug: #{volume.properties.nic_hot_plug}")
-      expect(subject).to receive(:puts).with("NIC Hot Unplug: #{volume.properties.nic_hot_unplug}")
-      expect(subject).to receive(:puts).with("Disc Virtio Hot Plug: #{volume.properties.disc_virtio_hot_plug}")
-      expect(subject).to receive(:puts).with("Disc Virtio Hot Unplug: #{volume.properties.disc_virtio_hot_unplug}")
-      expect(subject).to receive(:puts).with("Device number: #{volume.properties.device_number}")
       expect(subject.ui).to receive(:msg).with("Detaching Volume #{volume.id} from server. Request ID: ")
 
       expect(subject).not_to receive(:wait_for)
@@ -52,14 +43,14 @@ describe Chef::Knife::IonoscloudVolumeDetach do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/volumes/#{volume.id}",
-            operation: :'ServerApi.datacenters_servers_volumes_find_by_id',
+            operation: :'ServersApi.datacenters_servers_volumes_find_by_id',
             return_type: 'Volume',
             result: volume,
           },
           {
             method: 'DELETE',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/volumes/#{volume.id}",
-            operation: :'ServerApi.datacenters_servers_volumes_delete',
+            operation: :'ServersApi.datacenters_servers_volumes_delete',
           },
         ],
       )
@@ -67,7 +58,7 @@ describe Chef::Knife::IonoscloudVolumeDetach do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
-    it 'should not call ServerApi.datacenters_servers_volumes_delete when the ID is not valid' do
+    it 'should not call ServersApi.datacenters_servers_volumes_delete when the ID is not valid' do
       volume_id = 'invalid_id'
       subject_config = {
         ionoscloud_username: 'email',
@@ -88,7 +79,7 @@ describe Chef::Knife::IonoscloudVolumeDetach do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/volumes/#{volume_id}",
-            operation: :'ServerApi.datacenters_servers_volumes_find_by_id',
+            operation: :'ServersApi.datacenters_servers_volumes_find_by_id',
             return_type: 'Volume',
             exception: Ionoscloud::ApiError.new(code: 404),
           },

data/spec/chef/knife/ionoscloud_volume_get_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudVolumeGet do
   end
 
   describe '#run' do
-    it 'should call VolumeApi.datacenters_volumes_find_by_id' do
+    it 'should call VolumesApi.datacenters_volumes_find_by_id' do
       volume = volume_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -41,6 +41,7 @@ describe Chef::Knife::IonoscloudVolumeGet do
       expect(subject).to receive(:puts).with("Disc Virtio Hot Plug: #{volume.properties.disc_virtio_hot_plug}")
       expect(subject).to receive(:puts).with("Disc Virtio Hot Unplug: #{volume.properties.disc_virtio_hot_unplug}")
       expect(subject).to receive(:puts).with("Device number: #{volume.properties.device_number}")
+      expect(subject).to receive(:puts).with("PCI Slot: #{volume.properties.pci_slot}")
 
       expect(subject.api_client).not_to receive(:wait_for)
       mock_call_api(
@@ -49,7 +50,7 @@ describe Chef::Knife::IonoscloudVolumeGet do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/volumes/#{subject_config[:volume_id]}",
-            operation: :'VolumeApi.datacenters_volumes_find_by_id',
+            operation: :'VolumesApi.datacenters_volumes_find_by_id',
             return_type: 'Volume',
             result: volume,
           },

data/spec/chef/knife/ionoscloud_volume_list_spec.rb

@@ -41,7 +41,7 @@ describe Chef::Knife::IonoscloudVolumeList do
   end
 
   describe '#run' do
-    it 'should call VolumeApi.datacenters_volumes_get when no server_id is set' do
+    it 'should call VolumesApi.datacenters_volumes_get when no server_id is set' do
       subject_config = {
         ionoscloud_username: 'email',
         ionoscloud_password: 'password',
@@ -58,7 +58,7 @@ describe Chef::Knife::IonoscloudVolumeList do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/volumes",
-            operation: :'VolumeApi.datacenters_volumes_get',
+            operation: :'VolumesApi.datacenters_volumes_get',
             return_type: 'Volumes',
             result: @volumes,
           },
@@ -68,7 +68,7 @@ describe Chef::Knife::IonoscloudVolumeList do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
-    it 'should call ServerApi.datacenters_servers_volumes_get when server_id is set' do
+    it 'should call ServersApi.datacenters_servers_volumes_get when server_id is set' do
       subject_config = {
         ionoscloud_username: 'email',
         ionoscloud_password: 'password',
@@ -87,7 +87,7 @@ describe Chef::Knife::IonoscloudVolumeList do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/volumes",
-            operation: :'ServerApi.datacenters_servers_volumes_get',
+            operation: :'ServersApi.datacenters_servers_volumes_get',
             return_type: 'AttachedVolumes',
             result: @volumes,
           },

data/spec/chef/knife/ionoscloud_volume_update_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudVolumeUpdate do
   end
 
   describe '#run' do
-    it 'should call VolumeApi.datacenters_volumes_patch' do
+    it 'should call VolumesApi.datacenters_volumes_patch' do
       volume = volume_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -50,6 +50,7 @@ describe Chef::Knife::IonoscloudVolumeUpdate do
       expect(subject).to receive(:puts).with("Disc Virtio Hot Plug: #{subject_config[:disc_virtio_hot_plug]}")
       expect(subject).to receive(:puts).with("Disc Virtio Hot Unplug: #{subject_config[:disc_virtio_hot_unplug]}")
       expect(subject).to receive(:puts).with("Device number: #{volume.properties.device_number}")
+      expect(subject).to receive(:puts).with("PCI Slot: #{volume.properties.pci_slot}")
 
       volume.properties.name = subject_config[:name]
       volume.properties.size = subject_config[:size]
@@ -67,7 +68,7 @@ describe Chef::Knife::IonoscloudVolumeUpdate do
           {
             method: 'PATCH',
             path: "/datacenters/#{subject_config[:datacenter_id]}/volumes/#{subject_config[:volume_id]}",
-            operation: :'VolumeApi.datacenters_volumes_patch',
+            operation: :'VolumesApi.datacenters_volumes_patch',
             return_type: 'Volume',
             body: {
               name: subject_config[:name],
@@ -84,7 +85,7 @@ describe Chef::Knife::IonoscloudVolumeUpdate do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/volumes/#{subject_config[:volume_id]}",
-            operation: :'VolumeApi.datacenters_volumes_find_by_id',
+            operation: :'VolumesApi.datacenters_volumes_find_by_id',
             return_type: 'Volume',
             result: volume,
           },