knife-ionoscloud 5.1.2 → 6.0.0.alpha.1

data/spec/chef/knife/ionoscloud_datacenter_delete_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudDatacenterDelete do
   end
 
   describe '#run' do
-    it 'should call DataCenterApi.datacenters_delete when the ID is valid' do
+    it 'should call DataCentersApi.datacenters_delete when the ID is valid' do
       datacenter = datacenter_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -27,9 +27,6 @@ describe Chef::Knife::IonoscloudDatacenterDelete do
       expect(subject).to receive(:puts).with("Name: #{datacenter.properties.name}")
       expect(subject).to receive(:puts).with("Description: #{datacenter.properties.description}")
       expect(subject).to receive(:puts).with("Location: #{datacenter.properties.location}")
-      expect(subject).to receive(:puts).with("Version: #{datacenter.properties.version}")
-      expect(subject).to receive(:puts).with("Features: #{datacenter.properties.features}")
-      expect(subject).to receive(:puts).with("Sec Auth Protection: #{datacenter.properties.sec_auth_protection}")
       expect(subject.ui).to receive(:warn).with("Deleted Data center #{datacenter.id}. Request ID: ")
 
       expect(subject.api_client).not_to receive(:wait_for)
@@ -40,14 +37,14 @@ describe Chef::Knife::IonoscloudDatacenterDelete do
           {
             method: 'GET',
             path: "/datacenters/#{datacenter.id}",
-            operation: :'DataCenterApi.datacenters_find_by_id',
+            operation: :'DataCentersApi.datacenters_find_by_id',
             return_type: 'Datacenter',
             result: datacenter,
           },
           {
             method: 'DELETE',
             path: "/datacenters/#{datacenter.id}",
-            operation: :'DataCenterApi.datacenters_delete',
+            operation: :'DataCentersApi.datacenters_delete',
           },
         ],
       )
@@ -55,7 +52,7 @@ describe Chef::Knife::IonoscloudDatacenterDelete do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
-    it 'should not call DataCenterApi.datacenters_delete when the user ID is not valid' do
+    it 'should not call DataCentersApi.datacenters_delete when the user ID is not valid' do
       datacenter_id = 'invalid_id'
       subject_config = {
         ionoscloud_username: 'email',
@@ -74,7 +71,7 @@ describe Chef::Knife::IonoscloudDatacenterDelete do
           {
             method: 'GET',
             path: "/datacenters/#{datacenter_id}",
-            operation: :'DataCenterApi.datacenters_find_by_id',
+            operation: :'DataCentersApi.datacenters_find_by_id',
             return_type: 'Datacenter',
             exception: Ionoscloud::ApiError.new(code: 404),
           },

data/spec/chef/knife/ionoscloud_datacenter_list_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudDatacenterList do
   end
 
   describe '#run' do
-    it 'should call DataCenterApi.datacenters_get' do
+    it 'should call DataCentersApi.datacenters_get' do
       datacenters = datacenters_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -26,8 +26,8 @@ describe Chef::Knife::IonoscloudDatacenterList do
         subject.ui.color('Name', :bold),
         subject.ui.color('Description', :bold),
         subject.ui.color('Location', :bold),
+        subject.ui.color('CPU Architectures', :bold),
         subject.ui.color('Version', :bold),
-        subject.ui.color('Sec Auth Protection', :bold),
       ]
 
       datacenters.items.each do |datacenter|
@@ -35,8 +35,8 @@ describe Chef::Knife::IonoscloudDatacenterList do
         datacenter_list << datacenter.properties.name
         datacenter_list << datacenter.properties.description
         datacenter_list << datacenter.properties.location
+        datacenter_list << datacenter.properties.cpu_architecture.map { |arch| arch.cpu_family }
         datacenter_list << datacenter.properties.version.to_s
-        datacenter_list << datacenter.properties.sec_auth_protection.to_s
       end
 
       expect(subject.ui).to receive(:list).with(datacenter_list, :uneven_columns_across, 6)
@@ -47,7 +47,7 @@ describe Chef::Knife::IonoscloudDatacenterList do
           {
             method: 'GET',
             path: '/datacenters',
-            operation: :'DataCenterApi.datacenters_get',
+            operation: :'DataCentersApi.datacenters_get',
             return_type: 'Datacenters',
             result: datacenters,
           },

data/spec/chef/knife/ionoscloud_firewall_create_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudFirewallCreate do
   end
 
   describe '#run' do
-    it 'should call NicApi.datacenters_servers_nics_firewallrules_post with the expected arguments and output based on what it receives' do
+    it 'should call FirewallRulesApi.datacenters_servers_nics_firewallrules_post with the expected arguments and output based on what it receives' do
       firewall = firewall_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -29,6 +29,7 @@ describe Chef::Knife::IonoscloudFirewallCreate do
         port_range_end: firewall.properties.port_range_end,
         icmp_type: firewall.properties.icmp_type,
         icmp_code: firewall.properties.icmp_code,
+        type: firewall.properties.type,
       }
 
       subject_config.each { |key, value| subject.config[key] = value }
@@ -43,6 +44,7 @@ describe Chef::Knife::IonoscloudFirewallCreate do
       expect(subject).to receive(:puts).with("Port Range End: #{firewall.properties.port_range_end}")
       expect(subject).to receive(:puts).with("ICMP Type: #{firewall.properties.icmp_type}")
       expect(subject).to receive(:puts).with("ICMP Code: #{firewall.properties.icmp_code}")
+      expect(subject).to receive(:puts).with("Type: #{firewall.properties.type}")
 
       mock_wait_for(subject)
       mock_call_api(
@@ -51,7 +53,7 @@ describe Chef::Knife::IonoscloudFirewallCreate do
           {
             method: 'POST',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{subject_config[:nic_id]}/firewallrules",
-            operation: :'NicApi.datacenters_servers_nics_firewallrules_post',
+            operation: :'FirewallRulesApi.datacenters_servers_nics_firewallrules_post',
             return_type: 'FirewallRule',
             body: { properties: firewall.properties.to_hash },
             result: firewall,
@@ -59,7 +61,7 @@ describe Chef::Knife::IonoscloudFirewallCreate do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{subject_config[:nic_id]}/firewallrules/#{firewall.id}",
-            operation: :'NicApi.datacenters_servers_nics_firewallrules_find_by_id',
+            operation: :'FirewallRulesApi.datacenters_servers_nics_firewallrules_find_by_id',
             return_type: 'FirewallRule',
             result: firewall,
           },

data/spec/chef/knife/ionoscloud_firewall_delete_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudFirewallDelete do
   end
 
   describe '#run' do
-    it 'should call NicApi.datacenters_servers_nics_firewallrules_firewallrules_delete when the ID is valid' do
+    it 'should call FirewallRulesApi.datacenters_servers_nics_firewallrules_firewallrules_delete when the ID is valid' do
       firewall = firewall_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -36,6 +36,7 @@ describe Chef::Knife::IonoscloudFirewallDelete do
       expect(subject).to receive(:puts).with("Port Range End: #{firewall.properties.port_range_end}")
       expect(subject).to receive(:puts).with("ICMP Type: #{firewall.properties.icmp_type}")
       expect(subject).to receive(:puts).with("ICMP Code: #{firewall.properties.icmp_code}")
+      expect(subject).to receive(:puts).with("Type: #{firewall.properties.type}")
       expect(subject.ui).to receive(:warn).with("Deleted Firewall rule #{firewall.id}. Request ID: ")
 
       expect(subject.api_client).not_to receive(:wait_for)
@@ -47,7 +48,7 @@ describe Chef::Knife::IonoscloudFirewallDelete do
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/"\
                   "nics/#{subject_config[:nic_id]}/firewallrules/#{firewall.id}",
-            operation: :'NicApi.datacenters_servers_nics_firewallrules_find_by_id',
+            operation: :'FirewallRulesApi.datacenters_servers_nics_firewallrules_find_by_id',
             return_type: 'FirewallRule',
             result: firewall,
           },
@@ -55,7 +56,7 @@ describe Chef::Knife::IonoscloudFirewallDelete do
             method: 'DELETE',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/"\
                   "nics/#{subject_config[:nic_id]}/firewallrules/#{firewall.id}",
-            operation: :'NicApi.datacenters_servers_nics_firewallrules_delete',
+            operation: :'FirewallRulesApi.datacenters_servers_nics_firewallrules_delete',
           },
         ],
       )
@@ -63,7 +64,7 @@ describe Chef::Knife::IonoscloudFirewallDelete do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
-    it 'should not call NicApi.datacenters_servers_nics_firewallrules_delete when the user ID is not valid' do
+    it 'should not call FirewallRulesApi.datacenters_servers_nics_firewallrules_delete when the user ID is not valid' do
       firewall_id = 'invalid_id'
       subject_config = {
         ionoscloud_username: 'email',
@@ -86,7 +87,7 @@ describe Chef::Knife::IonoscloudFirewallDelete do
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/"\
                   "nics/#{subject_config[:nic_id]}/firewallrules/#{firewall_id}",
-            operation: :'NicApi.datacenters_servers_nics_firewallrules_find_by_id',
+            operation: :'FirewallRulesApi.datacenters_servers_nics_firewallrules_find_by_id',
             return_type: 'FirewallRule',
             exception: Ionoscloud::ApiError.new(code: 404),
           },

data/spec/chef/knife/ionoscloud_firewall_list_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudFirewallList do
   end
 
   describe '#run' do
-    it 'should call NicApi.datacenters_servers_nics_firewallrules_get' do
+    it 'should call FirewallRulesApi.datacenters_servers_nics_firewallrules_get' do
       firewalls = firewalls_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -35,6 +35,7 @@ describe Chef::Knife::IonoscloudFirewallList do
         subject.ui.color('Port Range End', :bold),
         subject.ui.color('ICMP Type', :bold),
         subject.ui.color('ICMP CODE', :bold),
+        subject.ui.color('Type', :bold),
       ]
 
       firewalls.items.each do |firewall|
@@ -48,9 +49,10 @@ describe Chef::Knife::IonoscloudFirewallList do
         firewall_list << firewall.properties.port_range_end.to_s
         firewall_list << firewall.properties.icmp_type.to_s
         firewall_list << firewall.properties.icmp_code.to_s
+        firewall_list << firewall.properties.type.to_s
       end
 
-      expect(subject.ui).to receive(:list).with(firewall_list, :uneven_columns_across, 10)
+      expect(subject.ui).to receive(:list).with(firewall_list, :uneven_columns_across, 11)
 
       mock_call_api(
         subject,
@@ -59,7 +61,7 @@ describe Chef::Knife::IonoscloudFirewallList do
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/"\
                   "nics/#{subject_config[:nic_id]}/firewallrules",
-            operation: :'NicApi.datacenters_servers_nics_firewallrules_get',
+            operation: :'FirewallRulesApi.datacenters_servers_nics_firewallrules_get',
             return_type: 'FirewallRules',
             result: firewalls,
           },

data/spec/chef/knife/ionoscloud_flowlog_create_spec.rb

@@ -0,0 +1,254 @@
+require 'spec_helper'
+require 'ionoscloud_flowlog_create'
+
+Chef::Knife::IonoscloudFlowlogCreate.load_deps
+
+describe Chef::Knife::IonoscloudFlowlogCreate do
+  before :each do
+    subject { Chef::Knife::IonoscloudFlowlogCreate.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call FlowLogsApi.datacenters_servers_nics_flowlogs_post with the expected arguments and output based on what it receives' do
+      flowlog = flowlog_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        server_id: 'server_id',
+        nic_id: 'nic_id',
+        type: 'nic',
+        name: flowlog.properties.name,
+        action: flowlog.properties.action,
+        direction: flowlog.properties.direction,
+        bucket: flowlog.properties.bucket,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{flowlog.id}")
+      expect(subject).to receive(:puts).with("Name: #{flowlog.properties.name}")
+      expect(subject).to receive(:puts).with("Action: #{flowlog.properties.action}")
+      expect(subject).to receive(:puts).with("Direction: #{flowlog.properties.direction}")
+      expect(subject).to receive(:puts).with("Bucket: #{flowlog.properties.bucket}")
+
+      mock_wait_for(subject)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'POST',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{subject_config[:nic_id]}/flowlogs",
+            operation: :'FlowLogsApi.datacenters_servers_nics_flowlogs_post',
+            return_type: 'FlowLog',
+            body: { properties: flowlog.properties.to_hash },
+            result: flowlog,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not call FlowLogsApi.datacenters_servers_nics_flowlogs_post when server_id and nic_id are not given' do
+      flowlog = flowlog_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        type: 'nic',
+        name: flowlog.properties.name,
+        action: flowlog.properties.action,
+        direction: flowlog.properties.direction,
+        bucket: flowlog.properties.bucket,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("Missing required parameters #{[:server_id, :nic_id]}")
+
+      expect(subject.api_client).not_to receive(:call_api)
+
+      expect { subject.run }.to raise_error(SystemExit) do |error|
+        expect(error.status).to eq(1)
+      end
+    end
+
+    it 'should call NATGatewaysApi.datacenters_natgateways_flowlogs_post with the expected arguments and output based on what it receives' do
+      flowlog = flowlog_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        natgateway_id: 'natgateway_id',
+        type: 'natgateway',
+        name: flowlog.properties.name,
+        action: flowlog.properties.action,
+        direction: flowlog.properties.direction,
+        bucket: flowlog.properties.bucket,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{flowlog.id}")
+      expect(subject).to receive(:puts).with("Name: #{flowlog.properties.name}")
+      expect(subject).to receive(:puts).with("Action: #{flowlog.properties.action}")
+      expect(subject).to receive(:puts).with("Direction: #{flowlog.properties.direction}")
+      expect(subject).to receive(:puts).with("Bucket: #{flowlog.properties.bucket}")
+
+      mock_wait_for(subject)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'POST',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/natgateways/#{subject_config[:natgateway_id]}/flowlogs",
+            operation: :'NATGatewaysApi.datacenters_natgateways_flowlogs_post',
+            return_type: 'FlowLog',
+            body: { properties: flowlog.properties.to_hash },
+            result: flowlog,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not call NATGatewaysApi.datacenters_natgateways_flowlogs_post when natgateway_id is not given' do
+      flowlog = flowlog_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        type: 'natgateway',
+        name: flowlog.properties.name,
+        action: flowlog.properties.action,
+        direction: flowlog.properties.direction,
+        bucket: flowlog.properties.bucket,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("Missing required parameters #{[:natgateway_id]}")
+
+      expect(subject.api_client).not_to receive(:call_api)
+
+      expect { subject.run }.to raise_error(SystemExit) do |error|
+        expect(error.status).to eq(1)
+      end
+    end
+
+    it 'should call NetworkLoadBalancersApi.datacenters_networkloadbalancers_flowlogs_post with the expected arguments and output based on what it receives' do
+      flowlog = flowlog_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        network_loadbalancer_id: 'network_loadbalancer_id',
+        type: 'loadbalancer',
+        name: flowlog.properties.name,
+        action: flowlog.properties.action,
+        direction: flowlog.properties.direction,
+        bucket: flowlog.properties.bucket,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{flowlog.id}")
+      expect(subject).to receive(:puts).with("Name: #{flowlog.properties.name}")
+      expect(subject).to receive(:puts).with("Action: #{flowlog.properties.action}")
+      expect(subject).to receive(:puts).with("Direction: #{flowlog.properties.direction}")
+      expect(subject).to receive(:puts).with("Bucket: #{flowlog.properties.bucket}")
+
+      mock_wait_for(subject)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'POST',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}/flowlogs",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_flowlogs_post',
+            return_type: 'FlowLog',
+            body: { properties: flowlog.properties.to_hash },
+            result: flowlog,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not call NetworkLoadBalancersApi.datacenters_networkloadbalancers_flowlogs_post when network_loadbalancer_id is not given' do
+      flowlog = flowlog_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        type: 'loadbalancer',
+        name: flowlog.properties.name,
+        action: flowlog.properties.action,
+        direction: flowlog.properties.direction,
+        bucket: flowlog.properties.bucket,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("Missing required parameters #{[:network_loadbalancer_id]}")
+
+      expect(subject.api_client).not_to receive(:call_api)
+
+      expect { subject.run }.to raise_error(SystemExit) do |error|
+        expect(error.status).to eq(1)
+      end
+    end
+
+    it 'should not call anything when the wrong type is given' do
+      flowlog = flowlog_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        server_id: 'server_id',
+        natgateway_id: 'natgateway_id',
+        network_loadbalancer_id: 'network_loadbalancer_id',
+        nic_id: 'nic_id',
+        type: 'other',
+        name: flowlog.properties.name,
+        action: flowlog.properties.action,
+        direction: flowlog.properties.direction,
+        bucket: flowlog.properties.bucket,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject.ui).to receive(:error).with("Flow log cannot belong to #{subject_config[:type]}. Value must be one of ['nic', 'natgateway', 'loadbalancer']")
+
+      expect(subject.api_client).not_to receive(:call_api)
+
+      expect { subject.run }.to raise_error(SystemExit) do |error|
+        expect(error.status).to eq(1)
+      end
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end