knife-ionoscloud 5.1.2 → 6.0.0.alpha.1

data/lib/chef/knife/ionoscloud_volume_detach.rb

@@ -31,10 +31,9 @@ class Chef
 
       def run
         $stdout.sync = true
-        handle_extra_config
         validate_required_params(@required_options, config)
 
-        server_api = Ionoscloud::ServerApi.new(api_client)
+        server_api = Ionoscloud::ServersApi.new(api_client)
 
         @name_args.each do |volume_id|
           begin
@@ -49,7 +48,14 @@ class Chef
             next
           end
 
-          print_volume(volume)
+          msg_pair('ID', volume.id)
+          msg_pair('Name', volume.properties.name)
+          msg_pair('Size', volume.properties.size)
+          msg_pair('Bus', volume.properties.bus)
+          msg_pair('Image', volume.properties.image)
+          msg_pair('Type', volume.properties.type)
+          msg_pair('Licence Type', volume.properties.licence_type)
+          msg_pair('Zone', volume.properties.availability_zone)
 
           begin
             confirm('Do you really want to detach this volume')

data/lib/chef/knife/ionoscloud_volume_list.rb

@@ -29,7 +29,6 @@ class Chef
 
       def run
         $stdout.sync = true
-        handle_extra_config
         validate_required_params(@required_options, config)
 
         volume_list = [
@@ -46,10 +45,10 @@ class Chef
         opts = { depth: 1 }
 
         if config[:server_id]
-          server_api = Ionoscloud::ServerApi.new(api_client)
+          server_api = Ionoscloud::ServersApi.new(api_client)
           volumes = server_api.datacenters_servers_volumes_get(config[:datacenter_id], config[:server_id], opts)
         else
-          volume_api = Ionoscloud::VolumeApi.new(api_client)
+          volume_api = Ionoscloud::VolumesApi.new(api_client)
           volumes = volume_api.datacenters_volumes_get(config[:datacenter_id], opts)
         end
 

data/lib/knife-ionoscloud/version.rb

@@ -1,6 +1,6 @@
 module Knife
   module Ionoscloud
-    VERSION = '5.1.2'
+    VERSION = '6.0.0.alpha.1'
     MAJOR, MINOR, TINY = VERSION.split('.')
   end
 end

data/spec/chef/knife/ionoscloud_backupunit_create_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudBackupunitCreate do
   end
 
   describe '#run' do
-    it 'should call BackupUnitApi.backupunits_post with the expected arguments and output based on what it receives' do
+    it 'should call BackupUnitsApi.backupunits_post with the expected arguments and output based on what it receives' do
       backupunit = backupunit_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -33,7 +33,7 @@ describe Chef::Knife::IonoscloudBackupunitCreate do
           {
             method: 'POST',
             path: '/backupunits',
-            operation: :'BackupUnitApi.backupunits_post',
+            operation: :'BackupUnitsApi.backupunits_post',
             return_type: 'BackupUnit',
             body: { properties: backupunit.properties.to_hash },
             result: backupunit,

data/spec/chef/knife/ionoscloud_backupunit_delete_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudBackupunitDelete do
   end
 
   describe '#run' do
-    it 'should call BackupUnitApi.backupunits_delete when the ID is valid' do
+    it 'should call BackupUnitsApi.backupunits_delete when the ID is valid' do
       backupunit = backupunit_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -36,14 +36,14 @@ describe Chef::Knife::IonoscloudBackupunitDelete do
           {
             method: 'GET',
             path: "/backupunits/#{backupunit.id}",
-            operation: :'BackupUnitApi.backupunits_find_by_id',
+            operation: :'BackupUnitsApi.backupunits_find_by_id',
             return_type: 'BackupUnit',
             result: backupunit,
           },
           {
             method: 'DELETE',
             path: "/backupunits/#{backupunit.id}",
-            operation: :'BackupUnitApi.backupunits_delete',
+            operation: :'BackupUnitsApi.backupunits_delete',
           },
         ],
       )
@@ -51,7 +51,7 @@ describe Chef::Knife::IonoscloudBackupunitDelete do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
-    it 'should not call BackupUnitApi.backupunits_delete when the ID is not valid' do
+    it 'should not call BackupUnitsApi.backupunits_delete when the ID is not valid' do
       backup_unit = 'invalid_id'
       subject_config = {
         ionoscloud_username: 'email',
@@ -70,7 +70,7 @@ describe Chef::Knife::IonoscloudBackupunitDelete do
           {
             method: 'GET',
             path: "/backupunits/#{backup_unit}",
-            operation: :'BackupUnitApi.backupunits_find_by_id',
+            operation: :'BackupUnitsApi.backupunits_find_by_id',
             return_type: 'BackupUnit',
             exception: Ionoscloud::ApiError.new(code: 404),
           },

data/spec/chef/knife/ionoscloud_backupunit_list_spec.rb

@@ -41,7 +41,7 @@ describe Chef::Knife::IonoscloudBackupunitList do
           {
             method: 'GET',
             path: '/backupunits',
-            operation: :'BackupUnitApi.backupunits_get',
+            operation: :'BackupUnitsApi.backupunits_get',
             return_type: 'BackupUnits',
             result: backupunits,
           },

data/spec/chef/knife/ionoscloud_backupunit_ssourl_spec.rb

@@ -7,7 +7,7 @@ describe Chef::Knife::IonoscloudBackupunitSsourl do
   subject { Chef::Knife::IonoscloudBackupunitSsourl.new }
 
   describe '#run' do
-    it 'should call BackupUnitApi.backupunits_ssourl_get and output the received url when the user ID is valid' do
+    it 'should call BackupUnitsApi.backupunits_ssourl_get and output the received url when the user ID is valid' do
       backupunit = backupunit_mock
       backupunit_sso = backupunit_sso_mock
       subject_config = {
@@ -27,7 +27,7 @@ describe Chef::Knife::IonoscloudBackupunitSsourl do
           {
             method: 'GET',
             path: "/backupunits/#{backupunit.id}/ssourl",
-            operation: :'BackupUnitApi.backupunits_ssourl_get',
+            operation: :'BackupUnitsApi.backupunits_ssourl_get',
             return_type: 'BackupUnitSSO',
             result: backupunit_sso,
           },
@@ -59,7 +59,7 @@ describe Chef::Knife::IonoscloudBackupunitSsourl do
           {
             method: 'GET',
             path: "/backupunits/#{backupunit_id}/ssourl",
-            operation: :'BackupUnitApi.backupunits_ssourl_get',
+            operation: :'BackupUnitsApi.backupunits_ssourl_get',
             return_type: 'BackupUnitSSO',
             exception: Ionoscloud::ApiError.new(code: 404),
           },

data/spec/chef/knife/ionoscloud_base_spec.rb

@@ -27,7 +27,7 @@ describe Chef::Knife::IonoscloudBaseTest do
           {
             method: 'GET',
             path: "/requests/#{request_id}/status",
-            operation: :'RequestApi.requests_status_get',
+            operation: :'RequestsApi.requests_status_get',
             return_type: 'RequestStatus',
             result: request_status,
           },
@@ -47,7 +47,7 @@ describe Chef::Knife::IonoscloudBaseTest do
           {
             method: 'GET',
             path: "/requests/#{request_id}/status",
-            operation: :'RequestApi.requests_status_get',
+            operation: :'RequestsApi.requests_status_get',
             return_type: 'RequestStatus',
             result: request_status,
           },
@@ -67,7 +67,7 @@ describe Chef::Knife::IonoscloudBaseTest do
           {
             method: 'GET',
             path: "/requests/#{request_id}/status",
-            operation: :'RequestApi.requests_status_get',
+            operation: :'RequestsApi.requests_status_get',
             return_type: 'RequestStatus',
             result: request_status,
           },
@@ -89,7 +89,7 @@ describe Chef::Knife::IonoscloudBaseTest do
           {
             method: 'GET',
             path: "/requests/#{request_id}/status",
-            operation: :'RequestApi.requests_status_get',
+            operation: :'RequestsApi.requests_status_get',
             return_type: 'RequestStatus',
             result: request_status,
           },

data/spec/chef/knife/ionoscloud_composite_server_create_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudCompositeServerCreate do
   end
 
   describe '#run' do
-    it 'should call ServerApi.datacenters_servers_post with the expected arguments and output based on what it receives' do
+    it 'should call ServersApi.datacenters_servers_post with the expected arguments and output based on what it receives' do
       server = server_mock({ volumes: Ionoscloud::Volumes.new(items: [volume_mock]), nics: Ionoscloud::Nics.new(items: [nic_mock]) })
       subject_config = {
         ionoscloud_username: 'email',
@@ -30,15 +30,16 @@ describe Chef::Knife::IonoscloudCompositeServerCreate do
         type: server.entities.volumes.items.first.properties.type,
         bus: server.entities.volumes.items.first.properties.bus,
         volume_availability_zone: server.entities.volumes.items.first.properties.availability_zone,
-        licence_type: server.entities.volumes.items.first.properties.licence_type,
-        image_alias: 'debian:latest',
+        image: server.entities.volumes.items.first.properties.image,
+        backupunit_id: server.entities.volumes.items.first.properties.backupunit_id,
+        user_data: server.entities.volumes.items.first.properties.user_data,
         image_password: 'K3tTj8G14a3EgKyNeeiY',
 
         lan: server.entities.nics.items.first.properties.lan,
         nic_name: server.entities.nics.items.first.properties.name,
         dhcp: server.entities.nics.items.first.properties.dhcp,
         ips: server.entities.nics.items.first.properties.ips.join(','),
-        nat: server.entities.nics.items.first.properties.nat,
+        firewall_type: server.entities.nics.items.first.properties.firewall_type,
       }
 
       subject_config.each { |key, value| subject.config[key] = value }
@@ -56,13 +57,15 @@ describe Chef::Knife::IonoscloudCompositeServerCreate do
 
       expected_entities = server.entities.to_hash
       expected_entities[:volumes][:items][0].delete(:id)
-      expected_entities[:volumes][:items][0][:properties].delete(:image)
       expected_entities[:nics][:items][0].delete(:id)
       expected_entities[:nics][:items][0].delete(:entities)
       expected_entities[:nics][:items][0][:properties].delete(:mac)
       expected_entities[:nics][:items][0][:properties].delete(:firewallActive)
+      expected_entities[:nics][:items][0][:properties].delete(:deviceNumber)
+      expected_entities[:nics][:items][0][:properties].delete(:pciSlot)
 
-      expected_entities[:volumes][:items][0][:properties][:imageAlias] = subject_config[:image_alias]
+      expected_entities[:volumes][:items][0][:properties].delete(:licenceType)
+      expected_entities[:volumes][:items][0][:properties][:image] = subject_config[:image]
       expected_entities[:volumes][:items][0][:properties][:imagePassword] = subject_config[:image_password]
 
       mock_wait_for(subject)
@@ -72,7 +75,7 @@ describe Chef::Knife::IonoscloudCompositeServerCreate do
           {
             method: 'POST',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers",
-            operation: :'ServerApi.datacenters_servers_post',
+            operation: :'ServersApi.datacenters_servers_post',
             return_type: 'Server',
             body: { properties: expected_properties, entities: expected_entities },
             result: server,
@@ -80,7 +83,7 @@ describe Chef::Knife::IonoscloudCompositeServerCreate do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{server.id}",
-            operation: :'ServerApi.datacenters_servers_find_by_id',
+            operation: :'ServersApi.datacenters_servers_find_by_id',
             return_type: 'Server',
             result: server,
           },

data/spec/chef/knife/ionoscloud_contract_list_spec.rb

@@ -12,8 +12,8 @@ describe Chef::Knife::IonoscloudContractList do
   end
 
   describe '#run' do
-    it 'should call ContractApi.contracts_get' do
-      contract = contract_mock
+    it 'should call ContractResourcesApi.contracts_get' do
+      contracts = contracts_mock
       subject_config = {
         ionoscloud_username: 'email',
         ionoscloud_password: 'password',
@@ -21,28 +21,33 @@ describe Chef::Knife::IonoscloudContractList do
 
       subject_config.each { |key, value| subject.config[key] = value }
 
-      expect(subject).to receive(:puts).with("Contract Type: #{contract.type}")
-      expect(subject).to receive(:puts).with("Contract Owner: #{contract.properties.owner}")
-      expect(subject).to receive(:puts).with("Contract Number: #{contract.properties.contract_number}")
-      expect(subject).to receive(:puts).with("Registration Domain: #{contract.properties.reg_domain}")
-      expect(subject).to receive(:puts).with("Status: #{contract.properties.status}")
-      expect(subject).to receive(:puts).with("Cores per contract: #{contract.properties.resource_limits.cores_per_contract}")
-      expect(subject).to receive(:puts).with("Cores per server: #{contract.properties.resource_limits.cores_per_server}")
-      expect(subject).to receive(:puts).with("Cores provisioned: #{contract.properties.resource_limits.cores_provisioned}")
-      expect(subject).to receive(:puts).with("HDD limit per contract: #{contract.properties.resource_limits.hdd_limit_per_contract}")
-      expect(subject).to receive(:puts).with("HDD limit per volume: #{contract.properties.resource_limits.hdd_limit_per_volume}")
-      expect(subject).to receive(:puts).with("HDD volume provisioned: #{contract.properties.resource_limits.hdd_volume_provisioned}")
-      expect(subject).to receive(:puts).with("RAM per contract: #{contract.properties.resource_limits.ram_per_contract}")
-      expect(subject).to receive(:puts).with("RAM per server: #{contract.properties.resource_limits.ram_per_server}")
-      expect(subject).to receive(:puts).with("RAM provisioned: #{contract.properties.resource_limits.ram_provisioned}")
-      expect(subject).to receive(:puts).with("Reservable IPs: #{contract.properties.resource_limits.reservable_ips}")
-      expect(subject).to receive(:puts).with("Reservable IPs in use: #{contract.properties.resource_limits.reserved_ips_in_use}")
-      expect(subject).to receive(:puts).with("Reservable IPs on contract: #{contract.properties.resource_limits.reserved_ips_on_contract}")
-      expect(subject).to receive(:puts).with("SSD limit per contract: #{contract.properties.resource_limits.ssd_limit_per_contract}")
-      expect(subject).to receive(:puts).with("SSD limit per volume: #{contract.properties.resource_limits.ssd_limit_per_volume}")
-      expect(subject).to receive(:puts).with("SSD volume provisioned: #{contract.properties.resource_limits.ssd_volume_provisioned}")
-      expect(subject).to receive(:puts).with("K8s Cluster Limit Total: #{contract.properties.resource_limits.k8s_cluster_limit_total}")
-      expect(subject).to receive(:puts).with("K8s Clusters provisioned: #{contract.properties.resource_limits.k8s_clusters_provisioned}")
+      expect(subject).to receive(:puts).with("Contract Type: #{contracts.items.first.type}")
+      expect(subject).to receive(:puts).with("Contract Owner: #{contracts.items.first.properties.owner}")
+      expect(subject).to receive(:puts).with("Contract Number: #{contracts.items.first.properties.contract_number}")
+      expect(subject).to receive(:puts).with("Registration Domain: #{contracts.items.first.properties.reg_domain}")
+      expect(subject).to receive(:puts).with("Status: #{contracts.items.first.properties.status}")
+      expect(subject).to receive(:puts).with("Cores per contract: #{contracts.items.first.properties.resource_limits.cores_per_contract}")
+      expect(subject).to receive(:puts).with("Cores per server: #{contracts.items.first.properties.resource_limits.cores_per_server}")
+      expect(subject).to receive(:puts).with("Cores provisioned: #{contracts.items.first.properties.resource_limits.cores_provisioned}")
+      expect(subject).to receive(:puts).with("HDD limit per contract: #{contracts.items.first.properties.resource_limits.hdd_limit_per_contract}")
+      expect(subject).to receive(:puts).with("HDD limit per volume: #{contracts.items.first.properties.resource_limits.hdd_limit_per_volume}")
+      expect(subject).to receive(:puts).with("HDD volume provisioned: #{contracts.items.first.properties.resource_limits.hdd_volume_provisioned}")
+      expect(subject).to receive(:puts).with("RAM per contract: #{contracts.items.first.properties.resource_limits.ram_per_contract}")
+      expect(subject).to receive(:puts).with("RAM per server: #{contracts.items.first.properties.resource_limits.ram_per_server}")
+      expect(subject).to receive(:puts).with("RAM provisioned: #{contracts.items.first.properties.resource_limits.ram_provisioned}")
+      expect(subject).to receive(:puts).with("Reservable IPs: #{contracts.items.first.properties.resource_limits.reservable_ips}")
+      expect(subject).to receive(:puts).with("Reservable IPs in use: #{contracts.items.first.properties.resource_limits.reserved_ips_in_use}")
+      expect(subject).to receive(:puts).with("Reservable IPs on contract: #{contracts.items.first.properties.resource_limits.reserved_ips_on_contract}")
+      expect(subject).to receive(:puts).with("SSD limit per contract: #{contracts.items.first.properties.resource_limits.ssd_limit_per_contract}")
+      expect(subject).to receive(:puts).with("SSD limit per volume: #{contracts.items.first.properties.resource_limits.ssd_limit_per_volume}")
+      expect(subject).to receive(:puts).with("SSD volume provisioned: #{contracts.items.first.properties.resource_limits.ssd_volume_provisioned}")
+      expect(subject).to receive(:puts).with("DAS volume provisioned: #{contracts.items.first.properties.resource_limits.das_volume_provisioned}")
+      expect(subject).to receive(:puts).with("K8s Cluster Limit Total: #{contracts.items.first.properties.resource_limits.k8s_cluster_limit_total}")
+      expect(subject).to receive(:puts).with("K8s Clusters provisioned: #{contracts.items.first.properties.resource_limits.k8s_clusters_provisioned}")
+      expect(subject).to receive(:puts).with("NLB total limit: #{contracts.items.first.properties.resource_limits.nlb_limit_total}")
+      expect(subject).to receive(:puts).with("NLBs provisioned: #{contracts.items.first.properties.resource_limits.nlb_provisioned}")
+      expect(subject).to receive(:puts).with("NAT gateway total limit: #{contracts.items.first.properties.resource_limits.nat_gateway_limit_total}")
+      expect(subject).to receive(:puts).with("NAT gateways provisioned: #{contracts.items.first.properties.resource_limits.nat_gateway_provisioned}")
 
       mock_call_api(
         subject,
@@ -50,9 +55,9 @@ describe Chef::Knife::IonoscloudContractList do
           {
             method: 'GET',
             path: '/contracts',
-            operation: :'ContractApi.contracts_get',
-            return_type: 'Contract',
-            result: contract,
+            operation: :'ContractResourcesApi.contracts_get',
+            return_type: 'Contracts',
+            result: contracts,
           },
         ],
       )

data/spec/chef/knife/ionoscloud_cube_server_create_spec.rb

@@ -0,0 +1,249 @@
+require 'spec_helper'
+require 'ionoscloud_cube_server_create'
+
+Chef::Knife::IonoscloudCubeServerCreate.load_deps
+
+describe Chef::Knife::IonoscloudCubeServerCreate do
+  before :each do
+    subject { Chef::Knife::IonoscloudCubeServerCreate.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call ServersApi.datacenters_servers_post with the expected arguments and also make another call to set the boot_volume when set_boot is sent' do
+      template = template_mock
+      server = server_mock(
+        volumes: Ionoscloud::Volumes.new(items: [volume_mock(size: template.properties.storage_size, type: 'DAS')]),
+        nics: Ionoscloud::Nics.new(items: [nic_mock]),
+        ram: template.properties.ram,
+        cores: template.properties.cores,
+        boot_volume: nil,
+        boot_cdrom: Ionoscloud::ResourceReference.new({ id: nil }),
+      )
+
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+
+        template: template.id,
+        name: server.properties.name,
+        cpu_family: server.properties.cpu_family,
+        availability_zone: server.properties.availability_zone,
+
+        volume_name: server.entities.volumes.items.first.properties.name,
+        type: server.entities.volumes.items.first.properties.type,
+        bus: server.entities.volumes.items.first.properties.bus,
+        image: SecureRandom.uuid,
+        image_password: 'K3tTj8G14a3EgKyNeeiY',
+        backupunit_id: server.entities.volumes.items.first.properties.backupunit_id,
+        user_data: server.entities.volumes.items.first.properties.user_data,
+
+        set_boot: true,
+
+        lan: server.entities.nics.items.first.properties.lan,
+        nic_name: server.entities.nics.items.first.properties.name,
+        dhcp: server.entities.nics.items.first.properties.dhcp,
+        ips: server.entities.nics.items.first.properties.ips.join(','),
+        firewall_type: server.entities.nics.items.first.properties.firewall_type,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{server.id}")
+      expect(subject).to receive(:puts).with("Name: #{server.properties.name}")
+      expect(subject).to receive(:puts).with("Type: #{server.properties.type}")
+      expect(subject).to receive(:puts).with("Cores: #{server.properties.cores}")
+      expect(subject).to receive(:puts).with("CPU Family: #{server.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Ram: #{server.properties.ram}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{server.properties.availability_zone}")
+      expect(subject).to receive(:puts).with("Boot Volume: #{server.entities.volumes.items.first.id}")
+      expect(subject).to receive(:puts).with("Boot CDROM: ")
+
+      expected_properties = server.properties.to_hash
+      expected_properties.delete(:bootCdrom)
+      expected_properties.delete(:bootVolume)
+      expected_properties.delete(:cores)
+      expected_properties.delete(:ram)
+      expected_properties[:type] = 'CUBE'
+      expected_properties[:templateUuid] = template.id
+
+      expected_entities = server.entities.to_hash
+      expected_entities[:volumes][:items][0].delete(:id)
+      expected_entities[:volumes][:items][0][:properties].delete(:size)
+      expected_entities[:volumes][:items][0][:properties].delete(:availabilityZone)
+      expected_entities[:nics][:items][0].delete(:id)
+      expected_entities[:nics][:items][0].delete(:entities)
+      expected_entities[:nics][:items][0][:properties].delete(:mac)
+      expected_entities[:nics][:items][0][:properties].delete(:firewallActive)
+      expected_entities[:nics][:items][0][:properties].delete(:deviceNumber)
+      expected_entities[:nics][:items][0][:properties].delete(:pciSlot)
+
+      expected_entities[:volumes][:items][0][:properties].delete(:licenceType)
+      expected_entities[:volumes][:items][0][:properties][:image] = subject_config[:image]
+      expected_entities[:volumes][:items][0][:properties][:imagePassword] = subject_config[:image_password]
+
+      server.properties.boot_volume = Ionoscloud::ResourceReference.new({ id: server.entities.volumes.items.first.id })
+
+      mock_wait_for(subject)
+      mock_wait_for(subject)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'POST',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers",
+            operation: :'ServersApi.datacenters_servers_post',
+            return_type: 'Server',
+            body: { properties: expected_properties, entities: expected_entities },
+            result: server,
+          },
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{server.id}",
+            operation: :'ServersApi.datacenters_servers_find_by_id',
+            return_type: 'Server',
+            result: server,
+          },
+          {
+            method: 'PATCH',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{server.id}",
+            operation: :'ServersApi.datacenters_servers_patch',
+            return_type: 'Server',
+            body: { bootVolume: { id: server.entities.volumes.items[0].id } },
+            result: server,
+          },
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{server.id}",
+            operation: :'ServersApi.datacenters_servers_find_by_id',
+            return_type: 'Server',
+            result: server,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should call ServersApi.datacenters_servers_post with the expected arguments and should not make another call to set the boot_volume when set_boot is not sent' do
+      template = template_mock
+      server = server_mock(
+        volumes: Ionoscloud::Volumes.new(items: [volume_mock(size: template.properties.storage_size, type: 'DAS')]),
+        nics: Ionoscloud::Nics.new(items: [nic_mock]),
+        ram: template.properties.ram,
+        cores: template.properties.cores,
+        boot_volume: nil,
+        boot_cdrom: Ionoscloud::ResourceReference.new({ id: nil }),
+      )
+
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+
+        template: template.id,
+        name: server.properties.name,
+        cpu_family: server.properties.cpu_family,
+        availability_zone: server.properties.availability_zone,
+
+        volume_name: server.entities.volumes.items.first.properties.name,
+        type: server.entities.volumes.items.first.properties.type,
+        bus: server.entities.volumes.items.first.properties.bus,
+        image: SecureRandom.uuid,
+        image_password: 'K3tTj8G14a3EgKyNeeiY',
+        backupunit_id: server.entities.volumes.items.first.properties.backupunit_id,
+        user_data: server.entities.volumes.items.first.properties.user_data,
+
+        set_boot: false,
+
+        lan: server.entities.nics.items.first.properties.lan,
+        nic_name: server.entities.nics.items.first.properties.name,
+        dhcp: server.entities.nics.items.first.properties.dhcp,
+        ips: server.entities.nics.items.first.properties.ips.join(','),
+        firewall_type: server.entities.nics.items.first.properties.firewall_type,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{server.id}")
+      expect(subject).to receive(:puts).with("Name: #{server.properties.name}")
+      expect(subject).to receive(:puts).with("Type: #{server.properties.type}")
+      expect(subject).to receive(:puts).with("Cores: #{server.properties.cores}")
+      expect(subject).to receive(:puts).with("CPU Family: #{server.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Ram: #{server.properties.ram}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{server.properties.availability_zone}")
+      expect(subject).to receive(:puts).with("Boot Volume: #{server.entities.volumes.items.first.id}")
+      expect(subject).to receive(:puts).with("Boot CDROM: ")
+
+      expected_properties = server.properties.to_hash
+      expected_properties.delete(:bootCdrom)
+      expected_properties.delete(:bootVolume)
+      expected_properties.delete(:cores)
+      expected_properties.delete(:ram)
+      expected_properties[:type] = 'CUBE'
+      expected_properties[:templateUuid] = template.id
+
+      expected_entities = server.entities.to_hash
+      expected_entities[:volumes][:items][0].delete(:id)
+      expected_entities[:volumes][:items][0][:properties].delete(:size)
+      expected_entities[:volumes][:items][0][:properties].delete(:availabilityZone)
+      expected_entities[:nics][:items][0].delete(:id)
+      expected_entities[:nics][:items][0].delete(:entities)
+      expected_entities[:nics][:items][0][:properties].delete(:mac)
+      expected_entities[:nics][:items][0][:properties].delete(:firewallActive)
+      expected_entities[:nics][:items][0][:properties].delete(:deviceNumber)
+      expected_entities[:nics][:items][0][:properties].delete(:pciSlot)
+
+      expected_entities[:volumes][:items][0][:properties].delete(:licenceType)
+      expected_entities[:volumes][:items][0][:properties][:image] = subject_config[:image]
+      expected_entities[:volumes][:items][0][:properties][:imagePassword] = subject_config[:image_password]
+
+      server.properties.boot_volume = Ionoscloud::ResourceReference.new({ id: server.entities.volumes.items.first.id })
+
+      mock_wait_for(subject)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'POST',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers",
+            operation: :'ServersApi.datacenters_servers_post',
+            return_type: 'Server',
+            body: { properties: expected_properties, entities: expected_entities },
+            result: server,
+          },
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{server.id}",
+            operation: :'ServersApi.datacenters_servers_find_by_id',
+            return_type: 'Server',
+            result: server,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_datacenter_create_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudDatacenterCreate do
   end
 
   describe '#run' do
-    it 'should call DataCenterApi.datacenters_post with the expected arguments and output based on what it receives' do
+    it 'should call DataCentersApi.datacenters_post with the expected arguments and output based on what it receives' do
       datacenter = datacenter_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -29,12 +29,10 @@ describe Chef::Knife::IonoscloudDatacenterCreate do
       expect(subject).to receive(:puts).with("Name: #{datacenter.properties.name}")
       expect(subject).to receive(:puts).with("Description: #{datacenter.properties.description}")
       expect(subject).to receive(:puts).with("Location: #{datacenter.properties.location}")
-      expect(subject).to receive(:puts).with("Version: #{datacenter.properties.version}")
-      expect(subject).to receive(:puts).with("Features: #{datacenter.properties.features}")
-      expect(subject).to receive(:puts).with("Sec Auth Protection: #{datacenter.properties.sec_auth_protection}")
 
       expected_body = datacenter.properties.to_hash
       expected_body.delete(:version)
+      expected_body.delete(:cpuArchitecture)
 
       mock_wait_for(subject)
       mock_call_api(
@@ -43,18 +41,11 @@ describe Chef::Knife::IonoscloudDatacenterCreate do
           {
             method: 'POST',
             path: '/datacenters',
-            operation: :'DataCenterApi.datacenters_post',
+            operation: :'DataCentersApi.datacenters_post',
             return_type: 'Datacenter',
             body: { properties: expected_body },
             result: datacenter,
           },
-          {
-            method: 'GET',
-            path: "/datacenters/#{datacenter.id}",
-            operation: :'DataCenterApi.datacenters_find_by_id',
-            return_type: 'Datacenter',
-            result: datacenter,
-          },
         ],
       )