knapsack_pro 1.20.1 → 1.22.2

data/spec/knapsack_pro/test_case_mergers/base_merger_spec.rb

@@ -0,0 +1,27 @@
+describe KnapsackPro::TestCaseMergers::BaseMerger do
+  describe '.call' do
+    let(:test_files) { double }
+
+    subject { described_class.call(adapter_class, test_files) }
+
+    context 'when adapter_class is KnapsackPro::Adapters::RSpecAdapter' do
+      let(:adapter_class) { KnapsackPro::Adapters::RSpecAdapter }
+
+      it do
+        result = double
+        rspec_merger = instance_double(KnapsackPro::TestCaseMergers::RSpecMerger, call: result)
+        expect(KnapsackPro::TestCaseMergers::RSpecMerger).to receive(:new).with(test_files).and_return(rspec_merger)
+
+        expect(subject).to eq result
+      end
+    end
+
+    context 'when adapter_class is unknown' do
+      let(:adapter_class) { 'fake-adapter' }
+
+      it do
+        expect { subject }.to raise_error 'Test case merger does not exist for adapter_class: fake-adapter'
+      end
+    end
+  end
+end

data/spec/knapsack_pro/test_case_mergers/rspec_merger_spec.rb

@@ -0,0 +1,59 @@
+describe KnapsackPro::TestCaseMergers::RSpecMerger do
+  describe '#call' do
+    subject { described_class.new(test_files).call }
+
+    context 'when all test files are not test example paths' do
+      let(:test_files) do
+        [
+          { 'path' => 'spec/a_spec.rb', 'time_execution' => 1.1 },
+          { 'path' => 'spec/b_spec.rb', 'time_execution' => 2.2 },
+        ]
+      end
+
+      it do
+        expect(subject).to eq([
+          { 'path' => 'spec/a_spec.rb', 'time_execution' => 1.1 },
+          { 'path' => 'spec/b_spec.rb', 'time_execution' => 2.2 },
+        ])
+      end
+    end
+
+    context 'when test files have test example paths' do
+      let(:test_files) do
+        [
+          { 'path' => 'spec/a_spec.rb', 'time_execution' => 1.1 },
+          # test example paths
+          { 'path' => 'spec/test_case_spec.rb[1:1]', 'time_execution' => 2.2 },
+          { 'path' => 'spec/test_case_spec.rb[1:2]', 'time_execution' => 0.8 },
+        ]
+      end
+
+      it 'returns merged paths for test examples and sum of their time_execution' do
+        expect(subject).to eq([
+          { 'path' => 'spec/a_spec.rb', 'time_execution' => 1.1 },
+          { 'path' => 'spec/test_case_spec.rb', 'time_execution' => 3.0 },
+        ])
+      end
+    end
+
+    context 'when test files have test example paths and at the same time test file path for test example path is present as full test file path' do
+      let(:test_files) do
+        [
+          { 'path' => 'spec/a_spec.rb', 'time_execution' => 1.1 },
+          # full test file path is present despite existing test example paths
+          { 'path' => 'spec/test_case_spec.rb', 'time_execution' => 1.0 },
+          # test example paths
+          { 'path' => 'spec/test_case_spec.rb[1:1]', 'time_execution' => 2.2 },
+          { 'path' => 'spec/test_case_spec.rb[1:2]', 'time_execution' => 0.8 },
+        ]
+      end
+
+      it 'returns merged paths for test examples and sum of their time_execution' do
+        expect(subject).to eq([
+          { 'path' => 'spec/a_spec.rb', 'time_execution' => 1.1 },
+          { 'path' => 'spec/test_case_spec.rb', 'time_execution' => 4.0 },
+        ])
+      end
+    end
+  end
+end

data/spec/knapsack_pro/test_file_finder_spec.rb

@@ -7,29 +7,105 @@ describe KnapsackPro::TestFileFinder do
 
     before do
       test_file_finder = instance_double(described_class, call: test_files)
-      expect(described_class).to receive(:new).with(test_file_pattern).and_return(test_file_finder)
+      expect(described_class).to receive(:new).with(test_file_pattern, true).and_return(test_file_finder)
     end
 
     it { should eq test_files }
   end
 
+  describe '.slow_test_files_by_pattern' do
+    let(:adapter_class) { double }
+
+    subject { described_class.slow_test_files_by_pattern(adapter_class) }
+
+    before do
+      expect(KnapsackPro::Config::Env).to receive(:slow_test_file_pattern).at_least(1).and_return(slow_test_file_pattern)
+    end
+
+    context 'when slow_test_file_pattern is present' do
+      let(:slow_test_file_pattern) { double }
+      let(:test_file_entities) do
+        [
+          { 'path' => 'a_spec.rb' },
+          { 'path' => 'b_spec.rb' },
+          { 'path' => 'c_spec.rb' },
+        ]
+      end
+      let(:slow_test_file_entities) do
+        [
+          { 'path' => 'b_spec.rb' },
+          { 'path' => 'c_spec.rb' },
+          { 'path' => 'd_spec.rb' },
+        ]
+      end
+
+      it do
+        test_file_pattern = double
+        expect(KnapsackPro::TestFilePattern).to receive(:call).with(adapter_class).and_return(test_file_pattern)
+        expect(described_class).to receive(:call).with(test_file_pattern).and_return(test_file_entities)
+
+        expect(described_class).to receive(:call).with(slow_test_file_pattern, test_file_list_enabled: false).and_return(slow_test_file_entities)
+
+        expect(subject).to eq([
+          { 'path' => 'b_spec.rb' },
+          { 'path' => 'c_spec.rb' },
+        ])
+      end
+    end
+
+    context 'when slow_test_file_pattern is not present' do
+      let(:slow_test_file_pattern) { nil }
+
+      it do
+        expect { subject }.to raise_error RuntimeError, 'KNAPSACK_PRO_SLOW_TEST_FILE_PATTERN is not defined'
+      end
+    end
+  end
+
+  describe '.select_test_files_that_can_be_run' do
+    let(:adapter_class) { double }
+    let(:test_file_entities_to_run) do
+      [
+        { 'path' => 'a_spec.rb' },
+        { 'path' => 'b_spec.rb' },
+        { 'path' => 'not_existing_on_disk_spec.rb' },
+      ]
+    end
+    # test files existing on disk
+    let(:test_file_entities) do
+      [
+        { 'path' => 'a_spec.rb' },
+        { 'path' => 'b_spec.rb' },
+        { 'path' => 'c_spec.rb' },
+      ]
+    end
+
+    subject { described_class.select_test_files_that_can_be_run(adapter_class, test_file_entities_to_run) }
+
+    it do
+      test_file_pattern = double
+      expect(KnapsackPro::TestFilePattern).to receive(:call).with(adapter_class).and_return(test_file_pattern)
+      expect(described_class).to receive(:call).with(test_file_pattern).and_return(test_file_entities)
+
+      expect(subject).to eq([
+        { 'path' => 'a_spec.rb' },
+        { 'path' => 'b_spec.rb' },
+      ])
+    end
+  end
+
   describe '#call' do
+    let(:test_file_list_enabled) { true }
     let(:test_file_pattern) { 'spec_fake/**{,/*/**}/*_spec.rb' }
 
-    subject { described_class.new(test_file_pattern).call }
+    subject { described_class.new(test_file_pattern, test_file_list_enabled).call }
 
     context 'when KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN is not defined' do
       it do
         should eq([
-          {
-            'path' => 'spec_fake/controllers/users_controller_spec.rb',
-          },
-          {
-            'path' => 'spec_fake/models/admin_spec.rb',
-          },
-          {
-            'path' => 'spec_fake/models/user_spec.rb',
-          },
+          { 'path' => 'spec_fake/controllers/users_controller_spec.rb' },
+          { 'path' => 'spec_fake/models/admin_spec.rb' },
+          { 'path' => 'spec_fake/models/user_spec.rb' },
         ])
       end
     end
@@ -43,12 +119,8 @@ describe KnapsackPro::TestFileFinder do
 
       it do
         should eq([
-          {
-            'path' => 'spec_fake/models/admin_spec.rb',
-          },
-          {
-            'path' => 'spec_fake/models/user_spec.rb',
-          },
+          { 'path' => 'spec_fake/models/admin_spec.rb' },
+          { 'path' => 'spec_fake/models/user_spec.rb' },
         ])
       end
     end
@@ -63,20 +135,24 @@ describe KnapsackPro::TestFileFinder do
 
       it do
         expect(subject).to eq([
-          {
-            'path' => 'spec/bar_spec.rb',
-          },
-          {
-            'path' => 'spec/foo_spec.rb',
-          },
-          {
-            'path' => 'spec/time_helpers_spec.rb:10',
-          },
-          {
-            'path' => 'spec/time_helpers_spec.rb:38',
-          },
+          { 'path' => 'spec/bar_spec.rb' },
+          { 'path' => 'spec/foo_spec.rb' },
+          { 'path' => 'spec/time_helpers_spec.rb:10' },
+          { 'path' => 'spec/time_helpers_spec.rb:38' },
         ])
       end
+
+      context 'when test_file_list_enabled=false' do
+        let(:test_file_list_enabled) { false }
+
+        it do
+          should eq([
+            { 'path' => 'spec_fake/controllers/users_controller_spec.rb' },
+            { 'path' => 'spec_fake/models/admin_spec.rb' },
+            { 'path' => 'spec_fake/models/user_spec.rb' },
+          ])
+        end
+      end
     end
   end
 end

data/spec/knapsack_pro/test_files_with_test_cases_composer_spec.rb

@@ -0,0 +1,41 @@
+describe KnapsackPro::TestFilesWithTestCasesComposer do
+  let(:test_files) do
+    [
+      { 'path' => 'spec/a_spec.rb' },
+      { 'path' => 'spec/b_spec.rb' },
+      { 'path' => 'spec/c_spec.rb' },
+      { 'path' => 'spec/slow_1_spec.rb' },
+      { 'path' => 'spec/slow_2_spec.rb' },
+    ]
+  end
+  let(:slow_test_files) do
+    [
+      { 'path' => 'spec/slow_1_spec.rb', 'time_execution' => 1.0 },
+      { 'path' => 'spec/slow_2_spec.rb', 'time_execution' => 2.0 },
+    ]
+  end
+  let(:test_file_cases) do
+    [
+      { 'path' => 'spec/slow_1_spec.rb[1:1]' },
+      { 'path' => 'spec/slow_1_spec.rb[1:2]' },
+      { 'path' => 'spec/slow_2_spec.rb[1:1:1]' },
+      { 'path' => 'spec/slow_2_spec.rb[1:1:2]' },
+      { 'path' => 'spec/slow_2_spec.rb[1:1:3]' },
+    ]
+  end
+
+  subject { described_class.call(test_files, slow_test_files, test_file_cases) }
+
+  it 'returns test files that are not slow and test file cases for slow test files' do
+    expect(subject).to eq([
+      { 'path' => 'spec/a_spec.rb' },
+      { 'path' => 'spec/b_spec.rb' },
+      { 'path' => 'spec/c_spec.rb' },
+      { 'path' => 'spec/slow_1_spec.rb[1:1]' },
+      { 'path' => 'spec/slow_1_spec.rb[1:2]' },
+      { 'path' => 'spec/slow_2_spec.rb[1:1:1]' },
+      { 'path' => 'spec/slow_2_spec.rb[1:1:2]' },
+      { 'path' => 'spec/slow_2_spec.rb[1:1:3]' },
+    ])
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 1.20.1
+  version: 1.22.2
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-09 00:00:00.000000000 Z
+date: 2020-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -229,6 +229,7 @@ files:
 - lib/knapsack_pro/allocator.rb
 - lib/knapsack_pro/allocator_builder.rb
 - lib/knapsack_pro/base_allocator_builder.rb
+- lib/knapsack_pro/build_distribution_fetcher.rb
 - lib/knapsack_pro/client/api/action.rb
 - lib/knapsack_pro/client/api/v1/base.rb
 - lib/knapsack_pro/client/api/v1/build_distributions.rb
@@ -281,12 +282,17 @@ files:
 - lib/knapsack_pro/runners/rspec_runner.rb
 - lib/knapsack_pro/runners/spinach_runner.rb
 - lib/knapsack_pro/runners/test_unit_runner.rb
+- lib/knapsack_pro/slow_test_file_determiner.rb
+- lib/knapsack_pro/slow_test_file_finder.rb
 - lib/knapsack_pro/task_loader.rb
 - lib/knapsack_pro/test_case_detectors/rspec_test_example_detector.rb
+- lib/knapsack_pro/test_case_mergers/base_merger.rb
+- lib/knapsack_pro/test_case_mergers/rspec_merger.rb
 - lib/knapsack_pro/test_file_cleaner.rb
 - lib/knapsack_pro/test_file_finder.rb
 - lib/knapsack_pro/test_file_pattern.rb
 - lib/knapsack_pro/test_file_presenter.rb
+- lib/knapsack_pro/test_files_with_test_cases_composer.rb
 - lib/knapsack_pro/test_flat_distributor.rb
 - lib/knapsack_pro/tracker.rb
 - lib/knapsack_pro/utils.rb
@@ -317,6 +323,7 @@ files:
 - spec/knapsack_pro/allocator_builder_spec.rb
 - spec/knapsack_pro/allocator_spec.rb
 - spec/knapsack_pro/base_allocator_builder_spec.rb
+- spec/knapsack_pro/build_distribution_fetcher_spec.rb
 - spec/knapsack_pro/client/api/action_spec.rb
 - spec/knapsack_pro/client/api/v1/base_spec.rb
 - spec/knapsack_pro/client/api/v1/build_distributions_spec.rb
@@ -365,12 +372,17 @@ files:
 - spec/knapsack_pro/runners/rspec_runner_spec.rb
 - spec/knapsack_pro/runners/spinach_runner_spec.rb
 - spec/knapsack_pro/runners/test_unit_runner_spec.rb
+- spec/knapsack_pro/slow_test_file_determiner_spec.rb
+- spec/knapsack_pro/slow_test_file_finder_spec.rb
 - spec/knapsack_pro/task_loader_spec.rb
 - spec/knapsack_pro/test_case_detectors/rspec_test_example_detector_spec.rb
+- spec/knapsack_pro/test_case_mergers/base_merger_spec.rb
+- spec/knapsack_pro/test_case_mergers/rspec_merger_spec.rb
 - spec/knapsack_pro/test_file_cleaner_spec.rb
 - spec/knapsack_pro/test_file_finder_spec.rb
 - spec/knapsack_pro/test_file_pattern_spec.rb
 - spec/knapsack_pro/test_file_presenter_spec.rb
+- spec/knapsack_pro/test_files_with_test_cases_composer_spec.rb
 - spec/knapsack_pro/test_flat_distributor_spec.rb
 - spec/knapsack_pro/tracker_spec.rb
 - spec/knapsack_pro/utils_spec.rb
@@ -431,6 +443,7 @@ test_files:
 - spec/knapsack_pro/allocator_builder_spec.rb
 - spec/knapsack_pro/allocator_spec.rb
 - spec/knapsack_pro/base_allocator_builder_spec.rb
+- spec/knapsack_pro/build_distribution_fetcher_spec.rb
 - spec/knapsack_pro/client/api/action_spec.rb
 - spec/knapsack_pro/client/api/v1/base_spec.rb
 - spec/knapsack_pro/client/api/v1/build_distributions_spec.rb
@@ -479,12 +492,17 @@ test_files:
 - spec/knapsack_pro/runners/rspec_runner_spec.rb
 - spec/knapsack_pro/runners/spinach_runner_spec.rb
 - spec/knapsack_pro/runners/test_unit_runner_spec.rb
+- spec/knapsack_pro/slow_test_file_determiner_spec.rb
+- spec/knapsack_pro/slow_test_file_finder_spec.rb
 - spec/knapsack_pro/task_loader_spec.rb
 - spec/knapsack_pro/test_case_detectors/rspec_test_example_detector_spec.rb
+- spec/knapsack_pro/test_case_mergers/base_merger_spec.rb
+- spec/knapsack_pro/test_case_mergers/rspec_merger_spec.rb
 - spec/knapsack_pro/test_file_cleaner_spec.rb
 - spec/knapsack_pro/test_file_finder_spec.rb
 - spec/knapsack_pro/test_file_pattern_spec.rb
 - spec/knapsack_pro/test_file_presenter_spec.rb
+- spec/knapsack_pro/test_files_with_test_cases_composer_spec.rb
 - spec/knapsack_pro/test_flat_distributor_spec.rb
 - spec/knapsack_pro/tracker_spec.rb
 - spec/knapsack_pro/utils_spec.rb