knapsack_pro 1.20.1 → 1.22.2

data/spec/knapsack_pro/client/api/v1/build_distributions_spec.rb

@@ -38,4 +38,35 @@ describe KnapsackPro::Client::API::V1::BuildDistributions do
       expect(subject).to eq action
     end
   end
+
+  describe '.last' do
+    let(:commit_hash) { double }
+    let(:branch) { double }
+    let(:node_total) { double }
+    let(:node_index) { double }
+
+    subject do
+      described_class.last(
+        commit_hash: commit_hash,
+        branch: branch,
+        node_total: node_total,
+        node_index: node_index,
+      )
+    end
+
+    it do
+      action = double
+      expect(KnapsackPro::Client::API::Action).to receive(:new).with({
+        endpoint_path: '/v1/build_distributions/last',
+        http_method: :get,
+        request_hash: {
+          commit_hash: commit_hash,
+          branch: branch,
+          node_total: node_total,
+          node_index: node_index,
+        }
+      }).and_return(action)
+      expect(subject).to eq action
+    end
+  end
 end

data/spec/knapsack_pro/client/connection_spec.rb

@@ -1,167 +1,298 @@
+shared_examples 'when request got response from API' do
+  context 'when body response is JSON and API response code is 400' do
+    let(:body) { '{"errors": "value"}' }
+    let(:code) { '400' } # it must be string code
+
+    before do
+      expect(KnapsackPro).to receive(:logger).exactly(4).and_return(logger)
+      expect(logger).to receive(:debug).with("#{expected_http_method} http://api.knapsackpro.test:3000/v1/fake_endpoint")
+      expect(logger).to receive(:debug).with('API request UUID: fake-uuid')
+      expect(logger).to receive(:debug).with('API response:')
+    end
+
+    it do
+      parsed_response = { 'errors' => 'value' }
+
+      expect(logger).to receive(:error).with(parsed_response)
+
+      expect(subject).to eq(parsed_response)
+      expect(connection.success?).to be true
+      expect(connection.errors?).to be true
+    end
+  end
+
+  context 'when body response is JSON with build_distribution_id' do
+    let(:body) { '{"build_distribution_id": "seed-uuid"}' }
+    let(:code) { '200' } # it must be string code
+
+    before do
+      expect(KnapsackPro).to receive(:logger).exactly(5).and_return(logger)
+      expect(logger).to receive(:debug).with("#{expected_http_method} http://api.knapsackpro.test:3000/v1/fake_endpoint")
+      expect(logger).to receive(:debug).with('API request UUID: fake-uuid')
+      expect(logger).to receive(:debug).with("Test suite split seed: seed-uuid")
+      expect(logger).to receive(:debug).with('API response:')
+    end
+
+    it do
+      parsed_response = { 'build_distribution_id' => 'seed-uuid' }
+
+      expect(logger).to receive(:debug).with(parsed_response)
+
+      expect(subject).to eq(parsed_response)
+      expect(connection.success?).to be true
+      expect(connection.errors?).to be false
+    end
+  end
+
+  context 'when body response is empty' do
+    let(:body) { '' }
+    let(:code) { '200' } # it must be string code
+
+    before do
+      expect(KnapsackPro).to receive(:logger).exactly(4).and_return(logger)
+      expect(logger).to receive(:debug).with("#{expected_http_method} http://api.knapsackpro.test:3000/v1/fake_endpoint")
+      expect(logger).to receive(:debug).with('API request UUID: fake-uuid')
+      expect(logger).to receive(:debug).with('API response:')
+    end
+
+    it do
+      expect(logger).to receive(:debug).with('')
+
+      expect(subject).to eq('')
+      expect(connection.success?).to be true
+      expect(connection.errors?).to be false
+    end
+  end
+end
+
+shared_examples 'when retry request' do
+  context 'when body response is JSON and API response code is 500' do
+    let(:body) { '{"error": "Internal Server Error"}' }
+    let(:code) { '500' } # it must be string code
+
+    before do
+      expect(KnapsackPro).to receive(:logger).at_least(1).and_return(logger)
+    end
+
+    it do
+      expect(logger).to receive(:debug).exactly(3).with("#{expected_http_method} http://api.knapsackpro.test:3000/v1/fake_endpoint")
+      expect(logger).to receive(:debug).exactly(3).with('API request UUID: fake-uuid')
+      expect(logger).to receive(:debug).exactly(3).with('API response:')
+
+      parsed_response = { 'error' => 'Internal Server Error' }
+
+      expect(logger).to receive(:error).exactly(3).with(parsed_response)
+
+      server_error = described_class::ServerError.new(parsed_response)
+      expect(logger).to receive(:warn).exactly(3).with(server_error.inspect)
+
+      expect(logger).to receive(:warn).with("Wait 8s and retry request to Knapsack Pro API.")
+      expect(logger).to receive(:warn).with("Next request in 8s...")
+      expect(logger).to receive(:warn).with("Next request in 6s...")
+      expect(logger).to receive(:warn).with("Next request in 4s...")
+      expect(logger).to receive(:warn).with("Next request in 2s...")
+      expect(logger).to receive(:warn).with("Wait 16s and retry request to Knapsack Pro API.")
+      expect(logger).to receive(:warn).with("Next request in 16s...")
+      expect(logger).to receive(:warn).with("Next request in 14s...")
+      expect(logger).to receive(:warn).with("Next request in 12s...")
+      expect(logger).to receive(:warn).with("Next request in 10s...")
+      expect(logger).to receive(:warn).with("Next request in 8s...")
+      expect(logger).to receive(:warn).with("Next request in 6s...")
+      expect(logger).to receive(:warn).with("Next request in 4s...")
+      expect(logger).to receive(:warn).with("Next request in 2s...")
+      expect(Kernel).to receive(:sleep).exactly(12).with(2)
+
+      expect(subject).to eq(parsed_response)
+
+      expect(connection.success?).to be false
+      expect(connection.errors?).to be true
+    end
+
+    context 'when Fallback Mode is disabled' do
+      before do
+        expect(KnapsackPro::Config::Env).to receive(:fallback_mode_enabled?).at_least(1).and_return(false)
+      end
+
+      it do
+        expect(logger).to receive(:debug).exactly(6).with("#{expected_http_method} http://api.knapsackpro.test:3000/v1/fake_endpoint")
+        expect(logger).to receive(:debug).exactly(6).with('API request UUID: fake-uuid')
+        expect(logger).to receive(:debug).exactly(6).with('API response:')
+
+        parsed_response = { 'error' => 'Internal Server Error' }
+
+        expect(logger).to receive(:error).exactly(6).with(parsed_response)
+
+        server_error = described_class::ServerError.new(parsed_response)
+        expect(logger).to receive(:warn).exactly(6).with(server_error.inspect)
+
+        expect(logger).to receive(:warn).with("Wait 8s and retry request to Knapsack Pro API.")
+        expect(logger).to receive(:warn).with("Next request in 8s...")
+        expect(logger).to receive(:warn).with("Next request in 6s...")
+        expect(logger).to receive(:warn).with("Next request in 4s...")
+        expect(logger).to receive(:warn).with("Next request in 2s...")
+
+        expect(logger).to receive(:warn).with("Wait 16s and retry request to Knapsack Pro API.")
+        expect(logger).to receive(:warn).with("Next request in 16s...")
+        expect(logger).to receive(:warn).with("Next request in 14s...")
+        expect(logger).to receive(:warn).with("Next request in 12s...")
+        expect(logger).to receive(:warn).with("Next request in 10s...")
+        expect(logger).to receive(:warn).with("Next request in 8s...")
+        expect(logger).to receive(:warn).with("Next request in 6s...")
+        expect(logger).to receive(:warn).with("Next request in 4s...")
+        expect(logger).to receive(:warn).with("Next request in 2s...")
+
+        expect(logger).to receive(:warn).with("Wait 24s and retry request to Knapsack Pro API.")
+        12.times do |i|
+          expect(logger).to receive(:warn).with("Next request in #{(i+1)*2}s...")
+        end
+
+        expect(logger).to receive(:warn).with("Wait 32s and retry request to Knapsack Pro API.")
+        16.times do |i|
+          expect(logger).to receive(:warn).with("Next request in #{(i+1)*2}s...")
+        end
+
+        expect(logger).to receive(:warn).with("Wait 40s and retry request to Knapsack Pro API.")
+        20.times do |i|
+          expect(logger).to receive(:warn).with("Next request in #{(i+1)*2}s...")
+        end
+
+        expect(Kernel).to receive(:sleep).exactly(60).with(2)
+
+        expect(subject).to eq(parsed_response)
+
+        expect(connection.success?).to be false
+        expect(connection.errors?).to be true
+      end
+    end
+  end
+end
+
 describe KnapsackPro::Client::Connection do
   let(:endpoint_path) { '/v1/fake_endpoint' }
-  let(:http_method) { :post }
   let(:request_hash) { { fake: 'hash' } }
+  let(:http_method) { :post }
   let(:action) do
     instance_double(KnapsackPro::Client::API::Action,
                     endpoint_path: endpoint_path,
                     http_method: http_method,
                     request_hash: request_hash)
   end
+  let(:test_suite_token) { '3fa64859337f6e56409d49f865d13fd7' }
 
   let(:connection) { described_class.new(action) }
 
   before do
     stub_const('ENV', {
       'KNAPSACK_PRO_ENDPOINT' => 'http://api.knapsackpro.test:3000',
-      'KNAPSACK_PRO_TEST_SUITE_TOKEN' => '3fa64859337f6e56409d49f865d13fd7',
+      'KNAPSACK_PRO_TEST_SUITE_TOKEN' => test_suite_token,
     })
   end
 
   describe '#call' do
     let(:logger) { instance_double(Logger) }
+    let(:http) { instance_double(Net::HTTP) }
+    let(:http_response) do
+      header = { 'X-Request-Id' => 'fake-uuid' }
+      instance_double(Net::HTTPOK, body: body, header: header, code: code)
+    end
 
     subject { connection.call }
 
-    context 'when http method is POST' do
-      before do
-        http = instance_double(Net::HTTP)
+    before do
+      expect(Net::HTTP).to receive(:new).with('api.knapsackpro.test', 3000).and_return(http)
 
-        expect(Net::HTTP).to receive(:new).with('api.knapsackpro.test', 3000).and_return(http)
+      expect(http).to receive(:use_ssl=).with(false)
+      expect(http).to receive(:open_timeout=).with(15)
+      expect(http).to receive(:read_timeout=).with(15)
+    end
 
-        expect(http).to receive(:use_ssl=).with(false)
-        expect(http).to receive(:open_timeout=).with(15)
-        expect(http).to receive(:read_timeout=).with(15)
+    context 'when http method is POST' do
+      let(:http_method) { :post }
 
-        header = { 'X-Request-Id' => 'fake-uuid' }
-        http_response = instance_double(Net::HTTPOK, body: body, header: header, code: code)
+      before do
         expect(http).to receive(:post).with(
           endpoint_path,
-          "{\"fake\":\"hash\",\"test_suite_token\":\"3fa64859337f6e56409d49f865d13fd7\"}",
+          request_hash.to_json,
           {
             'Content-Type' => 'application/json',
             'Accept' => 'application/json',
             'KNAPSACK-PRO-CLIENT-NAME' => 'knapsack_pro-ruby',
             'KNAPSACK-PRO-CLIENT-VERSION' => KnapsackPro::VERSION,
+            'KNAPSACK-PRO-TEST-SUITE-TOKEN' => test_suite_token,
           }
         ).and_return(http_response)
       end
 
-      context 'when body response is json and API response code is 400' do
-        let(:body) { '{"errors": "value"}' }
-        let(:code) { '400' } # it must be string code
-
-        before do
-          expect(KnapsackPro).to receive(:logger).exactly(3).and_return(logger)
-          expect(logger).to receive(:debug).with('API request UUID: fake-uuid')
-          expect(logger).to receive(:debug).with('API response:')
-        end
-
-        it do
-          parsed_response = { 'errors' => 'value' }
-
-          expect(logger).to receive(:error).with(parsed_response)
-
-          expect(subject).to eq(parsed_response)
-          expect(connection.success?).to be true
-          expect(connection.errors?).to be true
-        end
+      it_behaves_like 'when request got response from API' do
+        let(:expected_http_method) { 'POST' }
       end
+    end
 
-      context 'when body response is json with build_distribution_id' do
-        let(:body) { '{"build_distribution_id": "seed-uuid"}' }
-        let(:code) { '200' } # it must be string code
-
-        before do
-          expect(KnapsackPro).to receive(:logger).exactly(4).and_return(logger)
-          expect(logger).to receive(:debug).with('API request UUID: fake-uuid')
-          expect(logger).to receive(:debug).with("Test suite split seed: seed-uuid")
-          expect(logger).to receive(:debug).with('API response:')
-        end
-
-        it do
-          parsed_response = { 'build_distribution_id' => 'seed-uuid' }
-
-          expect(logger).to receive(:debug).with(parsed_response)
+    context 'when http method is GET' do
+      let(:http_method) { :get }
 
-          expect(subject).to eq(parsed_response)
-          expect(connection.success?).to be true
-          expect(connection.errors?).to be false
-        end
+      before do
+        uri = URI.parse("http://api.knapsackpro.test:3000#{endpoint_path}")
+        uri.query = URI.encode_www_form(request_hash)
+        expect(http).to receive(:get).with(
+          uri,
+          {
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+            'KNAPSACK-PRO-CLIENT-NAME' => 'knapsack_pro-ruby',
+            'KNAPSACK-PRO-CLIENT-VERSION' => KnapsackPro::VERSION,
+            'KNAPSACK-PRO-TEST-SUITE-TOKEN' => test_suite_token,
+          }
+        ).and_return(http_response)
       end
 
-      context 'when body response is empty' do
-        let(:body) { '' }
-        let(:code) { '200' } # it must be string code
-
-        before do
-          expect(KnapsackPro).to receive(:logger).exactly(3).and_return(logger)
-          expect(logger).to receive(:debug).with('API request UUID: fake-uuid')
-          expect(logger).to receive(:debug).with('API response:')
-        end
-
-        it do
-          expect(logger).to receive(:debug).with('')
-
-          expect(subject).to eq('')
-          expect(connection.success?).to be true
-          expect(connection.errors?).to be false
-        end
+      it_behaves_like 'when request got response from API' do
+        let(:expected_http_method) { 'GET' }
       end
     end
 
     context 'when retry request for http method POST' do
-      before do
-        http = instance_double(Net::HTTP)
-
-        expect(Net::HTTP).to receive(:new).exactly(3).with('api.knapsackpro.test', 3000).and_return(http)
+      let(:http_method) { :post }
 
-        expect(http).to receive(:use_ssl=).exactly(3).with(false)
-        expect(http).to receive(:open_timeout=).exactly(3).with(15)
-        expect(http).to receive(:read_timeout=).exactly(3).with(15)
-
-        header = { 'X-Request-Id' => 'fake-uuid' }
-        http_response = instance_double(Net::HTTPOK, body: body, header: header, code: code)
-        expect(http).to receive(:post).exactly(3).with(
+      before do
+        expect(http).to receive(:post).at_least(3).with(
           endpoint_path,
-          "{\"fake\":\"hash\",\"test_suite_token\":\"3fa64859337f6e56409d49f865d13fd7\"}",
+          request_hash.to_json,
           {
             'Content-Type' => 'application/json',
             'Accept' => 'application/json',
             'KNAPSACK-PRO-CLIENT-NAME' => 'knapsack_pro-ruby',
             'KNAPSACK-PRO-CLIENT-VERSION' => KnapsackPro::VERSION,
+            'KNAPSACK-PRO-TEST-SUITE-TOKEN' => test_suite_token,
           }
         ).and_return(http_response)
       end
 
-      context 'when body response is json and API response code is 500' do
-        let(:body) { '{"error": "Internal Server Error"}' }
-        let(:code) { '500' } # it must be string code
-
-        before do
-          expect(KnapsackPro).to receive(:logger).at_least(1).and_return(logger)
-          expect(logger).to receive(:debug).exactly(3).with('API request UUID: fake-uuid')
-          expect(logger).to receive(:debug).exactly(3).with('API response:')
-        end
-
-        it do
-          parsed_response = { 'error' => 'Internal Server Error' }
-
-          expect(logger).to receive(:error).exactly(3).with(parsed_response)
-
-          server_error = described_class::ServerError.new(parsed_response)
-          expect(logger).to receive(:warn).exactly(3).with(server_error.inspect)
+      it_behaves_like 'when retry request' do
+        let(:expected_http_method) { 'POST' }
+      end
+    end
 
-          expect(logger).to receive(:warn).with("Wait 4s and retry request to Knapsack Pro API.")
-          expect(logger).to receive(:warn).with("Wait 8s and retry request to Knapsack Pro API.")
-          expect(Kernel).to receive(:sleep).with(4)
-          expect(Kernel).to receive(:sleep).with(8)
+    context 'when retry request for http method GET' do
+      let(:http_method) { :get }
 
-          expect(subject).to eq(parsed_response)
+      before do
+        uri = URI.parse("http://api.knapsackpro.test:3000#{endpoint_path}")
+        uri.query = URI.encode_www_form(request_hash)
+        expect(http).to receive(:get).at_least(3).with(
+          uri,
+          {
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+            'KNAPSACK-PRO-CLIENT-NAME' => 'knapsack_pro-ruby',
+            'KNAPSACK-PRO-CLIENT-VERSION' => KnapsackPro::VERSION,
+            'KNAPSACK-PRO-TEST-SUITE-TOKEN' => test_suite_token,
+          }
+        ).and_return(http_response)
+      end
 
-          expect(connection.success?).to be false
-          expect(connection.errors?).to be true
-        end
+      it_behaves_like 'when retry request' do
+        let(:expected_http_method) { 'GET' }
       end
     end
   end

data/spec/knapsack_pro/config/env_spec.rb

@@ -183,6 +183,20 @@ describe KnapsackPro::Config::Env do
     end
   end
 
+  describe '.slow_test_file_pattern' do
+    subject { described_class.slow_test_file_pattern }
+
+    context 'when ENV exists' do
+      let(:slow_test_file_pattern) { 'spec/features/*_spec.rb' }
+      before { stub_const("ENV", { 'KNAPSACK_PRO_SLOW_TEST_FILE_PATTERN' => slow_test_file_pattern }) }
+      it { should eq slow_test_file_pattern }
+    end
+
+    context "when ENV doesn't exist" do
+      it { should be_nil }
+    end
+  end
+
   describe '.test_file_exclude_pattern' do
     subject { described_class.test_file_exclude_pattern }