keepr 0.4.0 → 0.5.0

data/spec/keepr/journal_export_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::JournalExport do
@@ -13,22 +15,21 @@ describe Keepr::JournalExport do
   let(:account_4920)  { FactoryBot.create :account, number: 4920, kind: :expense,   keepr_tax: vst }
   let(:account_8400)  { FactoryBot.create :account, number: 8400, kind: :revenue,   keepr_tax: ust }
 
-  let(:account_10000) { FactoryBot.create :account, number: 10000, kind: :debtor   }
+  let(:account_10000) { FactoryBot.create :account, number: 10_000, kind: :debtor }
 
   let(:scope) { Keepr::Journal.reorder(:number) }
 
-  let(:export) {
+  let(:export) do
     Keepr::JournalExport.new(scope,
-      'Berater'     => 1234567,
-      'Mandant'     => 78901,
-      'Datum vom'   => Date.new(2016,6,1),
-      'Datum bis'   => Date.new(2016,6,30),
-      'WJ-Beginn'   => Date.new(2016,1,1),
-      'Bezeichnung' => 'Keepr-Buchungen'
-    ) do |posting|
+                             'Berater'     => 1_234_567,
+                             'Mandant'     => 78_901,
+                             'Datum vom'   => Date.new(2016, 6, 1),
+                             'Datum bis'   => Date.new(2016, 6, 30),
+                             'WJ-Beginn'   => Date.new(2016, 1, 1),
+                             'Bezeichnung' => 'Keepr-Buchungen') do |posting|
       { 'Identifikationsnummer' => "ID:#{posting.id}" }
     end
-  }
+  end
 
   describe :to_s do
     subject { export.to_s }
@@ -37,30 +38,30 @@ describe Keepr::JournalExport do
       subject.lines[2..-1]
     end
 
-    it "should return CSV lines" do
+    it 'should return CSV lines' do
       expect(subject.lines.count).to eq(2)
       subject.lines.each { |line| expect(line).to include(';') }
     end
 
-    it "should include header data" do
+    it 'should include header data' do
       expect(subject.lines[0]).to include('1234567;')
       expect(subject.lines[0]).to include('78901;')
       expect(subject.lines[0]).to include('20160601;20160630;')
       expect(subject.lines[0]).to include('"Keepr-Buchungen";')
     end
 
-    context "Journal without tax" do
+    context 'Journal without tax' do
       let!(:journal_without_tax) do
         Keepr::Journal.create! number: 'BELEG-1',
                                subject: 'Geldautomat',
-                               date: Date.new(2016,06,23),
+                               date: Date.new(2016, 0o6, 23),
                                keepr_postings_attributes: [
                                  { keepr_account: account_1000, amount: 105, side: 'debit' },
                                  { keepr_account: account_1200, amount: 105, side: 'credit' }
                                ]
       end
 
-      it "should include data" do
+      it 'should include data' do
         expect(booking_lines.count).to eq(1)
 
         expect(booking_lines[0]).to include('"Geldautomat";')
@@ -73,11 +74,11 @@ describe Keepr::JournalExport do
       end
     end
 
-    context "Journal with tax" do
+    context 'Journal with tax' do
       let!(:journal_with_tax) do
         Keepr::Journal.create! number: 'BELEG-2',
                                subject: 'Telefonrechnung',
-                               date: Date.new(2016,06,24),
+                               date: Date.new(2016, 0o6, 24),
                                keepr_postings_attributes: [
                                  { keepr_account: account_4920, amount:  8.40, side: 'debit' },
                                  { keepr_account: account_1576, amount:  1.60, side: 'debit' },
@@ -85,7 +86,7 @@ describe Keepr::JournalExport do
                                ]
       end
 
-      it "should include data" do
+      it 'should include data' do
         expect(booking_lines.count).to eq(2)
 
         expect(booking_lines[0]).to include('"Telefonrechnung";')
@@ -106,22 +107,22 @@ describe Keepr::JournalExport do
       end
     end
 
-    context "Journal with debtor" do
+    context 'Journal with debtor' do
       let!(:journal_with_debtor) do
         Keepr::Journal.create! number: 'BELEG-3',
                                subject: 'Warenverkauf mit Anzahlung',
-                               date: Date.new(2016,06,25),
+                               date: Date.new(2016, 0o6, 25),
                                keepr_postings_attributes: [
                                  { keepr_account: account_10000, amount: 4760.00, side: 'debit'  },
                                  { keepr_account: account_1718,  amount: 1000.00, side: 'debit'  },
-                                 { keepr_account: account_1776,  amount:  190.00, side: 'debit'  },
+                                 { keepr_account: account_1776,  amount: 190.00, side: 'debit' },
 
                                  { keepr_account: account_8400,  amount: 5000.00, side: 'credit' },
-                                 { keepr_account: account_1776,  amount:  950.00, side: 'credit' }
+                                 { keepr_account: account_1776,  amount: 950.00, side: 'credit' }
                                ]
       end
 
-      it "should include data" do
+      it 'should include data' do
         expect(booking_lines.count).to eq(4)
 
         expect(booking_lines[0]).to include('"Warenverkauf mit Anzahlung";')
@@ -157,7 +158,7 @@ describe Keepr::JournalExport do
         expect(booking_lines[3]).to include(';0;')
       end
 
-      it "should include data from block" do
+      it 'should include data from block' do
         expect(booking_lines[0]).to include('ID:')
         expect(booking_lines[1]).to include('ID:')
       end
@@ -165,7 +166,7 @@ describe Keepr::JournalExport do
   end
 
   describe :to_file do
-    it "should create CSV file" do
+    it 'should create CSV file' do
       Dir.mktmpdir do |dir|
         filename = "#{dir}/EXTF_Buchungsstapel.csv"
         export.to_file(filename)

data/spec/keepr/journal_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::Journal do
@@ -11,17 +13,17 @@ describe Keepr::Journal do
 
   let :simple_journal do
     Keepr::Journal.create keepr_postings_attributes: [
-                                { keepr_account: account_1000, amount: 100.99, side: 'debit' },
-                                { keepr_account: account_1200, amount: 100.99, side: 'credit' }
-                              ]
+      { keepr_account: account_1000, amount: 100.99, side: 'debit' },
+      { keepr_account: account_1200, amount: 100.99, side: 'credit' }
+    ]
   end
 
   let :complex_journal do
     Keepr::Journal.create keepr_postings_attributes: [
-                                { keepr_account: account_4920, amount:  8.40, side: 'debit' },
-                                { keepr_account: account_1576, amount:  1.60, side: 'debit' },
-                                { keepr_account: account_1600, amount: 10.00, side: 'credit' }
-                               ]
+      { keepr_account: account_4920, amount: 8.40, side: 'debit' },
+      { keepr_account: account_1576, amount: 1.60, side: 'debit' },
+      { keepr_account: account_1600, amount: 10.00, side: 'credit' }
+    ]
   end
 
   describe :initialization do
@@ -33,7 +35,7 @@ describe Keepr::Journal do
 
     context 'with date given' do
       it 'should not modify the date' do
-        old_date = Date.new(2013,10,1)
+        old_date = Date.new(2013, 10, 1)
         expect(Keepr::Journal.new(date: old_date).date).to eq(old_date)
       end
     end
@@ -54,53 +56,53 @@ describe Keepr::Journal do
 
     it 'should fail for journal with only one posting' do
       journal = Keepr::Journal.create keepr_postings_attributes: [
-                                  { keepr_account: account_4920, amount: 8.40, side: 'debit' }
-                                ]
+        { keepr_account: account_4920, amount: 8.40, side: 'debit' }
+      ]
       expect(journal).not_to be_valid
-      expect(journal.errors.added? :base, :account_missing).to eq(true)
+      expect(journal.errors.added?(:base, :account_missing)).to eq(true)
     end
 
     it 'should fail for booking the same account twice' do
       journal = Keepr::Journal.create keepr_postings_attributes: [
-                                  { keepr_account: account_1000, amount: 10, side: 'debit' },
-                                  { keepr_account: account_1000, amount: 10, side: 'credit' }
-                                ]
+        { keepr_account: account_1000, amount: 10, side: 'debit' },
+        { keepr_account: account_1000, amount: 10, side: 'credit' }
+      ]
       expect(journal).not_to be_valid
-      expect(journal.errors.added? :base, :account_missing).to eq(true)
+      expect(journal.errors.added?(:base, :account_missing)).to eq(true)
     end
 
     it 'should fail for unbalanced journal' do
       journal = Keepr::Journal.create keepr_postings_attributes: [
-                                  { keepr_account: account_1000, amount: 10, side: 'debit' },
-                                  { keepr_account: account_1200, amount: 10, side: 'debit' }
-                                ]
+        { keepr_account: account_1000, amount: 10, side: 'debit' },
+        { keepr_account: account_1200, amount: 10, side: 'debit' }
+      ]
       expect(journal).not_to be_valid
-      expect(journal.errors.added? :base, :amount_mismatch).to eq(true)
+      expect(journal.errors.added?(:base, :amount_mismatch)).to eq(true)
     end
 
     it 'should fail for nil amount' do
       journal = Keepr::Journal.create keepr_postings_attributes: [
-                                  { keepr_account: account_1000, amount: 10,  side: 'debit' },
-                                  { keepr_account: account_1200, amount: nil, side: 'credit' }
-                                ]
+        { keepr_account: account_1000, amount: 10, side: 'debit' },
+        { keepr_account: account_1200, amount: nil, side: 'credit' }
+      ]
       expect(journal).not_to be_valid
-      expect(journal.errors.added? :base, :amount_mismatch).to eq(true)
+      expect(journal.errors.added?(:base, :amount_mismatch)).to eq(true)
     end
   end
 
   describe :permanent do
     before :each do
-      simple_journal.update_attributes! permanent: true
+      simple_journal.update! permanent: true
     end
 
-    it "should not allow update" do
-      expect(simple_journal.update_attributes subject: 'foo').to eq(false)
-      expect(simple_journal.errors.added? :base, :changes_not_allowed).to eq(true)
+    it 'should not allow update' do
+      expect(simple_journal.update(subject: 'foo')).to eq(false)
+      expect(simple_journal.errors.added?(:base, :changes_not_allowed)).to eq(true)
     end
 
-    it "should not allow destroy" do
+    it 'should not allow destroy' do
       expect(simple_journal.destroy).to eq(false)
-      expect(simple_journal.errors.added? :base, :changes_not_allowed).to eq(true)
+      expect(simple_journal.errors.added?(:base, :changes_not_allowed)).to eq(true)
     end
   end
 
@@ -111,8 +113,8 @@ describe Keepr::Journal do
     end
 
     it 'should order postings' do
-      expect(simple_journal.keepr_postings.map(&:side)).to eq(['debit','credit'])
-      expect(complex_journal.keepr_postings.map(&:side)).to eq(['debit','debit','credit'])
+      expect(simple_journal.keepr_postings.map(&:side)).to eq(%w[debit credit])
+      expect(complex_journal.keepr_postings.map(&:side)).to eq(%w[debit debit credit])
     end
   end
 

data/spec/keepr/posting_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::Posting do
@@ -85,15 +87,15 @@ describe Keepr::Posting do
     end
 
     it 'should fail for negative amount' do
-      expect {
+      expect do
         Keepr::Posting.new(amount: -10)
-      }.to raise_error(ArgumentError)
+      end.to raise_error(ArgumentError)
     end
 
     it 'should fail for unknown side' do
-      expect {
+      expect do
         Keepr::Posting.new(side: 'foo')
-      }.to raise_error(ArgumentError)
+      end.to raise_error(ArgumentError)
     end
   end
 
@@ -111,12 +113,12 @@ describe Keepr::Posting do
     let!(:cost_center) { FactoryBot.create(:cost_center) }
     let!(:account_8400) { FactoryBot.create(:account, number: 8400, kind: :revenue) }
 
-    it "should allow cost_center" do
+    it 'should allow cost_center' do
       posting = Keepr::Posting.new keepr_account: account_8400, amount: 100, keepr_cost_center: cost_center
       expect(posting).to be_valid
     end
 
-    it "should not allow cost_center" do
+    it 'should not allow cost_center' do
       posting = Keepr::Posting.new keepr_account: account_1000, amount: 100, keepr_cost_center: cost_center
       expect(posting).to_not be_valid
     end

data/spec/keepr/tax_spec.rb

@@ -1,20 +1,27 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::Tax do
-  let!(:tax_account) { Keepr::Account.create! number: 1776,
-                                              name: 'Umsatzsteuer 19%',
-                                              kind: :asset }
+  let!(:tax_account) do
+    Keepr::Account.create! number: 1776,
+                           name: 'Umsatzsteuer 19%',
+                           kind: :asset
+  end
 
-  let!(:tax) { Keepr::Tax.create! name: 'USt19',
-                                  description: 'Umsatzsteuer 19%',
-                                  value: 19.0,
-                                  keepr_account: tax_account }
+  let!(:tax) do
+    Keepr::Tax.create! name: 'USt19',
+                       description: 'Umsatzsteuer 19%',
+                       value: 19.0,
+                       keepr_account: tax_account
+  end
 
-  let!(:account) { Keepr::Account.create! number: 8400,
-                                          name: 'Erlöse 19% USt',
-                                          kind: :revenue,
-                                          keepr_tax: tax }
+  let!(:account) do
+    Keepr::Account.create! number: 8400,
+                           name: 'Erlöse 19% USt',
+                           kind: :revenue,
+                           keepr_tax: tax
+  end
 
   it 'should be direct linked from account' do
     expect(tax.keepr_accounts).to eq([account])
@@ -22,12 +29,12 @@ describe Keepr::Tax do
     expect(tax_account.keepr_tax).to eq(nil)
   end
 
-  it "should be reverse found from account" do
+  it 'should be reverse found from account' do
     expect(tax_account.keepr_taxes).to eq([tax])
     expect(account.keepr_taxes).to eq([])
   end
 
-  it "should avoid circular reference" do
+  it 'should avoid circular reference' do
     tax.keepr_account = account
     expect(tax).to be_invalid
     expect(tax.errors[:keepr_account_id]).to be_present

data/spec/spec_helper.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 require 'coveralls'
 
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
-  SimpleCov::Formatter::HTMLFormatter,
-  Coveralls::SimpleCov::Formatter
-])
+                                                                 SimpleCov::Formatter::HTMLFormatter,
+                                                                 Coveralls::SimpleCov::Formatter
+                                                               ])
 SimpleCov.start do
   add_filter '/spec/'
 end
@@ -27,7 +29,7 @@ I18n.enforce_available_locales = false
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[File.expand_path(File.join(File.dirname(__FILE__),'support','**','*.rb'))].each {|f| require f}
+Dir[File.expand_path(File.join(File.dirname(__FILE__), 'support', '**', '*.rb'))].each { |f| require f }
 
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
@@ -63,4 +65,3 @@ RSpec.configure do |config|
     DatabaseCleaner.clean
   end
 end
-

data/spec/support/contact.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Contact < ActiveRecord::Base
   has_many_keepr_accounts
 end

data/spec/support/document.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Document < ActiveRecord::Base
   has_keepr_journals
   has_keepr_postings

data/spec/support/ledger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Ledger < ActiveRecord::Base
   has_one_keepr_account
 end

data/spec/support/spec_migration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SpecMigration < Keepr::MIGRATION_BASE_CLASS
   def self.up
     create_table Contact, force: true do |t|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: keepr
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Georg Ledermann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-24 00:00:00.000000000 Z
+date: 2019-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: ancestry
   requirement: !ruby/object:Gem::Requirement
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: database_cleaner
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -123,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: factory_bot
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,7 +137,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -164,6 +164,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Double entry bookkeeping with Rails
 email: mail@georg-ledermann.de
 executables: []
@@ -171,16 +185,17 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- ci/Gemfile-rails-4-1
 - ci/Gemfile-rails-4-2
 - ci/Gemfile-rails-5-0
 - ci/Gemfile-rails-5-1
 - ci/Gemfile-rails-5-2
+- ci/Gemfile-rails-6-0
 - keepr.gemspec
 - lib/generators/keepr/migration/migration_generator.rb
 - lib/generators/keepr/migration/templates/migration.rb
@@ -233,15 +248,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.2
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Some basic ActiveRecord models to build a double entry bookkeeping application