keepr 0.4.0 → 0.5.0

data/spec/keepr/account_spec.rb

@@ -1,21 +1,22 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::Account do
   describe :number_as_string do
-    it "should return number with leading zeros for low values" do
+    it 'should return number with leading zeros for low values' do
       account = Keepr::Account.new(number: 999)
       expect(account.number_as_string).to eq('0999')
     end
 
-    it "should return number unchanged for high values" do
-      account = Keepr::Account.new(number: 70000)
+    it 'should return number unchanged for high values' do
+      account = Keepr::Account.new(number: 70_000)
       expect(account.number_as_string).to eq('70000')
     end
   end
 
   describe :to_s do
-    it "should format" do
+    it 'should format' do
       account = Keepr::Account.new(number: 27, name: 'Software')
       expect(account.to_s).to eq('0027 (Software)')
     end
@@ -32,25 +33,25 @@ describe Keepr::Account do
                            keepr_postings_attributes: [
                              { keepr_account: account_1000, amount: 20, side: 'debit' },
                              { keepr_account: account_1200, amount: 20, side: 'credit' }
-                            ]
+                           ]
 
     Keepr::Journal.create! date: Date.yesterday,
                            keepr_postings_attributes: [
                              { keepr_account: account_1000, amount:  10, side: 'credit' },
-                             { keepr_account: account_1200, amount:  10, side: 'debit' },
-                            ]
+                             { keepr_account: account_1200, amount:  10, side: 'debit' }
+                           ]
 
-    Keepr::Journal.create! date: Date.today,
+    Keepr::Journal.create! date: Date.current,
                            keepr_postings_attributes: [
                              { keepr_account: account_1000, amount: 200, side: 'debit' },
                              { keepr_account: account_1200, amount: 200, side: 'credit' }
-                            ]
+                           ]
 
-    Keepr::Journal.create! date: Date.today,
+    Keepr::Journal.create! date: Date.current,
                            keepr_postings_attributes: [
                              { keepr_account: account_1000, amount: 100, side: 'credit' },
-                             { keepr_account: account_1200, amount: 100, side: 'debit' },
-                            ]
+                             { keepr_account: account_1200, amount: 100, side: 'debit' }
+                           ]
   end
 
   describe 'validations' do
@@ -58,31 +59,31 @@ describe Keepr::Account do
     let!(:liability_group) { FactoryBot.create(:group, target: :liability) }
     let!(:asset_group)     { FactoryBot.create(:group, target: :asset) }
 
-    it "should not allow assigning to result group" do
+    it 'should not allow assigning to result group' do
       account = FactoryBot.build(:account, keepr_group: result_group)
       expect(account).to_not be_valid
-      expect(account.errors.added? :keepr_group_id, :no_group_allowed_for_result).to eq(true)
+      expect(account.errors.added?(:keepr_group_id, :no_group_allowed_for_result)).to eq(true)
     end
 
-    it "should not allow assigning asset account to liability group" do
+    it 'should not allow assigning asset account to liability group' do
       account = FactoryBot.build(:account, kind: :asset, keepr_group: liability_group)
       expect(account).to_not be_valid
-      expect(account.errors.added? :kind, :group_mismatch).to eq(true)
+      expect(account.errors.added?(:kind, :group_mismatch)).to eq(true)
     end
 
-    it "should not allow assigning liability account to asset group" do
+    it 'should not allow assigning liability account to asset group' do
       account = FactoryBot.build(:account, kind: :liability, keepr_group: asset_group)
       expect(account).to_not be_valid
-      expect(account.errors.added? :kind, :group_mismatch).to eq(true)
+      expect(account.errors.added?(:kind, :group_mismatch)).to eq(true)
     end
 
-    it "should not allow assigning forward account to asset group" do
+    it 'should not allow assigning forward account to asset group' do
       account = FactoryBot.build(:account, kind: :forward, keepr_group: asset_group)
       expect(account).to_not be_valid
-      expect(account.errors.added? :kind, :group_conflict).to eq(true)
+      expect(account.errors.added?(:kind, :group_conflict)).to eq(true)
     end
 
-    it "should allow target match" do
+    it 'should allow target match' do
       account = FactoryBot.build(:account, kind: :asset, keepr_group: asset_group)
       expect(account).to be_valid
     end
@@ -176,8 +177,8 @@ end
 
 describe Keepr::Account, 'with subaccounts' do
   let!(:account_1400) { FactoryBot.create(:account, number: 1400) }
-  let!(:account_10000) { FactoryBot.create(:account, number: 10000, parent: account_1400) }
-  let!(:account_10001) { FactoryBot.create(:account, number: 10001, parent: account_1400) }
+  let!(:account_10000) { FactoryBot.create(:account, number: 10_000, parent: account_1400) }
+  let!(:account_10001) { FactoryBot.create(:account, number: 10_001, parent: account_1400) }
   let!(:account_8400) { FactoryBot.create(:account, number: 8400) }
 
   before :each do
@@ -185,7 +186,7 @@ describe Keepr::Account, 'with subaccounts' do
                            keepr_postings_attributes: [
                              { keepr_account: account_10000, amount: 20, side: 'debit' },
                              { keepr_account: account_8400, amount: 20, side: 'credit' }
-                            ]
+                           ]
   end
 
   describe :keepr_postings do
@@ -209,34 +210,38 @@ describe Keepr::Account, 'with subaccounts' do
 
   describe :with_sums do
     it 'should calc balance' do
-      expect(Keepr::Account.with_sums.
-                     select(&:sum_amount).
-                     map { |a| [a.number, a.sum_amount] }).
-                     to eq([[8400, -20], [10000, 20]])
+      expect(Keepr::Account.with_sums
+                     .select(&:sum_amount)
+                     .map { |a| [a.number, a.sum_amount] })
+        .to eq([[8400, -20], [10_000, 20]])
     end
   end
 
   describe :merged_with_sums do
     it 'should calc merged balance' do
-      expect(Keepr::Account.merged_with_sums.
-                     select(&:sum_amount).
-                     map { |a| [a.number, a.sum_amount] }).
-                     to eq([[1400, 20], [8400, -20]])
+      expect(Keepr::Account.merged_with_sums
+                     .select(&:sum_amount)
+                     .map { |a| [a.number, a.sum_amount] })
+        .to eq([[1400, 20], [8400, -20]])
     end
   end
 end
 
 describe Keepr::Account, 'with tax' do
-  let!(:tax_account) { Keepr::Account.create! number: 1776,
-                                              name: 'Umsatzsteuer 19%',
-                                              kind: :asset }
+  let!(:tax_account) do
+    Keepr::Account.create! number: 1776,
+                           name: 'Umsatzsteuer 19%',
+                           kind: :asset
+  end
 
-  let!(:tax) { Keepr::Tax.create! name: 'USt19',
-                                  description: 'Umsatzsteuer 19%',
-                                  value: 19.0,
-                                  keepr_account: tax_account }
+  let!(:tax) do
+    Keepr::Tax.create! name: 'USt19',
+                       description: 'Umsatzsteuer 19%',
+                       value: 19.0,
+                       keepr_account: tax_account
+  end
 
-  it "should link to tax" do
+  it 'should link to tax' do
     account = Keepr::Account.new number: 8400,
                                  name: 'Erlöse 19% USt',
                                  kind: :revenue,
@@ -244,7 +249,7 @@ describe Keepr::Account, 'with tax' do
     expect(account).to be_valid
   end
 
-  it "should avoid circular reference" do
+  it 'should avoid circular reference' do
     tax_account.keepr_tax_id = tax.id
     expect(tax_account).to be_invalid
   end

data/spec/keepr/active_record_extension_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::ActiveRecordExtension do
@@ -13,14 +15,14 @@ describe Keepr::ActiveRecordExtension do
     end
 
     it 'has keepr_postings' do
-      journal = Keepr::Journal.create! keepr_postings_attributes: [
-                               { keepr_account: account,      amount: 30, side: 'debit'  },
-                               { keepr_account: account_1200, amount: 30, side: 'credit' }
-                             ]
-      other_journal = Keepr::Journal.create! keepr_postings_attributes: [
-                               { keepr_account: account_1000, amount: 20, side: 'debit'  },
-                               { keepr_account: account_1200, amount: 20, side: 'credit' }
-                             ]
+      Keepr::Journal.create! keepr_postings_attributes: [
+        { keepr_account: account,      amount: 30, side: 'debit'  },
+        { keepr_account: account_1200, amount: 30, side: 'credit' }
+      ]
+      Keepr::Journal.create! keepr_postings_attributes: [
+        { keepr_account: account_1000, amount: 20, side: 'debit'  },
+        { keepr_account: account_1200, amount: 20, side: 'credit' }
+      ]
 
       expect(ledger.keepr_postings.count).to eq(1)
       expect(ledger.keepr_postings.first.amount).to eq(30)
@@ -37,14 +39,14 @@ describe Keepr::ActiveRecordExtension do
     end
 
     it 'has keepr_postings' do
-      journal = Keepr::Journal.create! keepr_postings_attributes: [
-                               { keepr_account: account1,     amount: 30, side: 'debit'  },
-                               { keepr_account: account_1200, amount: 30, side: 'credit' }
-                             ]
-      other_journal = Keepr::Journal.create! keepr_postings_attributes: [
-                               { keepr_account: account_1000, amount: 20, side: 'debit'  },
-                               { keepr_account: account_1200, amount: 20, side: 'credit' }
-                             ]
+      Keepr::Journal.create! keepr_postings_attributes: [
+        { keepr_account: account1,     amount: 30, side: 'debit'  },
+        { keepr_account: account_1200, amount: 30, side: 'credit' }
+      ]
+      Keepr::Journal.create! keepr_postings_attributes: [
+        { keepr_account: account_1000, amount: 20, side: 'debit'  },
+        { keepr_account: account_1200, amount: 20, side: 'credit' }
+      ]
 
       expect(contact.keepr_postings.count).to eq(1)
       expect(contact.keepr_postings.first.amount).to eq(30)
@@ -70,7 +72,7 @@ describe Keepr::ActiveRecordExtension do
 
   describe 'scopes' do
     let!(:unbooked_document) { Document.create! number: 'Unbooked' }
-    let!(:booked_document) {
+    let!(:booked_document) do
       document = Document.create! number: 'Booked'
       Keepr::Journal.create! accountable: document,
                              keepr_postings_attributes: [
@@ -78,7 +80,7 @@ describe Keepr::ActiveRecordExtension do
                                { keepr_account: account_1200, amount: 100.99, side: 'credit' }
                              ]
       document
-    }
+    end
 
     describe :keepr_booked do
       subject { Document.keepr_booked }

data/spec/keepr/contact_export_spec.rb

@@ -1,22 +1,25 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::ContactExport do
-  let!(:account_1000)  { FactoryBot.create :account, kind: :asset,     number: 1000,  name: 'Kasse'      }
-  let!(:account_10000) { FactoryBot.create :account, kind: :creditor,  number: 10000, name: 'Meyer GmbH' }
-  let!(:account_70000) { FactoryBot.create :account, kind: :debtor,    number: 70000, name: 'Schulze AG' }
+  let!(:account_1000)  { FactoryBot.create :account, kind: :asset,     number: 1000, name: 'Kasse' }
+  let!(:account_10000) { FactoryBot.create :account, kind: :creditor,  number: 10_000, name: 'Meyer GmbH' }
+  let!(:account_70000) { FactoryBot.create :account, kind: :debtor,    number: 70_000, name: 'Schulze AG' }
 
   let(:scope) { Keepr::Account.all }
 
-  let(:export) {
-    Keepr::ContactExport.new(scope,
-      'Berater'     => 1234567,
-      'Mandant'     => 78901,
-      'WJ-Beginn'   => Date.new(2016,1,1),
+  let(:export) do
+    Keepr::ContactExport.new(
+      scope,
+      'Berater'     => 1_234_567,
+      'Mandant'     => 78_901,
+      'WJ-Beginn'   => Date.new(2016, 1, 1),
       'Bezeichnung' => 'Keepr-Kontakte'
     ) do |account|
       { 'Kurzbezeichnung' => account.name }
     end
-  }
+  end
 
   describe :to_s do
     subject { export.to_s }
@@ -25,31 +28,31 @@ describe Keepr::ContactExport do
       subject.lines[2..-1]
     end
 
-    it "should return CSV lines" do
+    it 'should return CSV lines' do
       subject.lines.each { |line| expect(line).to include(';') }
     end
 
-    it "should include header data" do
+    it 'should include header data' do
       expect(subject.lines[0]).to include('1234567;')
       expect(subject.lines[0]).to include('78901;')
       expect(subject.lines[0]).to include('"Keepr-Kontakte";')
     end
 
-    it "should include debtor/creditor accounts only" do
+    it 'should include debtor/creditor accounts only' do
       expect(account_lines.count).to eq(2)
 
       expect(account_lines[0]).to include('10000;')
       expect(account_lines[1]).to include('70000;')
     end
 
-    it "should include data from block" do
+    it 'should include data from block' do
       expect(account_lines[0]).to include('"Meyer GmbH";')
       expect(account_lines[1]).to include('"Schulze AG";')
     end
   end
 
   describe :to_file do
-    it "should create CSV file" do
+    it 'should create CSV file' do
       Dir.mktmpdir do |dir|
         filename = "#{dir}/EXTF_Stammdaten.csv"
         export.to_file(filename)

data/spec/keepr/cost_center_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::CostCenter do

data/spec/keepr/group_spec.rb

@@ -1,17 +1,19 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::Group do
   describe 'validations' do
-    it "should allow is_result for liability" do
+    it 'should allow is_result for liability' do
       group = Keepr::Group.new(is_result: true, target: :liability, name: 'foo')
       expect(group).to be_valid
     end
 
-    [ :asset, :profit_and_loss ].each do |target|
+    %i[asset profit_and_loss].each do |target|
       it "should not allow is_result for #{target}" do
         group = Keepr::Group.new(is_result: true, target: target, name: 'foo')
         expect(group).not_to be_valid
-        expect(group.errors.added? :base, :liability_needed_for_result).to eq(true)
+        expect(group.errors.added?(:base, :liability_needed_for_result)).to eq(true)
       end
     end
   end
@@ -28,9 +30,9 @@ describe Keepr::Group do
   describe :keepr_accounts do
     it 'should not destroy if there are accounts' do
       group = FactoryBot.create :group
-      account = FactoryBot.create :account, number: 1000, keepr_group: group
+      FactoryBot.create :account, number: 1000, keepr_group: group
 
-      expect { group.destroy }.to_not change { Keepr::Group.count }
+      expect { group.destroy }.to_not change(Keepr::Group, :count)
       expect(group.destroy).to eq(false)
       expect(group.reload).to eq(group)
     end
@@ -52,7 +54,7 @@ describe Keepr::Group do
     let(:group_2)     { FactoryBot.create :group, target: :profit_and_loss }
 
     # Group for balance result
-    let(:group_result){ FactoryBot.create :group, target: :liability, is_result: true }
+    let(:group_result) { FactoryBot.create :group, target: :liability, is_result: true }
 
     # Accounts
     let(:account_1a)  { FactoryBot.create :account, number: '0001', keepr_group: group_1_1_1 }
@@ -62,40 +64,42 @@ describe Keepr::Group do
     let(:account_2)   { FactoryBot.create :account, number: '8400', keepr_group: group_2, kind: :revenue }
 
     # Journals
-    let!(:journal1)   { Keepr::Journal.create! keepr_postings_attributes: [
-                          { keepr_account: account_1a, amount: 100.99, side: 'debit' },
-                          { keepr_account: account_2,  amount: 100.99, side: 'credit' }
-                        ]
-                      }
-    let!(:journal2)   { Keepr::Journal.create! keepr_postings_attributes: [
-                          { keepr_account: account_1b, amount: 100.99, side: 'debit' },
-                          { keepr_account: account_2, amount: 100.99, side: 'credit' }
-                        ]
-                      }
-    let!(:journal3)   { Keepr::Journal.create! keepr_postings_attributes: [
-                          { keepr_account: account_1c, amount: 100.99, side: 'debit' },
-                          { keepr_account: account_2,  amount: 100.99, side: 'credit' }
-                        ]
-                      }
+    let!(:journal1)   do
+      Keepr::Journal.create! keepr_postings_attributes: [
+        { keepr_account: account_1a, amount: 100.99, side: 'debit' },
+        { keepr_account: account_2, amount: 100.99, side: 'credit' }
+      ]
+    end
+    let!(:journal2) do
+      Keepr::Journal.create! keepr_postings_attributes: [
+        { keepr_account: account_1b, amount: 100.99, side: 'debit' },
+        { keepr_account: account_2, amount: 100.99, side: 'credit' }
+      ]
+    end
+    let!(:journal3) do
+      Keepr::Journal.create! keepr_postings_attributes: [
+        { keepr_account: account_1c, amount: 100.99, side: 'debit' },
+        { keepr_account: account_2, amount: 100.99, side: 'credit' }
+      ]
+    end
 
     context 'for normal groups' do
-      it "should return postings of all accounts within the group" do
-        postings_1 = [journal1.debit_postings.first, journal2.debit_postings.first, journal3.debit_postings.first]
-        expect(group_1.keepr_postings).to eq(postings_1)
-        expect(group_1_1.keepr_postings).to eq(postings_1)
-        expect(group_1_1_1.keepr_postings).to eq(postings_1)
-
-        postings_2 = [journal1.credit_postings.first, journal2.credit_postings.first, journal3.credit_postings.first]
-        expect(group_2.keepr_postings).to eq(postings_2)
+      it 'should return postings of all accounts within the group' do
+        postings1 = [journal1.debit_postings.first, journal2.debit_postings.first, journal3.debit_postings.first]
+        expect(group_1.keepr_postings).to eq(postings1)
+        expect(group_1_1.keepr_postings).to eq(postings1)
+        expect(group_1_1_1.keepr_postings).to eq(postings1)
+
+        postings2 = [journal1.credit_postings.first, journal2.credit_postings.first, journal3.credit_postings.first]
+        expect(group_2.keepr_postings).to eq(postings2)
       end
     end
 
-    context "for result group" do
-      it "should return postings for P&L accounts" do
-        result_postings = [ journal1.credit_postings.first,
-                            journal2.credit_postings.first,
-                            journal3.credit_postings.first
-                          ]
+    context 'for result group' do
+      it 'should return postings for P&L accounts' do
+        result_postings = [journal1.credit_postings.first,
+                           journal2.credit_postings.first,
+                           journal3.credit_postings.first]
 
         expect(group_result.keepr_postings).to eq(result_postings)
       end

data/spec/keepr/groups_creator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::GroupsCreator do
@@ -6,7 +8,7 @@ describe Keepr::GroupsCreator do
       Keepr::GroupsCreator.new(:balance).run
     end
 
-    it "should create groups" do
+    it 'should create groups' do
       expect(Keepr::Group.count).to eq(64)
       expect(Keepr::Group.asset.count).to eq(36)
       expect(Keepr::Group.liability.count).to eq(28)
@@ -15,7 +17,7 @@ describe Keepr::GroupsCreator do
       compare_with_source(Keepr::Group.liability, 'liability.txt')
     end
 
-    it "should create result group" do
+    it 'should create result group' do
       expect(Keepr::Group.result).to be_a(Keepr::Group)
     end
   end
@@ -25,7 +27,7 @@ describe Keepr::GroupsCreator do
       Keepr::GroupsCreator.new(:profit_and_loss).run
     end
 
-    it "should create profit & loss groups" do
+    it 'should create profit & loss groups' do
       expect(Keepr::Group.count).to eq(31)
       expect(Keepr::Group.profit_and_loss.count).to eq(31)
 
@@ -33,7 +35,8 @@ describe Keepr::GroupsCreator do
     end
   end
 
-private
+  private
+
   def compare_with_source(scope, filename)
     full_filename = File.join(File.dirname(__FILE__), "../../lib/keepr/groups_creator/#{filename}")
     source = File.read(full_filename)