katello 4.17.1 → 4.18.0.rc2

data/webpack/scenes/FlatpakRemotes/CreateEdit/__tests__/flatpakRemoteform.test.js

@@ -0,0 +1,117 @@
+import React from 'react';
+import { renderWithRedux, patientlyWaitFor, fireEvent } from 'react-testing-lib-wrapper';
+import { nockInstance, assertNockRequest } from '../../../../test-utils/nockWrapper';
+import FlatpakRemotesForm from '../FlatpakRemoteform';
+import api from '../../../../services/api';
+
+const mockFn = jest.fn();
+delete window.location;
+window.location = { assign: mockFn };
+
+afterEach(() => {
+  mockFn.mockClear();
+});
+
+const createFlatpakPath = api.getApiUrl('/flatpak_remotes');
+const updateFlatpakPath = id => api.getApiUrl(`/flatpak_remotes/${id}`);
+
+const mockRemoteData = {
+  id: 1,
+  name: 'Test Remote',
+  url: 'https://example.com',
+  username: 'testuser',
+  upstream_password_exists: true,
+};
+
+test('Renders FlatpakRemotesForm fields correctly', () => {
+  const { getByText } = renderWithRedux(<FlatpakRemotesForm setModalOpen={mockFn} />);
+  expect(getByText('Name')).toBeInTheDocument();
+  expect(getByText('URL')).toBeInTheDocument();
+  expect(getByText('Username')).toBeInTheDocument();
+  expect(getByText('Password')).toBeInTheDocument();
+});
+
+test('Can save Flatpak remote from form', async (done) => {
+  const createScope = nockInstance
+    .post(createFlatpakPath, {
+      organization_id: 1,
+      name: 'New Remote',
+      url: 'https://example.com',
+      username: 'testuser',
+      token: 'password123',
+    })
+    .reply(201, { id: 2 });
+
+  const { getByLabelText, getByText } = renderWithRedux(<FlatpakRemotesForm
+    setModalOpen={mockFn}
+  />);
+  fireEvent.change(getByLabelText('input_name'), { target: { value: 'New Remote' } });
+  fireEvent.change(getByLabelText('input_url'), { target: { value: 'https://example.com' } });
+  fireEvent.change(getByLabelText('input_username'), { target: { value: 'testuser' } });
+  fireEvent.change(getByLabelText('input_password'), { target: { value: 'password123' } });
+
+  getByText('Create').click();
+
+  await patientlyWaitFor(() => {
+    expect(window.location.assign).toHaveBeenCalledWith('/flatpak_remotes/2');
+  });
+
+  assertNockRequest(createScope);
+  done();
+});
+
+test('Can update Flatpak remote from form', async (done) => {
+  const updateScope = nockInstance
+    .put(updateFlatpakPath(mockRemoteData.id), {
+      name: 'Updated Remote',
+      url: 'https://updated.com',
+      username: 'updateduser',
+    })
+    .reply(200);
+
+  const { getByLabelText, getByText } = renderWithRedux(<FlatpakRemotesForm
+    setModalOpen={mockFn}
+    remoteData={mockRemoteData}
+  />);
+
+  fireEvent.change(getByLabelText('input_name'), { target: { value: 'Updated Remote' } });
+  fireEvent.change(getByLabelText('input_url'), { target: { value: 'https://updated.com' } });
+  fireEvent.change(getByLabelText('input_username'), { target: { value: 'updateduser' } });
+
+  getByText('Update').click();
+
+  await patientlyWaitFor(() => {
+    expect(window.location.assign).toHaveBeenCalledWith('/flatpak_remotes/1');
+  });
+
+  assertNockRequest(updateScope);
+  done();
+});
+
+test('Can update Flatpak remote password from placeholder', async (done) => {
+  const updateScope = nockInstance
+    .put(updateFlatpakPath(mockRemoteData.id), {
+      name: mockRemoteData.name,
+      url: mockRemoteData.url,
+      username: mockRemoteData.username,
+      token: 'newpassword123',
+    })
+    .reply(200);
+
+  const { getByLabelText, getByText } = renderWithRedux(<FlatpakRemotesForm
+    setModalOpen={mockFn}
+    remoteData={mockRemoteData}
+  />);
+
+  // Simulate changing the password from the placeholder to a new value
+  fireEvent.change(getByLabelText('input_password'), { target: { value: 'newpassword123' } });
+
+  getByText('Update').click();
+
+  await patientlyWaitFor(() => {
+    expect(window.location.assign).toHaveBeenCalledWith('/flatpak_remotes/1');
+  });
+
+  assertNockRequest(updateScope);
+  done();
+});

data/webpack/scenes/FlatpakRemotes/Delete/DeleteFlatpakModal.js

@@ -0,0 +1,59 @@
+import React from 'react';
+import { useDispatch } from 'react-redux';
+import PropTypes from 'prop-types';
+import { Modal, ModalVariant, Button, Icon, Title, Flex } from '@patternfly/react-core';
+import { ExclamationTriangleIcon } from '@patternfly/react-icons';
+import { translate as __ } from 'foremanReact/common/I18n';
+import { deleteFlatpakRemote } from '../Details/FlatpakRemoteDetailActions';
+
+const DeleteFlatpakModal = ({ isModalOpen, handleModalToggle, remoteId }) => {
+  const dispatch = useDispatch();
+
+  const handleDelete = () => {
+    dispatch(deleteFlatpakRemote(remoteId, () => window.location.replace('/flatpak_remotes')));
+    handleModalToggle();
+  };
+
+  return (
+    <Modal
+      ouiaId="flatpak-delete-modal"
+      variant={ModalVariant.small}
+      title={[
+        <Flex key="delete-modal-header">
+          <Icon status="warning" key="exclamation-triangle">
+            <ExclamationTriangleIcon />
+          </Icon>
+          <Title ouiaId="flatpak-delete-header" key="delete-flatpak-title" headingLevel="h5" size="2xl">
+            {__('Delete Flatpak remote?')}
+          </Title>
+        </Flex>,
+      ]}
+      isOpen={isModalOpen}
+      onClose={handleModalToggle}
+      actions={[
+        <Button ouiaId="delete-button" key="delete" variant="danger" onClick={handleDelete}>
+          {__('Delete')}
+        </Button>,
+        <Button ouiaId="cancel-button" key="cancel" variant="link" onClick={handleModalToggle}>
+          {__('Cancel')}
+        </Button>,
+      ]}
+    >
+      {__('This Flatpak remote will be deleted. Repositories mirrored from this remote will remain available and functional for use')}
+    </Modal>
+  );
+};
+
+DeleteFlatpakModal.propTypes = {
+  isModalOpen: PropTypes.bool,
+  handleModalToggle: PropTypes.func,
+  remoteId: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+};
+
+DeleteFlatpakModal.defaultProps = {
+  isModalOpen: false,
+  handleModalToggle: () => {},
+  remoteId: undefined,
+};
+
+export default DeleteFlatpakModal;

data/webpack/scenes/FlatpakRemotes/Details/FlatpakRemoteDetailActions.js

@@ -0,0 +1,87 @@
+import { API_OPERATIONS, APIActions, get, post, put } from 'foremanReact/redux/API';
+import { translate as __ } from 'foremanReact/common/I18n';
+import { flatpakRemoteDetailsKey,
+  flatpakRemoteRepositoriesKey,
+  UPDATE_FLATPAK_REMOTE,
+  UPDATE_FLATPAK_REMOTE_SUCCESS,
+  UPDATE_FLATPAK_REMOTE_FAILURE,
+  DELETE_FLATPAK_REMOTE_KEY,
+  SCAN_FLATPAK_REMOTE_KEY } from '../FlatpakRemotesConstants';
+import api, { orgId } from '../../../services/api';
+import { getResponseErrorMsgs } from '../../../utils/helpers';
+import { renderTaskStartedToast } from '../../Tasks/helpers';
+
+const getFlatpakRemoteDetails = (id, extraParams = {}) => get({
+  type: API_OPERATIONS.GET,
+  key: flatpakRemoteDetailsKey(id),
+  params: { organization_id: orgId(), include_permissions: true, ...extraParams },
+  url: api.getApiUrl(`/flatpak_remotes/${id}`),
+});
+
+export const getRemoteRepositories = frId => () =>
+  get({
+    type: API_OPERATIONS.GET,
+    key: flatpakRemoteRepositoriesKey(frId),
+    url: api.getApiUrl(`/flatpak_remotes/${frId}/flatpak_remote_repositories`),
+    params: { organization_id: orgId() },
+  });
+
+export const updateFlatpakRemote = (frId, params, handleSuccess, handleError) => put({
+  type: API_OPERATIONS.PUT,
+  key: flatpakRemoteDetailsKey(frId),
+  url: api.getApiUrl(`/flatpak_remotes/${frId}`),
+  handleSuccess,
+  handleError,
+  params,
+  successToast: () => __('Flatpak remote updated'),
+  errorToast: error => getResponseErrorMsgs(error.response),
+  updateData: (_prevState, respState) => respState,
+  actionTypes: {
+    REQUEST: UPDATE_FLATPAK_REMOTE,
+    SUCCESS: UPDATE_FLATPAK_REMOTE_SUCCESS,
+    FAILURE: UPDATE_FLATPAK_REMOTE_FAILURE,
+  },
+});
+
+export const mirrorFlatpakRepository = (
+  flatpakRepoId,
+  productName,
+  handleSuccess,
+  handleError,
+) =>
+  post({
+    type: API_OPERATIONS.POST,
+    key: flatpakRemoteRepositoriesKey(flatpakRepoId),
+    url: api.getApiUrl(`/flatpak_remote_repositories/${flatpakRepoId}/mirror`),
+    params: { product_name: productName, organization_id: orgId() },
+    handleSuccess: (response) => {
+      if (handleSuccess) handleSuccess(response);
+      return renderTaskStartedToast(response.data);
+    },
+    handleError,
+    errorToast: error => getResponseErrorMsgs(error.response),
+  });
+
+export const deleteFlatpakRemote = (id, handleSuccess) => APIActions.delete({
+  type: API_OPERATIONS.DELETE,
+  key: DELETE_FLATPAK_REMOTE_KEY,
+  url: api.getApiUrl(`/flatpak_remotes/${id}`),
+  handleSuccess,
+  successToast: () => __('Flatpak remote deleted'),
+  errorToast: error => __('Flatpak remote could not be deleted: ') + getResponseErrorMsgs(error.response),
+});
+
+export const scanFlatpakRemote = (id, handleSuccess, handleError) => post({
+  type: API_OPERATIONS.POST,
+  key: SCAN_FLATPAK_REMOTE_KEY,
+  url: api.getApiUrl(`/flatpak_remotes/${id}/scan`),
+  handleSuccess: (response) => {
+    if (handleSuccess) handleSuccess(response);
+    return renderTaskStartedToast(response.data);
+  },
+  handleError,
+  errorToast: error => __('Flatpak remote scan could not be started: ') +
+        getResponseErrorMsgs(error.response),
+});
+
+export default getFlatpakRemoteDetails;

data/webpack/scenes/FlatpakRemotes/Details/FlatpakRemoteDetailReducers.js

@@ -0,0 +1,23 @@
+import Immutable from 'seamless-immutable';
+import {
+  UPDATE_FLATPAK_REMOTE,
+  UPDATE_FLATPAK_REMOTE_FAILURE,
+  UPDATE_FLATPAK_REMOTE_SUCCESS,
+} from '../FlatpakRemotesConstants';
+
+const initialState = Immutable({
+  updating: false,
+});
+
+export default (state = initialState, action) => {
+  switch (action.type) {
+  case UPDATE_FLATPAK_REMOTE:
+    return state.set('updating', true);
+  case UPDATE_FLATPAK_REMOTE_SUCCESS:
+    return state.merge({ updating: false });
+  case UPDATE_FLATPAK_REMOTE_FAILURE:
+    return state.set('updating', false);
+  default:
+    return state;
+  }
+};

data/webpack/scenes/FlatpakRemotes/Details/FlatpakRemoteDetailSelectors.js

@@ -0,0 +1,16 @@
+import { STATUS } from 'foremanReact/constants';
+import {
+  selectAPIError,
+  selectAPIResponse,
+  selectAPIStatus,
+} from 'foremanReact/redux/API/APISelectors';
+import { flatpakRemoteDetailsKey } from '../FlatpakRemotesConstants';
+
+export const selectFlatpakRemoteDetails = (state, id) =>
+  selectAPIResponse(state, flatpakRemoteDetailsKey(id)) || {};
+
+export const selectFlatpakRemoteDetailStatus =
+  (state, id) => selectAPIStatus(state, flatpakRemoteDetailsKey(id)) || STATUS.PENDING;
+
+export const selectFlatpakRemoteDetailError =
+  (state, id) => selectAPIError(state, flatpakRemoteDetailsKey(id));

data/webpack/scenes/FlatpakRemotes/Details/FlatpakRemoteDetails.js

@@ -0,0 +1,167 @@
+import React, { useState, useEffect } from 'react';
+import { useSelector, useDispatch, shallowEqual } from 'react-redux';
+import { useParams } from 'react-router-dom';
+import {
+  Breadcrumb,
+  BreadcrumbItem,
+  Button,
+  Title,
+  Grid,
+  GridItem,
+  Text,
+  TextContent,
+  TextList,
+  TextListVariants,
+  Flex,
+  FlexItem,
+} from '@patternfly/react-core';
+import {
+  Dropdown,
+  DropdownItem,
+  KebabToggle,
+  DropdownPosition,
+} from '@patternfly/react-core/deprecated';
+import { translate as __ } from 'foremanReact/common/I18n';
+import { selectFlatpakRemoteDetails } from './FlatpakRemoteDetailSelectors';
+import getFlatpakRemoteDetails, {
+  scanFlatpakRemote,
+  updateFlatpakRemote,
+} from './FlatpakRemoteDetailActions';
+import ActionableDetail from '../../../components/ActionableDetail';
+import RemoteRepositoriesTable from './RemoteRepositories/RemoteRepositoriesTable';
+import EditFlatpakRemotesModal from '../CreateEdit/EditFlatpakRemotesModal';
+import DeleteFlatpakModal from '../Delete/DeleteFlatpakModal';
+
+export default function FlatpakRemoteDetails() {
+  const { id } = useParams();
+  const frId = Number(id);
+  const [dropDownOpen, setDropdownOpen] = useState(false);
+  const [isScanning, setIsScanning] = useState(false);
+  const [isEditing, setIsEditing] = useState(false);
+  const dispatch = useDispatch();
+
+  const [currentAttribute, setCurrentAttribute] = useState(null);
+  const [isDeleteModalOpen, setDeleteModalOpen] = useState(false);
+
+  useEffect(() => {
+    dispatch(getFlatpakRemoteDetails(frId));
+  }, [dispatch, frId]);
+
+  const frDetails = useSelector(state =>
+    selectFlatpakRemoteDetails(state, frId), shallowEqual) || {};
+  const name = frDetails.name || '';
+  const url = frDetails.url || '';
+
+  const {
+    can_edit: canEdit = false,
+    can_delete: canDelete = false,
+    can_mirror: canMirror = false,
+  } = frDetails || {};
+
+  const onEdit = (val, attribute) => {
+    if (val === frDetails[attribute]) return;
+    dispatch(updateFlatpakRemote(frId, { [attribute]: val }));
+  };
+
+  const dropDownItems = [];
+  if (canEdit) {
+    dropDownItems.push(<DropdownItem key="edit" ouiaId="fr-edit" onClick={() => { setIsEditing(true); }}> {__('Edit')}</DropdownItem>);
+  }
+  if (canDelete) {
+    dropDownItems.push(<DropdownItem key="delete" ouiaId="cv-delete" onClick={() => setDeleteModalOpen(true)}>{__('Delete')}</DropdownItem>);
+  }
+
+  return (
+    <Grid hasGutter span={12} style={{ padding: '24px' }}>
+      <GridItem span={12}>
+        <Breadcrumb ouiaId="flatpak-remote-breadcrumb">
+          <BreadcrumbItem to="/flatpak_remotes">Flatpak remotes</BreadcrumbItem>
+          <BreadcrumbItem isActive>{name}</BreadcrumbItem>
+        </Breadcrumb>
+      </GridItem>
+
+      <GridItem span={12}>
+        <Flex>
+          <FlexItem>
+            <Title headingLevel="h1" size="2xl" ouiaId="flatpak-remote-title">{name}</Title>
+          </FlexItem>
+          <FlexItem align={{ default: 'alignRight' }}>
+            {canEdit &&
+            <Button
+              ouiaId="fr-details-scan-button"
+              style={{ marginLeft: 'auto' }}
+              onClick={() => {
+                setIsScanning(true);
+                dispatch(scanFlatpakRemote(
+                  frId,
+                  () => { setIsScanning(false); },
+                  () => setIsScanning(false),
+                ));
+              }
+              }
+              variant="primary"
+              aria-label="scan_flatpak_remote"
+              isLoading={isScanning}
+              isDisabled={isScanning}
+            >
+              {__('Scan')}
+            </Button>
+            }
+            {dropDownItems.length > 0 &&
+            <Dropdown
+              position={DropdownPosition.right}
+              ouiaId="fr-details-actions"
+              style={{ marginLeft: 'auto' }}
+              toggle={<KebabToggle onToggle={(_event, val) => setDropdownOpen(val)} id="toggle-dropdown" />}
+              isOpen={dropDownOpen}
+              isPlain
+              dropdownItems={dropDownItems}
+            />
+            }
+          </FlexItem>
+        </Flex>
+      </GridItem>
+
+      <GridItem span={12}>
+        <TextContent>
+          <TextList component={TextListVariants.dl}>
+            <ActionableDetail
+              key={url}
+              label={__('URL:')}
+              attribute="url"
+              onEdit={onEdit}
+              disabled={!canEdit}
+              value={url}
+              {...{ currentAttribute, setCurrentAttribute }}
+            />
+          </TextList>
+        </TextContent>
+      </GridItem>
+
+      <GridItem span={12}>
+        <TextContent>
+          <Title headingLevel="h2" size="xl" ouiaId="flatpak-remote-subtitle">Remote repositories</Title>
+          <Text component="p" ouiaId="flatpak-remote-description" style={{ color: 'gray' }}>
+            This is a list of scanned flatpaks.
+            Mirroring a scanned flatpak creates a repository in the product of your choice.
+            Sync the repository after mirroring it from this remote to distribute its content.
+          </Text>
+        </TextContent>
+      </GridItem>
+
+      <GridItem span={12}>
+        <RemoteRepositoriesTable frId={frId} canMirror={canMirror} />
+      </GridItem>
+      { isEditing &&
+        <EditFlatpakRemotesModal show={isEditing} remoteData={frDetails} setIsOpen={setIsEditing} />
+      }
+      { isDeleteModalOpen &&
+        <DeleteFlatpakModal
+          isModalOpen={isDeleteModalOpen}
+          handleModalToggle={() => setDeleteModalOpen(!isDeleteModalOpen)}
+          remoteId={frId}
+        />
+        }
+    </Grid>
+  );
+}

data/webpack/scenes/FlatpakRemotes/Details/Mirror/MirrorRepositoryModal.js

@@ -0,0 +1,135 @@
+import React, { useState } from 'react';
+import PropTypes from 'prop-types';
+import { useDispatch } from 'react-redux';
+import { translate as __ } from 'foremanReact/common/I18n';
+import {
+  Modal,
+  ModalVariant,
+  Form,
+  FormGroup,
+  ActionGroup,
+  Button,
+  TextContent,
+  Text,
+  TextVariants,
+} from '@patternfly/react-core';
+import { orgId } from '../../../../services/api';
+import SearchText from '../../../../components/Search/SearchText';
+import { getRemoteRepositories, mirrorFlatpakRepository } from '../FlatpakRemoteDetailActions';
+
+const MirrorRepositoryModal = ({
+  frId,
+  closeModal,
+  repo,
+  onMirrorSuccess,
+}) => {
+  const dispatch = useDispatch();
+
+  const autoCompleteEndpoint = '/katello/api/v2/products/auto_complete_name';
+  const searchParams = term => ({
+    organization_id: orgId(),
+    enabled: true,
+    custom: true,
+    page: 1,
+    per_page: 5,
+    term,
+  });
+
+  const [productName, setProductName] = useState('');
+  const [loading, setLoading] = useState(false);
+
+  const handleSearchChange = (rawValue) => {
+    setProductName(rawValue.trim());
+  };
+
+  const handleMirror = (e) => {
+    e.preventDefault();
+    if (!productName || loading) return;
+    setLoading(true);
+    dispatch(mirrorFlatpakRepository(
+      repo.id,
+      productName,
+      () => {
+        dispatch(getRemoteRepositories(frId)());
+        setLoading(false);
+        if (onMirrorSuccess) onMirrorSuccess();
+        closeModal();
+      },
+      () => {
+        setLoading(false);
+        closeModal();
+      },
+    ));
+  };
+
+  return (
+    <Modal
+      ouiaId="mirror-repo-modal"
+      title={__('Mirror Repository')}
+      variant={ModalVariant.medium}
+      isOpen
+      onClose={closeModal}
+      appendTo={document.body}
+    >
+      <TextContent>
+        <Text component={TextVariants.p} ouiaId="mirror-text-info">
+          {__('Mirroring will import the remote flatpak repository')} <strong>{repo.name}</strong>{' '}
+          {__('into a product. Details from the flatpak remote will automatically populate the repository fields. The repository will be available for syncing once it has been mirrored into a product.')}
+        </Text>
+        <Text component={TextVariants.p} ouiaId="mirror-select-product">
+          {__('Select a product to mirror the repository into')}
+        </Text>
+      </TextContent>
+      <Form onSubmit={handleMirror}>
+        <FormGroup label={__('Product')} isRequired fieldId="mirror-product">
+          <SearchText
+            value={productName}
+            data={{
+              autocomplete: {
+                url: autoCompleteEndpoint,
+                apiParams: searchParams,
+              },
+            }}
+            onSearchChange={handleSearchChange}
+            aria-label="product-search"
+          />
+        </FormGroup>
+
+        <ActionGroup>
+          <Button
+            ouiaId="confirm-mirror-btn"
+            variant="primary"
+            type="submit"
+            isLoading={loading}
+            isDisabled={!productName || loading}
+          >
+            {__('Mirror')}
+          </Button>
+          <Button
+            ouiaId="cancel-mirror-btn"
+            variant="link"
+            onClick={closeModal}
+          >
+            {__('Cancel')}
+          </Button>
+        </ActionGroup>
+      </Form>
+    </Modal>
+  );
+};
+
+MirrorRepositoryModal.propTypes = {
+  frId: PropTypes.number.isRequired,
+  closeModal: PropTypes.func.isRequired,
+  repo: PropTypes.shape({
+    id: PropTypes.number.isRequired,
+    name: PropTypes.string.isRequired,
+  }).isRequired,
+  onMirrorSuccess: PropTypes.func,
+};
+
+MirrorRepositoryModal.defaultProps = {
+  onMirrorSuccess: null,
+};
+
+export default MirrorRepositoryModal;