katello 4.13.1 → 4.14.0.rc1

data/app/models/katello/repository.rb

@@ -32,6 +32,8 @@ module Katello
 
     EXPORTABLE_TYPES = [YUM_TYPE, FILE_TYPE, ANSIBLE_COLLECTION_TYPE, DOCKER_TYPE, DEB_TYPE].freeze
 
+    ALLOWED_UPDATE_FIELDS = ['version_href', 'last_indexed'].freeze
+
     define_model_callbacks :sync, :only => :after
 
     belongs_to :root, :inverse_of => :repositories, :class_name => "Katello::RootRepository"
@@ -119,8 +121,10 @@ module Katello
 
     before_validation :set_pulp_id
     before_validation :set_container_repository_name, :unless => :skip_container_name?
+    before_update :prevent_updates, :unless => :allow_updates?
 
     scope :has_url, -> { joins(:root).where.not("#{RootRepository.table_name}.url" => nil) }
+    scope :not_uln, -> { joins(:root).where("#{RootRepository.table_name}.url NOT LIKE 'uln%'") }
     scope :on_demand, -> { joins(:root).where("#{RootRepository.table_name}.download_policy" => ::Katello::RootRepository::DOWNLOAD_ON_DEMAND) }
     scope :immediate, -> { joins(:root).where("#{RootRepository.table_name}.download_policy" => ::Katello::RootRepository::DOWNLOAD_IMMEDIATE) }
     scope :non_immediate, -> { joins(:root).where.not("#{RootRepository.table_name}.download_policy" => ::Katello::RootRepository::DOWNLOAD_IMMEDIATE) }
@@ -166,7 +170,7 @@ module Katello
     scoped_search :on => :name, :relation => :product, :rename => :product_name
     scoped_search :on => :id, :relation => :product, :rename => :product_id, :only_explicit => true
     scoped_search :on => :label, :relation => :root, :complete_value => true, :only_explicit => true
-    scoped_search :on => :content_label, :ext_method => :search_by_content_label
+    scoped_search :on => :content_label, :ext_method => :search_by_content_label, :default_operator => :like
 
     delegate :product, :redhat?, :custom?, :to => :root
     delegate :yum?, :docker?, :deb?, :file?, :ostree?, :ansible_collection?, :generic?, :to => :root
@@ -179,7 +183,7 @@ module Katello
              :deb_components, :deb_architectures, :ssl_ca_cert_id, :ssl_ca_cert, :ssl_client_cert, :ssl_client_cert_id,
              :ssl_client_key_id, :os_versions, :ssl_client_key, :ignorable_content, :description, :include_tags, :exclude_tags,
              :ansible_collection_requirements, :ansible_collection_auth_url, :ansible_collection_auth_token,
-             :http_proxy_policy, :http_proxy_id, :to => :root
+             :http_proxy_policy, :http_proxy_id, :prevent_updates, :to => :root
 
     delegate :content_id, to: :root, allow_nil: true
     delegate :repository_type, to: :root
@@ -345,9 +349,10 @@ module Katello
     def content_counts
       content_counts = {}
       RepositoryTypeManager.defined_repository_types[content_type].content_types_to_index.each do |content_type|
-        if content_type&.model_class::CONTENT_TYPE == DockerTag::CONTENT_TYPE
+        case content_type&.model_class::CONTENT_TYPE
+        when DockerTag::CONTENT_TYPE
           content_counts[DockerTag::CONTENT_TYPE] = docker_tags.count
-        elsif content_type&.model_class::CONTENT_TYPE == GenericContentUnit::CONTENT_TYPE
+        when GenericContentUnit::CONTENT_TYPE
           content_counts[content_type.content_type] = content_type&.model_class&.in_repositories(self)&.where(:content_type => content_type.content_type)&.count
         else
           content_counts[content_type.label] = content_type&.model_class&.in_repositories(self)&.count
@@ -791,6 +796,8 @@ module Katello
           return true
         elsif !self.custom? && self.redhat_deletable?(remove_from_content_view_versions)
           return true
+        elsif Setting.find_by(name: 'delete_repo_across_cv')&.value
+          return true
         else
           errors.add(:base, _("Repository cannot be deleted since it has already been included in a published Content View. " \
                               "Please delete all Content View versions containing this repository before attempting to delete it "\
@@ -1007,6 +1014,7 @@ module Katello
         repository_type.index_additional_data_proc&.call(self)
       end
       self.update!(last_indexed: DateTime.now)
+
       true
     end
 
@@ -1048,6 +1056,12 @@ module Katello
       DockerMetaTag.cleanup_tags
     end
 
+    def allow_updates?
+      # allow the update if this repo is not in the default view
+      return true unless in_default_view?
+      root.allow_updates?(::Katello::Repository::ALLOWED_UPDATE_FIELDS)
+    end
+
     apipie :class, desc: "A class representing #{model_name.human} object" do
       name 'Repository'
       refs 'Repository'

data/app/models/katello/root_repository.rb

@@ -46,6 +46,8 @@ module Katello
     MIRRORING_POLICY_COMPLETE = 'mirror_complete'.freeze
     MIRRORING_POLICIES = [MIRRORING_POLICY_ADDITIVE, MIRRORING_POLICY_COMPLETE, MIRRORING_POLICY_CONTENT].freeze
 
+    ALLOWED_UPDATE_FIELDS = ['updated_at', 'content_id'].freeze
+
     belongs_to :product, :inverse_of => :root_repositories, :class_name => "Katello::Product"
     has_one :provider, :through => :product
 
@@ -115,6 +117,7 @@ module Katello
       }
 
     validates :container_push_name_format, inclusion: { in: ['label', 'id'].freeze, allow_nil: true}
+    before_update :prevent_updates, :unless => :allow_updates?
 
     scope :subscribable, -> { where(content_type: RootRepository::SUBSCRIBABLE_TYPES) }
     scope :skipable_metadata_check, -> { where(content_type: RootRepository::SKIPABLE_METADATA_TYPES) }
@@ -455,6 +458,22 @@ module Katello
       end
     end
 
+    def allow_updates?(additional_allowed_fields = [])
+      # allow updates for non-container-push repos, repos not in default view, and
+      # repos with a library instance
+      return true unless is_container_push && library_instance.present?
+
+      # let updates that contain ONLY allowed strings through
+      allowed_fields = ::Katello::RootRepository::ALLOWED_UPDATE_FIELDS + additional_allowed_fields
+      return true if (changed - allowed_fields).empty?
+
+      false
+    end
+
+    def prevent_updates
+      fail _("Cannot update properties of a container push repository")
+    end
+
     apipie :class, desc: 'A class representing Repository object' do
       name 'Repository'
       refs 'Repository'

data/app/models/katello/rpm.rb

@@ -53,7 +53,7 @@ module Katello
       # https://github.com/wvanbergen/scoped_search/blob/master/lib/scoped_search/query_builder.rb
       if ['LIKE', 'NOT LIKE'].include?(operator)
         conditions = "#{self.table_name}.#{column} #{operator} ?"
-        parameter = (value !~ /^\%|\*/ && value !~ /\%|\*$/) ? "%#{value}%" : value.tr_s('%*', '%')
+        parameter = (value !~ /^%|\*/ && value !~ /%|\*$/) ? "%#{value}%" : value.tr_s('%*', '%')
         return { :conditions => conditions, :parameter => [parameter] }
       elsif ['IN', 'NOT IN'].include?(operator)
         conditions = "#{self.table_name}.#{column} #{operator} (#{value.split(',').collect { '?' }.join(',')})"
@@ -124,7 +124,7 @@ module Katello
     end
 
     def self.scoped_search_evr_like(operator, value)
-      val = (value !~ /^\%|\*/ && value !~ /\%|\*$/) ? "%#{value}%" : value.tr_s('%*', '%')
+      val = (value !~ /^%|\*/ && value !~ /%|\*$/) ? "%#{value}%" : value.tr_s('%*', '%')
       evr = Util::Package.parse_evr(val)
       (e, v, r) = [evr[:epoch], evr[:version], evr[:release]]
       conditions = []

data/app/models/katello/subscription_facet_pool.rb

@@ -1,6 +1,6 @@
 module Katello
   class SubscriptionFacetPool < Katello::Model
-    # Note: Do not use active record call backs or dependent references on this class
+    # NOTE: Do not use active record call backs or dependent references on this class
     # Direct deletes are made in Pool#import_hosts (instead of destroys).
     belongs_to :subscription_facet, :inverse_of => :subscription_facet_pools, :class_name => 'Katello::Host::SubscriptionFacet'
     belongs_to :pool, :inverse_of => :subscription_facet_pools, :class_name => 'Katello::Pool'

data/app/models/katello/sync_plan.rb

@@ -148,13 +148,14 @@ module Katello
       if interval.nil?
         fail _("Interval cannot be nil")
       end
-      if (interval.downcase.eql? "hourly")
+      case interval.downcase
+      when "hourly"
         cron = min.to_s + " * * * *"
-      elsif (interval.downcase.eql? "daily")
+      when "daily"
         cron = min.to_s + " " + hour.to_s + " * * *"
-      elsif (interval.downcase.eql? "weekly")
+      when "weekly"
         cron = min.to_s + " " + hour.to_s + " * * " + day.to_s
-      elsif (interval.downcase.eql? CUSTOM_CRON)
+      when CUSTOM_CRON
         cron = cron_expression
       else
         fail _("Interval not set correctly")

data/app/models/katello/task_status.rb

@@ -154,18 +154,16 @@ module Katello
       when :package
         p = self.parameters[:packages]
         first_package = p.first.is_a?(Hash) ? p.first[:name] : p.first
-        unless p && p.length > 0
-          if self.task_type == "package_update"
-            case self.overall_status
-            when "running"
-              return "updating"
-            when "waiting"
-              return "updating"
-            when "error"
-              return _("all packages update failed")
-            else
-              return _("all packages update")
-            end
+        if !p && p.length > 0 && (self.task_type == "package_update")
+          case self.overall_status
+          when "running"
+            return "updating"
+          when "waiting"
+            return "updating"
+          when "error"
+            return _("all packages update failed")
+          else
+            return _("all packages update")
           end
         end
 
@@ -229,14 +227,15 @@ module Katello
       ret = []
       task_type = self.task_type.to_s
 
-      if task_type =~ /^package_group/
+      case task_type
+      when /^package_group/
         action = task_type.include?("remove") ? :removed : :installed
         ret = packages_change_description(result[:details][:package_group], action)
-      elsif task_type == "package_install" || task_type == "errata_install"
+      when "package_install", "errata_install"
         ret = packages_change_description(result[:details][:rpm], :installed)
-      elsif task_type == "package_update"
+      when "package_update"
         ret = packages_change_description(result[:details][:rpm], :updated)
-      elsif task_type == "package_remove"
+      when "package_remove"
         ret = packages_change_description(result[:details][:rpm], :removed)
       end
       ret
@@ -246,13 +245,14 @@ module Katello
       errors, stacktrace = self.result[:errors]
       return "" unless errors
       # Handle not very friendly Pulp message
-      if errors =~ /^\(.*\)$/
+      case errors
+      when /^\(.*\)$/
         if stacktrace.class == Array
           stacktrace.last.split(":").first
         else
           stacktrace.split("(").first
         end
-      elsif errors =~ /^\[.*,.*\]$/m
+      when /^\[.*,.*\]$/m
         result = errors.split(",").map do |error|
           error.gsub(/^\W+|\W+$/, "")
         end

data/app/presenters/katello/product_host_count_presenter.rb

@@ -0,0 +1,10 @@
+module Katello
+  class ProductHostCountPresenter < SimpleDelegator
+    attr_reader :product_host_count
+
+    def initialize(pool)
+      @product_host_count = pool.product_host_count
+      super(pool)
+    end
+  end
+end

data/app/services/katello/candlepin/consumer.rb

@@ -136,26 +136,26 @@ module Katello
       def self.distribution_to_puppet_os(name)
         return ::Operatingsystem::REDHAT_ATOMIC_HOST_OS if name == ::Operatingsystem::REDHAT_ATOMIC_HOST_DISTRO_NAME
 
-        name = name.downcase
-        if name =~ /red\s*hat/
+        case name.downcase
+        when /red\s*hat/
           'RedHat'
-        elsif name =~ /centos/
+        when /centos/
           'CentOS'
-        elsif name =~ /fedora/
+        when /fedora/
           'Fedora'
-        elsif name =~ /sles/ || name =~ /suse.*enterprise.*/
+        when /sles/, /suse.*enterprise.*/
           'SLES'
-        elsif name =~ /debian/
+        when /debian/
           'Debian'
-        elsif name =~ /ubuntu/
+        when /ubuntu/
           'Ubuntu'
-        elsif name =~ /oracle/
+        when /oracle/
           'OracleLinux'
-        elsif name =~ /almalinux/
+        when /almalinux/
           'AlmaLinux'
-        elsif name =~ /rocky/
+        when /rocky/
           'Rocky'
-        elsif name =~ /amazon/
+        when /amazon/
           'Amazon'
         else
           'Unknown'

data/app/services/katello/candlepin/message_handler.rb

@@ -43,9 +43,10 @@ module Katello
       end
 
       def pool_id
-        if subject == 'pool.created' || subject == 'pool.deleted'
+        case subject
+        when 'pool.created', 'pool.deleted'
           content['entityId']
-        elsif subject == 'entitlement.created' ||  subject == 'entitlement.deleted'
+        when 'entitlement.created', 'entitlement.deleted'
           content['referenceId']
         end
       end

data/app/services/katello/content_unit_indexer.rb

@@ -38,6 +38,12 @@ module Katello
             end
           end
 
+          # Even after this bug (https://github.com/pulp/pulp_rpm/issues/2821) is fixed,
+          # it is possible to have duplicate errata asosociated to a repo.
+          if @content_type.label == 'erratum'
+            to_insert.uniq! { |row| row["pulp_id"] || row[:pulp_id] }
+          end
+
           next if to_insert.empty?
           insert_timestamps(to_insert)
           if @content_type.mutable

data/app/services/katello/pulp3/alternate_content_source.rb

@@ -3,9 +3,7 @@ module Katello
   module Pulp3
     class AlternateContentSource
       include Katello::Pulp3::ServiceCommon
-      attr_accessor :acs
-      attr_accessor :smart_proxy
-      attr_accessor :repository
+      attr_accessor :acs, :smart_proxy, :repository
 
       def initialize(acs, smart_proxy, repository = nil)
         @acs = acs

data/app/services/katello/pulp3/api/core.rb

@@ -264,7 +264,7 @@ module Katello
             (response.count && (page_opts['offset'] < response.count)) ||
                 page_opts["offset"] == 0)
             response = yield page_opts
-            results = results.concat(response.results)
+            results.concat(response.results)
             page_opts[:offset] += page_size
           end
 

data/app/services/katello/pulp3/api/docker.rb

@@ -19,6 +19,16 @@ module Katello
         def container_push_api
           PulpContainerClient::RepositoriesContainerPushApi.new(api_client)
         end
+
+        def container_push_repo_for_name(name)
+          # There should be only one repository in Pulp with the requested name
+          container_push_api.list(name: name)&.results&.first
+        end
+
+        def container_push_distribution_for_repository(repository_href)
+          # There should be only one repository in Pulp with the requested repository_href
+          distributions_api.list(repository: repository_href)&.results&.first
+        end
       end
     end
   end

data/app/services/katello/pulp3/content_view_version/export.rb

@@ -8,6 +8,7 @@ module Katello
         FORMATS = [SYNCABLE, IMPORTABLE].freeze
 
         attr_reader :smart_proxy, :content_view_version, :destination_server, :from_content_view_version, :repository, :base_path
+
         def self.create(options)
           if options.delete(:format) == SYNCABLE
             SyncableFormatExport.new(**options)

data/app/services/katello/pulp3/content_view_version/import.rb

@@ -107,9 +107,10 @@ module Katello
         end
 
         def import_cv_name_from_export(name:, generated_for:)
-          if generated_for == :library_import
+          case generated_for
+          when :library_import
             ::Katello::ContentView::IMPORT_LIBRARY
-          elsif generated_for == :repository_import
+          when :repository_import
             name.gsub(/^Export/, 'Import')
           else
             name
@@ -138,9 +139,10 @@ module Katello
             }
           end
 
-          if generated_for == :library_export
+          case generated_for
+          when :library_export
             generated_for = :library_import
-          elsif generated_for == :repository_export
+          when :repository_export
             generated_for = :repository_import
           end
 

data/app/services/katello/pulp3/content_view_version/importable_products.rb

@@ -54,12 +54,10 @@ module Katello
         end
 
         def update_params(metadata_product)
-          params = {
+          {
             gpg_key_id: gpg_key_id(metadata_product),
             description: metadata_product.description
           }
-
-          params
         end
 
         def gpg_key_id(metadata_product)

data/app/services/katello/pulp3/repository/apt.rb

@@ -51,16 +51,6 @@ module Katello
           popts
         end
 
-        def mirror_publication_options
-          {
-            # Since we are synchronizing the "default" distribution from the simple publisher on the server,
-            # it will be included in the structured publish. Therefore, we MUST NOT use the simple publisher
-            # on the proxy, since this would collide!
-            #simple: true,
-            structured: true # publish real suites (e.g. 'stable')
-          }
-        end
-
         def distribution_options(path)
           {
             base_path: path,
@@ -87,12 +77,10 @@ module Katello
               # Not needed during incremental update due to dest_base_version
               # -> Unless incrementally updating a CV repo that is a soft copy of its library instance.
               # -> I.e. no filters and not an incremental version.
-              unless dest_repo_id_map[:base_version]
-                # Don't perform extra content actions if the repo is a soft copy of its library instance.
-                # Taken care of by the IncrementalUpdate action.
-                unless dest_repo.soft_copy_of_library?
-                  tasks << remove_all_content_from_repo(dest_repo_href)
-                end
+              # Don't perform extra content actions if the repo is a soft copy of its library instance.
+              # Taken care of by the IncrementalUpdate action.
+              if !dest_repo_id_map[:base_version] && !dest_repo.soft_copy_of_library?
+                tasks << remove_all_content_from_repo(dest_repo_href)
               end
               source_repo_ids.each do |source_repo_id|
                 source_repo_version = ::Katello::Repository.find(source_repo_id).version_href

data/app/services/katello/pulp3/repository/yum.rb

@@ -22,7 +22,13 @@ module Katello
 
         def publication_options(repository_version)
           options = super(repository_version)
-          options.merge(checksum_type: root.checksum_type)
+          # To work around https://projects.theforeman.org/issues/37715
+          checksum_type = if root.checksum_type.nil?
+                            'sha256'
+                          else
+                            root.checksum_type
+                          end
+          options.merge(checksum_type: checksum_type)
         end
 
         def specific_create_options
@@ -57,10 +63,8 @@ module Katello
               :distribution_family => distribution.results.first.release_name,
               :distribution_bootable => self.class.distribution_bootable?(distribution)
             )
-            unless distribution.results.first.variants.empty?
-              unless distribution.results.first.variants.first.name.nil?
-                repo.update!(:distribution_variant => distribution.results.first.variants.map(&:name).join(','))
-              end
+            if !distribution.results.first.variants.empty? && !distribution.results.first.variants.first.name.nil?
+              repo.update!(:distribution_variant => distribution.results.first.variants.map(&:name).join(','))
             end
           end
         end

data/app/services/katello/pulp3/repository.rb

@@ -5,8 +5,8 @@ module Katello
     class Repository
       include Katello::Util::HttpProxy
       include Katello::Pulp3::ServiceCommon
-      attr_accessor :repo
-      attr_accessor :smart_proxy
+      attr_accessor :repo, :smart_proxy
+
       delegate :root, to: :repo
       delegate :pulp3_api, to: :smart_proxy
 

data/app/services/katello/pulp3/repository_mirror.rb

@@ -2,6 +2,7 @@ module Katello
   module Pulp3
     class RepositoryMirror
       attr_accessor :repo_service
+
       delegate :repo, to: :repo_service
       delegate :smart_proxy, to: :repo_service
 
@@ -166,21 +167,13 @@ module Katello
         uri.to_s
       end
 
-      def publication_options(repository_version)
-        popts = {repository_version: repository_version}
-        if (type_specific_options = repo_service.try(:mirror_publication_options))
-          popts.merge!(type_specific_options)
-        end
-        popts
-      end
-
       def create_publication
         if (href = version_href)
           if repo_service.repo.content_type == "deb"
             publication_data = api.publication_verbatim_class.new({repository_version: href})
             api.publications_verbatim_api.create(publication_data)
           else
-            publication_data = api.publication_class.new(publication_options(href))
+            publication_data = api.publication_class.new(repository_version: href)
             api.publications_api.create(publication_data)
           end
         end

data/app/services/katello/pulp3/task.rb

@@ -39,6 +39,7 @@ module Katello
       #needed for serialization in dynflow
 
       attr_reader :pulp_data
+
       delegate :[], :key?, :dig, :to_hash, :to => :task_data
 
       def initialize(smart_proxy, data)
@@ -105,9 +106,10 @@ module Katello
       end
 
       def error
-        if task_data[:state] == CANCELED
+        case task_data[:state]
+        when CANCELED
           _("Task canceled")
-        elsif task_data[:state] == FAILED
+        when FAILED
           if task_data[:error][:description].blank?
             _("Pulp task error")
           else

data/app/services/katello/registration_manager.rb

@@ -125,9 +125,11 @@ module Katello
       #  * organization_destroy: destroy some data associated with host, but
       #    leave items alone that will be removed later as part of org destroy
       #  * unregistering: unregister the host but don't destroy it
+      #  * keep_kickstart_repository: ensure the KS repo ID is not set to nil
       def unregister_host(host, options = {})
         organization_destroy = options.fetch(:organization_destroy, false)
         unregistering = options.fetch(:unregistering, false)
+        keep_kickstart_repository = options.fetch(:keep_kickstart_repository, false)
 
         # if the first operation fails, just raise the error since there's nothing to clean up yet.
         candlepin_consumer_destroy(host.subscription_facet.uuid) if !organization_destroy && host.subscription_facet.try(:uuid)
@@ -138,7 +140,11 @@ module Katello
         host.subscription_facet.try(:destroy!)
 
         if unregistering
-          remove_host_artifacts(host)
+          if keep_kickstart_repository
+            remove_host_artifacts(host, kickstart_repository_id: host&.content_facet&.kickstart_repository_id)
+          else
+            remove_host_artifacts(host)
+          end
         elsif organization_destroy
           host.content_facet.try(:destroy!)
           remove_host_artifacts(host, clear_content_facet: false)
@@ -152,7 +158,9 @@ module Katello
         new_host = host.new_record?
         unless new_host
           host.save!
-          unregister_host(host, :unregistering => true)
+          # Keep the kickstart repository ID so the host's Medium isn't unset
+          # Important for registering a host during provisioning
+          unregister_host(host, :unregistering => true, :keep_kickstart_repository => true)
           host.reload
         end
 
@@ -294,13 +302,15 @@ module Katello
         subscription_facet
       end
 
-      def remove_host_artifacts(host, clear_content_facet: true)
+      def remove_host_artifacts(host, clear_content_facet: true, kickstart_repository_id: nil)
+        Rails.logger.debug "Host ID: #{host.id}, clear_content_facet: #{clear_content_facet}, kickstart_repository_id: #{kickstart_repository_id}"
         if host.content_facet && clear_content_facet
           host.content_facet.bound_repositories = []
           host.content_facet.applicable_errata = []
           host.content_facet.uuid = nil
           host.content_facet.content_view_environments = []
           host.content_facet.content_source = ::SmartProxy.pulp_primary
+          host.content_facet.kickstart_repository_id = kickstart_repository_id
           host.content_facet.save!
           Rails.logger.debug "remove_host_artifacts: marking CVEs unchanged to prevent backend update"
           host.content_facet.mark_cves_unchanged

data/app/services/katello/smart_proxy_helper.rb

@@ -1,6 +1,7 @@
 module Katello
   class SmartProxyHelper
     attr_accessor :smart_proxy
+
     def initialize(smart_proxy)
       @smart_proxy = smart_proxy
     end

data/app/views/dashboard/_host_collection_widget.html.erb

@@ -18,13 +18,14 @@
       </tr>
     </thead>
     <tbody>
+      <% installable_only = Setting['errata_status_installable'] %>
       <% host_collections.each do |host_collection| %>
         <tr>
           <td>
-            <% if host_collection.security_updates? %>
-              <a href="/host_collections/<%= host_collection.id %>" style="text-align: center"><i class="label label-danger">&nbsp;</i></a>
-            <% elsif host_collection.bugzilla_updates? || host_collection.enhancement_updates? %>
-              <a href="/host_collections/<%= host_collection.id %>" style="text-align: center"><i class="label label-warning">&nbsp;</i></a>
+            <% if host_collection.security_updates?(installable_only: installable_only) %>
+              <a href="/host_collections/<%= host_collection.id %>" style="text-align: center" title="<%= installable_only ? _('Installable security errata') : _('Applicable security errata') %>"><i class="label label-danger">&nbsp;</i></a>
+            <% elsif host_collection.bugzilla_updates?(installable_only: installable_only) || host_collection.enhancement_updates?(installable_only: installable_only) %>
+              <a href="/host_collections/<%= host_collection.id %>" style="text-align: center" title="<%= installable_only ? _('Installable bugfix/enhancement errata') : _('Applicable bugfix/enhancement errata') %>"><i class="label label-warning">&nbsp;</i></a>
             <% else %>
               <a href="/host_collections/<%= host_collection.id %>" style="text-align: center"><i class="label label-success">&nbsp;</i></a>
             <% end %>

data/app/views/foreman/job_templates/install_errata.erb

@@ -14,6 +14,7 @@ foreign_input_sets:
 - template: Package Action - Script Default
   exclude: action,package
 %>
+<%= snippet_if_exists(template_name + " custom pre") %>
 <% if @host.operatingsystem.family == 'Suse' -%>
     <% advisories = input(:errata).split(',').join(' ') -%>
     <%= render_template('Package Action - Script Default', :action => 'install -n -t patch', :package => advisories) %>
@@ -21,3 +22,4 @@ foreign_input_sets:
     <% advisories = input(:errata).split(',').map { |e| "--advisory=#{e}" }.join(' ') -%>
     <%= render_template('Package Action - Script Default', :action => 'update-minimal', :package => advisories) %>
 <% end -%>
+<%= snippet_if_exists(template_name + " custom post") %>

data/app/views/foreman/job_templates/install_errata_-_katello_ansible_default.erb

@@ -14,6 +14,7 @@ provider_type: Ansible
 kind: job_template
 %>
 
+<%= snippet_if_exists(template_name + " custom pre") %>
 <% if @host.operatingsystem.family == 'Suse' -%>
 <% advisories = input(:errata).split(',').join(' ') -%>
 <%= render_template('Run Command - Ansible Default', :command => "zypper -n install -t patch #{advisories}") %>
@@ -21,3 +22,4 @@ kind: job_template
 <% advisories = input(:errata).split(',').map { |e| "--advisory=#{e}" }.join(' ') -%>
 <%= render_template('Run Command - Ansible Default', :command => "yum -y update-minimal #{advisories}") %>
 <% end -%>
+<%= snippet_if_exists(template_name + " custom post") %>