katello 4.13.1 → 4.14.0.rc1

data/webpack/components/extensions/HostDetails/Tabs/RemoteExecutionActions.js

@@ -9,16 +9,20 @@ import { PACKAGE_SEARCH_QUERY } from './PackagesTab/YumInstallablePackagesConsta
 import { PACKAGES_SEARCH_QUERY, SELECTED_UPDATE_VERSIONS } from './PackagesTab/HostPackagesConstants';
 
 // PARAM BUILDING
-const baseParams = ({
-  feature, hostname, descriptionFormat, inputs = {},
-}) => ({
-  job_invocation: {
-    feature,
-    inputs,
-    description_format: descriptionFormat,
-    search_query: `name ^ (${hostname})`,
-  },
-});
+const baseParams = (options) => {
+  const {
+    feature, hostname, hostSearch, descriptionFormat, inputs = {},
+  } = options;
+  const search = hostSearch ?? `name ^ (${hostname})`;
+  return ({
+    job_invocation: {
+      feature,
+      inputs,
+      description_format: descriptionFormat,
+      search_query: search,
+    },
+  });
+};
 
 const runCommandParams = ({ hostname, command }) =>
   baseParams({
@@ -27,6 +31,13 @@ const runCommandParams = ({ hostname, command }) =>
     feature: REX_FEATURES.RUN_COMMAND,
   });
 
+const uploadProfileParams = ({ hostname }) =>
+  baseParams({
+    hostname,
+    inputs: {},
+    feature: REX_FEATURES.KATELLO_UPLOAD_PROFILE,
+  });
+
 // used when we know the package name
 const katelloPackageInstallParams = ({ hostname, packageName }) =>
   baseParams({
@@ -36,9 +47,12 @@ const katelloPackageInstallParams = ({ hostname, packageName }) =>
   });
 
 // used when we know package Id(s)
-const katelloPackageInstallBySearchParams = ({ hostname, search, descriptionFormat }) =>
+const katelloPackageInstallBySearchParams = ({
+  hostname, hostSearch, search, descriptionFormat,
+}) =>
   baseParams({
     hostname,
+    hostSearch,
     inputs: { [PACKAGE_SEARCH_QUERY]: search },
     feature: REX_FEATURES.KATELLO_PACKAGE_INSTALL_BY_SEARCH,
     descriptionFormat,
@@ -51,9 +65,12 @@ const katelloPackageRemoveParams = ({ hostname, packageName }) =>
     feature: REX_FEATURES.KATELLO_PACKAGE_REMOVE,
   });
 
-const katelloPackagesRemoveParams = ({ hostname, search, descriptionFormat }) =>
+const katelloPackageRemoveBySearchParams = ({
+  hostname, hostSearch, search, descriptionFormat,
+}) =>
   baseParams({
     hostname,
+    hostSearch,
     inputs: { [PACKAGES_SEARCH_QUERY]: search },
     feature: REX_FEATURES.KATELLO_PACKAGES_REMOVE_BY_SEARCH,
     descriptionFormat,
@@ -67,16 +84,21 @@ const katelloPackageUpdateParams = ({ hostname, packageName, descriptionFormat }
     descriptionFormat,
   });
 
-const katelloPackagesUpdateParams = ({
-  hostname, search, versions, descriptionFormat,
-}) => ({ // this doesn't use baseParams so looks different from the others
-  job_invocation: {
-    feature: REX_FEATURES.KATELLO_PACKAGES_UPDATE_BY_SEARCH,
-    inputs: { [PACKAGES_SEARCH_QUERY]: search, [SELECTED_UPDATE_VERSIONS]: versions },
-    search_query: `name ^ (${hostname})`,
-    description_format: descriptionFormat,
-  },
-});
+const katelloPackagesUpdateParams = (options) => {
+  // this doesn't use baseParams so looks different from the others
+  const {
+    hostname, search, hostSearch, versions, descriptionFormat,
+  } = options;
+  const searchQuery = hostSearch ?? `name ^ (${hostname})`;
+  return ({
+    job_invocation: {
+      feature: REX_FEATURES.KATELLO_PACKAGES_UPDATE_BY_SEARCH,
+      inputs: { [PACKAGES_SEARCH_QUERY]: search, [SELECTED_UPDATE_VERSIONS]: versions ?? [] },
+      search_query: searchQuery,
+      description_format: descriptionFormat,
+    },
+  });
+};
 
 const katelloTracerResolveParams = ({ hostname, search }) =>
   baseParams({
@@ -86,11 +108,13 @@ const katelloTracerResolveParams = ({ hostname, search }) =>
   });
 
 const katelloHostErrataInstallParams = ({
-  hostname, search,
+  hostname, hostSearch, search, descriptionFormat,
 }) => baseParams({
   hostname,
+  hostSearch,
   inputs: { [ERRATA_SEARCH_QUERY]: search },
   feature: REX_FEATURES.KATELLO_HOST_ERRATA_INSTALL_BY_SEARCH,
+  descriptionFormat,
 });
 
 const katelloModuleStreamActionsParams = ({ hostname, action, moduleSpec }) =>
@@ -131,6 +155,18 @@ export const runCommand = ({ hostname, command, handleSuccess }) => post({
   errorToast,
 });
 
+export const uploadProfile = ({ hostname, handleSuccess }) => post({
+  type: API_OPERATIONS.POST,
+  key: REX_JOB_INVOCATIONS_KEY,
+  url: foremanApi.getApiUrl('/job_invocations'),
+  params: uploadProfileParams({ hostname }),
+  handleSuccess: (response) => {
+    showRexToast(response);
+    if (handleSuccess) handleSuccess(response);
+  },
+  errorToast,
+});
+
 export const installPackage = ({ hostname, packageName, handleSuccess }) => post({
   type: API_OPERATIONS.POST,
   key: REX_JOB_INVOCATIONS_KEY,
@@ -143,11 +179,15 @@ export const installPackage = ({ hostname, packageName, handleSuccess }) => post
   errorToast,
 });
 
-export const installPackageBySearch = ({ hostname, search, descriptionFormat }) => post({
+export const installPackageBySearch = ({
+  hostname, hostSearch, search, descriptionFormat,
+}) => post({
   type: API_OPERATIONS.POST,
   key: REX_JOB_INVOCATIONS_KEY,
   url: foremanApi.getApiUrl('/job_invocations'),
-  params: katelloPackageInstallBySearchParams({ hostname, search, descriptionFormat }),
+  params: katelloPackageInstallBySearchParams({
+    hostname, hostSearch, search, descriptionFormat,
+  }),
   handleSuccess: showRexToast,
   errorToast,
 });
@@ -161,11 +201,15 @@ export const removePackage = ({ hostname, packageName }) => post({
   errorToast,
 });
 
-export const removePackages = ({ hostname, search, descriptionFormat }) => post({
+export const removePackagesBySearch = ({
+  hostname, hostSearch, search, descriptionFormat,
+}) => post({
   type: API_OPERATIONS.POST,
   key: REX_JOB_INVOCATIONS_KEY,
   url: foremanApi.getApiUrl('/job_invocations'),
-  params: katelloPackagesRemoveParams({ hostname, search, descriptionFormat }),
+  params: katelloPackageRemoveBySearchParams({
+    hostname, hostSearch, search, descriptionFormat,
+  }),
   handleSuccess: showRexToast,
   errorToast,
 });
@@ -180,13 +224,13 @@ export const updatePackage = ({ hostname, packageName }) => post({
 });
 
 export const updatePackages = ({
-  hostname, search, versions, descriptionFormat,
+  hostname, hostSearch, search, versions, descriptionFormat,
 }) => post({
   type: API_OPERATIONS.POST,
   key: REX_JOB_INVOCATIONS_KEY,
   url: foremanApi.getApiUrl('/job_invocations'),
   params: katelloPackagesUpdateParams({
-    hostname, search, versions, descriptionFormat,
+    hostname, search, hostSearch, versions, descriptionFormat,
   }),
   handleSuccess: showRexToast,
   errorToast,
@@ -202,13 +246,13 @@ export const resolveTraces = ({ hostname, search }) => post({
 });
 
 export const installErrata = ({
-  hostname, search,
+  hostname, hostSearch, search, descriptionFormat,
 }) => post({
   type: API_OPERATIONS.POST,
   key: REX_JOB_INVOCATIONS_KEY,
   url: foremanApi.getApiUrl('/job_invocations'),
   params: katelloHostErrataInstallParams({
-    hostname, search,
+    hostname, search, hostSearch, descriptionFormat,
   }),
   handleSuccess: showRexToast,
   errorToast,

data/webpack/components/extensions/HostDetails/Tabs/RemoteExecutionConstants.js

@@ -10,4 +10,5 @@ export const REX_FEATURES = {
   KATELLO_HOST_ERRATA_INSTALL_BY_SEARCH: 'katello_errata_install_by_search',
   KATELLO_HOST_MODULE_STREAM_ACTION: 'katello_module_stream_action',
   RUN_COMMAND: 'run_script',
+  KATELLO_UPLOAD_PROFILE: 'katello_upload_profile',
 };

data/webpack/components/extensions/HostDetails/Tabs/RemoteExecutionHooks.js

@@ -27,7 +27,7 @@ export const useRexJobPolling = (initialAction, successAction = null, failureAct
   }, [dispatch]);
 
   const tick = (resp) => {
-    const { data } = resp;
+    const data = resp?.data?.data || resp?.data;
     const { statusLabel, id, description } = propsToCamelCase(data);
     if (!id) setRexJobId(id);
     if (statusLabel && statusLabel !== 'running') {

data/webpack/components/extensions/HostDetails/Tabs/customizedRexUrlHelpers.js

@@ -4,13 +4,16 @@ import { ERRATA_SEARCH_QUERY } from './ErrataTab/HostErrataConstants';
 import { PACKAGE_SEARCH_QUERY } from './PackagesTab/YumInstallablePackagesConstants';
 import { PACKAGES_SEARCH_QUERY, SELECTED_UPDATE_VERSIONS } from './PackagesTab/HostPackagesConstants';
 
-export const createJob = ({
-  hostname, feature, inputs,
-}) => {
+export const createJob = (options) => {
+  const {
+    hostname, hostSearch, feature, inputs,
+  } = options;
+  if (inputs[SELECTED_UPDATE_VERSIONS] === undefined) delete inputs[SELECTED_UPDATE_VERSIONS];
   const inputParams = Object.keys(inputs).map(key => `inputs[${key}]=${inputs[key]}`);
+  const search = hostSearch ?? `name ^ (${hostname})`;
   const params = [
     `feature=${feature}`,
-    `search=name ^ (${hostname})`,
+    `search=${search}`,
     ...inputParams,
   ];
   const urlQuery = encodeURI(params.join('&'));
@@ -23,20 +26,31 @@ export const katelloPackageInstallUrl = ({ hostname, packages }) => createJob({
   inputs: { package: packages },
 });
 
-export const katelloPackageInstallBySearchUrl = ({ hostname, search }) => createJob({
+export const katelloPackageInstallBySearchUrl = ({ hostname, hostSearch, search }) => createJob({
   hostname,
+  hostSearch,
   feature: REX_FEATURES.KATELLO_PACKAGE_INSTALL_BY_SEARCH,
   inputs: { [PACKAGE_SEARCH_QUERY]: search },
 });
 
+export const katelloPackageRemoveBySearchUrl = ({ hostname, hostSearch, search }) => createJob({
+  hostname,
+  hostSearch,
+  feature: REX_FEATURES.KATELLO_PACKAGES_REMOVE_BY_SEARCH,
+  inputs: { [PACKAGES_SEARCH_QUERY]: search },
+});
+
 export const katelloPackageUpdateUrl = ({ hostname, packageName }) => createJob({
   hostname,
   feature: REX_FEATURES.KATELLO_PACKAGE_UPDATE,
   inputs: { package: packageName },
 });
 
-export const packagesUpdateUrl = ({ hostname, search, versions }) => createJob({
+export const packagesUpdateUrl = ({
+  hostname, hostSearch, search, versions,
+}) => createJob({
   hostname,
+  hostSearch,
   feature: REX_FEATURES.KATELLO_PACKAGES_UPDATE_BY_SEARCH,
   inputs: { [PACKAGES_SEARCH_QUERY]: search, [SELECTED_UPDATE_VERSIONS]: versions },
 });
@@ -47,8 +61,9 @@ export const resolveTraceUrl = ({ hostname, search }) => createJob({
   inputs: { [TRACES_SEARCH_QUERY]: search },
 });
 
-export const errataInstallUrl = ({ hostname, search }) => createJob({
+export const errataInstallUrl = ({ hostname, search, hostSearch }) => createJob({
   hostname,
+  hostSearch,
   feature: REX_FEATURES.KATELLO_HOST_ERRATA_INSTALL_BY_SEARCH,
   inputs: { [ERRATA_SEARCH_QUERY]: search },
 });

data/webpack/components/extensions/Hosts/ActionsBar/ActionsBar.scss

@@ -0,0 +1,14 @@
+.disabled-menu-item-span {
+  width: 25em;
+  display: flex;
+  flex-direction: row;
+}
+
+.disabled-menu-item-p {
+  margin-left: 0.6em;
+  word-break: normal;
+}
+
+.disabled-menu-item-icon {
+  font-size: small;
+}

data/webpack/components/extensions/Hosts/ActionsBar/index.js

@@ -1,26 +1,54 @@
 import React, { useContext, useEffect } from 'react';
+import PropTypes from 'prop-types';
 import { useDispatch } from 'react-redux';
-import { DropdownItem } from '@patternfly/react-core';
+import { Menu, MenuItem, MenuContent, MenuList } from '@patternfly/react-core';
+import { BanIcon } from '@patternfly/react-icons';
 import { translate as __ } from 'foremanReact/common/I18n';
 import { foremanUrl } from 'foremanReact/common/helpers';
 import { ForemanHostsIndexActionsBarContext } from 'foremanReact/components/HostsIndex';
 import { useForemanModal } from 'foremanReact/components/ForemanModal/ForemanModalHooks';
 import { addModal } from 'foremanReact/components/ForemanModal/ForemanModalActions';
+import { useForemanOrganization } from 'foremanReact/Root/Context/ForemanContext';
+import './ActionsBar.scss';
+
+const DisabledMenuItemDescription = ({ disabledReason }) => (
+  <span className="disabled-menu-item-span">
+    <span className="disabled-menu-item-icon">
+      <BanIcon />
+    </span>
+    <p className="disabled-menu-item-p">
+      {disabledReason}
+    </p>
+  </span>
+);
+
+DisabledMenuItemDescription.propTypes = {
+  disabledReason: PropTypes.string.isRequired,
+};
 
 const HostActionsBar = () => {
   const {
     fetchBulkParams,
     selectedCount,
     selectAllMode,
+    setMenuOpen,
   } = useContext(ForemanHostsIndexActionsBarContext);
 
   const dispatch = useDispatch();
   useEffect(() => {
-    dispatch(addModal({
-      id: 'bulk-change-cv-modal',
-    }));
+    [
+      'bulk-change-cv-modal',
+      'bulk-packages-wizard',
+      'bulk-errata-wizard',
+    ].forEach((id) => {
+      dispatch(addModal({ id }));
+    });
   }, [dispatch]);
-  const { setModalOpen } = useForemanModal({ id: 'bulk-change-cv-modal' });
+  const { setModalOpen: openBulkChangeCVModal } = useForemanModal({ id: 'bulk-change-cv-modal' });
+  const { setModalOpen: openBulkPackagesWizardModal } = useForemanModal({ id: 'bulk-packages-wizard' });
+  const { setModalOpen: openBulkErrataWizardModal } = useForemanModal({ id: 'bulk-errata-wizard' });
+
+  const orgId = useForemanOrganization()?.id;
 
   let href = '';
   if (selectAllMode) {
@@ -31,24 +59,55 @@ const HostActionsBar = () => {
   }
 
   return (
-    <>
-      <DropdownItem
-        ouiaId="change-content-s-dropdown-item"
-        key="change-content-source-dropdown-item"
-        href={href}
-        isDisabled={selectedCount === 0}
-      >
-        {__('Change content source')}
-      </DropdownItem>
-      <DropdownItem
-        ouiaId="bulk-change-cv-dropdown-item"
-        key="bulk-change-cv-dropdown-item"
-        onClick={setModalOpen}
-        isDisabled={selectedCount === 0}
-      >
-        {__('Change content view environments')}
-      </DropdownItem>
-    </>
+    <MenuItem
+      itemId="content-flyout-item"
+      key="content-flyout"
+      isDisabled={selectedCount === 0}
+      flyoutMenu={(
+        <Menu ouiaId="content-flyout-menu" onSelect={() => setMenuOpen(false)}>
+          <MenuContent>
+            <MenuList>
+              <MenuItem
+                itemId="bulk-packages-wizard-dropdown-item"
+                key="bulk-packages-wizard-dropdown-item"
+                onClick={openBulkPackagesWizardModal}
+                isDisabled={selectedCount === 0 || !orgId}
+                description={!orgId && <DisabledMenuItemDescription disabledReason={__('To manage host packages, a specific organization must be selected from the organization context.')} />}
+              >
+                {__('Packages')}
+              </MenuItem>
+              <MenuItem
+                itemId="bulk-errata-wizard-dropdown-item"
+                key="bulk-errata-wizard-dropdown-item"
+                onClick={openBulkErrataWizardModal}
+                isDisabled={selectedCount === 0}
+              >
+                {__('Errata')}
+              </MenuItem>
+              <MenuItem
+                itemId="change-content-s-dropdown-item"
+                key="change-content-source-dropdown-item"
+                to={href}
+                isDisabled={selectedCount === 0}
+              >
+                {__('Content source')}
+              </MenuItem>
+              <MenuItem
+                itemId="bulk-change-cv-dropdown-item"
+                key="bulk-change-cv-dropdown-item"
+                onClick={openBulkChangeCVModal}
+                isDisabled={selectedCount === 0 || !orgId}
+                description={!orgId && <DisabledMenuItemDescription disabledReason={__('To change content view environments, a specific organization must be selected from the organization context.')} />}
+              >
+                {__('Content view environments')}
+              </MenuItem>
+            </MenuList>
+          </MenuContent>
+        </Menu>
+        )}
+    >
+      {__('Manage content')}
+    </MenuItem>
   );
 };
 

data/webpack/components/extensions/Hosts/BulkActions/BulkChangeHostCVModal/index.js

@@ -5,10 +5,13 @@ import { useForemanModal } from 'foremanReact/components/ForemanModal/ForemanMod
 import BulkChangeHostCVModal from './BulkChangeHostCVModal';
 
 const BulkChangeHostCVModalScene = () => {
-  const org = useForemanOrganization();
+  const orgId = useForemanOrganization()?.id;
   const { selectedCount, fetchBulkParams } = useContext(ForemanActionsBarContext);
   const { modalOpen, setModalClosed } = useForemanModal({ id: 'bulk-change-cv-modal' });
 
+  if (!orgId) return null;
+
+
   return (
     <BulkChangeHostCVModal
       key="bulk-change-cv-modal"
@@ -16,7 +19,7 @@ const BulkChangeHostCVModalScene = () => {
       fetchBulkParams={fetchBulkParams}
       isOpen={modalOpen}
       closeModal={setModalClosed}
-      orgId={org?.id}
+      orgId={orgId}
     />
 
   );

data/webpack/components/extensions/Hosts/BulkActions/BulkErrataWizard/02_BulkErrataTable.js

@@ -0,0 +1,171 @@
+import React, { useEffect, useContext } from 'react';
+import {
+  Alert,
+  ToolbarItem,
+  Text,
+  TextContent,
+  TextVariants,
+} from '@patternfly/react-core';
+import { TableText } from '@patternfly/react-table';
+import TableIndexPage from 'foremanReact/components/PF4/TableIndexPage/TableIndexPage';
+import { translate as __ } from 'foremanReact/common/I18n';
+import SelectAllCheckbox from 'foremanReact/components/PF4/TableIndexPage/Table/SelectAllCheckbox';
+import { STATUS, getControllerSearchProps } from 'foremanReact/constants';
+import { RowSelectTd } from 'foremanReact/components/HostsIndex/RowSelectTd';
+import { getPageStats } from 'foremanReact/components/PF4/TableIndexPage/Table/helpers';
+import { BulkErrataWizardContext, ERRATA_URL } from './BulkErrataWizard';
+import { ErrataType, ErrataSeverity } from '../../../../../components/Errata';
+import katelloApi from '../../../../../services/api';
+
+const BulkErrataTable = () => {
+  const {
+    setShouldValidateStep2,
+    errataBulkSelect,
+    errataResults: results,
+    errataMetadata: {
+      total, per_page: perPage, page, subtotal,
+    },
+    errataResponse: response,
+  } = useContext(BulkErrataWizardContext);
+  const apiOptions = { key: 'BULK_HOST_ERRATA' };
+  const {
+    status: errataStatus,
+  } = response;
+
+
+  const origSearchProps = getControllerSearchProps('errata', 'searchBar-errata');
+  const customSearchProps = {
+    ...origSearchProps,
+    autocomplete: {
+      ...origSearchProps.autocomplete,
+      url: katelloApi.getApiUrl('/errata/auto_complete_search'),
+    },
+  };
+
+  const {
+    selectAll,
+    selectPage,
+    selectNone,
+    selectOne,
+    isSelected,
+    selectedCount,
+    areAllRowsSelected,
+    areAllRowsOnPageSelected,
+    updateSearchQuery,
+    hasInteracted,
+  } = errataBulkSelect;
+
+  useEffect(() => {
+    if (results?.length && hasInteracted) {
+      setShouldValidateStep2(true);
+    }
+  }, [setShouldValidateStep2, results, hasInteracted]);
+
+  const pageStats = getPageStats({ total: subtotal, page, perPage });
+  const selectionToolbar = (
+    <ToolbarItem key="selectAll">
+      <SelectAllCheckbox
+        {...{
+          selectNone,
+          selectPage,
+          selectedCount,
+          pageRowCount: pageStats.pageRowCount,
+          areAllRowsSelected,
+          areAllRowsOnPageSelected,
+        }}
+        selectAll={selectAll}
+        totalCount={total}
+        areAllRowsOnPageSelected={areAllRowsOnPageSelected()}
+        areAllRowsSelected={areAllRowsSelected()}
+      />
+    </ToolbarItem>
+  );
+
+  const columns = {
+    id: {
+      title: __('Erratum'),
+      wrapper: ({ id, errata_id: errataId }) => (
+        <a target="_blank" href={`/errata/${id}`} rel="noreferrer">{errataId}</a>
+      ),
+      isSorted: true,
+      weight: 10,
+    },
+    title: {
+      title: __('Title'),
+      wrapper: ({ title }) => <TableText wrapModifier="truncate">{title}</TableText>,
+      isSorted: true,
+      weight: 20,
+    },
+    type: {
+      title: __('Type'),
+      wrapper: erratum => <ErrataType {...erratum} />,
+      weight: 30,
+      isSorted: true,
+    },
+    severity: {
+      title: __('Severity'),
+      wrapper: erratum => <ErrataSeverity {...erratum} />,
+      weight: 40,
+      isSorted: true,
+    },
+    affectedHosts: {
+      title: __('Affected hosts'),
+      wrapper: ({ affected_hosts_count: affectedHostsCount }) => affectedHostsCount,
+      weight: 50,
+    },
+  };
+
+  return (
+    <>
+      <TextContent>
+        <Text ouiaId="mew-step-3-header" component={TextVariants.h3}>
+          {__('Apply errata')}
+        </Text>
+        <Text ouiaId="mew-step-3-content" component={TextVariants.p}>
+          {__('Select errata to apply on the selected hosts. Some errata may already be applied on some hosts.')}
+        </Text>
+      </TextContent>
+      {selectedCount === 0 && hasInteracted && (
+        <Alert
+          ouiaId="no-errata-alert"
+          variant="info"
+          isInline
+          title={__('Select at least one erratum.')}
+          style={{ marginBottom: '1rem' }}
+        />
+      )}
+      { errataStatus === STATUS.RESOLVED && !results?.length && (
+        <Alert
+          ouiaId="no-errata-found-alert"
+          variant="info"
+          isInline
+          title={__('No errata found.')}
+          style={{ marginBottom: '1rem' }}
+        />
+      )}
+      <TableIndexPage
+        columns={columns}
+        showCheckboxes
+        apiUrl={ERRATA_URL}
+        apiOptions={apiOptions}
+        headerText={__('Errata')}
+        header={null}
+        controller="errata"
+        customSearchProps={customSearchProps}
+        creatable={false}
+        replacementResponse={response}
+        selectionToolbar={selectionToolbar}
+        updateSearchQuery={updateSearchQuery}
+        rowSelectTd={RowSelectTd}
+        selectOne={selectOne}
+        isSelected={isSelected}
+        idColumn="errata_id"
+        updateParamsByUrl={false}
+        bookmarksPosition="right"
+      />
+    </>
+  );
+};
+
+
+export default BulkErrataTable;