katello 4.10.0 → 4.11.0.rc1

data/app/controllers/katello/api/registry/registry_proxies_controller.rb

@@ -134,7 +134,7 @@ module Katello
 
     def token
       if !require_user_authorization?
-        personal_token = OpenStruct.new(token: 'unauthenticated', issued_at: Time.now, expires_at: Time.now + 3)
+        personal_token = OpenStruct.new(token: 'unauthenticated', issued_at: Time.now, expires_at: 3.minutes.from_now)
       else
         personal_token = PersonalAccessToken.where(user_id: User.current.id, name: 'registry').first
         if personal_token.nil?
@@ -147,8 +147,21 @@ module Katello
         end
       end
 
+      create_time = (personal_token.created_at || personal_token.issued_at).to_time
+      expiry_time = personal_token.expires_at.to_time
+      expiration_seconds = (expiry_time - create_time).to_int # result already in seconds
+
       response.headers['Docker-Distribution-API-Version'] = 'registry/2.0'
-      render json: { token: personal_token.token, expires_at: personal_token.expires_at, issued_at: personal_token.created_at }
+      render json: {
+        token: personal_token.token,
+        expires_in: expiration_seconds,
+        issued_at: create_time.rfc3339,
+
+        # We're keeping the 'expires_at' field for now to maintain compatibility with existing
+        # smart-proxies during 4.11 upgrades. This is not a part of OAuth2 spec.
+        # TODO - Remove 'expires_at' in Katello 4.13 or later.
+        expires_at: expiry_time.rfc3339
+      }
     end
 
     def pull_manifest

data/app/controllers/katello/api/v2/capsule_content_controller.rb

@@ -20,6 +20,19 @@ module Katello
       param :environment_id, Integer, :desc => N_('Id of the lifecycle environment'), :required => true
     end
 
+    api :GET, '/capsules/:id/content/counts', N_('List content counts for the smart proxy')
+    param :id, Integer, :desc => N_('Id of the smart proxy'), :required => true
+    def counts
+      render json: @capsule.content_counts.to_json
+    end
+
+    api :POST, '/capsules/:id/content/update_counts', N_('Update content counts for the smart proxy')
+    param :id, Integer, :desc => N_('Id of the smart proxy'), :required => true
+    def update_counts
+      task = async_task(::Actions::Katello::CapsuleContent::UpdateContentCounts, @capsule)
+      respond_for_async :resource => task
+    end
+
     api :GET, '/capsules/:id/content/lifecycle_environments', N_('List the lifecycle environments attached to the smart proxy')
     param_group :lifecycle_environments
     def lifecycle_environments
@@ -60,12 +73,16 @@ module Katello
       find_content_view if params[:content_view_id]
       find_repository if params[:repository_id]
       skip_metadata_check = ::Foreman::Cast.to_bool(params[:skip_metadata_check])
+      sync_options = {
+        :environment_id => @environment.try(:id),
+        :content_view_id => @content_view.try(:id),
+        :repository_id => @repository.try(:id),
+        :skip_metadata_check => skip_metadata_check
+      }
+      sync_options[:environment_ids] = @capsule.lifecycle_environments&.pluck(:id) unless (@environment || @content_view || @repository)
       task = async_task(::Actions::Katello::CapsuleContent::Sync,
                         @capsule,
-                        :environment_id => @environment.try(:id),
-                        :content_view_id => @content_view.try(:id),
-                        :repository_id => @repository.try(:id),
-                        :skip_metadata_check => skip_metadata_check)
+                        sync_options)
       respond_for_async :resource => task
     end
 

data/app/controllers/katello/api/v2/capsules_controller.rb

@@ -4,6 +4,9 @@ module Katello
       api_base_url "/katello/api"
     end
 
+    skip_before_action :find_resource, only: [:show]
+    before_action :find_smart_proxy, :only => [:show]
+
     api :GET, '/capsules', 'List all smart proxies that have content'
     param_group :search, Api::V2::ApiController
     def index
@@ -15,7 +18,6 @@ module Katello
     api :GET, '/capsules/:id', 'Show the smart proxy details'
     param :id, Integer, :desc => 'Id of the smart proxy', :required => true
     def show
-      super
     end
 
     def resource_name
@@ -31,5 +33,13 @@ module Katello
     def authorized
       User.current.allowed_to?(params.slice(:action, :id).merge(controller: 'api/v2/smart_proxies'))
     end
+
+    # Without this method, Foreman requires non-admin users to be admin or have a
+    # non-existent "view_capsule" permission. By replacing the find_resource
+    # before action, we check the user for "view_smart_proxies" permission instead.
+    def find_smart_proxy
+      resource_scope = SmartProxy.authorized("view_smart_proxies", SmartProxy)
+      instance_variable_set("@smart_proxy", resource_finder(resource_scope, params[:id]))
+    end
   end
 end

data/app/controllers/katello/api/v2/content_view_versions_controller.rb

@@ -1,6 +1,6 @@
 module Katello
   class Api::V2::ContentViewVersionsController < Api::V2::ApiController
-    include Concerns::Api::V2::BulkHostsExtensions
+    include ::Api::V2::BulkHostsExtension
     include Katello::Concerns::FilteredAutoCompleteSearch
 
     before_action :find_authorized_katello_resource, :only => [:show, :update, :promote, :destroy, :republish_repositories]

data/app/controllers/katello/api/v2/docker_tags_controller.rb

@@ -4,6 +4,7 @@ module Katello
     include Katello::Concerns::Api::V2::RepositoryContentController
 
     before_action :find_repositories, :only => [:auto_complete_name]
+    before_action :find_optional_organization, :only => [:repositories, :index, :show, :auto_complete_search]
 
     def auto_complete_name
       page_size = Katello::Concerns::FilteredAutoCompleteSearch::PAGE_SIZE
@@ -31,6 +32,7 @@ module Katello
 
       if tag.repositories.size > 1 #pulp3
         repos = tag.repositories.non_archived
+        repos = repos.in_organization(@organization) if @organization
       else
         repos = []
         tag.related_tags.each do |related|

data/app/controllers/katello/api/v2/hosts_bulk_actions_controller.rb

@@ -1,6 +1,7 @@
 module Katello
+  # this is Katello's host bulk actions controller, not to be confused with Foreman's
   class Api::V2::HostsBulkActionsController < Api::V2::ApiController
-    include Concerns::Api::V2::BulkHostsExtensions
+    include ::Api::V2::BulkHostsExtension
     include Katello::Concerns::Api::V2::ContentOverridesController
     include Katello::ContentSourceHelper
     include ::Foreman::Renderer::Scope::Macros::Base

data/app/controllers/katello/api/v2/organizations_controller.rb

@@ -56,7 +56,7 @@ module Katello
     api :PUT, '/organizations/:id', N_('Update organization')
     param :id, :number, :desc => N_("organization ID"), :required => true
     param :redhat_repository_url, String, :desc => N_("Red Hat CDN URL"), deprecated: true
-    param :simple_content_access, :bool, :desc => N_('Whether Simple Content Access should be enabled for the organization.'), :required => false, :default => true
+    param :simple_content_access, :bool, :desc => N_('Whether Simple Content Access should be enabled for the organization.'), :required => false, :default => true, deprecated: true
     param_group :resource
     def update
       if params[:redhat_repository_url]
@@ -80,7 +80,7 @@ module Katello
     param :organization, Hash do
       param :label, String, :required => false
     end
-    param :simple_content_access, :bool, :desc => N_('Whether to turn on Simple Content Access for the organization.'), :required => false, :default => true
+    param :simple_content_access, :bool, :desc => N_('Whether to turn on Simple Content Access for the organization.'), :required => false, :default => true, deprecated: true
     def create
       @organization = Organization.new(resource_params)
       sca = params.key?(:simple_content_access) ? ::Foreman::Cast.to_bool(params[:simple_content_access]) : true

data/app/controllers/katello/api/v2/repositories_controller.rb

@@ -348,6 +348,7 @@ Alternatively, use the 'force' parameter to regenerate metadata locally. On the
     param :skip_metadata_check, :bool, :desc => N_("Force sync even if no upstream changes are detected. Only used with yum or deb repositories."), :required => false
     param :validate_contents, :bool, :desc => N_("Force a sync and validate the checksums of all content. Only used with yum repositories."), :required => false
     def sync
+      fail HttpErrors::BadRequest, _("attempted to sync a non-library repository.") unless @repository.library_instance?
       sync_options = {
         :skip_metadata_check => ::Foreman::Cast.to_bool(params[:skip_metadata_check]),
         :validate_contents => ::Foreman::Cast.to_bool(params[:validate_contents]),

data/app/controllers/katello/api/v2/simple_content_access_controller.rb

@@ -8,15 +8,15 @@ module Katello
     end
 
     api :GET, "/organizations/:organization_id/simple_content_access/eligible",
-      N_("Check if the specified organization is eligible for Simple Content Access")
+      N_("Check if the specified organization is eligible for Simple Content Access. %s") % sca_only_deprecation_text, deprecated: true
     def eligible
-      ::Foreman::Deprecation.api_deprecation_warning("This endpoint is deprecated and will be removed in a future release. All organizations are now eligible for Simple Content Access.")
+      ::Foreman::Deprecation.api_deprecation_warning("This endpoint is deprecated and will be removed in Katello 4.12. All organizations are now eligible for Simple Content Access.")
       eligible = @organization.simple_content_access_eligible?
       render json: { simple_content_access_eligible: eligible }
     end
 
     api :GET, "/organizations/:organization_id/simple_content_access/status",
-      N_("Check if the specified organization has Simple Content Access enabled")
+      N_("Check if the specified organization has Simple Content Access enabled. %s") % sca_only_deprecation_text, deprecated: true
     param :organization_id, :number, :desc => N_("Organization ID"), :required => true
     def status
       status = @organization.simple_content_access?
@@ -24,7 +24,7 @@ module Katello
     end
 
     api :PUT, "/organizations/:organization_id/simple_content_access/enable",
-      N_("Enable simple content access for a manifest")
+      N_("Enable simple content access for a manifest"), deprecated: true
     param :organization_id, :number, :desc => N_("Organization ID"), :required => true
     def enable
       task = async_task(::Actions::Katello::Organization::SimpleContentAccess::Enable, params[:organization_id])
@@ -32,7 +32,7 @@ module Katello
     end
 
     api :PUT, "/organizations/:organization_id/simple_content_access/disable",
-      N_("Disable simple content access for a manifest")
+      N_("Disable simple content access for a manifest. %s") % sca_only_deprecation_text, deprecated: true
     param :organization_id, :number, :desc => N_("Organization ID"), :required => true
     def disable
       task = async_task(::Actions::Katello::Organization::SimpleContentAccess::Disable, params[:organization_id])

data/app/controllers/katello/api/v2/sync_plans_controller.rb

@@ -8,6 +8,7 @@ module Katello
                                                                :add_products, :remove_products]
     before_action :set_organization, :only => [:update, :show, :destroy, :sync,
                                                :add_products, :remove_products]
+    before_action :validate_sync_plan_products, :only => [:update, :add_products, :remove_products]
 
     def_param_group :sync_plan do
       param :name, String, :desc => N_("sync plan name"), :required => true, :action_aware => true
@@ -93,8 +94,9 @@ module Katello
     param :product_ids, Array, :desc => N_("List of product ids to add to the sync plan"), :required => true
     def add_products
       products = ::Katello::Product.where(:id => params[:product_ids]).editable
+      disabled_products = products.select { |p| p.redhat? && !p.enabled? }
+      fail _("Cannot add disabled products to sync plan!") if disabled_products.present?
       @sync_plan.product_ids = (@sync_plan.product_ids + products.collect { |p| p.id }).uniq
-      @sync_plan.save!
       respond_for_show
     end
 
@@ -104,8 +106,10 @@ module Katello
     param :product_ids, Array, :desc => N_("List of product ids to remove from the sync plan"), :required => true
     def remove_products
       products = ::Katello::Product.where(:id => params[:product_ids]).editable
-      @sync_plan.product_ids = (@sync_plan.product_ids - products.collect { |p| p.id }).uniq
-      @sync_plan.save!
+      begin
+        @sync_plan.product_ids = (@sync_plan.product_ids - products.collect { |p| p.id }).uniq
+      end
+
       respond_for_show
     end
 
@@ -127,5 +131,9 @@ module Katello
     def set_organization
       @organization ||= @sync_plan.try(:organization)
     end
+
+    def validate_sync_plan_products
+      @sync_plan.validate_and_update_products force_update: true
+    end
   end
 end

data/app/controllers/katello/concerns/api/api_controller.rb

@@ -17,6 +17,12 @@ module Katello
         User.current
       end
 
+      class_methods do
+        def sca_only_deprecation_text
+          N_("WARNING: Simple Content Access will be required for all organizations in Katello 4.12.")
+        end
+      end
+
       protected
 
       def request_from_katello_cli?

data/app/controllers/katello/concerns/api/v2/hosts_bulk_actions_controller_extensions.rb

@@ -0,0 +1,23 @@
+module Katello
+  module Concerns
+    # overrides Foreman Api::V2::HostsBulkActionsController
+    module Api::V2::HostsBulkActionsControllerExtensions
+      extend ActiveSupport::Concern
+      require 'active_support/core_ext/string/inflections'
+
+      module Overrides
+        def bulk_destroy
+          destroyed_count = @hosts.count
+          @hosts.in_batches.each_record do |host|
+            Katello::RegistrationManager.unregister_host(host, :unregistering => false)
+          end
+          process_response(true, { :message => _("Deleted %{host_count} %{hosts}") % { :host_count => destroyed_count, :hosts => 'host'.pluralize(destroyed_count) }})
+        end
+      end
+
+      included do
+        prepend Overrides
+      end
+    end
+  end
+end

data/app/controllers/katello/concerns/filtered_auto_complete_search.rb

@@ -7,7 +7,7 @@ module Katello
 
       def auto_complete_search
         begin
-          options = resource_class.respond_to?(:completer_scope_options) ? resource_class.completer_scope_options : {}
+          options = resource_class.respond_to?(:completer_scope_options) ? resource_class.completer_scope_options(params[:search]) : {}
           items = resource_class.where(:id => self.index_relation).complete_for(params[:search], options)
           items = items.map do |item|
             category = ['and', 'or', 'not', 'has'].include?(item.to_s.sub(/^.*\s+/, '')) ? _('Operators') : ''

data/app/controllers/katello/concerns/organizations_controller_extensions.rb

@@ -25,6 +25,7 @@ module Katello
             begin
               @taxonomy = Organization.new(resource_params)
               sca = ::Foreman::Cast.to_bool(params[:simple_content_access])
+              ::Foreman::Deprecation.api_deprecation_warning("Simple Content Access will be required for all organizations in Katello 4.12.")
               ::Katello::OrganizationCreator.new(@taxonomy, sca: sca).create!
               @taxonomy.reload
               switch_taxonomy
@@ -47,6 +48,7 @@ module Katello
       def update
         return if params[:simple_content_access].nil?
         sca_param = ::Foreman::Cast.to_bool(params[:simple_content_access])
+        ::Foreman::Deprecation.api_deprecation_warning("Simple Content Access will be required for all organizations in Katello 4.12.")
         if sca_param && !@taxonomy.simple_content_access?(cached: false)
           # user has requested SCA enable
           sync_task(::Actions::Katello::Organization::SimpleContentAccess::Enable, params[:id])

data/app/controllers/katello/remote_execution_controller.rb

@@ -1,7 +1,7 @@
 module Katello
   if Katello.with_remote_execution?
     class RemoteExecutionController < JobInvocationsController
-      include Concerns::Api::V2::BulkHostsExtensions
+      include ::Api::V2::BulkHostsExtension
       include Concerns::Api::V2::HostErrataExtensions
 
       def new

data/app/jobs/create_host_lifecycle_expire_soon_notifications.rb

@@ -0,0 +1,11 @@
+class CreateHostLifecycleExpireSoonNotifications < ApplicationJob
+  def perform
+    Katello::UINotifications::Hosts::LifecycleExpireSoon.deliver!
+  ensure
+    self.class.set(:wait => 1.week).perform_later
+  end
+
+  def humanized_name
+    _('Host lifecycle support expiration notification')
+  end
+end

data/app/lib/actions/katello/applicability/hosts/bulk_generate.rb

@@ -8,14 +8,24 @@ module Actions
           end
 
           def run
+            error = false
             input[:host_ids].each do |host_id|
               content_facet = ::Katello::Host::ContentFacet.find_by_host_id(host_id)
               if content_facet.present?
+                # Catch errors and log them, but continue processing the rest of the hosts
                 content_facet.calculate_and_import_applicability
               else
                 Rails.logger.warn(_("Content Facet for host with id %s is non-existent. Skipping applicability calculation.") % host_id)
               end
+            rescue NoMethodError, PG::Error => e
+              Rails.logger.error("Error calculating applicability for host #{host_id}: #{e.message}")
+              error = true
             end
+            fail "Error calculating applicability for one or more hosts" if error
+          end
+
+          def rescue_strategy
+            Dynflow::Action::Rescue::Skip
           end
 
           def queue

data/app/lib/actions/katello/capsule_content/refresh_repos.rb

@@ -18,7 +18,8 @@ module Actions
           plan_self(:smart_proxy_id => smart_proxy.id,
                     :environment_id => options[:environment]&.id,
                     :content_view_id => options[:content_view]&.id,
-                    :repository_id => options[:repository]&.id)
+                    :repository_id => options[:repository]&.id,
+                    :repository_ids_list => options[:repository_ids_list])
         end
 
         def invoke_external_task
@@ -33,7 +34,12 @@ module Actions
           current_repos_on_capsule = smart_proxy_service.current_repositories(environment, content_view)
           current_repos_on_capsule_ids = current_repos_on_capsule.pluck(:id)
 
-          list_of_repos_to_sync = smart_proxy_helper.combined_repos_available_to_capsule(environment, content_view, repository)
+          if input[:repository_ids_list].nil?
+            list_of_repos_to_sync = smart_proxy_helper.combined_repos_available_to_capsule(environment, content_view, repository)
+          else
+            list_of_repos_to_sync = ::Katello::Repository.where(:id => input[:repository_ids_list])
+          end
+
           list_of_repos_to_sync.each do |repo|
             next unless act_on_repo?(repo, smart_proxy)
 

data/app/lib/actions/katello/capsule_content/sync.rb

@@ -2,10 +2,13 @@ module Actions
   module Katello
     module CapsuleContent
       class Sync < ::Actions::EntryAction
+        include ::Actions::ObservableAction
         def resource_locks
           :link
         end
 
+        execution_plan_hooks.use :notify_on_failure, :on => [:failure, :paused]
+
         input_format do
           param :name
         end
@@ -19,24 +22,19 @@ module Actions
         end
 
         def plan(smart_proxy, options = {})
+          input[:options] = options
+
           action_subject(smart_proxy)
           smart_proxy.verify_ueber_certs
-          environment_id = options.fetch(:environment_id, nil)
-          environment = ::Katello::KTEnvironment.find(environment_id) if environment_id
-          repository_id = options.fetch(:repository_id, nil)
-          repository = ::Katello::Repository.find(repository_id) if repository_id
-          content_view_id = options.fetch(:content_view_id, nil)
-          content_view = ::Katello::ContentView.find(content_view_id) if content_view_id
+
+          subjects = subjects(options)
 
           fail _("Action not allowed for the default smart proxy.") if smart_proxy.pulp_primary?
 
-          refresh_options = options.merge(content_view: content_view,
-                                          environment: environment,
-                                          repository: repository)
+          refresh_options = options.merge(subjects)
           sequence do
             if smart_proxy.has_feature?(SmartProxy::PULP3_FEATURE)
               plan_action(Actions::Pulp3::ContentGuard::Refresh, smart_proxy)
-              plan_action(Actions::Pulp3::Orchestration::Repository::RefreshRepos, smart_proxy, refresh_options)
             end
             plan_action(SyncCapsule, smart_proxy, refresh_options)
           end
@@ -49,6 +47,28 @@ module Actions
             smart_proxy&.audit_capsule_sync
           end
         end
+
+        def notify_on_failure(_plan)
+          notification = MailNotification[:proxy_sync_failure]
+          proxy = SmartProxy.find(input.fetch(:smart_proxy, {})[:id])
+          subjects = subjects(input[:options]).merge(smart_proxy: proxy)
+          notification.users.where(disabled: [nil, false], mail_enabled: true).each do |user|
+            notification.deliver(subjects.merge(user: user, task: task))
+          end
+        end
+
+        def subjects(options = {})
+          environment_id = options.fetch(:environment_id, nil)
+          environment = ::Katello::KTEnvironment.find(environment_id) if environment_id
+
+          repository_id = options.fetch(:repository_id, nil)
+          repository = ::Katello::Repository.find(repository_id) if repository_id
+
+          content_view_id = options.fetch(:content_view_id, nil)
+          content_view = ::Katello::ContentView.find(content_view_id) if content_view_id
+
+          {content_view: content_view, environment: environment, repository: repository}
+        end
       end
     end
   end

data/app/lib/actions/katello/capsule_content/sync_capsule.rb

@@ -3,6 +3,7 @@ module Actions
     module CapsuleContent
       class SyncCapsule < ::Actions::EntryAction
         # rubocop:disable Metrics/MethodLength
+        execution_plan_hooks.use :update_content_counts, :on => :success
         def plan(smart_proxy, options = {})
           plan_self(:smart_proxy_id => smart_proxy.id)
           action_subject(smart_proxy)
@@ -14,6 +15,13 @@ module Actions
             repos = repos_to_sync(smart_proxy, environment, content_view, repository, skip_metadata_check)
             return nil if repos.empty?
 
+            if environment.nil? && content_view.nil? && repository.nil?
+              options[:repository_ids_list] = repos.pluck(:id)
+            end
+            if smart_proxy.has_feature?(SmartProxy::PULP3_FEATURE)
+              plan_action(Actions::Pulp3::Orchestration::Repository::RefreshRepos, smart_proxy, options)
+            end
+
             repos.in_groups_of(Setting[:foreman_proxy_content_batch_size], false) do |repo_batch|
               concurrence do
                 repo_batch.each do |repo|
@@ -60,6 +68,11 @@ module Actions
           end
         end
 
+        def update_content_counts(_execution_plan)
+          smart_proxy = ::SmartProxy.unscoped.find(input[:smart_proxy_id])
+          ::ForemanTasks.async_task(::Actions::Katello::CapsuleContent::UpdateContentCounts, smart_proxy)
+        end
+
         def resource_locks
           :link
         end

data/app/lib/actions/katello/capsule_content/update_content_counts.rb

@@ -0,0 +1,24 @@
+module Actions
+  module Katello
+    module CapsuleContent
+      class UpdateContentCounts < Actions::EntryAction
+        def plan(smart_proxy)
+          plan_self(:smart_proxy_id => smart_proxy.id)
+        end
+
+        def humanized_name
+          _("Update Content Counts")
+        end
+
+        def run
+          smart_proxy = ::SmartProxy.unscoped.find(input[:smart_proxy_id])
+          smart_proxy.update_content_counts!
+        end
+
+        def rescue_strategy
+          Dynflow::Action::Rescue::Skip
+        end
+      end
+    end
+  end
+end

data/app/lib/actions/katello/content_view/promote.rb

@@ -4,6 +4,7 @@ module Actions
       class Promote < Actions::EntryAction
         extend ApipieDSL::Class
         include ::Actions::ObservableAction
+        execution_plan_hooks.use :notify_on_failure, :on => [:failure, :paused]
 
         def plan(version, environments, is_force = false, description = nil, incremental_update = false)
           action_subject(version.content_view)
@@ -23,6 +24,14 @@ module Actions
           end
         end
 
+        def notify_on_failure(_plan)
+          notification = MailNotification[:content_view_promote_failure]
+          view = ::Katello::ContentView.find(input.fetch(:content_view, {})[:id])
+          notification.users.where(disabled: [nil, false], mail_enabled: true).each do |user|
+            notification.deliver(user: user, content_view: view, task: task)
+          end
+        end
+
         def environments
           input['environments']
         end

data/app/lib/actions/katello/content_view/publish.rb

@@ -7,6 +7,7 @@ module Actions
         include ::Actions::ObservableAction
         attr_accessor :version
         execution_plan_hooks.use :trigger_capsule_sync, :on => :success
+        execution_plan_hooks.use :notify_on_failure, :on => [:failure, :paused]
 
         # rubocop:disable Metrics/MethodLength,Metrics/AbcSize,Metrics/CyclomaticComplexity
         def plan(content_view, description = "", options = {importing: false, syncable: false}) # rubocop:disable Metrics/PerceivedComplexity
@@ -132,6 +133,14 @@ module Actions
           end
         end
 
+        def notify_on_failure(_plan)
+          notification = MailNotification[:content_view_publish_failure]
+          view = ::Katello::ContentView.find(input.fetch(:content_view, {})[:id])
+          notification.users.where(disabled: [nil, false], mail_enabled: true).each do |user|
+            notification.deliver(user: user, content_view: view, task: task)
+          end
+        end
+
         def content_view_version_id
           input['content_view_version_id']
         end

data/app/lib/actions/katello/orphan_cleanup/remove_orphans.rb

@@ -15,9 +15,17 @@ module Actions
               plan_action(
                 Actions::Pulp3::Orchestration::OrphanCleanup::RemoveOrphans,
                 proxy)
+              plan_self(:smart_proxy_id => proxy.id)
             end
           end
         end
+
+        def finalize
+          smart_proxy = ::SmartProxy.unscoped.find(input[:smart_proxy_id])
+          if smart_proxy.pulp_mirror?
+            ::ForemanTasks.async_task(::Actions::Katello::CapsuleContent::UpdateContentCounts, smart_proxy)
+          end
+        end
       end
     end
   end

data/app/lib/actions/katello/repository/sync.rb

@@ -8,6 +8,8 @@ module Actions
         include ::Actions::ObservableAction
         middleware.use Actions::Middleware::ExecuteIfContentsChanged
 
+        execution_plan_hooks.use :notify_on_failure, :on => [:failure, :paused]
+
         input_format do
           param :id, Integer
           param :sync_result, Hash
@@ -83,6 +85,7 @@ module Actions
         def validate_repo!(repo:, source_url:, skip_metadata_check:, skip_candlepin_check:)
           fail ::Katello::Errors::InvalidActionOptionError, _("Unable to sync repo. This repository does not have a feed url.") if repo.url.blank? && source_url.blank?
           fail ::Katello::Errors::InvalidActionOptionError, _("Cannot skip metadata check on non-yum/deb repositories.") if skip_metadata_check && !repo.yum? && !repo.deb?
+          fail ::Katello::Errors::InvalidActionOptionError, _("Unable to sync repo. This repository is not a library instance repository.") unless repo.library_instance?
           ::Katello::Util::CandlepinRepositoryChecker.check_repository_for_sync!(repo) if repo.yum? && !skip_candlepin_check
         end
 
@@ -96,6 +99,14 @@ module Actions
           Dynflow::Action::Rescue::Skip
         end
 
+        def notify_on_failure(_plan)
+          notification = MailNotification[:repository_sync_failure]
+          repo = ::Katello::Repository.find(input.fetch(:repository, {})[:id])
+          notification.users.where(disabled: [nil, false], mail_enabled: true).each do |user|
+            notification.deliver(user: user, repo: repo, task: task)
+          end
+        end
+
         def repository_id
           input['repository']['id']
         end

data/app/lib/actions/pulp3/capsule_content/reclaim_space.rb

@@ -3,6 +3,7 @@ module Actions
     module CapsuleContent
       class ReclaimSpace < Pulp3::AbstractAsyncTask
         def plan(smart_proxy)
+          action_subject(smart_proxy)
           if smart_proxy.pulp_primary?
             repository_hrefs = ::Katello::Pulp3::RepositoryReference.default_cv_repository_hrefs(::Katello::Repository.unscoped.on_demand, ::Organization.all)
             repository_hrefs.flatten!
@@ -20,6 +21,10 @@ module Actions
           output[:pulp_tasks] = ::Katello::Pulp3::Api::Core.new(SmartProxy.find(input[:smart_proxy_id])).
             repositories_reclaim_space_api.reclaim(repo_hrefs: input[:repository_hrefs])
         end
+
+        def rescue_strategy
+          Dynflow::Action::Rescue::Skip
+        end
       end
     end
   end

data/app/lib/actions/pulp3/content_view_version/create_export_history.rb

@@ -16,11 +16,16 @@ module Actions
           param :exported_file_checksum, String
         end
 
-        def run
+        def run # rubocop:disable Metrics/AbcSize
           smart_proxy = ::SmartProxy.unscoped.find(input[:smart_proxy_id])
           api = ::Katello::Pulp3::Api::Core.new(smart_proxy)
           export_data = api.export_api.list(input[:exporter_data][:pulp_href]).results.first
           output[:exported_file_checksum] = export_data.output_file_info
+          if output[:exported_file_checksum].blank?
+            output[:export_history_id] = nil
+            output[:message] = _("Export failed: One or more repositories needs to be synced (with Immediate download policy.)")
+            return
+          end
           file_name = output[:exported_file_checksum].first&.first
           path = File.dirname(file_name.to_s)
           output[:path] = path