kalibro_client 0.0.1 → 0.0.2

data/spec/entities/processor/metric_result_spec.rb

@@ -18,9 +18,19 @@ require 'spec_helper'
 
 describe KalibroClient::Entities::Processor::MetricResult do
   let(:metric_configuration) { FactoryGirl.build(:metric_configuration_with_id) }
-  subject { FactoryGirl.build(:metric_result, metric_configuration_id: metric_configuration.id) }
+  subject { FactoryGirl.build(:metric_result) }
+
+  before do
+    KalibroClient::Entities::Configurations::MetricConfiguration.
+      stubs(:request).
+      with(':id', {id: metric_configuration.id}, :get).
+      returns({'metric_configuration' => metric_configuration.to_hash})
+  end
 
   describe 'new' do
+    before :each do
+      subject.metric_configuration_id = metric_configuration.id
+    end
     context 'with value NaN' do
       it 'should set the value with aggregated_value' do
         attributes_hash = FactoryGirl.build(:metric_result, {"aggregated_value" => 1.6}).to_hash
@@ -49,30 +59,6 @@ describe KalibroClient::Entities::Processor::MetricResult do
     end
   end
 
-  describe 'metric_configuration' do
-
-    context 'without a set metric configuration' do
-      it 'should fetch and return the metric configuration' do
-        KalibroClient::Entities::Configurations::MetricConfiguration.expects(:find).with(metric_configuration.id).returns(metric_configuration)
-        expect(subject.metric_configuration).to eq(metric_configuration)
-      end
-    end
-
-    context 'with a set metric configuration' do
-      before :each do
-        subject.metric_configuration = metric_configuration
-      end
-
-      it 'should only return the metric configuration' do
-        expect(subject.metric_configuration).to eq(metric_configuration)
-      end
-
-      it 'should set the metric configuration id' do
-        expect(subject.metric_configuration_id).to eq(metric_configuration.id)
-      end
-    end
-  end
-
   describe 'value=' do
     it 'should set the value of the attribute value' do
       subject.value = 42
@@ -91,9 +77,9 @@ describe KalibroClient::Entities::Processor::MetricResult do
     context 'when there is one descendant value for the given metric_result' do
       before :each do
         KalibroClient::Entities::Processor::MetricResult.
-          expects(:request).
-          with(':id/descendant_values', { id: subject.id }, :get).
-          returns({'descendant_values' => [13.3]})
+        expects(:request).
+        with(':id/descendant_values', { id: subject.id }, :get).
+        returns({'descendant_values' => [13.3]})
       end
 
       it 'should return an unitary list with the descendant value' do
@@ -104,9 +90,9 @@ describe KalibroClient::Entities::Processor::MetricResult do
     context 'when there is no descendant value for the given metric_result' do
       before :each do
         KalibroClient::Entities::Processor::MetricResult.
-          expects(:request).
-          with(':id/descendant_values', { id: subject.id }, :get).
-          returns({'descendant_values' => []})
+        expects(:request).
+        with(':id/descendant_values', { id: subject.id }, :get).
+        returns({'descendant_values' => []})
       end
 
       it 'should return an empty list' do
@@ -116,42 +102,42 @@ describe KalibroClient::Entities::Processor::MetricResult do
   end
 
   describe 'metric_results_of' do
+    let(:module_result) { FactoryGirl.build(:module_result) }
+
+    before :each do
+      KalibroClient::Entities::Processor::ModuleResult.
+      expects(:find).
+      with(module_result.id).
+      returns(module_result)
+    end
+
     context 'when there is one metric result for the given module_result' do
       before :each do
-        KalibroClient::Entities::Processor::ModuleResult.
-          expects(:request).
-          with(':id/metric_results', { id: 123 }, :get).
-          returns({'metric_results' => [subject.to_hash]})
+        module_result.expects(:metric_results).returns([subject])
       end
 
       it 'should return an unitary list with the metric result' do
-        expect(KalibroClient::Entities::Processor::MetricResult.metric_results_of(123).first.value).to eq(subject.value)
+        expect(KalibroClient::Entities::Processor::MetricResult.metric_results_of(module_result.id).first.value).to eq(subject.value)
       end
     end
 
     context 'when there is no metric result for the given module_result' do
       before :each do
-        KalibroClient::Entities::Processor::ModuleResult.
-          expects(:request).
-          with(':id/metric_results', { :id => 42 }, :get).
-          returns({'metric_results' => []})
+        module_result.expects(:metric_results).returns([])
       end
 
       it 'should return an empty list' do
-        expect(KalibroClient::Entities::Processor::MetricResult.metric_results_of(42)).to eq([])
+        expect(KalibroClient::Entities::Processor::MetricResult.metric_results_of(module_result.id)).to eq([])
       end
     end
 
     context 'when there are many metric results for the given module_result' do
       before :each do
-        KalibroClient::Entities::Processor::ModuleResult.
-          expects(:request).
-          with(':id/metric_results', { :id => 28 }, :get).
-          returns({'metric_results' => [subject.to_hash, subject.to_hash]})
+        module_result.expects(:metric_results).returns([subject, subject])
       end
 
       it 'should return a list with the descendant results' do
-        expect(KalibroClient::Entities::Processor::MetricResult.metric_results_of(28).first.value).to eq(subject.value)
+        expect(KalibroClient::Entities::Processor::MetricResult.metric_results_of(module_result.id).first.value).to eq(subject.value)
       end
     end
   end
@@ -164,9 +150,9 @@ describe KalibroClient::Entities::Processor::MetricResult do
     context 'when there is not a date metric result' do
       before :each do
         KalibroClient::Entities::Processor::Repository.
-          expects(:request).
-          with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id}).
-          returns({'metric_result_history_of' => []})
+        expects(:request).
+        with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id}).
+        returns({'metric_result_history_of' => []})
       end
 
       it 'should return an empty list' do
@@ -179,8 +165,8 @@ describe KalibroClient::Entities::Processor::MetricResult do
 
       before :each do
         KalibroClient::Entities::Processor::Repository.
-          expects(:request).with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id})
-          .returns({'metric_result_history_of' => [date_metric_result.to_hash]})
+        expects(:request).with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id})
+        .returns({'metric_result_history_of' => [date_metric_result.to_hash]})
       end
 
       it 'should return the date metric result as an object into a list' do
@@ -194,9 +180,9 @@ describe KalibroClient::Entities::Processor::MetricResult do
 
       before :each do
         KalibroClient::Entities::Processor::Repository.
-          expects(:request).
-          with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id}).
-          returns({'metric_result_history_of' => [date_metric_result.to_hash, another_date_metric_result.to_hash]})
+        expects(:request).
+        with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id}).
+        returns({'metric_result_history_of' => [date_metric_result.to_hash, another_date_metric_result.to_hash]})
       end
 
       it 'should return a list of date metric results as objects' do

data/spec/entities/processor/module_result_spec.rb

@@ -134,16 +134,18 @@ describe KalibroClient::Entities::Processor::ModuleResult do
   end
 
   describe 'history_of' do
+    let(:subject) { FactoryGirl.build(:module_result, kalibro_module: FactoryGirl.build(:kalibro_module_with_id)) }
+    let(:repository) { FactoryGirl.build(:repository) }
     let(:date_module_result) { FactoryGirl.build(:date_module_result) }
     before :each do
-      KalibroClient::Entities::Processor::ModuleResult.
+      KalibroClient::Entities::Processor::Repository.
         expects(:request).
-        with('history_of', {id: subject.id}).
+        with(':id/module_result_history_of', {id: repository.id, kalibro_module_id: subject.kalibro_module.id}).
         returns({'date_module_results' => [[date_module_result.date, date_module_result.module_result.to_hash]]})
     end
 
     it 'should return a list of date_module_results' do
-      date_module_results = KalibroClient::Entities::Processor::ModuleResult.history_of subject.id
+      date_module_results = KalibroClient::Entities::Processor::ModuleResult.history_of(subject, repository.id)
       expect(date_module_results.first.result).to eq date_module_result.result
     end
   end
@@ -175,4 +177,51 @@ describe KalibroClient::Entities::Processor::ModuleResult do
       end
     end
   end
+
+  describe 'metric_results' do
+    subject { FactoryGirl.build(:root_module_result) }
+    let(:metric_configuration) { FactoryGirl.build(:metric_configuration_with_id) }
+    let(:metric_result_1) { FactoryGirl.build(:metric_result, metric_configuration: metric_configuration) }
+    let(:metric_result_2) { FactoryGirl.build(:metric_result, metric_configuration: metric_configuration) }
+
+    context 'with metric results' do
+      before :each do
+        KalibroClient::Entities::Processor::ModuleResult.
+        expects(:request).
+        with(':id/metric_results', {id: subject.id}, :get).
+        returns({'metric_results' => [metric_result_1.to_hash, metric_result_2.to_hash]})
+        KalibroClient::Entities::Configurations::MetricConfiguration.
+        expects(:request).
+        with(':id', {id: metric_configuration.id}, :get).twice.
+        returns({'metric_configuration' => metric_configuration.to_hash})
+      end
+
+      it 'should return the metric results' do
+        expect(subject.metric_results).to eq([metric_result_1, metric_result_2])
+      end
+    end
+
+    context 'without metric results' do
+      before :each do
+        KalibroClient::Entities::Processor::ModuleResult.
+        expects(:request).
+        with(':id/metric_results', {id: subject.id}, :get).
+        returns({'metric_results' => []})
+      end
+
+      it 'should return the metric results' do
+        expect(subject.metric_results).to eq([])
+      end
+    end
+  end
+
+  describe 'processing' do
+    let(:processing) { FactoryGirl.build(:processing) }
+
+    it 'is expected to find the processing' do
+      KalibroClient::Entities::Processor::Processing.expects(:find).with(subject.processing_id).returns(processing)
+
+      expect(subject.processing).to eq(processing)
+    end
+  end
 end

data/spec/entities/processor/processing_spec.rb

@@ -79,13 +79,15 @@ describe KalibroClient::Entities::Processor::Processing do
 
   context 'static methods' do
     context 'using repository as parametter' do
-      let(:repository) { FactoryGirl.build(:repository) }
+      let!(:repository) { FactoryGirl.build(:repository_with_id) }
+
+      before :each do
+        KalibroClient::Entities::Processor::Repository.stubs(:find).with(repository.id).returns(repository)
+      end
+
       describe 'has_processing' do
         before :each do
-          KalibroClient::Entities::Processor::Repository.
-            expects(:request).once.
-            with("#{repository.id}/has_processing").
-            returns({'has_processing' => false})
+          repository.expects(:has_processing).returns(false)
         end
 
         it 'should convert the hash to a Boolean class' do
@@ -96,10 +98,7 @@ describe KalibroClient::Entities::Processor::Processing do
 
       describe 'has_ready_processing' do
         before :each do
-          KalibroClient::Entities::Processor::Repository.
-            expects(:request).once.
-            with("#{repository.id}/has_ready_processing", {}, :get).
-            returns({'has_ready_processing' => false})
+          repository.expects(:has_ready_processing).returns(false)
         end
 
         it 'should convert the hash to a Boolean class' do
@@ -110,10 +109,7 @@ describe KalibroClient::Entities::Processor::Processing do
 
       describe 'has_processing_after' do
         before :each do
-          KalibroClient::Entities::Processor::Repository.
-            expects(:request).once.
-            with("#{repository.id}/has_processing/after", {date: date}).
-            returns({'has_processing_in_time' => false})
+          repository.expects(:has_processing_after).with(date).returns(false)
         end
 
         it 'should convert the hash to a Boolean class' do
@@ -124,10 +120,7 @@ describe KalibroClient::Entities::Processor::Processing do
 
       describe 'has_processing_before' do
         before :each do
-          KalibroClient::Entities::Processor::Repository.
-            expects(:request).once.
-            with("#{repository.id}/has_processing/before", {date: date}).
-            returns({'has_processing_in_time' => false})
+          repository.expects(:has_processing_before).with(date).returns(false)
         end
 
         it 'should convert the hash to a Boolean class' do
@@ -137,12 +130,10 @@ describe KalibroClient::Entities::Processor::Processing do
       end
 
       describe 'last_processing_state_of' do
-        let(:any_state)  { "READY" }
+        let!(:any_state)  { "READY" }
+
         before :each do
-          KalibroClient::Entities::Processor::Repository.
-            expects(:request).once.
-            with("#{repository.id}/last_processing_state", {}, :get).
-            returns({'processing_state' => any_state})
+          repository.expects(:last_processing_state).returns(any_state)
         end
 
         it 'should return the state as string' do
@@ -157,15 +148,9 @@ describe KalibroClient::Entities::Processor::Processing do
         describe 'processing_of' do
           context 'when the repository has a ready processing' do
             before do
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with("#{repository.id}/has_ready_processing", {}, :get).
-                returns({'has_ready_processing' => true})
-
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with(':id/last_ready_processing', {id: repository.id}, :get).
-                returns({'last_ready_processing' => processing.to_hash})
+              repository.expects(:has_ready_processing).returns(true)
+
+              repository.expects(:last_ready_processing).returns(processing)
             end
 
             it 'should return the last ready processing' do
@@ -176,15 +161,9 @@ describe KalibroClient::Entities::Processor::Processing do
 
           context 'when the repository has not a ready processing' do
             before do
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with("#{repository.id}/has_ready_processing", {}, :get).
-                returns({'exists' => false})
-
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with("#{repository.id}/last_processing").
-                returns({'processing' => processing.to_hash})
+              KalibroClient::Entities::Processor::Processing.expects(:has_ready_processing).returns(false)
+
+              KalibroClient::Entities::Processor::Processing.expects(:last_processing_of).returns(processing)
             end
 
             it 'should return the last processing' do
@@ -197,15 +176,9 @@ describe KalibroClient::Entities::Processor::Processing do
         describe 'processing_with_date_of' do
           context 'when the repository has a processing after the given date' do
             before do
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with("#{repository.id}/has_processing/after", {date: date}).
-                returns({'has_processing_in_time' => true})
-
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with("#{repository.id}/first_processing/after", {date: date}).
-                returns({'processing' => processing.to_hash})
+              repository.expects(:has_processing_after).with(date).returns(true)
+
+              repository.expects(:first_processing_after).with(date).returns(processing)
             end
 
             it 'should return the first processing after the given date' do
@@ -216,20 +189,11 @@ describe KalibroClient::Entities::Processor::Processing do
 
           context 'when the repository has a processing before the given date' do
             before do
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with("#{repository.id}/has_processing/after", {date: date}).
-                returns({'has_processing_in_time' => false})
-
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with("#{repository.id}/has_processing/before", {date: date}).
-                returns({'has_processing_in_time' => true})
-
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with("#{repository.id}/last_processing/before", {date: date}).
-                returns({'processing' => processing.to_hash})
+              KalibroClient::Entities::Processor::Processing.expects(:has_processing_after).with(repository.id, date).returns(false)
+
+              KalibroClient::Entities::Processor::Processing.expects(:has_processing_before).with(repository.id, date).returns(true)
+
+              KalibroClient::Entities::Processor::Processing.expects(:last_processing_before).with(repository.id, date).returns(processing)
             end
 
             it 'should return the last ready processing' do
@@ -240,15 +204,9 @@ describe KalibroClient::Entities::Processor::Processing do
 
           context 'when the repository has not a processing after or before the given date' do
             before do
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with("#{repository.id}/has_processing/after", {date: date}).
-                returns({'has_processing_in_time' => false})
-
-              KalibroClient::Entities::Processor::Repository.
-                expects(:request).once.
-                with("#{repository.id}/has_processing/before", {date: date}).
-                returns({'has_processing_in_time' => false})
+              repository.expects(:has_processing_after).with(date).returns(false)
+
+              repository.expects(:has_processing_before).with(date).returns(false)
             end
 
             it 'should return the last ready processing' do
@@ -260,10 +218,7 @@ describe KalibroClient::Entities::Processor::Processing do
 
         describe 'last_ready_processing_of' do
           before :each do
-            KalibroClient::Entities::Processor::Repository.
-              expects(:request).once.
-              with(':id/last_ready_processing', {id: repository.id}, :get).
-              returns({'last_ready_processing' => processing.to_hash})
+            repository.expects(:last_ready_processing).returns(processing)
           end
 
           it 'should return a processing object' do
@@ -274,10 +229,7 @@ describe KalibroClient::Entities::Processor::Processing do
 
         describe 'first_processing_of' do
           before :each do
-            KalibroClient::Entities::Processor::Repository.
-              expects(:request).once.
-              with("#{repository.id}/first_processing").
-              returns({'processing' => processing.to_hash})
+            repository.expects(:first_processing).returns(processing)
           end
 
           it 'should return a processing object' do
@@ -288,10 +240,7 @@ describe KalibroClient::Entities::Processor::Processing do
 
         describe 'last_processing_of' do
           before :each do
-            KalibroClient::Entities::Processor::Repository.
-              expects(:request).once.
-              with("#{repository.id}/last_processing").
-              returns({'processing' => processing.to_hash})
+            repository.expects(:last_processing).returns(processing)
           end
 
           it 'should return a processing object' do
@@ -302,10 +251,7 @@ describe KalibroClient::Entities::Processor::Processing do
 
         describe 'first_processing_after' do
           before :each do
-            KalibroClient::Entities::Processor::Repository.
-              expects(:request).once.
-              with("#{repository.id}/first_processing/after", {date: date}).
-              returns({'processing' => processing.to_hash})
+            repository.expects(:first_processing_after).with(date).returns(processing)
           end
 
           it 'should return a processing object' do
@@ -316,10 +262,7 @@ describe KalibroClient::Entities::Processor::Processing do
 
         describe 'last_processing_before' do
           before :each do
-            KalibroClient::Entities::Processor::Repository.
-              expects(:request).once.
-              with("#{repository.id}/last_processing/before", {date: date}).
-              returns({'processing' => processing.to_hash})
+            repository.expects(:last_processing_before).with(date).returns(processing)
           end
 
           it 'should return a processing object' do