kalibro_client 0.0.1 → 0.0.2

data/features/processing/last_processing_before.feature

@@ -6,9 +6,9 @@ Feature: Last processing before
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With one repository just after starting to process
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And I have a reading group with name "Group"
-    And I have a loc configuration within the given configuration
+    And I have a loc configuration within the given kalibro configuration
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/processing/last_processing_of.feature

@@ -6,9 +6,9 @@ Feature: Last processing of
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With one repository just after starting to process
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And I have a reading group with name "Group"
-    And I have a loc configuration within the given configuration
+    And I have a loc configuration within the given kalibro configuration
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/processing/last_processing_state_of.feature

@@ -6,9 +6,9 @@ Feature: Last processing state of
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With one repository just after starting to process
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And I have a reading group with name "Group"
-    And I have a loc configuration within the given configuration
+    And I have a loc configuration within the given kalibro configuration
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/processing/last_ready_processing_of.feature

@@ -6,9 +6,9 @@ Feature: Last ready processing of
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With one repository just after with ready processing
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And I have a reading group with name "Group"
-    And I have a loc configuration within the given configuration
+    And I have a loc configuration within the given kalibro configuration
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/processing/processing_of.feature

@@ -6,9 +6,9 @@ Feature: Processing of
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With one repository just after starting to process
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And I have a reading group with name "Group"
-    And I have a loc configuration within the given configuration
+    And I have a loc configuration within the given kalibro configuration
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |
@@ -20,9 +20,9 @@ Feature: Processing of
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With one repository just after with ready processing
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And I have a reading group with name "Group"
-    And I have a loc configuration within the given configuration
+    And I have a loc configuration within the given kalibro configuration
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/processing/processing_with_date_of.feature

@@ -6,9 +6,9 @@ Feature: Processing with date of
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With one repository just after starting to process and tomorrow's date
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And I have a reading group with name "Group"
-    And I have a loc configuration within the given configuration
+    And I have a loc configuration within the given kalibro configuration
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |
@@ -20,9 +20,9 @@ Feature: Processing with date of
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With one repository just after starting to process and yesterday's date
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And I have a reading group with name "Group"
-    And I have a loc configuration within the given configuration
+    And I have a loc configuration within the given kalibro configuration
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/project/update.feature

@@ -0,0 +1,13 @@
+Feature: Update
+  In order to be able to have projects
+  As a developer
+  I want to update projects
+
+  @kalibro_processor_restart
+  Scenario: Setting and resetting the name of a valid project (ensures that update is getting called instead of create)
+    Given I have a project with name "Kalibro"
+    And I set the project name to "QtCalculator"
+    And I save the given project
+    And I set the project name to "Kalibro"
+    And I save the given project
+    Then I should get true as the response

data/features/repository/all.feature

@@ -6,7 +6,7 @@ Feature: Repositories listing
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With existing project repository
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/repository/cancel_processing.feature

@@ -6,7 +6,7 @@ Feature: Process
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With one repository
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/repository/destroy.feature

@@ -6,7 +6,7 @@ Feature: Repositories destroying
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With existing repository
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/repository/exists.feature

@@ -6,7 +6,7 @@ Feature: Repositories listing
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With existing project repository
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/repository/find.feature

@@ -6,7 +6,7 @@ Feature: Repositories listing
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With existing project repository
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And the given project has the following Repositories:
       |   name    | scm_type |                  address                    |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/repository/of.feature

@@ -6,7 +6,7 @@ Feature: Repositories listing
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With existing project repository
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And the given project has the following Repositories:
       |   name    | scm_type |              address                        |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/repository/process.feature

@@ -6,9 +6,9 @@ Feature: Process
   @kalibro_processor_restart @kalibro_configuration_restart
   Scenario: With one repository
     Given I have a project with name "Kalibro"
-    And I have a configuration with name "Java"
+    And I have a kalibro configuration with name "Java"
     And I have a reading group with name "Group"
-    And I have a loc configuration within the given configuration
+    And I have a loc configuration within the given kalibro configuration
     And the given project has the following Repositories:
       |   name    | scm_type |              address                        |
       |  Kalibro  |    GIT   | https://git.gitorious.org/sbking/sbking.git |

data/features/step_definitions/kalibro_configuration_steps.rb

@@ -0,0 +1,40 @@
+Given(/^I have a kalibro configuration with name "(.*?)"$/) do |name|
+  @kalibro_configuration = FactoryGirl.create(:kalibro_configuration, {name: name})
+end
+
+When(/^I get all the kalibro configurations$/) do
+  @all_kalibro_configurations = KalibroClient::Entities::Configurations::KalibroConfiguration.all
+end
+
+When(/^I create the kalibro configuration with name "(.*?)"$/) do |name|
+  @kalibro_configuration = FactoryGirl.create(:kalibro_configuration, {name: name})
+end
+
+Then(/^I should get a list with the given kalibro configuration$/) do
+  expect(@all_kalibro_configurations.include?(@kalibro_configuration)).to be_truthy
+end
+
+Then(/^the kalibro configuration should exist$/) do
+  expect(KalibroClient::Entities::Configurations::KalibroConfiguration.exists?(@kalibro_configuration.id)).to be_truthy
+end
+
+When(/^I destroy the kalibro configuration$/) do
+  @kalibro_configuration.destroy
+end
+
+Then(/^the kalibro configuration should no longer exist$/) do
+  expect(KalibroClient::Entities::Configurations::KalibroConfiguration.exists?(@kalibro_configuration.id)).to be_falsey
+end
+
+Given(/^the kalibro configuration has a metric configuration$/) do
+  @metric_configuration = FactoryGirl.create(:metric_configuration, kalibro_configuration_id: @kalibro_configuration.id)
+end
+
+When(/^I list all the metric configurations of the kalibro configuration$/) do
+  @metric_configurations = @kalibro_configuration.metric_configurations
+end
+
+Then(/^I should get a list with the given metric configuration$/) do
+  expect(@metric_configurations.include?(@metric_configuration)).to be_truthy
+end
+

data/features/step_definitions/metric_configuration_steps.rb

@@ -1,21 +1,21 @@
-Given(/^I have a metric configuration within the given configuration$/) do
+Given(/^I have a metric configuration within the given kalibro configuration$/) do
   @metric_configuration = FactoryGirl.create(:metric_configuration,
                                              {reading_group_id: @reading_group.id,
-                                              kalibro_configuration_id: @configuration.id})
+                                              kalibro_configuration_id: @kalibro_configuration.id})
 end
 
-Given(/^I have a metric configuration within the given configuration with the given metric$/) do
+Given(/^I have a metric configuration within the given kalibro configuration with the given metric$/) do
   @metric_configuration = FactoryGirl.create(:metric_configuration,
                                              {metric: @metric,
                                               reading_group_id: @reading_group.id,
-                                              kalibro_configuration_id: @configuration.id})
+                                              kalibro_configuration_id: @kalibro_configuration.id})
 end
 
-Given(/^I have a loc configuration within the given configuration$/) do
+Given(/^I have a loc configuration within the given kalibro configuration$/) do
   @metric_configuration = FactoryGirl.create(:metric_configuration,
                                              {metric: FactoryGirl.build(:loc),
                                               reading_group_id: @reading_group.id,
-                                              kalibro_configuration_id: @configuration.id})
+                                              kalibro_configuration_id: @kalibro_configuration.id})
 end
 
 When(/^I search a metric configuration with the same id of the given metric configuration$/) do
@@ -32,8 +32,8 @@ When(/^I search an inexistent metric configuration$/) do
   end
 end
 
-When(/^I request all metric configurations of the given configuration$/) do
-  @metric_configurations = KalibroClient::Entities::Configurations::MetricConfiguration.metric_configurations_of(@configuration.id)
+When(/^I request all metric configurations of the given kalibro configuration$/) do
+  @metric_configurations = KalibroClient::Entities::Configurations::MetricConfiguration.metric_configurations_of(@kalibro_configuration.id)
 end
 
 Then(/^it should return the same metric configuration as the given one$/) do
@@ -53,7 +53,7 @@ When(/^I destroy the metric configuration$/) do
 end
 
 Then(/^the metric configuration should no longer exist$/) do
-  expect { KalibroClient::Entities::Configurations::MetricConfiguration.find(@metric_configuration.id) }.to raise_error(KalibroClient::Errors::RecordNotFound)
+  expect { KalibroClient::Entities::Configurations::MetricConfiguration.find(@metric_configuration.id)}.to raise_error(KalibroClient::Errors::RecordNotFound)
 end
 
 Then(/^the metric configuration should exist$/) do

data/features/step_definitions/module_result_steps.rb

@@ -30,7 +30,7 @@ Given(/^I get the module result of the processing$/) do
 end
 
 When(/^I ask for the history of the given module result$/) do
-  @history = KalibroClient::Entities::Processor::ModuleResult.history_of(@module_result.id)
+  @history = KalibroClient::Entities::Processor::ModuleResult.history_of(@module_result, @repository.id)
 end
 
 Then(/^I should get a list with date module results$/) do

data/features/step_definitions/project_steps.rb

@@ -10,6 +10,10 @@ Given(/^I have a project with name "(.*?)"$/) do |name|
   @project = FactoryGirl.create(:project, {name: name})
 end
 
+Given(/^I set the project name to "(.*?)"$/) do |name|
+  @project.name = name
+end
+
 When(/^I save the project$/) do
   @project.save
 end
@@ -31,6 +35,10 @@ When(/^I ask for all the projects$/) do
   @all_projects = KalibroClient::Entities::Processor::Project.all
 end
 
+When(/^I save the given project$/) do
+  @response = @project.save
+end
+
 Then(/^the project should exist$/) do
   expect(KalibroClient::Entities::Processor::Project.exists?(@project.id)).to be_truthy
 end
@@ -46,3 +54,7 @@ end
 Then(/^I should get a list with the given project$/) do
   expect(@all_projects).to include(@project)
 end
+
+Then(/^I should get true as the response$/) do
+  expect(@response).to be_truthy
+end

data/features/step_definitions/range_steps.rb

@@ -1,5 +1,5 @@
 Given(/^I have a range within the given reading$/) do
-  @range = FactoryGirl.create(:range, {reading_id: @reading.id, metric_configuration_id: @metric_configuration.id})
+  @range = FactoryGirl.create(:range, {reading_id: @reading.id, metric_configuration_id: @metric_configuration.id, beginning: 1.1, end: 5.1})
 end
 
 Given(/^I have an unsaved range$/) do
@@ -70,3 +70,27 @@ Then(/^the range should no longer exist$/) do
   expect(KalibroClient::Entities::Configurations::KalibroRange.exists?(@range.id)).to be_falsey
 end
 
+When(/^I change the "(.*?)" to "(.*?)"$/) do |attribute, value|
+  @range.send("#{attribute}=", value)
+end
+
+When(/^I ask to update the given range$/) do
+  @range.update
+end
+
+Then(/^I should not receive errors$/) do
+  expect(@range.kalibro_errors).to be_empty
+end
+
+Then(/^I should get the error "(.*?)"$/) do |message|
+  expect(@range.kalibro_errors).to include(message)
+end
+
+Given(/^I have another range within the given reading$/) do
+  @another_range = FactoryGirl.create(:another_range, reading_id: @reading.id, metric_configuration_id: @metric_configuration.id)
+end
+
+When(/^I change the "(.*?)" of the other range to "(.*?)"$/) do |attribute, value|
+  @another_range.send("#{attribute}=", value)
+end
+

data/features/step_definitions/reading_steps.rb

@@ -6,7 +6,7 @@ Given(/^the given reading group has the following readings:$/) do |table|
 end
 
 Given(/^I have a reading within the given reading group$/) do
-  @reading = FactoryGirl.create(:reading, {reading_group_id: @reading_group.id})
+  @reading = FactoryGirl.create(:reading, reading_group_id: @reading_group.id, grade: 10.5)
 end
 
 When(/^I ask for all the readings$/) do

data/features/step_definitions/repository_steps.rb

@@ -1,7 +1,7 @@
 Given(/^the given project has the following Repositories:$/) do |table|
   hash = table.hashes.first
   hash[:project_id] = @project.id
-  hash[:configuration_id] = @configuration.id
+  hash[:kalibro_configuration_id] = @kalibro_configuration.id
 
   @repository = FactoryGirl.create(:repository, hash)
 end

data/lib/kalibro_client/entities/base.rb

@@ -21,17 +21,19 @@ require 'kalibro_client/helpers/request_methods'
 module KalibroClient
   module Entities
     class Base
-      attr_accessor :kalibro_errors
+      attr_accessor :kalibro_errors, :persisted
 
-      def initialize(attributes={})
+      def initialize(attributes={}, persisted=false)
         attributes.each { |field, value| send("#{field}=", value) if self.class.is_valid?(field) }
         @kalibro_errors = []
+        @persisted = persisted
       end
 
       def to_hash(options={})
         hash = Hash.new
         excepts = options[:except].nil? ? [] : options[:except]
         excepts << "kalibro_errors"
+        excepts << "persisted"
         fields.each do |field|
           hash = field_to_hash(field).merge(hash) if !excepts.include?(field)
         end
@@ -52,7 +54,7 @@ module KalibroClient
       end
 
       def self.to_object value
-        value.kind_of?(Hash) ? new(value) : value
+        value.kind_of?(Hash) ? new(value, true) : value
       end
 
       def self.to_objects_array value
@@ -61,17 +63,26 @@ module KalibroClient
       end
 
       def save
-        begin
-          response = self.class.request(save_action, save_params, :post, save_prefix)
-          self.id = response[instance_class_name]["id"]
-          self.kalibro_errors = response["kalibro_errors"] unless response["kalibro_errors"].nil?
-          self.created_at = response[instance_class_name]["created_at"] unless response[instance_class_name]["created_at"].nil?
-          self.updated_at = response[instance_class_name]["updated_at"] unless response[instance_class_name]["updated_at"].nil?
-
-          self.kalibro_errors.empty? ? true : false
-        rescue Exception => exception
-          add_error exception
-          false
+        if persisted?
+          self.update
+        else
+          begin
+            response = self.class.request(save_action, save_params, :post, save_prefix)
+
+            if response["errors"].nil?
+              self.id = response[instance_class_name]["id"]
+              self.created_at = response[instance_class_name]["created_at"] unless response[instance_class_name]["created_at"].nil?
+              self.updated_at = response[instance_class_name]["updated_at"] unless response[instance_class_name]["updated_at"].nil?
+              @persisted = true
+              true
+            else
+              self.kalibro_errors = response["errors"]
+              false
+            end
+          rescue Exception => exception
+            add_error exception
+            false
+          end
         end
       end
 
@@ -85,13 +96,24 @@ module KalibroClient
         new_model
       end
 
+      def update(attributes={})
+        attributes.each { |field, value| send("#{field}=", value) if self.class.is_valid?(field) }
+        response = self.class.request(update_action, update_params, :put, update_prefix)
+        unless response["errors"].nil?
+          response["errors"].each { |error| add_error(error) }
+          false
+        else
+          true
+        end
+      end
+
       def ==(another)
         unless self.class == another.class
           return false
         end
 
         self.variable_names.each do |name|
-          next if name == "created_at" or name == "updated_at"
+          next if name == "created_at" or name == "updated_at" or name == "persisted"
           unless self.send("#{name}") == another.send("#{name}") then
             return false
           end
@@ -107,7 +129,7 @@ module KalibroClient
       def self.find(id)
         if(exists?(id))
           response = request(find_action, id_params(id), :get)
-          new response[entity_name]
+          new(response[entity_name], true)
         else
           raise KalibroClient::Errors::RecordNotFound
         end
@@ -115,8 +137,18 @@ module KalibroClient
 
       def destroy
         begin
-          self.class.request(destroy_action, destroy_params, :delete, destroy_prefix)
-          self.kalibro_errors.empty? ? true : false
+          response = self.class.request(destroy_action, destroy_params, :delete, destroy_prefix)
+
+          unless response['errors'].nil?
+            response['errors'].each { |error| add_error(error) }
+          end
+
+          if self.kalibro_errors.empty?
+            @persisted = false
+            true
+          else
+            false
+          end
         rescue Exception => exception
           add_error exception
           false
@@ -124,7 +156,7 @@ module KalibroClient
       end
 
       def self.create_objects_array_from_hash (response)
-        create_array_from_hash(response[entity_name.pluralize]).map { |hash| new hash }
+        create_array_from_hash(response[entity_name.pluralize]).map { |hash| new(hash, true) }
       end
 
       def self.create_array_from_hash (response)
@@ -133,6 +165,8 @@ module KalibroClient
         response
       end
 
+      alias_method :persisted?, :persisted
+
       protected
 
       def instance_variable_names