judopay 2.1.0 → 2.1.3

data/spec/fixtures/transactions/android_payment.json

@@ -1,26 +1,26 @@
-{
-  "receiptId": "xxxxxxx",
-  "yourPaymentReference": "xxxxxxxxxxxxxxxxxxxxxx",
-  "type": "Payment",
-  "createdAt": "2016-11-03T15:02:26.8290+00:00",
-  "result": "Success",
-  "message": "AuthCode: xxxxxx",
-  "judoId": "xxxxxxxxx",
-  "merchantName": "xxxxxxxxxxxx",
-  "appearsOnStatementAs": "xxxxxxxxxxxxx",
-  "originalAmount": "0.02",
-  "netAmount": "0.02",
-  "amount": "0.02",
-  "currency": "GBP",
-  "cardDetails": {
-    "cardLastfour": "xxxx",
-    "endDate": "xxxx",
-    "cardToken": "xxxx",
-    "cardType": 1
-  },
-  "consumer": {
-    "consumerToken": "xxxxxxxxxxxxxx",
-    "yourConsumerReference": "xxxxxxxxxxxxxxxx"
-  },
-  "walletType": 2
-}
+{
+  "receiptId": "xxxxxxx",
+  "yourPaymentReference": "xxxxxxxxxxxxxxxxxxxxxx",
+  "type": "Payment",
+  "createdAt": "2016-11-03T15:02:26.8290+00:00",
+  "result": "Success",
+  "message": "AuthCode: xxxxxx",
+  "judoId": "xxxxxxxxx",
+  "merchantName": "xxxxxxxxxxxx",
+  "appearsOnStatementAs": "xxxxxxxxxxxxx",
+  "originalAmount": "0.02",
+  "netAmount": "0.02",
+  "amount": "0.02",
+  "currency": "GBP",
+  "cardDetails": {
+    "cardLastfour": "xxxx",
+    "endDate": "xxxx",
+    "cardToken": "xxxx",
+    "cardType": 1
+  },
+  "consumer": {
+    "consumerToken": "xxxxxxxxxxxxxx",
+    "yourConsumerReference": "xxxxxxxxxxxxxxxx"
+  },
+  "walletType": 2
+}

data/spec/fixtures/transactions/apple_payment.json

@@ -1,26 +1,26 @@
-{
-  "receiptId": "someReceipt",
-  "yourPaymentReference": "NEW_PR_123123123",
-  "type": "Payment",
-  "createdAt": "2016-10-31T10:09:10.4378+00:00",
-  "result": "Success",
-  "message": "AuthCode: xxxxxx",
-  "judoId": "someId",
-  "merchantName": "PiePay Project",
-  "appearsOnStatementAs": "APL*\/PiePayProject      ",
-  "originalAmount": "0.02",
-  "netAmount": "0.02",
-  "amount": "0.02",
-  "currency": "GBP",
-  "cardDetails": {
-    "cardLastfour": "xxxx",
-    "endDate": "xxxx",
-    "cardToken": "xxxxxxxxxxxxxx",
-    "cardType": 1
-  },
-  "consumer": {
-    "consumerToken": "xxxxxxxxx",
-    "yourConsumerReference": "Myconsumerref"
-  },
-  "walletType": 1
-}
+{
+  "receiptId": "someReceipt",
+  "yourPaymentReference": "NEW_PR_123123123",
+  "type": "Payment",
+  "createdAt": "2016-10-31T10:09:10.4378+00:00",
+  "result": "Success",
+  "message": "AuthCode: xxxxxx",
+  "judoId": "someId",
+  "merchantName": "PiePay Project",
+  "appearsOnStatementAs": "APL*\/PiePayProject      ",
+  "originalAmount": "0.02",
+  "netAmount": "0.02",
+  "amount": "0.02",
+  "currency": "GBP",
+  "cardDetails": {
+    "cardLastfour": "xxxx",
+    "endDate": "xxxx",
+    "cardToken": "xxxxxxxxxxxxxx",
+    "cardType": 1
+  },
+  "consumer": {
+    "consumerToken": "xxxxxxxxx",
+    "yourConsumerReference": "Myconsumerref"
+  },
+  "walletType": 1
+}

data/spec/fixtures/transactions/find.json

@@ -1,23 +1,23 @@
-{
-    "receiptId": "439539",
-    "type": "Payment",
-    "createdAt": "2014-06-17T14:56:49.7571+01:00",
-    "result": "Success",
-    "message": "AuthCode: 210658",
-    "judoId": 100016,
-    "merchantName": "Judo Pay test",
-    "appearsOnStatementAs": "JudoPay/JudoPayt",
-    "netAmount": 1.01,
-    "amount": 1.01,
-    "currency": "GBP",
-    "cardDetails": {
-        "cardLastfour": "5462",
-        "endDate": "1215",
-        "cardType": 11
-    },
-    "consumer": {
-        "consumerToken": "HUClqv3MSdCh6g5M",
-        "yourConsumerReference": "WebPayDemo_17/06/2014 14:56:53 +01:00"
-    },
-    "yourPaymentMetaData": {}
+{
+    "receiptId": "439539",
+    "type": "Payment",
+    "createdAt": "2014-06-17T14:56:49.7571+01:00",
+    "result": "Success",
+    "message": "AuthCode: 210658",
+    "judoId": 100016,
+    "merchantName": "Judo Pay test",
+    "appearsOnStatementAs": "JudoPay/JudoPayt",
+    "netAmount": 1.01,
+    "amount": 1.01,
+    "currency": "GBP",
+    "cardDetails": {
+        "cardLastfour": "5462",
+        "endDate": "1215",
+        "cardType": 11
+    },
+    "consumer": {
+        "consumerToken": "HUClqv3MSdCh6g5M",
+        "yourConsumerReference": "WebPayDemo_17/06/2014 14:56:53 +01:00"
+    },
+    "yourPaymentMetaData": {}
 }

data/spec/fixtures/transactions/find_not_found.json

@@ -1,5 +1,5 @@
-{
-    "errorMessage": "No transaction found for receipt id",
-    "errorType": 19,
-    "modelErrors": []
+{
+    "errorMessage": "No transaction found for receipt id",
+    "errorType": 19,
+    "modelErrors": []
 }

data/spec/fixtures/transactions/register_card.json

@@ -1,29 +1,29 @@
-{
-  "receiptId": "5050240",
-  "yourPaymentReference": "Judo_RegisterCardPreAuth_636059257945294942",
-  "type": "PreAuth",
-  "createdAt": "2016-08-04T16:43:14.7482+01:00",
-  "result": "Success",
-  "message": "AuthCode: 910333",
-  "judoId": 100435197,
-  "merchantName": "Oleg",
-  "appearsOnStatementAs": "APL\/Oleg    ",
-  "originalAmount": "1.01",
-  "amountCollected": "0.00",
-  "netAmount": "1.01",
-  "amount": "1.01",
-  "currency": "GBP",
-  "cardDetails": {
-    "cardLastfour": "3436",
-    "endDate": "1220",
-    "cardToken": "123123123",
-    "cardType": 1
-  },
-  "consumer": {
-    "consumerToken": "123123123",
-    "yourConsumerReference": "12345"
-  },
-  "risks": {
-    "postCodeCheck": "UNKNOWN"
-  }
+{
+  "receiptId": "5050240",
+  "yourPaymentReference": "Judo_RegisterCardPreAuth_636059257945294942",
+  "type": "PreAuth",
+  "createdAt": "2016-08-04T16:43:14.7482+01:00",
+  "result": "Success",
+  "message": "AuthCode: 910333",
+  "judoId": 100435197,
+  "merchantName": "Oleg",
+  "appearsOnStatementAs": "APL\/Oleg    ",
+  "originalAmount": "1.01",
+  "amountCollected": "0.00",
+  "netAmount": "1.01",
+  "amount": "1.01",
+  "currency": "GBP",
+  "cardDetails": {
+    "cardLastfour": "3436",
+    "endDate": "1220",
+    "cardToken": "123123123",
+    "cardType": 1
+  },
+  "consumer": {
+    "consumerToken": "123123123",
+    "yourConsumerReference": "12345"
+  },
+  "risks": {
+    "postCodeCheck": "UNKNOWN"
+  }
 }

data/spec/fixtures/transactions/save_card.json

@@ -1,28 +1,28 @@
-{
-  "receiptId": "123123123",
-  "yourPaymentReference": "Judo_RegisterCard_636051228548063948",
-  "type": "Register",
-  "createdAt": "2016-07-26T09:40:54.9313+01:00",
-  "result": "Success",
-  "message": "Register Card",
-  "judoId": 323123123,
-  "merchantName": "SomeMerch",
-  "appearsOnStatementAs": "APL123",
-  "originalAmount": "0.00",
-  "netAmount": "0.00",
-  "amount": "0.00",
-  "currency": "GBP",
-  "cardDetails": {
-    "cardLastfour": "3436",
-    "endDate": "1220",
-    "cardToken": "abc",
-    "cardType": 1
-  },
-  "consumer": {
-    "consumerToken": "abc",
-    "yourConsumerReference": "12345"
-  },
-  "risks": {
-    "postCodeCheck": "UNKNOWN"
-  }
+{
+  "receiptId": "123123123",
+  "yourPaymentReference": "Judo_RegisterCard_636051228548063948",
+  "type": "Register",
+  "createdAt": "2016-07-26T09:40:54.9313+01:00",
+  "result": "Success",
+  "message": "Register Card",
+  "judoId": 323123123,
+  "merchantName": "SomeMerch",
+  "appearsOnStatementAs": "APL123",
+  "originalAmount": "0.00",
+  "netAmount": "0.00",
+  "amount": "0.00",
+  "currency": "GBP",
+  "cardDetails": {
+    "cardLastfour": "3436",
+    "endDate": "1220",
+    "cardToken": "abc",
+    "cardType": 1
+  },
+  "consumer": {
+    "consumerToken": "abc",
+    "yourConsumerReference": "12345"
+  },
+  "risks": {
+    "postCodeCheck": "UNKNOWN"
+  }
 }

data/spec/fixtures/transactions/void.json

@@ -1,27 +1,27 @@
-{
-  "receiptId": "XXXXXX",
-  "originalReceiptId": "12345",
-  "yourPaymentReference": "12345",
-  "type": "VOID",
-  "createdAt": "2016-08-11T13:30:38.1849+01:00",
-  "result": "Success",
-  "message": "Void successful",
-  "judoId": 123123123,
-  "merchantName": "xxxx",
-  "appearsOnStatementAs": "xxxxxxx",
-  "originalAmount": "1.02",
-  "amountCollected": "0.00",
-  "netAmount": "1.02",
-  "amount": "1.02",
-  "currency": "GBP",
-  "cardDetails": {
-    "cardLastfour": "3436",
-    "endDate": "1220",
-    "cardToken": "xxxxxxxxxxxxxxxxxxxx",
-    "cardType": 1
-  },
-  "consumer": {
-    "consumerToken": "xxxxxxxxxxxxxxxx",
-    "yourConsumerReference": "12345"
-  }
+{
+  "receiptId": "XXXXXX",
+  "originalReceiptId": "12345",
+  "yourPaymentReference": "12345",
+  "type": "VOID",
+  "createdAt": "2016-08-11T13:30:38.1849+01:00",
+  "result": "Success",
+  "message": "Void successful",
+  "judoId": 123123123,
+  "merchantName": "xxxx",
+  "appearsOnStatementAs": "xxxxxxx",
+  "originalAmount": "1.02",
+  "amountCollected": "0.00",
+  "netAmount": "1.02",
+  "amount": "1.02",
+  "currency": "GBP",
+  "cardDetails": {
+    "cardLastfour": "3436",
+    "endDate": "1220",
+    "cardToken": "xxxxxxxxxxxxxxxxxxxx",
+    "cardType": 1
+  },
+  "consumer": {
+    "consumerToken": "xxxxxxxxxxxxxxxx",
+    "yourConsumerReference": "12345"
+  }
 }

data/spec/fixtures/web_payments/payments/create.json

@@ -1,4 +1,4 @@
-{
-  "postUrl": "https://pay.judopay-sandbox.com/",
-  "reference": "4gcBAAMAGAASAAAADA66kRor6ofknGqU3A6i-759FprFGPH3ecVcW5ChMQK0f3pLBQ"
+{
+  "postUrl": "https://pay.judopay-sandbox.com/",
+  "reference": "4gcBAAMAGAASAAAADA66kRor6ofknGqU3A6i-759FprFGPH3ecVcW5ChMQK0f3pLBQ"
 }

data/spec/fixtures/web_payments/payments/find.json

@@ -1,39 +1,39 @@
-{
-  "reference": "4gcBAAMAGAASAAAADA66kRor6ofknGqU3A6i-759FprFGPH3ecVcW5ChMQK0f3pLBQ",
-  "status": "Open",
-  "transactionType": "Payment",
-  "judoId": "1234-4567",
-  "amount": 12.34,
-  "currency": "GBP",
-  "expiryDate": "2014-03-18T14:35:54.5428+00:00",
-  "companyName": "AnyMerchant Ltd",
-  "yourConsumerReference": "consumer0053252",
-  "yourPaymentReference": "payment12412312",
-  "yourPaymentMetaData": {},
-  "response": {
-    "postUrl": "http://pay.judopay-sandbox.com/",
-    "reference": "4gcBAAMAGAASAAAADA66kRor6ofknGqU3A6i-759FprFGPH3ecVcW5ChMQK0f3pLBQ"
-  },
-  "cardAddress": "",
-  "clientIpAddress": "127.0.0.1",
-  "clientUserAgent": "Mozilla/5.0 (Windows NT 6.2; Win64; x64)...",
-  "paymentSuccessUrl": "http://www.yourcompany.co.uk/success",
-  "paymentCancelUrl": "http://www.yourcompany.co.uk/cancel",
-  "receipt": {
-    "receiptId": "1234",
-    "type": "Payment",
-    "createdAt": "2012-12-05T14:40:53.4529+00:00",
-    "result": "Success",
-    "message": "Payment was successful",
-    "judoId": "123-4567",
-    "merchantName": "AnyMerchant Ltd",
-    "appearsOnStatementAs": "Judo Payments/AnyMerch",
-    "refunds": 0.00,
-    "netAmount": 12.34,
-    "cardDetails": {
-      "cardLastFour": "3436",
-      "endDate": "12/15",
-      "cardType": 1
-    }
-  }
+{
+  "reference": "4gcBAAMAGAASAAAADA66kRor6ofknGqU3A6i-759FprFGPH3ecVcW5ChMQK0f3pLBQ",
+  "status": "Open",
+  "transactionType": "Payment",
+  "judoId": "1234-4567",
+  "amount": 12.34,
+  "currency": "GBP",
+  "expiryDate": "2014-03-18T14:35:54.5428+00:00",
+  "companyName": "AnyMerchant Ltd",
+  "yourConsumerReference": "consumer0053252",
+  "yourPaymentReference": "payment12412312",
+  "yourPaymentMetaData": {},
+  "response": {
+    "postUrl": "http://pay.judopay-sandbox.com/",
+    "reference": "4gcBAAMAGAASAAAADA66kRor6ofknGqU3A6i-759FprFGPH3ecVcW5ChMQK0f3pLBQ"
+  },
+  "cardAddress": "",
+  "clientIpAddress": "127.0.0.1",
+  "clientUserAgent": "Mozilla/5.0 (Windows NT 6.2; Win64; x64)...",
+  "paymentSuccessUrl": "http://www.yourcompany.co.uk/success",
+  "paymentCancelUrl": "http://www.yourcompany.co.uk/cancel",
+  "receipt": {
+    "receiptId": "1234",
+    "type": "Payment",
+    "createdAt": "2012-12-05T14:40:53.4529+00:00",
+    "result": "Success",
+    "message": "Payment was successful",
+    "judoId": "123-4567",
+    "merchantName": "AnyMerchant Ltd",
+    "appearsOnStatementAs": "Judo Payments/AnyMerch",
+    "refunds": 0.00,
+    "netAmount": 12.34,
+    "cardDetails": {
+      "cardLastFour": "3436",
+      "endDate": "12/15",
+      "cardType": 1
+    }
+  }
 }

data/spec/judopay/android_payment_spec.rb

@@ -1,74 +1,74 @@
-require 'spec_helper'
-require_relative '../../lib/judopay/models/android_payment'
-
-describe Judopay::AndroidPayment do
-  it 'should create a new payment given wallet object' do
-    stub_post('/transactions/payments').
-      to_return(:status => 200,
-                :body => lambda { |_request| fixture('transactions/android_payment.json') })
-
-    payment = build(:android_payment)
-    response = payment.create
-
-    expect(response).to be_a(Hash)
-    expect(response.result).to eq('Success')
-  end
-
-  it 'should return a bad request exception if basic validation fails' do
-    expect(lambda do
-      Judopay::AndroidPayment.new.create
-    end).to raise_error(Judopay::ValidationError)
-  end
-
-  it 'should use the configured Judo ID if one isn\'t provided in the payment request' do
-    stub_post('/transactions/payments').
-      to_return(:status => 200,
-                :body => lambda { |_request| fixture('transactions/android_payment.json') })
-
-    Judopay.configure do |config|
-      config.judo_id = '123-456'
-    end
-
-    payment = build(:android_payment, :judo_id => nil)
-    payment.create
-
-    expect(payment.valid?).to eq(true)
-    expect(payment.judo_id).to eq('123-456')
-  end
-
-  it 'properly coerces wallet field from_json' do
-    json_string = '{"wallet":{"encryptedMessage":"SomeBase64encodedData","environment":1,'\
-      '"ephemeralPublicKey":"SomeBase64encodedData","googleTransactionId":"someId",'\
-      '"instrumentDetails":"1234","instrumentType":"VISA","publicKey":"SomeBase64encodedData",'\
-      '"tag":"SomeBase64encodedData","version":1}}'
-
-    wallet = Judopay::Wallet.new(
-      :encrypted_message => 'SomeBase64encodedData',
-      :environment => 1,
-      :ephemeral_public_key => 'SomeBase64encodedData',
-      :google_transaction_id => 'someId',
-      :instrument_details => '1234',
-      :instrument_type => 'VISA',
-      :publicKey => 'SomeBase64encodedData',
-      :tag => 'SomeBase64encodedData',
-      :version => 1
-    )
-
-    payment = build(:android_payment, :wallet => json_string)
-    expect(payment.wallet).to be == wallet
-  end
-
-  it 'should raise an error when bad wallet passed' do
-    expect(lambda do
-      Judopay::AndroidPayment.new(:wallet => '{"someInvalidJson}}')
-    end).to raise_error(Judopay::ValidationError, format(Judopay::Wallet::WRONG_JSON_ERROR_MESSAGE, 'Judopay::Wallet'))
-
-    expect(lambda do
-      Judopay::AndroidPayment.new(:wallet => 1)
-    end).to raise_error(Judopay::ValidationError, format(Judopay::Wallet::WRONG_OBJECT_ERROR_MESSAGE, 'Judopay::Wallet'))
-
-    expect(lambda do
-      build(:android_payment, :wallet => '{"valid_json":"Without token field"}').create
-    end).to raise_error(Judopay::ValidationError)
-  end
-end
+require 'spec_helper'
+require_relative '../../lib/judopay/models/android_payment'
+
+describe Judopay::AndroidPayment do
+  it 'should create a new payment given wallet object' do
+    stub_post('/transactions/payments').
+      to_return(:status => 200,
+                :body => lambda { |_request| fixture('transactions/android_payment.json') })
+
+    payment = build(:android_payment)
+    response = payment.create
+
+    expect(response).to be_a(Hash)
+    expect(response.result).to eq('Success')
+  end
+
+  it 'should return a bad request exception if basic validation fails' do
+    expect(lambda do
+      Judopay::AndroidPayment.new.create
+    end).to raise_error(Judopay::ValidationError)
+  end
+
+  it 'should use the configured Judo ID if one isn\'t provided in the payment request' do
+    stub_post('/transactions/payments').
+      to_return(:status => 200,
+                :body => lambda { |_request| fixture('transactions/android_payment.json') })
+
+    Judopay.configure do |config|
+      config.judo_id = '123-456'
+    end
+
+    payment = build(:android_payment, :judo_id => nil)
+    payment.create
+
+    expect(payment.valid?).to eq(true)
+    expect(payment.judo_id).to eq('123-456')
+  end
+
+  it 'properly coerces wallet field from_json' do
+    json_string = '{"wallet":{"encryptedMessage":"SomeBase64encodedData","environment":1,'\
+      '"ephemeralPublicKey":"SomeBase64encodedData","googleTransactionId":"someId",'\
+      '"instrumentDetails":"1234","instrumentType":"VISA","publicKey":"SomeBase64encodedData",'\
+      '"tag":"SomeBase64encodedData","version":1}}'
+
+    wallet = Judopay::Wallet.new(
+      :encrypted_message => 'SomeBase64encodedData',
+      :environment => 1,
+      :ephemeral_public_key => 'SomeBase64encodedData',
+      :google_transaction_id => 'someId',
+      :instrument_details => '1234',
+      :instrument_type => 'VISA',
+      :publicKey => 'SomeBase64encodedData',
+      :tag => 'SomeBase64encodedData',
+      :version => 1
+    )
+
+    payment = build(:android_payment, :wallet => json_string)
+    expect(payment.wallet).to be == wallet
+  end
+
+  it 'should raise an error when bad wallet passed' do
+    expect(lambda do
+      Judopay::AndroidPayment.new(:wallet => '{"someInvalidJson}}')
+    end).to raise_error(Judopay::ValidationError, format(Judopay::Wallet::WRONG_JSON_ERROR_MESSAGE, :foo => 'Judopay::Wallet'))
+
+    expect(lambda do
+      Judopay::AndroidPayment.new(:wallet => 1)
+    end).to raise_error(Judopay::ValidationError, format(Judopay::Wallet::WRONG_OBJECT_ERROR_MESSAGE, :foo => 'Judopay::Wallet'))
+
+    expect(lambda do
+      build(:android_payment, :wallet => '{"valid_json":"Without token field"}').create
+    end).to raise_error(Judopay::ValidationError)
+  end
+end