judopay 2.1.0 → 2.1.3

data/spec/judopay/web_payments/transaction_spec.rb

@@ -1,15 +1,15 @@
-require 'spec_helper'
-require_relative '../../../lib/judopay/models/web_payments/transaction'
-
-describe Judopay::WebPayments::Transaction do
-  it 'should give details of a single web transaction given a valid reference' do
-    reference = '4gcBAAMAGAASAAAADA66kRor6ofknGqU3A6i-759FprFGPH3ecVcW5ChMQK0f3pLBQ'
-    stub_get('/webpayments/' + reference).
-      to_return(:status => 200,
-                :body => lambda { |_request| fixture('web_payments/payments/find.json') })
-
-    payment = Judopay::WebPayments::Transaction.find(reference)
-    expect(payment).to be_a(Hash)
-    expect(payment.reference).to eq(reference)
-  end
-end
+require 'spec_helper'
+require_relative '../../../lib/judopay/models/web_payments/transaction'
+
+describe Judopay::WebPayments::Transaction do
+  it 'should give details of a single web transaction given a valid reference' do
+    reference = '4gcBAAMAGAASAAAADA66kRor6ofknGqU3A6i-759FprFGPH3ecVcW5ChMQK0f3pLBQ'
+    stub_get('/webpayments/' + reference).
+      to_return(:status => 200,
+                :body => lambda { |_request| fixture('web_payments/payments/find.json') })
+
+    payment = Judopay::WebPayments::Transaction.find(reference)
+    expect(payment).to be_a(Hash)
+    expect(payment.reference).to eq(reference)
+  end
+end

data/spec/spec_helper.rb

@@ -1,41 +1,41 @@
-require_relative '../lib/judopay'
-require 'i18n'
-
-require 'factory_girl'
-require 'factories'
-require 'webmock/rspec'
-
-# Added to counter deprecation warning
-I18n.enforce_available_locales = true
-
-RSpec.configure do |config|
-  config.include FactoryGirl::Syntax::Methods
-  config.include WebMock::API
-
-  config.expect_with :rspec do |c|
-    c.syntax = [:expect, :should]
-  end
-end
-
-# Mock configuration
-Judopay.configure do |config|
-  config.judo_id = 'id'
-  config.api_token = 'token'
-  config.api_secret = 'secret'
-end
-
-def stub_get(path)
-  stub_request(:get, /judopay/i)
-end
-
-def stub_post(path)
-  stub_request(:post, /judopay/i)
-end
-
-def fixture_path
-  File.expand_path('../fixtures', __FILE__)
-end
-
-def fixture(file)
-  File.new(fixture_path + '/' + file)
-end
+require_relative '../lib/judopay'
+require 'i18n'
+
+require 'factory_bot'
+require 'factories'
+require 'webmock/rspec'
+
+# Added to counter deprecation warning
+I18n.enforce_available_locales = true
+
+RSpec.configure do |config|
+  config.include FactoryBot::Syntax::Methods
+  config.include WebMock::API
+
+  config.expect_with :rspec do |c|
+    c.syntax = [:expect, :should]
+  end
+end
+
+# Mock configuration
+Judopay.configure do |config|
+  config.judo_id = 'id'
+  config.api_token = 'token'
+  config.api_secret = 'secret'
+end
+
+def stub_get(path)
+  stub_request(:get, /judopay/i)
+end
+
+def stub_post(path)
+  stub_request(:post, /judopay/i)
+end
+
+def fixture_path
+  File.expand_path('../fixtures', __FILE__)
+end
+
+def fixture(file)
+  File.new(fixture_path + '/' + file)
+end

data/test/additions_payment_test.rb

@@ -0,0 +1,30 @@
+require_relative 'base/integration_base'
+
+class AdditionsPaymentTest < IntegrationBase
+  def test_one_use_token_payment
+    generated_token = generate_and_validate_token
+    successfully_use_one_use_token(generated_token)
+    cannot_reuse_one_use_token(generated_token)
+  end
+
+  def generate_and_validate_token
+    encryption = build(:encrypt_details, {}).create
+    assert_not_nil(encryption)
+    generated_token = encryption['oneUseToken']
+    assert_not_nil(generated_token)
+    generated_token
+  end
+
+  def successfully_use_one_use_token(generated_token)
+    encrypted_payment = build(:one_use_token_payment, :one_use_token => generated_token).create
+    assert_not_nil(encrypted_payment)
+    assert_equal('Success', encrypted_payment['result'])
+  end
+
+  def cannot_reuse_one_use_token(generated_token)
+    second_encrypted_payment = build(:one_use_token_payment, :one_use_token => generated_token)
+    assert_raise(Judopay::APIError.new('The one time token is not valid. It could have expired. Please try again')) do
+      second_encrypted_payment.create
+    end
+  end
+end

data/test/authentication_test.rb

@@ -1,23 +1,23 @@
-require 'base/integration_base'
-
-class AuthenticationTest < IntegrationBase
-  def test_payment_with_invalid_judo_id
-    payment = build(:card_payment, :judo_id => 123)
-
-    AssertionHelper.api_exception_with_errors(1, 1) { payment.create }
-  end
-
-  def test_payment_with_invalid_token
-    Judopay.configuration.api_token = 'Bad_token'
-    payment = build(:card_payment)
-
-    AssertionHelper.api_exception_with_errors(0, 403, 403, 1) { payment.create }
-  end
-
-  def test_payment_with_invalid_secret
-    Judopay.configuration.api_secret = 'Bad_secret'
-    payment = build(:card_payment)
-
-    AssertionHelper.api_exception_with_errors(0, 403, 403, 1) { payment.create }
-  end
-end
+require_relative 'base/integration_base'
+
+class AuthenticationTest < IntegrationBase
+  def test_payment_with_invalid_judo_id
+    payment = build(:card_payment, :judo_id => 123)
+
+    AssertionHelper.api_exception_with_errors(1, 1) { payment.create }
+  end
+
+  def test_payment_with_invalid_token
+    Judopay.configuration.api_token = 'Bad_token'
+    payment = build(:card_payment)
+
+    AssertionHelper.api_exception_with_errors(0, 403, 403, 1) { payment.create }
+  end
+
+  def test_payment_with_invalid_secret
+    Judopay.configuration.api_secret = 'Bad_secret'
+    payment = build(:card_payment)
+
+    AssertionHelper.api_exception_with_errors(0, 403, 403, 1) { payment.create }
+  end
+end

data/test/base/integration_base.rb

@@ -1,20 +1,20 @@
-require 'test/unit'
-require 'judopay'
-require 'judopay/error'
-require 'factory_girl'
-require_relative '../../spec/factories'
-require_relative '../helper/assertion_helper'
-
-class IntegrationBase < Test::Unit::TestCase
-  include FactoryGirl::Syntax::Methods
-  include TestHelpers
-
-  def setup
-    Judopay.configure do |config|
-      config.judo_id = ENV['JUDO_API_ID']
-      config.api_token = ENV['JUDO_API_TOKEN']
-      config.api_secret = ENV['JUDO_API_SECRET']
-      config.use_production = false
-    end
-  end
-end
+require 'test/unit'
+require 'judopay'
+require 'judopay/error'
+require 'factory_bot'
+require_relative '../../spec/factories'
+require_relative '../helper/assertion_helper'
+
+class IntegrationBase < Test::Unit::TestCase
+  include FactoryBot::Syntax::Methods
+  include TestHelpers
+
+  def setup
+    Judopay.configure do |config|
+      config.judo_id = ENV['JUDO_API_ID']
+      config.api_token = ENV['JUDO_API_TOKEN']
+      config.api_secret = ENV['JUDO_API_SECRET']
+      config.use_production = false
+    end
+  end
+end

data/test/base/payments_tests.rb

@@ -1,47 +1,47 @@
-require_relative '../base/integration_base'
-require_relative '../helper/assertion_helper'
-
-module PaymentTests
-  def test_valid_payment
-    result = get_model.create
-
-    TestHelpers::AssertionHelper.assert_successful_payment(result)
-  end
-
-  def test_declined_payment
-    result = get_model(:declined).create
-
-    TestHelpers::AssertionHelper.assert_declined_payment(result)
-  end
-
-  def test_payment_with_negative_amount
-    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => -1.0).create }
-  end
-
-  def test_payment_with_zero_amount
-    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => 0).create }
-  end
-
-  def test_payment_without_currency
-    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\ncurrency: can't be blank")) do
-      get_model(:currency => nil).create
-    end
-  end
-
-  def test_payment_with_unknown_currency
-    TestHelpers::AssertionHelper.api_exception_with_errors(2, 1) { get_model(:currency => 'ZZZ').create }
-  end
-
-  def test_payment_without_reference
-    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\nyour_consumer_reference: can't be blank")) do
-      get_model(:your_consumer_reference => nil).create
-    end
-  end
-
-  def test_duplicate_payment
-    model = get_model
-    TestHelpers::AssertionHelper.assert_successful_payment(model.create)
-
-    TestHelpers::AssertionHelper.api_exception_with_errors(1, 86, 409, 4) { model.create }
-  end
-end
+require_relative '../base/integration_base'
+require_relative '../helper/assertion_helper'
+
+module PaymentTests
+  def test_valid_payment
+    result = get_model.create
+
+    TestHelpers::AssertionHelper.assert_successful_payment(result)
+  end
+
+  def test_declined_payment
+    result = get_model(:declined).create
+
+    TestHelpers::AssertionHelper.assert_declined_payment(result)
+  end
+
+  def test_payment_with_negative_amount
+    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => -1.0).create }
+  end
+
+  def test_payment_with_zero_amount
+    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => 0).create }
+  end
+
+  def test_payment_without_currency
+    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\ncurrency: can't be blank")) do
+      get_model(:currency => nil).create
+    end
+  end
+
+  def test_payment_with_unknown_currency
+    TestHelpers::AssertionHelper.api_exception_with_errors(2, 1) { get_model(:currency => 'ZZZ').create }
+  end
+
+  def test_payment_without_reference
+    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\nyour_consumer_reference: can't be blank")) do
+      get_model(:your_consumer_reference => nil).create
+    end
+  end
+
+  def test_duplicate_payment
+    model = get_model
+    TestHelpers::AssertionHelper.assert_successful_payment(model.create)
+
+    TestHelpers::AssertionHelper.api_exception_with_errors(1, 86, 409, 4) { model.create }
+  end
+end

data/test/base/token_payment_tests.rb

@@ -1,98 +1,98 @@
-require_relative '../base/integration_base'
-require_relative '../helper/assertion_helper'
-
-module TokenPaymentTests
-  def setup
-    super
-    payment = build(:card_payment)
-    result = payment.create
-
-    TestHelpers::AssertionHelper.assert_successful_payment(result)
-
-    @card_token = result['cardDetails']['cardToken']
-    @consumer_token = result['consumer']['consumerToken']
-  end
-
-  def test_valid_token_payment
-    response = get_model.create
-
-    TestHelpers::AssertionHelper.assert_successful_payment(response)
-  end
-
-  def test_declined_token_payment
-    response = get_model(:cv2 => '666').create
-
-    TestHelpers::AssertionHelper.assert_declined_payment(response)
-  end
-
-  def test_token_payment_without_token
-    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\ncard_token: can't be blank")) do
-      get_model(:card_token => nil).create
-    end
-  end
-
-  def test_token_payment_without_cv2_and_without_token
-    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\ncard_token: can't be blank")) do
-      get_model(:card_token => nil, :cv2 => nil).create
-    end
-  end
-
-  def test_payment_with_negative_amount
-    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => -1.0).create }
-  end
-
-  def test_payment_with_zero_amount
-    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => 0).create }
-  end
-
-  def test_payment_without_currency
-    response = get_model(:currency => nil).create
-    TestHelpers::AssertionHelper.assert_successful_payment(response)
-  end
-
-  def test_payment_with_unknown_currency
-    TestHelpers::AssertionHelper.api_exception_with_errors(2, 1) { get_model(:currency => 'ZZZ').create }
-  end
-
-  def test_payment_without_reference
-    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\nyour_consumer_reference: can't be blank")) do
-      get_model(:your_consumer_reference => nil).create
-    end
-  end
-
-  def test_declined_token_payment_without_cv2
-    response = get_model(:cv2 => nil).create
-
-    TestHelpers::AssertionHelper.assert_declined_payment(response)
-  end
-
-  def test_token_payment_without_cv2_and_with_negative_amount
-    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => -1, :cv2 => nil).create }
-  end
-
-  def test_token_payment_without_cv2_and_with_zero_amount
-    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => 0, :cv2 => nil).create }
-  end
-
-  def test_token_payment_without_cv2_and_without_currency
-    response = get_model(:cv2 => nil, :currency => nil).create
-    TestHelpers::AssertionHelper.assert_declined_payment(response)
-  end
-
-  def test_token_payment_without_cv2_and_with_unknown_currency
-    TestHelpers::AssertionHelper.api_exception_with_errors(2, 1) { get_model(:cv2 => nil, :currency => 'ZZZ').create }
-  end
-
-  def test_token_payment_without_cv2_and_without_reference
-    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\nyour_consumer_reference: can't be blank")) do
-      get_model(:your_consumer_reference => nil, :cv2 => nil).create
-    end
-  end
-
-  def test_duplicate_payment
-    model = get_model
-    TestHelpers::AssertionHelper.assert_successful_payment(model.create)
-
-    TestHelpers::AssertionHelper.api_exception_with_errors(1, 86, 409, 4) { model.create }
-  end
-end
+require_relative '../base/integration_base'
+require_relative '../helper/assertion_helper'
+
+module TokenPaymentTests
+  def setup
+    super
+    payment = build(:card_payment)
+    result = payment.create
+
+    TestHelpers::AssertionHelper.assert_successful_payment(result)
+
+    @card_token = result['cardDetails']['cardToken']
+    @consumer_token = result['consumer']['consumerToken']
+  end
+
+  def test_valid_token_payment
+    response = get_model.create
+
+    TestHelpers::AssertionHelper.assert_successful_payment(response)
+  end
+
+  def test_declined_token_payment
+    response = get_model(:cv2 => '666').create
+
+    TestHelpers::AssertionHelper.assert_declined_payment(response)
+  end
+
+  def test_token_payment_without_token
+    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\ncard_token: can't be blank")) do
+      get_model(:card_token => nil).create
+    end
+  end
+
+  def test_token_payment_without_cv2_and_without_token
+    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\ncard_token: can't be blank")) do
+      get_model(:card_token => nil, :cv2 => nil).create
+    end
+  end
+
+  def test_payment_with_negative_amount
+    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => -1.0).create }
+  end
+
+  def test_payment_with_zero_amount
+    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => 0).create }
+  end
+
+  def test_payment_without_currency
+    response = get_model(:currency => nil).create
+    TestHelpers::AssertionHelper.assert_successful_payment(response)
+  end
+
+  def test_payment_with_unknown_currency
+    TestHelpers::AssertionHelper.api_exception_with_errors(2, 1) { get_model(:currency => 'ZZZ').create }
+  end
+
+  def test_payment_without_reference
+    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\nyour_consumer_reference: can't be blank")) do
+      get_model(:your_consumer_reference => nil).create
+    end
+  end
+
+  def test_declined_token_payment_without_cv2
+    response = get_model(:cv2 => nil).create
+
+    TestHelpers::AssertionHelper.assert_declined_payment(response)
+  end
+
+  def test_token_payment_without_cv2_and_with_negative_amount
+    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => -1, :cv2 => nil).create }
+  end
+
+  def test_token_payment_without_cv2_and_with_zero_amount
+    TestHelpers::AssertionHelper.api_exception_with_errors(1, 1) { get_model(:amount => 0, :cv2 => nil).create }
+  end
+
+  def test_token_payment_without_cv2_and_without_currency
+    response = get_model(:cv2 => nil, :currency => nil).create
+    TestHelpers::AssertionHelper.assert_declined_payment(response)
+  end
+
+  def test_token_payment_without_cv2_and_with_unknown_currency
+    TestHelpers::AssertionHelper.api_exception_with_errors(2, 1) { get_model(:cv2 => nil, :currency => 'ZZZ').create }
+  end
+
+  def test_token_payment_without_cv2_and_without_reference
+    assert_raise(Judopay::ValidationError.new("Missing required fields\nField errors:\nyour_consumer_reference: can't be blank")) do
+      get_model(:your_consumer_reference => nil, :cv2 => nil).create
+    end
+  end
+
+  def test_duplicate_payment
+    model = get_model
+    TestHelpers::AssertionHelper.assert_successful_payment(model.create)
+
+    TestHelpers::AssertionHelper.api_exception_with_errors(1, 86, 409, 4) { model.create }
+  end
+end