jr-paperclip 7.3.0

data/spec/paperclip/validators/attachment_file_name_validator_spec.rb

@@ -0,0 +1,249 @@
+require "spec_helper"
+
+describe Paperclip::Validators::AttachmentFileNameValidator do
+  before do
+    rebuild_model
+    @dummy = Dummy.new
+  end
+
+  def build_validator(options)
+    @validator = Paperclip::Validators::AttachmentFileNameValidator.new(options.merge(
+                                                                          attributes: :avatar
+                                                                        ))
+  end
+
+  context "with a failing validation" do
+    before do
+      build_validator matches: /.*\.png$/, allow_nil: false
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+    end
+
+    it "adds error to the base object" do
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+    end
+
+    it "adds error to base object as a string" do
+      expect(@dummy.errors[:avatar].first).to be_a String
+    end
+  end
+
+  context "with add_validation_errors_to not set (implicitly :both)" do
+    it "adds error to both attribute and base" do
+      build_validator matches: /.*\.png$/, allow_nil: false
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_file_name].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :attribute globally" do
+    before do
+      Paperclip.options[:add_validation_errors_to] = :attribute
+    end
+
+    after do
+      Paperclip.options[:add_validation_errors_to] = :both
+    end
+
+    it "only adds error to attribute not base" do
+      build_validator matches: /.*\.png$/, allow_nil: false
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_file_name].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].blank?,
+             "Error added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :base globally" do
+    before do
+      Paperclip.options[:add_validation_errors_to] = :base
+    end
+
+    after do
+      Paperclip.options[:add_validation_errors_to] = :both
+    end
+
+    it "only adds error to base not attribute" do
+      build_validator matches: /.*\.png$/, allow_nil: false
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+
+      assert @dummy.errors[:avatar_file_name].blank?,
+             "Error added to attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :attribute" do
+    it "only adds error to attribute not base" do
+      build_validator matches: /.*\.png$/, allow_nil: false,
+                      add_validation_errors_to: :attribute
+
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_file_name].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].blank?,
+             "Error added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :base" do
+    it "only adds error to base not attribute" do
+      build_validator matches: /.*\.png$/, allow_nil: false,
+                      add_validation_errors_to: :base
+
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+
+      assert @dummy.errors[:avatar_file_name].blank?,
+             "Error added to attribute"
+    end
+  end
+
+  it "does not add error to the base object with a successful validation" do
+    build_validator matches: /.*\.png$/, allow_nil: false
+    allow(@dummy).to receive_messages(avatar_file_name: "image.png")
+    @validator.validate(@dummy)
+
+    assert @dummy.errors[:avatar].blank?, "Error was added to base attribute"
+  end
+
+  context "whitelist format" do
+    context "with an allowed type" do
+      context "as a single regexp" do
+        before do
+          build_validator matches: /.*\.jpg$/
+          allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
+          @validator.validate(@dummy)
+        end
+
+        it "does not set an error message" do
+          assert @dummy.errors[:avatar_file_name].blank?
+        end
+      end
+
+      context "as a list" do
+        before do
+          build_validator matches: [/.*\.png$/, /.*\.jpe?g$/]
+          allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
+          @validator.validate(@dummy)
+        end
+
+        it "does not set an error message" do
+          assert @dummy.errors[:avatar_file_name].blank?
+        end
+      end
+    end
+
+    context "with a disallowed type" do
+      it "sets a correct default error message" do
+        build_validator matches: /^text\/.*/
+        allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
+        @validator.validate(@dummy)
+
+        assert @dummy.errors[:avatar_file_name].present?
+        expect(@dummy.errors[:avatar_file_name]).to include "is invalid"
+      end
+
+      it "sets a correct custom error message" do
+        build_validator matches: /.*\.png$/, message: "should be a PNG image"
+        allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
+        @validator.validate(@dummy)
+
+        expect(@dummy.errors[:avatar_file_name]).to include "should be a PNG image"
+      end
+    end
+  end
+
+  context "blacklist format" do
+    context "with an allowed type" do
+      context "as a single regexp" do
+        before do
+          build_validator not: /^text\/.*/
+          allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
+          @validator.validate(@dummy)
+        end
+
+        it "does not set an error message" do
+          assert @dummy.errors[:avatar_file_name].blank?
+        end
+      end
+
+      context "as a list" do
+        before do
+          build_validator not: [/.*\.png$/, /.*\.jpe?g$/]
+          allow(@dummy).to receive_messages(avatar_file_name: "image.gif")
+          @validator.validate(@dummy)
+        end
+
+        it "does not set an error message" do
+          assert @dummy.errors[:avatar_file_name].blank?
+        end
+      end
+    end
+
+    context "with a disallowed type" do
+      it "sets a correct default error message" do
+        build_validator not: /data.*/
+        allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+        @validator.validate(@dummy)
+
+        assert @dummy.errors[:avatar_file_name].present?
+        expect(@dummy.errors[:avatar_file_name]).to include "is invalid"
+      end
+
+      it "sets a correct custom error message" do
+        build_validator not: /.*\.png$/, message: "should not be a PNG image"
+        allow(@dummy).to receive_messages(avatar_file_name: "image.png")
+        @validator.validate(@dummy)
+
+        expect(@dummy.errors[:avatar_file_name]).to include "should not be a PNG image"
+      end
+    end
+  end
+
+  context "using the helper" do
+    before do
+      Dummy.validates_attachment_file_name :avatar, matches: /.*\.jpg$/
+    end
+
+    it "adds the validator to the class" do
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_file_name }
+    end
+  end
+
+  context "given options" do
+    it "raises argument error if no required argument was given" do
+      assert_raises(ArgumentError) do
+        build_validator message: "Some message"
+      end
+    end
+
+    it "does not raise argument error if :matches was given" do
+      build_validator matches: /.*\.jpg$/
+    end
+
+    it "does not raise argument error if :not was given" do
+      build_validator not: /.*\.jpg$/
+    end
+  end
+end

data/spec/paperclip/validators/attachment_presence_validator_spec.rb

@@ -0,0 +1,85 @@
+require "spec_helper"
+
+describe Paperclip::Validators::AttachmentPresenceValidator do
+  before do
+    rebuild_model
+    @dummy = Dummy.new
+  end
+
+  def build_validator(options = {})
+    @validator = Paperclip::Validators::AttachmentPresenceValidator.new(options.merge(
+                                                                          attributes: :avatar
+                                                                        ))
+  end
+
+  context "nil attachment" do
+    before do
+      @dummy.avatar = nil
+    end
+
+    context "with default options" do
+      before do
+        build_validator
+        @validator.validate(@dummy)
+      end
+
+      it "adds error on the attachment" do
+        assert @dummy.errors[:avatar].present?
+      end
+
+      it "does not add an error on the file_name attribute" do
+        assert @dummy.errors[:avatar_file_name].blank?
+      end
+    end
+
+    context "with :if option" do
+      context "returning true" do
+        before do
+          build_validator if: true
+          @validator.validate(@dummy)
+        end
+
+        it "performs a validation" do
+          assert @dummy.errors[:avatar].present?
+        end
+      end
+
+      context "returning false" do
+        before do
+          build_validator if: false
+          @validator.validate(@dummy)
+        end
+
+        it "performs a validation" do
+          assert @dummy.errors[:avatar].present?
+        end
+      end
+    end
+  end
+
+  context "with attachment" do
+    before do
+      build_validator
+      @dummy.avatar = StringIO.new('.\n')
+      @validator.validate(@dummy)
+    end
+
+    it "does not add error on the attachment" do
+      assert @dummy.errors[:avatar].blank?
+    end
+
+    it "does not add an error on the file_name attribute" do
+      assert @dummy.errors[:avatar_file_name].blank?
+    end
+  end
+
+  context "using the helper" do
+    before do
+      Dummy.validates_attachment_presence :avatar
+    end
+
+    it "adds the validator to the class" do
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_presence }
+    end
+  end
+end

data/spec/paperclip/validators/attachment_size_validator_spec.rb

@@ -0,0 +1,325 @@
+require "spec_helper"
+
+describe Paperclip::Validators::AttachmentSizeValidator do
+  before do
+    rebuild_model
+    @dummy = Dummy.new
+  end
+
+  def build_validator(options)
+    @validator = Paperclip::Validators::AttachmentSizeValidator.new(options.merge(
+                                                                      attributes: :avatar
+                                                                    ))
+  end
+
+  def self.should_allow_attachment_file_size(size)
+    context "when the attachment size is #{size}" do
+      it "adds error to dummy object" do
+        allow(@dummy).to receive(:avatar_content_type).and_return(size)
+        @validator.validate(@dummy)
+        assert @dummy.errors[:avatar_file_size].blank?,
+               "Expect an error message on :avatar_file_size, got none."
+      end
+
+      it "does not add error to the base dummy object" do
+        assert @dummy.errors[:avatar].blank?,
+               "Error added to base attribute"
+      end
+    end
+  end
+
+  def self.should_not_allow_attachment_file_size(size, options = {})
+    context "when the attachment size is #{size}" do
+      before do
+        allow(@dummy).to receive(:avatar_file_size).and_return(size)
+        @validator.validate(@dummy)
+      end
+
+      it "adds error to dummy object" do
+        assert @dummy.errors[:avatar_file_size].present?,
+               "Unexpected error message on :avatar_file_size"
+      end
+
+      it "adds error to the base dummy object" do
+        assert @dummy.errors[:avatar].present?,
+               "Error not added to base attribute"
+      end
+
+      it "adds error to base object as a string" do
+        expect(@dummy.errors[:avatar].first).to be_a String
+      end
+
+      if options[:message]
+        it "returns a correct error message" do
+          expect(@dummy.errors[:avatar_file_size]).to include options[:message]
+        end
+      end
+    end
+  end
+
+  context "with :in option" do
+    context "as a range" do
+      before do
+        build_validator in: (5.kilobytes..10.kilobytes)
+      end
+
+      should_allow_attachment_file_size(7.kilobytes)
+      should_not_allow_attachment_file_size(4.kilobytes)
+      should_not_allow_attachment_file_size(11.kilobytes)
+    end
+
+    context "as a proc" do
+      before do
+        build_validator in: lambda { |_avatar| (5.kilobytes..10.kilobytes) }
+      end
+
+      should_allow_attachment_file_size(7.kilobytes)
+      should_not_allow_attachment_file_size(4.kilobytes)
+      should_not_allow_attachment_file_size(11.kilobytes)
+    end
+  end
+
+  context "with :greater_than option" do
+    context "as number" do
+      before do
+        build_validator greater_than: 10.kilobytes
+      end
+
+      should_allow_attachment_file_size 11.kilobytes
+      should_not_allow_attachment_file_size 10.kilobytes
+    end
+
+    context "as a proc" do
+      before do
+        build_validator greater_than: lambda { |_avatar| 10.kilobytes }
+      end
+
+      should_allow_attachment_file_size 11.kilobytes
+      should_not_allow_attachment_file_size 10.kilobytes
+    end
+  end
+
+  context "with :less_than option" do
+    context "as number" do
+      before do
+        build_validator less_than: 10.kilobytes
+      end
+
+      should_allow_attachment_file_size 9.kilobytes
+      should_not_allow_attachment_file_size 10.kilobytes
+    end
+
+    context "as a proc" do
+      before do
+        build_validator less_than: lambda { |_avatar| 10.kilobytes }
+      end
+
+      should_allow_attachment_file_size 9.kilobytes
+      should_not_allow_attachment_file_size 10.kilobytes
+    end
+  end
+
+  context "with :greater_than and :less_than option" do
+    context "as numbers" do
+      before do
+        build_validator greater_than: 5.kilobytes,
+                        less_than: 10.kilobytes
+      end
+
+      should_allow_attachment_file_size 7.kilobytes
+      should_not_allow_attachment_file_size 5.kilobytes
+      should_not_allow_attachment_file_size 10.kilobytes
+    end
+
+    context "as a proc" do
+      before do
+        build_validator greater_than: lambda { |_avatar| 5.kilobytes },
+                        less_than: lambda { |_avatar| 10.kilobytes }
+      end
+
+      should_allow_attachment_file_size 7.kilobytes
+      should_not_allow_attachment_file_size 5.kilobytes
+      should_not_allow_attachment_file_size 10.kilobytes
+    end
+  end
+
+  context "with :message option" do
+    context "given a range" do
+      before do
+        build_validator in: (5.kilobytes..10.kilobytes),
+                        message: "is invalid. (Between %{min} and %{max} please.)"
+      end
+
+      should_not_allow_attachment_file_size(
+        11.kilobytes,
+        message: "is invalid. (Between 5 KB and 10 KB please.)"
+      )
+    end
+
+    context "given :less_than and :greater_than" do
+      before do
+        build_validator less_than: 10.kilobytes,
+                        greater_than: 5.kilobytes,
+                        message: "is invalid. (Between %{min} and %{max} please.)"
+      end
+
+      should_not_allow_attachment_file_size(
+        11.kilobytes,
+        message: "is invalid. (Between 5 KB and 10 KB please.)"
+      )
+    end
+  end
+
+  context "default error messages" do
+    context "given :less_than and :greater_than" do
+      before do
+        build_validator greater_than: 5.kilobytes,
+                        less_than: 10.kilobytes
+      end
+
+      should_not_allow_attachment_file_size(
+        11.kilobytes,
+        message: "must be less than 10 KB"
+      )
+
+      should_not_allow_attachment_file_size(
+        4.kilobytes,
+        message: "must be greater than 5 KB"
+      )
+    end
+
+    context "given a size range" do
+      before do
+        build_validator in: (5.kilobytes..10.kilobytes)
+      end
+
+      should_not_allow_attachment_file_size(
+        11.kilobytes,
+        message: "must be in between 5 KB and 10 KB"
+      )
+
+      should_not_allow_attachment_file_size(
+        4.kilobytes,
+        message: "must be in between 5 KB and 10 KB"
+      )
+    end
+  end
+
+  context "with add_validation_errors_to not set (implicitly :both)" do
+    it "adds error to both attribute and base" do
+      build_validator in: (5.kilobytes..10.kilobytes)
+      allow(@dummy).to receive(:avatar_file_size).and_return(11.kilobytes)
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_file_size].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :attribute globally" do
+    before do
+      Paperclip.options[:add_validation_errors_to] = :attribute
+    end
+
+    after do
+      Paperclip.options[:add_validation_errors_to] = :both
+    end
+
+    it "only adds error to attribute not base" do
+      build_validator in: (5.kilobytes..10.kilobytes)
+      allow(@dummy).to receive(:avatar_file_size).and_return(11.kilobytes)
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_file_size].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].blank?,
+             "Error added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :base globally" do
+    before do
+      Paperclip.options[:add_validation_errors_to] = :base
+    end
+
+    after do
+      Paperclip.options[:add_validation_errors_to] = :both
+    end
+
+    it "only adds error to base not attribute" do
+      build_validator in: (5.kilobytes..10.kilobytes)
+      allow(@dummy).to receive(:avatar_file_size).and_return(11.kilobytes)
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+
+      assert @dummy.errors[:avatar_file_size].blank?,
+             "Error added to attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :attribute" do
+    it "only adds error to attribute not base" do
+      build_validator in: (5.kilobytes..10.kilobytes),
+                      add_validation_errors_to: :attribute
+
+      allow(@dummy).to receive(:avatar_file_size).and_return(11.kilobytes)
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_file_size].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].blank?,
+             "Error added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :base" do
+    it "only adds error to base not attribute" do
+      build_validator in: (5.kilobytes..10.kilobytes),
+                      add_validation_errors_to: :base
+
+      allow(@dummy).to receive(:avatar_file_size).and_return(11.kilobytes)
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+
+      assert @dummy.errors[:avatar_file_size].blank?,
+             "Error added to attribute"
+    end
+  end
+
+  context "using the helper" do
+    before do
+      Dummy.validates_attachment_size :avatar, in: (5.kilobytes..10.kilobytes)
+    end
+
+    it "adds the validator to the class" do
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_size }
+    end
+  end
+
+  context "given options" do
+    it "raises argument error if no required argument was given" do
+      assert_raises(ArgumentError) do
+        build_validator message: "Some message"
+      end
+    end
+
+    Paperclip::Validators::AttachmentSizeValidator::AVAILABLE_CHECKS.each do |argument|
+      it "does not raise arguemnt error if #{argument} was given" do
+        build_validator argument => 5.kilobytes
+      end
+    end
+
+    it "does not raise argument error if :in was given" do
+      build_validator in: (5.kilobytes..10.kilobytes)
+    end
+  end
+end

data/spec/paperclip/validators/media_type_spoof_detection_validator_spec.rb

@@ -0,0 +1,48 @@
+require "spec_helper"
+
+describe Paperclip::Validators::MediaTypeSpoofDetectionValidator do
+  before do
+    rebuild_model
+    @dummy = Dummy.new
+  end
+
+  def build_validator(options = {})
+    @validator = Paperclip::Validators::MediaTypeSpoofDetectionValidator.new(options.merge(
+                                                                               attributes: :avatar
+                                                                             ))
+  end
+
+  it "is on the attachment without being explicitly added" do
+    assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :media_type_spoof_detection }
+  end
+
+  it "is not on the attachment when explicitly rejected" do
+    rebuild_model validate_media_type: false
+    assert Dummy.validators_on(:avatar).none? { |validator| validator.kind == :media_type_spoof_detection }
+  end
+
+  it "returns default error message for spoofed media type" do
+    build_validator
+    file = File.new(fixture_file("5k.png"), "rb")
+    @dummy.avatar.assign(file)
+
+    detector = double("detector", spoofed?: true)
+    allow(Paperclip::MediaTypeSpoofDetector).to receive(:using).and_return(detector)
+    @validator.validate(@dummy)
+
+    assert_equal I18n.t("errors.messages.spoofed_media_type"), @dummy.errors[:avatar].first
+  end
+
+  it "runs when attachment is dirty" do
+    build_validator
+    file = File.new(fixture_file("5k.png"), "rb")
+    @dummy.avatar.assign(file)
+    expect(Paperclip::MediaTypeSpoofDetector).to receive(:using).once.and_return(double("detector", spoofed?: false))
+    @dummy.valid?
+  end
+
+  it "does not run when attachment is not dirty" do
+    expect(Paperclip::MediaTypeSpoofDetector).to_not receive(:using)
+    @dummy.valid?
+  end
+end