jr-paperclip 7.3.0

data/spec/paperclip/schema_spec.rb

@@ -0,0 +1,298 @@
+require "spec_helper"
+require "paperclip/schema"
+require "active_support/testing/deprecation"
+
+describe Paperclip::Schema do
+  include ActiveSupport::Testing::Deprecation
+
+  before do
+    rebuild_class
+  end
+
+  after do
+    begin
+      ActiveRecord::Migration.drop_table :dummies
+    rescue StandardError
+      nil
+    end
+  end
+
+  # Helper to check datetime column (Rails 7+ uses datetime(6) precision by default)
+  def expect_datetime_column(columns, column_name)
+    datetime_column = columns.find { |col| col[0] == column_name }
+    expect(datetime_column).to be_present
+    expect(datetime_column[1]).to match(/^datetime/)
+  end
+
+  # Helper to enable deprecation warnings for testing
+  def with_deprecation_warnings_enabled
+    if ActiveSupport::Deprecation.respond_to?(:silenced=)
+      old_silenced = ActiveSupport::Deprecation.silenced
+      ActiveSupport::Deprecation.silenced = false
+      yield
+      ActiveSupport::Deprecation.silenced = old_silenced
+    elsif defined?(ActiveSupport.deprecator)
+      old_behavior = ActiveSupport.deprecator.behavior
+      ActiveSupport.deprecator.behavior = :stderr
+      yield
+      ActiveSupport.deprecator.behavior = old_behavior
+    else
+      yield
+    end
+  end
+
+  context "within table definition" do
+    context "using #has_attached_file" do
+      it "creates attachment columns" do
+        ActiveRecord::Migration.create_table :dummies, force: true do |t|
+          if ActiveSupport::Deprecation.respond_to?(:silence)
+            ActiveSupport::Deprecation.silence do
+              t.has_attached_file :avatar
+            end
+          elsif defined?(ActiveSupport.deprecator)
+            ActiveSupport.deprecator.silence do
+              t.has_attached_file :avatar
+            end
+          else
+            t.has_attached_file :avatar
+          end
+        end
+
+        columns = Dummy.columns.map { |column| [column.name, column.sql_type] }
+
+        expect(columns).to include(["avatar_file_name", "varchar"])
+        expect(columns).to include(["avatar_content_type", "varchar"])
+        expect(columns).to include(["avatar_file_size", "bigint"])
+        expect_datetime_column(columns, "avatar_updated_at")
+      end
+
+      it "displays deprecation warning" do
+        with_deprecation_warnings_enabled do
+          ActiveRecord::Migration.create_table :dummies, force: true do |t|
+            deprecator = defined?(ActiveSupport.deprecator) ? ActiveSupport.deprecator : ActiveSupport::Deprecation
+            assert_deprecated(nil, deprecator) do
+              t.has_attached_file :avatar
+            end
+          end
+        end
+      end
+    end
+
+    context "using #attachment" do
+      before do
+        ActiveRecord::Migration.create_table :dummies, force: true do |t|
+          t.attachment :avatar
+        end
+      end
+
+      it "creates attachment columns" do
+        columns = Dummy.columns.map { |column| [column.name, column.sql_type] }
+
+        expect(columns).to include(["avatar_file_name", "varchar"])
+        expect(columns).to include(["avatar_content_type", "varchar"])
+        expect(columns).to include(["avatar_file_size", "bigint"])
+        expect_datetime_column(columns, "avatar_updated_at")
+      end
+    end
+
+    context "using #attachment with options" do
+      before do
+        ActiveRecord::Migration.create_table :dummies, force: true do |t|
+          t.attachment :avatar, default: 1, file_name: { default: "default" }
+        end
+      end
+
+      it "sets defaults on columns" do
+        defaults_columns = ["avatar_file_name", "avatar_content_type", "avatar_file_size"]
+        columns = Dummy.columns.select { |e| defaults_columns.include? e.name }
+
+        expect(columns).to have_column("avatar_file_name").with_default("default")
+        expect(columns).to have_column("avatar_content_type").with_default("1")
+        expect(columns).to have_column("avatar_file_size").with_default(1)
+      end
+    end
+  end
+
+  context "within schema statement" do
+    before do
+      ActiveRecord::Migration.create_table :dummies, force: true
+    end
+
+    context "migrating up" do
+      context "with single attachment" do
+        before do
+          ActiveRecord::Migration.add_attachment :dummies, :avatar
+        end
+
+        it "creates attachment columns" do
+          columns = Dummy.columns.map { |column| [column.name, column.sql_type] }
+
+          expect(columns).to include(["avatar_file_name", "varchar"])
+          expect(columns).to include(["avatar_content_type", "varchar"])
+          expect(columns).to include(["avatar_file_size", "bigint"])
+          expect_datetime_column(columns, "avatar_updated_at")
+        end
+      end
+
+      context "with single attachment and options" do
+        before do
+          ActiveRecord::Migration.add_attachment :dummies, :avatar, default: "1", file_name: { default: "default" }
+        end
+
+        it "sets defaults on columns" do
+          defaults_columns = ["avatar_file_name", "avatar_content_type", "avatar_file_size"]
+          columns = Dummy.columns.select { |e| defaults_columns.include? e.name }
+
+          expect(columns).to have_column("avatar_file_name").with_default("default")
+          expect(columns).to have_column("avatar_content_type").with_default("1")
+          expect(columns).to have_column("avatar_file_size").with_default(1)
+        end
+      end
+
+      context "with multiple attachments" do
+        before do
+          ActiveRecord::Migration.add_attachment :dummies, :avatar, :photo
+        end
+
+        it "creates attachment columns" do
+          columns = Dummy.columns.map { |column| [column.name, column.sql_type] }
+
+          expect(columns).to include(["avatar_file_name", "varchar"])
+          expect(columns).to include(["avatar_content_type", "varchar"])
+          expect(columns).to include(["avatar_file_size", "bigint"])
+          expect_datetime_column(columns, "avatar_updated_at")
+          expect(columns).to include(["photo_file_name", "varchar"])
+          expect(columns).to include(["photo_content_type", "varchar"])
+          expect(columns).to include(["photo_file_size", "bigint"])
+          expect_datetime_column(columns, "photo_updated_at")
+        end
+      end
+
+      context "with multiple attachments and options" do
+        before do
+          ActiveRecord::Migration.add_attachment :dummies, :avatar, :photo, default: "1", file_name: { default: "default" }
+        end
+
+        it "sets defaults on columns" do
+          defaults_columns = ["avatar_file_name", "avatar_content_type", "avatar_file_size", "photo_file_name", "photo_content_type", "photo_file_size"]
+          columns = Dummy.columns.select { |e| defaults_columns.include? e.name }
+
+          expect(columns).to have_column("avatar_file_name").with_default("default")
+          expect(columns).to have_column("avatar_content_type").with_default("1")
+          expect(columns).to have_column("avatar_file_size").with_default(1)
+          expect(columns).to have_column("photo_file_name").with_default("default")
+          expect(columns).to have_column("photo_content_type").with_default("1")
+          expect(columns).to have_column("photo_file_size").with_default(1)
+        end
+      end
+
+      context "with no attachment" do
+        it "raises an error" do
+          assert_raises ArgumentError do
+            ActiveRecord::Migration.add_attachment :dummies
+          end
+        end
+      end
+    end
+
+    context "migrating down" do
+      before do
+        ActiveRecord::Migration.change_table :dummies do |t|
+          t.column :avatar_file_name, :string
+          t.column :avatar_content_type, :string
+          t.column :avatar_file_size, :bigint
+          t.column :avatar_updated_at, :datetime
+        end
+      end
+
+      # Helper to check datetime column is NOT present
+      def expect_no_datetime_column(columns, column_name)
+        datetime_column = columns.find { |col| col[0] == column_name }
+        expect(datetime_column).to be_nil
+      end
+
+      context "using #drop_attached_file" do
+        it "removes the attachment columns" do
+          if ActiveSupport::Deprecation.respond_to?(:silence)
+            ActiveSupport::Deprecation.silence do
+              ActiveRecord::Migration.drop_attached_file :dummies, :avatar
+            end
+          elsif defined?(ActiveSupport.deprecator)
+            ActiveSupport.deprecator.silence do
+              ActiveRecord::Migration.drop_attached_file :dummies, :avatar
+            end
+          else
+            ActiveRecord::Migration.drop_attached_file :dummies, :avatar
+          end
+
+          columns = Dummy.columns.map { |column| [column.name, column.sql_type] }
+
+          expect(columns).to_not include(["avatar_file_name", "varchar"])
+          expect(columns).to_not include(["avatar_content_type", "varchar"])
+          expect(columns).to_not include(["avatar_file_size", "bigint"])
+          expect_no_datetime_column(columns, "avatar_updated_at")
+        end
+
+        it "displays a deprecation warning" do
+          with_deprecation_warnings_enabled do
+            deprecator = defined?(ActiveSupport.deprecator) ? ActiveSupport.deprecator : ActiveSupport::Deprecation
+            assert_deprecated(nil, deprecator) do
+              ActiveRecord::Migration.drop_attached_file :dummies, :avatar
+            end
+          end
+        end
+      end
+
+      context "using #remove_attachment" do
+        context "with single attachment" do
+          before do
+            ActiveRecord::Migration.remove_attachment :dummies, :avatar
+          end
+
+          it "removes the attachment columns" do
+            columns = Dummy.columns.map { |column| [column.name, column.sql_type] }
+
+            expect(columns).to_not include(["avatar_file_name", "varchar"])
+            expect(columns).to_not include(["avatar_content_type", "varchar"])
+            expect(columns).to_not include(["avatar_file_size", "bigint"])
+            expect_no_datetime_column(columns, "avatar_updated_at")
+          end
+        end
+
+        context "with multiple attachments" do
+          before do
+            ActiveRecord::Migration.change_table :dummies do |t|
+              t.column :photo_file_name, :string
+              t.column :photo_content_type, :string
+              t.column :photo_file_size, :bigint
+              t.column :photo_updated_at, :datetime
+            end
+
+            ActiveRecord::Migration.remove_attachment :dummies, :avatar, :photo
+          end
+
+          it "removes the attachment columns" do
+            columns = Dummy.columns.map { |column| [column.name, column.sql_type] }
+
+            expect(columns).to_not include(["avatar_file_name", "varchar"])
+            expect(columns).to_not include(["avatar_content_type", "varchar"])
+            expect(columns).to_not include(["avatar_file_size", "bigint"])
+            expect_no_datetime_column(columns, "avatar_updated_at")
+            expect(columns).to_not include(["photo_file_name", "varchar"])
+            expect(columns).to_not include(["photo_content_type", "varchar"])
+            expect(columns).to_not include(["photo_file_size", "bigint"])
+            expect_no_datetime_column(columns, "photo_updated_at")
+          end
+        end
+
+        context "with no attachment" do
+          it "raises an error" do
+            assert_raises ArgumentError do
+              ActiveRecord::Migration.remove_attachment :dummies
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/paperclip/storage/filesystem_spec.rb

@@ -0,0 +1,102 @@
+require "spec_helper"
+
+describe Paperclip::Storage::Filesystem do
+  context "Filesystem" do
+    context "normal file" do
+      before do
+        rebuild_model styles: { thumbnail: "25x25#" }
+        @dummy = Dummy.create!
+
+        @file = File.open(fixture_file("5k.png"))
+        @dummy.avatar = @file
+      end
+
+      after { @file.close }
+
+      it "allows file assignment" do
+        assert @dummy.save
+      end
+
+      it "stores the original" do
+        @dummy.save
+        assert_file_exists(@dummy.avatar.path)
+      end
+
+      it "stores the thumbnail" do
+        @dummy.save
+        assert_file_exists(@dummy.avatar.path(:thumbnail))
+      end
+
+      it "is rewinded after flush_writes" do
+        @dummy.avatar.instance_eval "def after_flush_writes; end"
+
+        files = @dummy.avatar.queued_for_write.values
+        @dummy.save
+        assert files.none?(&:eof?), "Expect all the files to be rewinded."
+      end
+
+      it "is removed after after_flush_writes" do
+        paths = @dummy.avatar.queued_for_write.values.map(&:path)
+        @dummy.save
+        assert paths.none? { |path| File.exist?(path) },
+               "Expect all the files to be deleted."
+      end
+
+      it "copies the file to a known location with copy_to_local_file" do
+        tempfile = Tempfile.new("known_location")
+        @dummy.avatar.copy_to_local_file(:original, tempfile.path)
+        tempfile.rewind
+        assert_equal @file.read, tempfile.read
+        tempfile.close
+      end
+
+      it "only issues a delete call once for each unique attachment style when nullifying attachment" do
+        @dummy.save
+        @dummy.avatar.clear(:thumbnail)
+        @dummy.avatar = nil
+        assert_equal 3, @dummy.avatar.queued_for_delete.size
+
+        expect(FileUtils).to receive(:rm).twice
+        @dummy.save
+
+        FileUtils.rm_rf("tmp")
+      end
+
+      it "only issues a delete call once for each unique attachment style when destroying model" do
+        @dummy.save
+        @dummy.avatar.clear(:thumbnail)
+        assert_equal 1, @dummy.avatar.queued_for_delete.size
+
+        expect(FileUtils).to receive(:rm).twice
+        @dummy.destroy
+
+        FileUtils.rm_rf("tmp")
+      end
+    end
+
+    context "with file that has space in file name" do
+      before do
+        rebuild_model styles: { thumbnail: "25x25#" }
+        @dummy = Dummy.create!
+
+        @file = File.open(fixture_file("spaced file.png"))
+        @dummy.avatar = @file
+        @dummy.save
+      end
+
+      after { @file.close }
+
+      it "stores the file" do
+        assert_file_exists(@dummy.avatar.path)
+      end
+
+      it "returns a replaced version for path" do
+        assert_match /.+\/spaced_file\.png/, @dummy.avatar.path
+      end
+
+      it "returns a replaced version for url" do
+        assert_match /.+\/spaced_file\.png/, @dummy.avatar.url
+      end
+    end
+  end
+end