jira-ruby 1.2.0 → 2.3.0

data/spec/integration/watcher_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+describe JIRA::Resource::Watcher do
+  with_each_client do |site_url, client|
+    let(:client) { client }
+    let(:site_url) { site_url }
+
+    let(:target) { JIRA::Resource::Watcher.new(client, attrs: { 'id' => '99999' }, issue_id: '10002') }
+
+    let(:belongs_to) do
+      JIRA::Resource::Issue.new(client, attrs: {
+                                  'id' => '10002',
+                                  'fields' => {
+                                    'comment' => { 'comments' => [] }
+                                  }
+                                })
+    end
+
+    let(:expected_attributes) do
+      {
+        'self' => 'http://localhost:2990/jira/rest/api/2/issue/10002/watchers',
+        "isWatching": false,
+        "watchCount": 1,
+        "watchers": [
+          {
+            "self": 'http://www.example.com/jira/rest/api/2/user?username=admin',
+            "name": 'admin',
+            "displayName": 'admin',
+            "active": false
+          }
+        ]
+      }
+    end
+
+    describe 'watchers' do
+      before(:each) do
+        stub_request(:get, site_url + '/jira/rest/api/2/issue/10002')
+          .to_return(status: 200, body: get_mock_response('issue/10002.json'))
+
+        stub_request(:get, site_url + '/jira/rest/api/2/issue/10002/watchers')
+          .to_return(status: 200, body: get_mock_response('issue/10002/watchers.json'))
+
+        stub_request(:post, site_url + '/jira/rest/api/2/issue/10002/watchers')
+          .to_return(status: 204, body: nil)
+      end
+
+      it 'should returns all the watchers' do
+        issue = client.Issue.find('10002')
+        watchers = client.Watcher.all(options = { issue: issue })
+        expect(watchers.length).to eq(1)
+      end
+
+      it 'should add a watcher' do
+        issue = client.Issue.find('10002')
+        watcher = JIRA::Resource::Watcher.new(client, issue: issue)
+        user_id = "tester"
+        watcher.save!(user_id)
+      end
+    end
+
+  end
+end

data/spec/integration/webhook.rb

@@ -1,34 +1,25 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Webhook do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "2" }
+    let(:key) { '2' }
 
     let(:expected_attributes) do
-     {"name"=>"from API", "url"=>"http://localhost:3000/webhooks/1", "excludeBody"=>false, "filters"=>{"issue-related-events-section"=>""}, "events"=>[], "enabled"=>true, "self"=>"http://localhost:2990/jira/rest/webhooks/1.0/webhook/2", "lastUpdatedUser"=>"admin", "lastUpdatedDisplayName"=>"admin", "lastUpdated"=>1453306520188}
+      { 'name' => 'from API', 'url' => 'http://localhost:3000/webhooks/1', 'excludeBody' => false, 'filters' => { 'issue-related-events-section' => '' }, 'events' => [], 'enabled' => true, 'self' => 'http://localhost:2990/jira/rest/webhooks/1.0/webhook/2', 'lastUpdatedUser' => 'admin', 'lastUpdatedDisplayName' => 'admin', 'lastUpdated' => 1_453_306_520_188 }
     end
 
     let(:expected_collection_length) { 1 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
-    
-
-    it "returns a collection of components" do
-
-      stub_request(:get, site_url + described_class.singular_path(client, key)).
-        to_return(:status => 200, :body => get_mock_response('webhook/webhook.json'))
-
-
-      
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
 
+    it 'returns a collection of components' do
+      stub_request(:get, site_url + described_class.singular_path(client, key))
+        .to_return(status: 200, body: get_mock_response('webhook/webhook.json'))
     end
   end
 end

data/spec/integration/worklog_spec.rb

@@ -1,55 +1,51 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Worklog do
-
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
+    let(:key) { '10000' }
 
-    let(:key) { "10000" }
-
-    let(:target) { JIRA::Resource::Worklog.new(client, :attrs => {'id' => '99999'}, :issue_id => '54321') }
+    let(:target) { JIRA::Resource::Worklog.new(client, attrs: { 'id' => '99999' }, issue_id: '54321') }
 
     let(:expected_collection_length) { 3 }
 
-    let(:belongs_to) {
-      JIRA::Resource::Issue.new(client, :attrs => {
-        'id' => '10002', 'fields' => {
-          'comment' => {'comments' => []}
-        }
-      })
-    }
+    let(:belongs_to) do
+      JIRA::Resource::Issue.new(client, attrs: {
+                                  'id' => '10002', 'fields' => {
+                                    'comment' => { 'comments' => [] }
+                                  }
+                                })
+    end
 
     let(:expected_attributes) do
       {
-        'self' => "http://localhost:2990/jira/rest/api/2/issue/10002/worklog/10000",
+        'self' => 'http://localhost:2990/jira/rest/api/2/issue/10002/worklog/10000',
         'id'   => key,
-        'comment' => "Some epic work."
+        'comment' => 'Some epic work.'
       }
     end
 
-    let(:attributes_for_post) {
-      {"timeSpent" => "2d"}
-    }
-    let(:expected_attributes_from_post) {
-      { "id" => "10001", "timeSpent" => "2d"}
-    }
-
-    let(:attributes_for_put) {
-      {"timeSpent" => "2d"}
-    }
-    let(:expected_attributes_from_put) {
-      { "id" => "10001", "timeSpent" => "4d"}
-    }
-
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-    it_should_behave_like "a resource with a DELETE endpoint"
-    it_should_behave_like "a resource with a POST endpoint"
-    it_should_behave_like "a resource with a PUT endpoint"
+    let(:attributes_for_post) do
+      { 'timeSpent' => '2d' }
+    end
+    let(:expected_attributes_from_post) do
+      { 'id' => '10001', 'timeSpent' => '2d' }
+    end
+
+    let(:attributes_for_put) do
+      { 'timeSpent' => '2d' }
+    end
+    let(:expected_attributes_from_put) do
+      { 'id' => '10001', 'timeSpent' => '4d' }
+    end
 
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
+    it_should_behave_like 'a resource with a DELETE endpoint'
+    it_should_behave_like 'a resource with a POST endpoint'
+    it_should_behave_like 'a resource with a PUT endpoint'
   end
 end

data/spec/jira/base_factory_spec.rb

@@ -1,45 +1,44 @@
 require 'spec_helper'
 
 describe JIRA::BaseFactory do
+  class JIRA::Resource::FooFactory < JIRA::BaseFactory; end
+  class JIRA::Resource::Foo; end
 
-  class JIRA::Resource::FooFactory < JIRA::BaseFactory ; end
-  class JIRA::Resource::Foo ; end
-
-  let(:client)  { double() }
+  let(:client)  { double }
   subject       { JIRA::Resource::FooFactory.new(client) }
 
-  it "initializes correctly" do
+  it 'initializes correctly' do
     expect(subject.class).to        eq(JIRA::Resource::FooFactory)
     expect(subject.client).to       eq(client)
     expect(subject.target_class).to eq(JIRA::Resource::Foo)
   end
 
-  it "proxies all to the target class" do
+  it 'proxies all to the target class' do
     expect(JIRA::Resource::Foo).to receive(:all).with(client)
     subject.all
   end
 
-  it "proxies find to the target class" do
+  it 'proxies find to the target class' do
     expect(JIRA::Resource::Foo).to receive(:find).with(client, 'FOO')
     subject.find('FOO')
   end
 
-  it "returns the target class" do
+  it 'returns the target class' do
     expect(subject.target_class).to eq(JIRA::Resource::Foo)
   end
 
-  it "proxies build to the target class" do
-    attrs = double()
+  it 'proxies build to the target class' do
+    attrs = double
     expect(JIRA::Resource::Foo).to receive(:build).with(client, attrs)
     subject.build(attrs)
   end
 
-  it "proxies collection path to the target class" do
+  it 'proxies collection path to the target class' do
     expect(JIRA::Resource::Foo).to receive(:collection_path).with(client)
     subject.collection_path
   end
 
-  it "proxies singular path to the target class" do
+  it 'proxies singular path to the target class' do
     expect(JIRA::Resource::Foo).to receive(:singular_path).with(client, 'FOO')
     subject.singular_path('FOO')
   end