jira-ruby 1.2.0 → 2.3.0

data/spec/integration/issue_spec.rb

@@ -1,94 +1,93 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Issue do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "10002" }
+    let(:key) { '10002' }
 
     let(:expected_attributes) do
       {
-        'self'   => "http://localhost:2990/jira/rest/api/2/issue/10002",
-        'key'    => "SAMPLEPROJECT-1",
-        'expand' => "renderedFields,names,schema,transitions,editmeta,changelog"
+        'self'   => 'http://localhost:2990/jira/rest/api/2/issue/10002',
+        'key'    => 'SAMPLEPROJECT-1',
+        'expand' => 'renderedFields,names,schema,transitions,editmeta,changelog'
       }
     end
 
-    let(:attributes_for_post) {
+    let(:attributes_for_post) do
       { 'foo' => 'bar' }
-    }
-    let(:expected_attributes_from_post) {
-      { "id" => "10005", "key" => "SAMPLEPROJECT-4" }
-    }
+    end
+    let(:expected_attributes_from_post) do
+      { 'id' => '10005', 'key' => 'SAMPLEPROJECT-4' }
+    end
 
-    let(:attributes_for_put) {
+    let(:attributes_for_put) do
       { 'foo' => 'bar' }
-    }
-    let(:expected_attributes_from_put) {
+    end
+    let(:expected_attributes_from_put) do
       { 'foo' => 'bar' }
-    }
+    end
     let(:expected_collection_length) { 11 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a singular GET endpoint"
-    describe "GET all issues" do # JIRA::Resource::Issue.all uses the search endpoint
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a singular GET endpoint'
+    describe 'GET all issues' do # JIRA::Resource::Issue.all uses the search endpoint
       let(:client) { client }
       let(:site_url) { site_url }
 
-      let(:expected_attributes) {
+      let(:expected_attributes) do
         {
-          "id"=>"10014",
-          "self"=>"http://localhost:2990/jira/rest/api/2/issue/10014",
-          "key"=>"SAMPLEPROJECT-13"
+          'id' => '10014',
+          'self' => 'http://localhost:2990/jira/rest/api/2/issue/10014',
+          'key' => 'SAMPLEPROJECT-13'
         }
-      }
+      end
       before(:each) do
-        stub_request(:get, site_url + "/jira/rest/api/2/search?expand=transitions.fields").
-                    to_return(:status => 200, :body => get_mock_response('issue.json'))
+        stub_request(:get, site_url + '/jira/rest/api/2/search?expand=transitions.fields&maxResults=1000&startAt=0')
+          .to_return(status: 200, body: get_mock_response('issue.json'))
+
+        stub_request(:get, site_url + '/jira/rest/api/2/search?expand=transitions.fields&maxResults=1000&startAt=11')
+          .to_return(status: 200, body: get_mock_response('empty_issues.json'))
       end
-      it_should_behave_like "a resource with a collection GET endpoint"
+      it_should_behave_like 'a resource with a collection GET endpoint'
     end
-    it_should_behave_like "a resource with a DELETE endpoint"
-    it_should_behave_like "a resource with a POST endpoint"
-    it_should_behave_like "a resource with a PUT endpoint"
-    it_should_behave_like "a resource with a PUT endpoint that rejects invalid fields"
+    it_should_behave_like 'a resource with a DELETE endpoint'
+    it_should_behave_like 'a resource with a POST endpoint'
+    it_should_behave_like 'a resource with a PUT endpoint'
+    it_should_behave_like 'a resource with a PUT endpoint that rejects invalid fields'
 
-    describe "errors" do
+    describe 'errors' do
       before(:each) do
         stub_request(:get,
-                    site_url + "/jira/rest/api/2/issue/10002").
-                    to_return(:status => 200, :body => get_mock_response('issue/10002.json'))
-        stub_request(:put, site_url + "/jira/rest/api/2/issue/10002").
-                    with(:body => '{"missing":"fields and update"}').
-                    to_return(:status => 400, :body => get_mock_response('issue/10002.put.missing_field_update.json'))
+                     site_url + '/jira/rest/api/2/issue/10002')
+          .to_return(status: 200, body: get_mock_response('issue/10002.json'))
+        stub_request(:put, site_url + '/jira/rest/api/2/issue/10002')
+          .with(body: '{"missing":"fields and update"}')
+          .to_return(status: 400, body: get_mock_response('issue/10002.put.missing_field_update.json'))
       end
 
-      it "fails to save when fields and update are missing" do
+      it 'fails to save when fields and update are missing' do
         subject = client.Issue.build('id' => '10002')
         subject.fetch
         expect(subject.save('missing' => 'fields and update')).to be_falsey
       end
-
     end
 
-    describe "GET jql issues" do # JIRA::Resource::Issue.jql uses the search endpoint
+    describe 'GET jql issues' do # JIRA::Resource::Issue.jql uses the search endpoint
       jql_query_string = "PROJECT = 'SAMPLEPROJECT'"
       let(:client) { client }
       let(:site_url) { site_url }
       let(:jql_query_string) { jql_query_string }
 
-      let(:expected_attributes) {
+      let(:expected_attributes) do
         {
-          "id"=>"10014",
-          "self"=>"http://localhost:2990/jira/rest/api/2/issue/10014",
-          "key"=>"SAMPLEPROJECT-13"
+          'id' => '10014',
+          'self' => 'http://localhost:2990/jira/rest/api/2/issue/10014',
+          'key' => 'SAMPLEPROJECT-13'
         }
-      }
-      it_should_behave_like "a resource with JQL inputs and a collection GET endpoint"
+      end
+      it_should_behave_like 'a resource with JQL inputs and a collection GET endpoint'
     end
-
   end
 end

data/spec/integration/issuelinktype_spec.rb

@@ -1,29 +1,26 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Issuelinktype do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "10000" }
+    let(:key) { '10000' }
 
     let(:expected_attributes) do
       {
         'id' => key,
-        "self"=>"http://localhost:2990/jira/rest/api/2/issueLinkType/10000",
-        "name"=>"Blocks",
-        "inward"=>"is blocked by",
-        "outward"=>"blocks"
+        'self' => 'http://localhost:2990/jira/rest/api/2/issueLinkType/10000',
+        'name' => 'Blocks',
+        'inward' => 'is blocked by',
+        'outward' => 'blocks'
       }
     end
 
     let(:expected_collection_length) { 3 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
   end
 end

data/spec/integration/issuetype_spec.rb

@@ -1,16 +1,15 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Issuetype do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-    let(:key) { "5" }
+    let(:key) { '5' }
 
     let(:expected_attributes) do
       {
-        'self' => "http://localhost:2990/jira/rest/api/2/issuetype/5",
+        'self' => 'http://localhost:2990/jira/rest/api/2/issuetype/5',
         'id' => key,
         'name' => 'Sub-task'
       }
@@ -18,9 +17,8 @@ describe JIRA::Resource::Issuetype do
 
     let(:expected_collection_length) { 5 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
   end
 end

data/spec/integration/priority_spec.rb

@@ -1,17 +1,15 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Priority do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "1" }
+    let(:key) { '1' }
 
     let(:expected_attributes) do
       {
-        'self' => "http://localhost:2990/jira/rest/api/2/priority/1",
+        'self' => 'http://localhost:2990/jira/rest/api/2/priority/1',
         'id' => key,
         'name' => 'Blocker'
       }
@@ -19,9 +17,8 @@ describe JIRA::Resource::Priority do
 
     let(:expected_collection_length) { 5 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
   end
 end

data/spec/integration/project_spec.rb

@@ -1,33 +1,30 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Project do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "SAMPLEPROJECT" }
+    let(:key) { 'SAMPLEPROJECT' }
 
     let(:expected_attributes) do
       {
-        'self'   => "http://localhost:2990/jira/rest/api/2/project/SAMPLEPROJECT",
+        'self'   => 'http://localhost:2990/jira/rest/api/2/project/SAMPLEPROJECT',
         'key'    => key,
-        'name'   => "Sample Project for Developing RoR RESTful API"
+        'name'   => 'Sample Project for Developing RoR RESTful API'
       }
     end
 
     let(:expected_collection_length) { 1 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
 
-    describe "issues" do
-
-      it "returns all the issues" do
-        stub_request(:get, site_url + "/jira/rest/api/2/search?jql=project=\"SAMPLEPROJECT\"").
-          to_return(:status => 200, :body => get_mock_response('project/SAMPLEPROJECT.issues.json'))
+    describe 'issues' do
+      it 'returns all the issues' do
+        stub_request(:get, site_url + '/jira/rest/api/2/search?jql=project="SAMPLEPROJECT"')
+          .to_return(status: 200, body: get_mock_response('project/SAMPLEPROJECT.issues.json'))
         subject = client.Project.build('key' => key)
         issues = subject.issues
         expect(issues.length).to eq(11)
@@ -35,22 +32,18 @@ describe JIRA::Resource::Project do
           expect(issue.class).to eq(JIRA::Resource::Issue)
           expect(issue.expanded?).to be_falsey
         end
-
       end
-
     end
 
-    it "returns a collection of components" do
-
-      stub_request(:get, site_url + described_class.singular_path(client, key)).
-        to_return(:status => 200, :body => get_mock_response('project/SAMPLEPROJECT.json'))
+    it 'returns a collection of components' do
+      stub_request(:get, site_url + described_class.singular_path(client, key))
+        .to_return(status: 200, body: get_mock_response('project/SAMPLEPROJECT.json'))
 
       subject = client.Project.find(key)
       expect(subject.components.length).to eq(2)
       subject.components.each do |component|
         expect(component.class).to eq(JIRA::Resource::Component)
       end
-
     end
   end
 end

data/spec/integration/rapidview_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe JIRA::Resource::RapidView do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
@@ -10,14 +9,14 @@ describe JIRA::Resource::RapidView do
 
     let(:expected_collection_length) { 1 }
 
-    let(:expected_attributes) {
+    let(:expected_attributes) do
       {
         'id' => 1,
         'name' => 'SAMPLEPROJECT',
         'canEdit' => true,
         'sprintSupportEnabled' => true
       }
-    }
+    end
 
     it_should_behave_like 'a resource'
     # TODO@Anton: Add json file
@@ -28,8 +27,8 @@ describe JIRA::Resource::RapidView do
       let(:site_url) { site_url }
 
       before(:each) do
-        stub_request(:get, site_url + '/jira/rest/greenhopper/1.0/rapidview').
-        to_return(:status => 200, :body => get_mock_response('rapidview.json'))
+        stub_request(:get, site_url + '/jira/rest/greenhopper/1.0/rapidview')
+          .to_return(status: 200, body: get_mock_response('rapidview.json'))
       end
       it_should_behave_like 'a resource with a collection GET endpoint'
     end
@@ -41,16 +40,24 @@ describe JIRA::Resource::RapidView do
           site_url +
           '/jira/rest/greenhopper/1.0/xboard/plan/backlog/data?rapidViewId=1'
         ).to_return(
-          :status => 200,
-          :body => get_mock_response('rapidview/SAMPLEPROJECT.issues.json')
+          status: 200,
+          body: get_mock_response('rapidview/SAMPLEPROJECT.issues.json')
+        )
+
+        stub_request(
+          :get,
+          site_url + '/jira/rest/api/2/search?jql=id IN(10001, 10000)'
+        ).to_return(
+          status: 200,
+          body: get_mock_response('rapidview/SAMPLEPROJECT.issues.full.json')
         )
 
         stub_request(
           :get,
-          site_url + '/jira/rest/api/2/search?jql=id IN(10000, 10001)'
+          site_url + '/jira/rest/api/2/search?jql=id IN(10000, 10001) AND sprint IS NOT EMPTY'
         ).to_return(
-          :status => 200,
-          :body => get_mock_response('rapidview/SAMPLEPROJECT.issues.full.json')
+          status: 200,
+          body: get_mock_response('rapidview/SAMPLEPROJECT.issues.full.json')
         )
 
         subject = client.RapidView.build('id' => 1)

data/spec/integration/resolution_spec.rb

@@ -1,29 +1,26 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Resolution do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "1" }
+    let(:key) { '1' }
 
     let(:expected_attributes) do
       {
-        'self' => "http://www.example.com/jira/rest/api/2/resolution/1",
+        'self' => 'http://www.example.com/jira/rest/api/2/resolution/1',
         'id' => key,
         'name' => 'Fixed',
-        'description' => 'A fix for this issue is checked into the tree and tested.', 
+        'description' => 'A fix for this issue is checked into the tree and tested.',
         'iconUrl' => 'http://www.example.com/jira/images/icons/status_resolved.gif'
       }
     end
 
     let(:expected_collection_length) { 2 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
   end
-end
+end

data/spec/integration/status_spec.rb

@@ -1,17 +1,15 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Status do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "1" }
+    let(:key) { '1' }
 
     let(:expected_attributes) do
       {
-        'self' => "http://localhost:2990/jira/rest/api/2/status/1",
+        'self' => 'http://localhost:2990/jira/rest/api/2/status/1',
         'id' => key,
         'name' => 'Open'
       }
@@ -19,9 +17,8 @@ describe JIRA::Resource::Status do
 
     let(:expected_collection_length) { 5 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
   end
 end

data/spec/integration/transition_spec.rb

@@ -1,24 +1,23 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Transition do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
     let(:key) { '10000' }
 
-    let(:target) { JIRA::Resource::Transition.new(client, :attrs => {'id' => '99999'}, :issue_id => '10014') }
+    let(:target) { JIRA::Resource::Transition.new(client, attrs: { 'id' => '99999' }, issue_id: '10014') }
 
-    let(:belongs_to) {
-      JIRA::Resource::Issue.new(client, :attrs => {
-        'id' => '10002',
-        'self' => "#{site_url}/jira/rest/api/2/issue/10002",
-        'fields' => {
-          'comment' => {'comments' => []}
-        }
-      })
-    }
+    let(:belongs_to) do
+      JIRA::Resource::Issue.new(client, attrs: {
+                                  'id' => '10002',
+                                  'self' => "#{site_url}/jira/rest/api/2/issue/10002",
+                                  'fields' => {
+                                    'comment' => { 'comments' => [] }
+                                  }
+                                })
+    end
 
     let(:expected_attributes) do
       {
@@ -27,26 +26,24 @@ describe JIRA::Resource::Transition do
       }
     end
 
-    let(:attributes_for_post) {
+    let(:attributes_for_post) do
       {
         'transition' => {
           'id' => '42'
         }
       }
-    }
+    end
 
-    it_should_behave_like "a resource"
+    it_should_behave_like 'a resource'
 
-    describe "POST endpoint" do
-      it "saves a new resource" do
+    describe 'POST endpoint' do
+      it 'saves a new resource' do
         stub_request(:post, /#{described_class.collection_path(client, prefix)}$/)
-          .with(:body => attributes_for_post.to_json)
-          .to_return(:status => 200, :body => get_mock_from_path(:post))
+          .with(body: attributes_for_post.to_json)
+          .to_return(status: 200, body: get_mock_from_path(:post))
         subject = build_receiver.build
         expect(subject.save(attributes_for_post)).to be_truthy
       end
     end
-
   end
-
 end

data/spec/integration/user_spec.rb

@@ -1,25 +1,41 @@
 require 'spec_helper'
 
 describe JIRA::Resource::User do
-
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "admin" }
+    let(:key) { 'admin' }
 
     let(:expected_attributes) do
       {
-        'self' => "http://localhost:2990/jira/rest/api/2/user?username=admin",
+        'self' => 'http://localhost:2990/jira/rest/api/2/user?username=admin',
         'name' => key,
         'emailAddress' => 'admin@example.com'
       }
     end
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a singular GET endpoint'
+
+    describe '#all' do
+      let(:client) do
+        client = double(options: { rest_base_path: '/jira/rest/api/2' })
+        allow(client).to receive(:get).with('/rest/api/2/users/search?username=_&maxResults=1000').and_return(JIRA::Resource::UserFactory.new(client))
+        client
+      end
+
+      before do
+        allow(client).to receive(:get)
+          .with('/rest/api/2/users/search?username=_&maxResults=1000') { OpenStruct.new(body: '["User1"]') }
+        allow(client).to receive_message_chain(:User, :build).with('users') { [] }
+      end
+
+      it 'gets users with maxResults of 1000' do
+        expect(client).to receive(:get).with('/rest/api/2/users/search?username=_&maxResults=1000')
+        expect(client).to receive_message_chain(:User, :build).with('User1')
+        JIRA::Resource::User.all(client)
+      end
+    end
   end
 end

data/spec/integration/version_spec.rb

@@ -1,43 +1,39 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Version do
-
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "10000" }
+    let(:key) { '10000' }
 
     let(:expected_attributes) do
       {
-        'self' => "http://localhost:2990/jira/rest/api/2/version/10000",
+        'self' => 'http://localhost:2990/jira/rest/api/2/version/10000',
         'id'   => key,
-        'description' => "Initial version"
+        'description' => 'Initial version'
       }
     end
 
-    let(:attributes_for_post) {
-      {"name" => "2.0", "project" => "SAMPLEPROJECT" }
-    }
-    let(:expected_attributes_from_post) {
-      { "id" => "10001", "name" => "2.0" }
-    }
-
-    let(:attributes_for_put) {
-      {"name" => "2.0.0" }
-    }
-    let(:expected_attributes_from_put) {
-      { "id" => "10000", "name" => "2.0.0" }
-    }
+    let(:attributes_for_post) do
+      { 'name' => '2.0', 'project' => 'SAMPLEPROJECT' }
+    end
+    let(:expected_attributes_from_post) do
+      { 'id' => '10001', 'name' => '2.0' }
+    end
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a singular GET endpoint"
-    it_should_behave_like "a resource with a DELETE endpoint"
-    it_should_behave_like "a resource with a POST endpoint"
-    it_should_behave_like "a resource with a PUT endpoint"
-    it_should_behave_like "a resource with a PUT endpoint that rejects invalid fields"
+    let(:attributes_for_put) do
+      { 'name' => '2.0.0' }
+    end
+    let(:expected_attributes_from_put) do
+      { 'id' => '10000', 'name' => '2.0.0' }
+    end
 
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a singular GET endpoint'
+    it_should_behave_like 'a resource with a DELETE endpoint'
+    it_should_behave_like 'a resource with a POST endpoint'
+    it_should_behave_like 'a resource with a PUT endpoint'
+    it_should_behave_like 'a resource with a PUT endpoint that rejects invalid fields'
   end
 end