jinda 0.7.7.4 → 1.0.0

data/app/controllers/concerns/jinda_run_concern.rb

@@ -1,32 +1,34 @@
+# frozen_string_literal: true
+
 module JindaRunConcern
   extend ActiveSupport::Concern
 
   def run_form
     init_vars(params[:id])
     if authorize?
-      if ['F', 'X'].include? @xmain.status
+      if %w[F X].include? @xmain.status
         redirect_to_root
       else
-        service= @xmain.service
+        service = @xmain.service
         ###############################################################################################
         # Run View Form f created template by jinda rake follow freemind mm file
         ###############################################################################################
         if service
-          @title= "Transaction ID #{@xmain.xid}: #{@xmain.name} / #{@runseq.name}"
-          fhelp= "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.md"
+          @title = "Transaction ID #{@xmain.xid}: #{@xmain.name} / #{@runseq.name}"
+          fhelp  = "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.md"
           ###############################################################################################
           # Check if help file available for this form
           ###############################################################################################
-          @help = File.read(fhelp) if File.exists?(fhelp)
-          f1= "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.erb"
-          f2= "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.haml"
+          @help  = File.read(fhelp) if File.exist?(fhelp)
+          f1     = "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.erb"
+          f2     = "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.haml"
           if File.file?(f1)
-            @ui= File.read(f1)
+            @ui = File.read(f1)
           elsif File.file?(f2)
-            @ui= File.read(f2)
+            @ui = File.read(f2)
           else
             # flash[:notice]= "Error: Can not find the view file for this controller"
-            ma_log "Error: Can not find the view file for this controller"
+            ma_log 'Error: Can not find the view file for this controller'
             redirect_to_root
           end
         end
@@ -39,27 +41,25 @@ module JindaRunConcern
 
   def run_if
     init_vars(params[:id])
-    condition= eval(@runseq.code).to_s
-    match_found= false
+    condition   = eval(@runseq.code).to_s
+    match_found = false
     if condition
-      xml= REXML::Document.new(@runseq.xml).root
-      next_runseq= nil
-      text = xml.elements['//node/node'].attributes['TEXT']
-      match, name= text.split(':',2)
-      label= name2code(name.strip)
-      if condition==match
-        if label=="end"
-          @end_job= true
+      xml         = REXML::Document.new(@runseq.xml).root
+      next_runseq = nil
+      text        = xml.elements['//node/node'].attributes['TEXT']
+      match, name = text.split(':', 2)
+      label       = name2code(name.strip)
+      if condition == match
+        if label == 'end'
+          @end_job = true
         else
-          next_runseq= @xmain.runseqs.where(:code=> label, :action.ne=>'redirect').first
-          match_found= true if next_runseq
-          @runseq_not_f= false
+          next_runseq   = @xmain.runseqs.where(:code => label, :action.ne => 'redirect').first
+          match_found   = true if next_runseq
+          @runseq_not_f = false
         end
       end
     end
-    unless match_found || @end_job
-      next_runseq= @xmain.runseqs.where( rstep:(@xvars['current_step']+1) ).first
-    end
+    next_runseq = @xmain.runseqs.where(rstep: (@xvars['current_step'] + 1)).first unless match_found || @end_job
     end_action(next_runseq)
   end
 
@@ -67,12 +67,12 @@ module JindaRunConcern
   # eg: http://localhost:3000/notes/my
   def run_direct_to
     init_vars(params[:id])
-    next_runseq= @xmain.runseqs.where(:id.ne=>@runseq.id, :code=>@runseq.code).first
-    if !@runseq.code.blank? 
-      @xvars['p']['return'] = @runseq.code
+    next_runseq = @xmain.runseqs.where(:id.ne => @runseq.id, :code => @runseq.code).first
+    if @runseq.code.blank?
+      flash[:notice] = 'Error: missing required forward path in Freemind'
+      ma_log 'Error: require forward path in Freemind'
     else
-      flash[:notice]= "Error: missing required forward path in Freemind"
-      ma_log "Error: require forward path in Freemind"
+      @xvars['p']['return'] = @runseq.code
     end
     end_action(next_runseq)
   end
@@ -80,199 +80,202 @@ module JindaRunConcern
   def run_redirect
     init_vars(params[:id])
     # next_runseq= @xmain.runseqs.first :conditions=>["id != ? AND code = ?",@runseq.id, @runseq.code]
-    next_runseq= @xmain.runseqs.where(:id.ne=>@runseq.id, :code=>@runseq.code).first
-    @xmain.current_runseq= next_runseq.id
+    next_runseq           = @xmain.runseqs.where(:id.ne => @runseq.id, :code => @runseq.code).first
+    @xmain.current_runseq = next_runseq.id
     end_action(next_runseq)
   end
 
-    # call controller to do the freemind task using Star symbol eg: Update
-    # not for run_form
+  # call controller to do the freemind task using Star symbol eg: Update
+  # not for run_form
   def run_do
     init_vars(params[:id])
-    @runseq.start ||= Time.now
-    @runseq.status= 'R' # running
-    $runseq_id= @runseq.id
-    $user_id= current_ma_user.try(:id)
+    @runseq.start             ||= Time.zone.now
+    @runseq.status              = 'R' # running
+    $runseq_id                  = @runseq.id
+    $user_id                    = current_ma_user.try(:id)
     # $xmain, $runseq, $user, $xvars, $ip from local
     set_global
-    controller = Kernel.const_get(@xvars['custom_controller']).new
-    result = controller.send(@runseq.code)
+    controller                  = Kernel.const_get(@xvars['custom_controller']).new
+    result                      = controller.send(@runseq.code)
     # save local var to database
     init_vars_by_runseq($runseq_id)
-    @xvars = $xvars
-    @xvars[@runseq.code.to_sym]= result.to_s
-    @xvars['current_step']= @runseq.rstep
-    @runseq.status= 'F' #finish
-    @runseq.stop= Time.now
+    @xvars                      = $xvars
+    @xvars[@runseq.code.to_sym] = result.to_s
+    @xvars['current_step']      = @runseq.rstep
+    @runseq.status              = 'F' # finish
+    @runseq.stop                = Time.zone.now
     @runseq.save
     end_action
-  rescue => e
-    @xmain.status='E'
-    @xvars['error']= e.to_s+e.backtrace.to_s
-    @xmain.xvars= $xvars
+  rescue StandardError => e
+    @xmain.status   = 'E'
+    @xvars['error'] = e.to_s + e.backtrace.to_s
+    @xmain.xvars    = $xvars
     @xmain.save
-    @runseq.status= 'F' #finish
-    @runseq.stop= Time.now
+    @runseq.status  = 'F' # finish
+    @runseq.stop    = Time.zone.now
     @runseq.save
-    refresh_to "/", :alert => "Sorry opeation error at  #{@xmain.id} #{@xvars['error']}"
+    refresh_to '/', alert: "Sorry opeation error at  #{@xmain.id} #{@xvars['error']}"
   end
 
   def run_list
     init_vars(params[:id])
-    service= @xmain.service
+    service    = @xmain.service
     # disp= get_option("display")
     # disp = Nil or :"??????"
     # get option from last node: rule, role, display
-    disp= get_option("display")
+    disp       = get_option('display')
     # change from Nil to false and string to true
-    ma_display = (disp && !affirm(disp)) ? false : true
+    ma_display = disp && !affirm(disp) ? false : true
     # Todo check if file is available
     # if service and file exist
     # ma_display from disp of 3rd level node as rule, role, display
-    if service && !@runseq.code.blank? 
-      f= "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.erb"
-      @ui= File.read(f)
-      if Jinda::Doc.where(:runseq_id=>@runseq.id).exists?
-        @doc= Jinda::Doc.where(:runseq_id=>@runseq.id).first
-        @doc.update_attributes :data_text=> render_to_string(:inline=>@ui, :layout=>"utf8"),
-          :xmain=>@xmain, :runseq=>@runseq, :user=>current_ma_user,
-          :ip=> get_ip, :service=>service, :ma_display=>ma_display,
-          :ma_secured => @xmain.service.ma_secured,
-          :filename => "#{@runseq.code}.html.erb"
+    if service && @runseq.code.present?
+      f        = "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.erb"
+      @ui      = File.read(f)
+      if Jinda::Doc.exists?(runseq_id: @runseq.id)
+        @doc = Jinda::Doc.where(runseq_id: @runseq.id).first
+        @doc.update data_text: render_to_string(inline: @ui, layout: 'utf8'),
+                    xmain: @xmain, runseq: @runseq, user: current_ma_user,
+                    ip: get_ip, service: service, ma_display: ma_display,
+                    ma_secured: @xmain.service.ma_secured,
+                    filename: "#{@runseq.code}.html.erb"
       else
-        @doc= Jinda::Doc.create :name=> @runseq.name,
-          :content_type=>"output", :data_text=> render_to_string(:inline=>@ui, :layout=>"utf8"),
-          :xmain=>@xmain, :runseq=>@runseq, :user=>current_ma_user,
-          :ip=> get_ip, :service=>service, :ma_display=>ma_display,
-          :ma_secured => @xmain.service.ma_secured,
-          :filename => "#{@runseq.code}.html.erb"
+        @doc = Jinda::Doc.create name: @runseq.name,
+                                 content_type: 'output', data_text: render_to_string(inline: @ui, layout: 'utf8'),
+                                 xmain: @xmain, runseq: @runseq, user: current_ma_user,
+                                 ip: get_ip, service: service, ma_display: ma_display,
+                                 ma_secured: @xmain.service.ma_secured,
+                                 filename: "#{@runseq.code}.html.erb"
       end
       # @message = defined?(MSG_NEXT) ? MSG_NEXT : "Next >"
-      @message = defined?(MSG_NEXT) ? MSG_NEXT : "Next >>"
-      @message = "Finish" if @runseq.end
-      ma_log("Todo defined?(NSG_NEXT : Next >>)")
+      @message = defined?(MSG_NEXT) ? MSG_NEXT : 'Next >>'
+      @message = 'Finish' if @runseq.end
+      ma_log('Todo defined?(NSG_NEXT : Next >>)')
       eval "@xvars[@runseq.code] = url_for(:controller=>'jinda', :action=>'document', :id=>@doc.id)"
     else
-      flash[:notice]= "Error: Can not find the view file for this controller"
-      ma_log "Error: Can not find the view file for this controller"
+      flash[:notice] = 'Error: Can not find the view file for this controller'
+      ma_log 'Error: Can not find the view file for this controller'
       redirect_to_root
     end
     # Check if ma_display available
     # ma_display= get_option("display")
     # if not ma_display then no display both controller-view and content then  end back to root
-    unless ma_display
-      end_action
-    end
+    return if ma_display
+
+    end_action
+
     # controller display from  @ui
   end
 
   def run_folder
     init_vars(params[:id])
-    service= @xmain.service
+    service    = @xmain.service
     # disp= get_option("display")
     # disp = Nil or :"??????"
-    disp= get_option("display")
-    ma_display = (disp && !affirm(disp)) ? false : true
+    disp       = get_option('display')
+    ma_display = disp && !affirm(disp) ? false : true
     # Todo check if file is available
     # if service and file exist
-    if service && !@runseq.code.blank? 
-      f= "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.erb"
-      @ui= File.read(f)
-      if Jinda::Doc.where(:runseq_id=>@runseq.id).exists?
-        @doc= Jinda::Doc.where(:runseq_id=>@runseq.id).first
-        @doc.update_attributes :data_text=> render_to_string(:inline=>@ui, :layout=>"utf8"),
-          :xmain=>@xmain, :runseq=>@runseq, :user=>current_ma_user,
-          :ip=> get_ip, :service=>service, :ma_display=>ma_display,
-          :ma_secured => @xmain.service.ma_secured,
-          :filename => "#{@runseq.code}.html.erb"
+    if service && @runseq.code.present?
+      f        = "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.erb"
+      @ui      = File.read(f)
+      if Jinda::Doc.exists?(runseq_id: @runseq.id)
+        @doc = Jinda::Doc.where(runseq_id: @runseq.id).first
+        @doc.update data_text: render_to_string(inline: @ui, layout: 'utf8'),
+                    xmain: @xmain, runseq: @runseq, user: current_ma_user,
+                    ip: get_ip, service: service, ma_display: ma_display,
+                    ma_secured: @xmain.service.ma_secured,
+                    filename: "#{@runseq.code}.html.erb"
       else
-        @doc= Jinda::Doc.create :name=> @runseq.name,
-          :content_type=>"output", :data_text=> render_to_string(:inline=>@ui, :layout=>"utf8"),
-          :xmain=>@xmain, :runseq=>@runseq, :user=>current_ma_user,
-          :ip=> get_ip, :service=>service, :ma_display=>ma_display,
-          :ma_secured => @xmain.service.ma_secured,
-          :filename => "#{@runseq.code}.html.erb"
+        @doc = Jinda::Doc.create name: @runseq.name,
+                                 content_type: 'output', data_text: render_to_string(inline: @ui, layout: 'utf8'),
+                                 xmain: @xmain, runseq: @runseq, user: current_ma_user,
+                                 ip: get_ip, service: service, ma_display: ma_display,
+                                 ma_secured: @xmain.service.ma_secured,
+                                 filename: "#{@runseq.code}.html.erb"
       end
       # @message = defined?(MSG_NEXT) ? MSG_NEXT : "Next >"
-      @message = defined?(MSG_NEXT) ? MSG_NEXT : "Next >>"
-      @message = "Finish" if @runseq.end
-      ma_log("Todo defined?(NSG_NEXT : Next >>)")
+      @message = defined?(MSG_NEXT) ? MSG_NEXT : 'Next >>'
+      @message = 'Finish' if @runseq.end
+      ma_log('Todo defined?(NSG_NEXT : Next >>)')
       eval "@xvars[@runseq.code] = url_for(:controller=>'jinda', :action=>'document', :id=>@doc.id)"
     else
-      flash[:notice]= "Error: Can not find the view file for this controller"
-      ma_log "Error: Can not find the view file for this controller"
+      flash[:notice] = 'Error: Can not find the view file for this controller'
+      ma_log 'Error: Can not find the view file for this controller'
       redirect_to_root
     end
     # Check if ma_display available
     # ma_display= get_option("display")
-    unless ma_display
-      end_action
-    end
+    return if ma_display
+
+    end_action
+
     # controller display from  @ui
   end
 
   def run_output
     init_vars(params[:id])
-    service= @xmain.service
+    service    = @xmain.service
     # disp= get_option("display")
     # disp = Nil or :"??????"
-    disp= get_option("display")
-    ma_display = (disp && !affirm(disp)) ? false : true
+    disp       = get_option('display')
+    ma_display = disp && !affirm(disp) ? false : true
     # Todo check if file is available
     # if service and file exist
-    if service && !@runseq.code.blank? 
-      f= "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.erb"
-      @ui= File.read(f)
-      if Jinda::Doc.where(:runseq_id=>@runseq.id).exists?
-        @doc= Jinda::Doc.where(:runseq_id=>@runseq.id).first
-        @doc.update_attributes :data_text=> render_to_string(:inline=>@ui, :layout=>"utf8"),
-          :xmain=>@xmain, :runseq=>@runseq, :user=>current_ma_user,
-          :ip=> get_ip, :service=>service, :ma_display=>ma_display,
-          :ma_secured => @xmain.service.ma_secured,
-          :filename => "#{@runseq.code}.html.erb"
+    if service && @runseq.code.present?
+      f        = "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.erb"
+      @ui      = File.read(f)
+      if Jinda::Doc.exists?(runseq_id: @runseq.id)
+        @doc = Jinda::Doc.where(runseq_id: @runseq.id).first
+        @doc.update data_text: render_to_string(inline: @ui, layout: 'utf8'),
+                    xmain: @xmain, runseq: @runseq, user: current_ma_user,
+                    ip: get_ip, service: service, ma_display: ma_display,
+                    ma_secured: @xmain.service.ma_secured,
+                    filename: "#{@runseq.code}.html.erb"
       else
-        @doc= Jinda::Doc.create :name=> @runseq.name,
-          :content_type=>"output", :data_text=> render_to_string(:inline=>@ui, :layout=>"utf8"),
-          :xmain=>@xmain, :runseq=>@runseq, :user=>current_ma_user,
-          :ip=> get_ip, :service=>service, :ma_display=>ma_display,
-          :ma_secured => @xmain.service.ma_secured,
-          :filename => "#{@runseq.code}.html.erb"
+        @doc = Jinda::Doc.create name: @runseq.name,
+                                 content_type: 'output', data_text: render_to_string(inline: @ui, layout: 'utf8'),
+                                 xmain: @xmain, runseq: @runseq, user: current_ma_user,
+                                 ip: get_ip, service: service, ma_display: ma_display,
+                                 ma_secured: @xmain.service.ma_secured,
+                                 filename: "#{@runseq.code}.html.erb"
       end
       # @message = defined?(MSG_NEXT) ? MSG_NEXT : "Next >"
-      @message = defined?(MSG_NEXT) ? MSG_NEXT : "Next >>"
-      @message = "Finish" if @runseq.end
-      ma_log("Todo defined?(NSG_NEXT : Next >>)")
+      @message = defined?(MSG_NEXT) ? MSG_NEXT : 'Next >>'
+      @message = 'Finish' if @runseq.end
+      ma_log('Todo defined?(NSG_NEXT : Next >>)')
       eval "@xvars[@runseq.code] = url_for(:controller=>'jinda', :action=>'document', :id=>@doc.id)"
     else
-      flash[:notice]= "Error: Can not find the view file for this controller"
-      ma_log "Error: Can not find the view file for this controller"
+      flash[:notice] = 'Error: Can not find the view file for this controller'
+      ma_log 'Error: Can not find the view file for this controller'
       redirect_to_root
     end
     # Check if ma_display available
     # ma_display= get_option("display")
-    unless ma_display
-      end_action
-    end
+    return if ma_display
+
+    end_action
+
     # controller display from  @ui
   end
 
   def run_mail
     init_vars(params[:id])
-    service= @xmain.service
-    f= "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.erb"
-    @ui= File.read(f).html_safe
-    @doc= Jinda::Doc.create :name=> @runseq.name,
-      :content_type=>"mail", :data_text=> render_to_string(:inline=>@ui, :layout=>false),
-      :xmain=>@xmain, :runseq=>@runseq, :user=>current_ma_user,
-      :ip=> get_ip, :service=>service, :ma_display=>false,
-      :ma_secured => @xmain.service.ma_secured
+    service      = @xmain.service
+    f            = "app/views/#{service.module.code}/#{service.code}/#{@runseq.code}.html.erb"
+    @ui          = File.read(f).html_safe
+    @doc         = Jinda::Doc.create name: @runseq.name,
+                                     content_type: 'mail', data_text: render_to_string(inline: @ui, layout: false),
+                                     xmain: @xmain, runseq: @runseq, user: current_ma_user,
+                                     ip: get_ip, service: service, ma_display: false,
+                                     ma_secured: @xmain.service.ma_secured
     eval "@xvars[:#{@runseq.code}] = url_for(:controller=>'jinda', :action=>'document', :id=>@doc.id)"
-    mail_from = get_option('from')
+    get_option('from')
     # sender= render_to_string(:inline=>mail_from) if mail_from
-    mail_to = get_option('to')
-    recipients= render_to_string(:inline=>mail_to) if mail_to
+    mail_to      = get_option('to')
+    recipients   = render_to_string(inline: mail_to) if mail_to
     mail_subject = get_option('subject')
-    subject= render_to_string(:inline=>mail_subject) || "#{@runseq.name}"
+    subject      = render_to_string(inline: mail_subject) || @runseq.name.to_s
     JindaMailer.gmail(@doc.data_text, recipients, subject).deliver unless DONT_SEND_MAIL
     end_action
   end
@@ -290,24 +293,24 @@ module JindaRunConcern
     if params[:xmain_id]
       init_vars(params[:xmain_id])
     else
-      ma_log "Known Bug : repeated end_form "
+      ma_log 'Known Bug : repeated end_form '
       redirect_to_root and return
     end
-    eval "@xvars[@runseq.code] = {} unless @xvars[@runseq.code]"
+    eval '@xvars[@runseq.code] = {} unless @xvars[@runseq.code]'
     # Search for uploaded file name if exist
-    params.each { |k,v|
+    params.each do |k, v|
       if params[k].respond_to? :original_filename
         get_image(k, params[k])
-        # check if params of array in form eg: edit_article	
+        # check if params of array in form eg: edit_article
       elsif params[k].is_a?(ActionController::Parameters)
-        eval "@xvars[@runseq.code][k] = {} unless @xvars[@runseq.code][k]"
-        params[k].each { |k1,v1|
+        eval '@xvars[@runseq.code][k] = {} unless @xvars[@runseq.code][k]'
+        params[k].each do |k1, v1|
           # eval "@xvars[@runseq.code][k1] = params.require(k1).permit(k1)"
-          eval "@xvars[@runseq.code][k][k1] = v1" 
+          eval '@xvars[@runseq.code][k][k1] = v1'
           next unless v1.respond_to?(:original_filename)
-          doc = {}
+
           get_image1(k, k1, params[k][k1])
-        }
+        end
       else
         # No file attached
         #
@@ -316,53 +319,50 @@ module JindaRunConcern
         # https://stackoverflow.com/questions/34949505/rails-5-unable-to-retrieve-hash-values-from-parameter
         # v = v.to_unsafe_h unless v.class == String
         # v = params.require[k] unless v.class == String
-        v = v.to_s unless v.class == String
+        v.to_s unless v.instance_of?(String)
         # Create @xvars[@runseq.code]
-        eval "@xvars[@runseq.code][k] = v"
+        eval '@xvars[@runseq.code][k] = v'
       end
-    }
-  end_action
-  rescue => e
-    @xmain.status='E'
-    @xvars['error']= e.to_s+e.backtrace.to_s
-    @xmain.xvars= $xvars
+    end
+    end_action
+  rescue StandardError => e
+    @xmain.status   = 'E'
+    @xvars['error'] = e.to_s + e.backtrace.to_s
+    @xmain.xvars    = $xvars
     @xmain.save
-    @runseq.status= 'F' #finish
-    @runseq.stop= Time.now
+    @runseq.status  = 'F' # finish
+    @runseq.stop    = Time.zone.now
     @runseq.save
-    ma_log "Error:end_form "
-    refresh_to "/", :alert => "Sorry opeation error at  #{@xmain.id} #{@xvars['error']}"
+    ma_log 'Error:end_form '
+    refresh_to '/', alert: "Sorry opeation error at  #{@xmain.id} #{@xvars['error']}"
   end
 
   def end_action(next_runseq = nil)
     # not for form
     #    @runseq.status='F' unless @runseq_not_f
-    @xmain.xvars= @xvars
-    @xmain.status= 'R' # running
+    @xmain.xvars   = @xvars
+    @xmain.status  = 'R' # running
     @xmain.save!
-    @runseq.status='F'
-    @runseq.user= current_ma_user
-    @runseq.stop= Time.now
+    @runseq.status = 'F'
+    @runseq.user   = current_ma_user
+    @runseq.stop   = Time.zone.now
     @runseq.save
-    next_runseq= @xmain.runseqs.where(:rstep=> @runseq.rstep+1).first unless next_runseq
+    next_runseq ||= @xmain.runseqs.where(rstep: @runseq.rstep + 1).first
     if @end_job || !next_runseq # job finish
-      @xmain.xvars= @xvars
-      @xmain.status= 'F' unless @xmain.status== 'E' # finish
-      @xmain.stop= Time.now
+      @xmain.xvars  = @xvars
+      @xmain.status = 'F' unless @xmain.status == 'E' # finish
+      @xmain.stop   = Time.zone.now
       @xmain.save
       if @xvars['p']['return']
         redirect_to @xvars['p']['return'] and return
+      elsif @user
+        redirect_to action: 'index' and return
       else
-        if @user
-          redirect_to :action=>'index' and return
-        else
-          redirect_to_root and return
-        end
+        redirect_to_root and return
       end
     else
       @xmain.update_attribute :current_runseq, next_runseq.id
-      redirect_to :action=>'run', :id=>@xmain.id and return
+      redirect_to action: 'run', id: @xmain.id and return
     end
   end
-
-end 
+end

data/app/controllers/jinda_controller.rb

@@ -1,50 +1,51 @@
-# -*- encoding : utf-8 -*-
+# frozen_string_literal: true
 
 class JindaController < ApplicationController
   include JindaRunConcern
   include JindaGeneralConcern
+
   # view menu by user selected what service (module and code) to run (not all services like menu did
-  # Its only one service 
+  # Its only one service
 
   def init
-    module_code, code = params[:s].split(":")
-    @service= Jinda::Service.where(:module_code=> module_code, :code=> code).first
+    module_code, code = params[:s].split(':')
+    @service          = Jinda::Service.where(module_code: module_code, code: code).first
     if @service && authorize_init?
-      xmain = create_xmain(@service)
+      xmain  = create_xmain(@service)
       result = create_runseq(xmain)
       unless result
         message = "Node missing action icon: cannot find action for xmain #{xmain.id}, the node required action(icon) in freemind eg: form, list, method"
         ma_log(message)
-        flash[:notice]= message
-        redirect_to "pending" and return
+        flash[:notice] = message
+        redirect_to 'pending' and return
       end
       xmain.update_attribute(:xvars, @xvars)
-      xmain.runseqs.last.update_attribute(:end,true)
-      #Above line cause error update_attribute in heroku shown in logs and it was proposed to fixed in github:'kul1/g241502'
+      xmain.runseqs.last.update_attribute(:end, true)
+      # Above line cause error update_attribute in heroku shown in logs and it was proposed to fixed in github:'kul1/g241502'
       # Main action run with :id
-      redirect_to :action=>'run', :id=>xmain.id
-      
+      redirect_to action: 'run', id: xmain.id
+
     else
-      refresh_to "/", :alert => "Error: cannot process"
-      error_run_xmain = "Error_run_xmain"
+      refresh_to '/', alert: 'Error: cannot process'
+      error_run_xmain = 'Error_run_xmain'
       ma_log(error_run_xmain)
     end
   end
 
-  ########################################################################]
+  # #######################################################################]
   # run if, form, mail, output etc depend on icon in freemind
   # action from @r.action == do, form, if, output
   # Then will call def run_do, run_form, run_if, run_output
-  ########################################################################]
-  # 
-  # run 
-  #   init_vars 
+  # #######################################################################]
+  #
+  # run
+  #   init_vars
   #   To get all var from global and runseq, action
   #     (@runseq.action)
-  # 
+  #
   #   run_do, run_form, run_if, run_output
   #     run_do => controller => action eg: update, create, document
-  #     run_form => 
+  #     run_form =>
   #       run_form.haml => - next step => def end_form
   #       - next_step = end_form
   #     run_if =>
@@ -52,13 +53,13 @@ class JindaController < ApplicationController
   #
   #   end_action
   #   => save local var to database :current_runseq
-  #   :current_runseq => next_runseq 
+  #   :current_runseq => next_runseq
   #
   def run
     init_vars(params[:id])
     if authorize?
       # session[:full_layout]= false
-      redirect_to(:action=>"run_#{@runseq.action}", :id=>@xmain.id)
+      redirect_to(action: "run_#{@runseq.action}", id: @xmain.id)
     else
       redirect_to_root
     end

data/bin/lint_modified

@@ -0,0 +1,21 @@
+#!/usr/bin/env ruby
+require "timeout"
+
+modified = `git status --porcelain`.lines.filter_map { |l| l.split.last }.uniq
+files    = modified.select { |p| p.end_with?(".rb") }
+
+if files.empty?
+  puts "No modified Ruby files."
+  exit 0
+end
+
+files.each do |file|
+  puts "RuboCop: #{file}"
+  begin
+    Timeout.timeout(30) do
+      system("rubocop", "--config", File.expand_path("~/.rubocop.yml"), "-A", file)
+    end
+  rescue Timeout::Error
+    puts "Timeout on #{file} (over 30s). Skipping; fix manually."
+  end
+end