jinda 0.7.7.4 → 1.0.0

data/lib/generators/jinda/templates/spec/controllers/api/v1_get_index_spec.rb

@@ -1,23 +1,24 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 # describe Api::V1::NotesController, '#index', type: :request do
 RSpec.describe 'Notes API', type: :request do
-	# let(:notes) { create_list(:note,1)}
+  # let(:notes) { create_list(:note,1)}
   # let!(:notes) {Note.create(title: "dddd", body: "body")}
-  let!(:note) {FactoryBot.create_list(:note, 9)}
-	let(:note_id) { notes.first.id }
+  let!(:admin_user) { User.create(code: 'admin', email: 'admin@example.com', role: 'Admin') }
+  let!(:note) { FactoryBot.create_list(:note, 9, user: admin_user) }
+  let(:note_id) { notes.first.id }
+
+  describe 'GET /api/v1/notes' do
+    before { get api_v1_notes_path }
 
-	describe 'GET /api/v1/notes' do
- 		before { get api_v1_notes_path }
-		
-		it 'returns notes size as expected' do
-			expect(json).not_to be_empty
-			expect(json.size).to eq(9)
-		end
+    it 'returns notes size as expected' do
+      expect(json).not_to be_empty
+      expect(json.size).to eq(9)
+    end
 
     it 'returns status code 200' do
       expect(response).to have_http_status(:success)
-    end 
-
-	end
+    end
+  end
 end
-

data/lib/generators/jinda/templates/spec/controllers/api/v1_get_my_spec.rb

@@ -1,14 +1,19 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe 'Notes API', type: :request do
-  let!(:note) {FactoryBot.create_list(:note, 9)}
-  before {get api_v1_notes_my_path}
+  let!(:admin_user) { User.create(code: 'admin', email: 'admin@example.com', role: 'Admin') }
+  let!(:note) { FactoryBot.create_list(:note, 9, user: admin_user) }
+  before do
+    allow_any_instance_of(Api::V1::NotesController).to receive(:current_ma_user).and_return(admin_user)
+    get api_v1_notes_my_path
+  end
 
   it 'returns all notes' do
-			expect(json.size).to eq(9)
+    expect(json.size).to eq(9)
   end
   it 'returns status code 200' do
     expect(response).to have_http_status(:success)
   end
 end
-

data/lib/generators/jinda/templates/spec/controllers/api/v1_post_spec.rb

@@ -1,9 +1,10 @@
-require 'rails_helper'
-describe Api::V1::NotesController , type: :controller do
+# frozen_string_literal: true
 
+require 'rails_helper'
+describe Api::V1::NotesController, type: :controller do
   before do
     create_and_sign_in_user
-    post :create , params: { :body => 'test_body', :title => 'test_title', :user => User.first}
+    post :create, params: { body: 'test_body', title: 'test_title', user: User.first }
   end
 
   it 'returns the title' do

data/lib/generators/jinda/templates/spec/controllers/sessions_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # sessions_controller_spec.rb
 # 1. Set up the mock
 # 2. Make the request
@@ -5,94 +7,84 @@
 # require 'spec_helper'
 require 'rails_helper'
 describe SessionsController, type: :controller do
-
-	describe "Google"  do
-
-		before do
-	
-			@request.env['omniauth.auth'] = OmniAuth.config.mock_auth[:google_oauth2]
-			visit '/auth/google_oauth2'
-		end
-
-		describe "#create" do
-
-			it "should successfully create a session" do
-				session[:user_id].should be_nil
-				post :create, params: {provider: :google_oauth2}
-				session[:user_id].should_not be_nil
-			end
-
-			it "should redirect the user to root_path " do
-				post :create, params: {provider: :google_oauth2}
-				response.should redirect_to root_path 
-			end
-
-		end
-
-		#describe "#destroy", js: true  do
-		describe "#destroy"  do
-			before do
-				post :create, params: {provider: :google_oauth2}
-			end
-
-			it "should clear the session" do
-				session[:user_id].should_not be_nil
-				delete :destroy
-				session[:user_id].should be_nil
-			end
-
-			it "should redirect to the home page" do
-				delete :destroy
-				# response.should redirect_to root_url
-				# https://stackoverflow.com/questions/5144758/how-to-test-a-javascript-redirect-with-rspec
-				response.body.should include("window.location")
-			end
-		end
-	end
-
-	skip describe "Facebook" do
-  # skip or finish at config facebook
-
-		before do
-			@request.env['omniauth.auth'] = OmniAuth.config.mock_auth[:facebook]
-			visit '/auth/facebook'
-		end
-
-		describe "#create" do
-
-			it "should successfully create a session" do
-				session[:user_id].should be_nil
-				post :create, params: {provider: :facebook}
-				session[:user_id].should_not be_nil
-			end
-
-			it "should redirect the user to the articles/my url" do
-				post :create, params: {provider: :facebook}
-				response.should redirect_to articles_my_path
-			end
-
-		end
-
-		describe "#destroy" do
-			before do
-				post :create, params: {provider: :facebook}
-			end
-
-			it "should clear the session" do
-				session[:user_id].should_not be_nil
-				delete :destroy
-				session[:user_id].should be_nil
-			end
-
-			it "should redirect to the home page" do
-				delete :destroy
-				# response.should redirect_to root_url
-				# https://stackoverflow.com/questions/5144758/how-to-test-a-javascript-redirect-with-rspec
-				response.body.should include("window.location")
-			end
-		end
-	end
-
+  describe 'Google' do
+    before do
+      @request.env['omniauth.auth'] = OmniAuth.config.mock_auth[:google_oauth2]
+      visit '/auth/google_oauth2'
+    end
+
+    describe '#create' do
+      it 'should successfully create a session' do
+        session[:user_id].should be_nil
+        post :create, params: { provider: :google_oauth2 }
+        session[:user_id].should_not be_nil
+      end
+
+      it 'should redirect the user to root_path ' do
+        post :create, params: { provider: :google_oauth2 }
+        response.should redirect_to root_path
+      end
+    end
+
+    # describe "#destroy", js: true  do
+    describe '#destroy' do
+      before do
+        post :create, params: { provider: :google_oauth2 }
+      end
+
+      it 'should clear the session' do
+        session[:user_id].should_not be_nil
+        delete :destroy
+        session[:user_id].should be_nil
+      end
+
+      it 'should redirect to the home page' do
+        delete :destroy
+        # response.should redirect_to root_url
+        # https://stackoverflow.com/questions/5144758/how-to-test-a-javascript-redirect-with-rspec
+        response.body.should include('window.location')
+      end
+    end
+  end
+
+  skip describe 'Facebook' do
+    # skip or finish at config facebook
+
+    before do
+      @request.env['omniauth.auth'] = OmniAuth.config.mock_auth[:facebook]
+      visit '/auth/facebook'
+    end
+
+    describe '#create' do
+      it 'should successfully create a session' do
+        session[:user_id].should be_nil
+        post :create, params: { provider: :facebook }
+        session[:user_id].should_not be_nil
+      end
+
+      it 'should redirect the user to the articles/my url' do
+        post :create, params: { provider: :facebook }
+        response.should redirect_to articles_my_path
+      end
+    end
+
+    describe '#destroy' do
+      before do
+        post :create, params: { provider: :facebook }
+      end
+
+      it 'should clear the session' do
+        session[:user_id].should_not be_nil
+        delete :destroy
+        session[:user_id].should be_nil
+      end
+
+      it 'should redirect to the home page' do
+        delete :destroy
+        # response.should redirect_to root_url
+        # https://stackoverflow.com/questions/5144758/how-to-test-a-javascript-redirect-with-rspec
+        response.body.should include('window.location')
+      end
+    end
+  end
 end
-
-

data/lib/generators/jinda/templates/spec/features/userlogins_spec.rb

@@ -1,23 +1,20 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.feature "Userlogins", type: :feature do
-  scenario "Admin User Sign In" do
-    skip visit "/sessions/new"
+RSpec.feature 'Userlogins', type: :feature do
+  scenario 'Admin User Sign In' do
+    skip visit '/sessions/new'
 
-    fill_in "User name", :with => "admin"
-    fill_in "Password", :with => "secret1"
-    click_button "Sign In"
+    fill_in 'User name', with: 'admin'
+    fill_in 'Password', with: 'secret1'
+    click_button 'Sign In'
 
-   xexpect(page).to have_text("My Articles")
+    xexpect(page).to have_text('My Articles')
   end
 
-  scenario "Google User Sign In" do
-    visit "/auth/google_oauth2"
-    expect(page).to have_text("My Articles")
+  scenario 'Google User Sign In' do
+    visit '/auth/google_oauth2'
+    expect(page).to have_text('Sign Out')
   end
-
-
-
-
-
 end

data/lib/generators/jinda/templates/spec/mailers/note_spec.rb

@@ -1,12 +1,10 @@
-require 'rails_helper'
+# frozen_string_literal: true
 
-RSpec.describe NoteMailer  do
-  
+require 'rails_helper'
 
+RSpec.describe NoteMailer do
   describe 'gmail' do
-
-    let(:mail) {NoteMailer.gmail("Test Body", "receiver@email.com", "Test title", "from@example.com")}
-  
+    let(:mail) { NoteMailer.gmail('Test Body', 'receiver@email.com', 'Test title', 'from@example.com') }
 
     it 'renders the subject' do
       expect(mail.subject).to eql('Test title')
@@ -19,6 +17,5 @@ RSpec.describe NoteMailer  do
     it 'renders the sender email' do
       expect(mail.from).to eql(['from@example.com'])
     end
-	end
-
+  end
 end

data/lib/generators/jinda/templates/spec/mailers/previews/note_preview.rb

@@ -1,9 +1,7 @@
+# frozen_string_literal: true
+
 # Preview all emails at http://localhost:3000/rails/mailers/note
 class NotePreview < ActionMailer::Preview
-
   # Preview this email at http://localhost:3000/rails/mailers/note/gmail
-  def gmail
-    NoteMailer.gmail
-  end
-
+  delegate :gmail, to: :NoteMailer
 end

data/lib/generators/jinda/templates/spec/models/note_spec.rb

@@ -1,41 +1,42 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe Note, type: :model do
-	describe "Required only  title (Maximum 30)" do
-
-		it "valid with  both title and body" do
-			before_count = Note.count
-			Note.create(title: "dddd", body: "body")
-			expect(Note.count).not_to eq(before_count)
-		end
-
-		it "valid with  only title" do
-			before_count = Note.count
-			Note.create(title: "Title")
-			expect(Note.count).not_to eq(before_count)
-		end
-
-		it "invalid with  only body" do
-			before_count = Note.count
-			Note.new(body: "body")
-			expect(Note.count).to eq(before_count)
-		end
-
-		it "invalid body length more than 1000" do
-			before_count = Note.count
-			title_max = "x"*30
-			body_max  = "y"*1001
-			Note.create(title: title_max, body: body_max)
-			expect(Note.count).to eq(before_count)
-		end
+  let!(:admin_user) { User.create(code: 'admin', email: 'admin@example.com', role: 'Admin') }
+
+  describe 'Required only  title (Maximum 30)' do
+    it 'valid with  both title and body' do
+      before_count = Note.count
+      Note.create(title: 'dddd', body: 'body', user: admin_user)
+      expect(Note.count).not_to eq(before_count)
+    end
+
+    it 'valid with  only title' do
+      before_count = Note.count
+      Note.create(title: 'Title', user: admin_user)
+      expect(Note.count).not_to eq(before_count)
+    end
+
+    it 'invalid with  only body' do
+      before_count = Note.count
+      Note.new(body: 'body', user: admin_user)
+      expect(Note.count).to eq(before_count)
+    end
+
+    it 'invalid body length more than 1000' do
+      before_count = Note.count
+      title_max    = 'x' * 30
+      body_max     = 'y' * 1001
+      Note.create(title: title_max, body: body_max, user: admin_user)
+      expect(Note.count).to eq(before_count)
+    end
   end
 
-	describe "title data  blank" do
-		it "auto fill from body" do
-			note = Note.create(:title => "", :body => "Body content")
-			note.title.should == "Body content"
-		end
-	end
-
+  describe 'title data  blank' do
+    it 'auto fill from body' do
+      note = Note.create(title: '', body: 'Body content', user: admin_user)
+      note.title.should == 'Body content'
+    end
+  end
 end
-

data/lib/generators/jinda/templates/spec/models/user_spec.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe "User", :type => :model do
-  it "prevents duplicates " do
-		user1 = create(:user, code: 'abc', email: 'test@email.com')
-		user2 = build(:user, code: 'abc', email: 'test@email.com')
+RSpec.describe 'User', type: :model do
+  it 'prevents duplicates ' do
+    user1 = create(:user, code: 'abc', email: 'test@email.com')
+    user2 = build(:user, code: 'abc', email: 'test@email.com')
 
-		user1.should be_valid
-		#user2.should be_valid
-		user2.should_not  have_valid(:code)
-	end
+    user1.should be_valid
+    # user2.should be_valid
+    user2.should_not have_valid(:code)
+  end
 end

data/lib/generators/jinda/templates/spec/rails_helper.rb

@@ -1,42 +1,40 @@
+# frozen_string_literal: true
+
 # This file is copied to spec/ when you run 'rails generate rspec:install'
 ENV['RAILS_ENV'] ||= 'test'
-require File.expand_path('../../config/environment', __FILE__)
-Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f } # Add this at top of file
+require File.expand_path('../config/environment', __dir__)
+Rails.root.glob('spec/support/**/*.rb').each { |f| require f } # Add this at top of file
 # Prevent database truncation if the environment is production
-abort("The Rails environment is running in production mode!") if Rails.env.production?
+abort('The Rails environment is running in production mode!') if Rails.env.production?
 require 'rspec/rails'
 require 'spec_helper'
 
 RSpec.configure  do |config|
-  
   # Add create_and_sign_in_user
   config.include AuthenticationHelper, type: :controller
 
-	# To include RequestSpecHelper
-	config.include RequestSpecHelper, type: :request
-
-	# config.infer_spec_type_from_file_location!
-
-	# Filter lines from Rails gems in backtraces.
-	config.filter_rails_from_backtrace!
-	# arbitrary gems may also be filtered via:
-	# config.filter_gems_from_backtrace("gem name")
-
-
-
-	# Added to make factorybot work
-	# FactoryBot.allow_class_lookup = false 
-	config.use_transactional_fixtures = false
-	config.include FactoryBot::Syntax::Methods
-	config.before do
-		FactoryBot.find_definitions
-	end
-	# configure shoulda matchers to use rspec as the test framework and full matcher libraries for rails
-	Shoulda::Matchers.configure do |config|
-		config.integrate do |with|
-			with.test_framework :rspec
-			with.library :rails
-		end
-	end
-
+  # To include RequestSpecHelper
+  config.include RequestSpecHelper, type: :request
+
+  # config.infer_spec_type_from_file_location!
+
+  # Filter lines from Rails gems in backtraces.
+  config.filter_rails_from_backtrace!
+  # arbitrary gems may also be filtered via:
+  # config.filter_gems_from_backtrace("gem name")
+
+  # Added to make factorybot work
+  # FactoryBot.allow_class_lookup = false
+  config.use_transactional_fixtures = false
+  config.include FactoryBot::Syntax::Methods
+  config.before do
+    FactoryBot.find_definitions
+  end
+  # configure shoulda matchers to use rspec as the test framework and full matcher libraries for rails
+  Shoulda::Matchers.configure do |config|
+    config.integrate do |with|
+      with.test_framework :rspec
+      with.library :rails
+    end
+  end
 end

data/lib/generators/jinda/templates/spec/spec_helper.rb

@@ -1,36 +1,38 @@
+# frozen_string_literal: true
+
 # https://www.natashatherobot.com/rails-test-omniauth-sessions-controller/
 # spec_helper.rb
 require 'rubygems'
-require 'capybara/rspec' 
-# Set up the mock  
+require 'capybara/rspec'
+# Set up the mock
 require 'support/omniauth_macros'
 require 'valid_attribute'
 
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-	config.filter_run focus: true
+  config.filter_run focus: true
   config.run_all_when_everything_filtered = true
 
   # config.include SpecTestHelper, :type => :controller
   config.expect_with :rspec do |expectations|
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
-    expectations.syntax = [:expect, :should]
+    expectations.syntax                                               = %i[expect should]
   end
   config.mock_with :rspec do |mocks|
     mocks.verify_partial_doubles = true
   end
   config.shared_context_metadata_behavior = :apply_to_host_groups
 
-# https://github.com/DatabaseCleaner/database_cleaner #
-#  config.use_transactional_fixtures = false
-	# https://stackoverflow.com/questions/15148585/undefined-method-visit-when-using-rspec-and-capybara-in-rails
-	config.include Capybara::DSL
+  # https://github.com/DatabaseCleaner/database_cleaner #
+  #  config.use_transactional_fixtures = false
+  # https://stackoverflow.com/questions/15148585/undefined-method-visit-when-using-rspec-and-capybara-in-rails
+  config.include Capybara::DSL
 
-	# https://stackoverflow.com/questions/21445164/set-chrome-as-default-browser-for-rspec-capybara/30551595
-	Capybara.register_driver :chrome do |app|
-		  Capybara::Selenium::Driver.new(app, :browser => :chrome)
-	end
-	Capybara.javascript_driver = :chrome
+  # https://stackoverflow.com/questions/21445164/set-chrome-as-default-browser-for-rspec-capybara/30551595
+  Capybara.register_driver :chrome do |app|
+    Capybara::Selenium::Driver.new(app, browser: :chrome)
+  end
+  Capybara.javascript_driver = :chrome
 
   config.before(:suite) do
     if config.use_transactional_fixtures?
@@ -45,11 +47,12 @@ RSpec.configure do |config|
         uncommitted transaction data setup over the spec's database connection.
       MSG
     end
+
     DatabaseCleaner.clean_with(:deletion)
   end
 
-  config.before(:each, :js => true) do
-    #DatabaseCleaner.strategy = :transaction
+  config.before(:each, js: true) do
+    # DatabaseCleaner.strategy = :transaction
     DatabaseCleaner.strategy = :deletion
   end
 
@@ -75,6 +78,5 @@ RSpec.configure do |config|
   config.append_after(:each) do
     DatabaseCleaner.clean
   end
-#  https://github.com/DatabaseCleaner/database_cleaner #
-
+  #  https://github.com/DatabaseCleaner/database_cleaner #
 end

data/lib/generators/jinda/templates/spec/support/authentication_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AuthenticationHelper
   # controller return 1. Session 2. Cookies ==> user.id
   def sign_in(user)
@@ -8,13 +10,12 @@ module AuthenticationHelper
   def create_and_sign_in_user
     user = FactoryBot.create(:user)
     sign_in(user)
-    return user
-  end
-	# from Jinda::Helpers
-  def  current_ma_user 
-       @user ||= User.where(:auth_token => user.auth_token)
-       return @user
+    user
   end
 
+  # from Jinda::Helpers
+  def current_ma_user
+    @user ||= User.where(auth_token: user.auth_token)
+    @user
+  end
 end
-

data/lib/generators/jinda/templates/spec/support/databasecleaner.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 RSpec.configure do |config|
-    config.before(:suite) do
+  config.before(:suite) do
     DatabaseCleaner[:mongoid].strategy = :deletion
   end
 

data/lib/generators/jinda/templates/spec/support/factory_bot.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :user, class: 'User' do
-    code {Faker::Name.unique.name}
-    email {Faker::Internet.email}
-    role {"Admin"}
+    code { Faker::Name.unique.name }
+    email { Faker::Internet.email }
+    role { 'Admin' }
   end
-  factory :note,  class: 'Note' do
+  factory :note, class: 'Note' do
     title { Faker::Lorem.sentence[0..29] }
     body { Faker::Lorem.sentence[0..999] }
-    user { User.first }
+    association :user
   end
 end