itunes_store_transporter 0.1.3 → 0.2.0

data/spec/output_parser_spec.rb

@@ -7,20 +7,36 @@ describe ITunes::Store::Transporter::OutputParser do
     context "without an error code" do
       before(:all) { @parser = described_class.new(fixture("errors_and_warnings.no_error_number")) }
 
-      subject { @parser }
-      its(:warnings) { should be_empty }
-      its(:errors) { should have(2).items }
+      it "has no warnings" do
+        expect(@parser.warnings).to be_empty
+      end
+
+      it "has two errors" do
+        expect(@parser.errors.size).to eq 2
+      end
 
       describe "the first error" do
-        subject { @parser.errors.first }
-        its(:code) { should be_nil }
-        its(:message) { should == "An error occurred while doing fun stuff" }
+        before { @error = @parser.errors[0] }
+
+        it "has a nil code" do
+          expect(@error.code).to be_nil
+        end
+
+        it "has the right error message" do
+          expect(@error.message).to eq "An error occurred while doing fun stuff"
+        end
       end
 
       describe "the second error" do
-        subject { @parser.errors.last }
-        its(:code) { should be_nil }
-        its(:message) { should == "An exception has occurred: network timeout" }
+        before { @error = @parser.errors[1] }
+
+        it "has a nil code" do
+          expect(@error.code).to be_nil
+        end
+
+        it "has the right error message" do
+          expect(@error.message).to eq "An exception has occurred: network timeout"
+        end
       end
     end
 

data/spec/shell_spec.rb

@@ -32,12 +32,12 @@ describe ITunes::Store::Transporter::Shell do
       output << [ stream, line.chomp! ]
     end
 
-    output.should == expect
+    expect(output).to eq expect
   end
 
   describe "#exec" do
     it "requires a block" do
-      lambda { described_class.new.exec([]) }.should raise_exception(ArgumentError, "block required")
+      expect { described_class.new.exec([]) }.to raise_exception(ArgumentError, "block required")
     end
   end
 
@@ -45,32 +45,37 @@ describe ITunes::Store::Transporter::Shell do
     before(:all) { ENV["PROGRAMFILES"] = "C:\\" }
 
     it "selects the Windows executable" do
-      described_class.stub(:windows? => true, :osx? => false)
-      described_class.new.path.should match /#{described_class::WINDOWS_EXE}\Z/
+      allow(described_class).to receive(:windows?).and_return(true)
+      allow(described_class).to receive(:osx?).and_return(false)
+      expect(described_class.new.path).to match /#{described_class::WINDOWS_EXE}\z/
     end
   end
 
   context "when on OS X" do
-    before { described_class.stub(:windows? => false, :osx? => true) }
+    before do
+      allow(described_class).to receive(:windows?).and_return(false)
+      allow(described_class).to receive(:osx?).and_return(true)
+    end
 
     it "selects the right executable" do
-      exe = described_class::DEFAULT_OSX_PATHS.first
-      File.stub(:exist? => true)
-      described_class.new.path.should == exe
+      exe = described_class::OSX_APPLICATION_LOADER_PATHS.first
+      allow(File).to receive(:exist?).and_return(true)
+      expect(described_class.new.path).to eq exe
     end
 
     context "and no OS X specific executable is found" do
       it "defaults to the *nix executable" do
-        File.stub(:exist? => false)
-        described_class.new.path.should match /#{described_class::DEFAULT_UNIX_PATH}\Z/
+        allow(File).to receive(:exist?).and_return(false)
+        expect(described_class.new.path).to eq described_class::DEFAULT_UNIX_PATH
       end
     end
   end
 
   context "when not on Windows or OS X" do
     it "selects the right executable" do
-      described_class.stub(:windows? => false, :osx? => false)
-      described_class.new.path.should match /#{described_class::EXE_NAME}\Z/
+      allow(described_class).to receive(:windows?).and_return(false)
+      allow(described_class).to receive(:osx?).and_return(false)
+      expect(described_class.new.path).to match /#{described_class::EXE_NAME}\z/
     end
   end
 end

data/spec/spec_helper.rb

@@ -16,7 +16,17 @@ module SpecHelper
   end
 
   def expect_shell_args(*expected)
-    ITunes::Store::Transporter::Shell.any_instance.should_receive(:exec) { |*arg| arg.first.should include(*expected); 0 }
+    output = expected.last.is_a?(Hash) ? expected.pop : {}
+    ITunes::Store::Transporter::Shell.any_instance.should_receive(:exec) do |*args, &block|
+      expect(args.first).to include(*expected)
+
+      [:stdout, :stderr].each do |fd|
+        next unless output[fd]
+        output[fd].each { |line| block.call(line, fd) }
+      end
+
+      0
+    end
   end
 
   def fixture(path)
@@ -32,6 +42,7 @@ module SpecHelper
     [:stderr, :stdout].each do |fd|
       fixture = options[fd]
       next unless fixture
+
       lines = Array === fixture ? fixture : Fixture.for(fixture)
       outputs << [ lines, fd ]
     end

data/spec/transporter_spec.rb

@@ -79,8 +79,27 @@ describe ITunes::Store::Transporter::ITMSTransporter do
   describe "#status" do
     let(:method) { :status }
     let(:command) { "Status" }
+    let(:status) { double("status command") }
 
     it_behaves_like "a transporter method without a package argument"
+
+    context "when given :all => true" do
+      it "runs the status all command" do
+        expect(ITunes::Store::Transporter::Command::StatusAll).to receive(:new).and_return(status)
+        expect(status).to receive(:run)
+
+        subject.status(:all => true)
+      end
+    end
+
+    context "when given :all => false" do
+      it "runs the status command" do
+        expect(ITunes::Store::Transporter::Command::Status).to receive(:new).and_return(status)
+        expect(status).to receive(:run)
+
+        subject.status(:all => false)
+      end
+    end
   end
 
   describe "#upload" do

data/spec/xml_status_spec.rb

@@ -0,0 +1,60 @@
+require "spec_helper"
+
+RSpec.describe ITunes::Store::Transporter::XML::Status do
+  context "given a valid XML doc with a single status" do
+    it "returns a Hash with a single status" do
+      status = described_class.new.parse(fixture("status.vendor_id_123123").join(""))
+      expect(status).to eq [{:apple_id=>"X9123X",
+                             :vendor_id=>"123123",
+                             :content_status=>
+                             {:status=>"Unpolished",
+                              :review_status=>"Ready-NotReviewed",
+                              :itunes_connect_status=>"Other",
+                              :store_status=>
+                              {:not_on_store=>[], :on_store=>[], :ready_for_store=>["US"]},
+                              :video_components=>
+                              [{:name=>"Video",
+                                :locale=>nil,
+                                :status=>"In Review",
+                                :delivered=>"2011-11-30 01:41:10"},
+                               {:name=>"Audio",
+                                :locale=>"en-US",
+                                :status=>"In Review",
+                                :delivered=>"2011-11-30 01:41:10"}]},
+                             :info=>[{:created=>"2016-11-25 10:38:09", :status=>"Imported"}]}]
+
+    end
+  end
+
+  context "given an invalid XML doc" do
+    it "raises a ParseError" do
+      expect {
+        described_class.new.parse("<>")
+        # Comment out to satisfy 1.9.3, it results in an "not well-formed" error
+        #}.to raise_error( ITunes::Store::Transporter::ParseError, /invalid xml/i)
+      }.to raise_error(ITunes::Store::Transporter::ParseError)
+    end
+  end
+
+  context "given an XML doc that's not well-formed" do
+    it "raises a ParseError" do
+      expect {
+        described_class.new.parse("<a><b></a>")
+      }.to raise_error(ITunes::Store::Transporter::ParseError, /not well-formed/i)
+    end
+  end
+
+  context "given an XML doc that contains an error message" do
+    it "raises a ExecutionError containing the message and its code" do
+      expect {
+        described_class.new.parse(fixture("status.error_message").join("\n"))
+      }.to raise_error(ITunes::Store::Transporter::ExecutionError) { |e|
+        expect(e.errors.size).to eq 2
+        expect(e.errors[0].message).to eq "Error message one."
+        expect(e.errors[0].code).to eq -1234
+        expect(e.errors[1].message).to eq "Error message two."
+        expect(e.errors[1].code).to eq 9999
+      }
+    end
+  end
+end

data/spec/xml_status_spec.rb~

@@ -0,0 +1,22 @@
+require "spec_helper"
+
+RSpec.describe ITunes::Store::Transporter::XML::Status do
+  context "given a valid XML doc with a single status" do
+    it "returns a Hash with a single status" do
+
+    end
+
+  end
+
+  context "given a valid XML doc with multiple statuses" do
+    it "returns a Hash with multiple statuses" do
+
+    end
+  end
+
+  context "given an XML invalid XML doc" do
+    it "raises a ParseError" do
+
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: itunes_store_transporter
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - Skye Shaw
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-31 00:00:00.000000000 Z
+date: 2017-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -93,6 +93,7 @@ files:
 - lib/itunes/store/transporter/command/providers.rb
 - lib/itunes/store/transporter/command/schema.rb
 - lib/itunes/store/transporter/command/status.rb
+- lib/itunes/store/transporter/command/status_all.rb
 - lib/itunes/store/transporter/command/upload.rb
 - lib/itunes/store/transporter/command/verify.rb
 - lib/itunes/store/transporter/command/version.rb
@@ -101,6 +102,7 @@ files:
 - lib/itunes/store/transporter/output_parser.rb
 - lib/itunes/store/transporter/shell.rb
 - lib/itunes/store/transporter/version.rb
+- lib/itunes/store/transporter/xml/status.rb
 - spec/command_spec.rb
 - spec/errors_spec.rb
 - spec/fixtures/errors_and_warnings.yml
@@ -112,6 +114,8 @@ files:
 - spec/shell_spec.rb
 - spec/spec_helper.rb
 - spec/transporter_spec.rb
+- spec/xml_status_spec.rb
+- spec/xml_status_spec.rb~
 homepage: http://github.com/sshaw/itunes_store_transporter
 licenses:
 - MIT
@@ -136,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Upload and manage your assets in the iTunes Store using the iTunes Store's
@@ -153,3 +157,5 @@ test_files:
 - spec/shell_spec.rb
 - spec/spec_helper.rb
 - spec/transporter_spec.rb
+- spec/xml_status_spec.rb
+- spec/xml_status_spec.rb~