itunes_store_transporter 0.1.3 → 0.2.0

data/spec/command_spec.rb

@@ -41,7 +41,7 @@ shared_examples_for "a boolean transporter option" do |option, expected|
 
   context "when not boolean" do
     it "raises an OptionError" do
-      lambda { subject.run(options.merge(option => "sshaw")) }.should raise_exception(ITunes::Store::Transporter::OptionError, /does not accept/)
+      expect { subject.run(options.merge(option => "sshaw")) }.to raise_exception(ITunes::Store::Transporter::OptionError, /does not accept/)
     end
   end
 end
@@ -49,7 +49,7 @@ end
 shared_examples_for "a required option" do |option|
   it "must have a value" do
     ["", nil].each do |value|
-      lambda { subject.run(options.merge(option => value)) }.should raise_exception(ITunes::Store::Transporter::OptionError, /#{option}/)
+      expect { subject.run(options.merge(option => value)) }.to raise_exception(ITunes::Store::Transporter::OptionError, /#{option}/)
     end
   end
 end
@@ -57,20 +57,20 @@ end
 shared_examples_for "a command that accepts a shortname argument" do
   context "when the shortname's invalid" do
     it "raises an OptionError" do
-      lambda { subject.run(options.merge(:shortname => "+")) }.should raise_exception(ITunes::Store::Transporter::OptionError, /shortname/)
+      expect { subject.run(options.merge(:shortname => "+")) }.to raise_exception(ITunes::Store::Transporter::OptionError, /shortname/)
     end
   end
 
   context "when the shortname's valid" do
     it "does not raise an exception" do
       mock_output
-      lambda { subject.run(options.merge(:shortname => "Too $hort")) }.should_not raise_exception
+      expect { subject.run(options.merge(:shortname => "Too $hort")) }.to_not raise_exception
     end
   end
 end
 
 shared_examples_for "a subclass of Command::Base" do
-  it { should be_a_kind_of(ITunes::Store::Transporter::Command::Base) }
+  it { is_expected.to be_a_kind_of(ITunes::Store::Transporter::Command::Base) }
 
   context "when on Windows" do
     it "automatically sets NoPause to true" do
@@ -105,7 +105,7 @@ shared_examples_for "a subclass of Command::Base" do
         let(:print?) { false }
 
         it "does not print to stderr" do
-          $stderr.string.should be_empty
+          expect($stderr.string).to be_empty
         end
       end
     end
@@ -133,7 +133,7 @@ shared_examples_for "a subclass of Command::Base" do
         let(:print?) { false }
 
         it "does not print to stdout" do
-          $stdout.string.should be_empty
+          expect($stdout.string).to be_empty
         end
       end
     end
@@ -160,17 +160,17 @@ shared_examples_for "a subclass of Command::Base" do
       it "raises an ExecutionError" do
         mock_output(:exit => 1, :stderr => "stderr.errors")
         lambda { subject.run(options) }.should raise_error { |e|
-          e.should be_a(ITunes::Store::Transporter::ExecutionError)
+          expect(e).to be_a(ITunes::Store::Transporter::ExecutionError)
 
-          e.exitstatus.should == 1
-          e.errors.should have(2).items
+          expect(e.exitstatus).to eq 1
+          expect(e.errors.size).to eq 2
 
           # just check one
-          e.errors[0].should be_a(ITunes::Store::Transporter::TransporterMessage)
-          e.errors[0].code.should == 9000
-          e.errors[0].message.should match("Your audio of screwed up!")
-          e.errors[1].code.should == 4009
-          e.errors[1].message.should match("Chapter timecode is just plain wrong")
+          expect(e.errors[0]).to be_a(ITunes::Store::Transporter::TransporterMessage)
+          expect(e.errors[0].code).to eq 9000
+          expect(e.errors[0].message).to match("Your audio of screwed up!")
+          expect(e.errors[1].code).to eq 4009
+          expect(e.errors[1].message).to match("Chapter timecode is just plain wrong")
         }
       end
     end
@@ -179,18 +179,18 @@ end
 
 shared_examples_for "a transporter mode" do
   it_should_behave_like "a subclass of Command::Base"
-  it { should be_a_kind_of(ITunes::Store::Transporter::Command::Mode) }
+  it { is_expected.to be_a_kind_of(ITunes::Store::Transporter::Command::Mode) }
 
   it "requires a username" do
     args = options
     args.delete(:username)
-    lambda { subject.run(args) }.should raise_error(ITunes::Store::Transporter::OptionError, /username/)
+    expect { subject.run(args) }.to raise_error(ITunes::Store::Transporter::OptionError, /username/)
   end
 
   it "requires a password" do
     args = options
     args.delete(:password)
-    lambda { subject.run(args) }.should raise_error(ITunes::Store::Transporter::OptionError, /password/)
+    expect { subject.run(args) }.to raise_error(ITunes::Store::Transporter::OptionError, /password/)
   end
 end
 
@@ -269,13 +269,17 @@ describe ITunes::Store::Transporter::Command::Providers do
 
   subject { described_class.new({}) }
   let(:options) { create_options }
-  its(:mode) { should == "provider" }
+
+  it "uses Transporter's provider mode" do
+    expect_shell_args("-m", "provider")
+    subject.run(options)
+  end
 
   describe "#run" do
     it "returns the shortname and longname for each provider" do
       mock_output(:stdout => "providers.two", :stderr => "stderr.info")
-      subject.run(options).should == [ { :longname => "Some Great User", :shortname => "luser" },
-                                       { :longname => "Skye's Taco Eating Service Inc.", :shortname => "conmuchacebolla" } ]
+      expect(subject.run(options)).to eq [ { :longname => "Some Great User", :shortname => "luser" },
+                                           { :longname => "Skye's Taco Eating Service Inc.", :shortname => "conmuchacebolla" } ]
     end
   end
 end
@@ -293,7 +297,7 @@ describe ITunes::Store::Transporter::Command::Upload do
     context "when successful" do
       it "returns true" do
         mock_output(:stdout => "stdout.success")
-        subject.run(options).should be_true
+        expect(subject.run(options)).to be true
       end
     end
   end
@@ -301,7 +305,7 @@ describe ITunes::Store::Transporter::Command::Upload do
   describe "options" do
     describe ":rate" do
       it "must be an integer" do
-        lambda { subject.run(options.merge(:rate => "123")) }.should raise_exception(ITunes::Store::Transporter::OptionError, /rate/)
+        expect { subject.run(options.merge(:rate => "123")) }.to raise_exception(ITunes::Store::Transporter::OptionError, /rate/)
       end
 
       it_should_behave_like "a transporter option", {:rate => 123}, "-k", "123"
@@ -315,11 +319,11 @@ describe ITunes::Store::Transporter::Command::Upload do
       end
 
       it "is case sensitive" do
-        lambda { subject.run(options.merge(:transport => "aspera")) }.should raise_exception(ITunes::Store::Transporter::OptionError)
+        expect { subject.run(options.merge(:transport => "aspera")) }.to raise_exception(ITunes::Store::Transporter::OptionError)
       end
 
       it "raises an OptionError if the transport is not supported" do
-        lambda { subject.run(options.merge(:transport => "ftp")) }.should raise_exception(ITunes::Store::Transporter::OptionError)
+        expect { subject.run(options.merge(:transport => "ftp")) }.to raise_exception(ITunes::Store::Transporter::OptionError)
       end
     end
 
@@ -348,7 +352,6 @@ describe ITunes::Store::Transporter::Command::Lookup do
   subject { described_class.new({}) }
 
   let(:options) { create_options(:vendor_id => "X") }
-  its(:mode) { should == "lookupMetadata" }
 
   # Fake the directory iTMSTransporter creates for the metadata
   before(:each) do
@@ -365,13 +368,18 @@ describe ITunes::Store::Transporter::Command::Lookup do
 
   after(:each) { FileUtils.rm_rf(@tmpdir) }
 
+  it "uses Transporter's lookupMetadata mode" do
+    expect_shell_args("-m", "lookupMetadata")
+    subject.run(options)
+  end
+
   describe "#run" do
     before { mock_output }
 
     context "when successful" do
       it "returns the metadata and deletes the temp directory used to output the metadata" do
-        subject.run(options).should == @metadata
-        File.exists?(@tmpdir).should be_false
+        expect(subject.run(options)).to eq @metadata
+        expect(File.exists?(@tmpdir)).to be false
       end
 
       context "when the metadata file was not created" do
@@ -404,7 +412,11 @@ describe ITunes::Store::Transporter::Command::Schema do
 
   subject { described_class.new({}) }
   let(:options) { create_options(:type => "strict", :version => "film5") }
-  its(:mode) { should == "generateSchema" }
+
+  it "uses Transporter's generateSchema mode" do
+    expect_shell_args("-m", "generateSchema")
+    subject.run(options)
+  end
 
   describe "#run" do
     context "when successful" do
@@ -431,47 +443,113 @@ describe ITunes::Store::Transporter::Command::Schema do
   end
 end
 
+describe ITunes::Store::Transporter::Command::StatusAll do
+  subject { described_class.new({}) }
+  let(:options) { create_options(:vendor_id => 123123) }
+
+  it { is_expected.to be_kind_of(ITunes::Store::Transporter::Command::Status) }
+
+  it "uses Transporter's statusAll mode" do
+    expect_shell_args("-m", "statusAll", :stdout => fixture("status.vendor_id_123123"))
+    subject.run(options)
+  end
+end
+
 describe ITunes::Store::Transporter::Command::Status do
-  it_behaves_like "a transporter mode"
+  # Ugh, issue with stubbed print_stdout test, we need XML here :(
+  #it_behaves_like "a transporter mode"
 
   subject { described_class.new({}) }
   let(:options) { create_options(:vendor_id => 123123) }
-  its(:mode) { should == "status" }
+
+  it "uses Transporter's status mode" do
+    expect_shell_args("-m", "status", :stdout => fixture("status.vendor_id_123123"))
+    subject.run(options)
+  end
+
+  it "uses Transporter's XML output format" do
+    expect_shell_args("-outputFormat", "xml", :stdout => fixture("status.vendor_id_123123"))
+    subject.run(options)
+  end
 
   describe "#run" do
     context "when successful" do
-      context "with a single status" do
+      context "with a single id" do
         it "returns the status information for the package" do
           mock_output(:stdout => "status.vendor_id_123123", :stderr => "stderr.info")
-          subject.run(options).should == {
-            :vendor_identifier => "123123",
-            :apple_identifier => "123123",
-            :itunesconnect_status => "Not ready for sale",
-            :status => [ { :upload_created =>  "2000-01-01 00:00:00",
-                           :upload_state => "Uploaded",
-                           :upload_state_id => "1",
-                           :content_state => "Irie",
-                           :content_state_id => "2" } ]
-          }
+          expect(subject.run(options)).to eq [
+            :apple_id=>"X9123X",
+            :vendor_id=>"123123",
+            :content_status=>
+            {:status=>"Unpolished",
+             :review_status=>"Ready-NotReviewed",
+             :itunes_connect_status=>"Other",
+             :store_status=>
+             {:not_on_store=>[], :on_store=>[], :ready_for_store=>["US"]},
+             :video_components=>
+             [{:name=>"Video",
+               :locale=>nil,
+               :status=>"In Review",
+               :delivered=>"2011-11-30 01:41:10"},
+              {:name=>"Audio",
+               :locale=>"en-US",
+               :status=>"In Review",
+               :delivered=>"2011-11-30 01:41:10"}]},
+            :info=>[{:created=>"2016-11-25 10:38:09", :status=>"Imported"}]
+          ]
         end
       end
 
-      context "with multiple status" do
-        it "returns all the status information for the package" do
-          mock_output(:stdout => "status.vendor_id_789789", :stderr => "stderr.info")
-          subject.run(options).should == {
-            :vendor_identifier => "789789",
-            :status => [ { :upload_created =>  "2000-01-01 00:00:00",
-                           :upload_state => "Uploaded",
-                           :upload_state_id => "1",
-                           :content_state => "Irie",
-                           :content_state_id => "2" },
-                         { :upload_created =>  "2000-01-02 00:00:00",
-                           :upload_state => "Some Failure",
-                           :upload_state_id => "2",
-                           :content_state => "Still Irie",
-                           :content_state_id => "3" } ]
-          }
+      context "with multiple ids" do
+        it "returns all the status information for all packages" do
+          options[:vendor_id] = %w[123123 ABCABC]
+          mock_output(:stdout => "status.vendor_id_123123_and_ABCABC", :stderr => "stderr.info")
+          expect(subject.run(options)).to eq [
+            {:apple_id=>"X9123X",
+             :vendor_id=>"123123",
+             :content_status=>
+             {:status=>"Unpolished",
+              :review_status=>"Ready-NotReviewed",
+              :itunes_connect_status=>"Other",
+              :store_status=>
+              {:not_on_store=>[], :on_store=>[], :ready_for_store=>["US"]},
+              :video_components=>
+              [{:name=>"Video",
+                :locale=>nil,
+                :status=>"In Review",
+                :delivered=>"2011-11-30 01:41:10"},
+               {:name=>"Audio",
+                :locale=>"en-US",
+                :status=>"In Review",
+                :delivered=>"2011-11-30 01:41:10"}]},
+             :info=>[{:created=>"2016-11-25 10:38:09", :status=>"Imported"}]},
+            {:apple_id=>"919191",
+             :vendor_id=>"ABCABC",
+             :content_status=>
+             {:status=>"Unpolished",
+              :review_status=>"Ready-NotReviewed",
+              :itunes_connect_status=>"Other",
+              :store_status=>
+              {:not_on_store=>[], :on_store=>["US","MX"], :ready_for_store=>["US"]},
+              :video_components=>
+              [{:name=>"Preview Film",
+                :locale=>"World",
+                :status=>"Approved",
+                :delivered=>"2016-11-25 12:92:46"},
+               {:name=>"Audio",
+                :locale=>"en-US",
+                :status=>"Approved",
+                :delivered=>"2016-11-25 12:11:07"},
+               {:name=>"Chapters",
+                :locale=>"en-US",
+                :status=>"Approved",
+                :delivered=>"2016-11-25 12:12:46"}]},
+             :info=>
+             [{:created=>"2011-08-25 10:50:09", :status=>"Imported"},
+              {:created=>"2012-11-08 08:26:11", :status=>"Imported"},
+              {:created=>"2013-10-31 05:55:29", :status=>"Imported"},
+              {:created=>"2014-11-25 10:38:09", :status=>"Imported"}]}
+          ]
         end
       end
     end
@@ -479,7 +557,19 @@ describe ITunes::Store::Transporter::Command::Status do
 
   describe "options" do
     describe ":vendor_id" do
-      it_should_behave_like "a vendor_id option"
+      context "given a single vendor_id" do
+        it "passes a single id to the transporter" do
+          expect_shell_args("-vendor_ids", "123", :stdout => fixture("status.vendor_id_123123"))
+          subject.run(options.merge(:vendor_id => "123"))
+        end
+      end
+
+      context "given multiple vendor_ids" do
+        it "passes a single id to the transporter" do
+          expect_shell_args("-vendor_ids", "123,456", :stdout => fixture("status.vendor_id_123123"))
+          subject.run(options.merge(:vendor_id => %w[123 456]))
+        end
+      end
     end
   end
 end
@@ -490,15 +580,19 @@ describe ITunes::Store::Transporter::Command::Verify do
   it_behaves_like "a command that accepts a shortname argument"
 
   subject { described_class.new({}) }
-  its(:mode) { should == "verify" }
   let(:options) { create_options(:package => create_package) }
 
+  it "uses Transporter's verify mode" do
+    expect_shell_args("-m", "verify")
+    subject.run(options)
+  end
+
   describe "#run" do
     context "when successful" do  #successful means exit(0)
       context "without any errors" do
         it "returns true" do
           mock_output(:stdout => "stdout.success", :stderr => "stderr.info")
-          subject.run(options).should be_true
+          expect(subject.run(options)).to be true
         end
       end
 
@@ -506,7 +600,7 @@ describe ITunes::Store::Transporter::Command::Verify do
         it "raises an ExecutionError" do
           # If no packages were verfied it exits with 0 but emits an error message
           mock_output(:exit => 0, :stderr => "stderr.errors");
-          lambda { subject.run(options) }.should raise_exception(ITunes::Store::Transporter::ExecutionError)
+          expect { subject.run(options) }.to raise_exception(ITunes::Store::Transporter::ExecutionError)
         end
       end
     end

data/spec/fixtures/status.yml

@@ -1,29 +1,61 @@
 vendor_id_123123: |
-  Vendor identifier:      123123
-  Apple identifier:       123123
-  iTunesConnect Status:   Not ready for sale
+  <?xml version="1.0" encoding="UTF-8"?>
+  <itunes_transporter>
+    <upload_status apple_identifier="X9123X" vendor_identifier="123123">
+      <content_status_info content_review_status="Ready-NotReviewed" content_status="Unpolished" itunes_connect_status="Other">
+        <store_status not_on_store="N/A" on_store="N/A" ready_for_store="US"/>
+        <video_components>
+        <video_component component_delivered="2011-11-30 01:41:10" component_locale="N/A" component_name="Video" component_status="In Review"/>
+        <video_component component_delivered="2011-11-30 01:41:10" component_locale="en-US" component_name="Audio" component_status="In Review"/>
+        </video_components>
+      </content_status_info>
+      <upload_status_info created="2016-11-25 10:38:09" status="Imported"/>
+    </upload_status>
+  </itunes_transporter>
 
-  -------------------------Status Info-------------------------
-  Upload created: 2000-01-01 00:00:00
-  Upload state:   Uploaded
-  Upload state id:        1
-  Content state:  Irie
-  Content state id:       2
+vendor_id_123134_failed: |
+  <?xml version="1.0" encoding="UTF-8"?>
+  <itunes_transporter>
+    <upload_status vendor_identifier="98143907070932">
+      <upload_status_info created="2014-08-14 15:09:26" status="Upload Failed"/>
+    </upload_status>
+  </itunes_transporter>
 
-vendor_id_789789: |
-  Vendor identifier:      789789
+vendor_id_123123_and_ABCABC: |
+  <?xml version="1.0" encoding="UTF-8"?>
+  <itunes_transporter>
+    <upload_status apple_identifier="X9123X" vendor_identifier="123123">
+      <content_status_info content_review_status="Ready-NotReviewed" content_status="Unpolished" itunes_connect_status="Other">
+        <store_status not_on_store="N/A" on_store="N/A" ready_for_store="US"/>
+        <video_components>
+        <video_component component_delivered="2011-11-30 01:41:10" component_locale="N/A" component_name="Video" component_status="In Review"/>
+        <video_component component_delivered="2011-11-30 01:41:10" component_locale="en-US" component_name="Audio" component_status="In Review"/>
+        </video_components>
+      </content_status_info>
+      <upload_status_info created="2016-11-25 10:38:09" status="Imported"/>
+    </upload_status>
+    <upload_status apple_identifier="919191" vendor_identifier="ABCABC">
+      <content_status_info content_review_status="Ready-NotReviewed" content_status="Unpolished" itunes_connect_status="Other">
+        <store_status not_on_store="N/A" on_store="US,MX" ready_for_store="US"/>
+        <video_components>
+          <video_component component_delivered="2016-11-25 12:92:46" component_locale="World" component_name="Preview Film" component_status="Approved"/>
+          <video_component component_delivered="2016-11-25 12:11:07" component_locale="en-US" component_name="Audio" component_status="Approved"/>
+          <video_component component_delivered="2016-11-25 12:12:46" component_locale="en-US" component_name="Chapters" component_status="Approved"/>
+        </video_components>
+      </content_status_info>
+      <upload_status_info created="2011-08-25 10:50:09" status="Imported"/>
+      <upload_status_info created="2012-11-08 08:26:11" status="Imported"/>
+      <upload_status_info created="2013-10-31 05:55:29" status="Imported"/>
+      <upload_status_info created="2014-11-25 10:38:09" status="Imported"/>
+    </upload_status>
+  </itunes_transporter>
 
-  -------------------------Status Info-------------------------
-  Upload created: 2000-01-01 00:00:00
-  Upload state:   Uploaded
-  Upload state id:        1
-  Content state:  Irie
-  Content state id:       2
 
-  -------------------------Status Info #2-------------------------
-  Upload created: 2000-01-02 00:00:00
-  Upload state:   Some Failure
-  Upload state id:        2
-  Content state:  Still Irie
-  Content state id:       3
+error_message: |
+  <itunes_transporter a="foo">
 
+    Error Summary
+
+      Error message one. (-1234)
+      Error message two. (9999)
+  </itunes_transporter>