insika 0.9.0 → 1.0.1

data/lib/insika/studio/views/funnel.erb

@@ -1,24 +1,27 @@
-<%# the outcome funnel per store. Reads the fold's cells and the
+<div class="reports-page reports-funnel">
+<%# Outcomes & conversion by agent. Reads the fold's cells and the
    BudgetLedger's current counters (D6); the ONLY mutation on this page — the
    baseline freeze — dispatches :freeze_funnel_baseline on the bus (D7). No
    stage vocabulary of the engine's own: everything here comes from the pack
    declaration (D1). %>
 <header class="page-head">
   <div>
-    <nav class="crumbs"><span>operate</span></nav>
-    <h1>Funnel<span class="sub">the outcome funnel per store</span></h1>
+    <%== crumbs_for("Funnel") %>
+    <h1>Funnel<span class="sub">Outcomes & conversion by agent</span></h1>
   </div>
   <div class="head-actions">
-    <%== agent_filter_form("/studio/funnel", @agent) %>
     <form method="get" action="/studio/funnel" class="actions inline">
-      <label>
-        Period (days)
-        <select name="period" data-controller="auto-submit" data-action="change->auto-submit#submit">
-          <% [7, 30, 90].each do |p| %>
-            <option value="<%= p %>"<%== ' selected' if @period == p %>><%= p %></option>
+      <label>Agent
+        <%== render("_agent_picker", locals: { name: "agent", options: insika[:profile_source].ids.sort, value: @agent, blank: "All agents — type to search" }) %>
+      </label>
+      <label>Period
+        <select name="period">
+          <% ([7, 30, 90] + [@period]).uniq.sort.each do |p| %>
+            <option value="<%= p %>"<%== ' selected' if @period == p %>>Last <%= p %> days</option>
           <% end %>
         </select>
       </label>
+      <button type="submit">Apply filters</button>
     </form>
   </div>
 </header>
@@ -42,41 +45,97 @@
       <% max = [counts.values.max || 0, 1].max %>
       <div class="card">
         <div class="section-head">
-          <h3><%= tenant || "platform" %><span class="muted">folded by the tick · recomputable from the outcome store</span></h3>
-          <span class="muted">primary <strong><%= decl.primary %></strong> · attribution window <%= decl.attribution_window %> (carried, never computed)</span>
+          <h3><%= tenant || "platform" %></h3>
+          <span class="muted">Primary outcome · <strong><%= decl.primary %></strong></span>
+        </div>
+
+        <%# D6: spend next to the counts, NOT cost-per-conversion. The
+            BudgetLedger holds current-window TOKEN totals, no currency and no
+            per-day series; a cost/conversion ratio is deferred until
+            the ruler proves itself (E3). %>
+        <div class="kpi-strip">
+          <%== render("_kpi", locals: { label: decl.first_stage, value: first, sub: "last #{@period}d" }) %>
+          <%== render("_kpi", locals: { label: decl.primary, value: counts[decl.primary].to_i }) %>
+          <%== render("_kpi", locals: { label: "Conversion", value: conversion ? format("%.4f", conversion) : "—" }) %>
+          <%== render("_kpi", locals: { label: "Tokens today", value: spend[:daily], sub: "month #{spend[:monthly]}" }) %>
         </div>
-        <svg class="barchart" viewBox="0 0 700 120" preserveAspectRatio="none" role="img" aria-label="stage counts, last <%= @period %> days">
-          <% bw = 700.0 / decl.stages.length * 0.6 %>
+
+        <%# Chart geometry lives in a 720-unit viewBox and the .chart-funnel
+            cap holds the RENDERED width at 720px too — a wide viewport never
+            stretches the SVG past that, so a bar drawn at <= 28 units stays
+            <= 28 real pixels instead of scaling up with the page. %>
+        <svg class="chart chart-funnel" viewBox="0 0 720 120" preserveAspectRatio="none" role="img" aria-label="stage counts, last <%= @period %> days">
+          <% bw = [720.0 / decl.stages.length * 0.6, 28.0].min %>
           <% decl.stages.each_with_index do |stage, i| %>
             <% c = counts[stage].to_i %>
             <% h = (c.to_f / max) * 96.0 %>
-            <% x = (i * (700.0 / decl.stages.length)) + ((700.0 / decl.stages.length - bw) / 2.0) %>
+            <% x = (i * (720.0 / decl.stages.length)) + ((720.0 / decl.stages.length - bw) / 2.0) %>
             <rect class="bar<%== ' bar-empty' if c.zero? %>" x="<%= format('%.1f', x) %>" y="<%= format('%.1f', c.zero? ? 108.0 : 108.0 - h) %>"
                   width="<%= format('%.1f', bw) %>" height="<%= format('%.1f', c.zero? ? 3.0 : [h, 3.0].max) %>" rx="2">
               <title><%= stage %> · <%= c %></title>
             </rect>
           <% end %>
-          <line class="barchart-axis-line" x1="0" y1="108" x2="700" y2="108" />
+          <line class="axis" x1="0" y1="108" x2="720" y2="108" />
         </svg>
-        <div class="barchart-axis">
+        <div class="chart-labels">
           <% decl.stages.each do |stage| %>
             <span><%= stage %> · <%= counts[stage].to_i %></span>
           <% end %>
         </div>
-        <div class="skill-desc">
-          <span class="pill <%= conversion && conversion.positive? ? 'ok' : 'info' %>">
-            conversion <%= conversion ? format("%.4f", conversion) : "—" %>
-          </span>
-          <span class="muted"><%= counts[decl.primary].to_i %> × <%= decl.primary %> / <%= counts[decl.first_stage].to_i %> × <%= decl.first_stage %>, last <%= @period %> days</span>
-          <%# D6: spend next to the counts, NOT cost-per-conversion. The
-              BudgetLedger holds current-window TOKEN totals, no currency and no
-              per-day series; a cost/conversion ratio is deferred until
-              the ruler proves itself (E3). %>
-          <span class="muted">· tokens today <strong><%= spend[:daily] %></strong> / this month <strong><%= spend[:monthly] %></strong></span>
-        </div>
+
+        <%# Where conversations stop: the loss between consecutive stages, the
+            biggest one marked. Each row drills (?drop=) into the conversations
+            that reached the stage but not the next, grouped by the last thing
+            that happened in them. %>
+        <% if decl.stages.length > 1 %>
+          <div class="section-head">
+            <h3>Where conversations stop</h3>
+            <span class="muted">lost between stages · last <%= @period %>d</span>
+          </div>
+          <table class="grid">
+            <thead><tr><th>between</th><th class="num">lost</th><th class="num">share</th><th></th></tr></thead>
+            <tbody>
+              <% funnel_drops(decl, counts).each do |d| %>
+                <tr><td><a href="<%= funnel_drop_path(profile.id, tenant, d[:from]) %>"><%= d[:from] %> → <%= d[:to] %></a></td>
+                  <td class="num"><%= d[:lost] %></td>
+                  <td class="num"><%= d[:of].zero? ? "—" : "#{(100.0 * d[:lost] / d[:of]).round}%" %></td>
+                  <td><% if d[:biggest] %><span class="pill warn">biggest drop</span><% end %></td></tr>
+              <% end %>
+            </tbody>
+          </table>
+          <% groups = @agent == profile.id && @drop_tenant == tenant && @drop ? funnel_drop_sessions(decl, tenant, profile.id, @drop, @period) : nil %>
+          <% if groups %>
+            <h4>Reached <%= @drop %>, not <%= decl.stages[decl.index_of(@drop) + 1] %></h4>
+            <% if @drop_total.to_i > Studio::App::DROP_CLASSIFY_CAP %>
+              <p class="muted"><%= @drop_total %> stopped here; the newest <%= Studio::App::DROP_CLASSIFY_CAP %> are grouped below.</p>
+            <% end %>
+            <% if groups.empty? %>
+              <div class="empty">No conversation with an outcome stopped at <%= @drop %> in this window.</div>
+            <% else %>
+              <ul class="kv">
+                <% groups.each do |reason, sids| %>
+                  <li><span class="k"><%= Studio::App::DROP_REASONS[reason] %> · <%= sids.size %></span>
+                    <span class="v">
+                      <% sids.first(Studio::App::DROP_LIST_CAP).each do |sid| %>
+                        <a class="mono" href="/studio/sessions/<%= Rack::Utils.escape(sid) %>" title="<%= sid %>"><%= sid[0, 20] %></a>
+                      <% end %>
+                      <% if sids.size > Studio::App::DROP_LIST_CAP %><span class="muted">+<%= sids.size - Studio::App::DROP_LIST_CAP %> more</span><% end %>
+                    </span></li>
+                <% end %>
+              </ul>
+            <% end %>
+          <% end %>
+        <% end %>
+
+        <details class="report-details">
+          <summary>How this funnel is counted</summary>
+          <p>Counts are folded by the tick and can be recomputed from the outcome store. Conversion is the primary outcome count divided by the first-stage count.</p>
+          <p>Stage losses compare these folded counts. A drill lists conversations instead: each one's furthest stage across its outcomes in the window.</p>
+          <p>Attribution window: <%= decl.attribution_window %> (carried, never computed). Token totals use the current budget window.</p>
+        </details>
 
         <% baseline = insika[:funnel_store]&.baseline(tenant: tenant, agent: profile.id) %>
-        <div class="skill-desc">
+        <div class="actions">
           <% if baseline %>
             <span class="pill ok">baseline frozen</span>
             <span class="muted"><%= baseline["from"] %> → <%= baseline["to"] %> · <%= baseline["primary"] %> <%= baseline["primary_count"] %> · conversion <%= baseline["conversion"] ? format("%.4f", baseline["conversion"]) : "—" %> · <%= baseline["window"] %> window · frozen <%= baseline["frozen_at"] %></span>
@@ -84,23 +143,25 @@
             <span class="pill warn">no baseline</span>
             <span class="muted">≥ 28 days of data required — the freeze refuses a shorter span</span>
           <% end %>
+          <form method="post" action="/studio/funnel/<%= Rack::Utils.escape(profile.id) %>/freeze" class="actions">
+            <%== csrf_tag %>
+            <label>
+              From
+              <input type="date" name="from" value="<%= baseline && baseline["from"] %>">
+            </label>
+            <label>
+              To
+              <input type="date" name="to" value="<%= baseline && baseline["to"] %>">
+            </label>
+            <button type="submit" class="primary">Freeze baseline</button>
+            <% if tenant %>
+              <input type="hidden" name="tenant" value="<%= tenant %>">
+            <% end %>
+          </form>
         </div>
-        <form method="post" action="/studio/funnel/<%= Rack::Utils.escape(profile.id) %>/freeze" class="actions">
-          <%== csrf_tag %>
-          <label>
-            From
-            <input type="date" name="from" value="<%= baseline && baseline["from"] %>">
-          </label>
-          <label>
-            To
-            <input type="date" name="to" value="<%= baseline && baseline["to"] %>">
-          </label>
-          <button type="submit" class="primary">Freeze baseline</button>
-          <% if tenant %>
-            <input type="hidden" name="tenant" value="<%= tenant %>">
-          <% end %>
-        </form>
       </div>
     <% end %>
   <% end %>
 <% end %>
+
+</div>

data/lib/insika/studio/views/harvest.erb

@@ -1,7 +1,10 @@
-<header class="page-head">
+<header class="page-head harvest-head">
   <div>
-    <nav class="crumbs"><span>harvest</span></nav>
-    <h1>Harvest<span class="sub"><%= @agent ? "#{@agent}" : "no agent" %></span></h1>
+    <%== crumbs_for("Harvest") %>
+    <h1>Harvest<span class="sub">Turn conversation evidence into reusable skills</span></h1>
+  </div>
+  <div class="head-actions">
+    <%== agent_filter_form("/studio/harvest", @agent) %>
   </div>
 </header>
 
@@ -11,44 +14,47 @@
   <div class="empty">No agents yet. Add a <span class="mono">harvest:</span> block to an agent's pack to mine its finished traffic.</div>
 <% else %>
   <div class="card">
+    <h2>Find new skills</h2>
     <form method="post" action="/studio/harvest" class="actions">
       <%== csrf_tag %>
       <label>
         Agent
-        <select name="agent">
-          <% @agents.each do |id| %>
-            <option value="<%= id %>"<%== ' selected' if id == @agent %>><%= id %></option>
-          <% end %>
-        </select>
+        <%== render("_agent_picker", locals: { name: "agent", options: @agents, value: @agent }) %>
       </label>
-      <label title="Ignore the mined markers and re-read the whole window (the ledger dedup still protects).">
-        <input type="checkbox" name="full" value="1"> full window
+      <label class="check" title="Ignore the mined markers and re-read the whole window (the ledger dedup still protects).">
+        <input type="checkbox" name="full" value="1"> Re-read full window
       </label>
-      <button type="submit" class="primary">Mine now</button>
+      <button type="submit" class="primary" data-turbo-submits-with="Mining…">Mine now</button>
     </form>
     <div class="skill-desc muted">
-      Reads this agent's finished conversations, asks the configured miner for SKILL
-      proposals, and filters them through the negative list and the evidence ledger.
-      Nothing is ever applied automatically — a candidate only lands after the double
-      gate AND a human approval.
+      Reviews finished conversations and proposes skills. Nothing is applied until the evidence checks pass and you approve it.
     </div>
   </div>
 
-  <% if @agents.size > 1 %>
-    <div class="filter-bar">
-      <% @agents.each do |id| %>
-        <a class="btn" href="/studio/harvest?agent=<%= Rack::Utils.escape(id) %>"<%== ' aria-current="page"' if id == @agent %>><%= id %></a>
-      <% end %>
-    </div>
+  <% if @idle_reason == :off %>
+    <div class="empty">Harvest is off for this agent — turn it on in <a href="/studio/agents/<%= Rack::Utils.escape(@agent) %>?cfg=harvest">Agents › Config › harvest</a>.</div>
+  <% elsif @idle_reason == :no_matcher %>
+    <div class="empty">Not mining: harvest is on but there is <strong>no grounding matcher</strong>, so the automatic loop skips every conversation. Set a matcher SKU (and uncheck "use the platform default") in <a href="/studio/agents/<%= Rack::Utils.escape(@agent) %>?cfg=grounding">Agents › Config › grounding</a>.</div>
+  <% end %>
+
+  <% if @candidates.empty? && @blocked.empty? && @pending_gates.empty? %>
+    <div class="empty">No skills awaiting review. Mine finished conversations to find candidates.</div>
   <% end %>
 
   <%# The human's inbox. %>
   <% if @candidates.any? %>
-    <h2>Awaiting approval<span class="sub">the human's answer</span></h2>
+    <h2>Awaiting approval<span class="sub">review evidence before applying</span></h2>
     <% @candidates.each do |cand| %>
-      <div class="card">
+      <div class="card harvest-candidate">
+        <div class="review-heading"><div><h3><%= cand.name %></h3><p class="muted"><%= cand.description %></p></div><span class="pill warn">Awaiting approval</span></div>
+        <section class="harvest-proposal">
+          <h3>Proposed skill</h3>
+          <p class="muted"><%= cand.rationale %></p>
+          <div class="markdown-preview" data-controller="markdown"><%= cand.body %></div>
+        </section>
+        <details class="review-details"><summary>Evaluation results</summary>
         <div class="skill-desc">
-          <span class="pill ok">gated</span>
+          <span class="status <%= status_class(cand.status) %>">gated</span>
           <span class="mono"><%= cand.name %></span>
           <span class="muted">· <%= cand.description %></span>
         </div>
@@ -60,19 +66,23 @@
           <span class="mono"><%= cand.proposer %></span> · <%= (cand.eval_gate || {})["passed_cases"] %>/<%= (cand.eval_gate || {})["cases"] %> case(s) no regression
           · conversion <%= (cand.conversion_gate || {})["current"] %> vs <%= (cand.conversion_gate || {})["baseline"] %> (threshold <%= (cand.conversion_gate || {})["threshold"] %>)
         </div>
+        </details>
         <% if (excerpt = candidate_excerpt(cand)).any? %>
-          <details class="skill-desc">
-            <summary>evidence excerpt</summary>
+          <details class="review-details" open>
+            <summary>Conversation evidence</summary>
             <% excerpt.each do |sid, idx, text| %>
-              <div class="preview muted">
-                <a class="mono" href="/studio/sessions/<%= Rack::Utils.escape(sid) %>"><%= sid %></a> [<%= idx %>]: <%= text %>
+              <div class="harvest-evidence">
+                <a class="mono" href="/studio/sessions/<%= Rack::Utils.escape(sid) %>">Open conversation ↗</a>
+                <p class="review-source"><%= text %></p>
               </div>
             <% end %>
           </details>
         <% end %>
+        <details class="review-details"><summary>Source conversations</summary>
         <% Array(cand.origin).each do |sid| %>
           <a class="mono muted" href="/studio/sessions/<%= Rack::Utils.escape(sid) %>"><%= sid %></a>
         <% end %>
+        </details>
         <form method="post" action="/studio/harvest/promote" class="actions">
           <%== csrf_tag %>
           <input type="hidden" name="agent" value="<%= cand.agent %>">
@@ -81,13 +91,11 @@
             Note
             <input type="text" name="note" placeholder="why (optional)">
           </label>
-          <button type="submit" class="primary">Promote</button>
-          <button type="submit" class="ghost" formaction="/studio/harvest/reject">Reject</button>
+          <button type="submit" class="primary" data-turbo-submits-with="Promoting…">Promote</button>
+          <button type="submit" class="danger" formaction="/studio/harvest/reject">Reject</button>
         </form>
         <div class="skill-desc muted">
-          Promoting snapshots the pre-promotion state, writes the skill into this store's
-          scope, enables it on the allowlist and appends the promotion log row. Rollback
-          is the one-click mirror.
+          Promoting saves and enables this skill for the agent. The previous state is saved so you can roll it back.
         </div>
       </div>
     <% end %>
@@ -95,13 +103,17 @@
 
   <%# Gated-but-blocked: the ruler's hole, named. %>
   <% if @blocked.any? %>
-    <h2>Blocked<span class="sub">gated, waiting on the ruler</span></h2>
+    <h2>Blocked<span class="sub">resolve these before approval</span></h2>
     <div class="card">
       <ul class="history">
         <% @blocked.each do |cand| %>
           <li>
-            <span class="pill err">blocked</span>
+            <span class="status <%= status_class('blocked') %>">blocked</span>
             <span class="mono"><%= cand.name %></span>
+            <% ev = cand.eval_gate || {} %>
+            <% if ev["passed"] == false && ev["reason"] && (cand.conversion_gate || {})["reason"] %>
+              <span class="preview muted"><%= ev["reason"] %> ·</span>
+            <% end %>
             <span class="preview muted">
               <% reason = (cand.conversion_gate || {})["reason"] %>
               <% if reason == "no_frozen_baseline" %>
@@ -113,6 +125,14 @@
                 <%= (cand.eval_gate || {})["reason"] %>
               <% end %>
             </span>
+            <%== render("_harvest_candidate_detail", locals: { cand: cand }) %>
+            <form method="post" action="/studio/harvest/gate" class="actions inline">
+              <%== csrf_tag %>
+              <input type="hidden" name="agent" value="<%= cand.agent %>">
+              <input type="hidden" name="candidate_id" value="<%= cand.id %>">
+              <button type="submit" data-turbo-submits-with="Checking…" title="Re-run once the missing piece is fixed">Run checks again</button>
+              <button type="submit" class="danger" formaction="/studio/harvest/reject">Reject</button>
+            </form>
           </li>
         <% end %>
       </ul>
@@ -121,20 +141,21 @@
 
   <%# Mined, not yet gated. %>
   <% if @pending_gates.any? %>
-    <h2>Pending<span class="sub">mined, awaiting the double gate</span></h2>
+    <h2>Pending<span class="sub">awaiting evaluation and conversion checks</span></h2>
     <div class="card">
       <ul class="history">
         <% @pending_gates.each do |cand| %>
           <li>
-            <span class="pill">pending</span>
+            <span class="status <%= status_class(cand.status) %>"><%= cand.status %></span>
             <span class="mono"><%= cand.name %></span>
             <span class="preview muted"><%= cand.description %></span>
+            <%== render("_harvest_candidate_detail", locals: { cand: cand }) %>
             <form method="post" action="/studio/harvest/gate" class="actions inline">
               <%== csrf_tag %>
               <input type="hidden" name="agent" value="<%= cand.agent %>">
               <input type="hidden" name="candidate_id" value="<%= cand.id %>">
-              <button type="submit" class="primary">Gate it</button>
-              <button type="submit" class="ghost" formaction="/studio/harvest/reject">Reject</button>
+              <button type="submit" class="primary" data-turbo-submits-with="Checking…">Run checks</button>
+              <button type="submit" class="danger" formaction="/studio/harvest/reject">Reject</button>
             </form>
           </li>
         <% end %>
@@ -144,15 +165,15 @@
 
   <%# The promotion log — the single ledger, with the rollback mirror. %>
   <% if @promotions.any? %>
-    <h2>Promoted<span class="sub">the append-only log</span></h2>
+    <h2>Promoted<span class="sub">promotion history</span></h2>
     <div class="card">
       <ul class="history">
         <% @promotions.each do |row| %>
           <li>
             <% if row.rolled_back_at %>
-              <span class="pill err">rolled back</span>
+              <span class="status <%= status_class('rejected') %>">rolled back</span>
             <% else %>
-              <span class="pill ok">promoted</span>
+              <span class="status <%= status_class('approved') %>">promoted</span>
             <% end %>
             <span class="mono"><%= row.skill %></span>
             <span class="preview muted">
@@ -164,7 +185,7 @@
                 <%== csrf_tag %>
                 <input type="hidden" name="agent" value="<%= row.agent %>">
                 <input type="hidden" name="snapshot_ref" value="<%= row.snapshot_ref %>">
-                <input type="text" name="reason" placeholder="why (optional)">
+                <label>Rollback reason <input type="text" name="reason" placeholder="Optional"></label>
                 <button type="submit" class="ghost">Rollback</button>
               </form>
             <% end %>
@@ -176,7 +197,8 @@
 
   <%# The negative list block. %>
   <% if @negative && @negative.rules.any? %>
-    <h2>Negative list<span class="sub">the versioned seed, engine-applied</span></h2>
+    <details class="review-details"><summary>Negative list rules</summary>
+    <h2>Negative list<span class="sub">rules that exclude candidates</span></h2>
     <div class="card">
       <ul class="history">
         <% @negative.rules.each do |rule| %>
@@ -193,11 +215,12 @@
         <span class="mono">insika harvest:negative import --agent ID --file F</span>.
       </div>
     </div>
+    </details>
   <% end %>
 
   <%# The ruler block. %>
   <% if @criterion %>
-    <h2>The conversion criterion<span class="sub">frozen before the first promotion</span></h2>
+    <h2>Conversion criterion<span class="sub">frozen before the first promotion</span></h2>
     <div class="card">
       <div class="skill-desc">
         <span class="pill">metric <%= @criterion.rule.metric %></span>
@@ -215,20 +238,23 @@
 
   <% if @runs.any? %>
     <h2>Runs<span class="sub">most recent first</span></h2>
-    <div class="card">
-      <ul class="history">
-        <% @runs.each do |run| %>
-          <li>
-            <span class="pill <%= run.status == 'failed' ? 'err' : 'ok' %>"><%= run.status %></span>
-            <span class="mono"><%= run.id[0, 12] %></span>
-            <span class="preview muted">
-              <%= run.candidates %> candidate(s) ·
-              <% if run.cost && run.cost["spent"].to_i.positive? %><%= run.cost["spent"] %> tokens · <% end %>
-              <%= run.started_at %>
-            </span>
-          </li>
-        <% end %>
-      </ul>
+    <div class="card table-scroll" tabindex="0" role="region" aria-label="Harvest runs">
+      <table class="grid">
+        <thead>
+          <tr><th>status</th><th>run</th><th class="num">candidates</th><th class="num">tokens</th><th class="time">started</th></tr>
+        </thead>
+        <tbody>
+          <% @runs.each do |run| %>
+            <tr>
+              <td><span class="status <%= status_class(run.status) %>"><%= run.status %></span></td>
+              <td class="mono"><%= run.id[0, 12] %></td>
+              <td class="num"><%= run.candidates %></td>
+              <td class="num"><%= run.cost && run.cost["spent"].to_i.positive? ? run.cost["spent"] : "—" %></td>
+              <td class="time"><%= run.started_at %></td>
+            </tr>
+          <% end %>
+        </tbody>
+      </table>
     </div>
   <% end %>
 <% end %>