insika 0.9.0 → 1.0.1

data/lib/insika/studio/views/fact_detail.erb

@@ -0,0 +1,114 @@
+<%# Shared detail for the Facts page and Turbo frame navigation. %>
+<turbo-frame id="fact-detail" class="drill-pane drill-detail fact-detail">
+  <% if turbo_frame?("fact-detail") %>
+    <% if flash["error"] %><div class="flash err" role="alert"><%= flash["error"] %></div><% end %>
+    <% if flash["notice"] %><div class="flash ok" role="status"><%= flash["notice"] %></div><% end %>
+  <% end %>
+  <% if @selected.nil? %>
+    <div class="drill-empty">
+      <%== render("_empty", locals: { icon: :facts, text: "No proposals yet — facts appear here when a session's traffic is distilled. Nothing is ever applied automatically." }) %>
+    </div>
+  <% else %>
+    <div class="drill-pane-body">
+      <div class="fact-content">
+        <header class="fact-proposal" aria-labelledby="fact-title">
+          <div class="fact-summary">
+            <div class="fact-title-row">
+              <h2 id="fact-title"><%= @selected.key.tr("_", " ").sub(/\A./, &:upcase) %></h2>
+              <span class="status <%= status_class(@selected.status) %>"><%= @selected.status %></span>
+            </div>
+            <span class="sr-only">Proposed value</span>
+            <p class="fact-value"><%= @selected.value %></p>
+          </div>
+          <dl class="fact-context">
+            <div><dt>Model confidence</dt><dd><%= @selected.confidence ? "#{(@selected.confidence * 100).round}%" : "Not reported" %></dd></div>
+            <div><dt>Proposed</dt><dd><time datetime="<%= @selected.created_at %>" title="<%= @selected.created_at %>"><%= time_ago(@selected.created_at) %></time></dd></div>
+          </dl>
+        </header>
+
+        <section class="card fact-evidence" aria-labelledby="fact-evidence-title">
+          <div class="fact-section-head">
+            <h3 id="fact-evidence-title">Conversation evidence</h3>
+            <a href="/studio/sessions/<%= Rack::Utils.escape(@selected.session_ref) %>" data-turbo-frame="_top">Open conversation ↗</a>
+          </div>
+          <% excerpt = proposal_excerpt(@selected) %>
+          <% if excerpt.empty? %>
+            <p class="muted">Evidence unavailable. The source messages may no longer be available.</p>
+          <% else %>
+            <div class="fact-quotes" tabindex="0" role="region" aria-label="Evidence excerpts">
+              <% excerpt.each do |line| %>
+                <blockquote><%= line %></blockquote>
+              <% end %>
+            </div>
+          <% end %>
+        </section>
+
+        <% if @selected.status == "pending" %>
+          <section class="card fact-decision" aria-labelledby="fact-decision-title">
+            <h3 id="fact-decision-title">Save this fact to memory?</h3>
+            <p class="muted">Approval makes this value available in future conversations with this customer.</p>
+            <form method="post" action="/studio/facts/resolve" data-turbo-frame="_top">
+              <%== csrf_tag %>
+              <input type="hidden" name="proposal_id" value="<%= @selected.id %>">
+              <input type="hidden" name="decision" value="approved">
+              <% if @filter %><input type="hidden" name="filter" value="<%= @filter %>"><% end %>
+              <button type="submit" class="primary" data-turbo-submits-with="Saving…">Approve &amp; save to memory</button>
+            </form>
+            <details class="fact-decline">
+              <summary>Reject or dismiss</summary>
+              <p class="muted">Rejecting or dismissing prevents this same key and value from being proposed again.</p>
+              <form method="post" action="/studio/facts/resolve" data-turbo-frame="_top">
+                <%== csrf_tag %>
+                <input type="hidden" name="proposal_id" value="<%= @selected.id %>">
+                <input type="hidden" name="decision" value="rejected">
+                <% if @filter %><input type="hidden" name="filter" value="<%= @filter %>"><% end %>
+                <label for="fact-rejection-note">Reason for rejection <span class="muted">(optional)</span></label>
+                <textarea id="fact-rejection-note" name="note" rows="2" placeholder="Why should this fact not be saved?"></textarea>
+                <button type="submit" class="danger" data-turbo-submits-with="Rejecting…">Reject</button>
+              </form>
+              <form method="post" action="/studio/facts/resolve" data-turbo-frame="_top">
+                <%== csrf_tag %>
+                <input type="hidden" name="proposal_id" value="<%= @selected.id %>">
+                <input type="hidden" name="decision" value="dismissed">
+                <% if @filter %><input type="hidden" name="filter" value="<%= @filter %>"><% end %>
+                <button type="submit" class="ghost" data-turbo-submits-with="Dismissing…">Dismiss without a reason</button>
+              </form>
+            </details>
+          </section>
+        <% elsif @selected.status == "stale" %>
+          <section class="card fact-decision" aria-labelledby="fact-decision-title">
+            <h3 id="fact-decision-title">Memory changed since this proposal</h3>
+            <p class="muted">Your edit was kept. This proposal has not overwritten it.</p>
+            <dl class="fact-comparison">
+              <div><dt>Proposed value</dt><dd><s><%= @selected.value %></s></dd></div>
+              <div><dt>Current value</dt><dd><%= @selected.current_value %></dd></div>
+            </dl>
+            <form method="post" action="/studio/facts/resolve" data-turbo-frame="_top">
+              <%== csrf_tag %>
+              <input type="hidden" name="proposal_id" value="<%= @selected.id %>">
+              <input type="hidden" name="decision" value="dismissed">
+              <% if @filter %><input type="hidden" name="filter" value="<%= @filter %>"><% end %>
+              <button type="submit" class="secondary" data-turbo-submits-with="Dismissing…">Dismiss outdated proposal</button>
+            </form>
+          </section>
+        <% else %>
+          <section class="card fact-decision" aria-label="Resolution">
+            <h3><%= @selected.status == "approved" ? "Saved to memory" : "Not saved to memory" %></h3>
+            <p class="muted">Resolved by <%= @selected.operator %>.</p>
+            <% if @selected.note && !@selected.note.to_s.empty? %><p class="fact-resolution-note"><%= @selected.note %></p><% end %>
+          </section>
+        <% end %>
+
+        <details class="fact-metadata">
+          <summary>Technical details</summary>
+          <dl>
+            <div><dt>Memory key</dt><dd><code><%= @selected.key %></code></dd></div>
+            <div><dt>Memory scope</dt><dd><%= @selected.scope %></dd></div>
+            <div><dt>Source session</dt><dd><%= @selected.session_ref %></dd></div>
+            <div><dt>Proposal ID</dt><dd><%= @selected.id %></dd></div>
+          </dl>
+        </details>
+      </div>
+    </div>
+  <% end %>
+</turbo-frame>

data/lib/insika/studio/views/facts.erb

@@ -1,133 +1,32 @@
 <%# the Facts (wiki) page — the human gate on distilled proposals.
    Nothing is ever applied automatically: each pending fact needs a click.
-   Reads ProposalStore + SessionStore directly (evidence is a link, never a
+   Console shell: one queue (pending, then stale, then recent) on the left,
+   the selected fact's evidence + actions on the right — see _facts_master.erb
+   and fact_detail.erb for the shared miller-column pieces. Reads
+   ProposalStore + SessionStore directly (evidence is a link, never a
    copy — D7); the approve/reject/dismiss mutations dispatch :resolve_proposal
    on the bus. %>
-<header class="page-head">
+<header class="page-head facts-head">
   <div>
-    <nav class="crumbs"><span>operate</span></nav>
-    <h1>Facts<span class="sub">distilled customer facts, human-gated</span></h1>
+    <%== crumbs_for("Facts") %>
+    <h1>Facts<span class="sub">Review what your agents remember</span></h1>
   </div>
   <div class="head-actions">
     <form method="get" action="/studio/facts" class="actions inline">
       <label>
         Agent / scope
-        <select name="agent" data-controller="auto-submit" data-action="change->auto-submit#submit">
-          <option value="">all</option>
-          <% @stores.each do |scope| %>
-            <option value="<%= scope %>"<%== ' selected' if scope == @filter %>><%= scope %></option>
-          <% end %>
-        </select>
+        <%== render("_agent_picker", locals: { name: "agent", options: @stores, value: @filter, blank: "All agents / scopes — type to search", auto_submit: true }) %>
       </label>
     </form>
   </div>
 </header>
 
 <% if insika[:proposal_store].nil? %>
-  <div class="empty">
-    Distillation is off — nothing distills until an agent declares a
-    <span class="mono">distill:</span> block in its pack.
-  </div>
-<% elsif @pending.empty? && @stale.empty? && @recent.empty? %>
-  <div class="empty">
-    No proposals yet — facts appear here when a session's traffic is distilled.
-    Nothing is ever applied automatically.
-  </div>
+  <%== render("_empty", locals: { icon: :facts,
+                                  text: "Distillation is off — nothing distills until an agent declares a distill: block in its pack." }) %>
 <% else %>
-  <% unless @pending.empty? %>
-    <h2>Pending<span class="sub">oldest first — evidence ages</span></h2>
-    <% @pending.each do |p| %>
-      <div class="card">
-        <div class="section-head">
-          <h3><span class="mono"><%= p.key %></span> = <strong><%= p.value %></strong>
-            <% if p.confidence %><span class="pill info"><%= format("%.2f", p.confidence) %></span><% end %>
-          </h3>
-          <span class="muted"><%= p.scope %> · <a href="/studio/sessions/<%= Rack::Utils.escape(p.session_ref) %>"><%= p.session_ref %></a></span>
-        </div>
-        <% excerpt = proposal_excerpt(p) %>
-        <% unless excerpt.empty? %>
-          <div class="skill-desc muted">
-            <% excerpt.each do |line| %>
-              <div class="evidence"><%= line %></div>
-            <% end %>
-          </div>
-        <% end %>
-        <div class="actions">
-          <form method="post" action="/studio/facts/resolve" class="inline">
-            <%== csrf_tag %>
-            <input type="hidden" name="proposal_id" value="<%= p.id %>">
-            <input type="hidden" name="decision" value="approved">
-            <% if @filter %><input type="hidden" name="filter" value="<%= @filter %>"><% end %>
-            <button type="submit" class="primary">Approve &amp; save to memory</button>
-          </form>
-          <form method="post" action="/studio/facts/resolve" class="inline">
-            <%== csrf_tag %>
-            <input type="hidden" name="proposal_id" value="<%= p.id %>">
-            <input type="hidden" name="decision" value="rejected">
-            <% if @filter %><input type="hidden" name="filter" value="<%= @filter %>"><% end %>
-            <input type="text" name="note" placeholder="reason (optional)">
-            <button type="submit" class="secondary">Reject</button>
-          </form>
-          <form method="post" action="/studio/facts/resolve" class="inline">
-            <%== csrf_tag %>
-            <input type="hidden" name="proposal_id" value="<%= p.id %>">
-            <input type="hidden" name="decision" value="dismissed">
-            <% if @filter %><input type="hidden" name="filter" value="<%= @filter %>"><% end %>
-            <button type="submit" class="ghost">Dismiss<span class="muted"> — will not be proposed again</span></button>
-          </form>
-        </div>
-      </div>
-    <% end %>
-  <% end %>
-
-  <% unless @stale.empty? %>
-    <h2>Stale<span class="sub">the fact moved after this was distilled — the operator's edit wins (CAS)</span></h2>
-    <% @stale.each do |p| %>
-      <div class="card">
-        <div class="section-head">
-          <h3>
-            <span class="mono"><%= p.key %></span> =
-            <s><%= p.value %></s>
-            <span class="pill warn"><%= p.current_value %></span>
-            <span class="muted">(your edit)</span>
-          </h3>
-          <span class="muted"><%= p.scope %> · <a href="/studio/sessions/<%= Rack::Utils.escape(p.session_ref) %>"><%= p.session_ref %></a></span>
-        </div>
-        <div class="skill-desc">
-          The proposed value was not applied — the fact stands as you left it.
-        </div>
-        <div class="actions">
-          <form method="post" action="/studio/facts/resolve" class="inline">
-            <%== csrf_tag %>
-            <input type="hidden" name="proposal_id" value="<%= p.id %>">
-            <input type="hidden" name="decision" value="dismissed">
-            <% if @filter %><input type="hidden" name="filter" value="<%= @filter %>"><% end %>
-            <button type="submit" class="ghost">Dismiss<span class="muted"> — resolve the re-present</span></button>
-          </form>
-        </div>
-      </div>
-    <% end %>
-  <% end %>
-
-  <% unless @recent.empty? %>
-    <h2>Recent<span class="sub">resolved, most recent first</span></h2>
-    <div class="card">
-      <table>
-        <thead>
-          <tr><th>fact</th><th>status</th><th>by</th><th>note</th><th>session</th></tr>
-        </thead>
-        <tbody>
-          <% @recent.first(20).each do |p| %>
-            <tr>
-              <td><span class="mono"><%= p.key %></span> = <%= p.value %></td>
-              <td><span class="pill <%= %w[approved].include?(p.status) ? 'ok' : 'info' %>"><%= p.status %></span></td>
-              <td><%= p.operator %></td>
-              <td class="muted"><%= p.note %></td>
-              <td><a href="/studio/sessions/<%= Rack::Utils.escape(p.session_ref) %>"><%= p.session_ref %></a></td>
-            </tr>
-          <% end %>
-        </tbody>
-      </table>
-    </div>
-  <% end %>
-<% end %>
+  <div class="drill facts-workspace" data-controller="list-filter">
+    <%== render("_facts_master", locals: { active_id: @selected&.id }) %>
+    <%== render("fact_detail") %>
+  </div>
+<% end %>

data/lib/insika/studio/views/followups.erb

@@ -1,36 +1,45 @@
-<%# the Follow-ups page. Reads the FollowupStore/ContactStore/
-   OutcomeStore directly (D10); the ONLY mutations — cancel a pending record,
-   force-revoke a contact — dispatch bus commands. Nothing here is engine
-   vocabulary: the arm names, the reasons and the policy values are the pack's
-   (D1/D8). %>
-<header class="page-head">
+<%# the Follow-ups page — the Board shell: a KPI strip that opens the page
+   (pending/fired/cancelled/blocked, scoped to whatever the agent filter
+   currently shows) followed by one ledger + A/B card per declaring agent.
+   Reads the FollowupStore/ContactStore/OutcomeStore directly (D10); the
+   ONLY mutations — cancel a pending record, force-revoke a contact —
+   dispatch bus commands. Nothing here is engine vocabulary: the arm names,
+   the reasons and the policy values are the pack's (D1/D8). %>
+<header class="page-head operation-head">
   <div>
-    <nav class="crumbs"><span>operate</span></nav>
-    <h1>Follow-ups<span class="sub">scheduled, fired, blocked, cancelled — per agent</span></h1>
+    <%== crumbs_for("Follow-ups") %>
+    <h1>Follow-ups<span class="sub">Review scheduled messages and delivery history</span></h1>
   </div>
   <div class="head-actions">
     <%== agent_filter_form("/studio/followups", @agent) %>
   </div>
 </header>
 
+<% all_records = @stores.flat_map { |s| s[:records] } %>
+<div class="kpi-strip">
+  <%== render("_kpi", locals: { label: "Pending", value: all_records.count { |r| r.status == "pending" } }) %>
+  <%== render("_kpi", locals: { label: "Fired", value: all_records.count { |r| r.status == "fired" } }) %>
+  <%== render("_kpi", locals: { label: "Cancelled", value: all_records.count { |r| r.status == "cancelled" } }) %>
+  <%== render("_kpi", locals: { label: "Blocked", value: all_records.count { |r| r.status == "blocked" } }) %>
+</div>
+
 <% if !@has_followups %>
-  <div class="empty">
-    No follow-ups — add a <span class="mono">followup:</span> block to an agent's pack and
-    the records it schedules land here.
-  </div>
+  <%== render("_empty", locals: { icon: :followups,
+    text: "No follow-ups — add a followup: block to an agent's pack and the records it schedules land here." }) %>
 <% else %>
+  <div class="operation-followups" data-controller="list-filter">
+    <div class="filter-bar">
+      <input type="search" class="filter-input" placeholder="Filter by customer, reason or status…" aria-label="Filter follow-ups"
+             data-list-filter-target="query" data-action="input->list-filter#filter keydown->list-filter#clear">
+      <span class="filter-count mono muted" data-list-filter-target="count"></span>
+    </div>
   <% @stores.each do |store| %>
     <% profile, policy, records = store[:profile], store[:policy], store[:records] %>
-    <% pending   = records.select { |r| r.status == "pending" } %>
-    <% fired     = records.select { |r| r.status == "fired" } %>
-    <% cancelled = records.select { |r| r.status == "cancelled" } %>
-    <% blocked   = records.select { |r| r.status == "blocked" } %>
-    <h2><%= profile.id %><span class="sub">arm <strong><%= policy.arm %></strong> · <%= policy.cancel_keywords.size %> keyword(s) · silence after <%= policy.silence_after_sends %> send(s)</span></h2>
+    <h2><a href="<%= agent_path(profile.id) %>"><%= profile.id %></a><span class="sub"><%= records.count { |r| r.status == "pending" } %> pending · <%= records.size %> records</span></h2>
 
-    <div class="card">
+    <div class="card operation-table">
       <div class="section-head">
         <h3>Schedule records</h3>
-        <span class="muted"><%= pending.size %> pending · <%= fired.size %> fired · <%= cancelled.size %> cancelled · <%= blocked.size %> blocked</span>
       </div>
 
       <% if records.empty? %>
@@ -39,39 +48,35 @@
         <table class="grid">
           <thead>
             <tr>
-              <th>customer</th><th>at</th><th>reason</th><th>arm</th><th>status</th><th></th>
+              <th>Customer</th><th>Scheduled for</th><th>Reason</th><th>Arm</th><th>Status</th><th>Actions</th>
             </tr>
           </thead>
           <tbody>
             <% records.each do |r| %>
-              <tr>
-                <td class="mono"><%= r.customer %></td>
+              <tr data-list-filter-target="item" data-filter-text="<%= profile.id %> <%= r.customer %> <%= r.reason %> <%= r.arm %> <%= r.status %> <%= r.blocked_reason %>">
+                <td class="mono"><%= r.customer %><% if presence(r.session_id) %><br><a href="/studio/sessions/<%= Rack::Utils.escape(r.session_id) %>">Conversation ↗</a><% end %></td>
                 <td class="mono"><%= r.at %></td>
                 <td><%= r.reason %></td>
-                <td><span class="pill info"><%= r.arm %></span></td>
+                <td><span class="status info"><%= r.arm %></span></td>
                 <td>
-                  <% if r.status == "pending" %>
-                    <span class="pill warn">pending</span>
-                  <% elsif r.status == "fired" %>
-                    <span class="pill ok">fired</span>
-                  <% elsif r.status == "cancelled" %>
-                    <span class="pill">cancelled</span>
+                  <% if r.status == "blocked" %>
+                    <span class="status <%= status_class(r.status) %>">blocked · <%= r.blocked_reason %></span>
                   <% else %>
-                    <span class="pill error">blocked · <%= r.blocked_reason %></span>
+                    <span class="status <%= status_class(r.status) %>"><%= r.status %></span>
                   <% end %>
                 </td>
-                <td>
+                <td class="row-actions">
                   <% if r.status == "pending" %>
                     <form method="post" action="/studio/followups/<%= Rack::Utils.escape(profile.id) %>/cancel" class="actions">
                       <%== csrf_tag %>
                       <input type="hidden" name="id" value="<%= r.id %>">
-                      <button type="submit" class="danger">Cancel</button>
+                      <button type="submit" class="btn ghost btn-sm danger">Cancel</button>
                     </form>
                     <form method="post" action="/studio/followups/<%= Rack::Utils.escape(profile.id) %>/revoke" class="actions">
                       <%== csrf_tag %>
                       <input type="hidden" name="customer" value="<%= r.customer %>">
                       <input type="hidden" name="tenant" value="<%= r.tenant %>">
-                      <button type="submit" class="danger" title="A channel opt-out event that never arrived — revokes the contact and cancels its pending follow-ups">Revoke contact</button>
+                      <button type="submit" class="btn ghost btn-sm danger" title="A channel opt-out event that never arrived — revokes the contact and cancels its pending follow-ups">Revoke contact</button>
                     </form>
                   <% end %>
                 </td>
@@ -81,40 +86,44 @@
         </table>
       <% end %>
 
-      <div class="section-head" style="margin-top: 1.2rem;">
-        <h3>Policy <span class="muted">pack data — edit it on the agent's pack</span></h3>
-      </div>
-      <div class="skill-desc">
+      <details class="operation-diagnostics">
+        <summary>Follow-up policy</summary>
+        <p class="muted">Arm <strong><%= policy.arm %></strong> · silence after <%= policy.silence_after_sends %> send(s). <a href="<%= agent_path(profile.id, "config", "cfg=followups") %>">Edit policy ↗</a></p>
         <% qh = policy.quiet_hours %>
-        <span class="pill info"><%= qh ? "quiet #{qh.start}-#{qh.end} <#{qh.timezone}>" : "no quiet hours" %></span>
-        <span class="pill info"><%= policy.max_frequency ? "max #{policy.max_frequency}" : "no frequency ceiling" %></span>
-        <span class="muted"><%= policy.cancel_keywords.empty? ? "no cancellation keywords" : "keywords: #{policy.cancel_keywords.join(' · ')}" %></span>
-      </div>
+        <p class="skill-desc">
+          <span class="status info"><%= qh ? "quiet #{qh.start}-#{qh.end} <#{qh.timezone}>" : "no quiet hours" %></span>
+          <span class="status info"><%= policy.max_frequency ? "max #{policy.max_frequency}" : "no frequency ceiling" %></span>
+          <span class="muted"><%= policy.cancel_keywords.empty? ? "no cancellation keywords" : "keywords: #{policy.cancel_keywords.join(' · ')}" %></span>
+        </p>
+      </details>
     </div>
 
-    <%# D3: the A/B card — a READ-ONLY fold over the same records. The ruler
-        outside the card is the operator's   baseline; this card only
-        reads it (the note says so). %>
-    <div class="card">
+    <%# D3: the A/B card — a READ-ONLY fold over the same records. The
+        ruler outside the card is the operator's baseline; this card only
+        reads it (the note says so). A regression spec matches the
+        conversion-% and opt-outs cells' text content ("…100.0%…1…") to
+        prove the opt-out count is arm-scoped, never a global revoked
+        count — it doesn't pin the exact opening-tag markup. %>
+    <div class="card operation-table">
       <div class="section-head">
         <h3>A/B readout <span class="muted">last 30 days · per arm</span></h3>
-        <span class="muted">the A/B is the operator's — the card reads the   baseline</span>
+        <span class="muted">the A/B is the operator's — the card reads the baseline</span>
       </div>
       <% if store[:ab].empty? %>
         <div class="empty">Nothing fired in the period — the readout appears when the engine fires.</div>
       <% else %>
         <table class="grid">
           <thead>
-            <tr><th>arm</th><th>sent</th><th>conversions</th><th>conversion %</th><th>opt-outs</th></tr>
+            <tr><th>arm</th><th class="num">sent</th><th class="num">conversions</th><th class="num">conversion %</th><th>opt-outs</th></tr>
           </thead>
           <tbody>
             <% store[:ab].each do |arm, row| %>
               <tr>
-                <td><span class="pill info"><%= arm %></span></td>
-                <td><%= row[:sent] %></td>
-                <td><%= row[:conversions] %></td>
-                <td><%= row[:sent].zero? ? "—" : format("%.1f", row[:conversions].to_f / row[:sent] * 100) %>%</td>
-                <td><%= row[:opt_outs] %></td>
+                <td><span class="status info"><%= arm %></span></td>
+                <td class="num tnum"><%= row[:sent] %></td>
+                <td class="num tnum"><%= row[:conversions] %></td>
+                <td class="num tnum"><%= row[:sent].zero? ? "—" : format("%.1f", row[:conversions].to_f / row[:sent] * 100) %>%</td>
+                <td class="num tnum"><%= row[:opt_outs] %></td>
               </tr>
             <% end %>
           </tbody>
@@ -122,4 +131,6 @@
       <% end %>
     </div>
   <% end %>
+    <div class="empty" data-list-filter-target="empty" hidden>No follow-ups match your filter.</div>
+  </div>
 <% end %>